[00:04:47] Currently receiving objects from Gerrit at 4 KiB/s [00:05:18] that's slowwwww [00:05:18] on a decent connection: http://www.speedtest.net/result/7375585355.png [00:05:46] now 3 KiB/s [00:06:05] I quite like how it bothers to display it as '3.00 KiB/s' but clearly isn't measuring precisely enough to go into fractions of a KiB [00:06:06] it was fast for me [00:06:18] specifically I'm getting https://gerrit.wikimedia.org/r/operations/debs/nutcracker [00:06:46] meanwhile on labs, virtually instant: Receiving objects: 100% (228/228), 1.16 MiB | 0 bytes/s, done. [00:07:17] Krenair Receiving objects: 100% (228/228), 1.16 MiB | 1.80 MiB/s, done. [00:07:23] for me [00:07:49] Krenair though my connection is only slightly faster then yours http://www.speedtest.net/result/7375587071 [04:52:14] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#4266486 (10Nemo_bis) Discussion is continuing at https://lists.wikimedia.org/pipermail/wikitech-l/2018-June/090086.html [06:02:49] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Operations, 10Patch-For-Review: Upgrade deployment-prep deployment servers to stretch - https://phabricator.wikimedia.org/T192561#4266555 (10Dzahn) Yes, create a new one, apply puppet role and run it would get us back to the state it was in. Tha... [06:28:11] PROBLEM - Puppet errors on deployment-conf03 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [06:47:10] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [06:47:27] (03PS1) 10Legoktm: Configure mariadb to use binary charset/collations [integration/config] - 10https://gerrit.wikimedia.org/r/438152 (https://phabricator.wikimedia.org/T193222) [06:47:35] (03CR) 10jerkins-bot: [V: 04-1] Configure mariadb to use binary charset/collations [integration/config] - 10https://gerrit.wikimedia.org/r/438152 (https://phabricator.wikimedia.org/T193222) (owner: 10Legoktm) [06:51:03] (03PS2) 10Legoktm: Configure mariadb to use binary charset/collations [integration/config] - 10https://gerrit.wikimedia.org/r/438152 (https://phabricator.wikimedia.org/T193222) [07:08:13] RECOVERY - Puppet errors on deployment-conf03 is OK: OK: Less than 1.00% above the threshold [0.0] [07:24:34] (03CR) 10Legoktm: "I copied the settings that jynus provided on T193222#4247329. I tested against the AntiSpoof extension, which passed with quibble-stretch." [integration/config] - 10https://gerrit.wikimedia.org/r/438152 (https://phabricator.wikimedia.org/T193222) (owner: 10Legoktm) [07:35:39] legoktm: awesome :]]] [07:35:46] :))) [07:36:36] and I got wikibase and all to pass quibble [07:36:47] oh that's awesome [07:36:48] there is still a nasty race condition that has to be hunted and fixed [07:37:09] something about session being lost during a selenium test [07:38:32] legoktm: and thank you very much for the extension registration help (namely googlelogin and readinglists at https://phabricator.wikimedia.org/T196567 ) [07:38:50] always :) [07:39:02] actually I was juuust about to sleep when you pinged me :p [07:39:18] good night :) [07:39:39] hopefully I'll poke around with more quibble things tomorrow [07:43:58] legoktm: good night :] [07:44:12] good morning people [07:46:08] !log nuking integration-slave-jessie-1002 jenkins workspaces [07:46:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:50:18] !log github: deleting archived repo https://github.com/wikimedia/mediawiki-extensions-InterwikiIntegration | T196442 [07:50:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:50:20] T196442: Archive the InterwikiIntegration extension - https://phabricator.wikimedia.org/T196442 [08:07:12] Project mwext-phpunit-coverage-publish build #5297: 04FAILURE in 3.7 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/5297/ [08:07:23] (03PS2) 10Hashar: BlueSpice REL1_27 should not depend on ExtJSBase [integration/config] - 10https://gerrit.wikimedia.org/r/437680 (https://phabricator.wikimedia.org/T196454) [08:12:47] (03CR) 10Hashar: [C: 032] BlueSpice REL1_27 should not depend on ExtJSBase [integration/config] - 10https://gerrit.wikimedia.org/r/437680 (https://phabricator.wikimedia.org/T196454) (owner: 10Hashar) [08:15:03] (03Merged) 10jenkins-bot: BlueSpice REL1_27 should not depend on ExtJSBase [integration/config] - 10https://gerrit.wikimedia.org/r/437680 (https://phabricator.wikimedia.org/T196454) (owner: 10Hashar) [08:19:40] Yippee, build fixed! [08:19:41] Project mwext-phpunit-coverage-publish build #5298: 09FIXED in 12 min: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/5298/ [08:26:06] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: Is there a way to specify different different inter-extension-dependencies for REL-Branches? - https://phabricator.wikimedia.org/T196454#4266693 (10hashar) 05Open>03Resolved a:03hashar I have done a recheck of a REL1_27 change https://gerrit.wi... [08:31:36] 10Beta-Cluster-Infrastructure, 10Operations: confd broken on deployment-redis hosts - https://phabricator.wikimedia.org/T196596#4266698 (10Krenair) It looks like uninstalling the default redis-tools version I had put on those hosts to test this (3:3.2.6-1 that came from http://deb.debian.org/debian) and instal... [08:36:46] (03Draft1) 10MarcoAurelio: Mark repository as read only [extensions/EditOwn] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/438207 (https://phabricator.wikimedia.org/T196433) [08:36:49] (03PS2) 10MarcoAurelio: Mark repository as read only [extensions/EditOwn] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/438207 (https://phabricator.wikimedia.org/T196433) [08:37:03] (03CR) 10MarcoAurelio: [V: 032] Mark repository as read only [extensions/EditOwn] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/438207 (https://phabricator.wikimedia.org/T196433) (owner: 10MarcoAurelio) [08:44:50] (03CR) 10Jcrespo: [C: 031] "The client part is not needed, but it doesn't hurt either- in any case it will never affect the server configuration (only command line ut" [integration/config] - 10https://gerrit.wikimedia.org/r/438152 (https://phabricator.wikimedia.org/T193222) (owner: 10Legoktm) [08:59:17] 10Beta-Cluster-Infrastructure: Captchas on beta are blank, so account creation is impossible - https://phabricator.wikimedia.org/T196584#4262415 (10Krenair) I think my work in T196596 has fixed this. Try now [09:23:08] 10Phabricator, 10Release-Engineering-Team, 10Patch-For-Review: Phabricator replica functionality broken, needs port configuration - https://phabricator.wikimedia.org/T196604#4266797 (10jcrespo) [09:47:50] (03CR) 10Hashar: [V: 032] Mark repository as read only [extensions/EditOwn] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/438207 (https://phabricator.wikimedia.org/T196433) (owner: 10MarcoAurelio) [09:47:54] (03CR) 10Hashar: [V: 032 C: 032] Mark repository as read only [extensions/EditOwn] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/438207 (https://phabricator.wikimedia.org/T196433) (owner: 10MarcoAurelio) [09:48:36] !log github: deleting https://github.com/wikimedia/mediawiki-extensions-EditOwn | T196433 [09:48:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:48:39] T196433: Archive the EditOwn extension - https://phabricator.wikimedia.org/T196433 [10:11:58] (03CR) 10Zfilipin: [C: 032] "The job is running fine!" [integration/config] - 10https://gerrit.wikimedia.org/r/437970 (https://phabricator.wikimedia.org/T196374) (owner: 10Hashar) [10:12:35] 10Release-Engineering-Team (Kanban), 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen, 10User-zeljkofilipin: language-screenshots-VisualEditor fails with `stderr: warning: failed to remove cache` - https://phabricator.wikimedia.org/T196374#4266883 (10zeljkofilipin) 05Open>03Resolved The job is run... [10:13:53] (03Merged) 10jenkins-bot: Do not git clean language-screenshots-VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/437970 (https://phabricator.wikimedia.org/T196374) (owner: 10Hashar) [11:44:09] (03PS1) 10Rafidaslam: .gitignore: Add several files to ignore [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/438233 [11:44:11] (03PS1) 10Rafidaslam: __init__.py: Supress unintentional 'true' print in `ansi_codes()` [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/438234 (https://phabricator.wikimedia.org/T195078) [12:11:26] 10Gerrit, 10Release-Engineering-Team: Gerrit plugin "zuul" failed to load - https://phabricator.wikimedia.org/T195176#4266962 (10Krinkle) [12:11:28] 10Gerrit: Gerrit: Plugin "zuul" failed to load - https://phabricator.wikimedia.org/T193990#4266964 (10Krinkle) [12:23:40] 10Phabricator, 10Release-Engineering-Team, 10Patch-For-Review: Phabricator replica functionality broken, needs port configuration - https://phabricator.wikimedia.org/T196604#4266969 (10mmodell) This should be resolved now. Will leave open until I confirm that the dump is updated. [12:32:06] (03PS1) 10WMDE-leszek: Add WikibaseClient-only job for ArticlePlaceholder [integration/config] - 10https://gerrit.wikimedia.org/r/438239 [12:36:18] zeljkof: around on this fine day? [12:36:56] addshore: of horse :D [12:37:44] care to glance @ https://gerrit.wikimedia.org/r/#/c/438240/ quickly [12:37:51] i cant tell what im doing wrong [12:38:09] I get TypeError: Cannot read property 'getRevisionCheckbox' of undefined [12:38:23] at checkRevisionCheckboxAtIndex (C:\Users\adam\dev\git\gerrit\mediawiki\core\tests\selenium\pageobjects\restore.page.js:27:8) [12:39:38] addshore: sorry, in the middle of paperwork/reviews (the last day for reviews, already late with paperwork) :( [12:39:53] I can take a look on Monday [12:40:04] okay, thats fine as long as you dont imediatly spot the issue :) [12:40:29] leszek_wmde: ^^ maybe you could look with your advanced JS knowledge [12:41:10] addshore: I can spend 5 minutes staring at the code :) [12:41:31] zeljkof: that would be perfect, as far as I know im just doing something dumb that javascript doesnt allow me to [12:41:49] but my non JS focused brain says everything looks fine [12:42:23] well, that error message says that in restore.page.js:27 this is not defined [12:42:29] addshore: haha, advanced js knowledge [12:42:48] probably because you do not have `get` at the start of line 8? [12:43:18] my idea complained about get [12:43:30] a getter definition must have no parameters [12:43:36] ah [12:43:37] hm [12:43:46] what does eslint say? [12:43:56] we surely have similar examples [12:43:59] * zeljkof is looking [12:44:17] * zeljkof is nerdsniped [12:44:40] I don't see why it doesn't just work as the methods below do [12:44:44] they all call each other :D [12:45:08] restore calls open, but now checkRevisionCheckboxAtIndex cant call getRevisionCheckbox [12:45:47] try without `this` in line 27? [12:45:55] * zeljkof is just guessing at this point [12:45:59] *tries* [12:46:36] i could try making that get method a static too ... [12:47:01] if I remove the this, I get "getRevisionCheckbox is not defined" [12:47:11] https://phabricator.wikimedia.org/source/mediawiki/browse/master/tests/selenium/pageobjects/edit.page.js [12:47:16] so this page is similar [12:47:45] zeljkof: that selenium job failling with wikibase/echo is killing me https://phabricator.wikimedia.org/T191537 :D [12:47:49] ah no, it just wraps `open` [12:47:56] I cant reproduce it locally :(((( [12:47:58] hashar: :D [12:48:08] hashar: yeah, that's the problem [12:48:24] hmm, zeljkof, well making it static works [12:48:26] similar with video recording broken on the last video :/ [12:48:34] https://www.irccloud.com/pastebin/G3x2VkNE/ [12:48:41] addshore: ask Krinkle :D [12:48:43] I'll just keep doing that for now [12:48:52] 10Phabricator, 10Release-Engineering-Team (Kanban), 10DBA, 10Documentation: Prepare a disaster recovery plan for failing over from phab1001 to phab2001 (or phab2001 to 1001) - https://phabricator.wikimedia.org/T190572#4266986 (10jcrespo) [12:49:02] :D [12:49:04] * addshore goes for lunch [12:49:07] addshore: do it, we can fix it later, but I am sure I've seen similar code somewhere [12:49:15] maybe in an extension... [12:49:21] * zeljkof is back to paperwork :/ [12:49:24] addshore: isn't the problem that this in forEach is not the this you would have expected to be? or something like this? [12:49:38] addshore: i mean because of foreach [12:50:21] 10Phabricator, 10Release-Engineering-Team (Kanban), 10DBA, 10Documentation: Prepare a disaster recovery plan for failing over from phab1001 to phab2001 (or phab2001 to 1001) - https://phabricator.wikimedia.org/T190572#4266990 (10mmodell) note: the steps are a bit different for failing over between data cen... [12:51:44] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: Provide cross-dc redundancy (active-active or active-passive) to all important misc services - https://phabricator.wikimedia.org/T156937#4266993 (10jcrespo) [12:52:11] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: Provide cross-dc redundancy (active-active or active-passive) to all important misc services - https://phabricator.wikimedia.org/T156937#2990470 (10jcrespo) [12:52:34] leszek_wmde: well, thats why i stopped doing a foreach initially, and switched to a for [12:52:45] but maybe the same thing happens? [12:52:47] silly this [12:57:28] 10Phabricator, 10Release-Engineering-Team (Kanban), 10DBA, 10Documentation: Prepare a disaster recovery plan for failing over from phab1001 to phab2001 (or phab2001 to 1001) - https://phabricator.wikimedia.org/T190572#4266998 (10mmodell) [12:57:44] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4266999 (10hashar) Thank you @Anomie... [13:07:54] leszek_wmde: zeljkof lunch helped... I left the foreach in below the for I tried to replace it with.... works no [13:07:56] *now [13:08:05] thats what happens when you get hungry [13:11:09] anomie is a hero [13:11:19] I used to be on the same team as him [13:11:28] and to this day, I still have no idea how he magically figure out issues [13:15:35] 10Project-Admins: Rename Wikimedia project tags in Phab (#Wikisource; #Wiktionary) to clarify that they are not about language specific instances? - https://phabricator.wikimedia.org/T196740#4267022 (10Aklapper) p:05Triage>03Lowest [13:31:03] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4267064 (10hashar) From https://integr... [13:31:40] zeljkof: so hmm seems some page request is not completed by the time a new one start :/ [13:32:16] the one I looked at is requesting Special:Preferences as a normal user that continues acting after the Echo test logged in as Wikiadmin [13:32:23] and I guess that mess up the session/cookie [13:41:21] Ouch [13:47:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4267086 (10hashar) For the HHVM job th... [13:47:43] zeljkof: dont we close the web browser between tests ? [13:47:53] I mean using the wdio selenium tests [13:48:12] hashar: between specs [13:48:27] I am not sure what is going on really :/ [13:48:37] browser is reused for the tests in the same file, but cookies are deleted after each test [13:49:23] somehow it is messed up. But maybe my analysis is wrong [13:53:27] 10Scap, 10Operations, 10Patch-For-Review: Update Debian Package for Scap3 to 3.8.2-1 - https://phabricator.wikimedia.org/T196710#4267096 (10mobrovac) [14:06:00] ahhh [14:19:43] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4267131 (10hashar) So I think the `POS... [14:32:17] 10Phabricator, 10Developer-Relations (Apr-Jun-2018), 10Patch-For-Review: Try to identify new developers (via assignee field) in Phab tasks and potentially follow up - https://phabricator.wikimedia.org/T195780#4267170 (10Aklapper) Last SQL idea: Find a way to avoid querying expensive `phabricator_maniphest.ma... [14:54:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4267202 (10hashar) Maybe I will try to... [15:27:43] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:33:42] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:29:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4267506 (10Anomie) >>! In T191537#4267... [16:30:26] no_justification the disable private change feature works! [16:30:39] in polygerrit it will still show the check box but it won't work [16:31:00] :) [16:31:25] i think i fixed that [16:31:25] no_justification: eta? eta? eta? :) :) [16:32:00] Soon as I walk the dog :) [16:32:06] Gonna do it this AM [16:32:10] :) [16:32:48] all drafts will be made WIPs :) [16:32:58] that is the default behavour at least [16:33:05] it will ask you either wip or private [16:37:06] anyways upstream now backports bug fixes to polygerrit for 2.15 (as it is offically supported by there team now) [16:37:52] 10Project-Admins, 10PAWS: Create "JupyterHub 0.9" milestone for PAWS project - https://phabricator.wikimedia.org/T196559#4267517 (10bd808) 05Open>03Resolved https://phabricator.wikimedia.org/project/view/3414/ [16:39:06] ohhh [16:39:15] i just realised "Require a valid contributor agreement to upload" needs to be in a check [16:39:25] that should not work even if someone ticks it [16:39:29] but heh it is shown now :) [16:39:47] meh it works [16:43:20] there is the emojie switcher too [16:43:27] if you do : [16:49:20] 10Beta-Cluster-Infrastructure: Captchas on beta are blank, so account creation is impossible - https://phabricator.wikimedia.org/T196584#4267536 (10cscott) 05Open>03Resolved a:03cscott Yup, seems to work now. Thanks! [16:54:32] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4267565 (10hashar) Yup, I think the fl... [17:10:00] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Math, and 3 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4267600 (10Anomie) >>! In T191537#4267... [17:13:49] Project beta-code-update-eqiad build #208557: 04FAILURE in 48 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208557/ [17:15:46] PROBLEM - Puppet errors on deployment-sentry01 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [17:17:08] beta-code-update due to gerrit downtime ^ [17:21:57] PROBLEM - Puppet errors on saucelabs-02 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [17:22:57] PROBLEM - Puppet errors on integration-slave-jessie-1001 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [17:23:22] PROBLEM - Puppet errors on integration-slave-jessie-1004 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [17:23:51] Yippee, build fixed! [17:23:52] Project beta-code-update-eqiad build #208558: 09FIXED in 51 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208558/ [17:24:57] 10Beta-Cluster-Infrastructure, 10Cloud-Services, 10PAWS, 10Wikidata, 10Wikimedia-Logstash: Remove puppet class role::labs::lvm::mnt - https://phabricator.wikimedia.org/T178722#3700748 (10Chicocvenancio) PAWS uses `role::labs::lvm::mnt` with the `mount_point` being directed at `/var/lib/docker` instead of... [17:30:37] something wrong with gerrit? gives me 'is:wip' operator is not supported by change index version [17:30:55] SMalyshev hi, known :) [17:30:59] see -operations [17:31:06] ah, ok [17:31:08] thanks [17:53:11] (03CR) 10Legoktm: [C: 032] Configure mariadb to use binary charset/collations [integration/config] - 10https://gerrit.wikimedia.org/r/438152 (https://phabricator.wikimedia.org/T193222) (owner: 10Legoktm) [17:54:53] (03Merged) 10jenkins-bot: Configure mariadb to use binary charset/collations [integration/config] - 10https://gerrit.wikimedia.org/r/438152 (https://phabricator.wikimedia.org/T193222) (owner: 10Legoktm) [17:55:46] RECOVERY - Puppet errors on deployment-sentry01 is OK: OK: Less than 1.00% above the threshold [0.0] [17:57:59] RECOVERY - Puppet errors on integration-slave-jessie-1001 is OK: OK: Less than 1.00% above the threshold [0.0] [17:58:19] RECOVERY - Puppet errors on integration-slave-jessie-1004 is OK: OK: Less than 1.00% above the threshold [0.0] [18:01:55] RECOVERY - Puppet errors on saucelabs-02 is OK: OK: Less than 1.00% above the threshold [0.0] [18:05:16] !log updating docker files for https://gerrit.wikimedia.org/r/438152 [18:05:18] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:09:03] (03CR) 10Thiemo Kreuz (WMDE): "I run into this when I got a misplaced message complaining about a @license tag "only being allowed in file comments" on a perfectly valid" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/438031 (owner: 10Thiemo Kreuz (WMDE)) [18:14:25] (03CR) 10Legoktm: "> @license tags must be allowed in class-level comments" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/438031 (owner: 10Thiemo Kreuz (WMDE)) [18:28:59] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10releng-201718-q3, 10Epic, 10Patch-For-Review: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker - https://phabricator.wikimedia.org/T183512#4267827 (10hashar) [18:39:23] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:47:01] Code Review - Error'is:wip' operator is not supported by change index version [18:47:09] so says gerrit, shall reload [18:47:42] answer may be just wait a while. scripts running [18:47:48] fail fail [18:47:56] reload or new tab does not help [18:47:58] ah well [18:48:10] heh, apergos try polygerrit [18:48:15] it's mostley complete [18:48:20] with a updated ui compared to 2.14 [18:48:26] give me a url [18:48:41] apergos https://gerrit.wikimedia.org/r/?polygerrit=1 [18:49:04] though the switcher is in the footer to make it easy for users :) [18:49:06] in both ui's [18:49:10] Server error: 'is:wip' operator is not supported by change index version [18:49:15] fails to load anything [18:49:34] well I couldn't get to the switcher in the other url because it does not finish loading there either [18:49:43] so not polygerrit either [18:49:49] yep [18:51:59] (03CR) 10Thiemo Kreuz (WMDE): "I don't think you can disagree on that, because that's where the vast majority of @license tags is in the code we maintain, as I just said" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/438031 (owner: 10Thiemo Kreuz (WMDE)) [19:06:37] (03PS1) 10Legoktm: Bump Quibble to 0.0.18-1 [integration/config] - 10https://gerrit.wikimedia.org/r/439286 [19:08:24] 10Gerrit: Cannot access self dashboard after 2.15 upgrade - https://phabricator.wikimedia.org/T196768#4267911 (10MarcoAurelio) [19:09:06] 10Gerrit: Cannot access self dashboard after 2.15 upgrade - https://phabricator.wikimedia.org/T196768#4267924 (10Paladox) Hi, this is known, we are running the online upgrade reindexed which will take time due to the amount of repos we have. [19:09:30] solution: delete most of the repos [19:10:05] lol [19:10:27] heh notedb switched on for https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/438031 [19:10:32] 10Gerrit: Cannot access self dashboard after 2.15 upgrade - https://phabricator.wikimedia.org/T196768#4267926 (10MarcoAurelio) Okay. Let's check after the reindex. [19:10:36] so you can use hashtags now [19:10:39] and emojie's [19:10:42] and also cc [19:10:51] * Hauskatze looks with disaproval [19:11:06] see https://gerrit-review.googlesource.com/c/homepage/+/183493 [19:11:17] hashtags and emoji... are we that dump called twitter now? [19:11:25] heh [19:11:44] https://gerrit-review.googlesource.com/Documentation/intro-user.html#hashtags [19:13:12] and are "private" changes also supported? [19:13:19] we disabled that feature [19:13:45] meh [19:13:55] :) [19:14:03] you can use the WIP feature though [19:14:10] that prevents anyone from merging it [19:15:16] I was thinking it'd be useful for private security instead of posting the raw code in a phabricator comment [19:15:25] *private security fixes [19:15:38] well it would be phabricator could pick up the change though [19:15:43] so it would basically be shown [19:16:23] hashar: is it just me, or is jjb slower for everyone else? [19:18:08] I think it's just you [19:18:10] it takes like 2-3 minutes just to deploy one job [19:18:11] ugh [19:18:23] When I did the bumps last weekend for the docker, it was nowhere near as slow as it was for you [19:19:17] jjb hates you legoktm :P [19:19:28] so let's just assign all the job to Reedy [19:45:59] 10MediaWiki-Codesniffer: remove [optional] from parameter docs - https://phabricator.wikimedia.org/T196773#4268031 (10Umherirrender) [19:47:02] 10MediaWiki-Codesniffer: remove [optional] from parameter docs - https://phabricator.wikimedia.org/T196773#4268043 (10Umherirrender) Example result of the autofix: https://gerrit.wikimedia.org/r/#/c/439294/1/includes/Block/Block.php [19:51:59] wow flow has 51,082 Commits now [19:52:11] it's gone up by 20,000 commits since i last checked a few mins ago [19:58:24] 10MediaWiki-Codesniffer: remove [optional] from parameter docs - https://phabricator.wikimedia.org/T196773#4268031 (10Krinkle) I think we should distinguish two separate issues here: 1. Whether we want to have `[optional]` in the description of optional parameters. 2. Whether to fix incorrect use of `[optional... [19:59:22] paladox: It only shows 275 commits here - https://github.com/wikimedia/mediawiki-extensions-Flow/tree/b5289c [19:59:29] yeh [19:59:36] that's because it dosen't have notedb :) [19:59:46] it's not replicating the notedb refs [20:00:10] it has 78,000 refs now [20:00:33] so the reindex is still in progress [20:00:49] yep [20:01:55] Here it says 1337 commits https://github.com/wikimedia/mediawiki-extensions-Flow/tree/2b8af33fa [20:02:16] see on phab [20:02:40] Krinkle https://phabricator.wikimedia.org/F19133124 [20:03:06] They do not affect GitHub's tree history marker [20:03:11] nope [20:03:21] because we doin't replicate refs/meta/* (changes) [20:03:30] It does not relate to that. [20:03:48] Mediawiki just went from 226,194 to 354,966 Commits [20:03:50] It does not affect the tree-based commit count, but tree-based commit counts only count the commits within that tree. [20:03:53] Not entirely repository. [20:03:59] yep [20:04:16] Compare https://github.com/wikimedia/mediawiki-extensions-Flow/tree/REL1_30 and https://github.com/wikimedia/mediawiki-extensions-Flow/tree/REL1_31 [20:04:53] ok [20:08:38] (03PS1) 10Legoktm: Upgrade squizlabs/php_codesniffer to 3.3.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439297 [20:08:40] (03PS1) 10Legoktm: Add "Generic.PHP.LowerCaseType" to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439298 [20:08:42] (03PS1) 10Legoktm: Use "PSR12.Keywords.ShortFormTypeKeywords" in place of custom sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439299 [20:08:44] (03PS1) 10MarcoAurelio: Mark repository as read only [extensions/DidYouMean] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/439300 (https://phabricator.wikimedia.org/T196430) [20:09:27] (03PS2) 10MarcoAurelio: Mark repository as read only [extensions/DidYouMean] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/439300 (https://phabricator.wikimedia.org/T196430) [20:09:47] (03CR) 10jerkins-bot: [V: 04-1] Use "PSR12.Keywords.ShortFormTypeKeywords" in place of custom sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439299 (owner: 10Legoktm) [20:09:57] (03CR) 10Jforrester: [C: 031] Add "Generic.PHP.LowerCaseType" to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439298 (owner: 10Legoktm) [20:10:01] (03CR) 10jerkins-bot: [V: 04-1] Upgrade squizlabs/php_codesniffer to 3.3.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439297 (owner: 10Legoktm) [20:10:04] (03CR) 10jerkins-bot: [V: 04-1] Add "Generic.PHP.LowerCaseType" to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439298 (owner: 10Legoktm) [20:10:27] (03CR) 10Jforrester: [C: 031] Use "PSR12.Keywords.ShortFormTypeKeywords" in place of custom sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439299 (owner: 10Legoktm) [20:13:01] (03CR) 10Legoktm: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439297 (owner: 10Legoktm) [20:14:05] (03CR) 10jerkins-bot: [V: 04-1] Upgrade squizlabs/php_codesniffer to 3.3.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439297 (owner: 10Legoktm) [20:14:08] 10Phabricator, 10Release-Engineering-Team, 10Patch-For-Review: Phabricator replica functionality broken, needs port configuration - https://phabricator.wikimedia.org/T196604#4268140 (10mmodell) 05Open>03Resolved a:03mmodell ``` twentyafterfour@phab1001:~$ ls /srv/dumps/ -la total 1050732 drwxr-xr-x 2 r... [20:14:43] Reedy: do you want to deploy https://gerrit.wikimedia.org/r/439286 for me? this is stupid [20:14:46] wait no [20:14:57] Reedy: once I pinged you, it started going fast [20:14:58] <3 [20:15:04] haha [20:15:07] It knew it was in trouble [20:15:21] I switched it over to python3 and it seems to work fine now [20:15:59] (03CR) 10Legoktm: [C: 032] Bump Quibble to 0.0.18-1 [integration/config] - 10https://gerrit.wikimedia.org/r/439286 (owner: 10Legoktm) [20:18:23] (03Merged) 10jenkins-bot: Bump Quibble to 0.0.18-1 [integration/config] - 10https://gerrit.wikimedia.org/r/439286 (owner: 10Legoktm) [20:19:29] heh [20:21:48] Does anyone know why this patch has a "Cannot Merge" error message on it? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageSchemas/+/439288/ [20:22:13] Yaron you have set it as a WIP [20:22:16] click start review [20:22:18] button [20:22:46] paladox: thanks, it's looking better already! [20:22:52] :) [20:23:08] Do you know why I needed to press that button? Was there some change to the Gerrit settings, or something? [20:23:17] yep [20:23:21] we upgraded to gerrit 2.15 [20:23:22] today [20:23:30] and now the create dialog defaults to WIP [20:23:37] because drafts was removed [20:23:45] and split into private and WIP features [20:25:50] (patches submitted via bash are not marked as WIP - which is good) [20:25:58] yep [20:26:06] though you can set it through bash if you want [20:26:06] (03PS2) 10Legoktm: Upgrade squizlabs/php_codesniffer to 3.3.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439297 [20:26:08] (03PS2) 10Legoktm: Add "Generic.PHP.LowerCaseType" to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439298 [20:26:10] (03PS2) 10Legoktm: Use "PSR12.Keywords.ShortFormTypeKeywords" in place of custom sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439299 [20:26:12] or even publish comments on push too [20:26:20] oh? [20:26:33] git review saying that refs/publish/* is deprecated [20:26:45] but other than that, it's working fine for now [20:26:57] Hauskatze https://gerrit-review.googlesource.com/Documentation/intro-user.html#wip [20:27:55] Hauskatze https://gerrit-review.googlesource.com/c/gerrit/+/131630 [20:29:08] James_F: I got the tests to pass now :) [20:29:26] paladox: thanky [20:29:31] your welcome :) [20:29:33] legoktm: Show-off. :-) [20:30:05] (03CR) 10Jforrester: [C: 031] Upgrade squizlabs/php_codesniffer to 3.3.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/439297 (owner: 10Legoktm) [20:30:32] :) [20:31:26] woa mobilefrontend has 166,629 Commits [20:32:29] Are you sure? [20:32:31] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend [20:32:35] 14,205 [20:32:47] Is it counting commits in different branches are unique commits? [20:32:47] Reedy on phab! [20:33:04] i doubt phab is right if it's over 10 times larger [20:33:26] 10Beta-Cluster-Infrastructure: Captchas on beta are blank, so account creation is impossible - https://phabricator.wikimedia.org/T196584#4268206 (10Krenair) a:05cscott>03Krenair [20:33:27] Reedy refs/meta/* [20:33:33] is storing what every is in the db [20:33:36] for changes [20:33:37] now [20:33:43] so comments [20:33:49] and other meta data is in there now [20:33:53] so it counts refs/meta/config and so on [20:34:53] yep [20:35:05] 10Beta-Cluster-Infrastructure, 10Technical-Debt: Set up LVS in beta like prod - https://phabricator.wikimedia.org/T196662#4268212 (10Krenair) [20:35:33] So it hasn't got 166,629 commits then [20:36:28] paladox: very good to know, thanks. [20:36:35] your welcome :) [20:37:15] Reedy yep your correct in one way, but still has that many commits in the repo regardless :) [20:37:40] it's a useless metric [21:05:11] PROBLEM - Free space - all mounts on integration-slave-jessie-1001 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1001.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1001.diskspace._srv.byte_percentfree (<11.11%) [21:27:51] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#4268283 (10Nemo_bis) >>! In T165540#3337553, @Strainu wrote: > I am personally against using the markdown (and implicitly the .m... [21:44:15] looks like the online reindex takes some time :) [21:47:51] paladox: are Administrators allowed to override the Work In Progress tag of a patch? [21:49:00] Hauskatze i think so [21:49:14] ok [22:02:54] 10Release-Engineering-Team (Kanban), 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen, 10User-zeljkofilipin: language-screenshots-VisualEditor fails with `stderr: warning: failed to remove cache` - https://phabricator.wikimedia.org/T196374#4268360 (10hashar) \O/ I guess I did not pay attention in the... [22:10:07] 10Beta-Cluster-Infrastructure, 10Patch-For-Review: Get letsencrypt wildcard cert for *.beta.wmflabs.org domains - https://phabricator.wikimedia.org/T182927#4268369 (10Krenair) [22:12:13] meep, the "new" gerrit interface creeped back into my settings, and I'm not sure how to go back -- anyone knows? [22:12:44] not the new features (that are awesome) I mean the fancy wide-screen very-green-highlight inbox'y interface [22:15:45] mooeypoo the footer should have the switcher [22:16:19] "Switch to old UI" yessss. Thanks paladox [22:16:24] yep [22:16:27] your welcome :) [22:16:48] mooeypoo also note that GWTUI is being removed already disabled upstream. :) [22:17:07] i think they are planning for removal in 3.1 [22:17:16] you mean we'll only have the new? [22:17:21] Eh, I guess I'll have to get used to it [22:17:23] yep [22:17:34] mooeypoo though the ui in 2.16 / 3.0 [22:17:42] is completley different to 2.15 [22:17:46] I don't have anything inherently against it (except the wide-screen does tend to make it slightly less easily readable) but this is a true case of Who Moved My Cheese[tm] [22:17:46] looks alot nicer! [22:18:10] mooeypoo https://gerrit-review.googlesource.com/c/gerrit/+/176190 [22:18:15] that is what it would look like [22:18:16] I like my gerrit old and decrepit, thankyouverymuch [22:18:26] and this is https://docs.google.com/presentation/d/1xOwLICLyDuK8jQYiu6I2Wu0aF0AWCMsnXMqQNz0Kmhw/edit#slide=id.g365f09a753_0_282 a mock ui [22:18:33] yeah I am not a fan of full-width [22:18:40] mooeypoo though gerrit's gained dark mode! [22:19:01] I like when there's a limited width, it's a little easier to read, but I am also not one to go on a riot if I don't get my specifically prefered UI [22:19:19] heh [22:19:34] mooeypoo you could file a issue athttps://phabricator.wikimedia.org/project/view/330/ [22:19:36] https://phabricator.wikimedia.org/project/view/330/ [22:19:41] and we can forward it upstream [22:19:45] who listen to feedback [22:19:53] and change the ui based on the feedback they get [22:20:06] It seems it's a little more than an issue, it's more a design paradigm, but maybe [22:20:31] mooeypoo they have a desgn team behind the scenes heh [22:20:41] To be fair, most of my "omg wtf just happened to my screen" was a gut reaction to things that I automatically look at changing positions [22:20:59] I'm sure I'll get used to looking at the different places automatically [22:21:05] lol [22:21:13] dark theme in 2.15 or .16? [22:21:21] I would personally keep the interface more minimal, but they seem to go at expanded views [22:21:33] greg-g .16 [22:21:39] 3.0 / .16 [22:21:53] they haven't decided which one yet (2.16 at the moment) but could become 3.0 [22:22:19] right right [22:22:25] I was hoping it was .15 for us :) [22:22:45] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Upgrade integration/composer to 1.6.5 stable - https://phabricator.wikimedia.org/T125343#4268383 (10Legoktm) 05Open>03Resolved a:05Paladox>03Reedy [22:22:46] 10Continuous-Integration-Config, 10Wikidata, 10Patch-For-Review, 10Wikidata-Former-Sprint-Board: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins - https://phabricator.wikimedia.org/T158674#4268385 (10Legoktm) [22:22:52] heh :) [22:22:53] they did a bit of refactoring in polygerrit [22:22:55] css vars [22:22:59] to make dark mode possible [22:33:27] well mediawiki has over 799,254 Commits (i think 500,000 are notedb refs) [22:42:49] paladox: I think the way you're using the term "commits" is misleading/wrong [22:43:00] oh [22:43:31] like, it might technically be a commit, but for most people we count commits merged into the repo [22:44:02] ah ok [22:44:04] sorry [22:52:57] PROBLEM - Puppet errors on saucelabs-02 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [22:53:43] Project beta-code-update-eqiad build #208585: 04FAILURE in 42 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208585/ [22:53:59] PROBLEM - Puppet errors on integration-slave-jessie-1001 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [22:54:19] PROBLEM - Puppet errors on integration-slave-jessie-1004 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [22:54:48] what ^ [22:55:50] see --operations [22:56:35] PROBLEM - Puppet errors on integration-slave-jessie-1003 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [23:02:00] PROBLEM - Puppet errors on deployment-kafka-main-2 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [23:02:30] PROBLEM - Puppet errors on deployment-kafka-main-1 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [23:02:48] PROBLEM - Puppet errors on integration-slave-jessie-1002 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [23:02:50] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[git_pull_jenkins CI slave scripts] [23:03:41] Project beta-code-update-eqiad build #208586: 04STILL FAILING in 40 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208586/ [23:07:49] PROBLEM - Puppet errors on deployment-eventlog05 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [23:07:55] PROBLEM - Puppet errors on saucelabs-01 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [23:08:40] PROBLEM - puppet last run on contint1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[git_pull_jenkins CI slave scripts] [23:09:05] PROBLEM - Puppet errors on deployment-webperf11 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [23:09:59] PROBLEM - Puppet errors on saucelabs-03 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [23:13:42] Project beta-code-update-eqiad build #208587: 04STILL FAILING in 41 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208587/ [23:16:45] PROBLEM - Puppet errors on deployment-sentry01 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [23:23:40] Project beta-code-update-eqiad build #208588: 04STILL FAILING in 39 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208588/ [23:33:41] Project beta-code-update-eqiad build #208589: 04STILL FAILING in 40 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208589/ [23:43:43] Project beta-code-update-eqiad build #208590: 04STILL FAILING in 42 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208590/ [23:53:44] Yippee, build fixed! [23:53:44] Project beta-code-update-eqiad build #208591: 09FIXED in 43 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/208591/ [23:58:34] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 1 second ago with 0 failures