[00:17:40] 10MediaWiki-Codesniffer, 10Patch-For-Review: Discourage use of is_null() with PHPCS - https://phabricator.wikimedia.org/T199768 (10Krinkle) @thiemowmde Thanks. I also agree we should have an auto-fix, and it should be able to convert the vast majority of the affected code. [00:54:03] 10Project-Admins: Create a project for PHP .73 support - https://phabricator.wikimedia.org/T200593 (10MaxSem) [00:56:55] 10Release-Engineering-Team (Next), 10Scap: Add some facility to scap for custom logstash canary checks - https://phabricator.wikimedia.org/T198642 (10Krinkle) Moving it out of puppet and into mediawiki-config seems like a good start indeed. > ```lang=yaml > query: ((type:mediawiki AND (channel:exception OR c... [01:30:51] 10Project-Admins: Create a project for PHP .73 support - https://phabricator.wikimedia.org/T200593 (10Krinkle) 05Open>03Resolved a:03Krinkle Done. #php73. [02:09:52] 10Project-Admins: Create a project for PHP 7.3 support - https://phabricator.wikimedia.org/T200593 (10Krinkle) [02:52:18] Krinkle: uhh https://doc.wikimedia.org/cover-extensions/ [02:54:18] found it I think [02:55:25] (03PS1) 10Legoktm: cover: Fix variable reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/448838 [02:56:01] (for later reference https://screenshots.firefox.com/4CccxsGPKONemyqp/doc.wikimedia.org) [02:56:10] (03CR) 10Legoktm: [C: 032] cover: Fix variable reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/448838 (owner: 10Legoktm) [02:56:41] (03Merged) 10jenkins-bot: cover: Fix variable reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/448838 (owner: 10Legoktm) [02:56:47] (03CR) 10jenkins-bot: cover: Fix variable reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/448838 (owner: 10Legoktm) [03:24:03] !log legoktm@contint1001:/srv/org/wikimedia/doc/cover-extensions$ sudo -u jenkins-slave rm -rf EtherEditor/ # T197698 [03:24:07] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:24:07] T197698: Archive the EtherEditor extension - https://phabricator.wikimedia.org/T197698 [06:29:17] PROBLEM - Puppet errors on deployment-zotero01 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [06:34:24] PROBLEM - Puppet errors on deployment-deploy01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [07:04:13] RECOVERY - Puppet errors on deployment-zotero01 is OK: OK: Less than 1.00% above the threshold [0.0] [07:09:24] RECOVERY - Puppet errors on deployment-deploy01 is OK: OK: Less than 1.00% above the threshold [0.0] [11:49:41] my phabricator account is deactivated. I request help [12:14:09] (see -devtools) [12:38:21] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [13:18:20] RECOVERY - Puppet errors on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [14:42:00] cumin on deployment-cumin is broken [14:42:54] 10Beta-Cluster-Infrastructure: cumin on deployment-cumin is broken - https://phabricator.wikimedia.org/T200608 (10Krenair) [14:50:37] 10Beta-Cluster-Infrastructure: cumin on deployment-cumin is broken - https://phabricator.wikimedia.org/T200608 (10Krenair) I found this in /var/log/apt/history.log: ```Start-Date: 2018-07-20 06:29:50 Commandline: /usr/bin/unattended-upgrade Install: python3-clustershell:amd64 (1.8-1~wmf1, automatic) Upgrade: cl... [15:05:16] 10Beta-Cluster-Infrastructure: cumin on deployment-cumin is broken - https://phabricator.wikimedia.org/T200608 (10Krenair) Possibly related to T187773 [15:07:21] 10Continuous-Integration-Infrastructure, 10Operations-Software-Development, 10Patch-For-Review: cumin 3.0.1-1 is broken on labs master - https://phabricator.wikimedia.org/T188112 (10Krenair) Broken again in T200608 ? [15:10:51] 10MediaWiki-Codesniffer: Uses of Wikimedia\suppressWarnings(); should be preceded by a comment documenting why - https://phabricator.wikimedia.org/T200611 (10Jdforrester-WMF) [15:12:18] 10Beta-Cluster-Infrastructure: cumin on deployment-cumin is broken - https://phabricator.wikimedia.org/T200608 (10Krenair) Ah, the cumin package was being kept back and was therefore out of date: ```root@deployment-cumin:~# apt-cache policy cumin cumin: Installed: 2.0.0-1 Candidate: 3.0.1-1 Version table:... [15:12:31] 10Beta-Cluster-Infrastructure: cumin on deployment-cumin is broken - https://phabricator.wikimedia.org/T200608 (10Krenair) 05Open>03Resolved a:03Krenair [15:59:46] (03PS1) 10Legoktm: Move OAuthAuthentication to composer unittests (#2) [integration/config] - 10https://gerrit.wikimedia.org/r/448858 [19:07:09] legoktm: Would merge if you +1 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/LabeledSectionTransclusion/+/445059/ [20:14:54] 10Beta-Cluster-Infrastructure: cumin on deployment-cumin is broken - https://phabricator.wikimedia.org/T200608 (10hashar) Sorry I have forgot to take care of the deployment-prep cumin master :/ In T188112 volans did take care of the puppet boilerplate but I only looked at the integration cumin master. At least... [21:03:36] Krinkle: oops sorry [21:03:53] I think I just wanted to edit the commit message [21:07:31] Krinkle: +1'd [21:18:22] 10Beta-Cluster-Infrastructure: cumin on deployment-cumin is broken - https://phabricator.wikimedia.org/T200608 (10Krenair) According to https://tools.wmflabs.org/openstack-browser/puppetclass/profile::openstack::main::cumin::master, cumin is also used by af-puppetmaster02.automation-framework.eqiad.wmflabs as we... [21:28:51] think the cumin changes may also have broken --output json [21:48:35] 10MediaWiki-Codesniffer, 10at-ease: Uses of Wikimedia\suppressWarnings(); should be preceded by a comment documenting why - https://phabricator.wikimedia.org/T200611 (10Legoktm) Hmm, interesting idea. Quickly skimming https://codesearch.wmflabs.org/core/?q=suppressWarnings&i=nope&files=&repos= most uses that a... [22:01:51] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-09 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string 'Wikipedia' not found on 'http://en.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 6656 bytes in 0.193 second response time [22:04:48] WFM [22:05:54] (03CR) 10Legoktm: [C: 032] Move OAuthAuthentication to composer unittests (#2) [integration/config] - 10https://gerrit.wikimedia.org/r/448858 (owner: 10Legoktm) [22:06:52] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-09 is OK: HTTP OK: HTTP/1.1 200 OK - 47325 bytes in 1.396 second response time [22:07:20] (03Merged) 10jenkins-bot: Move OAuthAuthentication to composer unittests (#2) [integration/config] - 10https://gerrit.wikimedia.org/r/448858 (owner: 10Legoktm) [22:08:29] !log deployed https://gerrit.wikimedia.org/r/448858 [22:08:32] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:21:00] 10MediaWiki-Codesniffer, 10at-ease: Uses of Wikimedia\suppressWarnings(); should be preceded by a comment documenting why - https://phabricator.wikimedia.org/T200611 (10Krinkle) I'd recommending avoiding additional abstractions to make code easier to recognise for what it does, instead of having two ways to (f... [23:28:55] 10MediaWiki-Codesniffer, 10at-ease: Uses of Wikimedia\suppressWarnings(); should be preceded by a comment documenting why - https://phabricator.wikimedia.org/T200611 (10Jdforrester-WMF) >>! In T200611#4459464, @Krinkle wrote: > Perhaps the sniff could have a whitelist of function names to tolerate? Then, so lo... [23:34:57] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10releng-201718-q3, 10Epic, 10Patch-For-Review: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker - https://phabricator.wikimedia.org/T183512 (10Jdforrester-WMF)