[00:53:47] 10Phabricator, 10Release-Engineering-Team (Kanban): Make sure elasticsearch 6 is supported in phabricator - https://phabricator.wikimedia.org/T181393 (10mmodell) p:05Normal>03High High priority due to the situation described in T181393#4401319 [00:54:41] (03PS1) 10Zoranzoki21: Archive mediawiki/extensions/Wikidata (Wikidata build) [integration/config] - 10https://gerrit.wikimedia.org/r/450894 [00:56:17] (03Abandoned) 10Zoranzoki21: Archive mediawiki/extensions/Wikidata (Wikidata build) [integration/config] - 10https://gerrit.wikimedia.org/r/450894 (owner: 10Zoranzoki21) [01:09:00] Heads up: I'm resigning as a Phab admin. The user confirmation spam is unbearable. [01:10:39] Turns out Phab won't let you remove your own status? [01:10:42] Lamesauce [01:11:15] remove admin [01:11:21] button should be on your profile [01:11:58] Indeed it is. "You cannot adjust your own status as an administrator" [01:12:03] no_justification https://phabricator.wikimedia.org/people/manage/11/ [01:12:05] oh [01:12:13] Typical bait and switch in Phab. [01:12:22] Provide buttons that don't work [01:13:48] I guess I can just set up a filter [01:13:52] In my email [01:13:55] heh [01:15:36] no_justification also hi, haven't seen you around in a while :) [01:17:39] Been busy! Job + the wedding rapidly approaching! [01:17:58] wedding? [01:18:13] Oh yeah that's old news, getting married in Sept [01:18:22] Coulda sworn you knew [01:18:29] oh [01:18:30] nope [01:18:52] or i must have forgotten, though i doin't think so :) [02:16:47] no_justification: we're turning it off on Wednesday after the deploy, thankfully. [02:17:10] Thank the maker [02:17:25] New features to make it less necessary? [02:17:35] Guess I won't ssh in and revoke myself [02:17:37] Hehe [04:18:57] 10Continuous-Integration-Config, 10Wikimedia-General-or-Unknown, 10phan-taint-check-plugin, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review: Enable phan-taint-check-plugin on all Wikimedia-deployed repositories where it is curr... - https://phabricator.wikimedia.org/T201219 [08:27:27] 10Phabricator (Upstream), 10Upstream: Editing project settings on small screens, one cannot add new menu items or reorder existing menu items - https://phabricator.wikimedia.org/T157664 (10Aklapper) p:05Low>03Lowest [08:30:46] 10Phabricator (Upstream), 10Upstream, 10User-Matthewrbowker: Phabricator emails are sometimes mis-encoded on iOS - https://phabricator.wikimedia.org/T180405 (10Aklapper) @Matthewrbowker : Any news? I'm tempted to close this task as I don't expect a bug in Phabricator but in Apple products. [08:31:47] 10Phabricator (Upstream), 10Upstream: Incorrect link in HTML email notification for URLs without protocol (starting with "//") (due to missing base URI?) - https://phabricator.wikimedia.org/T121983 (10Aklapper) [10:08:32] (03PS1) 10Umherirrender: Whitelist @param-taint and @return-taint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/450933 [10:42:26] 10Phabricator (Upstream), 10Upstream: Interrupting (cancel; Esc) a transaction (search query; saving task edits) leaves UI buttons and boxes inactive - https://phabricator.wikimedia.org/T87506 (10Aklapper) [10:42:58] 10Phabricator (Upstream), 10Upstream: Interrupting (cancel; Esc) a transaction (search query; saving task edits) leaves UI buttons and boxes inactive - https://phabricator.wikimedia.org/T87506 (10Aklapper) [10:43:00] 10Phabricator (Upstream), 10Upstream: Leave the button "Save changes" enabled - https://phabricator.wikimedia.org/T129012 (10Aklapper) [10:43:02] 10Phabricator (Upstream), 10Upstream: Search button unusable when search interrupted - https://phabricator.wikimedia.org/T109955 (10Aklapper) [13:54:00] Project beta-update-databases-eqiad build #27401: 04FAILURE in 8 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/27401/ [14:29:00] Yippee, build fixed! [14:29:00] Project beta-update-databases-eqiad build #27402: 09FIXED in 2 min 47 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/27402/ [14:31:54] (03Abandoned) 10MarcoAurelio: Run phan for AbsenteeLandlord [integration/config] - 10https://gerrit.wikimedia.org/r/448429 (owner: 10MarcoAurelio) [14:36:22] (03PS3) 10MarcoAurelio: Fix missing stuff to fully whitelist User:Rxy on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/450644 [14:36:29] (03PS4) 10MarcoAurelio: Fix missing stuff to fully whitelist User:Rxy on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/450644 [15:03:02] Project mediawiki-core-code-coverage-docker build #3683: 04FAILURE in 3 min 1 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-docker/3683/ [15:06:29] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilip... [15:07:12] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilip... [15:18:02] hi relengers, think this will stop running quibble on the fundraising/REL* branches? [15:18:07] https://gerrit.wikimedia.org/r/451005 [15:19:25] This patch made quibble stop running on REL1_31 when it was merged: https://gerrit.wikimedia.org/r/448762 [15:19:41] but something since then seems to have re-enabled it [15:20:09] causing failures: https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php70-docker/31/console [15:20:15] 10Phabricator, 10Release-Engineering-Team (Kanban), 10VisualEditor, 10User-Ryasmeen: 404 on VisualEditor workboard (due to custom filter applied which did not exist in database) - https://phabricator.wikimedia.org/T199207 (10Esanders) p:05Unbreak!>03High >>! In T199207#4413718, @Krenair wrote: > For re... [15:25:27] (03PS24) 10Zfilipin: WIP Run tests daily targeting beta cluster for all repositories with Selenium tests [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [15:27:51] (03CR) 10Zfilipin: "PS24 is a failed attempt to rebase and use selenium-test npm script for core." [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [15:39:08] 10Gerrit, 10Release-Engineering-Team, 10Patch-For-Review, 10User-notice: Make PolyGerrit the default ui - https://phabricator.wikimedia.org/T196812 (10Paladox) Yup sure :) I’m hoping they will branch it soon :) [15:39:25] (03CR) 10jerkins-bot: [V: 04-1] WIP Run tests daily targeting beta cluster for all repositories with Selenium tests [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [15:53:13] (03CR) 10Legoktm: [C: 032] Whitelist @param-taint and @return-taint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/450933 (owner: 10Umherirrender) [15:54:44] (03PS25) 10Zfilipin: WIP Run tests daily targeting beta cluster for all repositories with Selenium tests [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [15:54:47] (03Merged) 10jenkins-bot: Whitelist @param-taint and @return-taint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/450933 (owner: 10Umherirrender) [15:55:50] (03CR) 10Zfilipin: "PS25 fixes problems introduced with the rebase." [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [15:56:45] (03CR) 10jenkins-bot: Whitelist @param-taint and @return-taint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/450933 (owner: 10Umherirrender) [16:11:36] 10Continuous-Integration-Config, 10Performance-Team, 10RunningStat: Publish Doxygen for RunningStat library - https://phabricator.wikimedia.org/T185724 (10Krinkle) [16:23:24] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilip... [16:24:09] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilip... [16:24:48] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin, 10Wikimedia-Incident: Create selenium-MediaWiki-jessie daily Jenkins job - https://phabricator.wikimedia.org/T185011 (10zeljkofilipin) a:03zeljkofilipin [16:26:24] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin, 10Wikimedia-Incident: Create selenium-MediaWiki-jessie daily Jenkins job - https://phabricator.wikimedia.org/T185011 (10zeljkofilipin) [16:27:02] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin, 10Wikimedia-Incident: Create selenium-MediaWiki-jessie daily Jenkins job - https://phabricator.wikimedia.org/T185011 (10zeljkofilipin) [16:35:32] 10Gerrit, 10Quarry: Quarry repo access should be cleaned up - https://phabricator.wikimedia.org/T201435 (10Jdforrester-WMF) [16:52:37] 10Gerrit: Allow pushing more than 10 changes at once - https://phabricator.wikimedia.org/T200785 (10Simetrical) For the record, I keep running into this. I'm doing a lot of refactoring work, and if I don't build all my patches on each other there are inevitably merge conflicts. I've been forced to just submit... [16:57:04] 10Gerrit: Allow pushing more than 10 changes at once - https://phabricator.wikimedia.org/T200785 (10Reedy) You can work around this by not using git review and a couple of steps... `git push origin HEAD~5:refs/for/master` And then just swap `~5` to a number to split your commits into batches of < 10 [16:57:59] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Create Fatal-Monitor dashboard in logstash-beta - https://phabricator.wikimedia.org/T185974 (10Etonkovidova) @zeljkofilipin - all works! Thanks. [17:22:12] twentyafterfour: You're doing the train today? CI's just a bit backed up yet. Would be nice to get some of it landed before the train is cut, but obviously you can't wait forever. :-) [17:41:23] James_F: well fortunately for you I’m also delayed by a crap internet connection. So I haven’t cut the branch yet. [17:41:29] 10Gerrit, 10Quarry: Quarry repo access should be cleaned up - https://phabricator.wikimedia.org/T201435 (10Legoktm) I've made https://gerrit.wikimedia.org/r/admin/groups/b992861bb3f5df1d6f3df8b821c0bf919bb713a8 public, I don't know why it was set to private. [17:42:02] * James_F nods. [17:43:08] 10Gerrit, 10Quarry: Quarry repo access should be cleaned up - https://phabricator.wikimedia.org/T201435 (10Jdforrester-WMF) [17:43:56] twentyafterfour: we have one revert that needs to make the train! https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/451045/ [17:44:57] niedzielski: ok [17:46:29] (03PS1) 10Umherirrender: Archive mediawiki/extensions/DjangoAnalytics [integration/config] - 10https://gerrit.wikimedia.org/r/451055 (https://phabricator.wikimedia.org/T199850) [17:49:59] twentyafterfour: thank you! [17:51:48] niedzielski: I guess if it doesn't merge before the branch cut then I'll cherry pick it [17:54:45] twentyafterfour: that'd be great. thank you! [17:56:25] 10Gerrit: Place holder task for Gerrit 2.16 upgrade - https://phabricator.wikimedia.org/T200739 (10Paladox) [18:01:06] 10Scap, 10Operations: Wrong umask when deploying from screen - https://phabricator.wikimedia.org/T200690 (10thcipriani) >>! In T200690#4482670, @Tgr wrote: >> I wonder if there are git hooks we could setup on the deployment servers to address this without having to put any logic into scap? > > Sure (just chec... [18:02:00] (03PS1) 10Umherirrender: Add quibble for mediawiki/extensions/CreatedPagesList [integration/config] - 10https://gerrit.wikimedia.org/r/451058 [18:04:28] (03PS1) 10Umherirrender: Add quibble for mediawiki/extensions/SplitPrivateWiki [integration/config] - 10https://gerrit.wikimedia.org/r/451059 [18:21:42] 10Release-Engineering-Team, 10Core-Platform-Team, 10Multi-Content-Revisions, 10Performance-Team, and 2 others: Save Timing increased 50% since 2018-06-28 20:53 - https://phabricator.wikimedia.org/T198483 (10CCicalese_WMF) [18:35:54] 10Release-Engineering-Team, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review: Save Timing increased 50% since 2018-06-28 20:53 - https://phabricator.wikimedia.org/T198483 (10CCicalese_WMF) [19:01:38] (03PS1) 10Thcipriani: WIP: Disconnect nodes where /srv > 95% full [integration/config] - 10https://gerrit.wikimedia.org/r/451078 (https://phabricator.wikimedia.org/T201224) [19:03:18] hi releng! [19:03:33] Any idea why quibble tests are running on fundraising branches again? [19:03:56] They're failing and stopping us from deploying to payments-wiki [19:03:59] w.g. [19:04:01] *e.g. [19:04:12] https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/221/console [19:04:18] on fundraising/REL1_27 [19:04:26] https://gerrit.wikimedia.org/r/450999 [19:06:13] There's a skip-if bit in layout.yaml that should keep quibble out of fundraising/* [19:06:30] but perhaps the 'queue' condition is restricting it? [19:06:35] (03CR) 10Thcipriani: [C: 031] "Looks awesome." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/449527 (https://phabricator.wikimedia.org/T200843) (owner: 10Dduvall) [19:06:48] Think this would help? [19:06:53] https://gerrit.wikimedia.org/r/451005 [19:09:35] ejegg: looking [19:10:35] thanks thcipriani. I think it just started in the past week [19:17:06] hrm that is strange. This is what added new quibble jobs, but I think it should still skip fundraising: https://gerrit.wikimedia.org/r/#/c/integration/config/+/450085/3/zuul/layout.yaml [19:17:23] oh wait [19:17:28] should that be fundraising/REL [19:17:31] ? [19:18:48] thcipriani: aha, probably it should skip REL* and fundraising/REL* [19:19:09] yeah, that seems like it might explain what you're seeing [19:19:48] though I don't quite get why the existing ^.*quibble-.*-docker$ pattern didn't apply to wmf-quibble-core-vendor-mysql-hhvm-docker [19:19:52] does the order matter? [19:25:06] I could believe it's the queue name :) [19:25:13] let's try your patch [19:26:46] (03CR) 10Thcipriani: [C: 032] Remove 'queue' to skip quibble on fr branches [integration/config] - 10https://gerrit.wikimedia.org/r/451005 (owner: 10Ejegg) [19:27:27] * ejegg crosses fingers [19:28:33] Hmm. Shouldn't REL1_31 patches go in a different queue / split tree to master patches in gate-and-submit? E.g. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageForms/+/441829 is currently the active 'mediawiki' queue for gate-and-submit, blocking https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/450658 (in master). [19:28:58] I thought jenkins/zuul would run those in parallel? [19:29:48] (03Merged) 10jenkins-bot: Remove 'queue' to skip quibble on fr branches [integration/config] - 10https://gerrit.wikimedia.org/r/451005 (owner: 10Ejegg) [19:30:13] from the looks of it, in the test pipeline, the queue name is "mediawiki/core" [19:30:23] in gate-and-submit the queue name is "mediawiki" [19:30:26] which is...confusing [19:31:43] That too. :-) [19:31:56] We definitely want MW core and MW extensions in the same queue. [19:32:23] But master and non-master patches shouldn't block each other – and I thought they didn't before. Am I mad, did it change, or both? [19:34:09] I think they've always blocked for the test pipeline. This lead to the creation of the gate-and-submit-swat pipeline that only looks at wmf branches so SWAT didn't get caught up waiting for the gate-and-submit pipeline to clear [19:35:32] I haven't looked at how difficult it would be to add a test-[wmf|rel] pipeline that is different than test. IIRC the criteria for "blocking" is: do these repos share a job [19:35:55] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/c/integration/config/+/451005 [19:35:57] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:37:09] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.32.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T191062 (10mmodell) [19:37:40] ejegg: ^ is deployed, FYI [19:45:31] Right. [19:48:48] 10Scap, 10Operations: Wrong umask when deploying from screen - https://phabricator.wikimedia.org/T200690 (10Krinkle) I haven't thought of using the screen command directly over ssh. That's neat. My setup is to have the `screen -DR` command in `~/.bash_profile` remotely. With that in place, any new login from... [19:49:09] (03PS5) 10Krinkle: Fix missing stuff to fully whitelist User:Rxy on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/450644 (owner: 10MarcoAurelio) [19:49:12] (03CR) 10Krinkle: [C: 032] Fix missing stuff to fully whitelist User:Rxy on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/450644 (owner: 10MarcoAurelio) [19:50:49] (03Merged) 10jenkins-bot: Fix missing stuff to fully whitelist User:Rxy on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/450644 (owner: 10MarcoAurelio) [19:52:41] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/450644 [19:52:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:53:03] (03PS3) 10Krinkle: Archive the Reflect extension [integration/config] - 10https://gerrit.wikimedia.org/r/450435 (https://phabricator.wikimedia.org/T201107) (owner: 10MarcoAurelio) [19:53:12] (03CR) 10Krinkle: [C: 032] Archive the Reflect extension [integration/config] - 10https://gerrit.wikimedia.org/r/450435 (https://phabricator.wikimedia.org/T201107) (owner: 10MarcoAurelio) [19:54:49] (03Merged) 10jenkins-bot: Archive the Reflect extension [integration/config] - 10https://gerrit.wikimedia.org/r/450435 (https://phabricator.wikimedia.org/T201107) (owner: 10MarcoAurelio) [19:59:05] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/450435 / T201107) [19:59:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:59:09] T201107: Archive the Reflect extension - https://phabricator.wikimedia.org/T201107 [19:59:27] 10Phabricator: Unable to log in to Phabricator via MediaWiki on mobile - https://phabricator.wikimedia.org/T201460 (10jhsoby) [20:01:28] * Krinkle is resisting the temptation to start renaming deployment-prep hosts from deployment-xx to beta-xx or prep-xx so that "ssh deploy" will not autocomplete all beta hosts before deploy1001.eqiad or deployment.eqiad [20:02:35] heh, blame production :) [20:02:37] also with the FQDN format for Cloud VPS we have now, I guess we could even drop the prefix, matching more closely what we do in prod with different "clusters". [20:03:05] e.g. webperf0013.deployment-prep.eqiad.wmflabs [20:03:27] webperf13* [20:05:04] FWIW: that would totally mess up my ssh config [20:05:12] https://gist.github.com/thcipriani/f9801b5373c4c698555cac1a3fe45590 [20:05:40] as it is if I do: deployment-[blah] it assumes deployment-prep [20:05:45] not a huge deal [20:11:57] thcipriani: darn, it's still quibbling with the fundraising branches: https://gerrit.wikimedia.org/r/450999 [20:14:31] I did that recheck before the zuul update [20:14:43] to see what queue it ended up in [20:45:31] [13:30:13] from the looks of it, in the test pipeline, the queue name is "mediawiki/core" <-- the test pipeline isn't dependent, so queues are named after their repositories. [20:46:16] [13:35:32] I haven't looked at how difficult it would be to add a test-[wmf|rel] pipeline that is different than test. IIRC the criteria for "blocking" is: do these repos share a job <-- kind of. the criteria is either a shared job, or queue-name that is common [20:46:45] I also still maintain that the dependent gate-and-submit queue is more harmful than helpful, especially with the introduction of Depends-On [20:49:30] I feel like the downside risk of turning it off might be high, that is, most of the time it's useless, but it likely catches problems that we may not otherwise. [20:49:54] I have yet to see a regression it actually would have caught [20:49:57] although I'm not basing that on any numbers or anything other than what hashar has told me [20:50:33] the alternative would be that repos are all dependent but not deps between repos? [20:52:15] I'm not able to parse your last message [20:52:35] that is, patch-sets for the same repo are all dependent, but not across repos [20:52:54] like the test pipeline [20:53:44] right [20:54:22] err, but patches in the same repo aren't dependent in the test pipeline unless they're actually dependent in git [20:55:45] https://phabricator.wikimedia.org/T94322 here's the task [20:55:51] https://phabricator.wikimedia.org/T94322#1902682 lol [20:56:14] * thcipriani reads [20:56:39] thcipriani: https://phabricator.wikimedia.org/T94322#1193732 is the tl;dr IMO [20:56:56] "The only reason is to catch compatibility regression if two changes are in the queue at the same time" [20:57:23] That happens from time to time. [20:57:32] But then again, we'd spot it very quickly. [20:58:43] I think the increase in CI times caused by constantly re-running tests whenever something entirely unrelated fails higher up in the queue isn't worth that minor benefit [21:00:27] * legoktm goes back to being on vacation o/ [21:00:29] Yeah. [21:06:05] thanks for the background! [21:16:46] 10Deployments, 10Wikimedia-Incident: Local private files on deployment host should be backed up somewhere - https://phabricator.wikimedia.org/T69818 (10Imarlier) Is PrivateSettings.php a single file that exists on the deployment host and that is shared between everyone with deploy access? Or does everyone hav... [21:18:02] hellooo... I need a CI admin (I think legoktm or addshore ?) can someone help with reviewing/merging this: https://gerrit.wikimedia.org/r/#/c/integration/config/+/450157/ [21:24:24] 10Deployments, 10Wikimedia-Incident: Local private files on deployment host should be backed up somewhere - https://phabricator.wikimedia.org/T69818 (10Reedy) >>! In T69818#4486677, @Imarlier wrote: > Is PrivateSettings.php a single file that exists on the deployment host and that is shared between everyone wi... [21:24:59] mooeypoo: I can take a look [21:25:09] thcipriani: much obliged! [21:25:48] thcipriani: I am not 100% sure of the cause of the original revert, but it looks like legoktm's concerns were answered with this new patch (?) MaxSem may have more details if needed [21:26:33] 10Phabricator, 10Release-Engineering-Team (Kanban), 10VisualEditor, 10User-Ryasmeen: 404 on VisualEditor workboard (due to custom filter applied which did not exist in database) - https://phabricator.wikimedia.org/T199207 (10mmodell) Indeed, I have no idea how/why this occurs. [21:31:31] mooeypoo: that's my understanding, too. [21:33:02] (03CR) 10Thcipriani: [C: 032] Re-add GlobalPreferences to extension-gate [integration/config] - 10https://gerrit.wikimedia.org/r/450157 (https://phabricator.wikimedia.org/T199761) (owner: 10MaxSem) [21:33:52] looks like there's a regex in place for REL branches that *should* make this fine (not knowing the whole background) [21:34:32] (03Merged) 10jenkins-bot: Re-add GlobalPreferences to extension-gate [integration/config] - 10https://gerrit.wikimedia.org/r/450157 (https://phabricator.wikimedia.org/T199761) (owner: 10MaxSem) [21:37:34] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/#/c/integration/config/+/450157/ [21:37:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:40:42] thcipriani: thank you! [21:40:59] mooeypoo: sure thing, I rechecked one of your patch sets, looks like there is an additional wmf-quibble-vendor-mysql-hhvm-docker job running for test now [21:41:35] ooh [21:41:39] ... I hope it passes [21:41:45] :D [21:43:49] heh, me too :) [22:02:58] thcipriani: sweet, it ran the extra job *and* passed. [22:03:00] thanks! [22:03:22] you're welcome! glad it worked! [22:04:52] 10Continuous-Integration-Config, 10Community-Tech, 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech-Sprint, 10Patch-For-Review: Re-add GlobalPreferences to extension-gate - https://phabricator.wikimedia.org/T199761 (10Mooeypoo) This was tested by running 'recheck' on this: https://gerrit.wikime... [22:10:46] 10Release-Engineering-Team, 10Operations, 10SRE-Access-Requests: Add contint-roots to releases{1,2}001 - https://phabricator.wikimedia.org/T201470 (10thcipriani) [22:12:43] i found a bug in project dashboard, amazing no one upstream caught that yet :) [22:14:20] 10Release-Engineering-Team, 10Operations, 10SRE-Access-Requests: Add contint-roots to releases{1,2}001 - https://phabricator.wikimedia.org/T201470 (10Dzahn) Note that we already have: %releasers-mediawiki ALL = (jenkins) NOPASSWD: ALL %releasers-mediawiki ALL = NOPASSWD: /usr/sbin/service jenkins * Which c... [22:26:44] 10Release-Engineering-Team, 10Operations, 10SRE-Access-Requests: Add contint-roots to releases{1,2}001 - https://phabricator.wikimedia.org/T201470 (10thcipriani) >>! In T201470#4486823, @Dzahn wrote: > Which could run any command as jenkins. I understand you need more than the jenkins user though? For upgra... [22:35:48] 10Continuous-Integration-Config, 10Community-Tech, 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech-Sprint, 10Patch-For-Review: Re-add GlobalPreferences to extension-gate - https://phabricator.wikimedia.org/T199761 (10MaxSem) 05Open>03Resolved Also core tests pass: https://gerrit.wikimedia.... [23:36:51] (03PS1) 10Ejegg: Skip quibble-vendor on fundraising branches [integration/config] - 10https://gerrit.wikimedia.org/r/451212 [23:38:48] hi releng! [23:39:36] I think ^^^ should stop these new failing jobs from running on fundraising branches