[00:39:29] https://groups.google.com/forum/#!topic/repo-discuss/7_Bjx8vKvwU [00:39:45] well that image diff looks awesome. [01:30:14] 10Release-Engineering-Team, 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend.js): [EPIC] Generate compiled assets from continuous integration - https://phabricator.wikimedia.org/T158980 (10Jdlrobson) p:05High>03Low [01:51:02] paladox: nice when uploading improved favicons/logos [02:01:51] WOW [02:02:35] paladox: that does look awesome [02:02:49] Yep :) [02:02:56] legoktm: it’s a plugin [02:03:12] https://gerrit-review.googlesource.com/admin/repos/plugins/image-diff [02:03:38] That won’t work with 2.15 pg though [02:03:58] Do to changes in core to get that plugin working (will work with 2.16) [02:11:28] legoktm: mutante “Patchset navigation” feature also looks awesome (comming soon) [02:11:46] paladox: what does that do? [02:11:48] paladox: yeah, that was the part that really got me excited. and the draft comments thing [02:12:43] mutante: viewing the different patch sets [02:15:46] hmm. i looked but not sure i get it yet. but i definitely like the dark theme, i always like dark themes :) [02:15:55] Heh [02:16:43] Green IT by not illuminating all those background pixels.. how much energy does it save multiplied by all the users :PP [02:17:04] Lol [02:17:36] We could in theory make multiple themes and allow users to set which one in there settings (through a plugin) [02:18:52] well, that seems to come with it. "It can be enabled via the Settings menu." [02:19:26] Yeh or we can specific a theme shown to all users [02:19:36] Like they did for gerrit-review [02:19:43] https://gerrit-review.googlesource.com/dashboard/self [02:19:47] Making it blue [02:20:28] "Have you ever drafted comments in Gerrit, but lost track of them before publishing?" "We’re taking them out of the Reply dialog" welll.. this part i'm not sure about.. i usually did NOT lose track.. because.. they were still in the Reply dialog [02:20:49] Heh [02:21:12] I guess if you have a lot of files to comment on [02:21:16] You could get lost [02:22:27] (03CR) 10Legoktm: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/455626 (owner: 10Umherirrender) [02:22:49] mutante: https://www.gerritcodereview.com/2.16.html#request-tracing :) [02:23:39] paladox: sounds good for debugging:) reminds me we never finished sending logs to logstash [02:24:10] Yep and oh? [02:25:22] wait.. did we? [02:25:30] Yep we did [02:25:37] i remember we tried and then .. [02:26:09] ok :) [02:52:21] (03PS2) 10Legoktm: Add tox-poolcounter image [integration/config] - 10https://gerrit.wikimedia.org/r/456073 [02:53:15] (03CR) 10Legoktm: [C: 032] Add tox-poolcounter image [integration/config] - 10https://gerrit.wikimedia.org/r/456073 (owner: 10Legoktm) [02:54:49] (03Merged) 10jenkins-bot: Add tox-poolcounter image [integration/config] - 10https://gerrit.wikimedia.org/r/456073 (owner: 10Legoktm) [02:55:41] !log rebuilding docker for https://gerrit.wikimedia.org/r/456073 [02:55:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:55:51] thcipriani: does docker-pkg need to be manually deployed? [02:57:08] I'm fairly sure that it does. It seems to be deployed via scap from deploy1001. [03:05:56] thcipriani: hm, who normally deploys it? [03:24:30] (03PS1) 10Legoktm: Add jobs for mediawiki/services/poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/456328 [03:26:23] (03CR) 10jerkins-bot: [V: 04-1] Add jobs for mediawiki/services/poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/456328 (owner: 10Legoktm) [03:36:01] When I looked at /srv/deployment/docker-pkg/deploy last _jo.e_ owned all the files there iirc [03:38:30] (03PS2) 10Legoktm: Add jobs for mediawiki/services/poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/456328 [03:41:34] (03CR) 10Legoktm: [C: 032] Add jobs for mediawiki/services/poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/456328 (owner: 10Legoktm) [03:44:04] (03Merged) 10jenkins-bot: Add jobs for mediawiki/services/poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/456328 (owner: 10Legoktm) [03:44:27] !log deployed https://gerrit.wikimedia.org/r/456328 [03:44:29] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [05:26:12] PROBLEM - SSH on integration-slave-docker-1004 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [05:38:13] eh [05:38:54] it's responding to ping [05:38:59] but not ssh [05:39:56] jenkins is trying to relaunch it because it can't grab the ssh connection [05:51:03] RECOVERY - SSH on integration-slave-docker-1004 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u5 (protocol 2.0) [05:57:06] !log manually triggering jobs on contint1001 (this time with 8 parallel jobs, up from 6 previously) [05:57:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:36:19] PROBLEM - Puppet errors on deployment-deploy01 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [06:42:04] PROBLEM - Puppet errors on saucelabs-01 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [06:59:33] (03PS1) 10Legoktm: seccheck for CheckUser and CirrusSearch [integration/config] - 10https://gerrit.wikimedia.org/r/456337 (https://phabricator.wikimedia.org/T202377) [06:59:50] (03CR) 10Legoktm: [C: 032] seccheck for CheckUser and CirrusSearch [integration/config] - 10https://gerrit.wikimedia.org/r/456337 (https://phabricator.wikimedia.org/T202377) (owner: 10Legoktm) [07:01:41] (03Merged) 10jenkins-bot: seccheck for CheckUser and CirrusSearch [integration/config] - 10https://gerrit.wikimedia.org/r/456337 (https://phabricator.wikimedia.org/T202377) (owner: 10Legoktm) [07:04:26] !log deploying https://gerrit.wikimedia.org/r/456337 [07:04:29] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:11:17] RECOVERY - Puppet errors on deployment-deploy01 is OK: OK: Less than 1.00% above the threshold [0.0] [07:14:52] 10Continuous-Integration-Config, 10Wikimedia-General-or-Unknown, 10phan-taint-check-plugin, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review: Enable phan-taint-check-plugin on all Wikimedia-deployed repositories where it is curr... - https://phabricator.wikimedia.org/T201219 [07:15:09] 10Continuous-Integration-Config, 10Wikimedia-General-or-Unknown, 10phan-taint-check-plugin, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review: Enable phan-taint-check-plugin on all Wikimedia-deployed repositories where it is curr... - https://phabricator.wikimedia.org/T201219 [07:17:04] RECOVERY - Puppet errors on saucelabs-01 is OK: OK: Less than 1.00% above the threshold [0.0] [07:17:10] (03PS1) 10Legoktm: seccheck for Collection [integration/config] - 10https://gerrit.wikimedia.org/r/456340 [07:17:23] (03CR) 10Legoktm: [C: 032] seccheck for Collection [integration/config] - 10https://gerrit.wikimedia.org/r/456340 (owner: 10Legoktm) [07:19:00] (03Merged) 10jenkins-bot: seccheck for Collection [integration/config] - 10https://gerrit.wikimedia.org/r/456340 (owner: 10Legoktm) [07:19:09] !log deploying https://gerrit.wikimedia.org/r/456340 [07:19:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:23:14] (03CR) 10Legoktm: [C: 032] Enable PSR2.Classes.ClassDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/455626 (owner: 10Umherirrender) [07:24:16] (03Merged) 10jenkins-bot: Enable PSR2.Classes.ClassDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/455626 (owner: 10Umherirrender) [07:24:51] (03CR) 10jenkins-bot: Enable PSR2.Classes.ClassDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/455626 (owner: 10Umherirrender) [07:29:07] (03PS1) 10Legoktm: seccheck for FundraiserLandingPage [integration/config] - 10https://gerrit.wikimedia.org/r/456341 [07:35:50] (03CR) 10Legoktm: [C: 032] seccheck for FundraiserLandingPage [integration/config] - 10https://gerrit.wikimedia.org/r/456341 (owner: 10Legoktm) [07:37:21] (03Merged) 10jenkins-bot: seccheck for FundraiserLandingPage [integration/config] - 10https://gerrit.wikimedia.org/r/456341 (owner: 10Legoktm) [07:39:49] !log deployed https://gerrit.wikimedia.org/r/456341 [07:39:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:42:56] 10Continuous-Integration-Config, 10Patch-For-Review: mwext-php70-phan-seccheck-docker isn't using composer cache - https://phabricator.wikimedia.org/T202225 (10Legoktm) Thank you! I have noticed a small speed up in these jobs :) [07:48:09] 10Release-Engineering-Team (Kanban), 10User-greg: Wikimedia Portals Update and European Mid-day SWAT windows at the same time on Mondays - https://phabricator.wikimedia.org/T201932 (10zeljkofilipin) [07:51:23] (03PS1) 10Legoktm: seccheck for BetaFeatures [integration/config] - 10https://gerrit.wikimedia.org/r/456343 [07:51:46] (03CR) 10Legoktm: [C: 032] seccheck for BetaFeatures [integration/config] - 10https://gerrit.wikimedia.org/r/456343 (owner: 10Legoktm) [07:53:13] (03Merged) 10jenkins-bot: seccheck for BetaFeatures [integration/config] - 10https://gerrit.wikimedia.org/r/456343 (owner: 10Legoktm) [07:53:45] !log deploying https://gerrit.wikimedia.org/r/456343 [07:53:48] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:07:25] (03CR) 10KartikMistry: [C: 031] Add mw ext ContentTranslation to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/450508 (https://phabricator.wikimedia.org/T86930) (owner: 10Santhosh) [08:12:26] 10Beta-Cluster-Infrastructure, 10Operations, 10wikidata-tech-focus, 10User-Addshore, 10User-Joe: Run mediawiki::maintenance scripts in Beta Cluster - https://phabricator.wikimedia.org/T125976 (10Addshore) p:05Normal>03High It looks like the fix for running wikidata dispatching is on more since we hav... [08:43:21] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin: Video recording for Selenium tests in Node.js - https://phabricator.wikimedia.org/T179188 (10zeljkofilipin) [08:54:53] (03PS1) 10Volans: Add tox job for operations/cookbooks [integration/config] - 10https://gerrit.wikimedia.org/r/456354 (https://phabricator.wikimedia.org/T199079) [09:04:26] 10Beta-Cluster-Infrastructure, 10Operations, 10Wikidata, 10wikidata-tech-focus, and 2 others: Run mediawiki::maintenance scripts in Beta Cluster - https://phabricator.wikimedia.org/T125976 (10Addshore) [09:30:58] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10Jenkins, 10Patch-For-Review: Upgrade deployment-prep deployment servers to stretch - https://phabricator.wikimedia.org/T192561 (10hashar) A while ago, once a change got merged for parsoid we would trigger a Jenkins job th... [09:35:42] (03PS1) 10Hashar: Add debian-glue non voting to blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456359 [09:36:38] (03CR) 10Hashar: [C: 032] Add debian-glue non voting to blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456359 (owner: 10Hashar) [09:38:11] (03Merged) 10jenkins-bot: Add debian-glue non voting to blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456359 (owner: 10Hashar) [09:40:31] (03CR) 10Hashar: [C: 032] "Testing happening on https://gerrit.wikimedia.org/r/#/c/blubber/+/456360/" [integration/config] - 10https://gerrit.wikimedia.org/r/456359 (owner: 10Hashar) [09:43:57] (03PS1) 10Hashar: debian-glue is only for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456361 [09:44:26] (03PS2) 10Hashar: debian-glue is only for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456361 [09:44:39] (03CR) 10Hashar: [C: 032] debian-glue is only for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456361 (owner: 10Hashar) [09:45:58] (03PS1) 10Hashar: Make debian-glue voting for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456362 [09:46:16] (03Merged) 10jenkins-bot: debian-glue is only for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456361 (owner: 10Hashar) [09:50:40] (03CR) 10Hashar: [C: 032] Add tox job for operations/cookbooks [integration/config] - 10https://gerrit.wikimedia.org/r/456354 (https://phabricator.wikimedia.org/T199079) (owner: 10Volans) [09:52:19] (03Merged) 10jenkins-bot: Add tox job for operations/cookbooks [integration/config] - 10https://gerrit.wikimedia.org/r/456354 (https://phabricator.wikimedia.org/T199079) (owner: 10Volans) [09:54:34] 10Release-Engineering-Team (Watching / External), 10Operations, 10Release Pipeline: Update Debian package of Blubber (0.5.0-1) - https://phabricator.wikimedia.org/T203121 (10ArielGlenn) p:05Triage>03Normal [09:57:01] (03CR) 10Hashar: Selenium daily tests for beta using Docker/wdio (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [09:57:17] (03PS33) 10Zfilipin: Selenium daily tests for beta using Docker/wdio [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [09:58:29] (03CR) 10Zfilipin: Selenium daily tests for beta using Docker/wdio (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [09:59:04] (03CR) 10Hashar: Selenium daily tests for beta using Docker/wdio (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [10:02:03] (03CR) 10Hashar: Selenium daily tests for beta using Docker/wdio (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [11:50:01] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin: Video recording for Selenium tests in Node.js - https://phabricator.wikimedia.org/T179188 (10zeljkofilipin) [11:52:01] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin: Video recording for Selenium tests in Node.js - https://phabricator.wikimedia.org/T179188 (10zeljkofilipin) [12:06:13] (03PS34) 10Zfilipin: Selenium daily tests for beta using Docker/wdio [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [12:06:24] (03CR) 10Zfilipin: "PS34 is a rebase" [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [12:08:36] 10Release-Engineering-Team (Kanban): Create keyholder gerrit repo - https://phabricator.wikimedia.org/T203108 (10faidon) My vote is under `operations/software`, if not under some non-operations hierarchy. The deployment method shouldn't affect the repository naming; the `operations/debs` tree is for writing Deb... [12:11:19] 10Release-Engineering-Team (Kanban): Create keyholder gerrit repo - https://phabricator.wikimedia.org/T203108 (10faidon) Oh also, would it be possible to keep the (operations/puppet) history such as commit messages etc.? git filter-branch etc. should make this possible right? I don't think there's much in the D... [12:15:40] (03PS35) 10Zfilipin: Selenium daily tests for beta using Docker/wdio [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [12:18:39] (03CR) 10Zfilipin: "PS35" [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [12:31:35] (03PS36) 10Zfilipin: Selenium daily tests for beta using Docker/wdio [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [12:32:28] (03CR) 10Zfilipin: "PS36 fixes log location" (034 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [12:37:54] (03PS37) 10Zfilipin: Selenium daily tests for beta using Docker/wdio [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [12:38:40] (03CR) 10Zfilipin: "PS37 deletes unused 'selenium-{project}-jessie' job template" (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [13:19:45] (03PS38) 10Zfilipin: Selenium daily tests for beta using Docker/wdio [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [13:21:00] (03CR) 10Zfilipin: "PS38 should fix LOG_DIR, but I'm not sure if it actually does. :/" (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [13:26:00] hashar: is there anywhere public to just see the raw XML that is currently being used to run a jenkins job>/ [13:26:01] ? [13:26:08] (03CR) 10Zfilipin: "Looks like thing are fine: https://integration.wikimedia.org/ci/view/Selenium/job/selenium-daily-beta-CirrusSearch/5/console" [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [13:26:22] I know if you log in you can see it in the UI (if you have access), but I was thinking something like https://noc.wikimedia.org but for the jenkins jobs :) [13:27:01] addshore: via the UI yes, or one can generate the jobs locally [13:27:18] the UI only for continit admins though I guess? [13:27:37] (03CR) 10Zfilipin: "Since @Hashar is the owner of the patch, looks like I can not remove WIP status." [integration/config] - 10https://gerrit.wikimedia.org/r/443931 (https://phabricator.wikimedia.org/T188742) (owner: 10Hashar) [13:27:49] addshore: yup :/ [13:27:54] :( [13:28:36] addshore: which job? [13:28:44] not for me, just a general question :) [13:29:31] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Someday), 10Growth-Team, 10MediaWiki-extensions-GettingStarted, and 2 others: Missing XML files cause "Publish Performance test result report" - https://phabricator.wikimedia.org/T164296 (10Deskana) [13:30:14] 10Release-Engineering-Team (Kanban), 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10Patch-For-Review, 10User-zeljkofilipin: Port GettingStarted Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T180224 (10Deskana) [13:30:47] zeljkof: you can check n the slave whether the log dir got populated [13:33:23] zeljkof: there should be some xunit files at least [13:37:02] 10Phabricator: 403 Forbidden when try to access the phabricator from Morocco - https://phabricator.wikimedia.org/T201201 (10Aklapper) 05Open>03declined >>! In T201201#4478581, @Omar_Ghrida wrote: > not always. I use Wi-Fi for the same Internet provider that provides Wikipedia Zero (Morocco Telecom). Should... [13:37:11] zeljkof: so yeah for CirrusSearch tests/selenium/wdio.conf.js has to be updated / synced with the version in mediawiki/core [13:37:19] it does not use the junit reporter [13:40:02] hashar: wait, what? [13:40:14] ah, I think I get it [13:40:23] compare mediawiki core and CirrusSearch tests/selenium/wdio.conf.js [13:40:26] ;] [13:40:53] extension configs are a bit different than core, but yes, I'll compare it with another extension, extensions should all be the same [13:41:50] zeljkof: https://phabricator.wikimedia.org/P7497 [13:42:07] red is CirrusSearch [13:42:09] green is core [13:49:56] 10Phabricator, 10MediaWiki-extensions-CentralAuth, 10Mobile, 10TestMe: Using the MediaWiki login to Phabricator on mobile, got a "No active login attempt is in progress for your session." error on CentralLogin - https://phabricator.wikimedia.org/T95221 (10Aklapper) 05Open>03stalled [13:51:00] 10Differential, 10Phabricator: Configure Phabricator to auto-create a .arcreview file when creating new repos - https://phabricator.wikimedia.org/T189 (10Aklapper) p:05Low>03Lowest [13:54:20] 10Phabricator, 10LDAP: Fix @Jarry1250's Phab account who cannot log in due to T138672 (two LDAP records) - https://phabricator.wikimedia.org/T138653 (10Aklapper) [13:54:24] 10Phabricator, 10LDAP: Specific user cannot log into Phabricator with LDAP account (Phab thinks it's registering a new account, hence email address is already in use) - https://phabricator.wikimedia.org/T168731 (10Aklapper) [13:54:53] 10Phabricator: Reorganize columns on Phabricator workboard - https://phabricator.wikimedia.org/T203073 (10Aklapper) 05Open>03Resolved Caaling this mostly done [13:58:47] hashar: ok, I've just checked, all extensions use the same config file, so I guess all of them should be updated to use xunit :/ [14:00:04] zeljkof: not CirrusSearch [14:00:28] but there is junit reporter? https://phabricator.wikimedia.org/P7497$109 [14:00:38] tests/selenium/wdio.conf.js does not have the junit reporter [14:00:46] ah, no, there i sjust spec [14:01:06] maybe the wdio.conf.js file that got introduced is an old one from core? [14:01:12] all extensions have the same config file, I guess the smallest possible, but yes, junit should be added [14:01:23] no, it's simplified one :) [14:08:23] hashar: this is probably what's wrong :/ https://gerrit.wikimedia.org/r/c/integration/config/+/443931/37..38 [14:08:56] but then, there are no logs at all, I guess adding junit logs would help [14:09:15] dcausse: are you around for a quick cirrus review? [14:09:22] zeljkof: sure [14:09:41] dcausse: great, I'll have something in a few minutes, just a wdio config file update [14:09:48] ok [14:12:57] zeljkof: look at tests/selenium/wdio.conf.js , the only reporter it has is "spec" [14:13:03] hence there is never any junit files being written [14:13:15] hmm, https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi has vanished? [14:13:28] hashar: thanks, saw it, thinking what to do, I'll probably just add the reporter for now [14:14:11] zeljkof: look at how mediawiki/core set logPath from the LOG_DIR env variable, that is done at the top of the file iirc [14:14:22] then logPath is used to set the screenshot path and the junit reporter destination [14:14:35] addshore: that got renamed https://phabricator.wikimedia.org/T178226 [14:14:40] hashar: should I just pretty much copy/paste core config? [14:14:54] 10Release-Engineering-Team, 10GitHub-Mirrors, 10Wikidata: https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi has vanished causing wikibase/javascript-api composer package to break - https://phabricator.wikimedia.org/T203162 (10Addshore) [14:14:56] addshore: eg: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/388046/1/.gitmodules [14:15:08] addshore: so you want wikibase/javascript-api.git :] [14:15:13] mhhhm, okay [14:15:14] 10Release-Engineering-Team, 10GitHub-Mirrors, 10Wikidata: https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi has vanished causing wikibase/javascript-api composer package to break - https://phabricator.wikimedia.org/T203162 (10Addshore) It looks like it was renamed in {T178226} [14:15:20] * addshore creates a ticket chain for reference [14:15:28] !! [14:15:55] zeljkof: and maybe we will want wdio-mediawiki to ship some default / base settings [14:16:11] 10Release-Engineering-Team, 10GitHub-Mirrors, 10Wikidata: https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi has vanished causing wikibase/javascript-api composer package to break - https://phabricator.wikimedia.org/T203162 (10Addshore) https://packagist.org/packages/wikibase/javascript-... [14:16:14] hashar: yes, this copy/pasting will get old pretty quick :/ [14:25:03] zeljkof: that is why I advocated to have them centrally configured :] [14:25:19] hashar: yeah :/ but that did not work either... [14:25:21] but I am sure mediawiki-wdio can ship some basic settings [14:25:25] until that, copy paste! [14:29:00] dcausse: here it is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/456395 [14:29:21] zeljkof: looking [14:30:34] 10Release-Engineering-Team, 10GitHub-Mirrors, 10Wikidata, 10Patch-For-Review, 10User-Addshore: https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi has vanished causing wikibase/javascript-api composer package to break - https://phabricator.wikimedia.org/T203162 (10Addshore) a:03Addsh... [14:31:03] 10Release-Engineering-Team, 10GitHub-Mirrors, 10Wikidata, 10Patch-For-Review, 10User-Addshore: https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi has vanished causing wikibase/javascript-api composer package to break - https://phabricator.wikimedia.org/T203162 (10Addshore) I have got... [14:31:11] dcausse: it's pretty much copy/paste of core config, with removed sauce labs section and adjusted test files section [14:31:49] it's the simplest thing to do for now to keep the config files in extensions/skins up to date, until we figure out a better way [14:32:13] zeljkof: sure, I'm tempted to just hit +2, I see nothing obviously wrong in this patch but I'm not an expert... [14:32:31] I hope that sync does not require some changes [14:32:43] I mean "sync: true" [14:33:31] dcausse: that's the default, I think, it's just explicitly set in core [14:33:55] and cirrus config file is used for daily jobs only anyway, and I've tested it locally, works fine [14:34:06] zeljkof: ok [14:34:06] there's little chance that something will break [14:34:10] sure [14:34:23] but there's always a chance! :D [14:35:03] it won't be a big if it breaks :) [14:35:10] *deal [14:35:42] yes, if it breaks, it will just break the daily job, and a revert would fix that quickly [14:36:48] 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10ArielGlenn) [14:40:01] hashar: sorry, stupid question, but how do I ssh to integration-slave-docker-1017? [14:40:11] (https://integration.wikimedia.org/ci/view/Selenium/job/selenium-daily-beta-CirrusSearch/4/console) [14:40:31] 10Release-Engineering-Team (Kanban), 10Scap, 10Operations: mwscript rebuildLocalisationCache.php takes 40 minutes on HHVM (rather than ~5 on PHP 5) - https://phabricator.wikimedia.org/T191921 (10ArielGlenn) [14:44:03] I've found this https://www.mediawiki.org/wiki/Continuous_integration/Docker#Testing_new_containers [14:44:45] but this does not work `ssh integration-slave-docker-1017` [14:49:49] hashar: when repos move like that is there no way to leave a redirect on github? [14:49:57] thats what happens when you move repos in their ui! [14:50:38] addshore: well the new repo has been created first in gerrit [14:50:44] which replicated to github [14:50:49] 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team (Kanban), 10Wikidata, 10Patch-For-Review: Rename mediawiki/extensions/WikibaseJavaScriptApi repo - https://phabricator.wikimedia.org/T178226 (10Addshore) It's a shame that when the mirror was moved a redirect was not left in place. I b... [14:50:50] aaah gotcha [14:50:54] or maybe we manually creted the new repo on both gerrit and github [14:51:04] and haven't thought about renaming it in the interface :] [14:53:24] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilip... [14:58:48] hashar: looks like the daily job works fine after all https://integration.wikimedia.org/ci/view/Selenium/job/selenium-daily-beta-CirrusSearch/ [14:58:59] now that log files are created, they are archived [15:00:01] zeljkof: magic! can you check the other 4 or 5 repositories? :] [15:01:05] zeljkof: then I guess you can merge / delete the old jobs. Congratulations! [15:01:23] hashar: I'll create patches, but I'm reluctant to self-merge :/ [15:01:32] hashar: how do I ssh to docker machine? [15:03:06] it is not a machine [15:03:09] it is a process [15:03:35] um [15:03:41] but you can exec commands in a running container [15:03:47] ah [15:03:56] probably something like: docker exec -i [15:04:02] err [15:04:08] docker exec -i -t /bin/bash [15:04:09] ;] [15:04:18] which would spawn a bash process in the same namespace [15:04:39] there is also "docker attach" to stream the container stdout/stderr [15:13:22] 10Project-Admins: Create project / workboard User-srodlund - https://phabricator.wikimedia.org/T203170 (10srodlund) [15:26:15] 10Release-Engineering-Team, 10GitHub-Mirrors, 10Wikidata, 10Patch-For-Review, 10User-Addshore: https://github.com/wikimedia/mediawiki-extensions-WikibaseJavaScriptApi has vanished causing wikibase/javascript-api composer package to break - https://phabricator.wikimedia.org/T203162 (10Addshore) 05Open>... [15:36:21] 10Phabricator: Phabricator edit registered multiple times - https://phabricator.wikimedia.org/T185201 (10jmatazzoni) >>! In T185201#3909245, @Peachey88 wrote: > @jmatazzoni Do you remember how you moved the task? using the action drop down or on the work-board view? It was back in January, so no. I typically us... [16:08:24] (03PS1) 10Physikerwelt: Revert "Migrate Math to Quibble" [integration/config] - 10https://gerrit.wikimedia.org/r/456411 (https://phabricator.wikimedia.org/T202266) [16:10:11] (03CR) 10Thcipriani: [C: 032] Make debian-glue voting for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456362 (owner: 10Hashar) [16:10:43] hashar: crazy idea time [16:11:23] cut a wmf branch every 2 hours, and run CI over everything, rather than running long running gate etc jobs for each patch? :P [16:12:42] (03Merged) 10jenkins-bot: Make debian-glue voting for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/456362 (owner: 10Hashar) [16:14:47] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/#/c/integration/config/+/456362/ [16:14:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:15:15] addshore: not a bad crazy idea :) [16:15:48] basicaly thinking that development of extensions and core shouldnt really be so tightly bound to the "wikimedia product" [16:16:04] how long does a branch cut take? [16:16:08] could do one every hour [16:16:25] the shorter the time the easier it is to find the breakages [16:17:57] mw.wmf.2018-08-30T17:00Z :D [16:18:13] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.32.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T191066 (10greg) a:03hashar [16:18:16] addshore: there is a task about dropping the DependentPipeline / gate from zuul [16:18:31] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.32.0-wmf.22 deployment blockers - https://phabricator.wikimedia.org/T191068 (10greg) a:03hashar [16:18:39] *looks* [16:18:41] part of the issue is the wmf-quibble does not really test all extensions [16:18:58] hashar: but, we could make a job that tested all extensions? [16:19:07] (and does not even have operations/mediawiki-config ) [16:19:08] / all wmf extensions [16:19:10] yeah [16:19:42] addshore: https://phabricator.wikimedia.org/T94322 recently reopened [16:19:47] so theorically [16:19:49] It makes sense that the CI for the whole wmf package might take ~1 hour or something to run eventually, but for an individual component it shouldnt really [16:20:03] when someone +2 a patch to one of the master branch of a deployed mediawiki thing [16:20:13] we could have a job (or several) that would run wikimedia integration tests [16:20:16] then if it merges [16:20:24] we now that all master branches at that times passed together [16:20:36] and we could theorically deploy that as is (since all tests passed) [16:21:14] the wmf-quibble (then mediawiki-extensions job) more or less attempt to do that [16:21:25] though it only run tests for an hardcoded list of a few extensions [16:21:41] timo proposed that job to only run specific tests instead of everything [16:26:25] hashar: unrelated question (sorry) - do you know if mysql data-dir is still on ram/tmpfs? Before 2013 we tested MW in CI on sqlite with tmpfs, before mysql was too slow. Then Tim and I made mysql work with tmpfs and we switched CI to it. I think that was still working in Nodepool as well, but it looks like maybe it got lost in quibble/docker which might explain why builds now take 2x as long. [16:27:31] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Browser-Tests: Migrate Selenium tests based on the ruby library mediawiki_selenium - https://phabricator.wikimedia.org/T203178 (10hashar) p:05Triage>03Normal [16:28:15] (03PS1) 10Hashar: docker: quibble container for mediawiki_selenium [integration/config] - 10https://gerrit.wikimedia.org/r/456414 (https://phabricator.wikimedia.org/T203178) [16:30:48] hashar: if we port the wikibase and wikibaselexeme selenium jobs to node that are still using rbuy, we will add probably ~5-10 more mins to all of the gate jobs / jobs that run our browser tests [16:32:48] Krinkle: the mysql database is on disk afaik [16:33:24] Krinkle: Quibble creates a temporary directory for the datadir based on python tempfile.TemporaryDirectory [16:33:39] oh no! So that means we lost that in the quibble migration? [16:33:47] which ends up being somewhere under /tmp whcih for weird reason is currently mounted from the host $WORKSPACE/tmp [16:33:57] yeah looks like we lost that sorry :-\ [16:34:23] (03PS2) 10Hashar: docker: quibble container for mediawiki_selenium [integration/config] - 10https://gerrit.wikimedia.org/r/456414 (https://phabricator.wikimedia.org/T203178) [16:34:46] addshore: that is fine to me (longer duration) [16:35:13] I thought the main reason for the slower job completion was that we added selenium tests, or that we now run everything serially instead of in parallel (1 big job, instead of 4 smaller jobs, phpcs, phpunit, npm test etc.). I think that is still true, but the mysql part for tests is probably a big factor as well. [16:35:15] addshore: we can surely find a way to optimize that and make them faster. Quibble itself deserves a lot of optimization [16:35:19] Would be good to restore at some point :) [16:35:46] ideally docker run would have a way to generate a tmpfs volume for us [16:35:48] in -mediawiki-core Tim found tests go from 13min to 5min when on tmpfs. [16:35:57] OH also [16:36:07] we spawn mariadb with the default settings from the Debian package [16:36:15] there is surely a few settings that could use tuning [16:36:50] One crazy idea would be to see how much RAM we can get from WMCS, and maybe run the whole docker image from a place that, on the host instance, is in tmpfs. [16:36:59] Basically run all docker images fully in RAM. [16:37:25] that would make it simpler by requiring no special knowledge inside the quibble and docker logic. [16:38:18] that as well :] [16:38:26] that is a good idea actually [16:38:41] 10Continuous-Integration-Infrastructure (shipyard), 10Quibble: Quibble MariaDB should use a tmpfs as a datadir - https://phabricator.wikimedia.org/T203181 (10hashar) [16:38:46] I am not sure how much RAM we would need though [16:39:14] addshore: meanwhile I am preparing a container to run the selenium ruby tasks via Quibble. will take me a few days to achieve though [16:42:17] hashar: ooooh [16:48:11] +ENTRYPOINT ["/usr/local/bin/quibble", "--commands", "mwselenium.sh"] [16:48:11] !!! :] [16:56:01] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilip... [16:56:31] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Easy, 10User-zeljkofilipin: All repositories with Selenium tests should use wdio-mediawiki - https://phabricator.wikimedia.org/T199113 (10zeljkofilipin) [16:58:05] 10Release-Engineering-Team (Kanban), 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-mediawiki-maintenance, and 3 others: Port TwoColConflict Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T180248 (10zeljkofilipin) [17:09:04] (03PS8) 10Dduvall: Publish job duration for labeled nodes to labmon1001 [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) [17:10:14] (03CR) 10Dduvall: "In addition to my previous paring down in scope, the publisher now targets labmon1001.eqiad.wmnet instead of statsd.eqiad.wmnet." [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [17:22:58] 10Project-Admins: Create project / workboard User-srodlund - https://phabricator.wikimedia.org/T203170 (10Aklapper) 05Open>03Resolved a:03Aklapper Requested public project #user-srodlund has been created: https://phabricator.wikimedia.org/project/view/3557/ Please encourage interested people to visit the... [17:32:26] "There seems to be a problem with your login session; this action has been canceled as a precaution against session hijacking. Please resubmit the form." [17:32:28] booo [17:32:29] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Browser-Tests, 10Patch-For-Review: Migrate Selenium tests based on the ruby library mediawiki_selenium - https://phabricator.wikimedia.org/T203178 (10hashar) [17:33:37] (03CR) 10Hashar: "Play testing it locally with:" [integration/config] - 10https://gerrit.wikimedia.org/r/456414 (https://phabricator.wikimedia.org/T203178) (owner: 10Hashar) [17:37:02] (03CR) 10Hashar: "Ok I got them running properly. Quibble does not spawn a webserver when using --commands. Else it passes fine locally hurray." [integration/config] - 10https://gerrit.wikimedia.org/r/456414 (https://phabricator.wikimedia.org/T203178) (owner: 10Hashar) [17:38:45] addshore: zeljkof: I got ruby selenium tests working with Quibble :] https://gerrit.wikimedia.org/r/#/c/integration/config/+/456414/ is the unfinished wip [17:39:02] (03CR) 10Paladox: [V: 032 C: 032] Allow users in "Trusted-Contributors" group to merge there own changes in avatar repo [All-Avatars] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/453170 (owner: 10Paladox) [17:39:39] hashar: wooo [17:40:57] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Browser-Tests, 10Patch-For-Review: Migrate Selenium tests based on the ruby library mediawiki_selenium - https://phabricator.wikimedia.org/T203178 (10hashar) One might want to use a command (via `--commands`) that wo... [17:41:25] addshore: zeljkof: I did it via https://gerrit.wikimedia.org/r/#/c/integration/config/+/456414/ [17:41:33] but really I should just write that inside Quibble itself [17:41:55] (03CR) 10Hashar: "The mwselenium.sh logic should be ported to Quibble as a new running stage." [integration/config] - 10https://gerrit.wikimedia.org/r/456414 (https://phabricator.wikimedia.org/T203178) (owner: 10Hashar) [17:47:16] 10Continuous-Integration-Infrastructure (shipyard), 10Quibble: Quibble MariaDB should use a tmpfs as a datadir - https://phabricator.wikimedia.org/T203181 (10hashar) We recently started to mount $WORKSPACE/tmp to the CI Docker container as /tmp (done with @dduvall and @thcipriani ). That was to workaround an i... [18:23:39] twentyafterfour: hey, does this need anything more? [18:24:20] https://gerrit.wikimedia.org/r/c/All-Projects/+/455629 [18:24:59] Amir1: looks good to me [18:24:59] (03CR) 10Paladox: [C: 032] "LGTM someone else will have to merge as i have no merge rights only +2" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/455629 (https://phabricator.wikimedia.org/T197096) (owner: 10Ladsgroup) [18:25:22] (03CR) 1020after4: [V: 032] Enable LFS for research/ores/wheels [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/455629 (https://phabricator.wikimedia.org/T197096) (owner: 10Ladsgroup) [18:25:24] twentyafterfour: Can you merge it and give push rights so I rewrite the history? [18:25:39] merged [18:25:40] That'd be great, thanks! [18:25:46] push rights where? [18:25:59] lfs push? you should have it [18:28:53] twentyafterfour: not just lfs push, the git push: https://phabricator.wikimedia.org/T181678#3798104 [18:38:22] thcipriani or twentyafterfour wondering if we could get this https://gerrit-review.googlesource.com/admin/repos/plugins/avatars-external plugin installed please? [18:39:05] hmm /me trys the plugin locally first [18:39:10] seems to have a build failure [18:41:28] fixed in https://gerrit-review.googlesource.com/c/plugins/avatars-external/+/194510 [19:04:57] (03CR) 10Thcipriani: [C: 031] "Some nitpicks/questions inline" (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [19:34:21] 10Release-Engineering-Team, 10GitHub-Mirrors, 10User-greg: Requesting access to the 'wikimedia' organization at GitHub for MarcoAurelio - https://phabricator.wikimedia.org/T201259 (10MarcoAurelio) >>! In T201259#4543884, @greg wrote: > I am supportive of this. Added. Thanks for your on-going work here. Than... [19:37:59] !log github: deleted mirror of extension-MwEmbedSupport per T197918 [19:38:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:38:03] T197918: Archive the MwEmbedSupport extension - https://phabricator.wikimedia.org/T197918 [19:38:05] !log bring integration-slave-docker-1025 back online [19:38:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:51:40] mutante avatar change works https://gerrit.git.wmflabs.org/r/q/status:open ! [19:53:20] hmm [19:53:25] paladox.png is not loading [20:00:21] i think i have the fix [20:17:40] mutante got it working now! [20:18:03] paladox: great! i'll get back to it soon. too many things at once :) [20:19:07] ok :) [20:19:21] mutante i tested it using the plugin too so i know it works now :) [20:19:24] (no failures) [20:19:36] :) [20:21:15] !log github: added standard description to https://github.com/wikimedia/mediawiki-extensions-FundraisingEmailUnsubscribe [20:21:18] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:21:28] (03PS9) 10Dduvall: Publish job duration for labeled nodes to labmon1001 [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) [20:23:46] (03CR) 10Dduvall: "Working test job here: https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-hhvm-docker-debug/13/console" (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [20:24:25] (03CR) 10jerkins-bot: [V: 04-1] Publish job duration for labeled nodes to labmon1001 [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [20:25:46] greg-g: It looks like the trimmed-down Monday schedule for Labor Day was carried over to next Monday and the Monday after as well. Am I correct in assuming that's a mistake, and is it OK if I fix it on the wiki page? [20:26:13] (03PS10) 10Dduvall: Publish job duration for labeled nodes to labmon1001 [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) [20:27:29] (03CR) 10jerkins-bot: [V: 04-1] Publish job duration for labeled nodes to labmon1001 [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [20:28:24] (03PS11) 10Dduvall: Publish job duration for labeled nodes to labmon1001 [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) [20:31:46] !log github: deleting https://github.com/wikimedia/mediawiki-extensions-SemanticLinks mirror for T199422 [20:31:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:31:51] T199422: Archive the SemanticLinks extension - https://phabricator.wikimedia.org/T199422 [20:34:45] !log github: deleting https://github.com/wikimedia/mediawiki-extensions-SemanticExpressiveness mirror for T199417 [20:34:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:34:50] T199417: Archive the Semantic Expressiveness extension - https://phabricator.wikimedia.org/T199417 [20:37:18] (03CR) 10Thcipriani: [C: 031] "LGTM, will let you deploy and +2" [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [20:47:48] !log Deploying https://gerrit.wikimedia.org/r/c/integration/config/+/455269 for 18 affected jobs [20:47:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:49:17] (03CR) 10Dduvall: [C: 032] "Updated affected jobs:" [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [20:51:23] (03Merged) 10jenkins-bot: Publish job duration for labeled nodes to labmon1001 [integration/config] - 10https://gerrit.wikimedia.org/r/455269 (https://phabricator.wikimedia.org/T201972) (owner: 10Dduvall) [21:00:10] 10MediaWiki-Codesniffer: Add sniff to prevent using config globals when Config is available - https://phabricator.wikimedia.org/T200679 (10MGChecker) Is this a recommendation that is valid in any cases? Is there any documentation about this? [21:24:26] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 10Technical-Debt: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7 - https://phabricator.wikimedia.org/T178136 (10MGChecker) I would appreciate a sniff checking if type hints from the documentation are actually se... [21:39:36] 13thcipriani: test [21:40:04] that is colourful [21:40:12] :) [22:02:08] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10ArticlePlaceholder, 10Wikidata, and 2 others: ArticlePlaceholder should use MediaWiki qunit runner - https://phabricator.wikimedia.org/T180171 (10hashar) a:03hashar [22:18:57] (03PS1) 10Thcipriani: Maintenance: disconnect full disk notifications [integration/config] - 10https://gerrit.wikimedia.org/r/456508 [22:24:17] Project beta-scap-eqiad build #220675: 04FAILURE in 42 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220675/ [22:25:22] Project beta-scap-eqiad build #220676: 04STILL FAILING in 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220676/ [22:25:45] ^ /me fixes [22:49:49] Yippee, build fixed! [22:49:50] Project beta-scap-eqiad build #220677: 09FIXED in 16 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220677/ [23:11:03] (03CR) 10Legoktm: "Shallow clones break the git-changed-in-head script, so it thinks that literally every file was changed." [integration/config] - 10https://gerrit.wikimedia.org/r/405722 (https://phabricator.wikimedia.org/T179963) (owner: 10Hashar) [23:11:42] (03PS1) 10Legoktm: Revert "Use shallow clone for phplint jobs" [integration/config] - 10https://gerrit.wikimedia.org/r/456515 [23:19:19] (03CR) 10Legoktm: [C: 032] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/456515 (owner: 10Legoktm) [23:21:48] (03Merged) 10jenkins-bot: Revert "Use shallow clone for phplint jobs" [integration/config] - 10https://gerrit.wikimedia.org/r/456515 (owner: 10Legoktm) [23:26:52] paladox: regarding avatars, perhaps it would be useful if we connect it with Phabricator via LDAP username, and use that avatar automatically? [23:27:12] I will help to not need everybody to maintain a separate location and system for avatar [23:27:13] Krinkle phabricator would be too slow [23:27:25] we did try that but the backend was too slow [23:27:56] ie it was slow to find the users avatar then load it. [23:28:14] The user request for avatar from Gerit does not have to wait for Phabricator - if it is automatically generated by a script every hour, for example. [23:28:21] and then loaded from a local store. [23:28:43] Oh you mean a script pulls in the users avatar from phab and uploads to All-Avatars? [23:29:45] I am hoping Gerrit has a way to not require using All-Avatars, but something more direct. But yes, if it can only work with that repository, then that could also work. We would restrict the repository to only the bot that uploads it there. That is a good idea. [23:30:39] "We would restrict the repository to only the bot that uploads it there. That is a good idea." yep. [23:30:58] though i created a trusted group for that repo so it should already be secure :) [23:31:12] but yeh it would be nice for a bot to pull in a users profile image [23:31:14] from phab [23:31:57] If the user does not have a Phabricator account, or if their Phabricator account has only mediawiki.org connection, then we can explain in documentation that to get an avatar, connect your Wikimedia Developer account with Phabricator. [23:32:39] yep [23:33:43] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: Get rid of the check pipeline - https://phabricator.wikimedia.org/T192217 (10Krinkle) [23:34:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: Remove the "check" pipeline and Zuul's user-filter - https://phabricator.wikimedia.org/T192217 (10Krinkle) [23:48:40] Krinkle: what is the user-filter? [23:48:51] legoktm: whitelist for 'test' pipeline [23:49:04] then that's not what that task is about... [23:49:38] that task is about getting rid of the whitelist [23:49:54] I did say whitelist. [23:50:07] whitelist for 'test' pipeline [23:50:14] I am confused. [23:50:51] :) [23:50:56] I mean https://phabricator.wikimedia.org/T192217 was about eliminating the check pipeline and just having everyone use test, unconditionally [23:51:08] so we wouldn't have any whitelist at all [23:52:12] legoktm: Yes. [23:52:42] (Getting rid of|Removing) the "check" pipeline *and* Zuul's (user filter | whitelist) [23:52:49] ohhhh [23:52:50] got it [23:53:03] I totally misread it [23:53:12] Please do tell. I don't see it. [23:53:28] my mind read it as "Remove the check pipeline and use Zuul's user-filter" [23:53:35] Oh, right. [23:53:37] which I don't really see how that happened [23:53:42] * legoktm slaps brain