[03:41:37] (03PS1) 10Legoktm: Drop ruby poolcounter job [integration/config] - 10https://gerrit.wikimedia.org/r/457077 [03:54:33] (03PS7) 10Legoktm: Detect nesting of inline ternary statements without parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/449149 (https://phabricator.wikimedia.org/T171520) (owner: 10PleaseStand) [03:54:42] (03CR) 10Legoktm: Detect nesting of inline ternary statements without parentheses (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/449149 (https://phabricator.wikimedia.org/T171520) (owner: 10PleaseStand) [03:57:26] (03CR) 10Legoktm: [C: 032] preg_quote should not be used with 1 argument [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/456896 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [03:58:16] (03PS8) 10Legoktm: Detect nesting of inline ternary statements without parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/449149 (https://phabricator.wikimedia.org/T171520) (owner: 10PleaseStand) [03:59:03] (03Merged) 10jenkins-bot: preg_quote should not be used with 1 argument [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/456896 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [03:59:41] (03CR) 10jenkins-bot: preg_quote should not be used with 1 argument [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/456896 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [04:08:23] (03CR) 10Legoktm: [C: 032] Detect nesting of inline ternary statements without parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/449149 (https://phabricator.wikimedia.org/T171520) (owner: 10PleaseStand) [04:09:24] (03Merged) 10jenkins-bot: Detect nesting of inline ternary statements without parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/449149 (https://phabricator.wikimedia.org/T171520) (owner: 10PleaseStand) [04:10:00] (03CR) 10jenkins-bot: Detect nesting of inline ternary statements without parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/449149 (https://phabricator.wikimedia.org/T171520) (owner: 10PleaseStand) [04:13:25] (03PS1) 10Legoktm: Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 [04:14:17] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff that preg_quote should not be used with 1 argument - https://phabricator.wikimedia.org/T203312 (10Legoktm) 05Open>03Resolved a:03Umherirrender [04:14:32] 10MediaWiki-Codesniffer, 10Patch-For-Review: Create a sniff for nested ternary operators without parentheses - https://phabricator.wikimedia.org/T171520 (10Legoktm) 05Open>03Resolved a:03PleaseStand [04:16:15] 10MediaWiki-Codesniffer: Add sniff to remove semicolon after class declaration - https://phabricator.wikimedia.org/T202922 (10Legoktm) @Umherirrender is this taken care of by https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/455626 ? [04:16:49] (03CR) 10Legoktm: [C: 04-1] Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 (owner: 10Legoktm) [04:19:13] (03PS1) 10Legoktm: Disable 'Generic.PHP.DeprecatedFunctions' sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457079 (https://phabricator.wikimedia.org/T201524) [04:25:32] 10MediaWiki-Codesniffer: Should point out `while ( count( $arr ) ) {` should be just `while ( $arr ) {` - https://phabricator.wikimedia.org/T200028 (10Legoktm) This is only true if $arr is an array I think. If $arr was a class that implemented [[https://secure.php.net/manual/en/class.countable.php|Countable]], t... [04:31:24] 10MediaWiki-Codesniffer: PHPCS Internal error when using SPDX license expressions like OR - https://phabricator.wikimedia.org/T195429 (10Legoktm) >>! In T195429#4531543, @Umherirrender wrote: > So the question: Is a combined license deprecated when a part is deprecated? I would say yes, because the part needs fi... [04:40:08] (03PS2) 10Legoktm: Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 [06:29:35] PROBLEM - Puppet errors on deployment-zotero01 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [07:04:35] RECOVERY - Puppet errors on deployment-zotero01 is OK: OK: Less than 1.00% above the threshold [0.0] [07:12:10] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff that preg_quote should not be used with 1 argument - https://phabricator.wikimedia.org/T203312 (10thiemowmde) 05Resolved>03Open Oh, wait. Using `preg_quote` with no argument is entirely valid: ```lang=php $regex = preg_quote( $searchString ); preg_matc... [07:15:31] (03CR) 10Thiemo Kreuz (WMDE): "Oh noes. Please don't do this." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/456896 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [07:33:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "As far as I can see we don't provide a list of deprecated functions. This also has nothing to do with @deprecated tags in our documentatio" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457079 (https://phabricator.wikimedia.org/T201524) (owner: 10Legoktm) [07:37:27] 10MediaWiki-Codesniffer: Should point out `while ( count( $arr ) ) {` should be just `while ( $arr ) {` - https://phabricator.wikimedia.org/T200028 (10thiemowmde) Uh. ```lang=php while ( count( $array ) ) { $lastElement = array_pop( $array ); } ``` Even if I agree that code like this is odd and should be rew... [08:13:06] (03PS1) 10Umherirrender: Revert "preg_quote should not be used with 1 argument" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457085 (https://phabricator.wikimedia.org/T203312) [08:13:19] (03CR) 10Umherirrender: [C: 032] Revert "preg_quote should not be used with 1 argument" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457085 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [08:14:30] (03Merged) 10jenkins-bot: Revert "preg_quote should not be used with 1 argument" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457085 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [08:15:00] (03CR) 10jenkins-bot: Revert "preg_quote should not be used with 1 argument" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457085 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [08:15:45] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff that preg_quote should not be used with 1 argument - https://phabricator.wikimedia.org/T203312 (10Umherirrender) I have never seen brackets as delimiter, but it is okay from documentation http://php.net/manual/de/regexp.reference.delimiters.php and such br... [08:16:29] (03PS2) 10Umherirrender: Disable 'Generic.PHP.DeprecatedFunctions' sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457079 (https://phabricator.wikimedia.org/T201524) (owner: 10Legoktm) [08:16:33] (03CR) 10Umherirrender: [C: 032] Disable 'Generic.PHP.DeprecatedFunctions' sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457079 (https://phabricator.wikimedia.org/T201524) (owner: 10Legoktm) [08:16:55] (03PS3) 10Umherirrender: Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 (owner: 10Legoktm) [08:18:55] (03Merged) 10jenkins-bot: Disable 'Generic.PHP.DeprecatedFunctions' sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457079 (https://phabricator.wikimedia.org/T201524) (owner: 10Legoktm) [08:19:24] (03CR) 10jenkins-bot: Disable 'Generic.PHP.DeprecatedFunctions' sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457079 (https://phabricator.wikimedia.org/T201524) (owner: 10Legoktm) [08:19:26] (03PS4) 10Umherirrender: Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 (owner: 10Legoktm) [08:19:36] (03CR) 10Umherirrender: [C: 031] Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 (owner: 10Legoktm) [08:21:14] 10MediaWiki-Codesniffer: Add sniff that preg_quote should not be used with 1 argument - https://phabricator.wikimedia.org/T203312 (10Umherirrender) a:05Umherirrender>03None [08:28:56] 10MediaWiki-Codesniffer: Add sniff to remove semicolon after class declaration - https://phabricator.wikimedia.org/T202922 (10Umherirrender) `PSR2.Classes.ClassDeclaration` would detect the issue as `PSR2.Classes.ClassDeclaration.CloseBraceSameLine` when the closing `}` is not on a line by itself (except whitesp... [10:04:42] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-MediaWikiFarm, 10Patch-For-Review: CI failure for MediaWikiFarm (says unable to merge, but change is up to date) - https://phabricator.wikimedia.org/T202224 (10Zoranzoki21) [10:24:29] Project beta-scap-eqiad build #220889: 04FAILURE in 1 min 32 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220889/ [10:25:48] Project beta-scap-eqiad build #220890: 04STILL FAILING in 21 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220890/ [10:28:19] 10:24:28 warning: unable to access '/mnt/home/jenkins-deploy/.config/git/attributes': Permission denied [10:29:07] 10:24:28 error: The last gc run reported the following. Please correct the root cause [10:29:07] 10:24:28 and remove .git/gc.log. [10:33:08] 10MediaWiki-Releasing, 10Growth-Team, 10Thanks, 10MW-1.32-release: Bundle Thanks extension with MW 1.32 - https://phabricator.wikimedia.org/T191739 (10Liuxinyu970226) [10:33:11] 10MediaWiki-Releasing, 10Growth-Team, 10Notifications, 10MW-1.32-release: Bundle Echo extension with MW 1.32 - https://phabricator.wikimedia.org/T191738 (10Liuxinyu970226) [10:34:01] Project beta-scap-eqiad build #220891: 04STILL FAILING in 16 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220891/ [10:44:04] Project beta-scap-eqiad build #220892: 04STILL FAILING in 17 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220892/ [10:54:01] Project beta-scap-eqiad build #220893: 04STILL FAILING in 15 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220893/ [11:04:03] Project beta-scap-eqiad build #220894: 04STILL FAILING in 17 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220894/ [11:14:04] Project beta-scap-eqiad build #220895: 04STILL FAILING in 16 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220895/ [11:24:07] Project beta-scap-eqiad build #220896: 04STILL FAILING in 17 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220896/ [11:32:22] ^ looking, don't promise anything tho [11:33:57] Project beta-scap-eqiad build #220897: 04STILL FAILING in 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220897/ [11:43:58] Project beta-scap-eqiad build #220898: 04STILL FAILING in 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220898/ [11:54:02] Project beta-scap-eqiad build #220899: 04STILL FAILING in 15 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220899/ [12:04:02] Project beta-scap-eqiad build #220900: 04STILL FAILING in 15 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220900/ [12:14:02] Project beta-scap-eqiad build #220901: 04STILL FAILING in 16 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220901/ [12:15:08] Krenair: got a minute to look at ^^ [12:15:10] ? [12:18:24] gc is failing [12:18:27] per "12:14:02 error: The last gc run reported the following. Please correct the root cause" [12:18:40] /usr/bin/git gc --quiet --auto [12:22:11] paladox: https://phabricator.wikimedia.org/P7508 [12:22:41] oh permission errors [12:22:44] also, there's no '/mnt/home/jenkins-deploy/.config/git/attributes' [12:22:53] so unable to access '/mnt/home/jenkins-deploy/.config/git/attributes' [12:22:58] makes not much sense to me [12:23:23] /mnt/home/jenkins-deploy/.config/git/attributes is a git feature [12:23:25] can be ignored [12:23:37] aha [12:23:46] so I'll just fix permissions for mediawiki-staging [12:23:54] yep [12:23:55] there are some files owned by reedy and thcipriani [12:24:02] Project beta-scap-eqiad build #220902: 04STILL FAILING in 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220902/ [12:24:09] portals and scap [12:24:28] chmod 775 jenkins-deploy wikidev portals ? [12:24:42] i thnk it's chown? [12:24:59] chown wikidev:portals [12:25:24] maurelio@deployment-deploy01:/srv/mediawiki-staging$ sudo -u jenkins-deploy chmod 775 scap [12:25:24] chmod: changing permissions of 'scap': Operation not permitted [12:25:39] ok [12:26:18] I'm 'root' now [12:26:40] ok [12:27:36] fixed [12:27:53] oops, missed -R [12:28:41] heh [12:28:43] thanks [12:28:49] !log root@deployment-deploy01:/srv/mediawiki-staging# chown -R jenkins-deploy:wikidev portals scap | fixing beta-scap-update-equiad failures [12:28:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:30:17] still failing 'sudo -u jenkins-deploy scap deploy-mediawiki' [12:30:21] :| [12:30:48] STDERR: [12:30:55] STDERR: [12:30:55] /usr/bin/find: cannot delete \u2018./.gitignore\u2019: Permission denied [12:31:00] bah [12:31:07] I'll check it further after lunch [12:33:59] Project beta-scap-eqiad build #220903: 04STILL FAILING in 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220903/ [12:42:09] eqiad* [12:43:58] Project beta-scap-eqiad build #220904: 04STILL FAILING in 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220904/ [12:48:48] !log deployment-deploy01: `sudo rm /srv/mediawiki/.git/gc.log` to clear error about permissions problems accessing nonexistent file. [12:48:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:52:05] (it's running fine now) [12:53:22] Hauskatze, eqiad* [12:53:38] Krenair: is it? [12:53:42] yes [12:53:44] you wrote equiad [12:53:58] ehm... I don't think I had to write that [12:54:05] maybe somebody else? [12:54:07] Project beta-scap-eqiad build #220905: 04STILL FAILING in 21 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220905/ [12:54:13] *facepalm* [12:54:29] ... huh [12:54:32] that's a new error [12:54:40] but it just ran fine for me? [12:54:43] I was about to root@... chown -R mwdeploy mwdeploy mediawiki-staging [12:54:57] **root@... chown -R mwdeploy:mwdeploy mediawiki-staging [12:55:10] maybe we just saw a problem running simultaneous scaps, though I would expect the scap lock to stop that [12:55:46] "mediawiki" is owned by mwdeploy:mwdeploy; "mediawiki-staging" is owned by jenkins-deploy:wikidev [12:56:58] I think it's supposed to be like that [12:57:26] aha [12:57:54] anyway I'm gonna let jenkins give it another go before mucking around with it more [12:57:59] wish I could trigger jenkins builds [12:59:17] this is how I see: https://phabricator.wikimedia.org/P7509 [13:00:04] wondering why chown doesn't rwxrwxr-x all of them though [13:03:51] it's running code-update [13:03:57] but that's working [13:04:21] and now beta-scap-eqiad [13:04:26] I think git stores some file permissions [13:05:19] for now it is not failing [13:05:37] like whether a file is executable etc [13:06:48] well it seems it is running now so probably you fixed it :D [13:10:33] "root@deployment-deploy01:/srv# chown -R jenkins-deploy:wikidev mediawiki-staging/" was the last thing I did like 10 min ago [13:14:10] that seems to be working so I'm gonna go do other stuff [13:15:12] if it doesn't work out, try to avoid doing anything drastic in mediawiki-staging, I have a feeling it might be a bit of a rabbit hole to recreate properly [13:16:23] two folders were owned by re-edy and th-cipriani so I had to root myself [13:16:30] (I don't like to sudo -u ) [13:16:44] but if it fails I'll just open a task [13:17:11] that said it's working apparently so I'm back at taxes [13:17:29] Project beta-scap-eqiad build #220906: 04STILL FAILING in 13 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220906/ [13:18:40] damn [13:19:11] annot create regular file '/srv/mediawiki-staging/php-master/cache/l10n/l10n_cache-ab.cdb': Permission denied [13:19:14] looking [13:22:52] so those l10n.* are rw-rw-rw- but should be rwxrwxrwx as the whole lot of others inside that folder [13:26:09] !log maurelio@deployment-deploy01:/srv/mediawiki-staging/php-master/cache$ sudo -u jenkins-deploy chmod -R 777 l10n/ | more permissions fixes for beta-scap-eqiad [13:26:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:28:53] and another build started, crossing fingers [13:33:44] Yippee, build fixed! [13:33:44] Project beta-scap-eqiad build #220907: 09FIXED in 15 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/220907/ [13:33:54] \o/ [16:42:51] 10Phabricator: Phabricator edit registered multiple times - https://phabricator.wikimedia.org/T185201 (10Aklapper) 05Open>03stalled Setting to stalled as we need reliable steps to reproduce the problem. [19:49:13] PROBLEM - Host deployment-certcentral02 is DOWN: CRITICAL - Host Unreachable (10.68.23.13) [19:51:34] PROBLEM - Host deployment-certcentral-testclient02 is DOWN: CRITICAL - Host Unreachable (10.68.16.95) [20:04:42] 10MediaWiki-Releasing, 10AbuseFilter, 10MW-1.32-release: Bundle AbuseFilter extension with MW 1.32 - https://phabricator.wikimedia.org/T191740 (10Legoktm) >>! In T191740#4427131, @Daimona wrote: > I guess "Extension's default configuration provides optimal experience" is satisfied, but is there a specific re... [20:52:04] (03CR) 10Legoktm: "Ack, thanks for the comment and quick revert!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/456896 (https://phabricator.wikimedia.org/T203312) (owner: 10Umherirrender) [21:00:20] (03CR) 10Legoktm: [C: 032] Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 (owner: 10Legoktm) [21:02:03] (03Merged) 10jenkins-bot: Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 (owner: 10Legoktm) [21:03:03] (03CR) 10jenkins-bot: Release 22.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/457078 (owner: 10Legoktm) [21:03:51] oh, another flood of libraryupgrader bumps :D [21:04:05] jenkins be nice to you [21:51:05] (03PS1) 10MGChecker: phan and seccheck for Variables [integration/config] - 10https://gerrit.wikimedia.org/r/457109 (https://phabricator.wikimedia.org/T203364) [21:52:29] (03CR) 10jerkins-bot: [V: 04-1] phan and seccheck for Variables [integration/config] - 10https://gerrit.wikimedia.org/r/457109 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [21:58:26] (03PS2) 10MGChecker: phan and seccheck for Variables [integration/config] - 10https://gerrit.wikimedia.org/r/457109 (https://phabricator.wikimedia.org/T203364) [22:09:54] PROBLEM - Puppet errors on deployment-sca01 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [22:11:16] sigh [22:11:38] what's sca01 being used for? [22:25:50] !log maurelio@deployment-sca01:~$ sudo puppet agent -tv | attempting to fix " PROBLEM - Puppet errors on deployment-sca01 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0]" [22:25:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:34:54] RECOVERY - Puppet errors on deployment-sca01 is OK: OK: Less than 1.00% above the threshold [0.0] [22:35:22] oh, looks like it fixed it [23:03:48] 10Phabricator, 10MediaWiki-Authentication-and-authorization, 10Browser-Support-Android-Google-Chrome: [Bug] [Android Chrome Dev] Logging into Phabricator with MediaWiki authorization causes infinite reload loop - https://phabricator.wikimedia.org/T136086 (10Liuxinyu970226) [23:14:32] Hauskatze, what did you end up changing to fix it? [23:15:05] Krenair: sudo puppet agent -tv [23:15:21] weird [23:15:32] indeed [23:15:46] it complained about space or something as well [23:16:48] if there was any puppet error the puppet agent run would've let me know, and I could open a task [23:16:50] but it worked well [23:16:50] looks like it still is complaining about space [23:16:50] that I don't know where/how to fix [23:17:06] there's not much puppet errors/how-to docs [23:17:54] that's because generally if puppet is failing, someone has set something up incorrectly [23:18:54] or inadvertently broken something [23:19:11] WARNING: deployment-prep.deployment-sca01.diskspace._var.byte_percentfree (No valid datapoints found [23:19:26] yeah there's no valid datapoints found... there *is* no /var partition there [23:21:39] so something must've made it at some point then something got rid of it [23:43:04] Krenair: beta cluster puppet maintenance, where the mess lives :) [23:44:14] enough for today for me, good night