[06:07:06] <wikibugs>	 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Someday), 10Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041 (10Dzahn) Great work to keep this up to date to use the current API methods and not rely on some d...
[07:35:21] <mdholloway>	 !log deployment-mcs01 deployed [mobileapps/deploy@bf09080]: Update mobileapps to 7878ffc
[07:35:25] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[08:40:08] <wmf-insecte>	 maintenance-disconnect-full-disks build 6577 integration-slave-docker-1041 (/srv: 99%): OFFLINE due to disk space
[08:40:58] <shinken-wm>	 PROBLEM - Free space - all mounts on integration-slave-docker-1041 is CRITICAL: CRITICAL: integration.integration-slave-docker-1041.diskspace._srv.byte_percentfree (<50.00%)
[08:55:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6580 integration-slave-docker-1041: OFFLINE due to disk space
[09:10:57] <shinken-wm>	 RECOVERY - Free space - all mounts on integration-slave-docker-1041 is OK: OK: All targets OK
[09:20:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6585 integration-slave-docker-1041: OFFLINE due to disk space
[09:39:45] <wikibugs>	 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Watching / External), 10Operations, 10Wikimedia-Logstash: logstash-beta.wmflab throws multiple "Error: Could not locate that visualization" - https://phabricator.wikimedia.org/T204845 (10MoritzMuehlenhoff) p:05Triage>03Normal
[09:40:11] <wikibugs>	 10Beta-Cluster-Infrastructure, 10Analytics-Kanban, 10Operations, 10Patch-For-Review, and 2 others: Prometheus resources in deployment-prep to create grafana graphs of EventLogging - https://phabricator.wikimedia.org/T204088 (10MoritzMuehlenhoff) p:05Triage>03Normal
[09:45:06] <wmf-insecte>	 maintenance-disconnect-full-disks build 6590 integration-slave-docker-1041: OFFLINE due to disk space
[09:45:14] <wikibugs>	 10Release-Engineering-Team (Watching / External), 10Scap, 10Operations, 10Datacenter-Switchover-2018, 10Wikimedia-Incident: Scap is checking canary servers in dormant instead of active-dc - https://phabricator.wikimedia.org/T204907 (10akosiaris) a:03akosiaris
[10:10:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6595 integration-slave-docker-1041: OFFLINE due to disk space
[10:35:06] <wmf-insecte>	 maintenance-disconnect-full-disks build 6600 integration-slave-docker-1041: OFFLINE due to disk space
[11:00:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6605 integration-slave-docker-1041: OFFLINE due to disk space
[11:02:13] <wikibugs>	 10Scap, 10Datacenter-Switchover-2018: Scap canary warning monitoring URL is hard-coded with eqiad servers, so isn't useful when codfw is primary - https://phabricator.wikimedia.org/T205559 (10akosiaris)
[11:02:19] <wikibugs>	 10Release-Engineering-Team (Watching / External), 10Scap, 10Operations, 10Datacenter-Switchover-2018, 10Wikimedia-Incident: Scap is checking canary servers in dormant instead of active-dc - https://phabricator.wikimedia.org/T204907 (10akosiaris)
[11:09:20] <wikibugs>	 10Release-Engineering-Team (Watching / External), 10Scap, 10Operations, 10Datacenter-Switchover-2018, 10Wikimedia-Incident: Scap is checking canary servers in dormant instead of active-dc - https://phabricator.wikimedia.org/T204907 (10akosiaris) As far as solving the logstash URL I think the best approac...
[11:25:09] <wmf-insecte>	 maintenance-disconnect-full-disks build 6610 integration-slave-docker-1041: OFFLINE due to disk space
[11:50:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6615 integration-slave-docker-1041: OFFLINE due to disk space
[12:02:34] <wikibugs>	 (03PS1) 10Alex Monk: Allow ops to create tags [debs/prometheus-openstack-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/463458
[12:03:08] <wikibugs>	 (03CR) 10Arturo Borrero Gonzalez: [V: 032 C: 032] Allow ops to create tags [debs/prometheus-openstack-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/463458 (owner: 10Alex Monk)
[12:06:22] <wikibugs>	 (03PS1) 10Paladox: Modify access rules [debs/prometheus-openstack-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/463460
[12:07:19] <wikibugs>	 (03CR) 10Arturo Borrero Gonzalez: [V: 032 C: 032] Modify access rules [debs/prometheus-openstack-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/463460 (owner: 10Paladox)
[12:09:29] <wikibugs>	 (03PS2) 10Paladox: Modify access rules [debs/prometheus-openstack-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/463460
[12:09:43] <wikibugs>	 (03PS3) 10Paladox: Modify access rules [debs/prometheus-openstack-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/463460
[12:10:16] <wikibugs>	 (03PS4) 10Paladox: Modify access rules [debs/prometheus-openstack-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/463460
[12:15:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6620 integration-slave-docker-1041: OFFLINE due to disk space
[12:40:08] <wmf-insecte>	 maintenance-disconnect-full-disks build 6625 integration-slave-docker-1041: OFFLINE due to disk space
[12:44:20] <wikibugs>	 (03CR) 10Hashar: [C: 032] Decouple composer/npm run for extskin [integration/quibble] - 10https://gerrit.wikimedia.org/r/461998 (owner: 10Hashar)
[12:44:44] <wikibugs>	 (03CR) 10Hashar: [C: 032] Early return in extskin composer/npm test commands [integration/quibble] - 10https://gerrit.wikimedia.org/r/461999 (owner: 10Hashar)
[12:45:08] <wikibugs>	 (03Merged) 10jenkins-bot: Decouple composer/npm run for extskin [integration/quibble] - 10https://gerrit.wikimedia.org/r/461998 (owner: 10Hashar)
[12:45:26] <wikibugs>	 (03Merged) 10jenkins-bot: Early return in extskin composer/npm test commands [integration/quibble] - 10https://gerrit.wikimedia.org/r/461999 (owner: 10Hashar)
[12:45:36] <wikibugs>	 (03CR) 10jenkins-bot: Decouple composer/npm run for extskin [integration/quibble] - 10https://gerrit.wikimedia.org/r/461998 (owner: 10Hashar)
[12:45:57] <wikibugs>	 (03CR) 10jenkins-bot: Early return in extskin composer/npm test commands [integration/quibble] - 10https://gerrit.wikimedia.org/r/461999 (owner: 10Hashar)
[12:47:09] <wikibugs>	 (03CR) 10Hashar: [C: 04-1] "It does not fail fast enough :]" (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/462512 (owner: 10Hashar)
[12:50:51] <wikibugs>	 (03CR) 10Hashar: [C: 04-1] Parallelize ext/skin linter (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/462512 (owner: 10Hashar)
[12:55:17] <wikibugs>	 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.32.0-wmf.23 deployment blockers - https://phabricator.wikimedia.org/T191069 (10zeljkofilipin) 05Open>03Resolved Deployed to all wikis. No blockers reported, so resolving. Please reopen if needed.
[13:05:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6630 integration-slave-docker-1041: OFFLINE due to disk space
[13:30:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6635 integration-slave-docker-1041: OFFLINE due to disk space
[13:55:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6640 integration-slave-docker-1041: OFFLINE due to disk space
[14:20:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6645 integration-slave-docker-1041: OFFLINE due to disk space
[14:44:29] <wikibugs>	 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find top 15 target projects that could use Selenium tests to prevent incidents - https://phabricator.wikimedia.org/T199133 (10zeljkofilipin)
[14:44:47] <wikibugs>	 (03CR) 10Umherirrender: [C: 031] Update message to talk about "top level" instead of "file comment" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/438031 (owner: 10Thiemo Kreuz (WMDE))
[14:45:06] <wmf-insecte>	 maintenance-disconnect-full-disks build 6650 integration-slave-docker-1041: OFFLINE due to disk space
[14:50:01] <thcipriani>	 !log investigating integration-slave-docker-1041
[14:50:03] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[14:50:15] <wikibugs>	 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find top 15 target projects that could use Selenium tests to prevent incidents - https://phabricator.wikimedia.org/T199133 (10zeljkofilipin)
[14:54:53] <shinken-wm>	 PROBLEM - Puppet errors on integration-slave-jessie-1003 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0]
[14:55:38] <wikibugs>	 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find top 15 target projects that could use Selenium tests to prevent incidents - https://phabricator.wikimedia.org/T199133 (10zeljkofilipin)
[15:18:19] <wikibugs>	 10Gerrit, 10Patch-For-Review: Place holder task for Gerrit 2.16 upgrade - https://phabricator.wikimedia.org/T200739 (10Paladox)
[15:31:16] <Amir1>	 !log ladsgroup@deployment-deploy01:~$ mwscript extensions/CentralAuth/maintenance/deleteLocalPasswords.php --wiki=fawiki  --prefix (T201009)
[15:31:21] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[15:31:21] <stashbot>	 T201009: Run deleteLocalPasswords.php in WMF prod (Central Auth wikis only!) after 1.32.0-wmf.16 is everywhere - https://phabricator.wikimedia.org/T201009
[15:33:29] <wikibugs>	 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find top 15 target projects that could use Selenium tests to prevent incidents - https://phabricator.wikimedia.org/T199133 (10zeljkofilipin)
[15:34:54] <shinken-wm>	 RECOVERY - Puppet errors on integration-slave-jessie-1003 is OK: OK: Less than 1.00% above the threshold [0.0]
[15:37:16] <wikibugs>	 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find top 15 target projects that could use Selenium tests to prevent incidents - https://phabricator.wikimedia.org/T199133 (10zeljkofilipin)
[15:38:18] <wikibugs>	 10Gerrit, 10Patch-For-Review: Place holder task for Gerrit 2.16 upgrade - https://phabricator.wikimedia.org/T200739 (10Paladox)
[15:50:50] <wikibugs>	 10Gerrit, 10Patch-For-Review: Place holder task for Gerrit 2.16 upgrade - https://phabricator.wikimedia.org/T200739 (10Paladox)
[16:35:38] <wikibugs>	 (03PS1) 10Legoktm: jenkins-debian-glue: Skip autopkgtests [integration/config] - 10https://gerrit.wikimedia.org/r/463507
[16:36:45] <wikibugs>	 (03CR) 10Legoktm: "I read through <https://github.com/mika/jenkins-debian-glue/blob/master/scripts/build-and-provide-package> to find this environment variab" [integration/config] - 10https://gerrit.wikimedia.org/r/463507 (owner: 10Legoktm)
[17:14:23] <paladox>	 thcipriani hmm, .gitfat looks broken with the latest git version.
[17:14:32] * paladox gets
[17:14:33] <paladox>	 fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths
[17:17:14] <paladox>	 i belive this https://github.com/jedbrown/git-fat/pull/85 will fix it
[17:18:12] <paladox>	 oh
[17:18:13] <paladox>	 nvm
[17:18:30] <paladox>	 they need to update homebrew version
[18:02:37] <paladox>	 This is what dark mode in gerrit will look like for the wmf https://phabricator.wikimedia.org/F26230729 :)
[18:02:41] <paladox>	 (includes the logo)
[18:19:30] <paladox>	 thcipriani looks like only one change is needed to do the 2.16 upgrade https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/463519/ :)
[18:28:25] <wikibugs>	 10Gerrit, 10Patch-For-Review: Place holder task for Gerrit 2.16 upgrade - https://phabricator.wikimedia.org/T200739 (10Paladox)
[18:28:28] <wikibugs>	 10Gerrit: Deploy gerrit master (then 2.16) to gerrit.git.wmflabs.org - https://phabricator.wikimedia.org/T205346 (10Paladox) 05Open>03Resolved a:03Paladox Upgrade was successful!
[19:17:15] <mutante>	 Phabricator will be inaccessible for a minute. The server needs to be rebooted. It will be back asap.
[19:24:36] <Krinkle>	 paladox: check phabricator header for a guideline-compatible way to use the logo (white logo, dark background). Alternatively, we could have black on a very bright blue shade or white. Or the current logo, only on white. 
[19:24:55] <paladox>	 Krinkle note that dark mode is included by default.
[19:25:02] <paladox>	 that was not made by me :)
[19:25:05] <paladox>	 it's in gerrit core
[19:25:08] <Krinkle>	 I'm referring to the blue/logo header I pointed out last time
[19:25:12] <paladox>	 ah
[19:25:17] <paladox>	 ok
[19:25:27] <paladox>	 the white logo would do both dark and the normal one
[19:25:52] <paladox>	 I belive we could just make a svg version of the png
[19:26:04] <paladox>	 seeing as polygerrit does not work on old browsers
[19:26:28] <mutante>	 yay for dark mode
[19:28:07] <paladox>	 :)
[19:28:28] <paladox>	 Krinkle the white logo would be preferable i guess.
[19:28:51] <Krinkle>	 paladox: Yeah, but will require a darker blue bar. the blue is too bright/low contrast
[19:28:54] <paladox>	 That way we could make the header blue 
[19:29:04] <paladox>	 yep
[19:29:09] <Krinkle>	 in any mode, not just dark mode
[19:29:33] <mutante>	 paladox: http://blackle.com/
[19:29:41] <paladox>	 heh
[19:30:15] <mutante>	 that's what i think about when i said it's saving energy. see the "7,070,112.060 Watt hours saved" under the search window :P
[19:33:46] <paladox>	 heh
[19:37:27] <wikibugs>	 10Continuous-Integration-Infrastructure: Update jobs to use zuul-cloner with git cache - https://phabricator.wikimedia.org/T97098 (10Krinkle)
[19:37:30] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Upstream, 10WorkType-NewFunctionality, 10Zuul: Zuul-cloner should use hard links when fetching from cache-dir - https://phabricator.wikimedia.org/T97106 (10Krinkle) 05Open>03Resolved a:03Krinkle This doesn't seem particularly relevant anymore with the newer...
[19:38:02] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Upstream, 10Wikimedia-production-error (Shared Build Failure), 10Zuul: Zuul-cloner failing to acquire .git lock sometimes - https://phabricator.wikimedia.org/T86730 (10Krinkle) 05Open>03Resolved a:03Krinkle Not seen in a while. Let's close this.
[19:47:43] <paladox>	 Krinkle like https://phabricator.wikimedia.org/F26231836 ?
[19:48:12] <paladox>	 and for dark mode: https://phabricator.wikimedia.org/F26231843
[19:48:40] <Krinkle>	 Yes, that's a white logo. But both the grey and the blue are too bright. Not enough contrast.
[19:48:52] <paladox>	 hmm i see
[19:48:58] <Krinkle>	 I don't know if the blue should be specific to dark mode, but if it is. then maybe a dark grey and dark blue.
[19:49:08] <Krinkle>	 see the phab toolbar for a good shade of dark blue to use
[19:49:14] <paladox>	 Krinkle i can create a bug report upstream.
[19:49:17] <Krinkle>	 then maybe the grescale version of that for regular mode, if you want it only on blue.
[19:49:21] <paladox>	 but what would i actually say to them?
[19:49:31] <Krinkle>	 This is not a bug in upstream.
[19:49:36] <Krinkle>	 The default grey is used for black text
[19:49:39] <Krinkle>	 that contrast is fine
[19:50:28] <paladox>	 Krinkle the blue header is dark mode :)
[19:50:37] <Krinkle>	 Our custom code should either use a black logo there on light grey, or we should update the customisation to override the background and header text color as well, not just the logo. (For regular mode).
[19:50:58] <Krinkle>	 paladox: is the grey text color on dark mode and the light blue background part of uptream dark mode?
[19:51:02] <paladox>	 yep
[19:51:10] <Krinkle>	 That seems like the text might need to be a bit brither by default for better accessibility contrast.
[19:51:23] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/master/polygerrit-ui/app/styles/themes/dark-theme.html
[19:52:10] <Krinkle>	 Well, yeah, that's an upstream issue. But for us we'll at least have to switch between black and white logo then
[19:52:24] <paladox>	 hmm
[19:52:31] <Krinkle>	 and upstream should consider making the grey text and icons brighter in dark mode.
[19:52:54] <Krinkle>	 there is probably a class name on <html> or <body> you can use to switch the css rule
[19:53:01] <Krinkle>	 (no javascript code needed)
[19:53:16] <paladox>	 Krqthere will be javascript needed to tell if your using dark mode
[19:53:19] <paladox>	 or the default
[19:53:22] <paladox>	 to change the logo
[19:53:34] <paladox>	 something like:
[19:53:42] <paladox>	 if (window.localStorage.getItem('dark-theme')) {
[19:54:30] <paladox>	 this.customStyle['<var>'] = 
[19:54:32] <paladox>	 }
[19:54:55] <Krinkle>	 No. The init code is responsible for determining the current state
[19:55:05] <Krinkle>	 our modification should only interact with the public interface
[19:55:23] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/master/polygerrit-ui/app/elements/gr-app.js#L141
[19:55:36] <paladox>	 hmm
[19:55:56] <paladox>	 Krinkle public interface?
[20:00:40] <paladox>	 Krinkle polygerrit uses polymer :)
[20:00:47] <paladox>	 which makes things alot easy to do this
[20:00:53] <paladox>	 using this.customStyle['<var>'] = <>
[20:01:07] <paladox>	 that overides what ever var we have set ^^
[20:01:51] <Krinkle>	 paladox: Yes, probaly some of the code there should do something like document.body.classList.toggle('gerrit-dark-theme');
[20:02:12] <Krinkle>	 I would expect that to already be the case, maybe buried somewhere inside. Do you have a live link that shows dark mode?
[20:02:20] <paladox>	 nope it's not like that :)
[20:02:21] <Krinkle>	 I can probably find a selector that would work
[20:02:26] <paladox>	 polymer has a import function
[20:02:42] <Krinkle>	 I know how that works.
[20:02:47] <Krinkle>	 That's for importing the theme itself.
[20:03:06] <paladox>	 yep
[20:03:08] <Krinkle>	 But we're not doing that. We're adding styles that should be responsive automatically based on themode
[20:03:13] <paladox>	 Krinkle but it uses vars
[20:03:18] <Krinkle>	 It needs to work even when you switch.
[20:03:27] <Krinkle>	 Yes, and the code can add a class name too.
[20:03:32] <paladox>	 in css
[20:03:33] <paladox>	 it dosen't change the classes
[20:03:38] <paladox>	 yehp
[20:03:43] <Krinkle>	 ... just ask upstream: How do I add a custom logo that is different for dark/regular mode.
[20:03:58] <Krinkle>	 you can make a patch that adds/changes a class.
[20:04:39] <paladox>	 ok
[20:05:00] <paladox>	 "Gerrit's dark theme is in early alpha, and almost definitely will not play nicely with themes set by specific Gerrit hosts. Filing feedback via the link in the app footer is strongly encouraged!"
[20:05:06] <paladox>	 they have that note when using the theme
[20:05:40] <Krinkle>	 This means they know it is missing a css class, and they will be happy to accept your patch to add a class.
[20:05:59] <paladox>	 where would i put the class though?
[20:06:58] <paladox>	 Krinkle but if (window.localStorage.getItem('dark-theme')) { would do right?
[20:07:04] <Krinkle>	 On an element in the HTML DOM that contains all the elements on the page, so that you can use it to change the logo or anything else. ".gerrit-dark-mode .my-logo { white } . gerrit-regular-mode { black; } "
[20:07:20] <Krinkle>	 paladox: I have answered this already, please re-read. Ask further questions to upstream.
[20:11:54] <paladox>	 Krinkle https://gerrit-review.googlesource.com/c/gerrit/+/197930
[20:42:04] <wikibugs>	 (03PS2) 10Hashar: Parallelize ext/skin linter [integration/quibble] - 10https://gerrit.wikimedia.org/r/462512
[20:44:30] <wikibugs>	 (03PS2) 10Hashar: Parallelize mediawiki/core linter [integration/quibble] - 10https://gerrit.wikimedia.org/r/462513
[20:46:52] <paladox>	 thcipriani marxarelli https://gerrit-review.googlesource.com/c/plugins/go-import/+/190630/3 :)
[21:37:42] <wikibugs>	 10Deployments, 10MediaWiki-Debug-Logger, 10Patch-For-Review, 10User-Tgr: Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086 (10Krinkle)
[21:37:45] <wikibugs>	 10Continuous-Integration-Config, 10MediaWiki-Debug-Logger, 10Patch-For-Review: Log suppressed errors with level=DEBUG - https://phabricator.wikimedia.org/T193472 (10Krinkle)
[22:15:07] <wmf-insecte>	 maintenance-disconnect-full-disks build 6740 integration-slave-docker-1034 (/srv: 95%): OFFLINE due to disk space