[00:25:50] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Legoktm) [00:28:00] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Legoktm) @Jdforrester-WMF I removed {T204420} as a blocker since so far testing shows that PHPUnit 6 seems to work fine on PHP 7.3. [01:12:54] (03PS1) 10Legoktm: Add the rest of bundled extensions into release-* jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/467550 [01:14:44] (03PS2) 10Legoktm: Add the rest of bundled extensions into release-* jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/467550 [02:55:45] 10Continuous-Integration-Infrastructure, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 2 others: Run MediaWiki tests on PHP 7.3 - https://phabricator.wikimedia.org/T204884 (10Legoktm) [02:56:16] 10Continuous-Integration-Infrastructure, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Run MediaWiki tests on PHP 7.3 - https://phabricator.wikimedia.org/T204884 (10Legoktm) [03:03:06] legoktm: Hm.. did the coverage artefacts go away? [03:03:17] I think there used to be a way to view the html report, right? [03:03:23] Maybe I'm looking at the wrong place [03:06:10] !log Rebooted deployment-deploy01 Jenkins slave (stuck for 8 hours) [03:06:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:06:57] Krinkle: https://phabricator.wikimedia.org/T206230 [03:07:23] legoktm: Ah, right. They're going to the docker images root /log [03:07:29] instead of workspace:log/, right? [03:07:42] they should be the same [03:07:53] log/ should be mounted as /log [03:07:57] the image's root / is the Jenkins workspace? [03:07:59] Oh, right [03:07:59] I haven't had a chance to investigate why it's not working yet [03:08:00] Maybe [03:46:56] post-merge build for https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/467315 apparently took 8 hours [03:59:45] (03PS1) 10Legoktm: docker: Add composer security-check.sh script [integration/config] - 10https://gerrit.wikimedia.org/r/467560 [03:59:47] (03PS1) 10Legoktm: [WIP] Refactor -composer-security into a matrix based job [integration/config] - 10https://gerrit.wikimedia.org/r/467561 [04:00:18] tgr: [20:06:10] !log Rebooted deployment-deploy01 Jenkins slave (stuck for 8 hours) [04:00:47] (03CR) 10Legoktm: [C: 032] docker: Add composer security-check.sh script [integration/config] - 10https://gerrit.wikimedia.org/r/467560 (owner: 10Legoktm) [04:02:36] (03Merged) 10jenkins-bot: docker: Add composer security-check.sh script [integration/config] - 10https://gerrit.wikimedia.org/r/467560 (owner: 10Legoktm) [04:04:07] !log deploying https://gerrit.wikimedia.org/r/467560 [04:04:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:12:09] (03PS2) 10Legoktm: [WIP] Refactor -composer-security into a matrix based job [integration/config] - 10https://gerrit.wikimedia.org/r/467561 [04:12:11] (03PS1) 10Legoktm: Install `curl` in composer image for security-check script [integration/config] - 10https://gerrit.wikimedia.org/r/467562 [04:12:37] (03CR) 10Legoktm: [C: 032] Install `curl` in composer image for security-check script [integration/config] - 10https://gerrit.wikimedia.org/r/467562 (owner: 10Legoktm) [04:14:18] (03Merged) 10jenkins-bot: Install `curl` in composer image for security-check script [integration/config] - 10https://gerrit.wikimedia.org/r/467562 (owner: 10Legoktm) [04:14:56] !log deploying https://gerrit.wikimedia.org/r/467562 [04:14:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:20:30] (03PS3) 10Legoktm: [WIP] Refactor -composer-security into a matrix based job [integration/config] - 10https://gerrit.wikimedia.org/r/467561 [04:20:32] (03PS1) 10Legoktm: Fix security-check's grep [integration/config] - 10https://gerrit.wikimedia.org/r/467563 [04:20:44] (03CR) 10Legoktm: [C: 032] Fix security-check's grep [integration/config] - 10https://gerrit.wikimedia.org/r/467563 (owner: 10Legoktm) [04:22:24] (03Merged) 10jenkins-bot: Fix security-check's grep [integration/config] - 10https://gerrit.wikimedia.org/r/467563 (owner: 10Legoktm) [04:22:44] !log deploying https://gerrit.wikimedia.org/r/467563 [04:22:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:49:04] (03PS4) 10Legoktm: Refactor -composer-security into a matrix based job [integration/config] - 10https://gerrit.wikimedia.org/r/467561 (https://phabricator.wikimedia.org/T180278) [04:51:39] (03PS1) 10Legoktm: Don't duplicate list of supported MediaWiki branches [integration/config] - 10https://gerrit.wikimedia.org/r/467567 [04:53:06] (03CR) 10Legoktm: [C: 032] Refactor -composer-security into a matrix based job [integration/config] - 10https://gerrit.wikimedia.org/r/467561 (https://phabricator.wikimedia.org/T180278) (owner: 10Legoktm) [04:54:15] 10Continuous-Integration-Config, 10Librarization, 10Security-team-backlog, 10Composer, and 2 others: Expand our usage of FriendsOfPHP/security-advisories - https://phabricator.wikimedia.org/T180278 (10Legoktm) {F26612728} [04:54:51] (03CR) 10Legoktm: [C: 032] "No-op" [integration/config] - 10https://gerrit.wikimedia.org/r/467567 (owner: 10Legoktm) [04:57:40] (03Merged) 10jenkins-bot: Refactor -composer-security into a matrix based job [integration/config] - 10https://gerrit.wikimedia.org/r/467561 (https://phabricator.wikimedia.org/T180278) (owner: 10Legoktm) [04:57:43] (03Merged) 10jenkins-bot: Don't duplicate list of supported MediaWiki branches [integration/config] - 10https://gerrit.wikimedia.org/r/467567 (owner: 10Legoktm) [06:05:50] 10Continuous-Integration-Infrastructure, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Run MediaWiki tests on PHP 7.3 - https://phabricator.wikimedia.org/T204884 (10Legoktm) [06:08:05] 10Continuous-Integration-Infrastructure, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Run MediaWiki tests on PHP 7.3 - https://phabricator.wikimedia.org/T204884 (10Legoktm) [06:37:27] 10Continuous-Integration-Config, 10Librarization, 10Security-team-backlog, 10Composer, and 2 others: Expand our usage of FriendsOfPHP/security-advisories - https://phabricator.wikimedia.org/T180278 (10Legoktm) Outside of MediaWiki extensions/skins (which I have a different plan for), what other repositorie... [07:31:26] 10Continuous-Integration-Config: Consider consolidating npm-test-* variants that install library dependencies - https://phabricator.wikimedia.org/T207087 (10hashar) At least for MediaWiki services (3d2png, graphoid, karthotherian, tilerator, mathoid), the plan is to move them to the deployment pipeline and Blubb... [07:34:21] 10Continuous-Integration-Infrastructure, 10SyntaxHighlight, 10Patch-For-Review: Failed to invoke Pygments: /usr/bin/env: python: No such file or directory - https://phabricator.wikimedia.org/T197601 (10hashar) [07:34:23] 10Continuous-Integration-Config, 10SyntaxHighlight: quibble-vendor-mysql-hhvm-docker failing on SyntaxHighlight_GeSHi due to "Failed to invoke Pygments: /usr/bin/env: python: No such file or directory" - https://phabricator.wikimedia.org/T207021 (10hashar) [07:35:11] 10Continuous-Integration-Config, 10SyntaxHighlight: quibble-vendor-mysql-hhvm-docker failing on SyntaxHighlight_GeSHi due to "Failed to invoke Pygments: /usr/bin/env: python: No such file or directory" - https://phabricator.wikimedia.org/T207021 (10hashar) It is a duplicate of {T197601} and there is {T182851}... [07:38:05] 10Deployments, 10MediaWiki-Debug-Logger, 10Patch-For-Review, 10User-Tgr: Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086 (10hashar) I wasn't aware of `$wgPropagateErrors`, indeed we no more need errors to be spurts to HHVM stdout (which is... [07:40:31] (03CR) 10Hashar: [C: 032] "It works:" [integration/config] - 10https://gerrit.wikimedia.org/r/467075 (https://phabricator.wikimedia.org/T206913) (owner: 10Jean-Frédéric) [07:40:57] (03CR) 10Hashar: [C: 04-2] Increase timeout for labs-tools-heritage tox job [integration/config] - 10https://gerrit.wikimedia.org/r/467075 (https://phabricator.wikimedia.org/T206913) (owner: 10Jean-Frédéric) [07:43:26] (03PS3) 10Hashar: Increase timeout for labs-tools-heritage tox job [integration/config] - 10https://gerrit.wikimedia.org/r/467075 (https://phabricator.wikimedia.org/T206913) (owner: 10Jean-Frédéric) [07:48:38] (03CR) 10jerkins-bot: [V: 04-1] Increase timeout for labs-tools-heritage tox job [integration/config] - 10https://gerrit.wikimedia.org/r/467075 (https://phabricator.wikimedia.org/T206913) (owner: 10Jean-Frédéric) [07:50:03] (03CR) 10Hashar: [C: 032] Increase timeout for labs-tools-heritage tox job [integration/config] - 10https://gerrit.wikimedia.org/r/467075 (https://phabricator.wikimedia.org/T206913) (owner: 10Jean-Frédéric) [07:52:42] (03Merged) 10jenkins-bot: Increase timeout for labs-tools-heritage tox job [integration/config] - 10https://gerrit.wikimedia.org/r/467075 (https://phabricator.wikimedia.org/T206913) (owner: 10Jean-Frédéric) [07:55:02] (03CR) 10Hashar: [C: 032] Add back Selenium tests for Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/457675 (https://phabricator.wikimedia.org/T189762) (owner: 10Hashar) [07:57:05] (03Merged) 10jenkins-bot: Add back Selenium tests for Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/457675 (https://phabricator.wikimedia.org/T189762) (owner: 10Hashar) [08:00:36] 10Continuous-Integration-Config, 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit) - https://phabricator.wikimedia.org/T206913 (10hashar) 05Open>03Resolved Should be good now. Congratulations. [08:01:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, and 2 others: selenium test for Wikibase is unstable - https://phabricator.wikimedia.org/T189762 (10hashar) The selenium tests are triggered again on patchset proposals :] [08:13:44] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [08:14:12] hashar: Hey! We're doing some cleanup of broken tests on tilerator / wdqs puppet modules (well, onimisionipe is doing that) [08:14:41] rspec on those modules are disabled in "some way", but I can't find that "some way" [08:15:13] since those tests are not broken anymore, we can re-enable them. Any idea where that is? [08:18:45] 10Continuous-Integration-Infrastructure (shipyard): XDebug should be disabled in composer-package-php70-docker jobs - https://phabricator.wikimedia.org/T188363 (10hashar) | Job | Image | Xdebug? |--|--|-- | [[ https://integration.wikimedia.org/ci/job/composer-package-php55-docker/ | composer-package-php55-docker... [08:23:43] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [08:25:00] gehel: rake_modules/taskgen.rb: ignored_modules = ['mysql', 'osm', 'puppetdbquery', 'stdlib', 'wdqs', 'lvm', 'tilerator'] [08:25:03] gehel: you are welcome :] [08:25:30] hashar: thanks! I knew it was "somewhere" ! [08:25:33] onimisionipe: ^ [08:27:26] then to test locally : bundle install [08:27:29] cd modules/wdqs [08:27:32] bundle exec rake spec [08:28:17] for tilerator hmm I don't know it lacks a spec_helper.rb / rakefile etc [08:28:28] hashar, gehel: Thanks for this! [08:30:52] hashar: yep, we completely removed the tests for tilerator, they were useless [08:34:20] (03PS2) 10Hashar: Remove some no-op branch filters [integration/config] - 10https://gerrit.wikimedia.org/r/463912 (owner: 10Legoktm) [08:46:14] 10Continuous-Integration-Config, 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Increase CI timeout for labs-tools-heritage tests (both test and gate-and-submit) - https://phabricator.wikimedia.org/T206913 (10JeanFred) Thanks for your guidance @hashar ! [08:47:07] onimisionipe: gehel let me know if you have troubles running specs of wdqs [08:47:19] hashar: wilco [09:08:59] (03CR) 10Hashar: "PyYAML documentation at https://pyyaml.org/wiki/PyYAMLDocumentation mentions unicode vs str in the python 3 support section. Namely:" [integration/config] - 10https://gerrit.wikimedia.org/r/464643 (owner: 10Paladox) [09:10:27] PROBLEM - SSH on integration-slave-docker-1021 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [09:46:16] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10Marostegui) [09:54:05] 10Release-Engineering-Team (Watching / External), 10Operations, 10Release Pipeline (Blubber): Update Debian package of Blubber (0.6.0-1) - https://phabricator.wikimedia.org/T206766 (10akosiaris) 05Open>03Resolved a:03akosiaris Package built and uploaded to both jessie-wikimedia and stretch-wikimedia [10:26:25] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10releng-201718-q3, 10Epic, and 2 others: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker - https://phabricator.wikimedia.org/T183512 (10hashar) [10:26:28] 10Continuous-Integration-Config, 10Wikidata, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10hashar) [10:28:22] 10Continuous-Integration-Config, 10Wikidata, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10hashar) >>! In T188717#4541201, @Addshore wrote: >>>! In T188717#4541195, @WMDE-leszek wrote: >> I guess it is kind of going to be... [10:34:31] 10Continuous-Integration-Config, 10Wikidata, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10Addshore) >>! In T188717#4669782, @hashar wrote: >>>! In T188717#4541201, @Addshore wrote: >> Is there a ticket to link to for this... [10:44:54] 10Continuous-Integration-Config, 10Wikidata, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10hashar) Ok sorry for the confusion. Meanwhile, I have Quibble running Wikibase PHPUnit tests just fine with: ``` ZUUL_PROJECT=medi... [12:16:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Page-Previews, 10Readers-Web-Backlog (Tracking), 10User-zeljkofilipin: selenium-daily-beta-Popups CI job failing - https://phabricator.wikimedia.org/T206640 (10zeljkofilipin) 05Open>03Resolved We have had some Docker prob... [12:40:39] (03PS1) 10Hashar: Remove obsolete Wikibase settings [integration/config] - 10https://gerrit.wikimedia.org/r/467675 (https://phabricator.wikimedia.org/T188717) [12:51:51] (03CR) 10Hashar: [C: 032] Remove obsolete Wikibase settings [integration/config] - 10https://gerrit.wikimedia.org/r/467675 (https://phabricator.wikimedia.org/T188717) (owner: 10Hashar) [12:54:25] (03Merged) 10jenkins-bot: Remove obsolete Wikibase settings [integration/config] - 10https://gerrit.wikimedia.org/r/467675 (https://phabricator.wikimedia.org/T188717) (owner: 10Hashar) [12:56:14] 10Continuous-Integration-Config, 10Wikidata, 10Patch-For-Review, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10Addshore) >>! In T188717#4541189, @Addshore wrote: >>>! In T188717#4541180, @Legoktm wrote: >> Well the goal... [12:56:38] 10Continuous-Integration-Config, 10Wikidata, 10Patch-For-Review, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10Addshore) [12:57:21] 10Continuous-Integration-Config, 10Wikidata, 10wikidata-tech-focus, 10Patch-For-Review, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10Addshore) [13:29:06] 10Release-Engineering-Team, 10Wikibase-Quality, 10Wikibase-Quality-Constraints, 10Wikidata, 10Wikidata-Campsite: Undeploy WikibaseQuality extension from the WMF - https://phabricator.wikimedia.org/T205064 (10Addshore) [13:29:59] 10Release-Engineering-Team, 10Wikibase-Quality, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: Undeploy WikibaseQuality extension from the WMF - https://phabricator.wikimedia.org/T205064 (10Addshore) [13:30:08] 10Release-Engineering-Team, 10Wikibase-Quality, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: Undeploy WikibaseQuality extension from the WMF - https://phabricator.wikimedia.org/T205064 (10Addshore) [13:36:20] (03PS1) 10Hashar: Fix DonationInterface skip-if rule [integration/config] - 10https://gerrit.wikimedia.org/r/467682 [13:36:45] (03PS2) 10Hashar: Fix DonationInterface skip-if rule [integration/config] - 10https://gerrit.wikimedia.org/r/467682 (https://phabricator.wikimedia.org/T203084) [13:39:16] 10Continuous-Integration-Config, 10Growth-Team, 10StructuredDiscussions: Random test failures for Flow\Tests\Collection\PostCollectionTest::testGetFirstRevision - https://phabricator.wikimedia.org/T207173 (10Daimona) [13:39:23] (03CR) 10Hashar: [C: 032] Fix DonationInterface skip-if rule [integration/config] - 10https://gerrit.wikimedia.org/r/467682 (https://phabricator.wikimedia.org/T203084) (owner: 10Hashar) [13:41:17] (03Merged) 10jenkins-bot: Fix DonationInterface skip-if rule [integration/config] - 10https://gerrit.wikimedia.org/r/467682 (https://phabricator.wikimedia.org/T203084) (owner: 10Hashar) [13:41:42] hashar, did you see my email from October 7th? [13:45:53] 10Release-Engineering-Team, 10Wikibase-Quality, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: Undeploy WikibaseQuality extension from the WMF - https://phabricator.wikimedia.org/T205064 (10Addshore) [13:59:14] Urbanecm: nop sorry, I was out for the last two weeks. [13:59:25] Urbanecm: and I have deleted a bunch of emails. Maybe fill it as a task instead? :] [14:00:30] 10Release-Engineering-Team (Watching / External), 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10Epic, 10User-notice: Deploy refactored comment storage - https://phabricator.wikimedia.org/T166733 (10Anomie) [14:01:19] 10Release-Engineering-Team (Watching / External), 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Doing), 10Epic, 10User-notice: Deploy refactored comment storage - https://phabricator.wikimedia.org/T166733 (10Anomie) [14:12:14] hashar, it was a question, not sure if question is a task. [14:29:27] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Onboarding liw - https://phabricator.wikimedia.org/T206466 (10LarsWirzenius) [14:33:42] hashar, I'm wondering how I can specify what testenv in tox should run when check zuul pipeline is invoked. I'd like to have something (lint) run for non-whitelisted users. Can you help me please? [14:33:48] (or anybody else ofc) [14:39:09] hey, how can I find the 1.32 release branch? [14:39:55] https://www.mediawiki.org/wiki/MediaWiki_1.32/Roadmap says that MediaWiki 1.32.0-wmf.26 is being branched and deployed this week, but I can't find that branch on github or gerrit [14:40:53] cscott, i think it wasn't branched yet [14:41:09] MediaWiki train is in 4 hours [14:41:31] Urbanecm: I thought the 1.32 release branch was yesterday and that we'd be on 1.33 train this week [14:41:36] maybe i misunderstood [14:42:17] Per https://wikitech.wikimedia.org/wiki/Deployments, we'll promote group0 to wmf.26 in today MediaWiki train [14:42:38] (you can verify it on https://test.wikipedia.org/wiki/Special:Version - it still says wmf.24) [14:43:16] and as far as I can see, it matches the roadmap you linked [14:43:17] cscott, ^^ [14:43:32] 10Gerrit, 10Patch-For-Review: Place holder task for Gerrit 2.16 upgrade - https://phabricator.wikimedia.org/T200739 (10Paladox) Upstream are preparing to branch 2.16 and release 2.16 rc0 see https://gerrit-review.googlesource.com/c/gerrit/+/200192 [15:11:07] "We plan to create [15:11:07] the REL1_32 branch on October 16 and to generate the first release [15:11:07] candidate, so we will be requesting "pencils down" on October 15." [15:11:26] said greg_g, so I misunderstood, "pencils down" != make branch. [15:12:54] twentyafterfour: ^ just a reminder :) :) [15:14:08] greg-g: so does this branch need to have extension submodules? [15:14:26] I believe it is a different set of extensions, correct? [15:15:38] or should I just take 1.32.0-wmf.26 and copy it to REL1_32 [15:16:02] and why do we use a different naming convention? Can we update that to something like release/1.32.0 ? [15:16:22] hysterical raisans [15:16:38] right, are any raisans still relevant? [15:16:50] I'm guessing SVN had something to do with it [15:16:54] 10Gerrit, 10Patch-For-Review: Place holder task for Gerrit 2.16 upgrade - https://phabricator.wikimedia.org/T200739 (10Paladox) Upstream have just branched 2.16. And are now upgrading master to work on 3.0. [15:17:12] twentyafterfour: https://www.mediawiki.org/wiki/Release_checklist#Setup_and_announcements [15:30:01] 10Deployments, 10I18n, 10Language-Team (Language-2018-October-December): Determine desired architecture to update localization strings for Wikimedia - https://phabricator.wikimedia.org/T206694 (10Nikerabbit) == Localisation Update (LU) == Developers work on features continously, and this means there will be... [15:37:10] twentyafterfour: very many things depend upon the REL1_XX naming... [15:37:20] twentyafterfour: the extension list is different [15:37:49] twentyafterfour: I think it's supposed to be branch.py in make-release/ [16:00:18] * awight wonders where quibble jobs are defined [16:03:36] awight: what specifically are you looking for? [16:03:57] (03PS1) 10Awight: Add optional dependencies for JADE [integration/config] - 10https://gerrit.wikimedia.org/r/467724 [16:04:35] legoktm: hi! I see that the whitelist for extension-coverage normally has the "includes" dir, but my extension should also get "maintenance" dir coverage stats. [16:04:50] maintenance is already whitelisted [16:04:53] It's working for https://doc.wikimedia.org/cover-extensions/AbuseFilter/ so I was checking whether that required any custom glue [16:04:56] aha, thanks :-) [16:05:00] which extension? [16:05:11] yeah, includes/, src/, and maintenance/ are whitelisted [16:05:13] This is the one I'm working on, https://doc.wikimedia.org/cover-extensions/JADE/ [16:05:28] as soon as the directory exists, the report will shift the base directory [16:05:36] PHPUnit is magical at times [16:05:54] Thanks btw for getting that coverage report set up, it's nice to have metrics we should care about. [16:06:01] awight: why does JADE depend upon CentralAuth? [16:06:05] :)) [16:06:10] hehe you said it. PHPUnit is magical except for when it's evil magic [16:06:32] legoktm: That should be an optional dependency. Was that the right place to express it? [16:07:02] JADE can optionally handle global user IDs, but only when CentralAuth is present. Otherwise, the tests will be skipped. [16:07:03] yes, but ideally extensions wouldn't care about CentralAuth at all, it should be abstracted away in core for the most part [16:07:11] hmm [16:07:30] Well, I need to make some CentralAuth calls, lemme tag you on the patch [16:07:33] have you looked at CentralIdLookup in core? [16:08:00] legoktm: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/JADE/+/461502/10/includes/JudgmentValidator.php [16:08:04] oh! [16:08:09] awesome, thanks for the pointer [16:08:38] from a quick skim, you should be able to do all of that with CentralIdLookup [16:08:49] * awight is loath to give up CentralAuthTestUser [16:08:52] kk that's great news [16:09:39] there's also a TestUser class in core... ;-) [16:10:41] Nice dependency inversion, btw [16:12:04] Seems like it should have been a MediaWikiService but ::factory is fine [16:12:19] 10Continuous-Integration-Infrastructure, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Run MediaWiki tests on PHP 7.3 - https://phabricator.wikimedia.org/T204884 (10Legoktm) [16:12:53] it predates MWServices [16:13:26] legoktm: One more question about this--once my code has no explicit dependency, don't I still need to depend on CentralAuth in CI so that a provider is present? [16:13:44] there will always be a local provider provided by core [16:15:54] You can see in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/JADE/+/461502/10/jsonschema/judgment/v1.json that we're only writing a 'gid' if there's such a thing as global IDs, otherwise there's only an 'id' property for local ID. Would you suggest that we always write a 'gid' and just allow CentralIdLookup to repeat the local user ID in that field? [16:20:37] awight: yep [16:20:53] maybe call it "cid"? (central id) [16:21:12] will do! [16:38:12] (03PS2) 10Awight: Add optional dependencies for JADE [integration/config] - 10https://gerrit.wikimedia.org/r/467724 [17:28:55] PROBLEM - Puppet errors on integration-slave-jessie-1003 is CRITICAL: CRITICAL: 6.67% of data above the critical threshold [3.0] [17:35:23] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Legoktm) I backported everything that I could find with "7.2" and "7.3" in the commit message - 7.2 tests pass now on 1.31. [18:28:00] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), 10Services (watching): Revisit the logging work done on Q1 2017-2018 for the standard pod setup - https://phabricator.wikimedia.org/T207200 (10akosiaris) p:05Triage>03Normal [18:32:58] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), 10Services (watching): Revisit the logging work done on Q1 2017-2018 for the standard pod setup - https://phabricator.wikimedia.org/T207200 (10akosiaris) [18:44:32] 10Continuous-Integration-Config, 10Librarization, 10Security-team-backlog, 10Composer, and 2 others: Expand our usage of FriendsOfPHP/security-advisories - https://phabricator.wikimedia.org/T180278 (10bd808) >>! In T180278#4669337, @Legoktm wrote: > Outside of MediaWiki extensions/skins (which I have a dif... [18:53:48] 10Release-Engineering-Team, 10Analytics, 10Analytics-Kanban: How to remove outdated and not used repo? - https://phabricator.wikimedia.org/T207204 (10Nuria) [18:54:58] PROBLEM - Free space - all mounts on integration-slave-docker-1017 is CRITICAL: CRITICAL: integration.integration-slave-docker-1017.diskspace.root.byte_percentfree (<30.00%) [18:55:08] maintenance-disconnect-full-disks build 11884 integration-slave-docker-1017 (/: 96%): OFFLINE due to disk space [18:55:09] maintenance-disconnect-full-disks build 11884 integration-slave-docker-1017 (/: 96%): OFFLINE due to disk space [19:00:06] maintenance-disconnect-full-disks build 11885 integration-slave-docker-1017: OFFLINE due to disk space [19:05:28] uhhh [19:05:54] oh I read too fast and thought it was multiple slaves [19:07:42] !log root@integration-slave-docker-1017:/# docker rmi $(docker images -q) to clean up disk space [19:07:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:07:54] /dev/vda3 19G 3.2G 15G 19% / [19:08:43] !log integration-slave-docker-1017 back online [19:08:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:09:38] !log Branching 1.32.0-wmf.26 [19:09:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:12:15] 10Continuous-Integration-Config, 10Librarization, 10Security-team-backlog, 10Composer, and 2 others: Expand our usage of FriendsOfPHP/security-advisories - https://phabricator.wikimedia.org/T180278 (10MaxSem) * https://github.com/wikimedia/grantmetrics * https://github.com/wikimedia/svgtranslate [19:19:57] RECOVERY - Free space - all mounts on integration-slave-docker-1017 is OK: OK: All targets OK [19:23:56] RECOVERY - Puppet errors on integration-slave-jessie-1003 is OK: OK: Less than 1.00% above the threshold [2.0] [19:27:20] (03PS1) 10Legoktm: Add more repositories to 'mediawiki-vendor-security' [integration/config] - 10https://gerrit.wikimedia.org/r/467765 [19:52:36] (03PS1) 10Legoktm: Refactor composer security checks for more flexibility [integration/config] - 10https://gerrit.wikimedia.org/r/467771 [19:56:59] (03PS2) 10Legoktm: Refactor composer security checks for more flexibility [integration/config] - 10https://gerrit.wikimedia.org/r/467771 [19:57:46] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [20:00:48] trying to run updateCredits.php but I get Uncaught Error: Class 'Collator' not found in /src/mediawiki/core/maintenance/updateCredits.php:74 [20:01:03] Collator doesn't seem to exist anywhere in the mediawiki source nor in vendor? [20:01:23] anyone know what class that's supposed to refer to? [20:01:56] twentyafterfour: you need to have the php-intl extension installed [20:02:04] twentyafterfour: though I think James_F already ran that script earlier this week? [20:02:34] I did. [20:02:42] I had to install php-intl first to make it work, yes. [20:03:07] twentyafterfour: You running on a Mac? It ships without, but you can use Homebrew's PHP with it. [20:04:13] don't we check for things like PHP extensions during MW installation? [20:04:18] linux [20:04:41] if it's already ran then I don't need to do it again, presumably [20:06:54] twentyafterfour: Yeah, I don't think anyone new has turned up since Thursday. [20:07:22] Krenair: My Vagrant Debian image has -intl working just fine (but can't write to disc). [20:12:39] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-09 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [20:17:34] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-09 is OK: HTTP OK: HTTP/1.1 200 OK - 47271 bytes in 1.646 second response time [20:48:21] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), 10Services (watching): Track and install additional npm packages for all service container images - https://phabricator.wikimedia.org/T205911 (10thcipriani) Seems like this is something we co... [21:00:11] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Patch-For-Review: Database busted for CiviCRM tests? - https://phabricator.wikimedia.org/T205950 (10Ejegg) Those partitions still fill up pretty fast. @thcipriani would it be possible to increase the size of /var/lib/mysql at all, at leas... [21:03:12] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [21:07:26] Krenair: intl isn't required...probably we should have that script check and output a nicer error message [21:07:36] ah [21:07:40] yeah [21:10:41] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Patch-For-Review: Database busted for CiviCRM tests? - https://phabricator.wikimedia.org/T205950 (10Eileenmcnaughton) Would it help to switch to file per table - https://stackoverflow.com/questions/3456159/how-to-shrink-purge-ibdata1-file... [21:11:52] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.32.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T191072 (10mmodell) [21:28:46] (03PS3) 10Legoktm: Refactor composer security checks for more flexibility [integration/config] - 10https://gerrit.wikimedia.org/r/467771 [21:29:24] 10Continuous-Integration-Config, 10AntiSpoof, 10Equivset, 10Growth-Team, 10Thanks: Thanks REL1_27 failing due to "Your requirements could not be resolved to an installable set of packages" - https://phabricator.wikimedia.org/T202671 (10dmaza) > That is due to #abusefilter having: > ``` > lang=json, name=... [21:36:56] (03PS2) 10Legoktm: Add more repositories for PHP dependency security checking [integration/config] - 10https://gerrit.wikimedia.org/r/467765 (https://phabricator.wikimedia.org/T180278) [21:37:12] (03Abandoned) 10Legoktm: Refactor composer security checks for more flexibility [integration/config] - 10https://gerrit.wikimedia.org/r/467771 (owner: 10Legoktm) [21:38:24] (03PS3) 10Legoktm: Add more repositories for PHP dependency security checking [integration/config] - 10https://gerrit.wikimedia.org/r/467765 (https://phabricator.wikimedia.org/T180278) [21:39:19] (03PS4) 10Legoktm: Add more repositories for PHP dependency security checking [integration/config] - 10https://gerrit.wikimedia.org/r/467765 (https://phabricator.wikimedia.org/T180278) [21:42:30] 10Continuous-Integration-Config, 10AntiSpoof, 10Equivset, 10Growth-Team, 10Thanks: Thanks REL1_27 failing due to "Your requirements could not be resolved to an installable set of packages" - https://phabricator.wikimedia.org/T202671 (10hashar) That is in the `REL1_27` branch. So probably we should remove... [21:51:55] (03CR) 10Legoktm: [C: 032] Add more repositories for PHP dependency security checking [integration/config] - 10https://gerrit.wikimedia.org/r/467765 (https://phabricator.wikimedia.org/T180278) (owner: 10Legoktm) [21:53:39] 10Continuous-Integration-Config, 10Librarization, 10Security-team-backlog, 10Composer, and 2 others: Expand our usage of FriendsOfPHP/security-advisories - https://phabricator.wikimedia.org/T180278 (10Legoktm) * https://integration.wikimedia.org/ci/job/mediawiki-php-security/ * https://integration.wikimedi... [21:53:53] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.32.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T191072 (10Krinkle) [21:54:25] 10Release-Engineering-Team, 10Analytics, 10Analytics-Kanban, 10GitHub-Mirrors, 10Repository-Admins: How to remove outdated and not used repo? - https://phabricator.wikimedia.org/T207204 (10greg) [21:57:23] (03Merged) 10jenkins-bot: Add more repositories for PHP dependency security checking [integration/config] - 10https://gerrit.wikimedia.org/r/467765 (https://phabricator.wikimedia.org/T180278) (owner: 10Legoktm) [21:58:01] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.32.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T191072 (10mmodell) [22:02:26] ok new release branch: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/467829/ [22:03:00] legoktm, James_F, cscott ^ [22:03:28] wheee [22:04:06] twentyafterfour: I don't see the branch for all extensions? is the script still in progress? [22:04:41] legoktm: no, it should have branched them (only bundled extensions though right?) [22:04:52] all extensions are supposed to get a branch [22:04:56] (and skins) [22:04:58] and vendor [22:05:37] hmm, branch.py doesn't seem to have that functionality [22:05:45] unless I'm doing it rong [22:06:00] "rong"(tm) [22:06:37] huh [22:07:20] it's just got a list of a few extensions and 3 skins [22:07:35] also the script has errors [22:07:44] seems unfinished but close [22:08:28] should I just checkout the mediawiki/extensions repo and do a git-submodule-foreach to create the branch ? [22:08:51] twentyafterfour: what options did you use? [22:09:16] ./branch.py --core --bundle base --core-version 1.32.0 REL1_32 [22:09:55] try uh ./branch.py --bundle='*' --core-version 1.32.0 REL1_32 [22:09:58] oh I see [22:10:01] hmm [22:10:22] actually you don't need --core-version [22:10:37] should the core branch have just the bundled submodules? [22:10:39] just ./branch.py --bundle='*' REL1_32 [22:10:41] yes [22:11:07] your core commit looks correct except for the lack of vendor/ (which is missing from the script afais?) and the version number [22:11:21] ok that's running now [22:11:43] what should the version number be? [22:11:58] lemme see what we did last time [22:12:03] also https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ImageMap/+refs has a REL1_33?? [22:12:37] that was a mistake, thought I deleted all of them already [22:12:58] 1.31.0-rc.0 [22:13:07] well, it should be 1.32.0-rc.0 [22:13:20] twentyafterfour: so uh, which page do we need to update the documentation on? :) [22:15:21] 403 Client Error: Forbidden for url: https://gerrit.wikimedia.org/r/a/projects/mediawiki%2Fextensions%2FWikibaseQualityConstraints/branches/REL1_32 [22:15:52] * legoktm looks [22:16:05] which documentation? [22:16:16] I haven't found any :-/ [22:16:47] the repo config for WikibaseQualityConstraints looks correct [22:17:10] twentyafterfour did you use auth against that? [22:17:14] https://www.mediawiki.org/wiki/Release_checklist#Setup_and_announcements I guess [22:17:32] make-extension-branches [22:17:53] yeah that hasn't existed for quite a while now [22:18:23] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.32.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T191072 (10Krinkle) @mmodell Hm.. the "create one" link seems to use form `47` (create release) instead of `46` (report error). Removing the `templa... [22:20:30] I'll bbl in a bit [23:00:39] 10Continuous-Integration-Config, 10AntiSpoof, 10Equivset, 10Growth-Team, 10Thanks: Thanks REL1_27 failing due to "Your requirements could not be resolved to an installable set of packages" - https://phabricator.wikimedia.org/T202671 (10Reedy) >>! In T202671#4672323, @dmaza wrote: >> That is due to #abuse... [23:12:58] 10Continuous-Integration-Config, 10Growth-Team, 10MediaWiki-extensions-CentralAuth, 10Thanks: Thanks REL1_29 failing due to CentralAuth tables being missing - https://phabricator.wikimedia.org/T202670 (10Reedy) 05Open>03declined [23:16:36] 10Continuous-Integration-Config, 10AntiSpoof, 10Equivset, 10Growth-Team, and 2 others: Thanks REL1_27 failing due to "Your requirements could not be resolved to an installable set of packages" - https://phabricator.wikimedia.org/T202671 (10Reedy) Yup, that works. Really, it should be done in extension.json... [23:18:42] 10Continuous-Integration-Config, 10AntiSpoof, 10Equivset, 10Growth-Team, and 2 others: Thanks REL1_27 failing due to "Your requirements could not be resolved to an installable set of packages" - https://phabricator.wikimedia.org/T202671 (10Reedy) Though, we can just remove the line entirely too based on ht... [23:27:32] 10Continuous-Integration-Config, 10MW-1.27-release: release-quibble-vendor-mysql-php*-docker failing on REL1_27 AbuseFilter - https://phabricator.wikimedia.org/T207241 (10Reedy) [23:28:06] 10Continuous-Integration-Config, 10AntiSpoof, 10Equivset, 10Growth-Team, 10Thanks: Thanks REL1_27 failing due to "Your requirements could not be resolved to an installable set of packages" - https://phabricator.wikimedia.org/T202671 (10Reedy) 05Open>03Resolved a:03Reedy [23:28:20] 10Continuous-Integration-Config, 10MW-1.27-release: release-quibble-vendor-mysql-php*-docker failing on REL1_27 AbuseFilter - https://phabricator.wikimedia.org/T207241 (10Reedy) [23:31:15] 10Continuous-Integration-Config, 10Growth-Team, 10StructuredDiscussions, 10MW-1.31-release: release-quibble-vendor-mysql-hhvm-docker fails with unknown class Pimple\Container - https://phabricator.wikimedia.org/T207242 (10Reedy)