[00:21:00] (03PS1) 10Legoktm: Upgrade squizlabs/php_codesniffer to 3.3.1 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/469147 (https://phabricator.wikimedia.org/T207250) [00:24:23] (03PS1) 10Legoktm: Release 19.1.0 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/469149 (https://phabricator.wikimedia.org/T207250) [00:30:09] 10MediaWiki-Codesniffer, 10PHP 7.3 support, 10Patch-For-Review: Backport codesniffer update to 19.x for PHP 7.3 compatibility - https://phabricator.wikimedia.org/T207250 (10Legoktm) a:03Legoktm [00:47:34] PROBLEM - Puppet staleness on deployment-maps03 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [43200.0] [09:02:12] 10Continuous-Integration-Config, 10Commons-Mass-Description, 10Map-of-monuments, 10Weapon of Mass Description, and 2 others: Run lint in check pipeline for Urbanecm's tools - https://phabricator.wikimedia.org/T207685 (10Zoranzoki21) @Urbanecm You think on this? https://packagist.org/packages/sllh/composer-... [09:26:37] 10Continuous-Integration-Config, 10Commons-Mass-Description, 10Map-of-monuments, 10Weapon of Mass Description, and 2 others: Run lint in check pipeline for Urbanecm's tools - https://phabricator.wikimedia.org/T207685 (10Urbanecm) No. Those tools are in Python, composer is for PHP. Anyway, this question is... [09:56:19] (03PS1) 10Tarrow: Remove WikibaseQuality from Wikibase, WikibaseQualityConstraints [integration/config] - 10https://gerrit.wikimedia.org/r/469181 (https://phabricator.wikimedia.org/T207655) [10:04:42] (03CR) 10Tarrow: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/469181 (https://phabricator.wikimedia.org/T207655) (owner: 10Tarrow) [11:21:00] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Onboarding liw - https://phabricator.wikimedia.org/T206466 (10jijiki) [11:34:22] 10Release-Engineering-Team, 10Wikibase-Quality, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: Undeploy WikibaseQuality extension from the WMF - https://phabricator.wikimedia.org/T205064 (10Tarrow) [13:48:34] 10Project-Admins, 10Analytics: Create project for SWAP - https://phabricator.wikimedia.org/T207425 (10Aklapper) 05Open>03Resolved a:03Aklapper Requested public project #Analytics-SWAP has been created: https://phabricator.wikimedia.org/project/view/3711/ I've also adjusted H126 to add #Analytics if not... [13:50:36] 10Project-Admins, 10Africa-Wikimedia-Developers: Project work board request for WikiFundi - https://phabricator.wikimedia.org/T186754 (10Aklapper) Any decision? :) If not, should this be declined for the time being? We can always reopen if the situation changes. [13:53:02] 10Project-Admins: Create group/project for "On-wiki documentation working group" - https://phabricator.wikimedia.org/T201639 (10Aklapper) The project tag #foundation.wikimedia.org exists. Would it make sense to create `documentation` as a [[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Parent_Pr... [13:54:43] 10Project-Admins: Create a component project for the EditAccount extension - https://phabricator.wikimedia.org/T205293 (10Aklapper) a:03ashley I think we need a reply from @ashley here if this is wanted [13:55:01] 10Project-Admins, 10Africa-Wikimedia-Developers: Project work board request for WikiFundi - https://phabricator.wikimedia.org/T186754 (10Anthere) Close it please. [13:56:51] 10Project-Admins: Create MediaWiki tag(s) for page data (access, storage, updates) - https://phabricator.wikimedia.org/T206284 (10Aklapper) Is @daniel 's proposal to create `#MediaWiki-Primary-Storage` and `#MediaWiki-Derived-Data` fine with everybody? Or any ideas for better names here? [13:58:57] 10Project-Admins: Create an #OSM tag to identify tasks with OpenStreetMap relevance - https://phabricator.wikimedia.org/T207017 (10Aklapper) Basically fine with this, just wondering (as usual) how to identify tasks "which may be relevant to the OpenStreetMap community". Hints welcome for the lost triager that I... [14:18:41] 10Project-Admins, 10User-Urbanecm: Create WMCZ-General project - https://phabricator.wikimedia.org/T207572 (10Aklapper) 05Open>03Resolved a:03Aklapper Requested public project #WMCZ-General has been created: https://phabricator.wikimedia.org/project/view/3712/ (Maybe at some point we should make `#WMCZ-... [14:19:33] 10Continuous-Integration-Config, 10WMCZ-General, 10Patch-For-Review, 10User-Urbanecm: Add php lint job to wikimedia-cz/mediawiki-config - https://phabricator.wikimedia.org/T207571 (10Aklapper) [14:19:55] 10Project-Admins: Create an #OSM tag to identify tasks with OpenStreetMap relevance - https://phabricator.wikimedia.org/T207017 (10Yurik) Thx @Aklapper , I think WIWOSM wouldn't be part of it, because, just like Kartotherian and other techs, WIWOSM is `using` OSM tech/data, but does not affect the OSM project it... [14:21:06] 10Project-Admins, 10User-Urbanecm: Create WMCZ-Events project - https://phabricator.wikimedia.org/T207681 (10Aklapper) 05Open>03Resolved a:03Aklapper Requested public project #wmcz-events has been created: https://phabricator.wikimedia.org/project/view/3713/ [14:31:02] 10Project-Admins, 10Africa-Wikimedia-Developers: Project work board request for WikiFundi - https://phabricator.wikimedia.org/T186754 (10Aklapper) 05stalled>03declined Thanks for the quick reply! Okay. :-/ (For future reference, you can also do this via the {nav name=Add Action... > Change Status} dropdown) [14:34:53] 10Release-Engineering-Team (Watching / External), 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Doing), 10Epic, 10User-notice: Deploy refactored comment storage - https://phabricator.wikimedia.org/T166733 (10Anomie) [15:41:19] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Adopt JSON as blubber's internal configuration format - https://phabricator.wikimedia.org/T207694 (10LarsWirzenius) a:03LarsWirzenius I'll take this on. [15:41:52] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Adopt JSON as blubber's internal configuration format - https://phabricator.wikimedia.org/T207694 (10LarsWirzenius) p:05Triage>03Normal [16:02:41] 10Continuous-Integration-Infrastructure, 10Jenkins: Make the new Jenkins login page match the fancy gerrit login page - https://phabricator.wikimedia.org/T207762 (10thcipriani) [16:03:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Jenkins: Make the new Jenkins login page match the fancy gerrit login page - https://phabricator.wikimedia.org/T207762 (10thcipriani) p:05Triage>03Low [16:11:49] 10Release-Engineering-Team (Kanban), 10Scap: deploy1001:/srv/mediawiki out of date? - https://phabricator.wikimedia.org/T207602 (10thcipriani) [16:12:14] 10Release-Engineering-Team (Kanban), 10Scap: deploy1001:/srv/mediawiki out of date? - https://phabricator.wikimedia.org/T207602 (10thcipriani) p:05Triage>03Normal a:03thcipriani [17:39:49] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10Epic, 10MW-1.32-release: Expand the set of bundled extensions and skins in MediaWiki 1.32 - https://phabricator.wikimedia.org/T196650 (10Jdforrester-WMF) >>! In T196650#4679588, @MGChecker wrote: > Considering blocking tasks and task descriptions, it seems li... [17:41:09] 10Project-Admins: Create MediaWiki tag(s) for page data (access, storage, updates) - https://phabricator.wikimedia.org/T206284 (10Legoktm) +1 to creating new projects, I'm unable to come up with any better names. [17:47:29] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10MW-1.27-release-notes, 10Patch-For-Review, 10Technical-Debt: Phaseout CI mediawiki config / extensions_load.txt to load extensions - https://phabricator.wikimedia.org/T189567 (10Legoktm) I think the last two places... [17:47:49] 10Continuous-Integration-Config, 10Wikidata, 10wikidata-tech-focus, 10Patch-For-Review, 10User-Addshore: Move Wikibase to using the normal mediawiki extension (quibble) jobs - https://phabricator.wikimedia.org/T188717 (10Legoktm) [17:47:53] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10MW-1.27-release-notes, 10Patch-For-Review, 10Technical-Debt: Phaseout CI mediawiki config / extensions_load.txt to load extensions - https://phabricator.wikimedia.org/T189567 (10Legoktm) [18:08:24] related to https://phabricator.wikimedia.org/T191231#4689449, we should track usage of non-free network services in CI...I think I'm aware of 4 right now [18:08:39] Project beta-scap-eqiad build #225621: 15ABORTED in 19 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/225621/ [18:08:44] ^ me [18:10:06] legoktm: I like that idea :) [18:12:06] twentyafterfour: hey.. would you mind swatting a fix to an unbreak now during the swat window? [18:12:13] * train rather [18:14:58] it's a deployment blocker now i think of it.. [18:19:47] twentyafterfour: ping me when you are free! [18:26:22] 10Release-Engineering-Team (Kanban), 10Scap: deploy1001:/srv/mediawiki out of date? - https://phabricator.wikimedia.org/T207602 (10thcipriani) There are 928 wikis in `wikiversions.{json,php}`. If 927 showed up as being on the previous versions, this leads me to believe wikiversions is only getting updated in `... [18:56:16] 10Project-Admins, 10User-Urbanecm: Create WMCZ-Events project - https://phabricator.wikimedia.org/T207681 (10Urbanecm) Thank you. [18:56:17] jdlrobson: I'm free [18:56:42] twentyafterfour: w00t. So https://phabricator.wikimedia.org/T207423 is the problem card [18:56:53] firstly it needs to go out with the train [18:57:03] ok [18:57:09] does it need a backport as well? [18:57:36] yeh https://gerrit.wikimedia.org/r/469244 is backport [18:57:44] if you can. I'd rather not wait until 4 hours from now [18:57:50] i understand it's giving analytics some problems [18:57:56] jdlrobson: got it! I'll deploy the backport right away [19:01:12] thx! I'm here for testing. Should be able to get quick feedback from the graph [19:01:40] ok just gotta wait for jenkins and I'll let you know when I start deploying [19:09:56] sweet [19:20:01] 10Project-Admins: Create an #OSM tag to identify tasks with OpenStreetMap relevance - https://phabricator.wikimedia.org/T207017 (10Peachey88) If the tag is created, it should OpenStreetMap as the name and OSM as the additional hashtag, so the name provides contextually data to users about what the tag relates to... [19:27:37] twentyafterfour: do you need me to write a patch to put it in 1.33.0-wmf.1 ? [19:28:18] jdlrobson: Sure, or I can cherry pick it if it's straightforward [19:35:41] https://gerrit.wikimedia.org/r/469254 [20:01:46] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.33.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T206655 (10mmodell) a:03mmodell [20:10:25] 10MediaWiki-Releasing, 10Growth-Team, 10MediaWiki-Installer, 10Epic, 10MW-1.32-release: Expand the set of bundled extensions and skins in MediaWiki 1.32 - https://phabricator.wikimedia.org/T196650 (10MGChecker) What do you mean with longer deprecation process? Afaik deprecation guidelines are the same fo... [20:28:53] 10MediaWiki-Releasing, 10Growth-Team, 10MediaWiki-Installer, 10Epic, 10MW-1.32-release: Expand the set of bundled extensions and skins in MediaWiki 1.32 - https://phabricator.wikimedia.org/T196650 (10Jdforrester-WMF) >>! In T196650#4689897, @MGChecker wrote: > What do you mean with longer deprecation pro... [20:45:18] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Recommendation-API, 10Research, and 2 others: Create the recommendation api DB in Beta - https://phabricator.wikimedia.org/T207795 (10mobrovac) p:05Triage>03Normal [20:49:33] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Recommendation-API, 10Research, and 2 others: Create the recommendation api DB in Beta - https://phabricator.wikimedia.org/T207795 (10Krenair) I'm confused about this vs. T207756 [20:58:28] ugh [20:58:30] Cloning into '/srv/mediawiki-staging/php-1.33.0-wmf.1/extensions/Wikibase/view/lib/wikibase-termbox'... [20:58:33] fatal: unable to access 'https://github.com/wmde/wikibase-termbox.git/': Failed to connect to github.com port 443: Connection timed out [21:00:58] twentyafterfour, from a prod host? [21:01:10] Krenair: yes [21:01:21] deploy1001 [21:01:29] I would suggest a workaround but I'm pretty sure that's not supposed to be happening (!) [21:01:44] Stuff shouldn't be getting deployed into prod from github [21:01:48] addshore, ping [21:01:52] Krenair: right [21:01:59] it should be pulling from phab or gerrit [21:02:02] yes [21:08:31] Krenair: pong [21:09:01] Hmm, there is a phab, mirror already? [21:09:03] addshore, what's up with this wmde github submodule that twentyafterfour found in the train today? [21:09:17] But there is some issue with it? [21:09:26] I think it is currently on relengs plate? [21:09:37] can you link the task so I can take a look? [21:09:48] I can fix up the mirroring if it's broken [21:10:15] this repo: https://phabricator.wikimedia.org/diffusion/WBTB/ [21:10:24] it's set to observe [21:10:31] status looks good [21:10:38] yeah it looks like it's all good to me [21:10:48] we just need to fix the .gitmodules to point to it I guess? [21:11:11] The ticket was https://phabricator.wikimedia.org/T206514 [21:11:15] yeah [21:11:34] Does it have the code in it ? Leszek just told me there was an issue with the mirroring? [21:11:38] I haven't checked though [21:11:42] yeah [21:11:50] it's got the latest master commit [21:11:55] Okay [21:11:57] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Recommendation-API, 10Research, and 2 others: Create the recommendation api DB in Beta - https://phabricator.wikimedia.org/T207795 (10bmansurov) [21:12:06] Yes, let's make a commit changing the submodule over then :) [21:13:05] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Recommendation-API, 10Research, and 2 others: Create the recommendation api DB in Beta - https://phabricator.wikimedia.org/T207795 (10bmansurov) [21:13:06] so we just gotta fix https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/wmf/1.33.0-wmf.1/.gitmodules [21:13:14] and the master one I guess [21:14:15] 10Project-Admins: Create group/project for "On-wiki documentation working group" - https://phabricator.wikimedia.org/T201639 (10Varnent) >>! In T201639#4688751, @Aklapper wrote: > The project tag #foundation.wikimedia.org exists. Would it make sense to create `documentation` as a [[ https://www.mediawiki.org/wik... [21:14:38] Yyes [21:15:58] I can give it a +2 if you make it :) [21:16:13] er sure [21:16:46] someone will need to do the backporting etc. as someone finally got around to cleaning up my wmf-deployment privileges [21:16:48] @Krenair: the ticket was T207042 that was blocking us [21:16:49] T207042: No repository URI(s) set for wikibase-termbox - https://phabricator.wikimedia.org/T207042 [21:18:22] Seems gerrit upstream have removed support for when cherry picking it would leave a message on the change that you cherry picked it from. [21:18:43] dammit how do /sourcfe URIs work [21:19:13] I may have misunderstood that ticket [21:19:37] one moment [21:20:05] paladox: that's a nice feature, wtf [21:20:08] :) [21:20:19] twentyafterfour i know right, i filled a issue upstream. [21:20:26] they of course did it for privacy reasons [21:20:30] (leaking a branch) [21:20:39] hmm [21:20:47] https://gerrit-review.googlesource.com/c/gerrit/+/200435 [21:20:52] that's a good reason I guess. [21:21:51] addshore, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/469323 [21:22:50] Just curious, but why does this rpeo have the odd name / callsign but the others have the full names? [21:23:20] that's just a matter of adding a "short name" for it I think [21:24:22] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Recommendation-API, 10Research, and 2 others: Create the recommendation api DB in Beta - https://phabricator.wikimedia.org/T207795 (10Krenair) I don't think we have a backup system in place for deployment-prep DBs? [21:24:25] addshore: fixed: https://phabricator.wikimedia.org/source/wikibase-termbox/ [21:24:28] hm [21:24:38] didn't it say that before? [21:24:46] maybe I was looking at the name instead of short name [21:24:55] yeah the short name was empty before [21:24:57] It seems silly to me that this should change that but... ok [21:24:58] So, that URL should work for fetching? If so, let's add that to the gitmodules file [21:24:59] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Recommendation-API, 10Research, and 2 others: Create the recommendation api DB in Beta - https://phabricator.wikimedia.org/T207795 (10bmansurov) [21:25:06] I still get this [21:25:12] the short name is what's used in the uri and the full name can be arbitrary url-unfriendly stuff [21:25:12] alex@alex-laptop:~/Development/MediaWiki/extensions/Wikibase (termbox-submodule)$ git clone https://phabricator.wikimedia.org/source/wikibase-termbox.git [21:25:12] Cloning into 'wikibase-termbox'... [21:25:12] fatal: repository 'https://phabricator.wikimedia.org/source/wikibase-termbox.git/' not found [21:25:15] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Recommendation-API, 10Research, and 2 others: Create the recommendation api DB in Beta - https://phabricator.wikimedia.org/T207795 (10bmansurov) OK, removed the backup part. [21:26:15] Krenair: https://phabricator.wikimedia.org/source/wikibase-termbox.git works for me [21:26:44] hmmm [21:27:12] git clone https://phabricator.wikimedia.org/source/wikibase-termbox.git [21:27:14] twentyafterfour, so why do I get a not found error? [21:27:15] Cloning into 'wikibase-termbox'... [21:27:17] remote: Counting objects: 358, done. [21:27:22] alex@alex-laptop:~/Development/MediaWiki/extensions/Wikibase (termbox-submodule)$ git clone https://phabricator.wikimedia.org/source/wikibase-termbox.git [21:27:23] Cloning into 'wikibase-termbox'... [21:27:23] fatal: repository 'https://phabricator.wikimedia.org/source/wikibase-termbox.git/' not found [21:27:23] alex@alex-laptop:~/Development/MediaWiki/extensions/Wikibase (termbox-submodule)$ [21:27:27] Krenair: I don't know that's pretty strange [21:27:57] I don't see any typos in there [21:28:22] no I literally copied and pasted your command, character for character, just in case that's what the problem was before [21:28:26] remove the .git [21:28:35] just do git clone https://phabricator.wikimedia.org/source/wikibase-termbox [21:28:59] well. [21:29:04] git remote -v [21:29:07] origin https://phabricator.wikimedia.org/source/wikibase-termbox.git (fetch) [21:29:09] origin ssh://vcs@git-ssh.wikimedia.org/source/wikibase-termbox.git (push) [21:29:10] that seems like a silly distinction to make [21:29:17] but ok [21:29:37] I thought the .git part was necessary but idk [21:29:49] * twentyafterfour scratches head [21:29:51] it shoulden't [21:30:02] here it's only working without it [21:30:03] normally it's optional [21:30:08] git clone https://phabricator.wikimedia.org/source/wikibase-termbox [21:30:09] works [21:30:12] addshore, amended [21:30:27] maybe it depends on which git version you've got? Idk [21:30:45] it depends on the server, not on the client [21:31:22] there... got rid of that pesky @ by my name [21:31:29] heh [21:32:54] fwiw, it works for me with or without .git [21:33:19] hmm, strange [21:33:30] (03CR) 10Jforrester: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [21:34:00] maybe new git versions retry automatically removing ".git"? [21:34:11] perhaps [21:34:19] what's your git --version ? [21:34:30] 2.1.4 is failing [21:34:36] git version 2.7.4 [21:35:11] Krenair: ill wait for jenkins to say yes [21:36:17] is zuul backed up? there isn't a comment from ci on that patch [21:36:33] twentyafterfour, my client doesn't add the @ [21:37:02] I didn't need to be op anymore (I had to gain op to redirect wikimedia-devtools into this channel ) [21:37:24] (03CR) 10jerkins-bot: [V: 04-1] Make WikiEditor depend on WikimediaEvents [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [21:38:49] * paladox is on 2.19.x [21:40:35] okay [21:40:43] why is CI silent on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/469323/ ? [21:40:59] (03CR) 10Jforrester: "So much for hoping it'd suddenly pass." [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [21:41:01] Krenair: it is still running [21:41:11] ah, it seems to be in zuul still [21:41:20] does it normally take this long? [21:41:33] I don't remember it taking this long. [21:42:00] it can take long [21:43:50] Krenair: i can see it [21:44:04] 2 of the jobs are still running [21:53:38] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.33.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T206655 (10Nuria) [22:00:49] Krenair: i just cherry picked it, +1ed the cherry pick and +2ed the master change [22:01:11] twentyafterfour: ^^ [22:01:24] awesome thanks addshore [22:06:20] twentyafterfour: Krenair give me a ping if you need anything [22:06:26] * addshore goes back to tech conf stuff [22:08:26] oh, forgot about that [23:02:20] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [wikimedia-cz/events] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469342 [23:02:22] (03CR) 10QChris: [V: 032 C: 032] Allow “Gerrit Managers” to import history [wikimedia-cz/events] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469342 (owner: 10QChris) [23:03:47] (03PS1) 10QChris: Import done. Revoke import grants [wikimedia-cz/events] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469343 [23:03:49] (03CR) 10QChris: [V: 032 C: 032] Import done. Revoke import grants [wikimedia-cz/events] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469343 (owner: 10QChris) [23:13:27] 10Phabricator: Create edit forms for every subtype - https://phabricator.wikimedia.org/T207806 (10MGChecker) [23:21:45] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [wikimedia/campaigns/eswiki-2018] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469344 [23:21:47] (03CR) 10QChris: [V: 032 C: 032] Allow “Gerrit Managers” to import history [wikimedia/campaigns/eswiki-2018] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469344 (owner: 10QChris) [23:22:31] (03PS1) 10QChris: Import done. Revoke import grants [wikimedia/campaigns/eswiki-2018] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469345 [23:22:33] (03CR) 10QChris: [V: 032 C: 032] Import done. Revoke import grants [wikimedia/campaigns/eswiki-2018] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469345 (owner: 10QChris) [23:33:42] (03PS2) 10Legoktm: Make WikiEditor depend on WikimediaEvents [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [23:33:44] (03PS1) 10Legoktm: Don't shell out for test_have_no_tabs [integration/config] - 10https://gerrit.wikimedia.org/r/469346 [23:33:57] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [libs/LangConv] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469347 [23:33:59] (03CR) 10QChris: [V: 032 C: 032] Allow “Gerrit Managers” to import history [libs/LangConv] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469347 (owner: 10QChris) [23:35:02] 23:59:32 test_have_no_tabs (test_files_structure.TestFilesStructure) ... ok [23:35:02] 00:01:40 test_jenkins_jobs_have_a_timeout (test_integration.IntegrationTests) ... ok [23:35:49] (03CR) 10jerkins-bot: [V: 04-1] Don't shell out for test_have_no_tabs [integration/config] - 10https://gerrit.wikimedia.org/r/469346 (owner: 10Legoktm) [23:35:52] (03CR) 10jerkins-bot: [V: 04-1] Make WikiEditor depend on WikimediaEvents [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [23:35:57] great [23:36:51] (03PS2) 10Legoktm: Don't shell out for test_have_no_tabs [integration/config] - 10https://gerrit.wikimedia.org/r/469346 [23:36:53] (03PS3) 10Legoktm: Make WikiEditor depend on WikimediaEvents [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [23:37:03] (03PS1) 10QChris: Import done. Revoke import grants [libs/LangConv] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469348 [23:37:05] (03CR) 10QChris: [V: 032 C: 032] Import done. Revoke import grants [libs/LangConv] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/469348 (owner: 10QChris) [23:40:20] legoktm: Apparently it does make a difference. [23:44:21] (03CR) 10Legoktm: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [23:45:16] James_F: uhhh this is not what I was expecting [23:45:27] * James_F shrugs. [23:45:50] I mean, yay, less work for me but... [23:46:04] I was expecting this to shave off like 2 seconds, and then I was going to start profiling it [23:46:10] VM images are dark magic and sometimes have timespace eddies that slow down randomly. [23:47:19] (03PS3) 10Legoktm: Don't shell out for test_have_no_tabs [integration/config] - 10https://gerrit.wikimedia.org/r/469346 [23:47:21] (03PS4) 10Legoktm: Make WikiEditor depend on WikimediaEvents [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [23:47:40] ok, I removed the part about it not making a difference from the commit message :p [23:47:58] (03CR) 10Legoktm: [C: 032] "Turns out it is a significant difference \o/" [integration/config] - 10https://gerrit.wikimedia.org/r/469346 (owner: 10Legoktm) [23:51:56] (03Merged) 10jenkins-bot: Don't shell out for test_have_no_tabs [integration/config] - 10https://gerrit.wikimedia.org/r/469346 (owner: 10Legoktm) [23:55:12] (03CR) 10Legoktm: [C: 032] Make WikiEditor depend on WikimediaEvents [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [23:57:19] (03Merged) 10jenkins-bot: Make WikiEditor depend on WikimediaEvents [integration/config] - 10https://gerrit.wikimedia.org/r/468171 (owner: 10Catrope) [23:59:21] !log deploying https://gerrit.wikimedia.org/r/468171 [23:59:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:59:26] RoanKattouw: ^^