[00:05:25] (03Merged) 10jenkins-bot: Switch operations-dnslint to ver 0.0.2 [integration/config] - 10https://gerrit.wikimedia.org/r/480268 (owner: 10BBlack) [00:05:25] (03Merged) 10jenkins-bot: Switch operations-dnslint to ver 0.0.2 [integration/config] - 10https://gerrit.wikimedia.org/r/480268 (owner: 10BBlack) [00:17:30] I want to deploy https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/477939/ today [00:17:30] I want to deploy https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/477939/ today [00:17:53] I'm just figuring out an order to do the sync-files in that won't cause fatal errors [00:17:53] I'm just figuring out an order to do the sync-files in that won't cause fatal errors [00:18:34] looks like the scheduled SWAT is done? [00:18:34] looks like the scheduled SWAT is done? [00:20:22] TimStarling: yeah [00:20:22] TimStarling: yeah [00:20:47] I want to do some unrelated debugging in production but it's not urgent [00:20:47] I want to do some unrelated debugging in production but it's not urgent [00:21:13] just ping me if you are finished, please [00:21:13] just ping me if you are finished, please [00:22:54] ok, here goes [00:22:54] ok, here goes [00:28:10] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10RazeSoldier) [00:28:10] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10RazeSoldier) [00:31:39] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10RazeSoldier) > RazeSoldier added a subtask: T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3. This should a last... [00:31:39] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10RazeSoldier) > RazeSoldier added a subtask: T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3. This should a last... [00:32:13] Project beta-scap-eqiad build #231261: 04FAILURE in 1.2 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/231261/ [00:32:13] Project beta-scap-eqiad build #231261: 04FAILURE in 1.2 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/231261/ [00:34:03] that's my fault [00:34:03] that's my fault [00:34:03] Project beta-scap-eqiad build #231262: 04STILL FAILING in 1.1 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/231262/ [00:34:03] Project beta-scap-eqiad build #231262: 04STILL FAILING in 1.1 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/231262/ [00:34:12] looking into it [00:34:12] looking into it [00:49:24] seems like it just fixed itself, may have been a config cache problem [00:49:24] seems like it just fixed itself, may have been a config cache problem [00:50:42] I'll have to isolate it fully, I'll revert it out of master for now [00:50:42] I'll have to isolate it fully, I'll revert it out of master for now [00:55:49] Yippee, build fixed! [00:55:49] Yippee, build fixed! [00:55:49] Project beta-scap-eqiad build #231263: 09FIXED in 11 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/231263/ [00:55:49] Project beta-scap-eqiad build #231263: 09FIXED in 11 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/231263/ [00:58:36] all done tgr [00:58:36] all done tgr [00:58:57] thx [00:58:57] thx [00:59:06] 10Gerrit, 10Jade, 10Scoring-platform-team: Clone gerrit repo mediawiki/extensions/JADE to mediawiki/extensions/Jade - https://phabricator.wikimedia.org/T212180 (10awight) [00:59:06] 10Gerrit, 10Jade, 10Scoring-platform-team: Clone gerrit repo mediawiki/extensions/JADE to mediawiki/extensions/Jade - https://phabricator.wikimedia.org/T212180 (10awight) [01:01:33] 10Continuous-Integration-Config, 10Jade, 10Scoring-platform-team: Rename JADE->Jade in continuous integration - https://phabricator.wikimedia.org/T212181 (10awight) [01:01:33] 10Continuous-Integration-Config, 10Jade, 10Scoring-platform-team: Rename JADE->Jade in continuous integration - https://phabricator.wikimedia.org/T212181 (10awight) [01:02:45] 10Gerrit, 10Jade, 10Scoring-platform-team, 10Patch-For-Review: Rename "JADE" extension to "Jade" - https://phabricator.wikimedia.org/T211046 (10awight) [01:02:45] 10Gerrit, 10Jade, 10Scoring-platform-team, 10Patch-For-Review: Rename "JADE" extension to "Jade" - https://phabricator.wikimedia.org/T211046 (10awight) [01:03:43] 10Continuous-Integration-Config, 10Jade, 10Scoring-platform-team: Rename JADE->Jade in continuous integration - https://phabricator.wikimedia.org/T212181 (10awight) [01:03:43] 10Continuous-Integration-Config, 10Jade, 10Scoring-platform-team: Rename JADE->Jade in continuous integration - https://phabricator.wikimedia.org/T212181 (10awight) [01:03:46] 10Gerrit, 10Jade, 10Scoring-platform-team: Clone gerrit repo mediawiki/extensions/JADE to mediawiki/extensions/Jade - https://phabricator.wikimedia.org/T212180 (10awight) [01:03:46] 10Gerrit, 10Jade, 10Scoring-platform-team: Clone gerrit repo mediawiki/extensions/JADE to mediawiki/extensions/Jade - https://phabricator.wikimedia.org/T212180 (10awight) [01:31:52] 10Phabricator: MinervaNeue tag links to nonexisting page - https://phabricator.wikimedia.org/T212183 (10Huji) [01:31:52] 10Phabricator: MinervaNeue tag links to nonexisting page - https://phabricator.wikimedia.org/T212183 (10Huji) [01:39:42] (03PS1) 10Awight: [DNM] Rename JADE to Jade [integration/config] - 10https://gerrit.wikimedia.org/r/480285 (https://phabricator.wikimedia.org/T212182) [01:39:42] (03PS1) 10Awight: [DNM] Rename JADE to Jade [integration/config] - 10https://gerrit.wikimedia.org/r/480285 (https://phabricator.wikimedia.org/T212182) [01:40:08] (03PS2) 10Awight: [DNM] Rename JADE to Jade [integration/config] - 10https://gerrit.wikimedia.org/r/480285 (https://phabricator.wikimedia.org/T212181) [01:40:08] (03PS2) 10Awight: [DNM] Rename JADE to Jade [integration/config] - 10https://gerrit.wikimedia.org/r/480285 (https://phabricator.wikimedia.org/T212181) [02:44:56] (03CR) 10Legoktm: [C: 03+2] Whitelist @after and @before phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/478474 (owner: 10Umherirrender) [02:44:56] (03CR) 10Legoktm: [C: 03+2] Whitelist @after and @before phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/478474 (owner: 10Umherirrender) [02:46:23] (03Merged) 10jenkins-bot: Whitelist @after and @before phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/478474 (owner: 10Umherirrender) [02:46:23] (03Merged) 10jenkins-bot: Whitelist @after and @before phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/478474 (owner: 10Umherirrender) [02:46:47] (03CR) 10jenkins-bot: Whitelist @after and @before phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/478474 (owner: 10Umherirrender) [02:46:47] (03CR) 10jenkins-bot: Whitelist @after and @before phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/478474 (owner: 10Umherirrender) [04:09:06] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Legoktm) [04:09:06] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Legoktm) [05:48:09] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Legoktm) [05:48:09] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Legoktm) [06:20:02] Project beta-update-databases-eqiad build #30565: 04FAILURE in 2.1 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/30565/ [06:20:02] Project beta-update-databases-eqiad build #30565: 04FAILURE in 2.1 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/30565/ [07:20:02] Project beta-update-databases-eqiad build #30566: 04STILL FAILING in 1.4 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/30566/ [07:20:02] Project beta-update-databases-eqiad build #30566: 04STILL FAILING in 1.4 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/30566/ [07:36:36] 10Release-Engineering-Team (Watching / External), 10Scap, 10serviceops: Allow scap sync to deploy gradually - https://phabricator.wikimedia.org/T212147 (10Joe) From our meeting yesterday: - To do progressive deploys of the train, we just have to modify `sync-wikiversion` and keep track of its completion (by... [07:36:36] 10Release-Engineering-Team (Watching / External), 10Scap, 10serviceops: Allow scap sync to deploy gradually - https://phabricator.wikimedia.org/T212147 (10Joe) From our meeting yesterday: - To do progressive deploys of the train, we just have to modify `sync-wikiversion` and keep track of its completion (by... [08:05:56] 10Continuous-Integration-Infrastructure, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 2 others: Run MediaWiki tests on PHP 7.3 - https://phabricator.wikimedia.org/T204884 (10Legoktm) [08:05:56] 10Continuous-Integration-Infrastructure, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 2 others: Run MediaWiki tests on PHP 7.3 - https://phabricator.wikimedia.org/T204884 (10Legoktm) [08:09:11] (03PS1) 10Legoktm: docker: Support multiple Python 3 versions in `tox` image [integration/config] - 10https://gerrit.wikimedia.org/r/480428 (https://phabricator.wikimedia.org/T191764) [08:09:11] (03PS1) 10Legoktm: docker: Support multiple Python 3 versions in `tox` image [integration/config] - 10https://gerrit.wikimedia.org/r/480428 (https://phabricator.wikimedia.org/T191764) [08:11:51] (03CR) 10Legoktm: [C: 03+2] docker: Support multiple Python 3 versions in `tox` image [integration/config] - 10https://gerrit.wikimedia.org/r/480428 (https://phabricator.wikimedia.org/T191764) (owner: 10Legoktm) [08:11:51] (03CR) 10Legoktm: [C: 03+2] docker: Support multiple Python 3 versions in `tox` image [integration/config] - 10https://gerrit.wikimedia.org/r/480428 (https://phabricator.wikimedia.org/T191764) (owner: 10Legoktm) [08:13:35] (03Merged) 10jenkins-bot: docker: Support multiple Python 3 versions in `tox` image [integration/config] - 10https://gerrit.wikimedia.org/r/480428 (https://phabricator.wikimedia.org/T191764) (owner: 10Legoktm) [08:13:35] (03Merged) 10jenkins-bot: docker: Support multiple Python 3 versions in `tox` image [integration/config] - 10https://gerrit.wikimedia.org/r/480428 (https://phabricator.wikimedia.org/T191764) (owner: 10Legoktm) [08:17:10] !log rebuilding docker tox image https://gerrit.wikimedia.org/r/480428 [08:17:10] !log rebuilding docker tox image https://gerrit.wikimedia.org/r/480428 [08:17:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:17:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:20:44] (03PS1) 10Legoktm: Remove unnecessary docker_image_var overrides [integration/config] - 10https://gerrit.wikimedia.org/r/480430 [08:20:44] (03PS1) 10Legoktm: Remove unnecessary docker_image_var overrides [integration/config] - 10https://gerrit.wikimedia.org/r/480430 [08:21:25] Yippee, build fixed! [08:21:25] Yippee, build fixed! [08:21:26] Project beta-update-databases-eqiad build #30567: 09FIXED in 1 min 24 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/30567/ [08:21:26] Project beta-update-databases-eqiad build #30567: 09FIXED in 1 min 24 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/30567/ [08:24:33] (03CR) 10Legoktm: [C: 03+2] Remove unnecessary docker_image_var overrides [integration/config] - 10https://gerrit.wikimedia.org/r/480430 (owner: 10Legoktm) [08:24:33] (03CR) 10Legoktm: [C: 03+2] Remove unnecessary docker_image_var overrides [integration/config] - 10https://gerrit.wikimedia.org/r/480430 (owner: 10Legoktm) [08:26:58] (03Merged) 10jenkins-bot: Remove unnecessary docker_image_var overrides [integration/config] - 10https://gerrit.wikimedia.org/r/480430 (owner: 10Legoktm) [08:26:58] (03Merged) 10jenkins-bot: Remove unnecessary docker_image_var overrides [integration/config] - 10https://gerrit.wikimedia.org/r/480430 (owner: 10Legoktm) [08:35:40] (03PS1) 10Legoktm: Forgot to git add [integration/config] - 10https://gerrit.wikimedia.org/r/480435 [08:35:40] (03PS1) 10Legoktm: Forgot to git add [integration/config] - 10https://gerrit.wikimedia.org/r/480435 [08:35:42] (03PS1) 10Legoktm: Switch mw-tools-scap-tox-doc-publish to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480436 [08:35:42] (03PS1) 10Legoktm: Switch mw-tools-scap-tox-doc-publish to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480436 [08:35:44] (03PS1) 10Legoktm: Bump tox-docker job to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480437 [08:35:44] (03PS1) 10Legoktm: Bump tox-docker job to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480437 [08:36:05] (03CR) 10Legoktm: [C: 03+2] Forgot to git add [integration/config] - 10https://gerrit.wikimedia.org/r/480435 (owner: 10Legoktm) [08:36:05] (03CR) 10Legoktm: [C: 03+2] Forgot to git add [integration/config] - 10https://gerrit.wikimedia.org/r/480435 (owner: 10Legoktm) [08:37:45] (03Merged) 10jenkins-bot: Forgot to git add [integration/config] - 10https://gerrit.wikimedia.org/r/480435 (owner: 10Legoktm) [08:37:45] (03Merged) 10jenkins-bot: Forgot to git add [integration/config] - 10https://gerrit.wikimedia.org/r/480435 (owner: 10Legoktm) [08:45:17] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog): Set up a Prometheus server under the integration project - https://phabricator.wikimedia.org/T205930 (10hashar) @fgiunchedi do you have any guidance to create a Prometheus instance on WMCS and have the exporters applied on all insta... [08:45:17] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog): Set up a Prometheus server under the integration project - https://phabricator.wikimedia.org/T205930 (10hashar) @fgiunchedi do you have any guidance to create a Prometheus instance on WMCS and have the exporters applied on all insta... [09:56:13] legoktm: I was wondering about those docket vars. They exist for a lot of npm jobs as well. Also redundant? [09:56:13] legoktm: I was wondering about those docket vars. They exist for a lot of npm jobs as well. Also redundant? [09:56:29] Krinkle: example? [09:56:29] Krinkle: example? [09:56:47] they're only needed if you have to use a different image, e.g. tox-cergen which has some extra packages [09:56:47] they're only needed if you have to use a different image, e.g. tox-cergen which has some extra packages [09:57:33] On mobile currently. But a few in misc yaml for (name) instances of job templates relating to npm docker and browser and npm6 etc [09:57:33] On mobile currently. But a few in misc yaml for (name) instances of job templates relating to npm docker and browser and npm6 etc [09:58:01] AFAIK those should be redundant even if they aren't currently:) [09:58:01] AFAIK those should be redundant even if they aren't currently:) [09:58:26] Also wondering about why each repo has its own job variant currrnly. Maybe to avoid pipelines? [09:58:26] Also wondering about why each repo has its own job variant currrnly. Maybe to avoid pipelines? [09:58:28] yeah some look redundant [09:58:28] yeah some look redundant [09:58:51] tbh I don't know [09:58:51] tbh I don't know [09:58:55] it doesn't make much sense to me [09:58:55] it doesn't make much sense to me [09:58:55] Oojs core, router, visual editor etc. [09:58:55] Oojs core, router, visual editor etc. [09:59:03] Right [09:59:03] Right [09:59:07] most of them run pretty fast anyways [09:59:07] most of them run pretty fast anyways [09:59:19] Yeah [09:59:19] Yeah [09:59:41] I like not having a shared implicit pipeline though [09:59:41] I like not having a shared implicit pipeline though [10:00:24] seems like yet another workaround for the dependent pipeline [10:00:24] seems like yet another workaround for the dependent pipeline [10:00:25] Maybe we can configure one major shared gate pipeline group that has dependencies disabled , similar to test pipeline, for standalone repos [10:00:25] Maybe we can configure one major shared gate pipeline group that has dependencies disabled , similar to test pipeline, for standalone repos [10:02:04] (03CR) 10Legoktm: [C: 03+2] Switch mw-tools-scap-tox-doc-publish to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480436 (owner: 10Legoktm) [10:02:04] (03CR) 10Legoktm: [C: 03+2] Switch mw-tools-scap-tox-doc-publish to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480436 (owner: 10Legoktm) [10:02:30] Or basically just mw with dependent pipes and non-mw/Rest without [10:02:30] Or basically just mw with dependent pipes and non-mw/Rest without [10:04:48] (03Merged) 10jenkins-bot: Switch mw-tools-scap-tox-doc-publish to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480436 (owner: 10Legoktm) [10:04:48] (03Merged) 10jenkins-bot: Switch mw-tools-scap-tox-doc-publish to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480436 (owner: 10Legoktm) [10:12:42] (03CR) 10Legoktm: [C: 03+2] "INFO:jenkins_jobs.builder:Reconfiguring jenkins job apps-android-wikipedia-tox-docker" [integration/config] - 10https://gerrit.wikimedia.org/r/480437 (owner: 10Legoktm) [10:12:42] (03CR) 10Legoktm: [C: 03+2] "INFO:jenkins_jobs.builder:Reconfiguring jenkins job apps-android-wikipedia-tox-docker" [integration/config] - 10https://gerrit.wikimedia.org/r/480437 (owner: 10Legoktm) [10:15:08] (03Merged) 10jenkins-bot: Bump tox-docker job to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480437 (owner: 10Legoktm) [10:15:08] (03Merged) 10jenkins-bot: Bump tox-docker job to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480437 (owner: 10Legoktm) [10:17:56] (03PS1) 10Legoktm: Bump other jobs to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480454 [10:17:56] (03PS1) 10Legoktm: Bump other jobs to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480454 [10:21:53] (03PS1) 10Legoktm: Bump cumin-tox-docker timeout since we're running more tests now [integration/config] - 10https://gerrit.wikimedia.org/r/480456 [10:21:53] (03PS1) 10Legoktm: Bump cumin-tox-docker timeout since we're running more tests now [integration/config] - 10https://gerrit.wikimedia.org/r/480456 [10:24:13] (03CR) 10Legoktm: [C: 03+2] Bump other jobs to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480454 (owner: 10Legoktm) [10:24:13] (03CR) 10Legoktm: [C: 03+2] Bump other jobs to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480454 (owner: 10Legoktm) [10:26:48] (03Merged) 10jenkins-bot: Bump other jobs to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480454 (owner: 10Legoktm) [10:26:48] (03Merged) 10jenkins-bot: Bump other jobs to tox:0.2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/480454 (owner: 10Legoktm) [10:29:07] James_F: what timezone are you in? [10:29:07] James_F: what timezone are you in? [10:29:35] legoktm: UTC. [10:29:35] legoktm: UTC. [10:29:44] heh :) [10:29:44] heh :) [10:29:47] legoktm: Until early January. [10:29:47] legoktm: Until early January. [10:30:01] legoktm: Whereas you just are burning the candle at six ends. :-) [10:30:01] legoktm: Whereas you just are burning the candle at six ends. :-) [10:30:47] the semester ended so I'm celebrating by uh, "partying" [10:30:47] the semester ended so I'm celebrating by uh, "partying" [10:31:12] (03CR) 10Legoktm: [C: 03+2] Bump cumin-tox-docker timeout since we're running more tests now [integration/config] - 10https://gerrit.wikimedia.org/r/480456 (owner: 10Legoktm) [10:31:12] (03CR) 10Legoktm: [C: 03+2] Bump cumin-tox-docker timeout since we're running more tests now [integration/config] - 10https://gerrit.wikimedia.org/r/480456 (owner: 10Legoktm) [10:33:52] (03Merged) 10jenkins-bot: Bump cumin-tox-docker timeout since we're running more tests now [integration/config] - 10https://gerrit.wikimedia.org/r/480456 (owner: 10Legoktm) [10:33:52] (03Merged) 10jenkins-bot: Bump cumin-tox-docker timeout since we're running more tests now [integration/config] - 10https://gerrit.wikimedia.org/r/480456 (owner: 10Legoktm) [10:34:06] * James_F grins. [10:34:06] * James_F grins. [10:34:29] legoktm: Feel like looking at a phpunit issue for me? ;-) [10:34:29] legoktm: Feel like looking at a phpunit issue for me? ;-) [10:35:15] James_F: sure [10:35:15] James_F: sure [10:35:45] legoktm: In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/478226 we're trying to add an integration test for WBMI so that Wikibase and core changes can't break us (and thus, break Commons). [10:35:45] legoktm: In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/478226 we're trying to add an integration test for WBMI so that Wikibase and core changes can't break us (and thus, break Commons). [10:36:14] But the phpunit runner spits out "can't write to the database!" and skips the test. [10:36:14] But the phpunit runner spits out "can't write to the database!" and skips the test. [10:36:21] So it "passes" without actually running it. [10:36:21] So it "passes" without actually running it. [10:36:27] How do we make this actually run? [10:36:27] How do we make this actually run? [10:37:15] I think ApiUploadTestCase is broken [10:37:15] I think ApiUploadTestCase is broken [10:38:29] hm [10:38:29] hm [10:38:44] * legoktm waits for the new jenkins logs [10:38:44] * legoktm waits for the new jenkins logs [10:41:13] It could be. [10:41:13] It could be. [10:41:25] And of course there's no unit test for action=upload, because MediaWiki. [10:41:25] And of course there's no unit test for action=upload, because MediaWiki. [10:49:55] (03PS1) 10Legoktm: Rebuild tox-cergen [integration/config] - 10https://gerrit.wikimedia.org/r/480457 [10:49:55] (03PS1) 10Legoktm: Rebuild tox-cergen [integration/config] - 10https://gerrit.wikimedia.org/r/480457 [10:49:57] (03PS1) 10Legoktm: Rebuild tox-certcentral [integration/config] - 10https://gerrit.wikimedia.org/r/480458 [10:49:57] (03PS1) 10Legoktm: Rebuild tox-certcentral [integration/config] - 10https://gerrit.wikimedia.org/r/480458 [10:49:59] (03PS1) 10Legoktm: Rebuild tox-conftool [integration/config] - 10https://gerrit.wikimedia.org/r/480459 [10:49:59] (03PS1) 10Legoktm: Rebuild tox-conftool [integration/config] - 10https://gerrit.wikimedia.org/r/480459 [10:50:01] (03PS1) 10Legoktm: Rebuild tox-eventlogging [integration/config] - 10https://gerrit.wikimedia.org/r/480460 [10:50:01] (03PS1) 10Legoktm: Rebuild tox-eventlogging [integration/config] - 10https://gerrit.wikimedia.org/r/480460 [10:50:03] (03PS1) 10Legoktm: Rebuild tox-labs-striker [integration/config] - 10https://gerrit.wikimedia.org/r/480461 [10:50:03] (03PS1) 10Legoktm: Rebuild tox-labs-striker [integration/config] - 10https://gerrit.wikimedia.org/r/480461 [10:50:05] (03PS1) 10Legoktm: Rebuild tox-poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/480462 [10:50:05] (03PS1) 10Legoktm: Rebuild tox-poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/480462 [10:51:08] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-cergen [integration/config] - 10https://gerrit.wikimedia.org/r/480457 (owner: 10Legoktm) [10:51:08] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-cergen [integration/config] - 10https://gerrit.wikimedia.org/r/480457 (owner: 10Legoktm) [10:51:49] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-certcentral [integration/config] - 10https://gerrit.wikimedia.org/r/480458 (owner: 10Legoktm) [10:51:49] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-certcentral [integration/config] - 10https://gerrit.wikimedia.org/r/480458 (owner: 10Legoktm) [10:52:33] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-conftool [integration/config] - 10https://gerrit.wikimedia.org/r/480459 (owner: 10Legoktm) [10:52:33] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-conftool [integration/config] - 10https://gerrit.wikimedia.org/r/480459 (owner: 10Legoktm) [10:52:42] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-eventlogging [integration/config] - 10https://gerrit.wikimedia.org/r/480460 (owner: 10Legoktm) [10:52:42] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-eventlogging [integration/config] - 10https://gerrit.wikimedia.org/r/480460 (owner: 10Legoktm) [10:52:49] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-labs-striker [integration/config] - 10https://gerrit.wikimedia.org/r/480461 (owner: 10Legoktm) [10:52:49] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-labs-striker [integration/config] - 10https://gerrit.wikimedia.org/r/480461 (owner: 10Legoktm) [10:52:55] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/480462 (owner: 10Legoktm) [10:52:55] (03CR) 10Legoktm: [C: 03+2] Rebuild tox-poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/480462 (owner: 10Legoktm) [10:53:57] (03Merged) 10jenkins-bot: Rebuild tox-cergen [integration/config] - 10https://gerrit.wikimedia.org/r/480457 (owner: 10Legoktm) [10:53:57] (03Merged) 10jenkins-bot: Rebuild tox-cergen [integration/config] - 10https://gerrit.wikimedia.org/r/480457 (owner: 10Legoktm) [10:54:37] James_F: according to https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/28465/testReport/(root)/Wikibase_MediaInfo_Tests_Integration_MultiLingualCaptionsTest/ the tests are being run and passing [10:54:37] James_F: according to https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/28465/testReport/(root)/Wikibase_MediaInfo_Tests_Integration_MultiLingualCaptionsTest/ the tests are being run and passing [10:54:57] (03Merged) 10jenkins-bot: Rebuild tox-certcentral [integration/config] - 10https://gerrit.wikimedia.org/r/480458 (owner: 10Legoktm) [10:54:57] (03Merged) 10jenkins-bot: Rebuild tox-certcentral [integration/config] - 10https://gerrit.wikimedia.org/r/480458 (owner: 10Legoktm) [10:55:09] (03Merged) 10jenkins-bot: Rebuild tox-conftool [integration/config] - 10https://gerrit.wikimedia.org/r/480459 (owner: 10Legoktm) [10:55:09] (03Merged) 10jenkins-bot: Rebuild tox-conftool [integration/config] - 10https://gerrit.wikimedia.org/r/480459 (owner: 10Legoktm) [10:55:12] (03Merged) 10jenkins-bot: Rebuild tox-eventlogging [integration/config] - 10https://gerrit.wikimedia.org/r/480460 (owner: 10Legoktm) [10:55:12] (03Merged) 10jenkins-bot: Rebuild tox-eventlogging [integration/config] - 10https://gerrit.wikimedia.org/r/480460 (owner: 10Legoktm) [10:55:19] (03Merged) 10jenkins-bot: Rebuild tox-labs-striker [integration/config] - 10https://gerrit.wikimedia.org/r/480461 (owner: 10Legoktm) [10:55:19] (03Merged) 10jenkins-bot: Rebuild tox-labs-striker [integration/config] - 10https://gerrit.wikimedia.org/r/480461 (owner: 10Legoktm) [10:55:34] (03Merged) 10jenkins-bot: Rebuild tox-poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/480462 (owner: 10Legoktm) [10:55:34] (03Merged) 10jenkins-bot: Rebuild tox-poolcounter [integration/config] - 10https://gerrit.wikimedia.org/r/480462 (owner: 10Legoktm) [10:55:47] legoktm: But https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/478226 -> https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/28465/console "Warning: Destructor threw an object exception: exception 'Wikimedia\Rdbms\DBConnectionError' with message 'Cannot access the database: Unknown error" [10:55:47] legoktm: But https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/478226 -> https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/28465/console "Warning: Destructor threw an object exception: exception 'Wikimedia\Rdbms\DBConnectionError' with message 'Cannot access the database: Unknown error" [10:55:59] legoktm: Is that not us? [10:55:59] legoktm: Is that not us? [10:56:12] !log rebuilding docker tox-* images [10:56:12] !log rebuilding docker tox-* images [10:56:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:56:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:58:32] James_F: have you checked other patches to see if the warning existed beforehand? [10:58:32] James_F: have you checked other patches to see if the warning existed beforehand? [10:59:02] Hmm. No. It does. [10:59:02] Hmm. No. It does. [10:59:15] So either we've never worked at all, but passed anyway, or it's something else. [10:59:15] So either we've never worked at all, but passed anyway, or it's something else. [10:59:38] well it's just a warning, and its in the destructor, so that doesn't cause test failures [10:59:39] well it's just a warning, and its in the destructor, so that doesn't cause test failures [10:59:44] er, jenkins failures* [10:59:44] er, jenkins failures* [10:59:49] Right. [10:59:49] Right. [11:00:00] I'll land our tests, then, and add WBMI to gate for Wikibase and MW. [11:00:00] I'll land our tests, then, and add WBMI to gate for Wikibase and MW. [11:00:44] legoktm: Thank you for the reassurance. :-) [11:00:44] legoktm: Thank you for the reassurance. :-) [11:00:48] np :) [11:00:48] np :) [11:02:53] hmmmmmmmmm [11:02:53] hmmmmmmmmm [11:02:58] (03PS1) 10Jforrester: Add WikibaseMediaInfo to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/480463 [11:02:58] (03PS1) 10Jforrester: Add WikibaseMediaInfo to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/480463 [11:03:04] ^^ [11:03:04] ^^ [11:03:07] I think tox is now defaulting to Python 3 [11:03:07] I think tox is now defaulting to Python 3 [11:03:13] Oh, fun. [11:03:13] Oh, fun. [11:04:45] (03CR) 10jerkins-bot: [V: 04-1] Add WikibaseMediaInfo to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/480463 (owner: 10Jforrester) [11:04:45] (03CR) 10jerkins-bot: [V: 04-1] Add WikibaseMediaInfo to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/480463 (owner: 10Jforrester) [11:06:58] Eurgh, where's the second list of gated extensions I need to update? [11:06:58] Eurgh, where's the second list of gated extensions I need to update? [11:23:51] all the tox-* images have been rebuilt, I'll deploy and test them in the morning [11:23:51] all the tox-* images have been rebuilt, I'll deploy and test them in the morning [11:24:18] er [11:24:18] er [11:24:22] later today [11:24:22] later today [11:25:47] :-) [11:25:47] :-) [11:26:00] legoktm: Do you know where the second list of gated extensions is? [11:26:00] legoktm: Do you know where the second list of gated extensions is? [11:26:49] James_F: you need to add the extension-gate template to zuul/layout.yaml I think [11:26:49] James_F: you need to add the extension-gate template to zuul/layout.yaml I think [11:27:03] Oh, right. [11:27:03] Oh, right. [11:27:16] besides that I'd look at the test to see what else its checking :p [11:27:16] besides that I'd look at the test to see what else its checking :p [11:27:19] good night :) [11:27:19] good night :) [11:27:54] (03PS2) 10Jforrester: Add WikibaseMediaInfo to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/480463 [11:27:54] (03PS2) 10Jforrester: Add WikibaseMediaInfo to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/480463 [11:28:00] See you. [11:28:00] See you. [11:36:27] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) [11:36:27] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) [11:36:29] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.8 deployment blockers - https://phabricator.wikimedia.org/T206662 (10zeljkofilipin) [11:36:29] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.8 deployment blockers - https://phabricator.wikimedia.org/T206662 (10zeljkofilipin) [11:36:32] legoktm: thx for the python 4 switch ! [11:36:32] legoktm: thx for the python 4 switch ! [11:36:39] 3* [11:36:39] 3* [11:38:26] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.8 deployment blockers - https://phabricator.wikimedia.org/T206662 (10zeljkofilipin) 05Open→03Resolved [11:38:26] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.8 deployment blockers - https://phabricator.wikimedia.org/T206662 (10zeljkofilipin) 05Open→03Resolved [11:41:06] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.8 deployment blockers - https://phabricator.wikimedia.org/T206662 (10zeljkofilipin) Related incident report: [[ https://wikitech.wikimedia.org/wiki/Incident_documentation/20181212-Train-1.33.0-wmf.8 | Inci... [11:41:06] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.8 deployment blockers - https://phabricator.wikimedia.org/T206662 (10zeljkofilipin) Related incident report: [[ https://wikitech.wikimedia.org/wiki/Incident_documentation/20181212-Train-1.33.0-wmf.8 | Inci... [12:49:58] my eyes popped out at the python 4 typo [12:49:58] my eyes popped out at the python 4 typo [12:53:07] Heh I wonder what python4 is :P [12:53:07] Heh I wonder what python4 is :P [12:59:22] 10Release-Engineering-Team (Kanban), 10Outreachy (Round 17), 10Patch-For-Review, 10User-zeljkofilipin: Outreachy microtask: Writing Echo node.js tests (#2) - https://phabricator.wikimedia.org/T204775 (10zeljkofilipin) a:03zeljkofilipin [12:59:23] 10Release-Engineering-Team (Kanban), 10Outreachy (Round 17), 10Patch-For-Review, 10User-zeljkofilipin: Outreachy microtask: Writing Echo node.js tests (#2) - https://phabricator.wikimedia.org/T204775 (10zeljkofilipin) a:03zeljkofilipin [13:01:50] 10Release-Engineering-Team (Kanban), 10Outreachy (Round 17), 10Patch-For-Review, 10User-zeljkofilipin: Outreachy microtask: Writing Echo node.js tests (#2) - https://phabricator.wikimedia.org/T204775 (10zeljkofilipin) p:05Triage→03Normal [13:01:50] 10Release-Engineering-Team (Kanban), 10Outreachy (Round 17), 10Patch-For-Review, 10User-zeljkofilipin: Outreachy microtask: Writing Echo node.js tests (#2) - https://phabricator.wikimedia.org/T204775 (10zeljkofilipin) p:05Triage→03Normal [13:07:35] paladox, python4 is The Future, isn't it :) [13:07:35] paladox, python4 is The Future, isn't it :) [14:12:56] (03CR) 10Urbanecm: [C: 03+1] "LGTM" [integration/config] - 10https://gerrit.wikimedia.org/r/479979 (owner: 10Framawiki) [14:12:56] (03CR) 10Urbanecm: [C: 03+1] "LGTM" [integration/config] - 10https://gerrit.wikimedia.org/r/479979 (owner: 10Framawiki) [14:15:14] Lol [14:15:14] Lol [14:23:28] (03CR) 10Urbanecm: [C: 04-1] "Do not deploy without my approval, please." [integration/config] - 10https://gerrit.wikimedia.org/r/479738 (https://phabricator.wikimedia.org/T211938) (owner: 10Urbanecm) [14:23:28] (03CR) 10Urbanecm: [C: 04-1] "Do not deploy without my approval, please." [integration/config] - 10https://gerrit.wikimedia.org/r/479738 (https://phabricator.wikimedia.org/T211938) (owner: 10Urbanecm) [14:28:49] 10Continuous-Integration-Config, 10WMCZ-Tracker, 10Patch-For-Review: Setup gate-and-submit-l10n for wikimedia-cz/tracker - https://phabricator.wikimedia.org/T211938 (10Urbanecm) 05Open→03Declined Will use a better approach. [14:28:49] 10Continuous-Integration-Config, 10WMCZ-Tracker, 10Patch-For-Review: Setup gate-and-submit-l10n for wikimedia-cz/tracker - https://phabricator.wikimedia.org/T211938 (10Urbanecm) 05Open→03Declined Will use a better approach. [14:29:39] (03PS5) 10Urbanecm: Setup gate-and-submit-l10n for wikimedia-cz/tracker [integration/config] - 10https://gerrit.wikimedia.org/r/479738 (https://phabricator.wikimedia.org/T209313) [14:29:39] (03PS5) 10Urbanecm: Setup gate-and-submit-l10n for wikimedia-cz/tracker [integration/config] - 10https://gerrit.wikimedia.org/r/479738 (https://phabricator.wikimedia.org/T209313) [14:31:45] (03CR) 10jerkins-bot: [V: 04-1] Setup gate-and-submit-l10n for wikimedia-cz/tracker [integration/config] - 10https://gerrit.wikimedia.org/r/479738 (https://phabricator.wikimedia.org/T209313) (owner: 10Urbanecm) [14:31:45] (03CR) 10jerkins-bot: [V: 04-1] Setup gate-and-submit-l10n for wikimedia-cz/tracker [integration/config] - 10https://gerrit.wikimedia.org/r/479738 (https://phabricator.wikimedia.org/T209313) (owner: 10Urbanecm) [14:37:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog): Set up a Prometheus server under the integration project - https://phabricator.wikimedia.org/T205930 (10fgiunchedi) >>! In T205930#4830474, @hashar wrote: > @fgiunchedi do you have any guidance to create a Prometheus instance on WMC... [14:37:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog): Set up a Prometheus server under the integration project - https://phabricator.wikimedia.org/T205930 (10fgiunchedi) >>! In T205930#4830474, @hashar wrote: > @fgiunchedi do you have any guidance to create a Prometheus instance on WMC... [14:48:10] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) [14:48:10] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) [15:01:40] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) [15:01:40] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) [15:46:46] Hi, with the new tox-docker image that has multiple Python versions I'm hitting the 3 minutes timeout for the tox job, that is not enough to go through all the defined envs for all versions. [15:46:46] Hi, with the new tox-docker image that has multiple Python versions I'm hitting the 3 minutes timeout for the tox job, that is not enough to go through all the defined envs for all versions. [15:47:07] I'm wondering if we should bump the global one or if I should bump the repo-specific one, and how [15:47:07] I'm wondering if we should bump the global one or if I should bump the repo-specific one, and how [15:48:45] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) Incident report: [[ https://wikitech.wikimedia.org/wiki/Incident_documentation/20181218-train-1.33.0-wmf.9 | Incident_doc... [15:48:45] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments, 10User-zeljkofilipin: 1.33.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T206663 (10zeljkofilipin) Incident report: [[ https://wikitech.wikimedia.org/wiki/Incident_documentation/20181218-train-1.33.0-wmf.9 | Incident_doc... [15:59:04] zeljkof: sorry about the boneheaded deployment blocker (T212218). https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Kartographer/+/480512/ should fix it. should i backport and put it on the calendar for the next SWAT window? or should we do it sooner? [15:59:04] zeljkof: sorry about the boneheaded deployment blocker (T212218). https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Kartographer/+/480512/ should fix it. should i backport and put it on the calendar for the next SWAT window? or should we do it sooner? [15:59:05] T212218: Fatal error: Call to undefined function Kartographer\Wikimedia\suppressWarnings() in /srv/mediawiki/php-1.33.0-wmf.9/extensions/Kartographer/includes/ApiQueryMapData.php on line 49 - https://phabricator.wikimedia.org/T212218 [15:59:05] T212218: Fatal error: Call to undefined function Kartographer\Wikimedia\suppressWarnings() in /srv/mediawiki/php-1.33.0-wmf.9/extensions/Kartographer/includes/ApiQueryMapData.php on line 49 - https://phabricator.wikimedia.org/T212218 [15:59:29] mdholloway: please put it on the next swat window [15:59:29] mdholloway: please put it on the next swat window [15:59:44] mdholloway: and no problem, I'm just surprised a linter didn't catch it [15:59:44] mdholloway: and no problem, I'm just surprised a linter didn't catch it [15:59:45] zeljkof: k, thanks [15:59:45] zeljkof: k, thanks [15:59:58] zeljkof: i was wondering about that myself... [15:59:58] zeljkof: i was wondering about that myself... [16:00:27] the other train blocker is similar one is undefined variable, other undefined function [16:00:27] the other train blocker is similar one is undefined variable, other undefined function [16:00:40] those seem to be trivial, but maybe tricky for a linter to catch [16:00:40] those seem to be trivial, but maybe tricky for a linter to catch [16:00:53] (trivial mistakes, that is) [16:00:53] (trivial mistakes, that is) [16:10:29] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Zuul: Zuul cancels all changes when a change is manually merged - https://phabricator.wikimedia.org/T203846 (10hashar) [16:10:29] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Zuul: Zuul cancels all changes when a change is manually merged - https://phabricator.wikimedia.org/T203846 (10hashar) [16:14:50] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10cloud-services-team (Kanban): Phase out Nodepool from production - https://phabricator.wikimedia.org/T209361 (10hashar) [16:14:50] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10cloud-services-team (Kanban): Phase out Nodepool from production - https://phabricator.wikimedia.org/T209361 (10hashar) [16:17:57] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10DBA: [DBA] remove nodepooldb on production-m5 and nodepool user - https://phabricator.wikimedia.org/T212230 (10hashar) p:05Triage→03Normal [16:17:57] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10DBA: [DBA] remove nodepooldb on production-m5 and nodepool user - https://phabricator.wikimedia.org/T212230 (10hashar) p:05Triage→03Normal [16:18:31] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10cloud-services-team (Kanban): Phase out Nodepool from production - https://phabricator.wikimedia.org/T209361 (10hashar) [16:18:31] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10cloud-services-team (Kanban): Phase out Nodepool from production - https://phabricator.wikimedia.org/T209361 (10hashar) [16:21:18] James_F: hi hi [16:21:18] James_F: hi hi [16:21:38] Heya addshore, you wonderful person you. [16:21:38] Heya addshore, you wonderful person you. [16:22:50] i just realized WikibaseLexeme is not in mw gates extensions too while looking at your patch :( [16:22:50] i just realized WikibaseLexeme is not in mw gates extensions too while looking at your patch :( [16:22:57] urgff [16:22:57] urgff [16:24:03] https://phabricator.wikimedia.org/T204153 [16:24:03] https://phabricator.wikimedia.org/T204153 [16:24:08] oh, i wrote a ticket for it .. [16:24:08] oh, i wrote a ticket for it .. [16:24:49] I mean, I can write a patch for Lexeme too. [16:24:49] I mean, I can write a patch for Lexeme too. [16:25:04] i just sense people are gonna start complaining about slowness :P [16:25:04] i just sense people are gonna start complaining about slowness :P [16:25:21] They already do. [16:25:21] They already do. [16:25:29] The trick is to write minimal-spanning unit tests. [16:25:29] The trick is to write minimal-spanning unit tests. [16:25:44] Maybe gate should only run a sub-set of each extension's tests/ [16:25:44] Maybe gate should only run a sub-set of each extension's tests/ [16:25:55] well, i think we should kill gate [16:25:55] well, i think we should kill gate [16:26:09] and just have "builds" or WMF flavour mediawiki run constantly [16:26:09] and just have "builds" or WMF flavour mediawiki run constantly [16:26:19] when the last one ends, start the next one [16:26:19] when the last one ends, start the next one [16:26:19] Conversely, I think gate should have every extension in production. [16:26:19] Conversely, I think gate should have every extension in production. [16:26:31] any one of those builds can be chosen for the branch to be deployed [16:26:31] any one of those builds can be chosen for the branch to be deployed [16:26:43] i agree, it should have all deployed things [16:26:44] i agree, it should have all deployed things [16:26:44] That lets people merge and dash. [16:26:44] That lets people merge and dash. [16:26:54] Which was a disaster, and why we moved to pre-merge CI. [16:26:54] Which was a disaster, and why we moved to pre-merge CI. [16:27:18] It's a terrible development anti-pattern. [16:27:18] It's a terrible development anti-pattern. [16:27:21] we should just have a solid rules, of if it breaks the build, revert it no questions asked and fix it after [16:27:21] we should just have a solid rules, of if it breaks the build, revert it no questions asked and fix it after [16:27:45] i actually don't really care about the length of builds any more [16:27:45] i actually don't really care about the length of builds any more [16:27:56] I'd rather have the tests [16:27:56] I'd rather have the tests [16:27:57] Some of us have to deploy stuff, so we do. :-P [16:27:57] Some of us have to deploy stuff, so we do. :-P [16:28:08] yeh, bcakports onto wmf branches are a bit of a pain [16:28:08] yeh, bcakports onto wmf branches are a bit of a pain [16:28:15] *backports [16:28:15] *backports [16:28:28] at least we dont have a multi day build time ;) [16:28:28] at least we dont have a multi day build time ;) [16:28:32] Yet [16:28:32] Yet [17:20:47] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), and 2 others: TEC3:O3:O3.1:Q2 Goal - Move Blubberoid, ZoteroV2, and Graphoid through the production CD Pipeline - https://phabricator.wikimedia.org/T205919 (10thcipriani) [17:20:47] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), and 2 others: TEC3:O3:O3.1:Q2 Goal - Move Blubberoid, ZoteroV2, and Graphoid through the production CD Pipeline - https://phabricator.wikimedia.org/T205919 (10thcipriani) [17:20:51] 10Release-Engineering-Team (Kanban), 10Operations, 10Release Pipeline, 10Patch-For-Review, 10Services (watching): Move Graphoid to Kubernetes via the deployment pipeline - https://phabricator.wikimedia.org/T203091 (10thcipriani) [17:20:51] 10Release-Engineering-Team (Kanban), 10Operations, 10Release Pipeline, 10Patch-For-Review, 10Services (watching): Move Graphoid to Kubernetes via the deployment pipeline - https://phabricator.wikimedia.org/T203091 (10thcipriani) [17:29:27] legoktm: you around by any chance? [17:29:27] legoktm: you around by any chance? [17:33:35] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10Release Pipeline: contint1001:/var/lib/docker growth - https://phabricator.wikimedia.org/T207702 (10thcipriani) p:05Triage→03Normal [17:33:35] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10Release Pipeline: contint1001:/var/lib/docker growth - https://phabricator.wikimedia.org/T207702 (10thcipriani) p:05Triage→03Normal [17:34:30] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Develop set of metrics to assess incident reports/post mortems - https://phabricator.wikimedia.org/T206622 (10thcipriani) [17:34:30] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Develop set of metrics to assess incident reports/post mortems - https://phabricator.wikimedia.org/T206622 (10thcipriani) [17:37:15] 10Release-Engineering-Team (Kanban), 10Operations, 10serviceops, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM request for doc.wikimedia.org - https://phabricator.wikimedia.org/T211974 (10Dzahn) @Hashar Here you go: - doc1001.eqiad.wmnet - stretch - php 7.2, not just 7.0 - php-fpm, not mod_php anymore... [17:37:15] 10Release-Engineering-Team (Kanban), 10Operations, 10serviceops, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM request for doc.wikimedia.org - https://phabricator.wikimedia.org/T211974 (10Dzahn) @Hashar Here you go: - doc1001.eqiad.wmnet - stretch - php 7.2, not just 7.0 - php-fpm, not mod_php anymore... [17:39:55] 10Release-Engineering-Team (Kanban), 10Operations, 10Release Pipeline: Refactor pipeline build step to be more isolated/secure/scalable - https://phabricator.wikimedia.org/T195050 (10thcipriani) 05Open→03Invalid The model of execution that this task refers to is not longer used/valid. [17:39:55] 10Release-Engineering-Team (Kanban), 10Operations, 10Release Pipeline: Refactor pipeline build step to be more isolated/secure/scalable - https://phabricator.wikimedia.org/T195050 (10thcipriani) 05Open→03Invalid The model of execution that this task refers to is not longer used/valid. [17:46:44] 10Release-Engineering-Team (Backlog), 10Release Pipeline: Implement a smoke + parallel strategy for running end-to-end tests - https://phabricator.wikimedia.org/T130037 (10thcipriani) 05Open→03Invalid Talked about this with @dduvall in the pipeline meeting today. This work is implicit in the design of the... [17:46:44] 10Release-Engineering-Team (Backlog), 10Release Pipeline: Implement a smoke + parallel strategy for running end-to-end tests - https://phabricator.wikimedia.org/T130037 (10thcipriani) 05Open→03Invalid Talked about this with @dduvall in the pipeline meeting today. This work is implicit in the design of the... [17:49:44] 10Release-Engineering-Team (Backlog), 10Release Pipeline, 10Scoring-platform-team, 10Wikibase-Containers, and 3 others: Stretch in docker registry forces ascii encoding - https://phabricator.wikimedia.org/T210260 (10thcipriani) [17:49:44] 10Release-Engineering-Team (Backlog), 10Release Pipeline, 10Scoring-platform-team, 10Wikibase-Containers, and 3 others: Stretch in docker registry forces ascii encoding - https://phabricator.wikimedia.org/T210260 (10thcipriani) [17:50:35] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Refactor validation system to use jsonschema - https://phabricator.wikimedia.org/T207695 (10thcipriani) p:05Triage→03Normal [17:50:35] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Refactor validation system to use jsonschema - https://phabricator.wikimedia.org/T207695 (10thcipriani) p:05Triage→03Normal [17:51:27] 10Release-Engineering-Team, 10Release Pipeline (Blubber): Manually defining artifacts results in default copy of all project files - https://phabricator.wikimedia.org/T211625 (10thcipriani) p:05Triage→03Normal [17:51:27] 10Release-Engineering-Team, 10Release Pipeline (Blubber): Manually defining artifacts results in default copy of all project files - https://phabricator.wikimedia.org/T211625 (10thcipriani) p:05Triage→03Normal [18:08:48] hashar: around by any chance? [18:08:48] hashar: around by any chance? [18:14:20] volans: he is at dinner but will come back :) [18:14:20] volans: he is at dinner but will come back :) [18:16:09] 10Release-Engineering-Team (Kanban), 10Scap, 10Patch-For-Review: l10nupdate is still using HHVM - https://phabricator.wikimedia.org/T205313 (10thcipriani) a:05thcipriani→03None [18:16:09] 10Release-Engineering-Team (Kanban), 10Scap, 10Patch-For-Review: l10nupdate is still using HHVM - https://phabricator.wikimedia.org/T205313 (10thcipriani) a:05thcipriani→03None [18:18:07] :) [18:18:07] :) [18:48:51] 10Release-Engineering-Team (Kanban), 10Operations, 10serviceops, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM request for doc.wikimedia.org - https://phabricator.wikimedia.org/T211974 (10Dzahn) - added "doc" as an official cluster prefix https://wikitech.wikimedia.org/w/index.php?title=Infrastructure_n... [18:48:51] 10Release-Engineering-Team (Kanban), 10Operations, 10serviceops, 10vm-requests, 10Patch-For-Review: eqiad: 1 VM request for doc.wikimedia.org - https://phabricator.wikimedia.org/T211974 (10Dzahn) - added "doc" as an official cluster prefix https://wikitech.wikimedia.org/w/index.php?title=Infrastructure_n... [18:53:47] welcome back hashar, volans had a question and i was going to merge the ci::master apache/httpd change ;) [18:53:47] welcome back hashar, volans had a question and i was going to merge the ci::master apache/httpd change ;) [18:54:06] mutante: +1 :) [18:54:06] mutante: +1 :) [18:54:11] :) [18:54:11] :) [18:54:16] volans: yeah more or less back. Leave a message :) [18:54:16] volans: yeah more or less back. Leave a message :) [18:55:37] given apache on the ci master just serves doc.wm.o and act as a proxy for jenkins/zuul embedded web servr [18:55:37] given apache on the ci master just serves doc.wm.o and act as a proxy for jenkins/zuul embedded web servr [18:55:43] apache can be restarted at anytime [18:55:43] apache can be restarted at anytime [18:56:11] hashar: how to increase the timeout for the tox-docker job? [18:56:11] hashar: how to increase the timeout for the tox-docker job? [18:56:23] I'm not sure I find the right place in integration/config [18:56:23] I'm not sure I find the right place in integration/config [18:56:53] build_timeout: 30 # minutes [18:56:53] build_timeout: 30 # minutes [18:57:06] contex: after Kunal's patch to use multiple Python versions, now tox takes more time as it goes through all env for 3 python versions, potentially 4 [18:57:06] contex: after Kunal's patch to use multiple Python versions, now tox takes more time as it goes through all env for 3 python versions, potentially 4 [18:57:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Discovery-Search, 10Elasticsearch: Set up data storage to collect loosely structured data from CI - https://phabricator.wikimedia.org/T211904 (10EBjune) @mmodell EBernhardson is out through the end of the year and really needs to weigh... [18:57:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Discovery-Search, 10Elasticsearch: Set up data storage to collect loosely structured data from CI - https://phabricator.wikimedia.org/T211904 (10EBjune) @mmodell EBernhardson is out through the end of the year and really needs to weigh... [18:57:29] at least for spicerack/cumin, so it hits the 3 minutes timeout [18:57:29] at least for spicerack/cumin, so it hits the 3 minutes timeout [18:57:31] argh [18:57:31] argh [18:57:55] https://integration.wikimedia.org/ci/job/tox-docker/4950/console for example [18:57:55] https://integration.wikimedia.org/ci/job/tox-docker/4950/console for example [18:58:42] 13:28:55 Started ... 13:31:55 Build timed out (after 3 minutes) [18:58:42] 13:28:55 Started ... 13:31:55 Build timed out (after 3 minutes) [19:00:34] so I was wondering if we should increase that to maybe 10m globally instead of a per-repo basis [19:00:34] so I was wondering if we should increase that to maybe 10m globally instead of a per-repo basis [19:00:44] so the job is in jjb/python-jobs.yaml [19:00:44] so the job is in jjb/python-jobs.yaml [19:00:58] hashar: merged and nothing happens at all. not even a service restart :) [19:00:58] hashar: merged and nothing happens at all. not even a service restart :) [19:01:01] the template accepts a build_timeout parameter which defaults to 3 (minutes) [19:01:01] the template accepts a build_timeout parameter which defaults to 3 (minutes) [19:01:05] mutante: magic! [19:01:05] mutante: magic! [19:01:54] volans: and the cumin-tox-docker job is defined in jjb/operations-misc.yaml , turns out it already has a 12 minutes timeout [19:01:54] volans: and the cumin-tox-docker job is defined in jjb/operations-misc.yaml , turns out it already has a 12 minutes timeout [19:02:28] there is not much left now to be able to delete module apache. just a major one .. "simplelamp" in cloud because it has a bunch of users [19:02:28] there is not much left now to be able to delete module apache. just a major one .. "simplelamp" in cloud because it has a bunch of users [19:04:37] volans: so yeah should bump the timeout so that it default to 10 instead of 3. That is probably sane [19:04:37] volans: so yeah should bump the timeout so that it default to 10 instead of 3. That is probably sane [19:04:43] hashar: should we bump build_timeout default globally in 'timeout: '{obj:build_timeout|3}' # minutes'? [19:04:43] hashar: should we bump build_timeout default globally in 'timeout: '{obj:build_timeout|3}' # minutes'? [19:04:46] 10Release-Engineering-Team, 10SDC General, 10Wikidata, 10Wiki-Setup (Create): Create a production test wiki in group0 to parallel Wikimedia Commons - https://phabricator.wikimedia.org/T197616 (10greg) 05Declined→03Open >>! In T197616#4543890, @greg wrote: > After speaking with @MarkTraceur we agreed to... [19:04:46] 10Release-Engineering-Team, 10SDC General, 10Wikidata, 10Wiki-Setup (Create): Create a production test wiki in group0 to parallel Wikimedia Commons - https://phabricator.wikimedia.org/T197616 (10greg) 05Declined→03Open >>! In T197616#4543890, @greg wrote: > After speaking with @MarkTraceur we agreed to... [19:04:48] yes [19:04:48] yes [19:04:50] sounds good [19:04:50] sounds good [19:04:52] ack sending patch [19:04:52] ack sending patch [19:05:01] James_F: https://phabricator.wikimedia.org/T197616#4832209 [19:05:01] James_F: https://phabricator.wikimedia.org/T197616#4832209 [19:05:20] 10Release-Engineering-Team, 10SDC Engineering, 10SDC General, 10Wikidata, 10Wiki-Setup (Create): Create a production test wiki in group0 to parallel Wikimedia Commons - https://phabricator.wikimedia.org/T197616 (10Jdforrester-WMF) [19:05:20] 10Release-Engineering-Team, 10SDC Engineering, 10SDC General, 10Wikidata, 10Wiki-Setup (Create): Create a production test wiki in group0 to parallel Wikimedia Commons - https://phabricator.wikimedia.org/T197616 (10Jdforrester-WMF) [19:05:28] greg-g: Thank you sir. :-) [19:05:28] greg-g: Thank you sir. :-) [19:06:40] (03PS1) 10Volans: tox-docker: bump default timeout to 10 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/480570 (https://phabricator.wikimedia.org/T191764) [19:06:40] (03PS1) 10Volans: tox-docker: bump default timeout to 10 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/480570 (https://phabricator.wikimedia.org/T191764) [19:06:48] hashar: ^^^ [19:06:48] hashar: ^^^ [19:07:00] (03Abandoned) 10Hashar: [OpenID] Switch from generic test to composer test [integration/config] - 10https://gerrit.wikimedia.org/r/276969 (owner: 10Paladox) [19:07:00] (03Abandoned) 10Hashar: [OpenID] Switch from generic test to composer test [integration/config] - 10https://gerrit.wikimedia.org/r/276969 (owner: 10Paladox) [19:08:04] volans: good :) [19:08:04] volans: good :) [19:09:24] (03CR) 10Hashar: [C: 03+2] "Deployed :)" [integration/config] - 10https://gerrit.wikimedia.org/r/480570 (https://phabricator.wikimedia.org/T191764) (owner: 10Volans) [19:09:24] (03CR) 10Hashar: [C: 03+2] "Deployed :)" [integration/config] - 10https://gerrit.wikimedia.org/r/480570 (https://phabricator.wikimedia.org/T191764) (owner: 10Volans) [19:09:52] thanks! [19:09:52] thanks! [19:12:02] (03Merged) 10jenkins-bot: tox-docker: bump default timeout to 10 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/480570 (https://phabricator.wikimedia.org/T191764) (owner: 10Volans) [19:12:02] (03Merged) 10jenkins-bot: tox-docker: bump default timeout to 10 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/480570 (https://phabricator.wikimedia.org/T191764) (owner: 10Volans) [19:12:19] hashar: also merged change for php7 on stretch, unblocks contint1001 -> contint1002, heh. and we could also convert that away from mod_php [19:12:19] hashar: also merged change for php7 on stretch, unblocks contint1001 -> contint1002, heh. and we could also convert that away from mod_php [19:12:36] (speaking just for the webserver part) [19:12:36] (speaking just for the webserver part) [19:12:41] volans: I should get it changed to "detox" which runs stuff in parallel ( https://pypi.org/project/detox/ ) [19:12:41] volans: I should get it changed to "detox" which runs stuff in parallel ( https://pypi.org/project/detox/ ) [19:13:04] mutante: do we have a contint1002 yet ? [19:13:04] mutante: do we have a contint1002 yet ? [19:13:43] hashar: no, that is in the future but i think save to say that will be its name .. to upgrade contint1* to stretch [19:13:43] hashar: no, that is in the future but i think save to say that will be its name .. to upgrade contint1* to stretch [19:14:03] do you want to request it? [19:14:03] do you want to request it? [19:14:21] not yet [19:14:21] not yet [19:14:23] ok [19:14:23] ok [19:14:33] there is preliminary work to handle before we might even start thinking about it hehe [19:14:33] there is preliminary work to handle before we might even start thinking about it hehe [19:14:42] fair enough [19:14:42] fair enough [19:15:02] hashar: a quick try of detox locally fails miserably :D [19:15:02] hashar: a quick try of detox locally fails miserably :D [19:15:21] volans: try with a real language such as python instead of php ? [19:15:21] volans: try with a real language such as python instead of php ? [19:15:37] ;D [19:15:37] ;D [19:23:16] mutante: I would need a system user and a ssh key pair to rsync from contint1001 to the doc host [19:23:16] mutante: I would need a system user and a ssh key pair to rsync from contint1001 to the doc host [19:25:51] hashar: i can (let puppet) setup the rsyncd on doc1001 so that you can write to /srv/org/wikimedia/doc [19:25:51] hashar: i can (let puppet) setup the rsyncd on doc1001 so that you can write to /srv/org/wikimedia/doc [19:26:21] limited by the fact that you come from contint* [19:26:21] limited by the fact that you come from contint* [19:26:22] yeah but then I need a Jenkins job that runs on contint1001 to be able to rsync to doc1001 and hence ssh into it [19:26:22] yeah but then I need a Jenkins job that runs on contint1001 to be able to rsync to doc1001 and hence ssh into it [19:27:25] I would rather not have it wide open [19:27:25] I would rather not have it wide open [19:27:54] it's limited by iptables and hosts.allow in rsyncd config [19:27:54] it's limited by iptables and hosts.allow in rsyncd config [19:28:06] from where else do you want to push then? [19:28:06] from where else do you want to push then? [19:28:19] it said from contint? [19:28:19] it said from contint? [19:28:26] other job, a docker container being build on contint1001, zuul whatever :) [19:28:26] other job, a docker container being build on contint1001, zuul whatever :) [19:28:59] but that's actually more open? [19:28:59] but that's actually more open? [19:29:24] what source IPs should be allowed? [19:29:24] what source IPs should be allowed? [19:29:42] only the ci masters so contint1001 and contint2001 [19:29:42] only the ci masters so contint1001 and contint2001 [19:31:17] ok [19:31:17] ok [19:31:38] now I have a doubt as to how it is currently setup :/ [19:31:38] now I have a doubt as to how it is currently setup :/ [19:32:24] let me just show you what i mean and we see if it works for you [19:32:24] let me just show you what i mean and we see if it works for you [19:32:34] since we are pushing it is not going to touch contint* [19:32:34] since we are pushing it is not going to touch contint* [19:32:38] only the new box [19:32:38] only the new box [19:33:52] the flow is CI instance build the doc, a job on contint1001 fetch from the instance and then push to doc1001 [19:33:52] the flow is CI instance build the doc, a job on contint1001 fetch from the instance and then push to doc1001 [19:37:28] ack, i will allow push to doc1001 if coming from contint [19:37:28] ack, i will allow push to doc1001 if coming from contint [19:43:38] 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10User-ArielGlenn: CI: run tests with multiple Python3 versions - https://phabricator.wikimedia.org/T191764 (10hashar) 05Open→03Resolved a:03faidon @faidon that looks easier than pyenv in the end. Did you need any specific patches for the po... [19:43:38] 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10User-ArielGlenn: CI: run tests with multiple Python3 versions - https://phabricator.wikimedia.org/T191764 (10hashar) 05Open→03Resolved a:03faidon @faidon that looks easier than pyenv in the end. Did you need any specific patches for the po... [19:44:07] https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/480573/ [19:44:07] https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/480573/ [19:45:19] mutante: so hosts_allow on rsync and the IP v4 and v6 ferm rules get automatically added ? :) [19:45:19] mutante: so hosts_allow on rsync and the IP v4 and v6 ferm rules get automatically added ? :) [19:45:53] hashar: yea, that's "autoferm" by moritz [19:45:53] hashar: yea, that's "autoferm" by moritz [19:46:13] the role has include rsync::server , shouldn't it be in the profile instead? [19:46:13] the role has include rsync::server , shouldn't it be in the profile instead? [19:46:48] rsync::server should be converted to a profile and then be in the role :p [19:46:48] rsync::server should be converted to a profile and then be in the role :p [19:47:00] ahhh [19:47:00] ahhh [19:48:27] hashar: you are right and jenkins bot agrees, moving it [19:48:27] hashar: you are right and jenkins bot agrees, moving it [19:48:41] I am still puzzled by that role / profile split [19:48:41] I am still puzzled by that role / profile split [19:48:50] or whether a profile can include other profiles [19:48:50] or whether a profile can include other profiles [19:49:14] 10Beta-Cluster-Infrastructure, 10Operations: Set up a process for regularly updating the Beta Cluster's copies of common.js, gadgets, and similar files - https://phabricator.wikimedia.org/T212244 (10Whatamidoing-WMF) p:05Triage→03Normal [19:49:14] 10Beta-Cluster-Infrastructure, 10Operations: Set up a process for regularly updating the Beta Cluster's copies of common.js, gadgets, and similar files - https://phabricator.wikimedia.org/T212244 (10Whatamidoing-WMF) p:05Triage→03Normal [19:50:58] 10Release-Engineering-Team (Kanban), 10Code-Stewardship-Reviews, 10Graphoid, 10Operations, 10Services: graphoid: Code stewardship request - https://phabricator.wikimedia.org/T211881 (10greg) p:05Triage→03Normal [19:50:58] 10Release-Engineering-Team (Kanban), 10Code-Stewardship-Reviews, 10Graphoid, 10Operations, 10Services: graphoid: Code stewardship request - https://phabricator.wikimedia.org/T211881 (10greg) p:05Triage→03Normal [19:51:00] hashar: ideally one role that includes nothing but profiles and no includes between the profiles, they only use modules.. i think [19:51:00] hashar: ideally one role that includes nothing but profiles and no includes between the profiles, they only use modules.. i think [19:52:04] and that rsync::server looks to me like it should be next to ::profile::backup::host [19:52:04] and that rsync::server looks to me like it should be next to ::profile::backup::host [19:52:17] probably [19:52:17] probably [19:52:30] that made me move it to role [19:52:30] that made me move it to role [19:52:46] well [19:52:46] well [19:53:01] I mean , there should probably be a profile::rsync::server so one can load it at role level [19:53:01] I mean , there should probably be a profile::rsync::server so one can load it at role level [19:53:08] yes, that [19:53:08] yes, that [19:53:11] giuseppe would know :) [19:53:11] giuseppe would know :) [19:53:44] meanwhile for that change, I thinkg it is easier add to the doc profile: class { '::rsync::server:': } [19:53:44] meanwhile for that change, I thinkg it is easier add to the doc profile: class { '::rsync::server:': } [19:54:00] seems that how it is done in other profiles [19:54:00] seems that how it is done in other profiles [19:54:29] yea, i had the same thoughts. doing that [19:54:29] yea, i had the same thoughts. doing that [19:56:39] seems easier [19:56:39] seems easier [19:57:19] then the rsync root is /srv/org/wikimedia/doc which belong to root:wikidev [19:57:19] then the rsync root is /srv/org/wikimedia/doc which belong to root:wikidev [19:57:21] amended and jenkins-bot likes it [19:57:21] amended and jenkins-bot likes it [19:57:37] yes [19:57:37] yes [19:57:39] but does rsyncd runs as root? [19:57:39] but does rsyncd runs as root? [19:58:20] yes [19:58:20] yes [19:58:41] so files get owned by root, but what if one set some setuid on a file and runs it ? :) [19:58:41] so files get owned by root, but what if one set some setuid on a file and runs it ? :) [19:58:44] if you use that rsync::quickdatacopy class [19:58:44] if you use that rsync::quickdatacopy class [19:58:52] you get a cronjob on the other side to automate pull [19:58:52] you get a cronjob on the other side to automate pull [19:59:15] I don't need that part though [19:59:15] I don't need that part though [19:59:24] it is the jenkins job which will push to doc1001 :) [19:59:24] it is the jenkins job which will push to doc1001 :) [19:59:35] ack, it confirms that root is used for it though [19:59:35] ack, it confirms that root is used for it though [19:59:54] it's in root's cron. all i was saying [19:59:54] it's in root's cron. all i was saying [20:00:10] ok [20:00:10] ok [20:01:12] so we should create "jenkins" user as it exists on contint hosts i guess [20:01:12] so we should create "jenkins" user as it exists on contint hosts i guess [20:01:38] and add it also on doc [20:01:38] and add it also on doc [20:02:27] that one modules/jenkins/manifests/init.pp: user { 'jenkins': [20:02:27] that one modules/jenkins/manifests/init.pp: user { 'jenkins': [20:02:47] 10Beta-Cluster-Infrastructure: Set up a process for regularly updating the Beta Cluster's copies of common.js, gadgets, and similar files - https://phabricator.wikimedia.org/T212244 (10Krenair) [20:02:47] 10Beta-Cluster-Infrastructure: Set up a process for regularly updating the Beta Cluster's copies of common.js, gadgets, and similar files - https://phabricator.wikimedia.org/T212244 (10Krenair) [20:03:54] mutante: yeah so it is probably better to create some system user for doc [20:03:54] mutante: yeah so it is probably better to create some system user for doc [20:04:01] but without jenkins in the name :) [20:04:01] but without jenkins in the name :) [20:04:11] "doc" might be too generic [20:04:11] "doc" might be too generic [20:04:37] but jenkins actually is the uploader and already a user? [20:04:37] but jenkins actually is the uploader and already a user? [20:04:59] well until we drop jenkins from the equation :) [20:04:59] well until we drop jenkins from the equation :) [20:05:16] ok [20:05:16] ok [20:05:30] "doc-uploader" [20:05:30] "doc-uploader" [20:05:35] +2 ! [20:05:35] +2 ! [20:05:38] naming is hard [20:05:38] naming is hard [20:05:43] but the thing is with each of these users.. [20:05:43] but the thing is with each of these users.. [20:05:50] we want to "reserve a UID" [20:05:50] we want to "reserve a UID" [20:05:56] and use the same one across all systems [20:05:56] and use the same one across all systems [20:06:01] and that is overhead [20:06:01] and that is overhead [20:06:08] does it matter in this case? [20:06:08] does it matter in this case? [20:06:12] it needs to be regested on UID on wikitech [20:06:12] it needs to be regested on UID on wikitech [20:06:15] 10Gerrit, 10Proton, 10Core Platform Team Backlog (Attic), 10Readers-Web-Backlog (Tracking), and 2 others: Rename chromium-render gerrit project to Proton - https://phabricator.wikimedia.org/T211375 (10Jdlrobson) [20:06:15] 10Gerrit, 10Proton, 10Core Platform Team Backlog (Attic), 10Readers-Web-Backlog (Tracking), and 2 others: Rename chromium-render gerrit project to Proton - https://phabricator.wikimedia.org/T211375 (10Jdlrobson) [20:06:19] registered [20:06:19] registered [20:06:45] is that really needed? Given it is a single host and a single service? [20:06:45] is that really needed? Given it is a single host and a single service? [20:07:03] yea, because in the future there will be doc1002 or even doc2001 and then we want to rsync again and they they have different UIDs and permissions get messed p [20:07:03] yea, because in the future there will be doc1002 or even doc2001 and then we want to rsync again and they they have different UIDs and permissions get messed p [20:07:11] buster.. [20:07:11] buster.. [20:07:14] anddd [20:07:14] anddd [20:07:22] I guess rsync doesn't do the uid mapping grr [20:07:22] I guess rsync doesn't do the uid mapping grr [20:08:15] yea, i have manually fixed these with "find / -uid .. -exec chown .." and stuff [20:08:15] yea, i have manually fixed these with "find / -uid .. -exec chown .." and stuff [20:08:21] to get the same one [20:08:21] to get the same one [20:09:29] https://wikitech.wikimedia.org/wiki/UID [20:09:29] https://wikitech.wikimedia.org/wiki/UID [20:10:03] for appservers: root > wikidev > mwdeploy > www-data [20:10:03] for appservers: root > wikidev > mwdeploy > www-data [20:11:06] www-data seems not wrong as the owner of the docs in the docroot [20:11:06] www-data seems not wrong as the owner of the docs in the docroot [20:12:56] i am getting picked up for lunch soon, i will be back later [20:12:56] i am getting picked up for lunch soon, i will be back later [20:13:06] leaving that for review for now [20:13:06] leaving that for review for now [20:13:54] ok :))) [20:13:54] ok :))) [20:14:07] maybe it's not so wrong if the jenkins job does it sudo -u www-data ? talk more about it later [20:14:07] maybe it's not so wrong if the jenkins job does it sudo -u www-data ? talk more about it later [20:20:22] hello [20:20:22] hello [20:20:43] volans: looks like everything has been fixed? [20:20:43] volans: looks like everything has been fixed? [20:21:10] legoktm: yup he bumped the default build timeout for tox jobs from 3 to 10 minutes [20:21:10] legoktm: yup he bumped the default build timeout for tox jobs from 3 to 10 minutes [20:24:09] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Refactor integration/pipelinelib to use blubberoid.discovery.wmnet - https://phabricator.wikimedia.org/T212247 (10dduvall) [20:24:09] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Refactor integration/pipelinelib to use blubberoid.discovery.wmnet - https://phabricator.wikimedia.org/T212247 (10dduvall) [20:34:19] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Regression: betalabs email is not working - https://phabricator.wikimedia.org/T212249 (10Etonkovidova) [20:34:19] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Regression: betalabs email is not working - https://phabricator.wikimedia.org/T212249 (10Etonkovidova) [20:43:18] 10Release-Engineering-Team (Kanban), 10Release Pipeline, 10serviceops: Allow access to blubberoid.discovery.wmnet:8748 - https://phabricator.wikimedia.org/T212251 (10dduvall) [20:43:18] 10Release-Engineering-Team (Kanban), 10Release Pipeline, 10serviceops: Allow access to blubberoid.discovery.wmnet:8748 - https://phabricator.wikimedia.org/T212251 (10dduvall) [20:43:49] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Refactor integration/pipelinelib to use blubberoid.discovery.wmnet - https://phabricator.wikimedia.org/T212247 (10dduvall) p:05Triage→03Normal [20:43:49] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Refactor integration/pipelinelib to use blubberoid.discovery.wmnet - https://phabricator.wikimedia.org/T212247 (10dduvall) p:05Triage→03Normal [20:48:17] 10Release-Engineering-Team (Kanban), 10Release Pipeline, 10serviceops: Allow access to blubberoid.discovery.wmnet:8748 - https://phabricator.wikimedia.org/T212251 (10dduvall) [20:48:17] 10Release-Engineering-Team (Kanban), 10Release Pipeline, 10serviceops: Allow access to blubberoid.discovery.wmnet:8748 - https://phabricator.wikimedia.org/T212251 (10dduvall) [20:56:56] legoktm: and thank you for the tox containers rebuild ! [20:56:56] legoktm: and thank you for the tox containers rebuild ! [21:13:21] legoktm: yeah I guess so, rechecking now on my CRs [21:13:21] legoktm: yeah I guess so, rechecking now on my CRs [21:27:57] re-check done, all good (4m50s for the record) [21:27:57] re-check done, all good (4m50s for the record) [22:26:27] (03PS1) 10Hashar: Overhaul publishing [integration/config] - 10https://gerrit.wikimedia.org/r/480657 (https://phabricator.wikimedia.org/T211974) [22:26:27] (03PS1) 10Hashar: Overhaul publishing [integration/config] - 10https://gerrit.wikimedia.org/r/480657 (https://phabricator.wikimedia.org/T211974) [23:44:05] i am following the docs hashar left how to run tests locally and i got the "bundle install" to work but then it's always "Unknown resource type: 'apt::repository' in my case. that's a defined type in module apt and apt is in fixtures.. and for hashar it seems to work.. [23:44:05] i am following the docs hashar left how to run tests locally and i got the "bundle install" to work but then it's always "Unknown resource type: 'apt::repository' in my case. that's a defined type in module apt and apt is in fixtures.. and for hashar it seems to work.. [23:48:51] (03PS1) 10Volans: Edit Project Config [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/480675 [23:48:51] (03PS1) 10Volans: Edit Project Config [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/480675 [23:49:22] (03Abandoned) 10Volans: Edit Project Config [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/480675 (owner: 10Volans) [23:49:22] (03Abandoned) 10Volans: Edit Project Config [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/480675 (owner: 10Volans)