[00:47:09] (03CR) 10Umherirrender: "in core is just one file, there are two files in skins and 181 files in extensions with mediawiki/codesniffer (not wikibase/codesniffer) w" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481530 (https://phabricator.wikimedia.org/T203799) (owner: 10Umherirrender) [00:47:09] (03CR) 10Umherirrender: "in core is just one file, there are two files in skins and 181 files in extensions with mediawiki/codesniffer (not wikibase/codesniffer) w" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481530 (https://phabricator.wikimedia.org/T203799) (owner: 10Umherirrender) [00:48:16] (03CR) 10Umherirrender: "in core is just one file, there are none files in skins and 36 files in extensions with mediawiki/codesniffer (not wikibase/codesniffer) w" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481526 (https://phabricator.wikimedia.org/T212510) (owner: 10Umherirrender) [00:48:16] (03CR) 10Umherirrender: "in core is just one file, there are none files in skins and 36 files in extensions with mediawiki/codesniffer (not wikibase/codesniffer) w" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481526 (https://phabricator.wikimedia.org/T212510) (owner: 10Umherirrender) [09:02:27] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Awesome, thanks a lot for the numbers!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481530 (https://phabricator.wikimedia.org/T203799) (owner: 10Umherirrender) [09:02:27] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Awesome, thanks a lot for the numbers!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481530 (https://phabricator.wikimedia.org/T203799) (owner: 10Umherirrender) [09:04:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Awesome, thanks a lot! To me this sounds like these are all mistakes. So good to go in my opinion." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481526 (https://phabricator.wikimedia.org/T212510) (owner: 10Umherirrender) [09:04:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Awesome, thanks a lot! To me this sounds like these are all mistakes. So good to go in my opinion." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481526 (https://phabricator.wikimedia.org/T212510) (owner: 10Umherirrender) [11:45:09] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to remove space after not operator - https://phabricator.wikimedia.org/T203799 (10Umherirrender) I run phpcs to detect the different cases: | Spacing=1 | Spacing=0 | Extension | 1 | 265 | AbuseFilter | 1 | 34 | Cite | 1 | 250 | Echo | 1 | 6 | GPGMail | 1... [11:45:09] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to remove space after not operator - https://phabricator.wikimedia.org/T203799 (10Umherirrender) I run phpcs to detect the different cases: | Spacing=1 | Spacing=0 | Extension | 1 | 265 | AbuseFilter | 1 | 34 | Cite | 1 | 250 | Echo | 1 | 6 | GPGMail | 1... [11:45:20] (03CR) 10Umherirrender: "I have added stats on the task" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481530 (https://phabricator.wikimedia.org/T203799) (owner: 10Umherirrender) [11:45:20] (03CR) 10Umherirrender: "I have added stats on the task" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481530 (https://phabricator.wikimedia.org/T203799) (owner: 10Umherirrender) [18:34:05] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to remove space after not operator - https://phabricator.wikimedia.org/T203799 (10thiemowmde) Uh, awesome. It looks like the #mediawiki-extensions-arrays might be the only codebase that intentionally uses spaces after `!` operators. All others – even if so... [18:34:05] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to remove space after not operator - https://phabricator.wikimedia.org/T203799 (10thiemowmde) Uh, awesome. It looks like the #mediawiki-extensions-arrays might be the only codebase that intentionally uses spaces after `!` operators. All others – even if so...