[00:42:45] (03PS1) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [00:43:26] (03PS2) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (https://phabricator.wikimedia.org/T203239) [00:44:12] (03CR) 10Krinkle: Create node10 image (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (https://phabricator.wikimedia.org/T203239) (owner: 10Krinkle) [00:47:30] legoktm: Do you know if the 'control' file is needed or what it does? It looks like a file for a debian package, but afaik node images are not debian packages.. [00:47:44] s/docker/node/ [01:46:24] (03PS3) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [01:48:12] (03CR) 10jerkins-bot: [V: 04-1] Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (owner: 10Krinkle) [01:48:40] (03PS4) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [01:49:46] (03PS5) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [01:50:58] (03PS11) 10Krinkle: Forbid usage of is_null() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/446271 (https://phabricator.wikimedia.org/T199768) (owner: 10Prtksxna) [01:51:34] (03CR) 10jerkins-bot: [V: 04-1] Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (owner: 10Krinkle) [01:52:26] (03PS6) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [02:57:58] 10Phabricator, 10Release-Engineering-Team, 10Operations: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Paladox) [02:58:28] 10Phabricator, 10Release-Engineering-Team, 10Operations: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Paladox) [03:23:35] Krinkle: it is used for dependency resolution. it's based off of the debian format and is used by docker-pkg [03:24:25] legoktm: interesting, what does it do with the parent ones mentioned in 'control' - I thought this was already done in the Dockerfile itself with 'FROM'. [03:25:09] legoktm: I've installed docker-pkg now, and did a full run of building all the images which took about 55 minutes. [03:25:27] you have a fast laptop then :p [03:25:37] I would have just pulled down the missing image instead of building everything from scratch [03:25:49] .. the docs didn't say that was possible [03:26:04] https://www.mediawiki.org/wiki/Continuous_integration/Docker/Dockerfiles [03:26:06] https://phabricator.wikimedia.org/T200720 [03:27:12] Oh, it's building past versions as well? [03:27:25] no, just the latest [03:27:33] but for all the packages you didn't change you could have just pulled them [03:27:39] Right [03:28:01] And I gather I should still do that so as to make sure my derived version is actually derived from the one in the registry. [03:28:27] most likely the version you built locally will not be identical to the one in the registry [03:28:47] because of all the things that can change outside of the docker images (apt repos updating packages mostly) [03:29:54] yeah [03:30:43] so I'll have to clear the docker repo locally somehow and then re-fetch [03:31:15] to be clear though, is this like jjb in that I'd push my local, or will it rebuild remotely - meaning the local fetching only helps to make sure my local testing of the image is correct. [03:32:05] it will rebuild remotely [03:32:18] the images are all built on contint1001 when you run the fab task to deploy [03:33:41] (03PS1) 10Legoktm: Merge v6.5.0 [integration/npm] - 10https://gerrit.wikimedia.org/r/482398 [03:33:43] (03PS1) 10Legoktm: Build v6.5.0 [integration/npm] - 10https://gerrit.wikimedia.org/r/482399 [03:33:56] (03CR) 10Legoktm: [V: 03+2 C: 03+2] Merge v6.5.0 [integration/npm] - 10https://gerrit.wikimedia.org/r/482398 (owner: 10Legoktm) [03:34:06] (03CR) 10Legoktm: [V: 03+2 C: 03+2] Build v6.5.0 [integration/npm] - 10https://gerrit.wikimedia.org/r/482399 (owner: 10Legoktm) [03:35:51] legoktm: right, ok. [03:44:12] https://www.mediawiki.org/wiki/Continuous_integration/Docker#Manage_local_images [03:45:48] :D [03:46:51] legoktm: Would appreciate CR on https://gerrit.wikimedia.org/r/#/c/integration/config/+/482392/ [03:47:01] * legoktm looks [03:47:46] * Krinkle licenses legoktm to not assume good faith :) - I don't know what I'm doing. [03:56:22] Krinkle: did you test the images? [03:56:44] That was going to be my next step. I just cleared my whole cache from last hour and pulled down stuff from wm.o [03:56:49] which is now ready, so I'll re-build. [03:56:57] ok [03:57:07] I'm 93% confident it won't work :) [03:57:12] I did build an earlier version of my patch last hour, but I'm not sure what an error looks like or if I'd recognise it [03:57:19] one moment, finishing my last comment [03:57:26] I copied the apt command from Antoine's IRC message, the rest is copy/pasta [03:57:31] oh wait [03:57:34] I didn't finish reading [04:04:02] (03CR) 10Legoktm: [C: 04-1] Create node10 image (036 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (owner: 10Krinkle) [04:05:18] Krinkle: overall lgtm :) [04:05:32] (03CR) 10Legoktm: [C: 04-1] "One concern I have is that we now have 3 forks of the node images, npm, npm6, and node10. I haven't had time to finish the npm6 transition" [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (owner: 10Krinkle) [04:06:32] (03CR) 10Krinkle: Create node10 image (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (owner: 10Krinkle) [04:08:31] legoktm: nodejs-legacy adds node == nodejs, without it the command is called 'nodejs', which causes issues given that most scripts would look for the 'node' command. [04:09:02] but might be that our node10 package does that already [04:09:41] * legoktm looks [04:11:39] (03PS7) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [04:13:02] our nodejs 10 image has Conflicts: nodejs-legacy [04:13:29] https://paste.fedoraproject.org/paste/SpWLWGudL-9qVfsT48s63A/raw [04:16:05] https://paste.fedoraproject.org/paste/jgUmYCfa6GaeJfGco9Br0Q/raw [04:17:16] Krinkle: you'll have to remove nodejs-legacy afaict [04:17:59] cool [04:18:07] (03PS8) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [04:22:53] * legoktm afk -> dinner [04:27:12] (03CR) 10Krinkle: "I think rolling it into this transition makes sense." [integration/config] - 10https://gerrit.wikimedia.org/r/482392 (owner: 10Krinkle) [04:27:32] legoktm: main point remaining is about -browser/-xvfb. [04:28:16] With the transition being fast-forwarded, it might be harder to leave xvfb out, but I'm hopeful. So I could do -browser as you proposed, but without xvfb and without an xvfb variant. [04:52:25] (03PS9) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [05:32:14] Krinkle: do we have a list of things that are still dependent upon xvfb? [05:32:30] I don't know, pretty much anything gets is by default, so it's hard to tell. [05:32:40] hmm [05:33:05] afaik the only thing that might need it is a job that uses firefox, which got headless only recently, and we haven't adopted that anywhere yet. [05:33:17] but our most of our ci also doesn't test in firefox yet [05:33:32] chrome is headless everywhere we use it afaik, and the odd job still using phantomjs wouldn't need xvfb anyway [05:34:24] tried a few times to enable firefox by default, but due to insignificant differences some false negatives happened in mw qunit and ve and oojs ui. [05:42:50] (03PS10) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [07:09:05] the stretch firefox is 60 now, and that supports headless [15:02:43] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10Patch-For-Review: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Paladox) they now include "void-recipient@" in the email https://github.com/phacility/phabricator/blob/73e3057c52f46ec6d... [16:39:33] (03PS5) 10Daimona Eaytoy: Add dependencies for AbuseFilter [integration/config] - 10https://gerrit.wikimedia.org/r/481570 [16:39:53] (03PS3) 10Daimona Eaytoy: Add AbuseFilter as dependency of SpamBlacklist [integration/config] - 10https://gerrit.wikimedia.org/r/481571 [20:27:55] legoktm: https://codesearch.wmflabs.org/search/?q=firefox&i=nope&files=(Gruntfile%7Cpackage)%5C.(js%7Cjson)&repos= [20:28:12] core, ve, ooui are the only repos that offer Firefox testing, but currently only used for local dev, not in CI. [20:28:40] We should look into fixing that, especially given Karma supports concurrency out of the box [20:28:46] so it shuoldn't slow down the build significantly [21:09:23] (03PS11) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [21:11:59] (03PS12) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392 [21:29:21] (03PS13) 10Krinkle: Create node10 image [integration/config] - 10https://gerrit.wikimedia.org/r/482392