[00:05:43] 10Beta-Cluster-Infrastructure, 10Wikimedia-Logstash: Beta Cluster ("deployment-prep") logstash has gone silent since 2019-01-02Z01:14:14 - https://phabricator.wikimedia.org/T213129 (10Jdforrester-WMF) [00:29:29] twentyafterfour: should I land that patch of mine you approved for the closerPHID migration? [00:40:07] 10Gerrit, 10Release-Engineering-Team, 10GitHub-Mirrors, 10Scoring-platform-team: articlequality repo mirroring is broken - https://phabricator.wikimedia.org/T212962 (10awight) 05Open→03Resolved a:03awight I was able to work around by pushing directly to gerrit. If it happens again, I'll reuse this t... [02:08:49] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10Tgr) >>! In T37497#4860677, @Paladox wrote: > We can install https://gerrit-review.googlesource.com/admin/repos/plugins/github (which is what ge... [02:34:20] (03PS1) 10Krinkle: Add Fresnel postmerge job for publishing coverage report [integration/config] - 10https://gerrit.wikimedia.org/r/482751 (https://phabricator.wikimedia.org/T133646) [02:35:44] (03PS2) 10Krinkle: Create Node 10 coverage-publish job and use for Fresnel [integration/config] - 10https://gerrit.wikimedia.org/r/482751 (https://phabricator.wikimedia.org/T133646) [02:36:54] (03CR) 10Krinkle: [C: 03+2] "Compiled and uploaded 'generic-node10-browser-coverage-docker-publish'" [integration/config] - 10https://gerrit.wikimedia.org/r/482751 (https://phabricator.wikimedia.org/T133646) (owner: 10Krinkle) [02:39:28] (03Merged) 10jenkins-bot: Create Node 10 coverage-publish job and use for Fresnel [integration/config] - 10https://gerrit.wikimedia.org/r/482751 (https://phabricator.wikimedia.org/T133646) (owner: 10Krinkle) [02:45:47] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/482751 [02:45:48] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:46:42] legoktm: once this one is known to work, and my initial fresnel commit lands, I'll start removing old jobs. [02:47:00] Also trying out the generic approach for more of the node coverage jobs, not sure why we haven't previously. [02:47:21] Seems the only differing factor is 'dest:' which, if the dynamic mapping doesn't work, we can fix, it's a python function. [02:47:37] ZUUL_PROJECT '/' => '-' currenetly [02:57:05] (03PS1) 10Krinkle: zuul: Add custom DOC_PROJECT destination for fresnel [integration/config] - 10https://gerrit.wikimedia.org/r/482752 (https://phabricator.wikimedia.org/T133646) [02:58:54] (03CR) 10jerkins-bot: [V: 04-1] zuul: Add custom DOC_PROJECT destination for fresnel [integration/config] - 10https://gerrit.wikimedia.org/r/482752 (https://phabricator.wikimedia.org/T133646) (owner: 10Krinkle) [03:00:20] (03PS2) 10Krinkle: zuul: Add custom DOC_PROJECT destination for fresnel [integration/config] - 10https://gerrit.wikimedia.org/r/482752 (https://phabricator.wikimedia.org/T133646) [03:55:35] (03CR) 10Krinkle: [C: 03+2] zuul: Add custom DOC_PROJECT destination for fresnel [integration/config] - 10https://gerrit.wikimedia.org/r/482752 (https://phabricator.wikimedia.org/T133646) (owner: 10Krinkle) [03:57:22] (03Merged) 10jenkins-bot: zuul: Add custom DOC_PROJECT destination for fresnel [integration/config] - 10https://gerrit.wikimedia.org/r/482752 (https://phabricator.wikimedia.org/T133646) (owner: 10Krinkle) [04:00:38] (03PS1) 10Krinkle: Add Jenkins jobs for jsdoc/wmf-theme (npm-test; Node 10) [integration/config] - 10https://gerrit.wikimedia.org/r/482755 (https://phabricator.wikimedia.org/T187672) [04:03:14] (03CR) 10jerkins-bot: [V: 04-1] Add Jenkins jobs for jsdoc/wmf-theme (npm-test; Node 10) [integration/config] - 10https://gerrit.wikimedia.org/r/482755 (https://phabricator.wikimedia.org/T187672) (owner: 10Krinkle) [04:06:39] (03PS2) 10Krinkle: Add Jenkins jobs for jsdoc/wmf-theme (npm-test; Node 10) [integration/config] - 10https://gerrit.wikimedia.org/r/482755 (https://phabricator.wikimedia.org/T187672) [04:13:22] (03CR) 10VolkerE: [C: 03+1] Add Jenkins jobs for jsdoc/wmf-theme (npm-test; Node 10) [integration/config] - 10https://gerrit.wikimedia.org/r/482755 (https://phabricator.wikimedia.org/T187672) (owner: 10Krinkle) [04:49:07] 10Gerrit, 10Operations, 10Traffic, 10Patch-For-Review: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183 (10Krinkle) >>! In T191183#4656943, @Tgr wrote: > [Phabricator] Conduit is [..] not very fast, so the Gerrit plugin would still have to store images somewhere. Yeah, anything that qu... [05:15:00] legoktm: I see that extension-quibble uses npm6 already which is cool, curious how you did the switch. Temporarily a separate template to gradually enable and then remove; or add to experimental try all and flip at once? I'll try to follow the same in that case. [05:16:14] (03PS1) 10Krinkle: [WIP] Add node10-docker job variants for mwgate [integration/config] - 10https://gerrit.wikimedia.org/r/482764 [05:28:26] 10Gerrit, 10Operations, 10Traffic, 10Patch-For-Review: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183 (10demon) I'm increasingly convinced that avatars aren't worth the effort. [05:29:50] (03PS1) 10Krinkle: Add coverage-publish job for Example extension [integration/config] - 10https://gerrit.wikimedia.org/r/482765 [05:33:32] (03PS2) 10Krinkle: Add coverage-publish job for Example extension [integration/config] - 10https://gerrit.wikimedia.org/r/482765 [05:33:40] (03CR) 10Krinkle: [C: 03+2] Add coverage-publish job for Example extension [integration/config] - 10https://gerrit.wikimedia.org/r/482765 (owner: 10Krinkle) [05:35:30] (03Merged) 10jenkins-bot: Add coverage-publish job for Example extension [integration/config] - 10https://gerrit.wikimedia.org/r/482765 (owner: 10Krinkle) [05:37:17] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/482752 [05:37:18] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:11:08] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: mediawiki-phpunit-coverage-patch-docker missing HTML report artifact - https://phabricator.wikimedia.org/T205235 (10MGChecker) Thank you very much! [06:58:33] 10Gerrit, 10Operations, 10Traffic, 10Patch-For-Review: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183 (10Tgr) Well the effort was inflated by dubious privacy requirements :) I still think the best course of action would be gravatar with a proxy. [07:11:42] (03PS1) 10Santhosh: Add MobileFrontend dependency for ExternalGuidance [integration/config] - 10https://gerrit.wikimedia.org/r/482766 [07:13:22] (03CR) 10Santhosh: "To fix errors like this: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/29889/console" [integration/config] - 10https://gerrit.wikimedia.org/r/482766 (owner: 10Santhosh) [09:14:58] (03PS1) 10Hashar: Edit Project Config [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/482769 [09:15:06] oops [09:18:07] Hmm, how did you manage to delete it? [09:19:48] !log gerrit: resaved configuration for All-Projects by changing "Max Reviewers" from 3 to 4. Might enable adding reviewers automatically based on git blame. See task for config diff # T 101131 [09:19:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:19:54] paladox: good morning [09:20:03] paladox: maybe because I have admin rights on gerrit? [09:20:16] Hi [09:20:28] hashar: I thought we disabled that? [09:20:52] Due to a accidental deletion in the puppet repo [09:30:34] 10Gerrit, 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10hashar) Indeed it is definitely not adding reviewers. That puzzled me during the xmas break and eventually had an idea this morning. Based on my previous comment a... [09:31:26] paladox: well I have some elevated privileges probably [09:37:35] Yup [09:38:34] 10Gerrit, 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10hashar) Eventually I have found https://groups.google.com/d/msg/repo-discuss/-5kMTN34aqw/zgTAEgReDgAJ //reviewers-by-blame on stable-2.15 busted with NoteDb//. It... [09:49:19] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [extensions/FilterSpecialPages] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/482773 [09:49:21] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [extensions/FilterSpecialPages] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/482773 (owner: 10QChris) [09:49:46] (03PS1) 10QChris: Import done. Revoke import grants [extensions/FilterSpecialPages] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/482774 [09:49:48] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [extensions/FilterSpecialPages] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/482774 (owner: 10QChris) [09:59:56] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10hashar) a:03hashar [10:25:04] paladox: in case you have looked at the git reviewers by blame plugin, it is broken on our setup and need an updat e:) [10:25:14] but eventually, we will get reviewers automagically added! \o/ [10:39:37] 10Scap, 10Operations, 10serviceops, 10Goal: SRE FY2019 Q3:TEC6: First steps towards Canary Deployments - https://phabricator.wikimedia.org/T213156 (10jijiki) p:05Triage→03Normal [10:39:52] 10Scap, 10Operations, 10serviceops, 10Goal, 10User-jijiki: SRE FY2019 Q3:TEC6: First steps towards Canary Deployments - https://phabricator.wikimedia.org/T213156 (10jijiki) [11:06:50] (03Abandoned) 10Hashar: Only do one run of MediaWiki core PHPUnit [integration/quibble] - 10https://gerrit.wikimedia.org/r/426742 (owner: 10Legoktm) [11:42:20] 10Continuous-Integration-Config, 10ExternalGuidance: Add MobileFrontend dependency for ExternalGuidance - https://phabricator.wikimedia.org/T213166 (10santhosh) [11:42:44] 10Continuous-Integration-Config, 10ExternalGuidance: Add MobileFrontend dependency for ExternalGuidance - https://phabricator.wikimedia.org/T213166 (10santhosh) p:05Triage→03Normal [11:42:52] (03PS2) 10Santhosh: Add MobileFrontend dependency for ExternalGuidance [integration/config] - 10https://gerrit.wikimedia.org/r/482766 (https://phabricator.wikimedia.org/T213166) [12:06:28] 10Beta-Cluster-Infrastructure, 10Wikimedia-Logstash: Beta Cluster ("deployment-prep") logstash has gone silent since 2019-01-02Z01:14:14 - https://phabricator.wikimedia.org/T213129 (10fgiunchedi) [12:06:30] 10Beta-Cluster-Infrastructure, 10Wikimedia-Logstash: Logstash in beta fails periodically - https://phabricator.wikimedia.org/T211984 (10fgiunchedi) [12:11:21] 10Beta-Cluster-Infrastructure, 10Wikimedia-Logstash: Beta Cluster ("deployment-prep") logstash has gone silent since 2019-01-02Z01:14:14 - https://phabricator.wikimedia.org/T213129 (10fgiunchedi) AFAICT not immediately related to pipeline changes, though see also T211984. I've restarted logstash on `deployment... [13:09:30] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10SRE-Access-Requests: Grant sudo access for CI admins to doc.wikimedia.org publishing user - https://phabricator.wikimedia.org/T213169 (10hashar) p:05Triage→03Normal [14:06:17] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10Ottomata) > the "Pull-request to Change" This is the part that I care about too. I don't need two way sync (even though that is indeed cool).... [14:17:05] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10hashar) For uploading patches one can use https://www.mediawiki.org/wiki/Gerrit_patch_uploader . Interface: https://tools.wmflabs.org/gerrit-pat... [14:18:29] hashar ah, ok :) [14:25:00] !log Upgrading plugins on https://releases-jenkins.wikimedia.org/ [14:25:01] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:27:30] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10Paladox) We could do https://github.com/golang/go/wiki/GerritBot https://github.com/golang/build/tree/master/cmd/gerritbot [14:51:04] 10Continuous-Integration-Infrastructure, 10Operations, 10SRE-Access-Requests, 10Patch-For-Review, 10Performance-Team (Radar): Add krinkle to contint-docker group - https://phabricator.wikimedia.org/T213015 (10hashar) The group comes from T182860 and https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/... [15:17:06] 10Release-Engineering-Team (Watching / External), 10DBA, 10SDC Engineering, 10SDC General, and 2 others: Create a production test wiki in group0 to parallel Wikimedia Commons - https://phabricator.wikimedia.org/T197616 (10Marostegui) The database is still present at the s4 servers, and I would like to clea... [15:17:23] 10Release-Engineering-Team (Watching / External), 10DBA, 10SDC Engineering, 10SDC General, and 2 others: Create a production test wiki in group0 to parallel Wikimedia Commons - https://phabricator.wikimedia.org/T197616 (10Marostegui) 05Resolved→03Open [15:17:33] Yippee, build fixed! [15:17:34] Project beta-scap-eqiad build #233610: 09FIXED in 12 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/233610/ [15:19:52] 10Release-Engineering-Team (Watching / External), 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), 10Services (watching): Revisit the logging work done on Q1 2017-2018 for the standard pod setup - https://phabricator.wikimedia.org/T207200 (10fgiunchedi) >>! In T207200... [15:25:01] 10Release-Engineering-Team (Watching / External), 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), 10Services (watching): Revisit the logging work done on Q1 2017-2018 for the standard pod setup - https://phabricator.wikimedia.org/T207200 (10fselles) @fgiunchedi i do... [15:28:11] (03PS1) 10MarkAHershberger: Require mbstring since it is needed for FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/482821 [15:40:00] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10Paladox) It seems all of google tools ie https://github.com/LetsUseGerrit/gerritbot and https://github.com/golang/build/tree/master/cmd/gerritbo... [15:51:06] 10Release-Engineering-Team (Watching / External), 10DBA, 10SDC Engineering, 10SDC General, and 2 others: Create a production test wiki in group0 to parallel Wikimedia Commons - https://phabricator.wikimedia.org/T197616 (10jcrespo) By the way, are people aware that a shard called "test-s4" has 2 dedicated l... [16:09:34] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10hashar) From @thcipriani to rebuild the plugin one would do something like: bazel build plugins/reviewers-by-blame wmf/stab... [16:20:17] 10Release-Engineering-Team (Kanban), 10Outreachy (Round 17), 10Patch-For-Review, 10User-zeljkofilipin: Outreachy microtask: Writing Echo node.js tests (#2) - https://phabricator.wikimedia.org/T204775 (10zeljkofilipin) a:05zeljkofilipin→03None [16:29:50] 10Beta-Cluster-Infrastructure, 10Wikimedia-Logstash: Beta Cluster ("deployment-prep") logstash has gone silent since 2019-01-02Z01:14:14 - https://phabricator.wikimedia.org/T213129 (10Jdforrester-WMF) Ah, right, thanks! [16:37:04] hello, is there any Phabricator around? [16:44:57] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10User-zeljkofilipin: 5 of the 15 prioritized repositories have at least 1 end-to-end test - https://phabricator.wikimedia.org/T206621 (10zeljkofilipin) [17:02:43] meh, what did I even wrote [17:02:53] hello, is there any Phabricator admin around? [17:03:37] leszek_wmde: What've you broken? [17:03:49] nothing yet :) [17:03:56] Keep it that way [17:03:58] * Reedy blocks leszek_wmde [17:04:35] Wassup? [17:04:52] so issue being: new WMDE staff member have created a mediawiki account and phabricator account linked to it [17:05:04] sadly, they initially entered their email address wrong [17:05:11] on mw.org the email could be change [17:05:12] d [17:05:35] but the pharbicator account cannot be used, as pharbicator confirmation email went to /dev/null [17:05:46] is there a way to have the email address changed? [17:07:02] I think it might need someone with database access [17:07:23] If I visit https://phabricator.wikimedia.org/settings/user/Addshore/page/email/ for example [17:07:27] You do not have permission to edit this object. [17:07:27] Users with the "Can Edit" capability: [17:07:27] By default, no one can take this action. [17:07:27] Only you can edit your information. [17:07:31] O_o [17:07:37] o/ [17:07:43] addshore: please fix [17:07:48] Reedy: aren;t you root yet>? [17:07:54] addshore: hah [17:08:02] leszek_wmde: I'd suggest filing a task on their behalf :) [17:08:06] i think it needs one of the phab admins or roots ;) [17:08:24] I'm a phab admin! [17:08:27] no [17:08:32] the phab admin ladap group [17:08:36] not the ui type of phab admin [17:08:38] you dont count ;) [17:08:40] phab admin != phab admin [17:08:44] indeed [17:09:22] Reedy: thanks, will do [17:17:21] someone called for a phab admin? [17:17:30] twentyafterfour: I did! [17:17:41] I almost submitted a phab task where I ping you [17:18:00] twentyafterfour: are you in power to change an email address of the phab account? [17:18:19] can you send me the email address in a private chat or email to mmodell@ [17:18:33] twentyafterfour: much thanks, will do [17:19:01] I need both the addresses, the incorrect and the correct one [17:24:35] 10Release-Engineering-Team, 10Release Pipeline, 10serviceops, 10Core Platform Team Backlog (Watching / External), 10Services (watching): TEC3:O3:O3.1:Q3 Goal - Move cxserver, citoid, changeprop, eventgate (new service) and ORES (partially) through the production ... - https://phabricator.wikimedia.org/T212801 [17:24:44] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), and 2 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10thcipriani) [17:24:47] 10Release-Engineering-Team, 10Operations, 10Prod-Kubernetes, 10Release Pipeline, 10Documentation: TEC3:O6:O:6.1:Q3: Deployment Pipeline Documentation - https://phabricator.wikimedia.org/T213090 (10thcipriani) [17:33:06] 10Release-Engineering-Team, 10ChangeProp, 10Release Pipeline, 10Services, 10serviceops: Migrate changeprop to kubernetes - https://phabricator.wikimedia.org/T213193 (10thcipriani) [17:33:11] 10Release-Engineering-Team, 10Citoid, 10Release Pipeline, 10Services, 10serviceops: Migrate citoid to kubernetes - https://phabricator.wikimedia.org/T213194 (10thcipriani) [17:33:15] 10Release-Engineering-Team, 10CX-cxserver, 10Release Pipeline, 10Services, 10serviceops: Migrate cxserver to kubernetes - https://phabricator.wikimedia.org/T213195 (10thcipriani) [17:33:27] 10Release-Engineering-Team, 10Release Pipeline, 10serviceops, 10Core Platform Team Backlog (Watching / External), 10Services (watching): TEC3:O3:O3.1:Q3 Goal - Move cxserver, citoid, changeprop, eventgate (new service) and ORES (partially) through the production ... - https://phabricator.wikimedia.org/T212801 [17:33:31] 10Release-Engineering-Team, 10CX-cxserver, 10Release Pipeline, 10Services, 10serviceops: Migrate cxserver to kubernetes - https://phabricator.wikimedia.org/T213195 (10thcipriani) [17:33:38] 10Release-Engineering-Team, 10Release Pipeline, 10serviceops, 10Core Platform Team Backlog (Watching / External), 10Services (watching): TEC3:O3:O3.1:Q3 Goal - Move cxserver, citoid, changeprop, eventgate (new service) and ORES (partially) through the production ... - https://phabricator.wikimedia.org/T212801 [17:33:43] 10Release-Engineering-Team, 10Citoid, 10Release Pipeline, 10Services, 10serviceops: Migrate citoid to kubernetes - https://phabricator.wikimedia.org/T213194 (10thcipriani) [17:34:21] 10Release-Engineering-Team, 10Release Pipeline, 10serviceops, 10Core Platform Team Backlog (Watching / External), 10Services (watching): TEC3:O3:O3.1:Q3 Goal - Move cxserver, citoid, changeprop, eventgate (new service) and ORES (partially) through the production ... - https://phabricator.wikimedia.org/T212801 [17:34:25] 10Release-Engineering-Team, 10ChangeProp, 10Release Pipeline, 10Services, 10serviceops: Migrate changeprop to kubernetes - https://phabricator.wikimedia.org/T213193 (10thcipriani) [17:35:36] 10Release-Engineering-Team, 10Operations: Add IRC SRE bot for SAL !log actions to #wikimedia-serviceops - https://phabricator.wikimedia.org/T213196 (10Jdforrester-WMF) [17:36:10] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Manually defining artifacts results in default copy of all project files - https://phabricator.wikimedia.org/T211625 (10thcipriani) [17:38:03] 10Release-Engineering-Team (Backlog), 10ORES, 10Operations, 10Scoring-platform-team, 10Release Pipeline (Blubber): The continuous release pipeline should support more than one service per repo - https://phabricator.wikimedia.org/T210267 (10thcipriani) [17:39:21] (03PS1) 10Ottomata: Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) [17:40:50] (03CR) 10jerkins-bot: [V: 04-1] Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) (owner: 10Ottomata) [17:41:49] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Manually defining artifacts results in default copy of all project files - https://phabricator.wikimedia.org/T211625 (10thcipriani) a:03dduvall [17:49:13] 10Release-Engineering-Team, 10Operations, 10Prod-Kubernetes, 10Release Pipeline, 10Documentation: Document helm chart creation - https://phabricator.wikimedia.org/T213197 (10thcipriani) p:05Triage→03Normal [17:50:13] 10Release-Engineering-Team, 10Operations, 10Prod-Kubernetes, 10Documentation, 10Release Pipeline (Blubber): Update Blubber documentation - https://phabricator.wikimedia.org/T213198 (10thcipriani) p:05Triage→03Normal [18:35:51] (03PS2) 10Ottomata: Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) [18:37:41] (03CR) 10jerkins-bot: [V: 04-1] Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) (owner: 10Ottomata) [18:39:25] (03PS3) 10Ottomata: Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) [18:41:02] (03CR) 10jerkins-bot: [V: 04-1] Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) (owner: 10Ottomata) [18:41:52] (03PS4) 10Ottomata: Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) [19:00:55] (03CR) 10Lars Wirzenius: [C: 03+2] Provide a new Blubber logo [blubber] - 10https://gerrit.wikimedia.org/r/479846 (owner: 10Dduvall) [19:01:44] (03Merged) 10jenkins-bot: Provide a new Blubber logo [blubber] - 10https://gerrit.wikimedia.org/r/479846 (owner: 10Dduvall) [19:04:35] (03CR) 10jenkins-bot: Provide a new Blubber logo [blubber] - 10https://gerrit.wikimedia.org/r/479846 (owner: 10Dduvall) [19:12:50] Krinkle: IIRC I tested 10-15 repos with the docker image locally and then flipped it, and kept an eye on the fallout [19:36:08] legoktm: okay :) [19:53:57] !log deployment-prep adjusting puppet config on deployment-mwmaint01. remove "mediawiki_maintenance" role from "other classes" section and apply "mediawiki::maintenance" instead after role rename in gerrit:479131 for consistency with other mediawiki:: roles [19:53:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:54:45] (03CR) 10Krinkle: "Blocked on https://phabricator.wikimedia.org/T187672#4861517" [integration/config] - 10https://gerrit.wikimedia.org/r/482755 (https://phabricator.wikimedia.org/T187672) (owner: 10Krinkle) [19:58:56] o/ anybody around for a review of https://gerrit.wikimedia.org/r/#/c/integration/config/+/482855/ ? [20:41:47] (03CR) 10Thcipriani: [C: 03+2] Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) (owner: 10Ottomata) [20:43:37] (03Merged) 10jenkins-bot: Add eventgate-ci for deployment pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/482855 (https://phabricator.wikimedia.org/T211247) (owner: 10Ottomata) [20:46:33] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/#/c/integration/config/+/482855/ [20:46:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:06:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10SRE-Access-Requests, 10Patch-For-Review: Grant sudo access for CI admins to doc.wikimedia.org publishing user - https://phabricator.wikimedia.org/T213169 (10Dzahn) Thanks for excellent justification for https://... [21:14:22] hey how do i get admin rights on github for repos that I manage - specifically Minerva, MobileFrontend and Popups ? [21:14:51] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend doesn't list me as an admin for some reason [21:15:11] I guess it's for the request to install an app I've just received jdlrobson ? [21:15:37] Hauskatze: that's one thing yup. I'm keen to experiment with travis-ci, netlify and the github wiki functionality on this repos [21:15:58] I just need Popups for the time being,but was surprised that I wasn't an admin already [21:16:53] I guess they can make you a member of a github group and make said group administer a set of repos [21:17:17] I'd rather let others take a look given that I have access for janitorial-like tasks (create and delete repos) [21:20:59] i also setup a github team > https://github.com/orgs/wikimedia/teams/readers-web/members?utf8=%E2%9C%93&query= but i can't seem to be able to add our repos [21:21:43] * Hauskatze takes a look [21:25:30] jdlrobson: so you want me to add which repo to readers-web? [21:29:46] I see this is handled already [21:29:59] Hauskatze: yup looks like i actually have admin rights [21:30:09] thank you for caring :) [21:30:34] !log github: [21:30:34] niedzielski updated jdlrobson permission on Wikimedia from read to admin [21:30:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:30:44] ... [21:30:45] sigh [21:31:28] retry [21:31:30] !log github: @niedzielski updated @jdlrobson permission on Wikimedia from `read` to `admin` [21:31:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:36:18] (03PS4) 10Thcipriani: service-pipeline: add commit SHA tag to images [integration/config] - 10https://gerrit.wikimedia.org/r/476593 (https://phabricator.wikimedia.org/T209088) [21:36:20] (03PS5) 10Thcipriani: service-pipeline: add image tag on git tag push [integration/config] - 10https://gerrit.wikimedia.org/r/476600 (https://phabricator.wikimedia.org/T209088) [21:36:57] (03CR) 10Thcipriani: "> The only case we have guarantee that ZUUL_COMMIT match is in the" [integration/config] - 10https://gerrit.wikimedia.org/r/476593 (https://phabricator.wikimedia.org/T209088) (owner: 10Thcipriani) [21:37:27] (03CR) 10Thcipriani: service-pipeline: add image tag on git tag push (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/476600 (https://phabricator.wikimedia.org/T209088) (owner: 10Thcipriani) [21:39:01] thcipriani: is there any good reason i shouldn't give netlify.com permission to access a wikimedia repo? I'm interested in having a static documentation site deployed from code on every commit and it's read only (a bit like travis-ci). It's experimental so I'd rather avoid working out how to integrate this with jenkins right now [21:40:42] what permission does it need if it's read-only? [21:41:23] I don't know what the usual process is for this kind of thing/if there is one :) [21:42:41] ^ greg-g ? [21:42:57] i think it's sent an email to the wikimedia organisation so hopefulyl that has details about what it needs [21:43:36] looks like it just requests the following: [21:43:39] https://www.irccloud.com/pastebin/jha82BYz/ [21:44:03] not sure why it needs write access for the latter [21:44:46] (03CR) 10Thcipriani: [C: 03+2] "deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/476593 (https://phabricator.wikimedia.org/T209088) (owner: 10Thcipriani) [21:44:47] (and if that differs from what travis needs) [21:45:19] (03CR) 10Thcipriani: [C: 03+2] "job deployed. zuul/layout change tbd (to be deployed)." [integration/config] - 10https://gerrit.wikimedia.org/r/476600 (https://phabricator.wikimedia.org/T209088) (owner: 10Thcipriani) [21:45:23] and for context > https://zen-pasteur-e92b1e.netlify.com/ is the output [21:46:04] is netlify a proprietary service? [21:46:29] and what's their privacy policy? [21:46:42] jenkins is already set up to deploy static documentation sites, it should be trivial to add new ones as a post-merge job [21:47:30] (03Merged) 10jenkins-bot: service-pipeline: add commit SHA tag to images [integration/config] - 10https://gerrit.wikimedia.org/r/476593 (https://phabricator.wikimedia.org/T209088) (owner: 10Thcipriani) [21:47:59] (03Merged) 10jenkins-bot: service-pipeline: add image tag on git tag push [integration/config] - 10https://gerrit.wikimedia.org/r/476600 (https://phabricator.wikimedia.org/T209088) (owner: 10Thcipriani) [21:48:30] the last permission it's requesting is a little sketchy: wonder why it wants read/write? [21:48:39] output doesn't work without js [21:48:44] * thcipriani crumudgens :P [21:49:16] legoktm: the problem with jenkins is it's running node 6 and we need node 11 [21:49:47] jdlrobson: we have node 10 in the pipeline, Krinkle worked on crafting the containers for it last week :) [21:49:47] jenkins has node10 now [21:50:41] for netlify.com, releng/ci folks can not claim responsability for github and all the third party services that are integrated with it [21:50:55] the github situation is already a maintenance burden :/ [21:50:55] so why is travis ci allowed? [21:50:59] (im just curious) [21:51:06] they seem like very similar services [21:51:10] well gerrit repositories are replicated to github [21:51:13] folks add travis [21:51:16] which is fine [21:51:21] but not supported by releng [21:51:27] or ci admins [21:51:28] so why can't folks add netlify in the same way without support from releng [21:51:39] somebody must have approved the travis-ci app on wikimedia? [21:51:41] well you can do I guess, there is nothing preventing you from doing it [21:52:03] but it is probably fairly trivial to add the CI config to have your material published ot doc.wikimedia.org [21:52:15] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/#/c/integration/config/+/476600/ [21:52:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:52:19] it's definitely trivial once we have node 11 :) [21:52:31] im just trying to find an interim solution [21:52:32] well [21:52:38] wikimedia is on nodejs 6 [21:52:45] and we are migrating to nodejs 10 as I got it [21:52:58] do you know when that's likely to go live? [21:53:13] for CI? [21:53:18] jdlrobson: travis-ci is used as an extra addition to jenkins, it's not used as the primary for anything. And there was an RfC about the use of travis (among other things) [21:53:29] jdlrobson: Early Q4 for prod. [21:53:37] I think the containers are ready though I haven't looked at them personally but I trust Timo and Kunal to have done the right things. We have jobs generated already probably [21:53:55] for prod, I can't tell but it is a goal of this fiscal year afaik [21:54:16] hashar: I believe it is, as node 6 goes EOL in April. [21:54:24] ah [21:54:27] hashar: But I'm not personally involved in that work. [21:54:27] legoktm: sure, but netlify is just static site deployments - it would be an addition to jenkins [21:54:34] yeah so SRE would surely push to get us migrated before the eol [21:54:45] Node 10 is further ahead in prod than in CI. [21:55:00] Services are already on Node 10 for a good part. [21:55:04] including their testing. [21:55:18] @hashar right Node 10 in CI is what i'm asking about [21:55:22] but for front-end testing / npm-test etc. is a bit behind, I'm catching up on that as we speak. [21:55:38] Krinkle: awesome :-) [21:55:45] The general switch will be 1-2 weeks or so, but I can canary a few if you want, jdlrobson [21:55:58] we're hitting a few issues now relating to node 6, but storybook is the first one where we've found an incompatibility with node 6 [21:56:04] Krinkle: Happy to volunteer OOUI and VE if you need early canaries. [21:56:04] Krinkle: definitely! count us in [21:56:23] jdlrobson: well wip I guess. I only learned about nodejs 10 last week :( Luckily Timo jumped in and he knows a lot more about node and repositories using them [21:56:35] jdlrobson: what issue are you running into exactly? is it testing of a node.js service, or build/unit of frontend? mw extension or generic? [21:56:51] Krinkle: also +1 on your proposal to have the node10 containers to use npm6 (if not already done) [21:56:57] Krinkle: we're experimenting with storybook to document Popups > http://localhost:6006/?selectedKind=Non-latin&selectedStory=thumbnails&full=0&addons=1&stories=1&panelRight=1&addonPanel=storybooks%2Fstorybook-addon-knobs [21:57:06] it's pretty powerful but requires node 11 [21:57:26] hashar: cool, could you review my env fix patch btw? Then you (or me, after tomorrow) can rebuild the images. [21:57:28] so for the time being we've placed it in a subfolder in Popups with its own package.json [21:57:56] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10Patch-For-Review: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Dzahn) Thanks @Paladox, per IRC and Gerrit +1 to that config change. Could you add some info in what version exactly this will... [21:58:02] i'm keen to deploy it somewhere, but given documentation generation and webpack bundling uses node 6 that's causing us problems. [21:58:03] Krinkle: sure, I am lagging behind in my reviews of integration/config, will do tomorrow morning [21:58:35] (and the reason we're using node 6 is because CI checks the assets are built in node 6) [21:58:52] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10Patch-For-Review: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Paladox) It has been removed in version 2019.01 (https://secure.phabricator.com/w/changelog/2019.01/) [21:59:08] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10Patch-For-Review: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Dzahn) https://secure.phabricator.com/book/phabricator/article/configuring_outbound_email/ [21:59:33] jdlrobson: the thing is that you will not be able to deploy a nodejs 11 app on wikimedia infra. Well at least not now since we picked up nodejs10 which is the LTS [21:59:51] sorry i shared a localhost url haha https://zen-pasteur-e92b1e.netlify.com/?selectedKind=Thumbnails&selectedStory=portrait&full=0&addons=1&stories=1&panelRight=1&addonPanel=storybooks%2Fstorybook-addon-knobs is what i meant to share [22:00:04] hashar: the app is not nodejs 11 [22:00:09] jdlrobson: what part of it requires node 11? That's an unstable node version with not many new additions last I checked, not sure why something would require that. [22:00:15] their tests run on node 8. [22:00:20] if I found the right repo [22:00:49] but surely we could get the assets build with node10 once the CI jobs are availalbe [22:01:17] Krinkle it looks like 8.6.0 is the minimum we need so 10 would be fine [22:01:26] Hosting of HTML/static assets from generated scripts we do fine though, that's all doc.wikimedia.org. We publish jsduck and coverage reports the same way. So you can use postmerge jobs in WMF CI to publish those on doc.wm.o instead of netlify [22:01:39] looks like the .nvmrc definition in Popups is wrong [22:01:57] Krinkle: sure, but i need to make sure i have node 8 for that right? [22:02:04] so if we have node 10 that problem is solved [22:03:19] jdlrobson: is storybooks a server or a build script [22:03:27] i think there are two .nvmrc files in popups [22:03:35] we can run any build script in any language in postmerge docker CI, np. [22:04:20] Krinkle: storybook generates a static folder [22:04:29] (but acts as both for dev purposes) [22:04:42] (03PS1) 10Thcipriani: service-pipeline: check for .pipeline/helm.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/483013 (https://phabricator.wikimedia.org/T209871) [22:04:42] cool. If you generate that from 'npm run doc' you can use the generic templates to have it published to doc.wikimedia.org on each commit. [22:05:14] e.g. with sub directories if needed (one for jsduck/jsdoc doc/api, and one for storybooks or just one or the other) [22:05:16] er, there will be two https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/479354/7/.storybook/.nvmrc [22:07:11] the 10,000 lines in the lockfile are somewhat concerning though. Have we audited all those to make sure that when we install that and publish the html output, not something in there added e.g. a problematic inline script on the html we then publish under *.wikimedia.org? [22:07:29] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10Patch-For-Review: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Dzahn) looked at upstream docs, config change looks ok to me, confirmed with @herron services should use smtp to localhost and t... [22:08:00] 10Phabricator, 10Release-Engineering-Team, 10Mail, 10Operations, and 2 others: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Dzahn) [22:08:18] (I ask because unlike mw-vendor and webpack output, these aren't versioned or auditable in git) [22:08:40] bbiab - lunch [22:11:37] (03PS5) 10Krinkle: Fix nyc and npm-update bugs due to unwritable HOME [integration/config] - 10https://gerrit.wikimedia.org/r/482527 (https://phabricator.wikimedia.org/T212602) [22:11:52] "jdlrobson | somebody must have approved the travis-ci app on wikimedia?" no one in releng did, there's far too many "owners" of the wikimedia github org, most initially weren't even members of releng [22:12:45] (03PS2) 10Thcipriani: service-pipeline: check for .pipeline/helm.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/483013 (https://phabricator.wikimedia.org/T209871) [22:16:31] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog): Regularly run mwext-{name}-testextension-* jobs to make sure they are still passing after core or dependency changes - https://phabricator.wikimedia.org/T93414 (10hashar) From [[ https://gerrit.wikimedia.org/r/#/c/operations/puppet/... [22:32:57] (03CR) 10Thcipriani: [C: 03+2] "deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/483013 (https://phabricator.wikimedia.org/T209871) (owner: 10Thcipriani) [22:33:18] 10Release-Engineering-Team (Backlog), 10Release Pipeline, 10Patch-For-Review: Initial production image build fails helm test - https://phabricator.wikimedia.org/T209871 (10thcipriani) 05Open→03Resolved a:03thcipriani [22:35:32] (03Merged) 10jenkins-bot: service-pipeline: check for .pipeline/helm.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/483013 (https://phabricator.wikimedia.org/T209871) (owner: 10Thcipriani) [22:36:07] greg-g: either way somebody must have approved travis-ci app at some point. Are there guidelines around what our stance on authorising github apps is? maybe tied to the RFC lego referenced earlier? [22:45:25] I don't think we have any policy for github [22:45:29] it is a gray area [22:47:05] jdlrobson: Travis app got "Installed 8 months ago" [22:47:18] I am pretty sure we have used it before that thought [22:49:50] yeh maybe they changed permissions or something or github enforced the app model? I know wikimedia apps have been using it for a while? [22:52:10] yeah [22:52:18] jdlrobson: so it is lost in the history :-) [22:52:52] so in terms of adding to the docs pipeline are there any notes for how to do this? I don't really know where to start [22:55:55] I think the only doc we have is https://www.mediawiki.org/wiki/Continuous_integration/Documentation_generation [22:55:59] (and this is why something like netlify is so powerful/tempting .. it just sets it all up for you with a couple of clicks) [22:56:09] which I gotta overhaul since I am migrating the underlying infrastructure that host doc.wikimedia.org [22:56:16] it has been made slightly simpler :) [22:57:51] jdlrobson: as for CI config, what Timo said an hour or so ago: [22:57:59] """ If you generate that from 'npm run doc' you can use the generic templates to have it published to doc.wikimedia.org on each commit.""" [22:58:11] """e.g. with sub directories if needed (one for jsduck/jsdoc doc/api, and one for storybooks or just one or the other)""" [22:59:08] then we will want to craft a job that runs that command and publish to doc.wm.o [22:59:15] hashar: is there any easy way for me to test the configuration locally? (or does that require a day setting up jenkins job builder or cargo cult programming and poking at it until it works ?) [22:59:26] not so sure about hosting node_modules on doc.wm.o though [23:02:59] jdlrobson: yeah there is a bit of programming to add a job that runs npm run doc and publish. But that is not too hard [23:03:25] once the job is created, adding it on other repositories is rather trivial [23:04:09] i'll setup a task for a rainy day... [23:05:04] jdlrobson: well you can fill it up with the gerrit repo name, mention you need node 10 and then have a change that introduce the npm script doc so we can just "npm run doc" [23:05:14] and from there we will do the boiler plate in jjb/yaml etc [23:05:30] i promise one day devs will be able to do it themselves [23:05:40] in a simpler way [23:05:42] the storybook code is in a dedicated folder with its own package.json [23:05:44] will that be a problem? [23:05:55] yeah most probably [23:06:55] because the root directory needs node 6 [23:07:05] probably best if i capture this all in a card [23:07:25] first write the use in a task, and we can look at what has to be done :) [23:08:05] and whateever is the repository, it is most probably going to be migrated to node10 over the next few weeks [23:09:41] anyway sorry, i have to sleep :/ midnight passed [23:17:31] 10Release-Engineering-Team (Backlog), 10Readers-Web-Backlog: Publish Popups storybook to docs - https://phabricator.wikimedia.org/T213226 (10Jdlrobson) [23:18:14] 10Release-Engineering-Team (Backlog), 10Page-Previews, 10Readers-Web-Backlog: Publish Popups storybook to docs - https://phabricator.wikimedia.org/T213226 (10Jdlrobson) [23:18:28] did my best to capture the problem here > https://phabricator.wikimedia.org/T213226 [23:18:33] thanks for the conversations :) [23:20:07] 10Release-Engineering-Team (Backlog), 10Page-Previews, 10Readers-Web-Backlog: Publish Popups storybook to docs - https://phabricator.wikimedia.org/T213226 (10Jdlrobson) [23:25:30] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10Jdlrobson) > For uploading patches one can use https://www.mediawiki.org/wiki/Gerrit_patch_uploader . Interface: https://tools.wmflabs.org/gerri... [23:33:39] jdlrobson: team-level managers have approved in case by case basis, yes. No other level than that. [23:36:52] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10Reedy) >>! In T37497#4864391, @Jdlrobson wrote: > It's important to me that any contributor doesn't have to use any tooling that they are not fa... [23:38:03] I have to go afk, I'm down to one eye (sticks+kids+eyes==ouch) [23:39:31] :O