[00:21:58] urandom: Hey! I just saw the email from Greg, ping me if you want to chat about mutation testing [00:23:30] gehel: ?? [00:24:02] Oh, disregard, this was about Evan, not Evans :( [00:24:49] that being said, let me know if you are interested in mutation testing :) [00:24:50] Haha [00:26:11] gehel: put the jar of radioactive spiders away please >.> [00:28:07] * gehel does not like spiders ! [00:28:27] What about a box of radioactive kittens instead ? [00:28:44] * gehel is going to bed, it is well past time ! [00:29:35] gehel: :) eprodromou on IRC :) [00:30:17] greg-g: I replied to the email, let's see tomorrow where that leads [03:07:52] 10MediaWiki-Codesniffer, 10Patch-For-Review: Closure formatting is ugly - https://phabricator.wikimedia.org/T154789 (10MGChecker) I agree with @Mainframe98 here. [03:10:14] maintenance-disconnect-full-disks build 37898 integration-slave-docker-1021 (/: 98%): OFFLINE due to disk space [03:10:15] maintenance-disconnect-full-disks build 37898 integration-slave-docker-1021 (/: 98%): OFFLINE due to disk space [03:20:14] maintenance-disconnect-full-disks build 37900 integration-slave-docker-1021: OFFLINE due to disk space [03:45:13] maintenance-disconnect-full-disks build 37905 integration-slave-docker-1021: OFFLINE due to disk space [04:10:25] maintenance-disconnect-full-disks build 37910 integration-slave-docker-1021: OFFLINE due to disk space [04:19:33] 10Diffusion, 10Striker, 10Patch-For-Review: Diffusion repository creation fails via toolsadmin - https://phabricator.wikimedia.org/T182142 (10bd808) a:03bd808 [04:35:13] maintenance-disconnect-full-disks build 37915 integration-slave-docker-1021: OFFLINE due to disk space [05:00:13] maintenance-disconnect-full-disks build 37920 integration-slave-docker-1021: OFFLINE due to disk space [05:25:14] maintenance-disconnect-full-disks build 37925 integration-slave-docker-1021: OFFLINE due to disk space [05:50:13] maintenance-disconnect-full-disks build 37930 integration-slave-docker-1021: OFFLINE due to disk space [06:15:15] maintenance-disconnect-full-disks build 37935 integration-slave-docker-1021: OFFLINE due to disk space [06:40:13] maintenance-disconnect-full-disks build 37940 integration-slave-docker-1021: OFFLINE due to disk space [07:05:13] maintenance-disconnect-full-disks build 37945 integration-slave-docker-1021: OFFLINE due to disk space [07:30:13] maintenance-disconnect-full-disks build 37950 integration-slave-docker-1021: OFFLINE due to disk space [07:55:13] maintenance-disconnect-full-disks build 37955 integration-slave-docker-1021: OFFLINE due to disk space [08:16:25] 10Continuous-Integration-Infrastructure, 10MediaWiki-Vendor, 10Composer, 10Patch-For-Review, 10Security: security.sensiolabs.org is shutting down at the end of October 2018 - https://phabricator.wikimedia.org/T206442 (10Legoktm) a:03Legoktm > we should just re-implement it as a PHP webservice, and offe... [08:20:15] maintenance-disconnect-full-disks build 37960 integration-slave-docker-1021: OFFLINE due to disk space [08:30:10] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: doc.wikimedia.org urls without trailing slash respond with HTTP 403 Forbidden - https://phabricator.wikimedia.org/T213509 (10hashar) Amazing, thank you very much for the apache-fast-test test! [08:33:29] hashar: maintenance-disconnect-full-disks build 37930 integration-slave-docker-1021: OFFLINE due to disk space [08:36:42] (03CR) 10Hashar: [C: 03+2] [MediaWiki-VisualEditor]: Test with TemplateData [integration/config] - 10https://gerrit.wikimedia.org/r/484264 (owner: 10Jforrester) [08:38:32] (03Merged) 10jenkins-bot: [MediaWiki-VisualEditor]: Test with TemplateData [integration/config] - 10https://gerrit.wikimedia.org/r/484264 (owner: 10Jforrester) [08:45:16] maintenance-disconnect-full-disks build 37965 integration-slave-docker-1021: OFFLINE due to disk space [08:48:16] (03CR) 10Hashar: "That sounds legit. 1900 seconds is 31 minutes. There are three matrix jobs which trigger the php-composer-security-docker 15 times if my c" [integration/config] - 10https://gerrit.wikimedia.org/r/482646 (https://phabricator.wikimedia.org/T206442) (owner: 10Brian Wolff) [08:58:41] 10Continuous-Integration-Infrastructure, 10MediaWiki-Vendor, 10Composer, 10Patch-For-Review, 10Security: security.sensiolabs.org is shutting down at the end of October 2018 - https://phabricator.wikimedia.org/T206442 (10hashar) Can't we reuse upstream CLI? https://github.com/sensiolabs/security-checker... [08:59:37] zeljkof: clean it up ? :) [08:59:53] hashar: I have no idea even where to start ;P [08:59:57] ... [09:00:15] and in the middle of something completely different, just noticed the error message :) [09:00:55] !log Deleting Docker images on integration-slave-docker-1021 [09:00:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:04:00] https://integration.wikimedia.org/ci/label/BrowserTests/ bah [09:04:10] bunch of them have been failling for months [09:35:35] 10Continuous-Integration-Infrastructure, 10MediaWiki-Vendor, 10Composer, 10Patch-For-Review, 10Security: security.sensiolabs.org is shutting down at the end of October 2018 - https://phabricator.wikimedia.org/T206442 (10Legoktm) >>! In T206442#4880226, @hashar wrote: > Can't we reuse upstream CLI? https:... [09:52:58] 10Continuous-Integration-Infrastructure (Slipway), 10CirrusSearch, 10Discovery-Search: mwext-CirrusSearch-whitespaces - https://phabricator.wikimedia.org/T210282 (10hashar) I looked at the history of commits with a tiny script: ` #!/usr/bin/python3 import shlex import subprocess out = subprocess.check_outp... [09:57:11] (03PS1) 10Hashar: Remove CirrusSearch whitespaces job [integration/config] - 10https://gerrit.wikimedia.org/r/484385 (https://phabricator.wikimedia.org/T210282) [09:57:22] 10Continuous-Integration-Infrastructure (Slipway), 10Release-Engineering-Team (Kanban), 10CirrusSearch, 10Discovery-Search, 10Patch-For-Review: mwext-CirrusSearch-whitespaces - https://phabricator.wikimedia.org/T210282 (10hashar) a:03hashar [09:59:16] (03CR) 10Hashar: "IIRC the job got added for Nik "manybubbles" Everett. CirrusSearch is the sole repository using it and I would like to clean up the CI co" [integration/config] - 10https://gerrit.wikimedia.org/r/484385 (https://phabricator.wikimedia.org/T210282) (owner: 10Hashar) [09:59:57] (03CR) 10DCausse: [C: 03+1] "no problem!" [integration/config] - 10https://gerrit.wikimedia.org/r/484385 (https://phabricator.wikimedia.org/T210282) (owner: 10Hashar) [10:00:07] dcausse: ;) [10:00:10] :) [10:00:22] 10Release-Engineering-Team (Kanban), 10Code-Stewardship-Reviews, 10Graphoid, 10Operations, and 2 others: graphoid: Code stewardship request - https://phabricator.wikimedia.org/T211881 (10akosiaris) >>! In T211881#4878702, @Tgr wrote: > Are those numbers reliable? Arabic Wikipedia gets about 5M pageviews a... [10:00:27] dcausse: je tente de nettoyer la config du CI :] [10:00:44] (03CR) 10Hashar: [C: 03+2] "Merci!" [integration/config] - 10https://gerrit.wikimedia.org/r/484385 (https://phabricator.wikimedia.org/T210282) (owner: 10Hashar) [10:03:24] (03Merged) 10jenkins-bot: Remove CirrusSearch whitespaces job [integration/config] - 10https://gerrit.wikimedia.org/r/484385 (https://phabricator.wikimedia.org/T210282) (owner: 10Hashar) [10:04:14] 10Continuous-Integration-Infrastructure (Slipway), 10Release-Engineering-Team (Kanban), 10CirrusSearch, 10Discovery-Search, 10Patch-For-Review: mwext-CirrusSearch-whitespaces - https://phabricator.wikimedia.org/T210282 (10hashar) 05Open→03Resolved [10:55:21] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10User-zeljkofilipin: Give a code health metrics talk at All Hands - https://phabricator.wikimedia.org/T207044 (10zeljkofilipin) Looks like lightning talk schedule is already fixed. I've assumed we'll be able to apply during the event. 🤔 [10:57:47] 10Continuous-Integration-Infrastructure (Slipway), 10Release-Engineering-Team (Kanban), 10releng-201718-q4, 10Discovery, 10Wikimedia-Portals: Migrate Jenkins jobs wikimedia-portals-build and wikidata-query-gui-build to Docker and to use an entry point (eg: npm bu... - https://phabricator.wikimedia.org/T190073 [10:58:01] 10Continuous-Integration-Infrastructure (Slipway), 10Wikidata, 10Wikidata Query UI, 10Wikimedia-Portals: Migrate wikidata-query-gui-build and wikimedia-portals-build to Docker containers - https://phabricator.wikimedia.org/T210286 (10hashar) [10:58:04] 10Continuous-Integration-Infrastructure (Slipway), 10Release-Engineering-Team (Kanban), 10releng-201718-q4, 10Discovery, 10Wikimedia-Portals: Migrate Jenkins jobs wikimedia-portals-build and wikidata-query-gui-build to Docker and to use an entry point (eg: npm bu... - https://phabricator.wikimedia.org/T190073 [10:59:41] 10Continuous-Integration-Infrastructure (Slipway), 10Wikimedia-Portals: Migrate wikimedia-portals-build to Docker container - https://phabricator.wikimedia.org/T213806 (10hashar) [11:00:51] 10Continuous-Integration-Infrastructure (Slipway), 10Wikidata, 10Wikidata Query UI: Migrate wikidata-query-gui-build to Docker containers - https://phabricator.wikimedia.org/T210286 (10hashar) [11:01:39] 10Continuous-Integration-Infrastructure (Slipway), 10Wikidata, 10Wikidata Query UI: Migrate wikidata-query-gui-build to Docker containers - https://phabricator.wikimedia.org/T210286 (10hashar) I have moved the part about Wikimedia portals to a standalone task T213806. Although the jobs for each repositories... [11:02:10] 10Continuous-Integration-Infrastructure (Slipway), 10Wikimedia-Portals: Migrate wikimedia-portals-build to Docker container - https://phabricator.wikimedia.org/T213806 (10hashar) [11:18:06] 10Continuous-Integration-Infrastructure, 10MediaWiki-Vendor, 10Composer, 10Patch-For-Review, 10Security: security.sensiolabs.org is shutting down at the end of October 2018 - https://phabricator.wikimedia.org/T206442 (10hashar) Good that makes sense :-] [12:26:05] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10hashar) I went with install bazel from their apt package (which is a huge binary blob bah). Then: ` $ cd ~/projects/operatio... [12:33:38] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10Paladox) @hashar correct (for the path to the plugin jar) [12:55:54] 10Continuous-Integration-Config, 10Jenkins: Typo on https://integration.wikimedia.org/ci/ - https://phabricator.wikimedia.org/T191078 (10hashar) The patch did: ` lang=diff - login=Iniciar Sesion + login=Iniciar sesión ` And now it shows as: `Iniciar sesión` Because the translation file now has: `Iniciar ses... [13:00:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "At this point I'm not so sure any more if we know what we are doing here. The auto-fix code already became so complicated, I honestly can'" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/446271 (https://phabricator.wikimedia.org/T199768) (owner: 10Prtksxna) [13:04:53] (03PS1) 10Urbanecm: Production branch is no longer needed [wikimedia-cz/tracker] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/484417 [13:05:08] (03CR) 10Urbanecm: [V: 03+2 C: 03+2] Production branch is no longer needed [wikimedia-cz/tracker] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/484417 (owner: 10Urbanecm) [13:32:48] 10Continuous-Integration-Infrastructure (Slipway), 10Lexicographical data, 10Wikidata, 10Browser-Tests, 10User-zeljkofilipin: Migrate selenium-Wikibase-chrome selenium-WikibaseLexeme-chrome to Docker containers - https://phabricator.wikimedia.org/T210285 (10hashar) >>! In T210285#4876384, @WMDE-leszek wr... [13:47:38] (03PS1) 10Eevans: Edit Project Config [services/kask] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/484427 [13:48:06] (03Abandoned) 10Eevans: Edit Project Config [services/kask] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/484427 (owner: 10Eevans) [13:48:43] 10Continuous-Integration-Config, 10Jenkins: Typo on https://integration.wikimedia.org/ci/ - https://phabricator.wikimedia.org/T191078 (10MarcoAurelio) Yes indeed it's broken. Not sure why they replace `ó`. [14:09:26] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata-Campsite: Run ArticlePlaceholder tests as part of Wikibase CI - https://phabricator.wikimedia.org/T213815 (10Addshore) [15:34:55] 10Phabricator, 10translatewiki.net, 10I18n: Update Translatewiki with phabricator source string changes - https://phabricator.wikimedia.org/T209631 (10mmodell) >>! In T209631#4756495, @Nikerabbit wrote: > That was a lot of changes to process. Hopefully in future they will be smaller (or done more often). In... [15:35:20] 10Phabricator, 10translatewiki.net, 10I18n: Update Translatewiki with phabricator source string changes - https://phabricator.wikimedia.org/T209631 (10mmodell) 05Open→03Resolved a:03mmodell [16:13:44] (03PS1) 10Hashar: docker: rake-mediawiki-selenium [integration/config] - 10https://gerrit.wikimedia.org/r/484507 (https://phabricator.wikimedia.org/T210285) [16:15:19] 10Continuous-Integration-Infrastructure (Slipway), 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Wikidata, and 3 others: Migrate selenium-Wikibase-chrome selenium-WikibaseLexeme-chrome to Docker containers - https://phabricator.wikimedia.org/T210285 (10hashar) a:03hashar I crafted a very... [16:16:17] (03CR) 10jerkins-bot: [V: 04-1] docker: rake-mediawiki-selenium [integration/config] - 10https://gerrit.wikimedia.org/r/484507 (https://phabricator.wikimedia.org/T210285) (owner: 10Hashar) [16:17:04] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Security-Team, 10User-MModell: Create a security issue task type with additional attributes - https://phabricator.wikimedia.org/T204160 (10mmodell) a:05mmodell→03chasemp Assigning this to chase since my part is mostly done. Please feel free to assig... [17:19:13] 10Release-Engineering-Team, 10Operations, 10Recommendation-API, 10Research, and 2 others: Recommendation API improvements - https://phabricator.wikimedia.org/T213222 (10bmansurov) [17:43:36] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), and 2 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10hashar) [17:44:10] 10Continuous-Integration-Infrastructure (Slipway), 10Wikimedia-Portals: Migrate wikimedia-portals-build to Docker container - https://phabricator.wikimedia.org/T213806 (10hashar) I might look at migrating it to a CI Docker container. Longterm it would probably migrate to Blubber / Pipeline / Kubernetes which i... [17:44:40] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Core Platform Team Backlog (Watching / External), and 2 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10hashar) From the releng meeting, I have added `wikimedia/portals` to th... [18:04:26] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.33.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T206667 (10dduvall) a:03dduvall Cutting the branch. [18:33:11] is gerrit down? [18:33:18] What's going on with Gerrit? It's completely broken for me [18:35:33] known [18:35:36] see -operations [18:35:37] subbu: RoanKattouw see -operations :) [18:36:46] ok. [18:38:43] 10Release-Engineering-Team (Backlog), 10Discovery-Search (Current work): Use maven wrapper (mvnw) to build maven based project from search platform team - https://phabricator.wikimedia.org/T208938 (10Gehel) 05Open→03Resolved a:03Gehel This has been done for some time already [18:39:21] 10Release-Engineering-Team (Backlog), 10Discovery-Search (Current work): Use maven wrapper (mvnw) to build maven based project from search platform team - https://phabricator.wikimedia.org/T208938 (10Gehel) 05Resolved→03Open my mistake, this ticket is still ongoing, the CI part isn't done yet. [19:29:05] is there a delay of any kind for someone adding their SSH public key to gerrit.wikimedia.org, and having it accepted? [19:29:23] nope [19:29:26] should be instant [19:29:39] hrmm [19:30:04] hmm I'm attempting to run the ssh and it keeps asking for a password. I'm on Mac btw [19:31:08] oh, it shoulden't be asking for a password [19:31:23] password for your ssh key? or password for the server? [19:32:21] Not sure. I've tried my my passphrase and other passwords to no avail [19:32:44] clarakosi: but it does say "Password:", yes? [19:32:44] What command are you running? [19:33:02] (like, all by itself?) [19:33:27] Bare in mind, there's been some gerrit issues related to the DC power stuff [19:33:35] So it's possible things aren't working quite as expected too [19:33:35] `ssh -p 29418 @gerrit.wikimedia.org` [19:33:43] urandom: yeah it says password [19:34:06] run it iwth ssh -vvv? [19:36:23] https://www.irccloud.com/pastebin/Oe1qeKPm/ [19:36:35] seems to be reading from the config file [19:36:40] oooh [19:36:52] it's trying to proxy through bast2001 [19:37:09] clarakosi: what does your `.ssh/config` look like? [19:37:57] seems the likely culprit :) [19:38:15] https://www.irccloud.com/pastebin/xl6jv0FK/ [19:38:37] Host !bast2001.wikimedia.org *.wikimedia.org *.wmnet [19:38:37] ProxyCommand ssh -a -W %h:%p bast2001.wikimedia.org [19:38:43] add a !gerrit.wikimedia.org to that [19:38:55] or take out the *.wikimedia.org ? [19:39:13] that seems too eager a match [19:39:15] Depends which hosts they need to access [19:39:16] Host *.wikimedia.org *.wmnet !gerrit.wikimedia.org !git-ssh.wikimedia.org [19:39:16] User reedy [19:39:16] # Everything else goes via bastion acting as a proxy [19:39:17] ProxyCommand ssh -a -W %h:%p bast3002.wikimedia.org [19:39:19] # Do not offer other identities loaded in ssh-agent [19:39:22] IdentitiesOnly yes [19:39:24] IdentityFile ~/.ssh/reedy-wmfprod [19:39:26] That's what I have [19:39:28] and then [19:39:31] oh ok [19:39:33] Host gerrit.wikimedia.org [19:39:35] User reedy [19:39:37] # Do not offer other identities loaded in ssh-agent [19:39:39] IdentitiesOnly yes [19:39:41] IdentityFile ~/.ssh/reedy-cloud [19:39:45] It works! Thanks Reedy [19:39:51] https://wikitech.wikimedia.org/wiki/Production_shell_access#Setting_up_your_SSH_config [19:40:00] ^ our docs say "Host *.wikimedia.org *.wmnet !gerrit.wikimedia.org !git-ssh.wikimedia.org" too :) [19:40:18] clarakosi: Might want to add the !git-ssh one too incase you end up needing that host for some reason [19:40:36] Reedy: will do. Thanks again [19:40:41] np :) [19:40:50] cool [19:40:59] 10Release-Engineering-Team, 10Operations, 10Recommendation-API, 10Research, and 2 others: Recommendation API improvements - https://phabricator.wikimedia.org/T213222 (10leila) [19:41:41] 10Release-Engineering-Team (Kanban), 10Code-Stewardship-Reviews, 10Graphoid, 10Operations, and 2 others: graphoid: Code stewardship request - https://phabricator.wikimedia.org/T211881 (10MSantos) >>! In T211881#4878426, @akosiaris wrote: >> @akosiaris, the logic in I've got another question! We have a service written in Go now: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/services/kask, and we'll need CI for it [19:44:12] two things I cannot think of an existing example of (so I'm not sure if it'll be a problem or not), 1) we want to generate a release artifact from the CI build [19:44:39] and 2) we have functional tests that need to connect to Cassandra (so we need to spin up a DB, and tear it down after) [19:45:38] the question, I guess, are there examples of either? [19:45:43] urandom: we have another service written in go: https://gerrit.wikimedia.org/g/blubber [19:45:58] * Reedy runs while thcipriani answers the question [19:46:07] it may be able to help you build a new service in go: https://wikitech.wikimedia.org/wiki/Blubber [19:46:24] ok, cool [19:46:27] it's part of the Deployment Pipeline work serviceops/releng has been working on [19:46:49] the result of the pipeline is a docker image that is deployable to production [19:47:10] blubber uses blubber to make the blubberoid service which is a docker image that is deployed to production k8s [19:47:19] thcipriani: oh, is this having... yeah [19:47:27] kask isn't going on kubernetes [19:47:30] https://people.wikimedia.org/~thcipriani/docker/wikimedia/blubber/tags/ [19:47:48] there aren't any plans to deploy it via a docker image atm [19:48:06] presumably we *could* if necessary [19:48:39] so the artifact I had in mind was the compiled binary [19:49:20] yeah, hrm, I think there may be certain maven jobs that produce a compiled jar, but I'm not 100% sure [19:49:24] re: kask, neat! [19:50:32] blubberoid's image is basically a compiled binary in a tar file [19:50:39] e.g. docker image [19:50:43] er i.e. [19:50:45] right [19:53:33] thcipriani: what about functional testing that relies on an external process? [19:54:52] we have examples of that (i.e., we spin up mysql inside a container to run mediawiki tests), they're all pseudo-custom solutions inside the integration/config repo. [19:56:21] urandom: it might be best to file a task with this same question tagged continuous-integration-config. I can brain dump there a bit. hashar can also brain dump when he's around about anything that may produce artifacts. [19:56:38] ostensibly kask could be tested via the CD pipeline (including functional tests with a cassandra backend) even if it's not deployed to prod k8s [19:57:23] thcipriani: perfect, I'll do that [19:57:34] marxarelli: CD pipeline? [19:57:38] marxarelli: helm test could probably make this work, but I don't know about the end result artifact [19:58:19] thcipriani: true. it would result in a docker image containing the binary [19:58:27] urandom: same thing I mentioned above -- the k8s pipeline. It can accomplish what you want, it just produces a docker image with a binary rather than a binary. [19:58:34] thcipriani: we're using dependencies packaged for Stretch (to piggy back on Debian security support), so I'd like to avoid deploying with artifacts built on developers workstations [19:58:42] urandom: the pipeline we're building out with sre (ci + blubber + helm + k8s) [19:58:47] too error prone [19:59:19] urandom: https://wikitech.wikimedia.org/wiki/Streamlined_Service_Delivery_Design [19:59:24] So `make` gives us what we want, but I'd rather use a result built repeatably elsewhere against a pristine env [20:02:41] yeah, that's what we were aiming for with the pipeline: repeatable trusted build environment with the ability to define unit and integration tests. Just outputs a docker image currently :P [20:03:18] maybe that's OK, it's a superset of what we're after [20:03:49] anyway, if you file a task, I can brain dump a few alternatives. The only real alternative I can think of would be something ad hoc in integration/config, but maybe I'm not aware of a project doing something simliar elsewhere. [20:03:59] thcipriani: will do [20:18:50] 10MediaWiki-Codesniffer: Sniff to detect if there are not spaces between function definitions - https://phabricator.wikimedia.org/T213861 (10D3r1ck01) [20:19:41] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10hashar) The plugin is going to be bumped by https://gerrit.wikimedia.org/r/#/c/operations/software/gerrit/+/484437/-1..1 [20:24:05] 10MediaWiki-Codesniffer: Sniff to detect if there are not newlines between function definitions - https://phabricator.wikimedia.org/T213861 (10D3r1ck01) [20:24:50] 10MediaWiki-Codesniffer: Sniff to detect if there is no one extra newlines between function definitions - https://phabricator.wikimedia.org/T213861 (10D3r1ck01) [21:08:09] twentyafterfour: hi, so there has been an issue affecting dbproxy used by phabricator. tomorrow (when DBAs are back) it will fail-over to a new DNS name. but it's just the DNS change. it's not clear if we have to restart phabricator [21:09:09] mutante i think it will be safe. [21:09:29] mutante: I'm not sure... It would probably pick up the dns change eventually but it might take a while to notice ... restarting apache should do the trick? [21:10:37] twentyafterfour: restarting phd service i think [21:10:57] since that talks to mysql (maria) [21:12:56] paladox: what are we using again for mysql_host.. didnt we put it in hiera.. looking [21:13:26] um [21:13:27] https://github.com/wikimedia/puppet/blob/production/hieradata/role/eqiad/phabricator.yaml#L7 [21:13:29] mutante ^^ [21:13:32] hiera('phabricator::mysql::master' [21:13:51] phabricator::mysql::master: "m3-master.eqiad.wmnet" [21:14:01] yea, so this will point to a new server suddenly [21:14:23] sometime tomorrow when Manuel does it. i said i could talk about it here [21:27:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (Backlog), 10Discovery-Search (Current work): Use maven wrapper (mvnw) to build maven based project from search platform team - https://phabricator.wikimedia.org/T208938 (10greg) [22:41:59] (03PS5) 10Krinkle: [WIP] Add mediawiki-fresnel-patch job [integration/config] - 10https://gerrit.wikimedia.org/r/459268 (https://phabricator.wikimedia.org/T133646) [22:55:01] thcipriani gerrit seems to be missing from archiva. [22:55:17] when i search "gerrit" it only brings up the plugins. [22:57:24] ah [22:57:25] found it [22:57:26] https://archiva.wikimedia.org/#artifact/com.googlesource/gerrit/2.15.8 [22:58:11] 10Continuous-Integration-Config, 10Utilities-mwdumper: Build mwdumper automatically - https://phabricator.wikimedia.org/T213874 (10Tgr) [22:59:21] paladox: yeah, it's there, although I did just find a bug in the script that I use to upload [22:59:29] oh [22:59:57] https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/gerrit/+/deploy/wmf/stable-2.15/deploy_artifacts.py#39 [23:00:51] happens in a loop so on the first iteration: works as expected, on the second iteration you get things like: https://archiva.wikimedia.org/#browse/com.googlesource.gerrit.plugins.gerrit.plugins.gerrit.plugins.gerrit.plugins.gerrit.plugins [23:01:05] gerrit.plugins over and over [23:01:15] ah ok [23:02:03] not affecting git-fat, but it's not ideal either :) [23:03:33] heh [23:11:07] thcipriani i wonder do we want to get rid of the 2.14 branch? [23:28:35] (03PS6) 10Krinkle: Add mediawiki-fresnel-patch job [integration/config] - 10https://gerrit.wikimedia.org/r/459268 (https://phabricator.wikimedia.org/T133646)