[00:00:01] thcipriani: :) [01:00:40] 10Release-Engineering-Team (Next), 10serviceops, 10Patch-For-Review, 10Release Pipeline (Blubber): Publish Blubber releases on releases.wikimedia.org - https://phabricator.wikimedia.org/T213563 (10thcipriani) 05Open→03Resolved a:03thcipriani yipee! I pushed up latest binaries to releases and they ar... [02:09:38] paladox: is it possible to exempt users from the reviewers-by-blame plugin? [02:09:45] * paladox looks [02:10:25] nope [02:10:26] https://gerrit.googlesource.com/plugins/reviewers-by-blame/+/master/src/main/resources/Documentation/config.md [02:11:50] 10Gerrit: Exempt libraryupgrader from Gerrit's reviewers-by-blame plugin - https://phabricator.wikimedia.org/T213997 (10Legoktm) [02:13:07] paladox: ^^ [02:13:14] * paladox is on it :) [02:13:15] maybe we can submit an upstream bug report tehn? [02:13:17] reporting upstream [02:13:18] ty :)) [02:13:20] <3 [02:15:08] legoktm https://bugs.chromium.org/p/gerrit/issues/detail?id=10318 [02:15:37] 10Gerrit, 10Upstream: Exempt libraryupgrader from Gerrit's reviewers-by-blame plugin - https://phabricator.wikimedia.org/T213997 (10Paladox) Reported upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=10318 [02:15:51] thank you :) [02:16:22] your welcome :) [02:32:29] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10Tgr) Works great, thank you for fixing it! Given that action of adding reviewers is done under the name of the uploader, so... [06:22:23] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10Peachey88) >>! In T101131#4886836, @Tgr wrote: > Works great, thank you for fixing it! > > Given that action of adding revi... [06:38:51] 10Project-Admins: Cleaning up #Mediawiki-extensions-other - https://phabricator.wikimedia.org/T213880 (10Peachey88) >>! In T213880#4883183, @Krenair wrote: > I understand the reasoning behind this but I am skeptical about how good an idea it is to create phab projects for code that might not actually be tracking... [07:02:43] (03PS1) 10Legoktm: Use php-security-checker.wmflabs.org for composer security checks [integration/config] - 10https://gerrit.wikimedia.org/r/484853 (https://phabricator.wikimedia.org/T206442) [07:03:31] (03PS2) 10Legoktm: Use php-security-checker.wmflabs.org for composer security checks [integration/config] - 10https://gerrit.wikimedia.org/r/484853 (https://phabricator.wikimedia.org/T206442) [08:37:47] (03CR) 10Legoktm: [C: 03+2] Use php-security-checker.wmflabs.org for composer security checks [integration/config] - 10https://gerrit.wikimedia.org/r/484853 (https://phabricator.wikimedia.org/T206442) (owner: 10Legoktm) [08:39:08] (03Merged) 10jenkins-bot: Use php-security-checker.wmflabs.org for composer security checks [integration/config] - 10https://gerrit.wikimedia.org/r/484853 (https://phabricator.wikimedia.org/T206442) (owner: 10Legoktm) [08:39:47] !log deploying composer docker image - https://gerrit.wikimedia.org/r/484853 [08:39:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:45:02] 10Project-Admins: Cleaning up #Mediawiki-extensions-other - https://phabricator.wikimedia.org/T213880 (10Legoktm) >>! In T213880#4883251, @Aklapper wrote: > It might be unrealistic but then I might miss the point of the entire proposal? :) > Which underlying problem is solved by spending time categorizing things... [08:46:30] (03PS1) 10Legoktm: php-composer-security-docker: Use composer:0.1.8 image [integration/config] - 10https://gerrit.wikimedia.org/r/484975 [08:54:22] 10Continuous-Integration-Infrastructure: Upgrade jenkins-debian-glue to v0.20.0 - https://phabricator.wikimedia.org/T212774 (10hashar) [08:54:37] 10Continuous-Integration-Infrastructure, 10Packaging: Upgrade jenkins-debian-glue to v0.20.0 - https://phabricator.wikimedia.org/T212774 (10hashar) [08:55:22] 10Continuous-Integration-Infrastructure, 10Packaging: Upgrade jenkins-debian-glue to v0.20.0 - https://phabricator.wikimedia.org/T212774 (10hashar) [08:55:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Packaging, 10Upstream: jenkins-debian-glue should run the lintian version from cowbuilder instead of from host - https://phabricator.wikimedia.org/T186494 (10hashar) [09:02:07] (03PS2) 10Hashar: php-composer-security-docker: Use composer:0.1.8 image [integration/config] - 10https://gerrit.wikimedia.org/r/484975 (https://phabricator.wikimedia.org/T212774) (owner: 10Legoktm) [09:02:30] (03PS3) 10Hashar: php-composer-security-docker: Use composer:0.1.8 image [integration/config] - 10https://gerrit.wikimedia.org/r/484975 (https://phabricator.wikimedia.org/T206442) (owner: 10Legoktm) [09:02:47] (03CR) 10Hashar: [C: 03+1] "Attached to T206442 :)" [integration/config] - 10https://gerrit.wikimedia.org/r/484975 (https://phabricator.wikimedia.org/T206442) (owner: 10Legoktm) [09:15:33] 10Release-Engineering-Team, 10Performance-Team: Create gerrit bot for git pushes to specific repo from prod machines - https://phabricator.wikimedia.org/T214015 (10Gilles) p:05Triage→03Normal [09:19:11] 10Release-Engineering-Team (Backlog), 10ORES, 10Operations, 10Scoring-platform-team, 10Release Pipeline (Blubber): The continuous release pipeline should support more than one service per repo - https://phabricator.wikimedia.org/T210267 (10Ladsgroup) >>! In T210267#4873881, @thcipriani wrote: > I think t... [09:19:48] (03Abandoned) 10Ladsgroup: python: Upgrade pip as well as other libraries [blubber] - 10https://gerrit.wikimedia.org/r/475732 (owner: 10Ladsgroup) [09:31:06] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10Jenkins, 10User-zeljkofilipin: selenium-daily-beta-Newsletter failing during `npm install` - https://phabricator.wikimedia.org/T213944 (10zeljkofilipin) p:05Triage→03Normal [10:13:39] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10Jenkins, 10User-zeljkofilipin: selenium-daily-beta-Newsletter failing during `npm install` - https://phabricator.wikimedia.org/T213944 (10hashar) `fibers` seems to be a native module which t... [10:20:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10Jenkins, 10User-zeljkofilipin: selenium-daily-beta-Newsletter failing during `npm install` - https://phabricator.wikimedia.org/T213944 (10hashar) Note the Docker containers are being passed... [10:23:02] hashar: quick one, how hard it is to add some build artifacts from a tox job so that they are available in Jenkins? I'm wondering if it would be possible to "check" sphinx output before merging directly from jenkins ;) [10:25:43] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10Jenkins, 10User-zeljkofilipin: selenium-daily-beta-Newsletter failing during `npm install` - https://phabricator.wikimedia.org/T213944 (10hashar) To reproduce: ` $ docker run --rm -it --entr... [10:31:28] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10Jenkins, 10User-zeljkofilipin: selenium-daily-beta-Newsletter failing during `npm install` - https://phabricator.wikimedia.org/T213944 (10hashar) We have python-minimal in a bunch of npm con... [10:35:54] (03CR) 10Legoktm: [C: 03+2] "Thanks :)" [integration/config] - 10https://gerrit.wikimedia.org/r/484975 (https://phabricator.wikimedia.org/T206442) (owner: 10Legoktm) [10:37:56] (03Merged) 10jenkins-bot: php-composer-security-docker: Use composer:0.1.8 image [integration/config] - 10https://gerrit.wikimedia.org/r/484975 (https://phabricator.wikimedia.org/T206442) (owner: 10Legoktm) [10:38:41] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10Jenkins, 10User-zeljkofilipin: selenium-daily-beta-Newsletter failing during `npm install` - https://phabricator.wikimedia.org/T213944 (10hashar) For the other issue (wrong username) node-gy... [10:51:54] (03CR) 10Hashar: "Some comments about the bash script, I will send a new change that amend that." (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [10:53:01] (03PS11) 10Hashar: Add job for running code analysis on SonarQube [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [10:54:27] (03CR) 10Hashar: [C: 03+2] "The job is experimental so it is not going to cause any trouble." [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [10:56:04] (03PS12) 10Hashar: Add job for running code analysis on SonarQube [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [10:57:07] (03CR) 10Hashar: [C: 03+2] "I forgot to deploy the Jenkins job :(" [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [10:59:41] (03Merged) 10jenkins-bot: Add job for running code analysis on SonarQube [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [11:03:56] (03PS1) 10Hashar: docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 [11:11:31] zeljkof: let me know how the experimental sonarqube job works :) [11:11:37] I am heading out for lunch right now though :) [11:11:43] hashar: will do :) [11:30:15] maintenance-disconnect-full-disks build 38574 integration-slave-jessie-1002 (/srv: 95%): OFFLINE due to disk space [11:35:13] maintenance-disconnect-full-disks build 38575 integration-slave-jessie-1002: OFFLINE due to disk space [12:00:13] maintenance-disconnect-full-disks build 38580 integration-slave-jessie-1002: OFFLINE due to disk space [12:24:59] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10Patch-For-Review, 10User-zeljkofilipin: Code health metrics spike - https://phabricator.wikimedia.org/T207046 (10zeljkofilipin) [12:25:13] maintenance-disconnect-full-disks build 38585 integration-slave-jessie-1002: OFFLINE due to disk space [12:33:43] (03CR) 10Zfilipin: "I ran `check experimental` for 136fcf8 and other 4 jobs from the experimental pipeline ran, but wmf-sonar-scanner did not run. 🤔" [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [12:44:55] (03CR) 10Zfilipin: "WikimediaEvents does not use extension-quibble-composer template 😄" [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [12:50:13] maintenance-disconnect-full-disks build 38590 integration-slave-jessie-1002: OFFLINE due to disk space [12:53:27] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10Patch-For-Review, 10User-zeljkofilipin: Code health metrics spike - https://phabricator.wikimedia.org/T207046 (10zeljkofilipin) [12:53:58] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10Patch-For-Review, 10User-zeljkofilipin: Code health metrics spike - https://phabricator.wikimedia.org/T207046 (10zeljkofilipin) [13:01:29] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10Patch-For-Review, 10User-zeljkofilipin: Code health metrics spike - https://phabricator.wikimedia.org/T207046 (10zeljkofilipin) [13:06:36] (03CR) 10Zfilipin: "Tested at e4140fb" [integration/config] - 10https://gerrit.wikimedia.org/r/475470 (https://phabricator.wikimedia.org/T207046) (owner: 10Kosta Harlan) [13:08:25] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10Patch-For-Review, 10User-zeljkofilipin: Code health metrics spike - https://phabricator.wikimedia.org/T207046 (10zeljkofilipin) I have tested [[ https://integration.wikimedia.org/ci/job/wmf-sonar-scanner | wmf-sonar-scanner ]] job at [[ https://... [13:10:45] 10Gerrit, 10Developer-Advocacy: When uploading a new patch, reviewers should be added automatically - https://phabricator.wikimedia.org/T91190 (10hashar) I had the task closed since we have https://www.mediawiki.org/wiki/Git/Reviewers Yesterday we have enabled a plugin in Gerrit which automatically add review... [13:15:13] maintenance-disconnect-full-disks build 38595 integration-slave-jessie-1002: OFFLINE due to disk space [13:40:13] maintenance-disconnect-full-disks build 38600 integration-slave-jessie-1002: OFFLINE due to disk space [14:05:14] maintenance-disconnect-full-disks build 38605 integration-slave-jessie-1002: OFFLINE due to disk space [14:13:56] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Quibble, 10User-zeljkofilipin: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests - https://phabricator.wikimedia.org/T199116 (10phuedx) Ping @hashar, @zeljkofilipin: Has any progress be... [14:14:39] hashar: o/ [14:15:19] I have a admin module change (https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/482275/) that should be a noop, but I'd like to cherry pick it to deployment-prep first to see if in the cloud/labs realm anything happens [14:15:27] I don't expect anything weird but better safe than sorry [14:15:45] the change should allow us to deploy users without ssh keys if needed [14:15:56] (mostly useful only for hadoop now) [14:16:01] how does it sound? [14:18:40] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Backlog): Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Nuria) [14:18:45] 10Phabricator, 10Analytics, 10Analytics-Kanban, 10Wikimedia-Stream, 10Patch-For-Review: Move KafkaSSE development from Differential to Github - https://phabricator.wikimedia.org/T212420 (10Nuria) 05Open→03Resolved [14:29:17] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Quibble, 10User-zeljkofilipin: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests - https://phabricator.wikimedia.org/T199116 (10zeljkofilipin) As far as I know, this is blocked on @hash... [14:30:13] maintenance-disconnect-full-disks build 38610 integration-slave-jessie-1002: OFFLINE due to disk space [14:39:19] 10Release-Engineering-Team: [Bug] SSL failure doesn't cause browser test to be marked as failed - https://phabricator.wikimedia.org/T214047 (10phuedx) [14:40:27] 10Release-Engineering-Team: [Bug] SSL failure doesn't cause browser test to be marked as failed - https://phabricator.wikimedia.org/T214047 (10phuedx) [14:41:43] 10Release-Engineering-Team: [Bug] SSL failure doesn't cause browser test to be marked as failed - https://phabricator.wikimedia.org/T214047 (10phuedx) [14:47:37] 21:28:18 hostname "saucelabs.com" does not match the server certificate (OpenSSL::SSL::SSLError) eheh [14:47:40] hashar: thank you for your review + amendments of the sonar-scanner patch, and your explanatory comments as well :) [14:55:15] maintenance-disconnect-full-disks build 38615 integration-slave-jessie-1002: OFFLINE due to disk space [14:58:51] 10Release-Engineering-Team, 10Browser-Tests: [Bug] SSL failure doesn't cause browser test to be marked as failed - https://phabricator.wikimedia.org/T214047 (10hashar) `counterexample hostname "saucelabs.com" does not match the server certificate (OpenSSL::SSL::SSLError) ` From the stacktrace that comes from:... [14:59:08] kostajh: zeljkof and I paired on it this morning :)) [15:10:06] (03PS2) 10Hashar: docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 [15:14:09] 10Release-Engineering-Team, 10Browser-Tests: [Bug] SSL failure doesn't cause browser test to be marked as failed - https://phabricator.wikimedia.org/T214047 (10zeljkofilipin) p:05Triage→03Lowest Ruby framework was deprecated in October 2017, {J79}. I'm probably one of the most familiar with the framework,... [15:16:03] (03CR) 10Zfilipin: [C: 03+1] docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 (owner: 10Hashar) [15:20:13] maintenance-disconnect-full-disks build 38620 integration-slave-jessie-1002: OFFLINE due to disk space [15:36:31] (03PS3) 10Hashar: docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 [15:45:13] maintenance-disconnect-full-disks build 38625 integration-slave-jessie-1002: OFFLINE due to disk space [15:45:15] (03CR) 10Zfilipin: [C: 03+1] docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 (owner: 10Hashar) [15:48:35] zeljkof: for the changelog fix in https://gerrit.wikimedia.org/r/485005 , in a follow up change I will add a linter for the debian changelog files :) [15:49:04] kostajh: there was some mistakes in the changelog files, the format is rather pedantic and has to match a specific form. On Debian people use "dch" [15:49:25] kostajh: I will look at adding a linter for them and maybe there is a python version we can use for those that do not have the dch utility available [15:49:26] ;) [15:50:34] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10User-zeljkofilipin: Give a code health metrics talk at All Hands - https://phabricator.wikimedia.org/T207044 (10zeljkofilipin) @Aklapper as far as I can see from the schedule (see links in T207044#4884186) there should be time during Tech Day on W... [15:59:15] (03CR) 10Kosta Harlan: [C: 03+1] docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 (owner: 10Hashar) [16:00:28] hashar: thanks, yeah afaict dch is not available for macOS [16:00:51] btw hashar, is this page still a draft? https://www.mediawiki.org/wiki/Continuous_integration/Docker [16:05:43] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10User-zeljkofilipin: Give a code health metrics talk at All Hands - https://phabricator.wikimedia.org/T207044 (10Aklapper) > there should be time during Tech Day on Wednesday Oh thanks! Alright, there is a GDoc for Wed where we can add talks for `T... [16:10:13] maintenance-disconnect-full-disks build 38630 integration-slave-jessie-1002: OFFLINE due to disk space [16:14:59] 10Release-Engineering-Team (Kanban), 10Code-Health-Metrics, 10User-zeljkofilipin: Give a code health metrics talk at All Hands - https://phabricator.wikimedia.org/T207044 (10zeljkofilipin) Done! Thanks for the reminder! [16:18:54] 10Release-Engineering-Team (Watching / External), 10GitHub-Mirrors, 10Security-Team: Enforce 2FA for GitHub members - https://phabricator.wikimedia.org/T198810 (10MarcoAurelio) I see there are three listed blockers for this task. Two are visible to me and are resolved. If the third one is as well, maybe we c... [16:23:54] kostajh: no idea. Would probably need to be carefully reviewed/updated :/ [16:24:13] zeljkof: mind being bold and +2 ing the changelog fix at https://gerrit.wikimedia.org/r/485005 ? :) [16:27:20] (03PS2) 10Hashar: Add the Cite extension to Popups jobs [integration/config] - 10https://gerrit.wikimedia.org/r/484726 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [16:29:42] hashar: surez [16:30:03] (03CR) 10Zfilipin: [C: 03+2] docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 (owner: 10Hashar) [16:30:40] (03CR) 10Hashar: [C: 03+2] "The line was too long and flake8 (the python linter) complained." [integration/config] - 10https://gerrit.wikimedia.org/r/484726 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [16:31:53] (03Merged) 10jenkins-bot: docker: fix java8-sonar-scanner/changelog [integration/config] - 10https://gerrit.wikimedia.org/r/485005 (owner: 10Hashar) [16:32:30] (03Merged) 10jenkins-bot: Add the Cite extension to Popups jobs [integration/config] - 10https://gerrit.wikimedia.org/r/484726 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [16:33:10] (03CR) 10Hashar: [C: 03+2] "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/484726 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [16:35:14] maintenance-disconnect-full-disks build 38635 integration-slave-jessie-1002: OFFLINE due to disk space [16:38:17] hashar / zeljkof any issues with https://gerrit.wikimedia.org/r/#/c/integration/config/+/481570/ ? [16:44:25] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata-Campsite: Run ArticlePlaceholder tests as part of Wikibase CI - https://phabricator.wikimedia.org/T213815 (10Addshore) [16:44:38] 10Continuous-Integration-Config, 10Wikidata, 10wikidata-tech-focus, 10Patch-For-Review, 10User-Addshore: Add more Wikibase extensions to gatedextensions - https://phabricator.wikimedia.org/T204153 (10Addshore) [16:44:41] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata-Campsite: Run ArticlePlaceholder tests as part of Wikibase CI - https://phabricator.wikimedia.org/T213815 (10Addshore) p:05Triage→03Normal [16:45:06] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Run ArticlePlaceholder tests as part of Wikibase CI - https://phabricator.wikimedia.org/T213815 (10Addshore) This was missed but should have been moved to the iteration as we decided in the breakdown [16:48:06] 10Continuous-Integration-Config, 10Wikidata, 10wikidata-tech-focus, 10Patch-For-Review, 10User-Addshore: Add more Wikibase extensions to gatedextensions - https://phabricator.wikimedia.org/T204153 (10Addshore) Of the things I see in T204153#4580923 we should add: - WikimediaBadges (few or no tests, but... [16:48:12] Hauskatze: looks good to me, but I would leave it to hashar to take a look, he's more familiar with that [16:49:12] ok, tnx [16:55:10] 10Gerrit, 10Developer-Advocacy: When uploading a new patch, reviewers should be added automatically - https://phabricator.wikimedia.org/T91190 (10hashar) I have published a blog explaining the Gerrit review by blame plugin as well as other manual way to find reviewers: J139: {J139} [16:55:18] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10hashar) I have published a blog explaining the Gerrit review by blame plugin as well as other manual way to find reviewers:... [16:58:23] 10Continuous-Integration-Config, 10Wikidata, 10User-Addshore: [Task] Wikibase: Set up Jenkins to run unit tests also against repo without client - https://phabricator.wikimedia.org/T114690 (10Addshore) 05Open→03Resolved a:03Addshore We have had special jobs for this for quite some time. In T188717 ther... [17:00:15] maintenance-disconnect-full-disks build 38640 integration-slave-jessie-1002: OFFLINE due to disk space [17:05:20] that reminds me, i will need to have a look at making a PG ui for that plugin hashar :) [17:07:53] 10Continuous-Integration-Config, 10MediaWiki-General-or-Unknown, 10Multi-Content-Revisions, 10Core Platform Team ( Code Health (TEC13)), and 3 others: Some PHPUnit tests consistently fail when collecting coverage report - https://phabricator.wikimedia.org/T183777 (10Addshore) Updated. Everything is green?... [17:15:35] (03PS1) 10Hashar: docker: test changelog are valid [integration/config] - 10https://gerrit.wikimedia.org/r/485065 [17:16:31] (03PS2) 10Hashar: docker: test changelog are valid [integration/config] - 10https://gerrit.wikimedia.org/r/485065 [17:17:42] (03CR) 10Hashar: "I have added a test to ensure changelog files are properly formatted: https://gerrit.wikimedia.org/r/#/c/integration/config/+/485065/" [integration/config] - 10https://gerrit.wikimedia.org/r/485005 (owner: 10Hashar) [17:19:00] (03CR) 10Hashar: "The test can be run using:" [integration/config] - 10https://gerrit.wikimedia.org/r/485065 (owner: 10Hashar) [17:23:59] (03PS1) 10Hashar: (DO NOT SUBMIT) inspect docker deps [integration/config] - 10https://gerrit.wikimedia.org/r/485067 [17:25:12] maintenance-disconnect-full-disks build 38645 integration-slave-jessie-1002: OFFLINE due to disk space [17:25:47] (03CR) 10jerkins-bot: [V: 04-1] (DO NOT SUBMIT) inspect docker deps [integration/config] - 10https://gerrit.wikimedia.org/r/485067 (owner: 10Hashar) [17:26:15] (03PS2) 10Hashar: (DO NOT SUBMIT) inspect docker deps [integration/config] - 10https://gerrit.wikimedia.org/r/485067 [17:28:01] (03CR) 10jerkins-bot: [V: 04-1] (DO NOT SUBMIT) inspect docker deps [integration/config] - 10https://gerrit.wikimedia.org/r/485067 (owner: 10Hashar) [17:33:14] (03PS3) 10Hashar: (DO NOT SUBMIT) inspect docker deps [integration/config] - 10https://gerrit.wikimedia.org/r/485067 [17:50:17] maintenance-disconnect-full-disks build 38650 integration-slave-jessie-1002: OFFLINE due to disk space [18:03:30] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team, 10Zuul: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10hashar) [18:07:42] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team, 10Zuul: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10hashar) And the original JavaScript to do the magic looks like: https://github.com/openstack-infra/system-config/commit... [18:10:44] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team, 10Zuul: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10Paladox) It's better if you build a polygerrit plugin then spending time on a GWTUI plugin. GWTUI has been removed upst... [18:15:13] maintenance-disconnect-full-disks build 38655 integration-slave-jessie-1002: OFFLINE due to disk space [18:16:52] Gerrit at some point created a local user record for the developer account "Striker test 2017-01-25 01". The account doesn't own any patches or reviews and as far as I know has never actually been used to authenticate to gerrit. It does however share an email address with my real gerrit account. I'm wondering how to make gerrit forget about the account so that it stops showing up in typeahead searches and being added to patches by new [18:16:52] reviewers-by-blame plugin. [18:20:14] huh, db fiddling I'd guess [18:26:15] You can disable the account bd808 greg-g [18:26:20] through inactive [18:27:03] paladox: do you have the magic admin powers needed to do that? [18:27:11] nope [18:27:22] * bd808 is a mortal in gerrit [18:27:28] i think most of releng does (and any one in ldap/ops) [18:27:58] https://gerrit-review.googlesource.com/Documentation/rest-api-accounts.html#delete-active [18:29:53] curl --user username:password -X DELETE https://gerrit.wikimedia.org/r/a/accounts//active [18:30:01] That's some pretty fancy HTTP verb usage to make it "restful" [18:30:17] heh [18:30:53] the password can either be the generated one done through the ui, or your ldap pass [18:34:34] you'll want it to be "https://gerrit.wikimedia.org/r/a/accounts/Striker+test+2017-01-25+01/active" [18:34:38] encoded [18:40:15] maintenance-disconnect-full-disks build 38660 integration-slave-jessie-1002: OFFLINE due to disk space [19:04:41] 10Release-Engineering-Team, 10Operations, 10Recommendation-API, 10Research, and 2 others: Recommendation API improvements - https://phabricator.wikimedia.org/T213222 (10bmansurov) [19:05:13] maintenance-disconnect-full-disks build 38665 integration-slave-jessie-1002: OFFLINE due to disk space [19:26:42] could also, I assume, use ssh api: ssh gerrit.wikimedia.org -p 29418 gerrit set-account --inactive 'Striker test 2017-01-25 01' [19:27:52] I think that's the new format for disabling an account, right (cc paladox ) [19:27:59] yep [19:28:05] can either do it through rest api [19:28:06] or ssh [19:28:13] thcipriani ^^ [19:28:23] * thcipriani *nods* [19:28:27] https://gerrit-review.googlesource.com/Documentation/cmd-set-account.html [19:28:37] set-account does offer a lot of options [19:28:50] yup [19:29:36] I noticed that my account has two identities, one as I registered it, and the other in all lowercase [19:30:12] maintenance-disconnect-full-disks build 38670 integration-slave-jessie-1002: OFFLINE due to disk space [19:34:37] !log integration-slave-jessie-1002:sudo rm -rf /srv/jenkins-workspace/workspace/* and bring back online [19:34:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:49:27] (03PS3) 10Jforrester: Add WikibaseMediaInfo to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/480463 (https://phabricator.wikimedia.org/T204153) [19:58:14] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10Tgr) >>! In T101131#4887060, @Peachey88 wrote: > ideally in the long term we should request automated actions like that are... [20:01:39] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Developer-Wishlist (2017), 10Patch-For-Review: Enable Gerrit reviewers-by-blame plugin - https://phabricator.wikimedia.org/T101131 (10greg) >>! In T101131#4890004, @Tgr wrote: >>>! In T101131#4887060, @Peachey88 wrote: >> ideally in the long term we should r... [20:02:33] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (Backlog), 10Zuul: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10greg) [20:03:05] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (Backlog), 10Zuul: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10greg) p:05Triage→03Normal [20:05:13] 10Release-Engineering-Team (Backlog), 10Browser-Tests: [Bug] SSL failure doesn't cause browser test to be marked as failed - https://phabricator.wikimedia.org/T214047 (10greg) [20:08:44] (03CR) 10Krinkle: [C: 03+1] docker: test changelog are valid [integration/config] - 10https://gerrit.wikimedia.org/r/485065 (owner: 10Hashar) [20:11:11] 10Release-Engineering-Team (Watching / External), 10GitHub-Mirrors, 10Security-Team: Enforce 2FA for GitHub members - https://phabricator.wikimedia.org/T198810 (10greg) >>! In T198810#4888563, @MarcoAurelio wrote: > I see there are three listed blockers for this task. Two are visible to me and are resolved.... [20:13:26] 10Release-Engineering-Team (Kanban): Gather and Analyze Information Around Developer Tooling Woes - https://phabricator.wikimedia.org/T212454 (10jeena) On Jan. 8, I sent an email to the engineering and wikitech-l mailing lists to solicit participants for interviews on their local dev environment. There was some... [20:18:07] (03CR) 10Kosta Harlan: [C: 03+1] "Looks fine, maybe I've missed it, but could we also document somewhere in this repo that you need to use dch to generate the changelog?" [integration/config] - 10https://gerrit.wikimedia.org/r/485065 (owner: 10Hashar) [20:21:39] 10Release-Engineering-Team, 10Performance-Team: Create gerrit bot for git pushes to specific repo from prod machines - https://phabricator.wikimedia.org/T214015 (10Krinkle) We should probably follow a similar pattern to localisation bot and libraryupgrade-bot. Specifically, we'd grant the bot account CR+2 per... [20:29:01] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.33.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T206667 (10dduvall) 05Open→03Resolved [21:46:02] why is Gerrit adding reviewers automatically? it's causing lots of confusion to a lot of people [21:46:33] jdlrobson hi, it's due to reviewers by blame [21:46:43] so if a user touched the file (line) then they are added. [21:46:55] hashar has a blog post on this [21:46:56] mm could this have been made opt in? [21:47:06] jdlrobson https://phabricator.wikimedia.org/phame/post/view/139/gerrit_now_automatically_adds_reviewers/ [21:47:21] jdlrobson we have filed a issue upstream to add support for that [21:47:36] * greg-g sends an email to wikitech-l [21:49:17] thanks paladox [21:49:26] your welcome :) [21:49:28] i was wondering why i was getting reviews from volunteers from 6 years ago [21:49:37] and i had a lot of Gerrit notifications today [21:49:41] i'll follow up on the blog post [21:49:44] ok [21:50:54] thcipriani https://bugs.chromium.org/p/gerrit/issues/detail?id=10326 (seems there's a bug in 2.16) [21:54:48] 10Gerrit: reviewers-by-blame plugin: (a short description) - https://phabricator.wikimedia.org/T214097 (10bmansurov) [21:55:10] 10Gerrit: reviewers-by-blame plugin: only new reviewers should be pinged - https://phabricator.wikimedia.org/T214097 (10bmansurov) [21:56:45] 10Gerrit: reviewers-by-blame plugin: only recent reviewers should be pinged - https://phabricator.wikimedia.org/T214097 (10bmansurov) [21:58:06] * paladox will look into how to support whitelisting users in reviewers-by-blame in a bit. [21:59:19] thanks paladox [21:59:27] your welcome :) [22:20:51] (03CR) 10Thcipriani: Add npm job for recommendation-api service (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/483225 (https://phabricator.wikimedia.org/T213222) (owner: 10Bmansurov) [22:51:41] (03CR) 10Bmansurov: Add npm job for recommendation-api service (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/483225 (https://phabricator.wikimedia.org/T213222) (owner: 10Bmansurov) [22:59:30] (03PS2) 10Bmansurov: Add npm job for recommendation-api service [integration/config] - 10https://gerrit.wikimedia.org/r/483225 (https://phabricator.wikimedia.org/T213222) [23:00:33] (03CR) 10jerkins-bot: [V: 04-1] Add npm job for recommendation-api service [integration/config] - 10https://gerrit.wikimedia.org/r/483225 (https://phabricator.wikimedia.org/T213222) (owner: 10Bmansurov) [23:01:55] (03PS3) 10Bmansurov: Add npm job for recommendation-api service [integration/config] - 10https://gerrit.wikimedia.org/r/483225 (https://phabricator.wikimedia.org/T213222) [23:02:54] (03CR) 10jerkins-bot: [V: 04-1] Add npm job for recommendation-api service [integration/config] - 10https://gerrit.wikimedia.org/r/483225 (https://phabricator.wikimedia.org/T213222) (owner: 10Bmansurov) [23:17:09] 10Gerrit, 10Developer-Advocacy: When uploading a new patch, reviewers should be added automatically - https://phabricator.wikimedia.org/T91190 (10MGChecker) 05Invalid→03Resolved