[00:16:21] thcipriani: if this quibble, then most probably that is automatically registered based on the flag Antoine added to install.php for MW, which takes anything it sees in extensions/ [00:16:50] This, however, make it unsuitable for local development where you might have 100s of incompatible or outdated extensions cloned, but only a few actually in your LocalSettings.php [00:16:50] Krinkle: this is quibble, thanks for that insight ^ SMalyshev [00:17:26] It creates a new LocalSettings.php file on each run. [00:17:38] I did notice that [00:17:55] seems like the kind of thing you could put behind a command line flag [00:18:16] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.33.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T206668 (10Jdforrester-WMF) [00:19:21] if the idea is to use quibble to test locally as well as in CI [00:27:41] (03PS1) 10Krinkle: Replace python-minimal with python (full) in node10 dockerfiles [integration/config] - 10https://gerrit.wikimedia.org/r/486195 (https://phabricator.wikimedia.org/T213944) [00:27:50] Krinkle: Want to switch core to node10 now? [00:28:03] James_F: Blocked on T213944) [00:28:03] T213944: Jenkins jobs for npm-test fail on project with deps on node-gyp which requires python2.7 - https://phabricator.wikimedia.org/T213944 [00:28:23] Oh, lame. [00:28:36] James_F: I'm switching a few more non-mw repos first, among them performance/docroot, which also failed on the above. [00:28:44] This is the selenium video-taking bit, then? [00:29:00] Needed for it, yes. [00:29:12] Krinkle: mediawiki/services/mobileapps[/deploy] would love to switch to node10, if you're looking for volunteers. [00:29:14] The node-gyp use is from node-fibers, which is that weird wdio thing that makes promises appear synchronous. [00:29:28] * James_F nods. [00:29:38] and wdio, for selenium indeed [00:36:15] If you return null in a js function and call this.function (will it fail with undefined function?) [00:48:29] (03CR) 10Krinkle: "Compiling locally (will take a while), and then to test out with a repo locally, and then to update the JJB references before merging." [integration/config] - 10https://gerrit.wikimedia.org/r/486195 (https://phabricator.wikimedia.org/T213944) (owner: 10Krinkle) [00:49:07] paladox: If you call foo().bar() where foo() returns null, that will produce an exception yes. [00:49:18] ah ok [00:49:53] JavaScript tolerates 1 level of undefined-ness, and only for property access, not for function calling. E.g. var x = {}. x.foo does not create an exception ,it just returns undefined for you. [00:50:14] but x.foo.bar is an exception (property of non-object), and x.foo() is also an exception (cannot call undefined non-function) [00:50:24] thanks [00:50:44] though in this case it seems to be right [00:57:05] * paladox has found a annoying bug in the inline editor. [00:57:35] so im going to try and fix that as it's making me create tons of tiny patches only because it restores a prevous copy from the storage [01:35:10] (03PS2) 10Krinkle: Replace python-minimal with python (full) in node10 dockerfiles [integration/config] - 10https://gerrit.wikimedia.org/r/486195 (https://phabricator.wikimedia.org/T213944) [01:36:01] (03CR) 10Krinkle: [C: 03+1] "Tested out node10-test-browser:0.2.3. locally on performance/docroot. Previously failed with node-gyp errors, now passes." [integration/config] - 10https://gerrit.wikimedia.org/r/486195 (https://phabricator.wikimedia.org/T213944) (owner: 10Krinkle) [01:38:21] found the bug [01:38:27] after a year heh :P [01:45:36] (03CR) 10Krinkle: [C: 03+2] "Affected per jjb-diff output:" [integration/config] - 10https://gerrit.wikimedia.org/r/486195 (https://phabricator.wikimedia.org/T213944) (owner: 10Krinkle) [01:47:39] (03CR) 10Krinkle: [V: 03+2 C: 03+2] Replace python-minimal with python (full) in node10 dockerfiles [integration/config] - 10https://gerrit.wikimedia.org/r/486195 (https://phabricator.wikimedia.org/T213944) (owner: 10Krinkle) [01:48:38] (03CR) 10Krinkle: [V: 03+2 C: 03+2] "(bypassed because I forgot deploy_docker only works post-merge, to minimise downtime of the affected jobs)" [integration/config] - 10https://gerrit.wikimedia.org/r/486195 (https://phabricator.wikimedia.org/T213944) (owner: 10Krinkle) [01:56:41] 10Continuous-Integration-Config, 10JavaScript, 10Patch-For-Review: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects - https://phabricator.wikimedia.org/T211784 (10Krinkle) [01:56:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-ORES, and 5 others: Jenkins jobs for npm-test fail on project with deps on node-gyp which requires python2.7 - https://phabricator.wikimedia.org/T213944 (10Krinkle) 05Ope... [02:52:17] https://gerrit-review.googlesource.com/c/gerrit/+/211512/7/polygerrit-ui/app/elements/shared/gr-storage/gr-storage.js [02:52:24] lol, it was a one liner fix :) [04:47:42] 10Project-Admins: Create MediaWiki tag(s) for page data (access, storage, updates) - https://phabricator.wikimedia.org/T206284 (10Krinkle) @Daniel I think we should keep change-tagging and logging separate for now. They seem to be well-contained features that don't intersect with RevisionStore, BlobStore, or Pag... [04:47:43] 10Project-Admins: Create MediaWiki tag(s) for page data (access, storage, updates) - https://phabricator.wikimedia.org/T206284 (10Krinkle) p:05Triage→03Normal a:03Krinkle [04:47:49] 10Project-Admins: Create MediaWiki tag(s) for page data (access, storage, updates) - https://phabricator.wikimedia.org/T206284 (10Krinkle) (self-assigning so that it won't be forgotten.) [05:38:26] Something weird is going on with https://phabricator.wikimedia.org/maniphest/task/edit/204756/ can't seem to be able to view it: https://phabricator.wikimedia.org/T204756, but was able to see it in a column on a workboard and edit it. [05:38:32] > Construction of a DateTime() with epoch '2018-09-18' raised an exception. [06:01:25] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10Wikimedia-production-error (Shared Build Failure): Jenkins build for MediaWiki should fail when "PHP Warning" is emitted - https://phabricator.wikimedia.org/T214552 (10Krinkle) [06:01:56] Krinkle: about the quibble thing - looks like whatever it's supposed to do is not working, since the tests don't seem to be running... any idea how can I check if the extension is actually being loaded? [06:02:29] SMalyshev: Can you dump some context for how you're invoking it? [06:02:39] which mw branch and extension? [06:03:00] Krinkle: it's WIkibaseCirrusSearch... I just use extension-quibble job on CI [06:03:11] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/+/447954 [06:03:38] the thing is, it passes, but it shouldn't since I purposedly broke a test in the ext to see if the tests are being run [06:03:57] so looks like the tests for extension itself aren't being run [06:04:47] I have one idea though... it declares dependencies on Wikibase... and Wikibase is old extension [06:04:55] this probably doesn't work? [06:24:25] SMalyshev: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/31900/artifact/log/ > LocalSettings [06:24:36] https://gist.github.com/Krinkle/968a3f8e8455f99e57ba8d3bf9f3894d [06:25:09] 22:08:21 Fatal error: unknown class Wikibase\Search\Elastic\Tests\Fields\SearchFieldTestCase in /workspace/src/extensions/WikibaseCirrusSearch/tests/phpunit/Fields/DescriptionFieldTest.php on line 19 [06:25:26] well yes that's new [06:25:39] this seems to finally load it [06:25:51] what did you change btw? [06:26:22] legoktm: I removed dependency on Wikibase & CirrusSeach [06:26:35] looks like extension.json cant do dependencies on old extensions [06:27:01] legoktm: could you explain the autoload part though? [06:27:18] extension.json can only do dependencies on things that use extension.json [06:27:59] so there's no way to make dependency on Wikibase now? [06:28:12] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10Wikimedia-production-error (Shared Build Failure): Jenkins build for MediaWiki should fail when "PHP Warning" is emitted - https://phabricator.wikimedia.org/T214552 (10Legoktm) The warning comes before the "PHPUnit 6.5.13" line, which I think means i... [06:28:37] you can just do it manually in an ExtensionFunction or something [06:28:43] or a callback probably [06:28:51] and poke Wikibase and CirrusSearch maintainers to migrate :-) [06:29:20] SMalyshev: which part about autoloading? [06:29:54] legoktm: not using composer autoloading... would it still work locally for me without it? [06:30:12] you're only ever using the extension through MW right? [06:30:33] legoktm: I am not sure what you mean by "using through MW" [06:30:43] does running phpunit tests count as using through MW? [06:30:51] yes [06:30:56] then probably yes [06:30:59] because you use MW's phpunit.php [06:31:24] so should be fine then :) [06:33:14] I wonder though since Cirrus & WIkibase are not going extension.json anytime soon AFAIK, wouldn't it make sense for newer extensions to be able to depend on them? [06:33:39] it's not some random plugins, they underly big pieces of our sites... [06:34:34] yeah unit tests seem to run without autoload thingy... [06:58:45] ok looks like I got phpunit stuck... it's over 25 mins and doesn't seem to make any progress... https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/31928/console [06:59:07] in fact, no progress for last 20 mins [07:54:02] 10Release-Engineering-Team (Kanban), 10User-greg: Onboarding Brennen - https://phabricator.wikimedia.org/T214556 (10greg) p:05Triage→03Normal [08:35:02] 10Beta-Cluster-Infrastructure: Puppet failure on deployment-prometheus01.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T214558 (10dcausse) [09:01:25] (03PS1) 10Hashar: Debian glue for operations/debs/prometheus-storage-migrator [integration/config] - 10https://gerrit.wikimedia.org/r/486225 [09:01:40] (03CR) 10Hashar: [C: 03+2] Debian glue for operations/debs/prometheus-storage-migrator [integration/config] - 10https://gerrit.wikimedia.org/r/486225 (owner: 10Hashar) [09:04:36] (03Merged) 10jenkins-bot: Debian glue for operations/debs/prometheus-storage-migrator [integration/config] - 10https://gerrit.wikimedia.org/r/486225 (owner: 10Hashar) [09:06:23] paladox: my dashboards don't work with the new ui we're running (eg: [09:06:25] https://gerrit.wikimedia.org/r/#/dashboard/?title=RelEng+Pending&Mukunda+Modell=owner:20after4+status:open&Dan+Duvall=owner:Dduvall+status:open&Greg+Grossmeier=owner:Greg%20Grossmeier+status:open&Antoine+Musso=owner:Hashar+status:open&Jeena+Huneidi=owner:Jeena%20Huneidi+status:open&JR+Branaa=owner:Jrbranaa+status:open&Lars+Wirzenius=owner:Lars%20Wirzenius+status:open&Tyler+Cipriani=owner:thcipriani+ [09:06:27] status:open&Zeljko+Filipin=owner:Zfilipin+status:open ); is the syntax changed or is the feature gone? [09:06:30] ugh, bad paste [09:06:37] ;) [09:06:59] we should create a release-engineering group in Gerrit I guess :D [09:07:00] paladox: the url again: https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/Dashboards#Code-review [09:07:04] we have one :) [09:07:22] https://gerrit.wikimedia.org/r/#/admin/groups/1484,members [09:07:43] maybe the dhasboard url is different with the new ui (polygerrit) [09:07:51] yeah, that's my assumption [09:08:07] yeah works with the old ui [09:09:01] 10Beta-Cluster-Infrastructure, 10monitoring, 10Puppet: Puppet failure on deployment-prometheus01.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T214558 (10greg) [09:10:19] https://bugs.chromium.org/p/gerrit/issues/detail?id=3941 is about polygerrit not supporting user dashboard bah [09:11:08] though there is https://gerrit.wikimedia.org/r/Documentation/user-dashboards.html [09:11:16] and the url looks fine [09:12:18] "Construction of a DateTime() with epoch '2018-09-18' raised an exception." weird, what I get for https://phabricator.wikimedia.org/T204756 and https://phabricator.wikimedia.org/T204757 [09:12:47] hashar: that documentation documents the old ui syntax, iow: what I used :) [09:14:53] upstream's bug 1, I suppose [09:16:36] for the dashboard in polygerrit, I am afraid that is not yet supporteD? :( [09:20:08] ah https://gerrit-review.googlesource.com/c/gerrit/+/129891 [09:20:18] included in: v2.16 v2.16-rc0 v2.16-rc1 v2.16-rc2 v2.16-rc3 v2.16.1 v2.16.2 v2.16.3 [09:22:32] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.3 - https://phabricator.wikimedia.org/T200739 (10hashar) [09:23:00] greg-g: so yeah dashboards are not supported by PolyGerrit in Gerrit 2.15 but will be with 2.16. It is listed as an improvement in our task to upgrade to Gerrit 2.16 [09:28:24] ack [09:31:30] (03Abandoned) 10WMDE-Fisch: Enable reference previews [integration/jenkins] - 10https://gerrit.wikimedia.org/r/485793 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [09:47:09] 10Continuous-Integration-Config, 10Operations, 10Puppet: puppet.git rake fails with ruby 2.5 - https://phabricator.wikimedia.org/T208566 (10Joe) There is a specific reason why the recommended method for running our spec tests includes the use of `rbenv` https://wikitech.wikimedia.org/wiki/Puppet_coding#Insta... [18:02:47] (03CR) 10Umherirrender: "'nested_parenthesis' is the open and closing parenthesis of the if condition, not of the if body, so $scopeCloser is already the end of th" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/486033 (https://phabricator.wikimedia.org/T203800) (owner: 10Thiemo Kreuz (WMDE)) [18:11:58] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Gate pipeline build failed on apps/android/wikipedia - https://phabricator.wikimedia.org/T214497 (10Dbrant) whoops, never mind, I got it: https://gerrit.wikimedia.org/r/486337 [18:25:26] 10MediaWiki-Codesniffer, 10good first bug: MediaWiki Codesniffer not catching irrelevant characters after PHPDoc return types - https://phabricator.wikimedia.org/T214591 (10Umherirrender) It is looking for punctations (regex class `\p{P}` which include \ when looking at https://www.fileformat.info/info/unicode... [18:40:57] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban): Document the process for tagging, signing and preparing a tarball release. - https://phabricator.wikimedia.org/T211655 (10mmodell) [18:41:07] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban): Document the process for tagging, signing and preparing a tarball release. - https://phabricator.wikimedia.org/T211655 (10mmodell) 05Open→03Resolved [18:41:10] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.32-notes, 10MW-1.32-release, 10User-MacFan4000: Release MW 1.32 - https://phabricator.wikimedia.org/T207529 (10mmodell) [18:41:13] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10Security: Streamline/automate MW tarball security release process - https://phabricator.wikimedia.org/T156445 (10mmodell) [18:46:49] 10Project-Admins: Create user board for DannyS712 - https://phabricator.wikimedia.org/T214621 (10DannyS712) [18:55:37] 10Phabricator, 10Release-Engineering-Team: Change default search query for tasks - https://phabricator.wikimedia.org/T214579 (10greg) Oops, those are mine. I wonder if I can convert them to non-global? Their mostly just used on my own personal dashboard.... [18:57:36] paladox: you finally did it. i switched to polygerrit [18:59:02] i will force myself to stay on it to rewire my brain .. to get used to "new stuff is on top" :p [18:59:29] :) [19:00:03] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Gate pipeline build failed on apps/android/wikipedia - https://phabricator.wikimedia.org/T214497 (10Dbrant) 05Open→03Resolved a:03Dbrant ...and we're good. [19:00:06] "but if the old stuff is at the bottom and not at the top as a constant reminder you still have to do it.. you will more likely never do it " [19:00:11] that is the only concern, heh [19:00:54] the color scheme and the little icons are cool [19:01:22] (03CR) 1020after4: [C: 03+1] Docs: remove references to differential [tools/scap] - 10https://gerrit.wikimedia.org/r/486321 (owner: 10Thcipriani) [19:01:22] yeh [19:01:31] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Experiment with continuous deployment using Blubberoid - https://phabricator.wikimedia.org/T214158 (10jeena) Unless there is some part I am missing, I don't think we'll need to be changing any k8s configuration regarding load balancers, etc. If we use... [19:12:38] paladox: i find myself typing "check experimental" and think "could this be a button i click" [19:12:47] Oh yes [19:12:51] it could be a button [19:13:25] next to the other button "recheck" ? [19:13:31] we can have recheck too [19:13:36] we can do anything [19:13:43] yay , heh :) [19:13:47] the power of FOSS [19:13:57] heh [19:14:06] i've already been working on buttons! [19:14:14] (not related to this but something else) [19:14:20] cool [19:15:10] i think it requires 2.16 for it to work in polygerrit [19:16:38] i see. aanother reason for upgrading. ok [19:17:04] yup [19:22:05] +100 to buttons [19:22:26] it's very easy once you know how to [19:28:24] paladox: I don't see any recheck/check experimental buttons on PolyGerrit, or is that a planned new feature? [19:28:34] it's a planned new feature [19:28:37] we need to make a plugin [19:28:37] chachi [19:28:52] hey, so i made this ticket about the "check experimental" jenkins-bot check but i have no idea how to tag it https://phabricator.wikimedia.org/T214629 [19:29:09] I still have to get used to this new UI design. I feel like I'm logged out lol [19:29:24] integration-config mutante [19:29:26] i think [19:29:41] thanks [19:29:44] Hauskatze heh [19:29:44] 10Continuous-Integration-Config: jenkins-bot puppet-compiler-test may report SUCCESS though compiling failed - https://phabricator.wikimedia.org/T214629 (10Paladox) [19:29:53] :) [19:31:06] 10Continuous-Integration-Config, 10Operations: jenkins-bot puppet-compiler-test may report SUCCESS though compiling failed - https://phabricator.wikimedia.org/T214629 (10Dzahn) [19:36:11] 10Continuous-Integration-Config, 10Operations: jenkins-bot puppet-compiler-test may report SUCCESS though compiling failed - https://phabricator.wikimedia.org/T214629 (10Dzahn) p:05Triage→03Low prio isn't high since this is clearly labelled as experimental and the feature itself is really cool to have :) t... [19:54:54] 10Phabricator, 10Release-Engineering-Team (Backlog): Change default search query for tasks - https://phabricator.wikimedia.org/T214579 (10greg) p:05Triage→03Low [19:56:33] 10Gerrit: Create a plugin that add's recheck/check experimental as buttons to PolyGerrit ui's - https://phabricator.wikimedia.org/T214631 (10Paladox) [19:58:46] 10Gerrit: Create a plugin that add's recheck/check experimental as buttons to PolyGerrit ui's - https://phabricator.wikimedia.org/T214631 (10Paladox) a:03Paladox [20:00:30] Do we need any other buttons? [20:00:42] We can use the wikimedia plugin we have already to support this :) [20:45:33] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.33.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T206668 (10mmodell) [20:47:58] 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn) >>! In T190568#4903583, @mmodell wrote: > https://wikitech.wikimedia.org/wiki/Phabricator/Meeting_Notes/2019... [20:49:41] 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations, 10serviceops, 10Patch-For-Review: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Paladox) "* 429 Too Many Requests" someone will want to whitelist deploy1001 ip so it's not hit by... [20:49:46] 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations, 10serviceops, 10Patch-For-Review: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn) [20:58:42] 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Operations, 10serviceops, 10Patch-For-Review: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn) [21:41:25] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.33.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T206670 (10mmodell) a:03mmodell [21:41:45] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.33.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T206668 (10mmodell) 05Open→03Resolved [21:43:08] twentyafterfour: good work [21:43:24] :) thanks [21:43:31] fairly uneventful train this week [22:55:18] maintenance-disconnect-full-disks build 40727 integration-slave-jessie-1002 (/srv: 95%): OFFLINE due to disk space [23:06:16] 10Project-Admins: Create user board for DannyS712 - https://phabricator.wikimedia.org/T214621 (10MGChecker) a:03MGChecker [23:10:14] maintenance-disconnect-full-disks build 40730 integration-slave-jessie-1002: OFFLINE due to disk space [23:10:51] 10Project-Admins: Create user board for DannyS712 - https://phabricator.wikimedia.org/T214621 (10MGChecker) 05Open→03Resolved Requested public project #User-DannyS712 has been created: https://phabricator.wikimedia.org/project/view/3849/ Please encourage interested people to visit the project and to join th... [23:35:12] maintenance-disconnect-full-disks build 40735 integration-slave-jessie-1002: OFFLINE due to disk space