[00:51:48] 10Phabricator, 10Release-Engineering-Team (Kanban): Mass-edits via @Phabricator_maintenance account stop after 11 tasks - https://phabricator.wikimedia.org/T205258 (10mmodell) [04:19:34] 10Phabricator, 10Release-Engineering-Team (Kanban): Mass-edits via @Phabricator_maintenance account stop after 11 tasks - https://phabricator.wikimedia.org/T205258 (10greg) [04:44:05] 10Release-Engineering-Team (Kanban), 10User-greg: Onboarding Brennen - https://phabricator.wikimedia.org/T214556 (10greg) [05:17:57] (03PS4) 10Legoktm: Adjust warning text for PhpunitAnnotations.NotClassTrait sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481650 (https://phabricator.wikimedia.org/T209486) (owner: 10Umherirrender) [05:18:02] (03CR) 10Legoktm: [C: 03+2] Adjust warning text for PhpunitAnnotations.NotClassTrait sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481650 (https://phabricator.wikimedia.org/T209486) (owner: 10Umherirrender) [05:18:42] (03Merged) 10jenkins-bot: Adjust warning text for PhpunitAnnotations.NotClassTrait sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481650 (https://phabricator.wikimedia.org/T209486) (owner: 10Umherirrender) [05:19:17] (03CR) 10jenkins-bot: Adjust warning text for PhpunitAnnotations.NotClassTrait sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481650 (https://phabricator.wikimedia.org/T209486) (owner: 10Umherirrender) [08:26:24] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: Generate PHP code coverage reports for extensions - https://phabricator.wikimedia.org/T71685 (10Legoktm) [08:26:28] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Test-Coverage: generate Wikibase.git code coverage on Jenkins - https://phabricator.wikimedia.org/T88434 (10Legoktm) 05Open→03Stalled This is blocked on Wikibase adopting the standard directory layout, spe... [08:27:49] (03CR) 10Legoktm: [C: 03+2] Enable phan checks for FileExporter [integration/config] - 10https://gerrit.wikimedia.org/r/486439 (owner: 10WMDE-Fisch) [08:29:36] (03CR) 10Legoktm: "> Patch Set 4: Code-Review-1" [integration/config] - 10https://gerrit.wikimedia.org/r/479738 (owner: 10Urbanecm) [08:29:46] (03Merged) 10jenkins-bot: Enable phan checks for FileExporter [integration/config] - 10https://gerrit.wikimedia.org/r/486439 (owner: 10WMDE-Fisch) [08:30:04] (03CR) 10Legoktm: [C: 03+2] Add dependencies for AbuseFilter [integration/config] - 10https://gerrit.wikimedia.org/r/481570 (owner: 10Daimona Eaytoy) [08:31:40] (03CR) 10Legoktm: [C: 03+2] Add AbuseFilter as dependency of SpamBlacklist [integration/config] - 10https://gerrit.wikimedia.org/r/481571 (owner: 10Daimona Eaytoy) [08:31:56] (03Merged) 10jenkins-bot: Add dependencies for AbuseFilter [integration/config] - 10https://gerrit.wikimedia.org/r/481570 (owner: 10Daimona Eaytoy) [08:33:29] (03Merged) 10jenkins-bot: Add AbuseFilter as dependency of SpamBlacklist [integration/config] - 10https://gerrit.wikimedia.org/r/481571 (owner: 10Daimona Eaytoy) [08:34:07] (03CR) 10Legoktm: [C: 04-1] "This should be the email registered with your Gerrit account, which appears to be shhilson@curse.com. Also please keep the lists in alphab" [integration/config] - 10https://gerrit.wikimedia.org/r/485967 (owner: 10ValeryanM) [08:35:40] !log deploying https://gerrit.wikimedia.org/r/486439 https://gerrit.wikimedia.org/r/481570 https://gerrit.wikimedia.org/r/481571 [08:35:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:06:57] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Test-Coverage: generate Wikibase.git code coverage on Jenkins - https://phabricator.wikimedia.org/T88434 (10Lucas_Werkmeister_WMDE) Well, the three extensions included in Wikibase.git (WikibaseLib, WikibaseRep... [10:25:32] (03PS2) 10Lucas Werkmeister (WMDE): Trigger recheck on comments starting with recheck [integration/config] - 10https://gerrit.wikimedia.org/r/487037 [10:26:10] (03CR) 10Lucas Werkmeister (WMDE): "Done using unittest.subTest to avoid some repetition, I hope that’s okay? (I guess CI will tell me… I’m not even sure if these tests are r" [integration/config] - 10https://gerrit.wikimedia.org/r/487037 (owner: 10Lucas Werkmeister (WMDE)) [10:27:21] (03CR) 10jerkins-bot: [V: 04-1] Trigger recheck on comments starting with recheck [integration/config] - 10https://gerrit.wikimedia.org/r/487037 (owner: 10Lucas Werkmeister (WMDE)) [10:28:19] (03CR) 10Lucas Werkmeister (WMDE): "mäh, no subTest function. okay, then I’ll copy+paste :)" [integration/config] - 10https://gerrit.wikimedia.org/r/487037 (owner: 10Lucas Werkmeister (WMDE)) [10:35:52] (03PS3) 10Lucas Werkmeister (WMDE): Trigger recheck on comments starting with recheck [integration/config] - 10https://gerrit.wikimedia.org/r/487037 [17:07:21] 10Beta-Cluster-Infrastructure, 10Page-Previews, 10Readers-Web-Backlog, 10Browser-Tests: Popups build failing consistently for a week - https://phabricator.wikimedia.org/T214974 (10Jdlrobson) [17:07:31] 10Beta-Cluster-Infrastructure, 10Page-Previews, 10Readers-Web-Backlog, 10Browser-Tests: Popups build failing consistently for a week - https://phabricator.wikimedia.org/T214974 (10Jdlrobson) p:05Triage→03High [17:31:11] https://gerrit-review.googlesource.com/c/plugins/zuul-status/+/212103 is merged now (zuul-status) :) [17:32:02] \o/ [17:36:39] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (Backlog), 10Zuul: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10Paladox) [17:36:41] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.4 - https://phabricator.wikimedia.org/T200739 (10Paladox) [17:39:28] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.4 - https://phabricator.wikimedia.org/T200739 (10Paladox) [17:39:31] 10Gerrit, 10Patch-For-Review: Create a plugin that add's recheck/check experimental as buttons to PolyGerrit ui's - https://phabricator.wikimedia.org/T214631 (10Paladox) [17:42:05] 10Gerrit: Make a PolyGerrit plugin to welcome new users - https://phabricator.wikimedia.org/T201246 (10Paladox) I have recently learned we can use most of PolyGerrit's functions including gr-rest-api-interface. [18:11:12] 10MediaWiki-Codesniffer, 10Patch-For-Review: PHP Codesniffer errors and warnings misleading for phpunitannotations sniff - https://phabricator.wikimedia.org/T209486 (10Umherirrender) 05Open→03Resolved [18:11:38] 10MediaWiki-Codesniffer, 10Patch-For-Review: PHP Codesniffer errors and warnings misleading for phpunitannotations sniff - https://phabricator.wikimedia.org/T209486 (10D3r1ck01) Thanks for working on this @Umherirrender :) [18:12:01] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to replace !! by explicit boolean cast (bool) - https://phabricator.wikimedia.org/T203800 (10Umherirrender) 05Open→03Resolved p:05Triage→03Normal a:03Mainframe98 [18:14:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Discovery-Search: extensions phpunit tests time out - https://phabricator.wikimedia.org/T214978 (10Smalyshev) [18:54:32] 10Scap, 10ORES, 10Scoring-platform-team: Investigate: why are we getting overload errors during ORES deployments? - https://phabricator.wikimedia.org/T213116 (10Halfak) [19:02:16] (03PS8) 10Umherirrender: Expand ExtendClassUsageSniff to check for config globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481653 (https://phabricator.wikimedia.org/T200679) [19:04:34] (03CR) 10Umherirrender: "I have remove the version check, because that does not work. The list of globals is a blacklist and the blacklist is stable, because the g" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481653 (https://phabricator.wikimedia.org/T200679) (owner: 10Umherirrender) [19:04:57] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Test-Coverage: generate Wikibase.git code coverage on Jenkins - https://phabricator.wikimedia.org/T88434 (10Legoktm) That's one possible option, yes. Or you can adopt the standard layout in one repo, but sligh... [19:39:55] 10Scap, 10ORES, 10Scoring-platform-team: Investigate: why are we getting overload errors during ORES deployments? - https://phabricator.wikimedia.org/T213116 (10Ladsgroup) >>! In T213116#4860787, @awight wrote: > Maybe this is because scap is restarting the services in serial, but not accounting for the long... [19:52:35] (03PS1) 10Umherirrender: Replace sniff for forbidden globals by deprecated globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/487166 [20:08:37] (03CR) 10Legoktm: [C: 03+2] "Sorry, you're right. I totally confused both sniffs." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481653 (https://phabricator.wikimedia.org/T200679) (owner: 10Umherirrender) [20:09:22] (03Merged) 10jenkins-bot: Expand ExtendClassUsageSniff to check for config globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481653 (https://phabricator.wikimedia.org/T200679) (owner: 10Umherirrender) [20:09:49] (03CR) 10jenkins-bot: Expand ExtendClassUsageSniff to check for config globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/481653 (https://phabricator.wikimedia.org/T200679) (owner: 10Umherirrender) [20:24:24] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to prevent using config globals when Config is available - https://phabricator.wikimedia.org/T200679 (10Umherirrender) 05Open→03Resolved [21:26:02] 10Phabricator: independent column sorting in Phabricator - https://phabricator.wikimedia.org/T214988 (10Smalyshev) [21:53:55] (03CR) 10ValeryanM: "> Patch Set 1: Code-Review-1" [integration/config] - 10https://gerrit.wikimedia.org/r/485967 (owner: 10ValeryanM) [21:56:44] 10Phabricator (Upstream), 10Upstream: independent column sorting in Phabricator - https://phabricator.wikimedia.org/T214988 (10Aklapper) Could you please provide specific use cases as an example? See https://secure.phabricator.com/book/phabcontrib/article/describing_problems/ and see also https://secure.phabri... [21:57:23] (03PS2) 10ValeryanM: Add ValeryanM to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/485967 [22:05:53] (03PS1) 10Gehel: java: build maven projects with maven wrapper if it exists [integration/config] - 10https://gerrit.wikimedia.org/r/487285 (https://phabricator.wikimedia.org/T208938) [22:07:02] (03PS2) 10Gehel: java: build maven projects with maven wrapper if it exists [integration/config] - 10https://gerrit.wikimedia.org/r/487285 (https://phabricator.wikimedia.org/T208938) [22:07:40] 10Continuous-Integration-Config, 10Release-Engineering-Team (Backlog), 10Discovery-Search (Current work), 10Patch-For-Review: Use maven wrapper (mvnw) to build maven based project from search platform team - https://phabricator.wikimedia.org/T208938 (10Gehel) [22:36:18] brennen: You now have access to staff IRC, BTW. :-) [22:43:47] * paladox has finally got the image-diff plugin working https://gerrit-review.googlesource.com/c/plugins/image-diff/+/205530 [22:46:09] paladox: Neat. Does it do SVGs? [22:46:16] * paladox tests [22:46:37] Most image differs of UGC don't, for security reasons. [22:46:49] But SVGs are also pretty much the only image type we put into gerrit… :-( [22:47:22] James_F nope https://github.com/GerritCodeReview/gerrit/blob/ec5adc5564f2de4f707e49cfba09db00293a8f11/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-image.js#L25 [22:47:35] Ah well. [22:47:41] x-icon, really? Wow. [22:47:48] yup [22:48:04] was added 22 days ago James_F :) [22:48:05] https://github.com/GerritCodeReview/gerrit/commit/c93d71c545bd0e996c12365820570287509af364 [22:50:08] (03CR) 10MarcoAurelio: [C: 03+1] Add ValeryanM to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/485967 (owner: 10ValeryanM) [22:59:06] James_F i also implemented zuul status view in gerrit https://gerrit-review.googlesource.com/c/plugins/zuul-status/+/212103 :) [22:59:56] I saw. Very neat. [23:08:41] thanks James_F [23:14:54] (03CR) 10Paladox: "needs rebasing." [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/465324 (owner: 10Alexandros Kosiaris) [23:46:40] (03PS1) 10Shawnmjones: Edit Project Config [extensions/Memento] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/487311