[00:04:17] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.4 - https://phabricator.wikimedia.org/T200739 (10Paladox) [00:18:37] 10Gerrit, 10Patch-For-Review: Create a plugin that add's recheck/check experimental as buttons to PolyGerrit ui's - https://phabricator.wikimedia.org/T214631 (10Paladox) p:05Triage→03Normal [00:40:20] 10Gerrit, 10Icinga, 10Operations, 10monitoring: Investigate why icinga did not report high cpu/load for gerrit - https://phabricator.wikimedia.org/T215033 (10Dzahn) @Paladox I think it's just different descriptions for the same thing when looking at the nrpe_command line only. So just one new check. [03:01:57] Project mediawiki-core-code-coverage-docker build #4044: 04FAILURE in 1 min 55 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-docker/4044/ [03:47:47] retriggered [03:55:14] 10Gerrit, 10Patch-For-Review: Create a plugin that add's recheck/check experimental as buttons to PolyGerrit ui's - https://phabricator.wikimedia.org/T214631 (10Legoktm) Adding 'recheck' sounds like a good idea. 'check experimental' is just supposed to be for the CI team testing new jobs and stuff - I don't th... [04:07:14] 10Continuous-Integration-Config, 10MediaWiki-extensions-Other, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Basic CI checks for mediawiki/extension/AuthenticatedKeyValueStore - https://phabricator.wikimedia.org/T214417 (10Liuxinyu970226) [04:33:46] (03CR) 10Legoktm: [C: 03+2] Autoload Composer dependencies in GraphQL extension. [integration/config] - 10https://gerrit.wikimedia.org/r/487534 (https://phabricator.wikimedia.org/T215047) (owner: 10Dbarratt) [04:35:14] (03Merged) 10jenkins-bot: Autoload Composer dependencies in GraphQL extension. [integration/config] - 10https://gerrit.wikimedia.org/r/487534 (https://phabricator.wikimedia.org/T215047) (owner: 10Dbarratt) [04:36:44] !log deploying https://gerrit.wikimedia.org/r/487534 [04:36:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:46:25] 10Continuous-Integration-Config, 10GraphQL, 10Patch-For-Review: GraphQL extension should use -composer jobs in CI - https://phabricator.wikimedia.org/T215047 (10Legoktm) 05Open→03Resolved a:03dbarratt [04:55:28] (03PS1) 10Legoktm: Stop deploying WikibaseQuality [tools/release] - 10https://gerrit.wikimedia.org/r/487623 (https://phabricator.wikimedia.org/T208499) [05:10:44] Yippee, build fixed! [05:10:44] Project mediawiki-core-code-coverage-docker build #4045: 09FIXED in 1 hr 23 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-docker/4045/ [05:10:58] (03CR) 10Legoktm: [C: 03+2] "> @Legoktm I have multiple email addresses added to Gerrit. I can change my preferred email address at any time. I used samrhilson@gmail.c" [integration/config] - 10https://gerrit.wikimedia.org/r/485967 (owner: 10ValeryanM) [05:13:12] (03Merged) 10jenkins-bot: Add ValeryanM to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/485967 (owner: 10ValeryanM) [05:44:14] !log deployed https://gerrit.wikimedia.org/r/485967 [05:44:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:13:06] (03PS1) 10Legoktm: Remove concurrency limit for phpunit-patch-coverage jobs [integration/config] - 10https://gerrit.wikimedia.org/r/487627 [06:13:27] (03CR) 10Legoktm: [C: 03+2] Remove concurrency limit for phpunit-patch-coverage jobs [integration/config] - 10https://gerrit.wikimedia.org/r/487627 (owner: 10Legoktm) [06:15:16] (03Merged) 10jenkins-bot: Remove concurrency limit for phpunit-patch-coverage jobs [integration/config] - 10https://gerrit.wikimedia.org/r/487627 (owner: 10Legoktm) [06:15:41] !log deployed https://gerrit.wikimedia.org/r/487627 [06:15:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:29:34] 10Continuous-Integration-Infrastructure, 10phpunit-patch-coverage: doc.wikimedia.org CSP prevents inline styles on HTML patch coverage report from working - https://phabricator.wikimedia.org/T215115 (10Legoktm) [09:38:37] 10Continuous-Integration-Config, 10phpunit-patch-coverage: phpunit-patch-coverage HTML reports are not being saved by jenkins - https://phabricator.wikimedia.org/T206230 (10Legoktm) [09:38:41] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: mediawiki-phpunit-coverage-patch-docker missing HTML report artifact - https://phabricator.wikimedia.org/T205235 (10Legoktm) [13:08:40] 10Project-Admins: Cleaning up #Mediawiki-extensions-other - https://phabricator.wikimedia.org/T213880 (10Liuxinyu970226) #other-skins is likely or not? [14:28:01] 10Gerrit, 10Patch-For-Review: Create a plugin that add's recheck/check experimental as buttons to PolyGerrit ui's - https://phabricator.wikimedia.org/T214631 (10Dzahn) >>! In T214631#4922952, @Legoktm wrote: > 'check experimental' is just supposed to be for the CI team testing new jobs and stuff - I don't thi... [14:32:09] 10Gerrit, 10Patch-For-Review: Create a plugin that add's recheck/check experimental as buttons to PolyGerrit ui's - https://phabricator.wikimedia.org/T214631 (10Paladox) I think it's useful for operations/puppet for the compiler stuff? In which case we can only expose it to that project if you want? [16:52:06] https://gerrit-review.googlesource.com/c/gerrit/+/212571 [16:52:13] that should be useful for users ^^ [19:04:15] brennen hi, are you on phabricator? [19:05:23] hi paladox - not yet but soon. i have a good deal of setup left to do on various accounts, working through the list today and tomorrow. [19:05:32] ah ok [19:08:59] brennen i just wanted to add you to https://phabricator.wikimedia.org/project/view/3104/ but coulden't find you :) [19:14:40] paladox: ah, right on. i'll ping when i figure out what the heck i am doing. :) [19:14:49] ok :) [19:14:59] the group is to prevent you hitting spam filters too [19:36:04] legoktm we can do https://stackoverflow.com/questions/8830599/php-convert-xml-to-json [19:36:16] so push the json file some where. [19:36:18] paladox: oh, I have some code locally [19:36:21] just need to push it [19:36:25] :) [19:36:41] i used a online xml -> json converter [19:36:46] for the mw core code coverage [19:39:22] legoktm that's great then! [19:40:35] https://twitter.com/GerritReview/status/1091321243159224320 [19:40:52] that would be a cool thing if that becomes a feature [19:43:20] 10MediaWiki-Codesniffer: Assignment to a class variable in an anonymous class incorrectly triggers MediaWiki.Usage.AssignmentInReturn.AssignmentInReturn - https://phabricator.wikimedia.org/T215129 (10Mainframe98) [19:43:47] 10MediaWiki-Codesniffer: Assignment to a class variable in an anonymous class incorrectly triggers MediaWiki.Usage.AssignmentInReturn.AssignmentInReturn - https://phabricator.wikimedia.org/T215129 (10Mainframe98) p:05Triage→03Normal [19:47:50] (03PS1) 10Mainframe98: Also exclude anonymous classes in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/487662 (https://phabricator.wikimedia.org/T215129) [19:59:47] legoktm i'll be able to work on this once we have a json file :). [20:08:25] (03CR) 10Umherirrender: [C: 03+1] Also exclude anonymous classes in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/487662 (https://phabricator.wikimedia.org/T215129) (owner: 10Mainframe98) [20:38:06] paladox: https://phabricator.wikimedia.org/p/brennen/ [20:38:39] (and on that note i'm going to head outside while there is still daylight.) [21:42:15] 10Beta-Cluster-Infrastructure, 10User-DannyS712: Requesting bot rights on enwiki beta - https://phabricator.wikimedia.org/T215132 (10DannyS712) [21:44:13] paladox: sorry, I thought we were blocked on upgrading Gerrit? [22:00:01] legoktm yup, though i've already upgraded my test site :) [22:00:09] (https://gerrit.git.wmflabs.org/r/) [22:00:38] (also sorry for late reply was watching vera!0 [22:00:40] *) [22:00:55] brennen done :) [22:02:09] (03PS1) 10Paladox: Modify access rules [software/thumbor-plugins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/487783 [22:02:40] (03CR) 10Gilles: [C: 03+2] Modify access rules [software/thumbor-plugins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/487783 (owner: 10Paladox) [22:03:25] (03CR) 10Gilles: [V: 03+2 C: 03+2] Modify access rules [software/thumbor-plugins] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/487783 (owner: 10Paladox) [22:06:30] paladox: https://chromium.googlesource.com/infra/gerrit-plugins/code-coverage/+/master/src/main/resources/static/chromium-coverage.html#30 will need to be configurable [22:06:45] yup, that can be done [22:07:15] some of that plugin will have to be configured differently since the format would be different. [22:07:53] are we going to fork the plugin? [22:08:11] I guess we will have to as that plugin is for chromium needs [22:08:13] everything else looked fine to me [22:51:17] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Discovery-Search (Current work): Run sonar analysis as a pre-merge step for search platform maven projects - https://phabricator.wikimedia.org/T215135 (10Gehel) [22:53:17] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Discovery-Search (Current work): Run sonar analysis as a pre-merge step for search platform maven projects - https://phabricator.wikimedia.org/T215135 (10Gehel) Note that since the sonar analysis itself only breaks if the analysis fails (as in: "it cr... [22:57:18] (03PS1) 10Gehel: sonar: run sonar analysis as a pre-merge step [integration/config] - 10https://gerrit.wikimedia.org/r/487786 (https://phabricator.wikimedia.org/T215135) [22:58:18] (03CR) 10jerkins-bot: [V: 04-1] sonar: run sonar analysis as a pre-merge step [integration/config] - 10https://gerrit.wikimedia.org/r/487786 (https://phabricator.wikimedia.org/T215135) (owner: 10Gehel)