[00:12:21] !log removed old docker images on contint1001 to free up space [00:12:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [00:16:39] (03PS1) 10Krinkle: doc: Multi-column magic [integration/docroot] - 10https://gerrit.wikimedia.org/r/489106 [00:17:45] (03CR) 10Krinkle: [C: 03+2] doc: Multi-column magic [integration/docroot] - 10https://gerrit.wikimedia.org/r/489106 (owner: 10Krinkle) [00:18:09] (03Merged) 10jenkins-bot: doc: Multi-column magic [integration/docroot] - 10https://gerrit.wikimedia.org/r/489106 (owner: 10Krinkle) [00:18:16] (03CR) 10jenkins-bot: doc: Multi-column magic [integration/docroot] - 10https://gerrit.wikimedia.org/r/489106 (owner: 10Krinkle) [00:20:18] error: unable to unlink old 'org/wikimedia/doc/default.html': Permission denied [00:20:18] error: unable to unlink old 'org/wikimedia/doc/index.php': Permission denied [00:25:27] Owned by the wrong group? [00:26:18] Yeah, looks like a non-group owned file from hashar got in there. [00:26:22] trying to fix it now [00:27:00] and parent directories.. [00:27:45] OK. fixed [00:28:37] !log krinkle@doc1001: sudo -u doc-uploader chmod 775 /srv/docroot/org/wikimedia/doc/ [00:28:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [00:34:49] (03PS1) 10Krinkle: doc: Even out un-even margins in columns [integration/docroot] - 10https://gerrit.wikimedia.org/r/489108 [00:34:56] (03CR) 10Krinkle: [C: 03+2] doc: Even out un-even margins in columns [integration/docroot] - 10https://gerrit.wikimedia.org/r/489108 (owner: 10Krinkle) [00:35:21] (03Merged) 10jenkins-bot: doc: Even out un-even margins in columns [integration/docroot] - 10https://gerrit.wikimedia.org/r/489108 (owner: 10Krinkle) [00:35:27] (03CR) 10jenkins-bot: doc: Even out un-even margins in columns [integration/docroot] - 10https://gerrit.wikimedia.org/r/489108 (owner: 10Krinkle) [00:47:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10Operations: contint1001 store docker images on separate partition or disk - https://phabricator.wikimedia.org/T207707 (10thcipriani) >>! In T207707#4909130, @Dzahn wrote: > Let's ask dcops instead and request a new disk to be ad... [00:58:25] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.4 - https://phabricator.wikimedia.org/T200739 (10Paladox) test [00:58:58] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.4 - https://phabricator.wikimedia.org/T200739 (10Paladox) test [01:01:22] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.4 - https://phabricator.wikimedia.org/T200739 (10Dzahn) >>! In T200739#4937041, @Paladox wrote: > test ACK, let's confirm phab mail works after the latest deploy. [01:08:27] (03PS5) 10Dduvall: Use blubberoid.wikimedia.org to process blubber.yaml [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/480689 (https://phabricator.wikimedia.org/T212247) [01:36:04] (03PS1) 10Krinkle: Switch labs/tools/wikidata-slicer to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489120 (https://phabricator.wikimedia.org/T211784) [01:37:40] 10Gerrit, 10Release-Engineering-Team (Next): Upgrade to Gerrit 2.15.10 - https://phabricator.wikimedia.org/T214359 (10Paladox) [01:47:07] 10Phabricator, 10Release-Engineering-Team (Backlog), 10Mail, 10Operations, and 2 others: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10Dzahn) deployed in production and we tested mail still works. this just adds the new config and does not remove the... [02:06:01] (03CR) 10Krinkle: [C: 03+2] Switch labs/tools/wikidata-slicer to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489120 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [02:07:56] (03Merged) 10jenkins-bot: Switch labs/tools/wikidata-slicer to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489120 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [02:45:54] (03PS1) 10Krinkle: Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) [02:47:04] (03CR) 10jerkins-bot: [V: 04-1] Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [02:48:07] (03PS2) 10Krinkle: Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) [02:51:02] (03CR) 10jerkins-bot: [V: 04-1] Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [02:54:51] (03PS1) 10Krinkle: jobs: Remove old config for Gerrit-Set-Reviewers job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/489129 [02:56:40] (03CR) 10Krinkle: [C: 03+2] Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [02:58:26] (03CR) 10Krinkle: [C: 03+2] jobs: Remove old config for Gerrit-Set-Reviewers job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/489129 (owner: 10Krinkle) [02:59:07] (03Merged) 10jenkins-bot: jobs: Remove old config for Gerrit-Set-Reviewers job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/489129 (owner: 10Krinkle) [02:59:35] (03CR) 10jerkins-bot: [V: 04-1] Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [03:02:59] (03Abandoned) 10Krinkle: [FEAT] Detect bug id duplicates [integration/jenkins] - 10https://gerrit.wikimedia.org/r/247059 (owner: 10XZise) [03:03:34] (03Abandoned) 10Krinkle: Add travis-set-env.sh helper for travis integration. [integration/jenkins] - 10https://gerrit.wikimedia.org/r/173046 (https://phabricator.wikimedia.org/T114421) (owner: 10C. Scott Ananian) [03:04:13] (03PS3) 10Krinkle: Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) [03:04:32] (03CR) 10Krinkle: [C: 03+2] "ugh, dirty git. I was working locally, but forgot to stage. Fixed now." [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [03:04:36] (03CR) 10Krinkle: [C: 03+2] Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [03:07:08] (03CR) 10jerkins-bot: [V: 04-1] Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [03:08:33] (03Merged) 10jenkins-bot: Switch npm-audit job to node10 [integration/config] - 10https://gerrit.wikimedia.org/r/489128 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [03:10:36] !log Delete various jobs on Jenkins that no longer exist in JJB config [03:10:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:48:50] can I please have a +2 on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaEvents/+/489131/ if anyone is around? [03:49:31] I'm investigating the failure of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/489125/ [03:51:04] +2 applied [03:59:13] thanks [07:56:16] (03CR) 10Legoktm: "This is super cool. I love magic." [integration/docroot] - 10https://gerrit.wikimedia.org/r/489106 (owner: 10Krinkle) [07:58:02] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10User-greg: integration-slave-docker-1033 out of disk space - https://phabricator.wikimedia.org/T215564 (10greg) 05Open→03Resolved a:03greg This was done. [09:49:13] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [09:53:28] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [09:53:52] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [09:56:58] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [09:57:19] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [09:57:45] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [09:57:56] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [10:20:37] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [10:21:13] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [10:21:29] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [10:21:51] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [10:22:14] 10Release-Engineering-Team (Watching / External), 10DBA, 10Datasets-General-or-Unknown, 10Patch-For-Review, and 2 others: Automate the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459 (10jcrespo) [10:42:46] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Backlog): Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10MarcoAurelio) Requesting a Gerrit repo is just a matter of asking at . QChris and myself handl... [11:07:58] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Backlog): Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10LucasWerkmeister) > Requesting a Gerrit repo is just a matter of asking at https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests. QChris and myself h... [12:18:21] 10Continuous-Integration-Config, 10Lexicographical data, 10Wikidata, 10Wikidata-Campsite: Enable phan checks for WikibaseLexeme extension - https://phabricator.wikimedia.org/T215556 (10Addshore) p:05Triage→03Low [13:39:26] 10Release-Engineering-Team, 10User-Zppix: Jenkins is posting duplicate comments when a depended on change merge fails - https://phabricator.wikimedia.org/T215511 (10Zppix) >>! In T215511#4935670, @Legoktm wrote: > This is on purpose, and a good thing IMO. It can be a bit confusing if they're all at the same ti... [13:40:05] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-2] "This proposal horrifies me quite a lot. Since when is it a good idea to force people to write the shortest possible code? People did this " (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/486813 (owner: 10Daimona Eaytoy) [15:03:24] (03PS2) 10Kosta Harlan: Sonar: Specify branch name and target [integration/config] - 10https://gerrit.wikimedia.org/r/487877 (https://phabricator.wikimedia.org/T215175) [15:10:42] hi rel-eng. I'm still trying to figure out how to look inside the docker images to debug a test [15:11:07] i'm trying to follow the suggestions here: https://stackoverflow.com/questions/20813486/exploring-docker-containers-file-system [15:11:20] but when I try to run docker run -t -i mysnapshot /bin/bash [15:11:30] "the docker images", which ones? :D [15:11:47] addshore: the ones created on the integration slaves to run the quibble tests [15:12:12] specifically to debug this failing test: https://gerrit.wikimedia.org/r/487979 [15:12:12] docker run will run a command in a new container (not an existing one) [15:12:40] right, I've been trying to create a new container as a snapshot of a running one while the test is in process [15:12:57] so I can take a look at the files before it's all deleted [15:13:22] also, So, you probably want to specify --rm when you use docker run so that it doesnt leave the containers you create on the host after you exit them [15:13:49] ok, I can also delete them manually, right? [15:13:52] yup [15:14:33] so, the suggested docker run command fails - it seems to be trying to clone something to /bin/bash [15:14:37] > DEBUG:zuul.CloneMapper:Using /bin/bash as destination (unmatched) [15:14:53] what would be the correct way to get a shell inside the image? [15:15:09] whats the full command you are running? [15:15:25] docker run -t -i ejeggsnapshot /bin/bash [15:15:38] what image is that snapshot based on? [15:15:59] where ejeggsnapshot was created by looking up the id of the image running the test with 'docker ps' [15:16:21] then using 'docker commit ejeggsnapshot' [15:17:35] so you need to override the entrypoint it looks like [15:17:52] aha, how would I do that? [15:17:58] --entrypoint [15:18:06] but i wonder if the images have bash (i guess so) [15:18:13] you might also need to override the user [15:18:26] heh, sh would do. And I'm pretty sure they have that! [15:19:13] (03CR) 10Daimona Eaytoy: "> (4 comments)" (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/486813 (owner: 10Daimona Eaytoy) [15:19:32] ok, looking at this article: https://medium.com/@oprearocks/how-to-properly-override-the-entrypoint-using-docker-run-2e081e5feb9d [15:19:36] for example: [15:19:38] docker run --rm -it --entrypoint /bin/bash docker-registry.wikimedia.org/releng/quibble-stretch-php72:0.0.27 [15:19:40] works [15:20:27] they do have bash, but I dont think it is in the default users PATh [15:20:45] and the default entry point is normally something like ENTRYPOINT /bin/bash /run.sh [15:20:53] ok, cool. Thanks, addshore! [15:35:55] aha, so the extension's composer dependencies seem not to exist when the mediawiki tests are run [15:38:04] the test runs 'composer test' in the extension's directory right after cloning it, [15:38:12] which installs the dependencies [15:38:25] but then it runs git clean and deletes them [15:38:57] and the mediawiki composer.json doesn't include extensions/*/composer.json in the merge-plugin extra [15:39:17] oh hey, I bet I can just gitignore vendor and keep it out of the cleanup! [15:44:45] nope, that didn't do it [15:45:03] so rel-eng, how is it supposed to work for extensions with composer dependencies? [15:45:36] Is there some special test setup to tell quibble to composer install and keep the vendor dir for the mw phpunit tests? [15:46:18] Or some way to specify that the core composer.json should include the extension's composer.json in the merge-plugin config? [15:47:54] that git clean -xqdf is pretty aggressive [15:48:00] Hi again! [15:48:06] which extension is this for? [15:48:13] and can you link me to one of the failed test funs? [15:48:15] *runs [15:48:21] https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/34223/console [15:48:30] for FundraisingEmailUnsubscribe [15:48:44] and which library is it not installing? [15:49:14] it's deleting the whole extensions/FundraisingEmailUnsubscribe/vendor dir after running composer test in extensions/FundraisingEmailUnsubscribe [15:49:30] so, the libraries need to be included in https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json [15:49:35] (needed for production too) [15:49:43] as far as I can see quibble is running using that [15:49:48] addshore: ahh, but this extension doesn't run on production [15:49:54] just the payments cluster [15:50:12] I'd hate to add unnecessary libs to production just to run tests [15:51:06] so the "vendor" in the job name quibble-vendor-mysql-hhvm-docker means it uses mediawiki-vendor [15:51:16] let me find the job you will actually want *looks* [15:51:40] composer! [15:51:45] ok, I guess that extn is using the standard extension test template in the zuul-config repo [15:52:01] quibble-composer-mysql-hhvm-docker is what you want :) [15:52:24] it is using the default extension-quibble template [15:52:34] I think it needs extension-quibble-composer [15:53:02] give me 1 min [15:53:08] ok, great! [15:53:43] (03PS1) 10Addshore: zuul, make FundraisingEmailUnsubscribe use extension-quibble-composer [integration/config] - 10https://gerrit.wikimedia.org/r/489241 [15:54:01] (03CR) 10Addshore: [C: 03+2] zuul, make FundraisingEmailUnsubscribe use extension-quibble-composer [integration/config] - 10https://gerrit.wikimedia.org/r/489241 (owner: 10Addshore) [15:54:10] hehe, love the command tense in the commit msg [15:54:17] :D [15:55:48] (03Merged) 10jenkins-bot: zuul, make FundraisingEmailUnsubscribe use extension-quibble-composer [integration/config] - 10https://gerrit.wikimedia.org/r/489241 (owner: 10Addshore) [15:58:19] !log reloaded zuul for https://gerrit.wikimedia.org/r/#/c/integration/config/+/489241/ [15:58:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:58:32] cool, recheck-ing [15:59:36] !log this reload also included "Switch npm-audit job to node10"? T211784, which did touch the zuul file [15:59:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:59:39] T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects - https://phabricator.wikimedia.org/T211784 [16:00:12] dang but node moves fast [16:00:23] hehe [16:00:24] they versioning it like browsers now? [16:02:18] yes! looks like that did it. [16:02:19] [merge-plugin] Merging twig/twig [16:02:26] Thanks addshore ! [16:02:33] cp! [16:02:34] np! [16:35:58] (03CR) 10Thcipriani: [C: 04-1] "See comments inline about httpRequest and application/json" (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/480689 (https://phabricator.wikimedia.org/T212247) (owner: 10Dduvall) [16:45:11] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10MarkAHershberger) [16:46:42] 10Release-Engineering-Team (Kanban), 10Core Platform Team Kanban, 10SDC Engineering, 10Wikidata, and 3 others: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). - https://phabricator.wikimedia.org/T198342 (10daniel) [16:48:44] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10MarkAHershberger) [16:56:06] (03CR) 10Thcipriani: [C: 04-1] Use blubberoid.wikimedia.org to process blubber.yaml (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/480689 (https://phabricator.wikimedia.org/T212247) (owner: 10Dduvall) [16:59:37] (03CR) 10Thcipriani: [C: 03+2] "Thanks for this fix!" [tools/scap] - 10https://gerrit.wikimedia.org/r/488919 (owner: 10MarcoAurelio) [17:01:00] (03Merged) 10jenkins-bot: Fix flake8 "F632 use ==/!= to compare str, bytes, and int literals" error [tools/scap] - 10https://gerrit.wikimedia.org/r/488919 (owner: 10MarcoAurelio) [17:01:06] (03CR) 10jenkins-bot: Fix flake8 "F632 use ==/!= to compare str, bytes, and int literals" error [tools/scap] - 10https://gerrit.wikimedia.org/r/488919 (owner: 10MarcoAurelio) [17:17:17] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10Umherirrender) Your copy of `KEY_FORMAT_REGEX` includes an escaped `-`, your php example does not use a escaped `-` I see no error on using e... [17:17:47] 10Scap (Scap3-Adoption-Phase2), 10Toolforge: Setup a proper deployment strategy for Kubernetes - https://phabricator.wikimedia.org/T129311 (10thcipriani) Cleaning up some old workboards. Is this task still needed? If so, is scap3 still a part of the discussion? [17:18:33] 10Scap, 10WorkType-NewFunctionality: create a scap3 command to bootstrap a new deployment repo - https://phabricator.wikimedia.org/T118760 (10thcipriani) [17:18:57] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10Umherirrender) It seems the fix already backported to REL1_31 https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/467546/ Are you working wi... [17:29:25] 10Release-Engineering-Team (Long-Lived-Branches), 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Spike, 10Wikimedia-Incident: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904 (10AndyRussG) Following IRL discussion with @thcipriani, it... [17:46:04] 10Phabricator, 10Release-Engineering-Team (Watching / External), 10Mail, 10Operations, and 2 others: Convert Phabricator mail config to use cluster.mailers - https://phabricator.wikimedia.org/T212989 (10greg) [17:53:09] thcipriani, twentyafterfour, greg-g, Niharika: Last night I moved jouncebot from the old Trusty job grid to the Kubernetes cluster in Toolforge as well as updating its runtime from python2 to python3. All the tests I did look good, but just a heads up in case it starts misbehaving next week unexpectedly. [17:53:31] Thanks bd808! [17:53:45] bd808: wow, neat :) [17:54:24] the good news is that it now operated almost exactly like Stashbot (Stashbot is still on python2) and should be pretty awesomely self-healing [17:54:49] that sounds fancy [17:55:17] vaguely terrifying [17:55:52] * Krenair is imagining jouncebot rising from the grave [17:56:07] if the bot crashes that should kill the pod that it runs in and the containing Kubernetes replica set should start it back up [17:57:12] nice [18:03:14] bd808: nice, thanks for the updates, I saw the email about moving from trusty and wasn't sure what needed to happen exactly. [18:03:46] there was an easy mode route and a hard mode route. I took the hard mode route :) [18:04:10] mostly because I had "been meaning to" do that change for about a year and a half ;) [18:17:00] (03CR) 10Thcipriani: "recheck" [tools/scap] - 10https://gerrit.wikimedia.org/r/486321 (owner: 10Thcipriani) [18:17:13] (03PS3) 10Thcipriani: Docs: remove references to differential [tools/scap] - 10https://gerrit.wikimedia.org/r/486321 [19:00:25] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10MarkAHershberger) It isn't me. Original user (see support desk link above) was on 1.32.1. [19:02:51] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10MarkAHershberger) Also, thanks for pointing out the escape in what is on master. I created the test based on what posted on the support desk,... [19:15:17] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10MarkAHershberger) [19:16:31] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10MarkAHershberger) [19:21:28] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10Reedy) So this is basically fixed, but fix still to be released? [19:22:16] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10MarkAHershberger) [19:22:19] 10MediaWiki-Releasing, 10MediaWiki-Debian, 10MW-1.31-release, 10PHP 7.3 support: UploadStash should use a valid regex - https://phabricator.wikimedia.org/T215632 (10MarkAHershberger) 05Open→03Resolved a:03MarkAHershberger Yep: https://phabricator.wikimedia.org/rMWf80e50f318a350c4486d272b1bc1bb5c22715a7c [19:49:30] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing: ExtensionJsonValidationTest does not support @note - https://phabricator.wikimedia.org/T215650 (10Smalyshev) [20:10:11] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I use this sniff myself in most repositories I maintain, and support this addition to our standard." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/488561 (https://phabricator.wikimedia.org/T213861) (owner: 10Umherirrender) [20:18:43] thcipriani: could we remove .arclint from https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/scap/+/486321/ as well? Then it'd be good to go IMHO. [20:20:55] !log Delete various jobs on Jenkins that no longer exist in JJB config, ref T91410 [20:20:57] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:20:57] T91410: Automatically delete old jobs not (or no longer) managed by JJB - https://phabricator.wikimedia.org/T91410 [20:21:22] (03PS4) 10Thcipriani: Docs: remove references to differential [tools/scap] - 10https://gerrit.wikimedia.org/r/486321 [20:21:32] ^ hauskatze good catch! done. [20:22:07] thcipriani: nice, thanks. I can +2 if you like, but I'm not sure how that repo works so maybe I'll just stick to +1 [20:24:07] hauskatze: feel free to +2. +2 for that repo is auto-deploy to beta (although that may not be working at the moment, actually). [20:25:13] worse case for +2 would be: beta-scap-eqiad would break and we could revert fairly quickly so code wouldn't be auto-deployed to beta for 20 minutes or so: not generally a huge problem. [20:25:14] thcipriani: so like mediawiki [20:25:29] yep [20:25:50] I'll think about it while I have some dinner :) [20:25:56] fair :) [21:03:07] 10Gerrit: Create a plugin that add (custom html classes) in polygerrit for ci comments - https://phabricator.wikimedia.org/T215658 (10Paladox) [21:03:13] thcipriani i've created ^^ [21:05:38] 10Gerrit: Create plugin that allows users to cherry pick commits even with merge conflicts (in polygerrit) - https://phabricator.wikimedia.org/T215659 (10Paladox) [21:30:24] (03CR) 10MarcoAurelio: [C: 03+1] "Looks good to me now :)" [tools/scap] - 10https://gerrit.wikimedia.org/r/486321 (owner: 10Thcipriani) [21:33:34] 10Continuous-Integration-Config, 10ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: Migrate ORES CI to Stretch - https://phabricator.wikimedia.org/T186239 (10Ladsgroup) a:03Ladsgroup https://github.com/wikimedia/ores/pull/314 Full docker [22:04:44] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Backlog), 10Developer Productivity, 10Patch-For-Review, 10User-Jdlrobson: Automatically display production content on Beta Cluster wikis (via an API request) - https://phabricator.wikimedia.org/T207508 (10greg) (Adding this task to #developer_pro... [22:24:23] * hexmode Reading [[mw:Continuous_integration/Jenkins_job_builder]] to figure out how to set up mediawiki-core-release linked from [[mw:Release_checklist]]... [22:25:09] * greg-g waves to hexmode [22:25:18] * hexmode waves back [22:31:21] greg-g: I think I have a login on jenkins (mah) that I don't have the password for. Is there any way to reset it? [22:33:59] hrmmm, it should just be your "Wikimedia Developer Account" (aka: your wikitech.wikimedia.org account) [22:34:10] ah... k, trying [22:34:25] let me know if you have the needed access or not [22:43:11] hexmode: nice to see that familiar nick [22:53:38] :) [22:54:13] * hexmode feels the love [23:29:35] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Upgrade to Gerrit 2.16.5 - https://phabricator.wikimedia.org/T200739 (10Paladox) [23:44:08] (03CR) 10Dduvall: Use blubberoid.wikimedia.org to process blubber.yaml (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/480689 (https://phabricator.wikimedia.org/T212247) (owner: 10Dduvall)