[00:08:23] 10Phabricator (Upstream), 10Upstream: Feature request: E-mail notification about adding SSH key(s) on Phabricator should provide better message like Gerrit - https://phabricator.wikimedia.org/T208163 (10epriestley) Can you walk me through a scenario, step by step, where the having the public key in the email m... [00:10:48] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Test-Coverage: generate Wikibase.git code coverage on Jenkins - https://phabricator.wikimedia.org/T88434 (10Legoktm) >>! In T88434#5196007, @Lucas_Werkmeister_WMDE wrote: > I just came back across this point w... [00:37:09] 10Phabricator (Upstream), 10Upstream: Feature request: E-mail notification about adding SSH key(s) on Phabricator should provide better message like Gerrit - https://phabricator.wikimedia.org/T208163 (10Paladox) I didn’t write that feature :) (we are duplicating it for another thing) but from what I know it al... [01:12:16] (03Abandoned) 10Legoktm: Use webhook plugin post-merge for autopull [labs/tools/wikibugs2] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/475580 (https://phabricator.wikimedia.org/T210280) (owner: 10Legoktm) [01:17:35] (03PS1) 10Legoktm: Add "curl" docker image that just contains curl [integration/config] - 10https://gerrit.wikimedia.org/r/511361 (https://phabricator.wikimedia.org/T210280) [01:19:58] 10Phabricator (Upstream), 10Upstream: Feature request: E-mail notification about adding SSH key(s) on Phabricator should provide better message like Gerrit - https://phabricator.wikimedia.org/T208163 (10epriestley) I don't see how that commit explains why including the public key in the email is a safety featu... [01:20:43] (03PS1) 10Legoktm: Port 'labs-tools-wikibugs2-autopull' to use docker [integration/config] - 10https://gerrit.wikimedia.org/r/511362 (https://phabricator.wikimedia.org/T210280) [01:40:41] (03CR) 10Legoktm: [C: 03+2] Add "curl" docker image that just contains curl [integration/config] - 10https://gerrit.wikimedia.org/r/511361 (https://phabricator.wikimedia.org/T210280) (owner: 10Legoktm) [01:42:38] (03Merged) 10jenkins-bot: Add "curl" docker image that just contains curl [integration/config] - 10https://gerrit.wikimedia.org/r/511361 (https://phabricator.wikimedia.org/T210280) (owner: 10Legoktm) [01:43:08] !log deploying https://gerrit.wikimedia.org/r/511361 [01:43:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:46:06] OMG [01:46:09] that was way too fast [01:46:28] thank you to whomever finally fixed the publish step in docker-pkg so it doesn't publish literally everything [03:12:40] 10Beta-Cluster-Infrastructure, 10Wikimedia-Hackathon-2019, 10Chinese-Sites, 10Patch-For-Review: Please create beta zhwikivoyage - https://phabricator.wikimedia.org/T223770 (10Shizhao) [05:03:38] (03CR) 10Legoktm: [C: 03+2] Port 'labs-tools-wikibugs2-autopull' to use docker [integration/config] - 10https://gerrit.wikimedia.org/r/511362 (https://phabricator.wikimedia.org/T210280) (owner: 10Legoktm) [05:04:31] 10Continuous-Integration-Infrastructure (Slipway), 10Wikibugs, 10Patch-For-Review: Migrate CI job labs-tools-wikibugs2-autopull to use a Docker container or phase it out - https://phabricator.wikimedia.org/T210280 (10Legoktm) 05Open→03Resolved a:03Legoktm Switched to a docker image that just contains c... [05:10:38] (03Merged) 10jenkins-bot: Port 'labs-tools-wikibugs2-autopull' to use docker [integration/config] - 10https://gerrit.wikimedia.org/r/511362 (https://phabricator.wikimedia.org/T210280) (owner: 10Legoktm) [06:11:42] 10Phabricator (Upstream), 10Upstream: "Unknown Object" in feed should say "Restricted Task" instead - https://phabricator.wikimedia.org/T105332 (10mmodell) 05Open→03Resolved a:03mmodell [06:25:56] PROBLEM - Puppet errors on integration-slave-jessie-1002 is CRITICAL: (Service Check Timed Out) [06:46:23] 10Phabricator (Upstream), 10Browser-Support-Google-Chrome, 10Upstream: Phabricator is showing a lot of scrollbars on comments (Google Chrome) - https://phabricator.wikimedia.org/T180887 (10Peachey88) This has been fixed for ages I believe, the task was just never updated. > [06:49:52] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:00:03] Project mediawiki-core-code-coverage-docker build #4260: 04FAILURE in 4 hr 0 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-docker/4260/ [08:16:23] 10Gerrit, 10Release-Engineering-Team, 10translatewiki.net, 10Language-Team (Language-2019-April-June): Running translatewiki export for MediaWiki extensions: Too many concurrent connections (4) - max. allowed: 4 - https://phabricator.wikimedia.org/T222546 (10Arrbee) 05Open→03Resolved [08:55:19] 10Phabricator, 10Release-Engineering-Team (Backlog): Getting Admin rights for Phabricator - https://phabricator.wikimedia.org/T221136 (10RazShuty) Thanks a lot @Aklapper ! With Great Power Comes Great Responsibility! [09:23:40] hashar: No rush on the patch CR, etc., but I did want to say that I'm looking forward to hearing your opinions about T223752. [09:23:41] T223752: Decouple Quibble planning and execution phases - https://phabricator.wikimedia.org/T223752 [09:36:28] 10Continuous-Integration-Infrastructure, 10PHP 7.2 support, 10Patch-For-Review: Create composer test containers for php7.2 - https://phabricator.wikimedia.org/T223428 (10hashar) 05Open→03Resolved a:03Jdforrester-WMF Sorry I must have been confused at some point or had an integration/config that missed... [09:49:38] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.5 deployment blockers - https://phabricator.wikimedia.org/T220730 (10hashar) [09:52:18] awight: hi! I am unlikely to be able to look into it anytime soon unfortunately :-( [09:52:24] awight: but yeah decoupling sounds good! [09:53:42] hashar: Cool, thanks for the initial sanity check. I'll prepare a rough patch in the next few weeks, and will attach to the task. [09:54:30] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.5 deployment blockers - https://phabricator.wikimedia.org/T220730 (10hashar) [10:17:23] PROBLEM - Disk space on contint1001 is CRITICAL: DISK CRITICAL - free space: / 2525 MB (5% inode=40%): https://wikitech.wikimedia.org/wiki/Monitoring/Disk_space [10:24:02] RECOVERY - Disk space on contint1001 is OK: DISK OK https://wikitech.wikimedia.org/wiki/Monitoring/Disk_space [10:31:12] Main test build failed. [10:31:12] operations-puppet-tests-stretch-docker https://integration.wikimedia.org/ci/job/operations-puppet-tests-stretch-docker/None/console : NOT_REGISTERED [10:31:15] ??? [10:31:27] https://gerrit.wikimedia.org/r/c/operations/puppet/+/511397 [10:49:43] fsero: yeah I have spotted a few of them :- [10:49:53] there is a race condition :( [10:50:28] happens because Zuul (the CI workflow) got loaded and started processing events before Jenkins went up and ready :-/ [10:56:03] fsero: looks good now! https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/511397/ [10:56:46] yup ty! [11:20:54] 10Project-Admins: Create a project for mediawiki extension Passwordless Login - https://phabricator.wikimedia.org/T223893 (10Florian) [12:01:43] 10Beta-Cluster-Infrastructure, 10Sentry, 10Patch-For-Review, 10User-Tgr: Integrate Sentry with beta cluster - https://phabricator.wikimedia.org/T106920 (10Tgr) 05Open→03Declined Declining for now in favor of {T222180}. [12:11:23] awight: in case you are around, I am going to hijack your patch https://gerrit.wikimedia.org/r/#/c/integration/config/+/510459/ which remove the progress bar from phan runs [12:14:07] hashar: <3 excellent [12:14:11] lmk if I can do anything else. [12:14:39] PHP Warning: PHP Startup: Unable to load dynamic library '/usr/lib/php/20151012/zip.so' - libzip.so.4: failed to map segment from shared object in [12:15:02] seems the integration node has a small config issue [12:15:03] https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php70-docker/19163/console [12:15:18] this test is shelling out to php cli. [12:15:42] not critictal, just an fyi [12:15:50] awight: so for https://gerrit.wikimedia.org/r/#/c/integration/config/+/510459/ :) [12:16:04] awight: we should just disable the progress report instead of hardcoding COLUMNS=xx :] [12:16:12] thedj: please fill a task :) [12:16:22] hashar: k, will do [12:16:25] hashar: Can do. Shall I or did you already make the change? [12:16:26] that one is new to me at least [12:16:41] awight: if you are up to, yes please refine the change to just remove the '-p' [12:16:47] kk [12:17:01] (03PS2) 10Hashar: docker: mediawiki phan wrapper requires a path [integration/config] - 10https://gerrit.wikimedia.org/r/510936 (https://phabricator.wikimedia.org/T219114) [12:17:26] and the Wikibase case works with https://gerrit.wikimedia.org/r/#/c/integration/config/+/510936 hurrah [12:17:49] so I guess I will then merge both changes and add a third change that bumps mediawiki-phan/changelog entry refering to those two changes [12:18:57] 10Continuous-Integration-Infrastructure: php cli reports Unable to load dynamic library /usr/lib/php/20151012/zip.so - https://phabricator.wikimedia.org/T223903 (10TheDJ) [12:21:26] (03PS3) 10Awight: Reduce memory usage by omitting progress bar [integration/config] - 10https://gerrit.wikimedia.org/r/510459 (https://phabricator.wikimedia.org/T219114) [12:21:28] (03PS4) 10Awight: Bump mediawiki-phan container [integration/config] - 10https://gerrit.wikimedia.org/r/510140 (https://phabricator.wikimedia.org/T219114) [12:21:30] (03PS3) 10Awight: Use phan images with disabled progress bar [integration/config] - 10https://gerrit.wikimedia.org/r/510143 (https://phabricator.wikimedia.org/T219114) [12:21:49] hashar: I had a changelog patch ^ that can be abandoned, fwiw [12:24:01] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), 10Patch-For-Review, and 2 others: phan 1.2.6 is OOMing on MediaWiki core - https://phabricator.wikimedia.org/T219114 (10hashar) Yeah that sounds like a good migration plan :] And indeed on Jenkins we... [12:24:32] awight: and in https://gerrit.wikimedia.org/r/#/c/integration/config/+/510936/ I have updated the README.md ;) [12:26:06] (03CR) 10Awight: [C: 03+1] docker: mediawiki phan wrapper requires a path (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/510936 (https://phabricator.wikimedia.org/T219114) (owner: 10Hashar) [12:26:27] (03CR) 10Hashar: [C: 03+2] docker: mediawiki phan wrapper requires a path [integration/config] - 10https://gerrit.wikimedia.org/r/510936 (https://phabricator.wikimedia.org/T219114) (owner: 10Hashar) [12:27:53] (03Merged) 10jenkins-bot: docker: mediawiki phan wrapper requires a path [integration/config] - 10https://gerrit.wikimedia.org/r/510936 (https://phabricator.wikimedia.org/T219114) (owner: 10Hashar) [12:29:45] 10Project-Admins: Create a project for mediawiki extension Passwordless Login - https://phabricator.wikimedia.org/T223893 (10Aklapper) 05Open→03Resolved a:03Aklapper TODO: Creating an extension homepage on mediawiki.org (and then updating the project description) is welcome. :) Requested public project #P... [12:30:15] (03PS4) 10Hashar: docker: disable phan progress bar [integration/config] - 10https://gerrit.wikimedia.org/r/510459 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [12:31:52] awight: ok I am building all of that ;] [12:32:01] (03PS5) 10Hashar: Bump mediawiki-phan container [integration/config] - 10https://gerrit.wikimedia.org/r/510140 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [12:32:20] (03CR) 10Hashar: [C: 03+2] docker: disable phan progress bar [integration/config] - 10https://gerrit.wikimedia.org/r/510459 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [12:32:39] Right on [12:33:12] (03CR) 10Hashar: [C: 03+2] Bump mediawiki-phan container (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/510140 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [12:33:22] that was a mess [12:33:49] Sorry again that I proposed a bad fix, and thanks for all the follow-through. [12:34:04] If you think that was bad BTW, wait 'til you see my latest work ;-) https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/510709/ [12:34:17] (03Merged) 10jenkins-bot: docker: disable phan progress bar [integration/config] - 10https://gerrit.wikimedia.org/r/510459 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [12:34:41] (03Merged) 10jenkins-bot: Bump mediawiki-phan container [integration/config] - 10https://gerrit.wikimedia.org/r/510140 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [12:36:50] 10Phabricator (Upstream), 10Browser-Support-Google-Chrome, 10Upstream: Phabricator is showing a lot of scrollbars on comments (Google Chrome) - https://phabricator.wikimedia.org/T180887 (10Aklapper) 05Open→03Resolved Thanks for the ping and the quick reply! Closing as per last comment by the reporter. [13:03:04] 10Phabricator (Upstream), 10Upstream: Can't preview new titles and/or changes to task titles on the Phabricator - https://phabricator.wikimedia.org/T190610 (10Aklapper) I assume that some Wikimedia users who are new to Phabricator might expect a Phab task summary to allow some kind of formatting (for example,... [13:09:08] (03PS4) 10Hashar: Use latest phan images [integration/config] - 10https://gerrit.wikimedia.org/r/510143 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [13:11:21] !log updating phan jobs to use docker-registry.wikimedia.org/releng/mediawiki-phan:0.1.15 # T219114 [13:11:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:11:34] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Reconfiguring jenkins job mediawiki-core-php70-phan-docker" [integration/config] - 10https://gerrit.wikimedia.org/r/510143 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [13:11:34] T219114: phan 1.2.6 is OOMing on MediaWiki core - https://phabricator.wikimedia.org/T219114 [13:13:54] (03Merged) 10jenkins-bot: Use latest phan images [integration/config] - 10https://gerrit.wikimedia.org/r/510143 (https://phabricator.wikimedia.org/T219114) (owner: 10Awight) [13:13:59] 10Phabricator (Upstream), 10Upstream: Can't preview new titles and/or changes to task titles on the Phabricator - https://phabricator.wikimedia.org/T190610 (10epriestley) If the root problem here is something like "Users who are familiar with syntax X in tool Y may try to use that syntax when filing a task and... [13:17:21] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), 10Patch-For-Review, and 2 others: phan 1.2.6 is OOMing on MediaWiki core - https://phabricator.wikimedia.org/T219114 (10hashar) 05Open→03Resolved @awight update the container to disable the progre... [13:18:31] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:31:35] 10Beta-Cluster-Infrastructure: Packages broken on deployment-mediawiki-07 (libpcre3) - https://phabricator.wikimedia.org/T223801 (10Aklapper) [13:57:17] (03CR) 10Hashar: [C: 03+2] [GlobalUsage] Add phan [integration/config] - 10https://gerrit.wikimedia.org/r/511097 (owner: 10Umherirrender) [13:57:37] (03CR) 10Hashar: [C: 03+2] [GWToolset] Add phan [integration/config] - 10https://gerrit.wikimedia.org/r/510903 (owner: 10Umherirrender) [13:59:31] (03Merged) 10jenkins-bot: [GlobalUsage] Add phan [integration/config] - 10https://gerrit.wikimedia.org/r/511097 (owner: 10Umherirrender) [13:59:33] (03Merged) 10jenkins-bot: [GWToolset] Add phan [integration/config] - 10https://gerrit.wikimedia.org/r/510903 (owner: 10Umherirrender) [14:49:52] 10Release-Engineering-Team, 10Operations, 10SRE-Access-Requests: Request access to analytics cluster for Alaa Sarhan - https://phabricator.wikimedia.org/T223697 (10Volans) @alaa_wmde this requires explicit approval here on task from your manager at WMDE and from @Nuria (added in copy) from the Analytics team... [14:50:03] 10Release-Engineering-Team, 10Operations, 10SRE-Access-Requests: Request access to analytics cluster for Alaa Sarhan - https://phabricator.wikimedia.org/T223697 (10Volans) p:05Triage→03Normal [14:56:07] 10Continuous-Integration-Config, 10phan: phan issue due to a composer dev dependency - https://phabricator.wikimedia.org/T223397 (10hashar) In T223397#5185404 I have missed the fact that `dockerfiles/ci-src-setup/setup-mwext.sh` ran composer update from mediawiki/core with `--no-dev` whereas Quibble runs witho... [15:19:09] (03PS1) 10Hashar: phan: do not install mediawiki dev dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/511447 (https://phabricator.wikimedia.org/T223397) [15:19:37] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10phan: phan issue due to a composer dev dependency - https://phabricator.wikimedia.org/T223397 (10hashar) p:05Triage→03Normal a:03hashar [15:21:15] (03PS2) 10Hashar: phan: do not install mediawiki dev dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/511447 (https://phabricator.wikimedia.org/T223397) [15:22:21] (03CR) 10jerkins-bot: [V: 04-1] phan: do not install mediawiki dev dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/511447 (https://phabricator.wikimedia.org/T223397) (owner: 10Hashar) [15:27:45] 10Release-Engineering-Team, 10Operations, 10SRE-Access-Requests: Request access to deployment cluster for Alaa Sarhan - https://phabricator.wikimedia.org/T223698 (10Volans) p:05Triage→03Normal @alaa_wmde this requires explicit approval here on task from your manager at WMDE and from @greg from the Releas... [15:34:57] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10phan: phan issue due to a composer dev dependency - https://phabricator.wikimedia.org/T223397 (10hashar) The workaround was to do: ` lang=php // @phan-suppress-next-line PhanRedefinedInheritedInterface abstract clas... [15:39:36] (03PS3) 10Hashar: phan: do not install mediawiki dev dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/511447 (https://phabricator.wikimedia.org/T223397) [15:40:15] (03CR) 10Hashar: "That should fix T223397. Will update the jobs on Tuesday since I can not watch the aftermath of a deployment today." [integration/config] - 10https://gerrit.wikimedia.org/r/511447 (https://phabricator.wikimedia.org/T223397) (owner: 10Hashar) [15:45:56] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10phan: phan issue due to a composer dev dependency - https://phabricator.wikimedia.org/T223397 (10hashar) I will update the job configuration on Tuesday. Then I guess we have to remove the various `@phan-suppress-nex... [15:47:56] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10phan: phan issue due to a composer dev dependency - https://phabricator.wikimedia.org/T223397 (10Umherirrender) For EventLogging I have uploaded a patch set For GrowthExperiments you can revert https://gerrit.wikim... [16:00:00] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10phan: phan issue due to a composer dev dependency - https://phabricator.wikimedia.org/T223397 (10hashar) Thank you @Umherirrender . I will do the update tomorrow :] [16:19:33] 10Release-Engineering-Team (Watching / External), 10Operations, 10SRE-Access-Requests, 10Patch-For-Review: Grant James Forrester access to contint-admins and contint-docker, and to the ciadmin LDAP group - https://phabricator.wikimedia.org/T223137 (10Volans) @Jdforrester-WMF did you had a chance to check a... [16:40:37] 10Beta-Cluster-Infrastructure, 10Patch-For-Review, 10Technical-Debt: Set up LVS in beta like prod - https://phabricator.wikimedia.org/T196662 (10Andrew) [16:48:36] 10Release-Engineering-Team (Watching / External), 10Operations, 10SRE-Access-Requests, 10Patch-For-Review: Grant James Forrester access to contint-admins and contint-docker, and to the ciadmin LDAP group - https://phabricator.wikimedia.org/T223137 (10Jdforrester-WMF) 05Open→03Resolved a:03ArielGlenn... [16:52:15] Yippee, build fixed! [16:52:15] Project mediawiki-core-code-coverage-docker build #4261: 09FIXED in 1 hr 52 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-docker/4261/ [16:52:48] (03CR) 10Thcipriani: [C: 03+2] pipeline: Fix invalid SETUP/TEARDOWN const references [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510271 (owner: 10Dduvall) [16:53:01] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Clarify that spaces are not allowed in Phabricator usernames when creating an account - https://phabricator.wikimedia.org/T179126 (10Aklapper) Indeed, there is a one byte difference in the string now so strings don't match. Let me cook u... [16:53:45] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510271 (owner: 10Dduvall) [16:53:47] (03Merged) 10jenkins-bot: pipeline: Fix invalid SETUP/TEARDOWN const references [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510271 (owner: 10Dduvall) [16:54:24] (03CR) 10jenkins-bot: pipeline: Fix invalid SETUP/TEARDOWN const references [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510271 (owner: 10Dduvall) [17:06:27] 10Release-Engineering-Team, 10MobileFrontend, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs - https://phabricator.wikimedia.org/T221860 (10pmiazga) a:03pmiazga [17:08:12] 10Phabricator, 10Patch-For-Review: Clarify that spaces are not allowed in Phabricator usernames when creating an account - https://phabricator.wikimedia.org/T179126 (10Aklapper) a:05mmodell→03Aklapper [17:13:11] (03CR) 10Thcipriani: [C: 03+2] pipeline: Allow for execution of a single pipeline [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510274 (owner: 10Dduvall) [17:13:55] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510274 (owner: 10Dduvall) [17:13:57] (03Merged) 10jenkins-bot: pipeline: Allow for execution of a single pipeline [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510274 (owner: 10Dduvall) [17:14:19] (03CR) 10jenkins-bot: pipeline: Allow for execution of a single pipeline [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510274 (owner: 10Dduvall) [17:15:35] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace._srv.byte_percentfree (<100.00%) [17:17:34] 10Phabricator, 10Regression: Phabricator login page does not show Welcome text / "Click button below" text anymore - https://phabricator.wikimedia.org/T223926 (10Aklapper) [18:36:33] why does phabricator alert me that someone wrote on a task that i cannot see but am subscribed to, but not on a task i can see and subscribed to? [18:50:32] (03Restored) 10Hashar: Create selenium-daily-beta-AdvancedSearch Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [18:51:32] (03CR) 10Hashar: "I abandoned the change since I thought the initiative has been abandoned. I guess we just need an email to send notifications to then red" [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [18:52:10] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10hashar) @Tobi_WMDE_SW I have reopened it :] Can you suggest on the change a... [20:06:19] 10Phabricator, 10Patch-For-Review: Clarify that spaces are not allowed in Phabricator usernames when creating an account - https://phabricator.wikimedia.org/T179126 (10Dzahn) >>! In T179126#5198383, @Aklapper wrote: > Indeed, there is a one byte difference in the string now so strings don't match. Yep, though... [20:13:19] (03PS2) 10Dduvall: pipeline: Use registry discovery name when registering images [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510600 [20:13:46] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510600 (owner: 10Dduvall) [20:29:35] (03PS8) 10Awight: Create selenium-daily-beta-AdvancedSearch Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [20:30:58] (03CR) 10Awight: [C: 03+1] "PS8: Looks like the maintainer is WMDE Technical Wishes: https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/AdvancedSearch" [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [20:47:57] (03CR) 10Thcipriani: [V: 03+2 C: 03+2] Merge tag 'v2.15.13' into wmf/stable-2.15 [software/gerrit] (wmf/stable-2.15) - 10https://gerrit.wikimedia.org/r/505801 (owner: 10Paladox) [21:04:12] thcipriani: at some point, I had been asking you about spinning up a database during functional tests (ran via CI), and you helpfully suggested an example I could template from [21:04:28] thcipriani: and then I lost track of it [21:04:39] :( [21:05:04] thcipriani: I think it was something that spun up mysql, would you happen to still have that handy? [21:05:55] urandom: hrm, quibble definitely does spin up mysql for phpunit tests that require the db, but I don't recall if that's what I was talking about or not :) [21:06:44] thcipriani: quibble doesn't sound familiar, but that doesn't mean that wasn't it :) [21:07:39] you probably want an example to work from for kask tests? [21:08:47] thcipriani: yeah :) [21:09:51] I don't know that we have anything that uses a database during helm test at the moment, but perhaps something like what we do for tox-mysqld could be adapted to run with helm test: https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/dockerfiles/tox-mysqld [21:10:18] ^ marxarelli you may have gone further down thinking about this path than I have [21:10:38] so, how is helm test used? [21:10:48] what role does that fill? [21:10:58] * marxarelli reads [21:12:36] i think we talked a bit about this kind of thing last week in our team's Deployment Pipeline meeting [21:12:45] helm test is used before your image is promoted for production use in the pipeline. The idea is that it can be used for integration tests that involve multiple services; i.e., you could spin up a container that run mysqld, spin up a kask container, and spin up another container that exercises that stack. The current use is spinning up, say, a mathoid instance and spinning up service-checker to [21:12:46] exercise mathoid [21:13:41] hrmm [21:13:50] right, so `helm test` can create any number of k8s resources meant to exercise tests against a deployment [21:14:14] but in the case urandom is describing, i think you'd need to deploy a temporary mysql install as well [21:14:23] Cassandra, actually [21:14:28] ah, right [21:14:54] would that not be possible to do as part of helm test? [21:15:02] so, kask has unit, functional, and integration tests [21:15:12] so in which case, your helm chart requirements need to (conditionally, for test cases only) reference a version of cassandra (chart) [21:15:33] functional just tests the... i dunno, "DAO" for Cassandra [21:15:45] it would technically be part of the deployment (resources created by `helm install`, not `helm test`) [21:16:34] `helm test` is relying on the resources as they would exist in production? [21:16:52] because for session storage (or anything else AFAIK), we're not using Cassandra containers [21:18:06] nm, I missed a message above "...(conditionally, for test cases only) reference a version of cassandra (chart)" [21:18:22] helm test templates are given the release (referenced as `.Release` in the template) previously created by a `helm install` run [21:19:02] they can also reference the same `.Values` set by helm during the install, afaict [21:23:10] 10Phabricator, 10Patch-For-Review: Clarify that spaces are not allowed in Phabricator usernames when creating an account - https://phabricator.wikimedia.org/T179126 (10Aklapper) 05Open→03Resolved Works now; it shows: `Usernames must contain only numbers, Latin letters, period, underscore and hyphen, and ca... [21:24:20] http://gph.is/1E7ygMm [21:24:21] urandom: do you have a helm chart for kask already? maybe we could play around with it a bit [21:24:37] marxarelli: I honestly don't know [21:24:49] marxarelli: I think so... I think there is something [21:25:39] marxarelli: would this be the preferred way to do anything NOT a unit test then? [21:26:31] there's this https://gerrit.wikimedia.org/r/plugins/gitiles/operations/deployment-charts/+/master/charts/kask/ [21:27:05] which runs the service-checker helm test it seems https://gerrit.wikimedia.org/r/plugins/gitiles/operations/deployment-charts/+/master/charts/kask/templates/tests/test-service-checker.yaml [21:27:23] urandom: not preferred per se, but it's how we've imagined this kind of integration testing would/will work with the pipeline in its current implementation. this is unchar... new territory for us :) [21:27:49] I see [21:28:21] OK, we have functional tests that we had imagined running via CI, when unit tests were ran [21:28:49] and that they'd contribute to a gerrit changeset in the same way [21:29:04] (thcipriani: let's put this on the agenda for tomorrow's meeting) [21:29:16] * thcipriani does [21:29:26] all they currently do is test with the actually CassandraStore what the unit tests do with a mock one [21:29:34] s/actually/actual/ [21:30:18] a helm test would be something kicked off manually though? is that right? [21:30:33] something you'd do prior to deploying a particular image? [21:30:41] 10Release-Engineering-Team, 10MobileFrontend, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs - https://phabricator.wikimedia.org/T221860 (10pmiazga) Tests are green, looks like the iss... [21:31:18] 10Release-Engineering-Team, 10MobileFrontend, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs - https://phabricator.wikimedia.org/T221860 (10pmiazga) 05Open→03Resolved [21:31:31] urandom: not manually, no. they should be kicked off by the deployment pipeline [21:31:55] marxarelli: when does the deployment pipeline run? [21:31:56] 10Release-Engineering-Team, 10Scap, 10MediaWiki-ResourceLoader, 10Performance-Team, and 2 others: Scap deployments are not purging MessageBlobStore (was: Stale localized messages) - https://phabricator.wikimedia.org/T222539 (10Krinkle) [21:32:34] urandom: helm test currently only happens on gate-and-submit, but it does happen automatically [21:32:56] so only if you +2 a change [21:33:02] thcipriani: does that mean.... OK [21:33:40] pre-merge of the change and pre pushing to the production registry [21:33:54] right now, we have a fairly static deployment pipeline job that 1) builds the "test" variant"; 2) runs the "test" variant entrypoint; 3) builds the "production" variant; 4) deploys that image to a ci k8s namespace using `helm install`; 4) tests that deployment by running `helm test` which can create any number of ephemeral k8s pods that exercise the deployment; 5) tears down the deployment created by `helm install`; 6) tags/publishes [21:33:54] the image [21:34:47] OK, that helps [21:34:57] hopefully soonish (patches are being reviewed and thoroughly tested) that entire pipeline process can be defined by teams themselves [21:35:35] but I guess that still leaves me wondering, will the New World Order prefer this to the sort of functional tests we have? [21:35:36] * marxarelli looks for 5-minute demo recording [21:35:38] example of a pipeline run with test deployment: https://integration.wikimedia.org/ci/blue/organizations/jenkins/service-pipeline-test-and-publish/detail/service-pipeline-test-and-publish/113/pipeline/39 [21:36:31] sounds easier to spin up a Cassandra container via helm than otherwise [21:36:44] urandom: the exact test implementations are really up to you. if those mocked tests work for your software and your team, than we need to support entrypoints for that. if you think system-level integration tests make more sense, we need to support that too [21:37:35] we just haven't proven our current deployment pipeline to do the latter yet [21:40:18] urandom: basically what i just described but also shows some of the upcoming pipeline capabilities https://www.youtube.com/watch?v=IvVYM3tjnlg [21:41:25] marxarelli: thanks, I'll have a look [22:16:25] (03CR) 10Thcipriani: [C: 03+2] "Seems like this should be backwards compatible with current integration/config" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510600 (owner: 10Dduvall) [22:17:11] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510600 (owner: 10Dduvall) [22:17:13] (03Merged) 10jenkins-bot: pipeline: Use registry discovery name when registering images [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510600 (owner: 10Dduvall) [22:17:36] (03CR) 10jenkins-bot: pipeline: Use registry discovery name when registering images [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510600 (owner: 10Dduvall) [22:19:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10Operations, 10SRE-Access-Requests: Request: add awight to contint-docker - https://phabricator.wikimedia.org/T223262 (10Dzahn) a:03Tobi_WMDE_SW [22:21:11] 10Release-Engineering-Team (Kanban), 10Operations, 10SRE-Access-Requests, 10User-Urbanecm, 10User-greg: Requesting access to production for SWAT deploy for Urbanecm - https://phabricator.wikimedia.org/T192830 (10Dzahn) a:03greg @greg So this is approved by you? [22:51:33] (03CR) 10PipelineBot: "pipeline-dashboard: thcipriani-service-pipeline-test" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/510600 (owner: 10Dduvall) [22:55:08] (03CR) 10Thcipriani: [C: 03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 2" [integration/config] - 10https://gerrit.wikimedia.org/r/510605 (owner: 10Dduvall) [22:57:28] (03Merged) 10jenkins-bot: service-pipeline: Use registries defined by pipelinelib [integration/config] - 10https://gerrit.wikimedia.org/r/510605 (owner: 10Dduvall) [23:11:10] 10Phabricator, 10CommRel-Design, 10CommRel-Internals: Create Phabricator form for CommRel-Design and Comms requests and add a link to it in the "Star" dropdown - https://phabricator.wikimedia.org/T223102 (10mcruzWMF) >>! In T223102#5185872, @Aklapper wrote: >>>! In T223102#5185432, @mcruzWMF wrote: >> We nee... [23:15:52] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10MediaWiki-Documentation, 10Regression, 10Upstream: Doxygen search.php no longer works on doc.wikimedia.org - https://phabricator.wikimedia.org/T218233 (10Krinkle) Bump. This came up again at the Hackathon and made documentation signif... [23:19:48] 10Phabricator, 10CommRel-Design, 10CommRel-Internals: Create Phabricator form for CommRel-Design and Comms requests and add a link to it in the "Star" dropdown - https://phabricator.wikimedia.org/T223102 (10mcruzWMF) @Aklapper: 1. Can we change the name of [[ https://phabricator.wikimedia.org/transactions/e... [23:49:55] 10Phabricator, 10CommRel-Design, 10CommRel-Internals: Create Phabricator form for CommRel-Design and Comms requests and add a link to it in the "Star" dropdown - https://phabricator.wikimedia.org/T223102 (10Aklapper) >>! In T223102#5199076, @mcruzWMF wrote: > 1. Can we change the name of [[ https://phabricat...