[00:04:42] (03PS2) 10Jforrester: jjb: Migrate docker-setup-mwext-for-phan to node10 quibble, too [integration/config] - 10https://gerrit.wikimedia.org/r/514190 [00:05:04] (03CR) 10Jforrester: [C: 03+2] jjb: Migrate docker-setup-mwext-for-phan to node10 quibble, too [integration/config] - 10https://gerrit.wikimedia.org/r/514190 (owner: 10Jforrester) [00:08:13] (03Merged) 10jenkins-bot: jjb: Migrate docker-setup-mwext-for-phan to node10 quibble, too [integration/config] - 10https://gerrit.wikimedia.org/r/514190 (owner: 10Jforrester) [00:09:39] (03CR) 10Awight: [C: 03+1] "I think this is right, but let's wait for @fr-tech to decide. If they aren't relying on any browser tests or custom npm scripts, there sh" [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [00:10:01] What is that job... [00:10:40] !log jjb: Migrated docker-setup-mwext-for-phan to node10 quibble [00:10:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [00:11:51] Does that quibble-donationinterface job exist only to provide a custom list of extensions? [00:14:13] awight: Probably. [00:14:28] * awight shudders [00:14:51] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205039 (10Reedy) [00:14:54] 10MediaWiki-Releasing, 10Security: Tag MW 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205047 (10Reedy) 05Open→03Resolved ` $ git push --tags Enumerating objects: 16, done. Counting objects: 100% (16/16), done. Delta compression using up to 2 threads Compressing objects: 100% (12/12), d... [00:14:58] Yeah, CI is dark and full of terrors. [00:15:40] Maybe it can be simplified by passing some quibble args. Now I need to read my kids' rainbow unicorn books to drive these horrors from my mind. [00:15:49] * awight poofs [00:24:04] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205039 (10Reedy) [00:24:07] 10MediaWiki-Releasing, 10Documentation, 10Security: Update CVEs and publish them - https://phabricator.wikimedia.org/T225149 (10Reedy) 05Open→03Resolved a:03Reedy This should be done... Might take MITRE a little while to process the updates [00:24:28] 10MediaWiki-Releasing, 10Patch-For-Review, 10Security: Update HISTORY in master after 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205046 (10Reedy) a:03Reedy [00:31:01] 10MediaWiki-Releasing, 10Security: Update HISTORY in master after 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205046 (10Reedy) [00:31:25] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205039 (10Reedy) [00:31:28] 10MediaWiki-Releasing, 10Security: Update HISTORY in master after 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205046 (10Reedy) 05Open→03Resolved [00:34:26] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205039 (10Jdforrester-WMF) [00:34:29] 10MediaWiki-Releasing, 10Security: Update onwiki release notes for 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205044 (10Jdforrester-WMF) 05Open→03Resolved [00:34:38] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Patch-For-Review: Drop php55 testing support - https://phabricator.wikimedia.org/T224907 (10Jdforrester-WMF) [00:34:40] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2 - https://phabricator.wikimedia.org/T205039 (10Jdforrester-WMF) 05Open→03Resolved [00:35:19] (03PS2) 10Jforrester: jjb: Migrate quibble-donationinterface-{branch}-php70-docker to node10 quibble [integration/config] - 10https://gerrit.wikimedia.org/r/514191 [00:35:27] (03CR) 10jerkins-bot: [V: 04-1] jjb: Migrate quibble-donationinterface-{branch}-php70-docker to node10 quibble [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [00:36:33] (03PS3) 10Jforrester: jjb: Migrate quibble-donationinterface-{branch}-php70-docker to node10 quibble [integration/config] - 10https://gerrit.wikimedia.org/r/514191 [01:15:33] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10mmodell) I tried again to create the branches today. Gerrit rejects my requests. I was under the impression from speaking to @thci... [01:17:20] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Paladox) @mmodell using your ldap creds will work (i've done that before and simply curl --user :'' http://gerrit.... [01:19:41] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Paladox) ` curl https://gerrit.wikimedia.org/r/adiawiki%2Fextensions%2F3D/branches/REL1_33 --user paladox: )]}' { "web_lin... [01:28:08] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Paladox) curl https://gerrit.wikimedia.org/r/a/projects/mediawiki%2Fextensions%2F3D/branches/REL1_33 --user paladox: -X PUT... [01:38:31] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10mmodell) @paladox: the request is a http PUT not GET. I get the same error 401 from every extension. I verified that I'm authent... [01:50:01] thcipriani: Do I need to do anything with the security patches on deploy1001 that are no longer required? [02:02:31] 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Browser-Tests: Proposal to move browser based tests (Selenium and QUnit) to a non-voting pipeline - https://phabricator.wikimedia.org/T225248 (10kostajh) Thank you everyone for the discussion! > that non-voting tests will become meaningles... [02:02:43] 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Browser-Tests: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline - https://phabricator.wikimedia.org/T225248 (10kostajh) [02:17:27] Reedy: delete them from /srv/patches? [02:21:00] thcipriani hi, around? [02:23:13] apparently twentyafterfour has gotten a username that has broken integration with ldap (e.g anything over https is broken when authing, though the UI works for him). [02:23:55] heh I'm not alone [02:24:04] there's others? :P [02:24:07] a bunch of people have broken gerrit accounts currently [02:24:20] oh, yeh, your's is not link to those ones :) [02:24:28] lots of the duplicate errors due to mixed case usernames [02:24:36] you were just assigned a username that appears to break with ldap integration. [02:24:42] oh, yeh [02:24:47] lots of people have that situation too [02:25:16] I don't actually know where gerrit gets the username from [02:25:20] and up till recently created an account even if the pass was incorrect. [02:25:29] twentyafterfour ldap. [02:25:30] i think [02:25:42] twentyafterfour: Delete from the current branch? [02:25:56] It just feels a bit odd doing so when we've not backported in gerrit (should we?) [02:26:09] Not like there's any rush, no train next week [02:29:08] hmm [02:29:26] looking back through the stuff, the username should be what you typed into "login" [02:29:57] Reedy: yeah remove them from the current version because that'll prevent them from getting carried forward next time [02:30:20] since they are already applied on the actual branch it doesn't hurt to remove them from /srv/patches [02:35:19] accountSshUserName is the uuid [02:35:47] so i guess gerrit just wanted to annoy you twentyafterfour :P (unless your uuid in ldap is twentyafterfour) [02:35:50] 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Browser-Tests: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline - https://phabricator.wikimedia.org/T225248 (10kostajh) [02:39:12] paladox: my shell username is twentyafterfour [02:41:11] Oh [02:41:29] I think the shell is provisioned by puppet rather then ldap [02:41:35] (In prod) [02:44:25] Though if your uuid in ldap is 20after4 then gerrit either has a bug, or had a bug back when your account was created [02:45:15] why would there be 2 usernames in ldap I really don't understand [02:45:40] I mean why would I ever want to have my gerrit username be different from what I log in with [02:45:44] it's all insane IMO [02:45:51] You wouldn’t [02:46:18] At least it would be confusing :P [02:46:28] it is confusing [02:46:30] :P [02:46:35] Heh [02:46:44] Couldn’t we change your username in gerrit [02:46:56] Though that would need testing first [03:18:45] 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Browser-Tests: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline - https://phabricator.wikimedia.org/T225248 (10mmodell) >>! In T225248#5242249, @kostajh wrote: > Maybe a better starting point than my subject... [03:56:00] 10Release-Engineering-Team, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (10notconfusing) I find the CSP error happening diferently on different language Wikis.... [03:57:44] 10Release-Engineering-Team, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (10notconfusing) Am I correct in thinking that CentralNotice banners that are displayed o... [03:58:18] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<33.33%) [04:24:18] (03CR) 10Ejegg: [C: 03+1] "Thanks Jforrester and awight. This should be fine to merge!" [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [05:02:18] 10Release-Engineering-Team, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (10Ejegg) @notconfusing yep, you are correct. This CSP is only applied on a forced banner... [06:53:19] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:18:35] (03PS4) 10Hashar: Composer dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513498 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:18:58] (03CR) 10Hashar: [C: 03+2] "Rebased. We can find a better name for ComposerComposerDependencies later :D" [integration/quibble] - 10https://gerrit.wikimedia.org/r/513498 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:19:39] (03Merged) 10jenkins-bot: Composer dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513498 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:20:09] (03CR) 10jenkins-bot: Composer dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513498 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:22:26] (03CR) 10Hashar: [C: 03+2] Vendor dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513503 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:25:36] (03CR) 10Hashar: [C: 03+2] Vendor dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513503 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:27:13] (03PS3) 10Hashar: Vendor dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513503 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:27:23] (03CR) 10Hashar: [C: 03+2] Vendor dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513503 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:27:29] (03PS3) 10Hashar: Composer and npm test as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513504 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:28:04] (03Merged) 10jenkins-bot: Vendor dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513503 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:28:34] (03CR) 10jenkins-bot: Vendor dependencies as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513503 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:30:56] (03PS3) 10Hashar: Npm install as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513510 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:31:31] (03PS1) 10Awight: Rename native composer command [integration/quibble] - 10https://gerrit.wikimedia.org/r/515009 [07:31:50] (03CR) 10jerkins-bot: [V: 04-1] Rename native composer command [integration/quibble] - 10https://gerrit.wikimedia.org/r/515009 (owner: 10Awight) [07:31:53] (03CR) 10Hashar: [C: 03+2] Npm install as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513510 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:31:56] I'm just adding minor fixups to the end of ^ the chain, not touching anything you might review... [07:32:33] (03Merged) 10jenkins-bot: Npm install as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513510 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:33:04] (03CR) 10jenkins-bot: Npm install as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513510 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:35:55] (03PS3) 10Hashar: MediaWiki installation... as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513520 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:36:18] (03CR) 10Hashar: "Cherry picked against tip of master." [integration/quibble] - 10https://gerrit.wikimedia.org/r/513520 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:36:35] (03CR) 10jerkins-bot: [V: 04-1] MediaWiki installation... as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513520 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:37:52] hashar: Holler whenever you need a break, and I can clean up my mess. [07:38:07] awight: ahh good morning :] [07:38:24] I want to merge in the MediaWiki install as a command [07:38:24] Thanks for the persistence :-) [07:38:29] and then I will look at all the test command [07:38:46] I think my concern with the test commands is that they are just wrappers for the actual commands in quibble/test.py [07:38:46] ;D [07:39:31] Are you already fixing https://gerrit.wikimedia.org/r/513520 or should I? [07:39:45] yes [07:39:48] on it [07:39:54] but I am puzzled on the removal of def copylog [07:39:56] ;-) [07:40:21] oh that was only needed by commands, so I moved it out of cmd.py to prevent a circular dependency. [07:41:13] but some other patches also moved a copylog method bah [07:42:21] hmm [07:42:35] yeah that is the Vendor to commands 64f6301193024aca7434cb54d476fcc2ea0f8072 [07:42:36] :D [07:43:00] weird, I thought I had rebased everything cleanly last night... [07:43:34] https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/513503/ adds the util.py copylog, but doesn't remove the cmd.py one yet [07:43:56] azrgh [07:44:11] so copylog was really just an helper to copyfile() to the logdir ;D [07:44:23] yeah i wouldn't mind seeing it inlines [07:44:25] *inlined [07:44:35] but it's reused a few times, so I donno... [07:45:04] that was to avoid having to repeat a os.path.join(self.log_dir [07:45:05] ;D [07:46:35] On a side note, today is WMDE's work-related hackathon, so I might have some time to poke at things. In particular, I'd be interested in working on https://phabricator.wikimedia.org/T225193, if you have any insights or obstacles please do add to the task! [07:47:14] (03PS4) 10Hashar: MediaWiki installation... as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513520 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:47:39] awight: this afternon I will work again on the migration of civicrm to the docker container [07:48:02] 10Beta-Cluster-Infrastructure, 10MinervaNeue (Desktop): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva skin - https://phabricator.wikimedia.org/T225279 (10Etonkovidova) [07:48:08] Nice. Ping me with any questions or subtasks. [07:49:49] (03CR) 10Hashar: [C: 03+2] "I have a concern with copylog() which changed semantic. However that comes from a previous change ;D" [integration/quibble] - 10https://gerrit.wikimedia.org/r/513520 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:50:29] (03Merged) 10jenkins-bot: MediaWiki installation... as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513520 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:50:58] (03CR) 10jenkins-bot: MediaWiki installation... as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513520 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [07:53:59] hashar: As for the test commands being thin wrappers, maybe we should move test.py content into commands? I'm personally fine with thin wrappers, since the Command single responsibility can be considered simply containing and decoupling parameters... but keeping the app's style consistent is fine with me, just lmk how I should tweak. [07:54:13] s/fine with me/seems like a good idea/ [08:01:42] 10Continuous-Integration-Infrastructure: CI monitoring to detect flapping tests, especially in unrelated gated extensions - https://phabricator.wikimedia.org/T225193 (10hashar) OpenStack had a similar need and they wrote a reporter which collect and analyze tests and create a nice report. https://www.elastic.co... [08:02:17] awight: I am fine breaking the current coding style [08:02:30] really it originated as a single file schell script [08:02:40] eventually I tried a rewrite using GNU Make [08:02:44] and moved to python [08:02:59] but the very first iteration of Quibble was really just a single file with no class iirc [08:03:24] I moved the test commands to their own file to increase clarity when reading the main quibble/cmd.py [08:03:39] the same way you are now dramatically increasing clarity by moving most commands from cmd.py to commands.py [08:03:40] so yeah [08:03:51] essentially stuff in test.py and commands.py are the same [08:04:12] with test.py being a subset of commands that are actually running tests ;] [08:06:04] > a rewrite using GNU Make => baahahaa. bold. [08:06:55] yeah [08:06:56] ;] [08:07:06] Well it's your repo anyway, I'm sure I'll drift away into the night after some point. Just let me know what conventions will be annoying to you in the future, and I'm happy to learn. [08:07:27] -1 [08:07:34] it is OURs [08:07:45] * awight jumps from the bridge [08:07:59] and I am more than happy to see someone else jumping in the code base and making it more like an actual software [08:07:59] Hey, thanks for the awesome input on T225193! [08:08:00] T225193: CI monitoring to detect flapping tests, especially in unrelated gated extensions - https://phabricator.wikimedia.org/T225193 [08:08:06] instead of the half baked script I wrote ;D [08:09:42] I spent 2.5 years towards the beginning of my so-called career nursing a cathedral of multi-platform makefiles. Back when there were different Make syntaxes for each system ^^'. For some reason though, I'm still fond of tinkering with make, I think it's a pretty good system. [08:09:56] But thank you for choosing Python. [08:18:16] 10Continuous-Integration-Infrastructure: CI monitoring to detect flapping tests, especially in unrelated gated extensions - https://phabricator.wikimedia.org/T225193 (10hashar) Another thought: Zuul pipelines can have several reporters. The only one we use for now is the `gerrit` reporter which send a review bac... [08:22:12] awight: yeah python is way easier to step in. Even has a beginner or not being familiar with python itself [08:22:30] I find it rather straightforward, once the editor is properly configured to handle the weird "indentation is syntax" thing [08:40:41] 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Browser-Tests, 10User-zeljkofilipin: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline - https://phabricator.wikimedia.org/T225248 (10zeljkofilipin) [08:47:58] 10Project-Admins: Create a project for Wikilink - https://phabricator.wikimedia.org/T225065 (10Samwalton9) Done - thanks for flagging that @MGChecker :) [08:53:16] 10Continuous-Integration-Infrastructure, 10Browser-Tests, 10Code-Health, 10User-zeljkofilipin: Automate identifying flaky tests - https://phabricator.wikimedia.org/T224673 (10zeljkofilipin) [09:09:01] aargh yeah I am not a fan of the indentation regime. Viva curly braces! [09:10:33] CI metrics probably won't become a project today--but I know colleagues will be interested over the next few weeks. [09:27:23] awight: I think twentyafterfour has/had meeting with analytics for that. Something named data^3 [09:27:26] after data data data [09:28:52] :) [09:30:26] twentyafterfour: good night ;] awight / berlin are wondering how to collect data from the tests and do some analysis on reasons for "recheck" ;D [09:30:29] that is the teaser [09:32:22] (03CR) 10Hashar: Core npm composer test as command (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/513515 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [09:32:28] awight: https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/513515/2/quibble/commands.py ;D [09:33:02] awight: i think we should just move all the quibble/test.py material into quibble/commands.py . With maybe the execption of run_webdriver() which can be moved to backend.py [09:33:33] The main problem so far is where to store the data for things like this [09:33:36] I don't mind reworking some of your changes, the one to run composer/npm for mediawiki/core is straightforward ( https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/513515/ ) [09:34:48] twentyafterfour: I thought at the offiste we envisioned junit/test results to elasticsearch, potentially console logs as well [09:35:16] but yeah we probably want to write down what we currently have and figure out a solution with analytics team I guess [09:35:24] hashar: yes but we don't "own" any elasticsearch clusters [09:35:32] yeah [09:35:44] we need the infrastructure. I guess we could run something in labs [09:35:54] so the devil would be to find a team willing to offer us the ElasticSearch service and baby sit it for us [09:36:12] WMCs that is good for a prototype, but it comes with its own challenge as well [09:36:13] hashar: it sucks being sans-hardware [09:36:17] ;] [09:36:44] it's the biggest roadblock every time I want to do anything with data.. well where to put it? [09:36:47] contint1001 is receiving some additional 1TB disk and has plenty of CPU/RAM. So maybe we can setup something there [09:37:14] or define the data and "outsource" it to the analytics team [09:37:40] hashar: yeah but that seems like quite a bunch of hoops to jump through [09:42:05] twentyafterfour: i am sure its doable without too much hassles [09:43:34] If that was the case it wouldn't take half a year and still not be done [10:14:44] (03CR) 10Hashar: [C: 04-1] phpunit tests as command (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/513513 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [10:21:33] hashar: one of slowest tests in wikibase is slow because it sleeps for 8 seconds to make sure ttl is expired :] [10:21:39] I'm trying to fix that [10:23:31] (03PS4) 10Hashar: jjb: Migrate quibble-donationinterface-{branch}-php70-docker to node10 quibble [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [10:23:49] 10Beta-Cluster-Infrastructure, 10MinervaNeue (Desktop): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva skin: "SkinOption tabsOnSpecials doesn't exist" - https://phabricator.wikimedia.org/T225279 (10Aklapper) [10:24:05] (03CR) 10Hashar: "I have made to use the latest version of releng/quibble-stretch-php70 which is 0.0.31-5" [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [10:27:40] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 1" [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [10:29:55] (03Merged) 10jenkins-bot: jjb: Migrate quibble-donationinterface-{branch}-php70-docker to node10 quibble [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [10:32:27] (03CR) 10Awight: Core npm composer test as command (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/513515 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [10:33:07] hashar: Is this a good time for me to start amending and rebasing? [10:39:04] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Wikidata, and 5 others: Introduce wikidata termbox SSR to kubernetes - https://phabricator.wikimedia.org/T220402 (10akosiaris) @tarrow, @WMDE-leszek Hi, sorry for taking so long to answer to this, it's been really busy. >>! In T220402#521447... [10:43:06] Just discovered that the parallel_run tests are not so nice to port into commands.py [10:44:06] This is a refactor I was hoping to tackle later: individual tasks would become commands, and the execution engine would be able to parallelize based on the way we define dependencies between tasks. [10:44:39] I'll try to do the MVP port for now. [10:45:55] PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [140.0] https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [10:46:16] 10Continuous-Integration-Infrastructure, 10Browser-Tests, 10Code-Health, 10User-zeljkofilipin: Automate identifying flaky tests - https://phabricator.wikimedia.org/T224673 (10hashar) [11:03:11] 10Phabricator, 10CommRel-Design, 10CommRel-Internals: Create Phabricator form for CommRel-Design and Comms requests and add a link to it in the "Star" dropdown - https://phabricator.wikimedia.org/T223102 (10Elitre) FWIW, I think the checkboxes at https://phabricator.wikimedia.org/T225036 are confusing, becau... [11:06:16] hashar: btw. I merged the patch on slow tests on Cirrus, it seems it's way faster now [11:07:00] 10Continuous-Integration-Infrastructure, 10Browser-Tests, 10Code-Health, 10User-zeljkofilipin: Automate identifying flaky tests - https://phabricator.wikimedia.org/T224673 (10hashar) I have edited the task description to show comments matching `\nrecheck` in the database, though the comments are no more in... [11:07:28] awight: well we can port parallel_run as is and refactor later ;] [11:07:36] Amir1: great! thank you dcausse :] [11:26:50] foood etc [11:31:24] RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 30.00% above the threshold [90.0] https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [11:32:25] 10Beta-Cluster-Infrastructure, 10MinervaNeue (Desktop): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva skin: "SkinOption tabsOnSpecials doesn't exist" - https://phabricator.wikimedia.org/T225279 (10pmiazga) caused by {1e87c621918b3fccbb606f3b4df71cea2e438d9... [11:37:30] 10Phabricator, 10CommRel-Design, 10CommRel-Internals: Create Phabricator form for CommRel-Design and Comms requests and add a link to it in the "Star" dropdown - https://phabricator.wikimedia.org/T223102 (10Aklapper) a:03Aklapper Alright, I am going to resolve this task soon as * https://phabricator.wikime... [11:39:03] 10Beta-Cluster-Infrastructure, 10MinervaNeue (Desktop): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva skin: "SkinOption tabsOnSpecials doesn't exist" - https://phabricator.wikimedia.org/T225279 (10pmiazga) p:05Triage→03Unbreak! a:03pmiazga [11:39:47] 10Beta-Cluster-Infrastructure, 10MinervaNeue (Desktop), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva skin: "SkinOption tabsOnSpecials doesn't exist... - https://phabricator.wikimedia.org/T225279 [11:42:58] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Wikidata, and 5 others: Introduce wikidata termbox SSR to kubernetes - https://phabricator.wikimedia.org/T220402 (10Tarrow) @akosiaris Thanks! Now https://gerrit.wikimedia.org/r/c/wikibase/termbox/+/515040 is merged the Healthcheck query shoul... [12:03:13] (03PS4) 10Awight: Composer and npm test as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513504 (https://phabricator.wikimedia.org/T223752) [12:03:16] Mocking multiprocessing was hairy. [12:05:03] (03CR) 10Awight: phpunit tests as command (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/513513 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [12:06:23] awight: so yeah probably we will need moaare modules [12:07:31] :) [12:07:55] This coagulation step is cool though [12:12:41] 10Beta-Cluster-Infrastructure, 10MinervaNeue (Desktop), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva skin: "SkinOption tabsOn... - https://phabricator.wikimedia.org/T225279 [12:13:28] mock_pool.return_value.__enter__.return_value\ [12:13:28] .imap_unordered.side_effect [12:13:29] bahhh [12:13:43] that is the kind of line that takes me a couple hours to figure out :-\ [12:13:44] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Wikidata, and 5 others: Introduce wikidata termbox SSR to kubernetes - https://phabricator.wikimedia.org/T220402 (10akosiaris) Indeed this was fixed. However another regression has crept up it's head Doing a `curl 'http://192.168.99.100:18788... [12:13:49] i am always confused by mock interface [12:15:13] It took me a couple of hours to write it :-) [12:15:29] (03CR) 10Hashar: [C: 03+2] "Works. Addition of tests is lovely!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/513504 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [12:16:08] (03Merged) 10jenkins-bot: Composer and npm test as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513504 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [12:16:37] (03CR) 10jenkins-bot: Composer and npm test as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513504 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [12:22:38] hashar: > move quibble.test.run_phpunit() as a new command here (class PhpUnit)? [12:22:45] I'm having doubts about this, now. [12:22:59] cos run_phpunit shouldn't be used as a command... [12:23:08] *Command [12:24:29] hmm [12:24:32] why not? [12:24:33] oh [12:24:38] the base PhpUnit one [12:24:47] well we can make it a Command, just that it will not be used [12:24:53] ? [12:26:25] let's see... [12:35:46] (03PS2) 10Hashar: zuul: drop an obsolete rule for fundraising-tools-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/499514 [12:37:18] (03CR) 10Hashar: [C: 03+2] "Zuul diff looks fine" [integration/config] - 10https://gerrit.wikimedia.org/r/499514 (owner: 10Hashar) [12:38:53] (03Merged) 10jenkins-bot: zuul: drop an obsolete rule for fundraising-tools-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/499514 (owner: 10Hashar) [12:48:18] (03PS3) 10Awight: phpunit tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513513 (https://phabricator.wikimedia.org/T223752) [12:57:16] (03Abandoned) 10Hashar: debian: remove override_dh_auto_test we dont use it [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/508710 (owner: 10Hashar) [12:57:18] (03Abandoned) 10Hashar: debian: remove openstack-pkg-tools [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/508711 (owner: 10Hashar) [12:57:20] (03Abandoned) 10Hashar: debian: add back test dependencies [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/508712 (owner: 10Hashar) [12:57:22] (03Abandoned) 10Hashar: debian: depend on git [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/508709 (owner: 10Hashar) [12:57:24] (03Abandoned) 10Hashar: debian: have testr use the virtualenv [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/508713 (owner: 10Hashar) [12:57:26] (03Abandoned) 10Hashar: Increase tests timeout [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/509404 (owner: 10Hashar) [13:18:32] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:28:31] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10serviceops, and 5 others: Introduce kask session storage service to kubernetes - https://phabricator.wikimedia.org/T220401 (10akosiaris) `sessionstore.discovery.wmnet` is now around and should be the canonical DNS used to address the service. [13:30:37] !log cherry pick https://gerrit.wikimedia.org/r/c/operations/puppet/+/515058 [13:30:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:47:32] oh [13:47:38] I found a new magic command in git-review :-D [13:47:47] to compare two patchsets [13:47:50] git-review --compare 513513,2-3 [13:47:51] :D [13:49:03] O_O [13:50:22] apparently it fetches each patchset, rebase them [13:50:24] and then compare [13:52:51] oooooh [13:54:55] which does not really help when one of the patchset got rebase on top of other stuff ... [13:54:57] but still [13:54:59] feature! [13:55:36] awight: https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/513513/3/quibble/commands.py is sooo cleaner :] [13:57:10] (03PS3) 10Awight: Core npm composer test as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513515 (https://phabricator.wikimedia.org/T223752) [13:58:09] yes! [13:58:17] That last one nearly killed me ^... [13:58:39] Really shouldn't have, but I'm not very good at https://docs.python.org/3/library/unittest.mock.html#id5 [13:58:45] "where to patch()" [13:59:41] time ZUUL_PROJECT=mediawiki/skins/Vector quibble --git-cache=/home/hashar/projects --skip-zuul --skip-deps --run=phpunit --db=sqlite [13:59:42] 7 seconds [13:59:54] (ok that skips all the git operations as well as composer/npm install) [14:00:01] and only run Vector skin hehe [14:00:42] awight: yeah mock is both awesome AND terrible :-\ [14:00:51] similar to the other patch you did earlier [14:00:56] with return_value ... side_effect etc [14:01:03] <3 that is the truth [14:02:27] there is something I would love is to have some kind of prepare step in quibble [14:02:57] so that one can run it first to clone/fetch the git repo + composer install (if not using venodr.git) / npm install [14:03:01] the result would be the source tree [14:03:10] and then we could dispatch patch to each of the test commands [14:03:51] so something like (start) -> (git clone/fetch) -> [ composer local, composer install, npm install ] -> snapshot the result [14:04:05] then resume and for each run command: install.php > test command [14:04:39] (03CR) 10Hashar: [C: 03+2] "Clean and nice. And mediawiki/core tests still run on my machine !" [integration/quibble] - 10https://gerrit.wikimedia.org/r/513513 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [14:05:19] (03Merged) 10jenkins-bot: phpunit tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513513 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [14:05:49] (03CR) 10jenkins-bot: phpunit tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513513 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [14:06:03] hashar: That would suit me, too--I've been soul-searching about the fact that we have incomplete information about what tests to run, until after cloning. [14:06:11] A prepare step would solve that. [14:06:35] I like the sound of snapshotting... [14:07:46] (03PS3) 10Awight: browser tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513518 (https://phabricator.wikimedia.org/T223752) [14:08:43] (03PS10) 10Awight: Separate planning and execution phases [integration/quibble] - 10https://gerrit.wikimedia.org/r/511749 (https://phabricator.wikimedia.org/T223752) [14:11:14] (03PS4) 10Awight: browser tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513518 (https://phabricator.wikimedia.org/T223752) [14:11:16] (03PS11) 10Awight: Separate planning and execution phases [integration/quibble] - 10https://gerrit.wikimedia.org/r/511749 (https://phabricator.wikimedia.org/T223752) [14:11:18] (03PS2) 10Awight: Rename native composer command [integration/quibble] - 10https://gerrit.wikimedia.org/r/515009 [14:12:00] (03CR) 10jerkins-bot: [V: 04-1] browser tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513518 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [14:12:02] (03CR) 10jerkins-bot: [V: 04-1] Separate planning and execution phases [integration/quibble] - 10https://gerrit.wikimedia.org/r/511749 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [14:12:04] (03CR) 10jerkins-bot: [V: 04-1] Rename native composer command [integration/quibble] - 10https://gerrit.wikimedia.org/r/515009 (owner: 10Awight) [14:12:37] bah ;-\ [14:16:47] just some test refactoring to do [14:29:23] 10Beta-Cluster-Infrastructure, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10MinervaNeue (Desktop), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva... - https://phabricator.wikimedia.org/T225279 [14:49:36] hashar: I found something else that reduces the phpunit runtime by 20% (According to the patches). Use APC cache for everything: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/515086 [14:49:49] it adds 10MB to memory but it's already 800MB [14:50:02] Using DB cache causes it to go really slow [14:51:20] (03PS5) 10Awight: browser tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513518 (https://phabricator.wikimedia.org/T223752) [14:51:22] (03PS12) 10Awight: Separate planning and execution phases [integration/quibble] - 10https://gerrit.wikimedia.org/r/511749 (https://phabricator.wikimedia.org/T223752) [14:51:24] (03PS3) 10Awight: Rename native composer command [integration/quibble] - 10https://gerrit.wikimedia.org/r/515009 [14:51:26] (03PS1) 10Awight: Move parallel_run to util.py [integration/quibble] - 10https://gerrit.wikimedia.org/r/515090 [14:53:42] (03CR) 10jerkins-bot: [V: 04-1] browser tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513518 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [14:53:48] oof [14:53:52] (03CR) 10jerkins-bot: [V: 04-1] Separate planning and execution phases [integration/quibble] - 10https://gerrit.wikimedia.org/r/511749 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [14:53:56] (03CR) 10jerkins-bot: [V: 04-1] Rename native composer command [integration/quibble] - 10https://gerrit.wikimedia.org/r/515009 (owner: 10Awight) [14:53:58] (03CR) 10jerkins-bot: [V: 04-1] Move parallel_run to util.py [integration/quibble] - 10https://gerrit.wikimedia.org/r/515090 (owner: 10Awight) [14:55:50] (03PS6) 10Awight: browser tests as command [integration/quibble] - 10https://gerrit.wikimedia.org/r/513518 (https://phabricator.wikimedia.org/T223752) [14:55:52] (03PS13) 10Awight: Separate planning and execution phases [integration/quibble] - 10https://gerrit.wikimedia.org/r/511749 (https://phabricator.wikimedia.org/T223752) [14:55:54] (03PS2) 10Awight: Move parallel_run to util.py [integration/quibble] - 10https://gerrit.wikimedia.org/r/515090 [14:55:56] (03PS4) 10Awight: Rename native composer command [integration/quibble] - 10https://gerrit.wikimedia.org/r/515009 [14:56:34] 10Release-Engineering-Team, 10Scap, 10serviceops, 10PHP 7.2 support, 10User-jijiki: Enhance MediaWiki deployments for support of php7.x - https://phabricator.wikimedia.org/T224857 (10Joe) A small comment about what has been done and what needs to be done: - We upped opcache to 1 GB. By my evaluations, th... [15:09:26] Amir1: yeah cache apc would do [15:09:38] Amir1: but the default in mediawiki/core should really still be CACHE_ANYTHING [15:10:14] Amir1: I have no idea what type of caches ends up being used when running the tests on CI :-\ But surely something can be tweaked via includes/DevelopmentSettings.php [15:12:56] awight: I will do some more review tonight I guess and probably over the week-end [15:16:59] I am vanishing for now [15:33:44] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10Paladox) [15:41:46] (03CR) 10Jforrester: "Thanks for deploying, hashar!" [integration/config] - 10https://gerrit.wikimedia.org/r/514191 (owner: 10Jforrester) [15:44:20] paladox: did I miss something, has HTTP auth been re-enabled? [15:44:45] legoktm http auth is still enabled, just you carn't use a random password rather you have to use your ldap pass. [15:44:54] ohhhh [15:45:09] well then, [15:45:33] paladox: so if I pass the libraryupgrader ldap password to Gerrit, it'll just work as if it were the randomly generated one? [15:45:33] also i think http auth may be able to be re evaluated as my email changes were merged upstream :P [15:45:42] yup [15:46:18] fantastic (to both) [15:47:14] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Wikidata, and 5 others: Introduce wikidata termbox SSR to kubernetes - https://phabricator.wikimedia.org/T220402 (10Tarrow) >>! In T220402#5242902, @akosiaris wrote: > Indeed this was fixed. However another regression has crept up it's head T... [16:00:39] legoktm: Woah, LibraryUpdater! Yay. [16:01:03] * James_F gets all the e-mails. [16:01:24] James_F: yes :) paladox (above) explained that I could just use the ldap password [16:03:23] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10thcipriani) This is due to gerrit using `cn` as the UI login (internally in gerrit this is the `gerrit` schema), while using `uid` as the ssh/api login (internally in ge... [16:03:40] Yeah, but it didn't work for Mukunda for pushing new tags? [16:03:42] * James_F shrugs. [16:03:55] James_F his problem is due to https://phabricator.wikimedia.org/T225308 [16:04:08] Oh, fun. [16:04:47] http auth worked for me last night too [16:06:43] Amir1: nice spot on the APC patch! [16:06:59] 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Browser-Tests, 10User-zeljkofilipin: Consider moving browser based tests (Selenium and QUnit) to a non-voting pipeline - https://phabricator.wikimedia.org/T225248 (10Legoktm) I thought I had written this down in a task somewhere, but I ca... [16:07:06] kostajh: I'm so excited about it. About to make a production ready patch [16:07:18] it makes phpunit 20% faster \o/ [16:08:27] !! Yeah looks great [16:11:07] Amir1: is this using OPcache or APC? [16:11:15] APC [16:11:28] Anything is better than database as cache :D [16:13:56] (03PS4) 10Jforrester: Stop running PHP55 tests anywhere. [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) [16:16:00] (03CR) 10Jforrester: "Last MW 1.27 release is out (and they're being force-merged anyway). Let's do this." [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) (owner: 10Jforrester) [16:33:36] 10Phabricator, 10CommRel-Design, 10CommRel-Internals: Create Phabricator form for CommRel-Design and Comms requests and add a link to it in the "Star" dropdown - https://phabricator.wikimedia.org/T223102 (10hdothiduc) Thank you so much, Andre! I think what Erica means is that when you put an "x" in between... [16:42:19] James_F: want to +2 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/515115 ? [16:45:12] (03CR) 10Legoktm: [C: 04-1] Stop running PHP55 tests anywhere. (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) (owner: 10Jforrester) [16:45:22] legoktm: Done. [16:46:44] (03CR) 10Jforrester: Stop running PHP55 tests anywhere. (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) (owner: 10Jforrester) [16:51:42] 10Phabricator, 10CommRel-Design, 10CommRel-Internals: Create Phabricator form for CommRel-Design and Comms requests and add a link to it in the "Star" dropdown - https://phabricator.wikimedia.org/T223102 (10Aklapper) 05Open→03Resolved Cheers & Meouw! 🐱 [16:53:37] (03CR) 10Legoktm: [C: 04-1] Stop running PHP55 tests anywhere. (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) (owner: 10Jforrester) [16:57:14] (03CR) 10Jforrester: Stop running PHP55 tests anywhere. (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) (owner: 10Jforrester) [17:01:21] 10Beta-Cluster-Infrastructure, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10MinervaNeue (Desktop), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [betalabs] Special:Preferences OutOfBoundsException for any Special pages after switching to Minerva... - https://phabricator.wikimedia.org/T225279 [17:03:55] (03CR) 10Jforrester: Stop running PHP55 tests anywhere. (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) (owner: 10Jforrester) [17:04:34] (03PS5) 10Jforrester: Stop running PHP55 tests anywhere. [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) [17:06:51] (03CR) 10jerkins-bot: [V: 04-1] Stop running PHP55 tests anywhere. [integration/config] - 10https://gerrit.wikimedia.org/r/514031 (https://phabricator.wikimedia.org/T224907) (owner: 10Jforrester) [17:07:01] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release, 10Patch-For-Review: Prune /vendor for REL1_33 - https://phabricator.wikimedia.org/T220667 (10Jdforrester-WMF) a:03Reedy [17:07:28] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33.0-rc.0 - https://phabricator.wikimedia.org/T220654 (10Jdforrester-WMF) a:03Reedy [17:27:27] James_F: just to make sure, automated processes like LU should be running "npm ci" instead of "npm it" now? [17:30:06] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Jdforrester-WMF) [17:30:09] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Prune /vendor for REL1_33 - https://phabricator.wikimedia.org/T220667 (10Jdforrester-WMF) 05Open→03Resolved [17:30:22] legoktm: `npm ci` will be much faster, yes. [17:30:39] legoktm: There are a few repos not running node10 yet, but all the MW/ext/skin stuff is. [17:32:06] got it [17:34:18] 10Continuous-Integration-Infrastructure, 10Front-end-Standards-Group, 10MediaWiki-extensions-General, 10Core Platform Team Backlog (Designing), 10Services (designing): Decide whether we want the package-lock.json to commit or ignore - https://phabricator.wikimedia.org/T179229 (10Legoktm) [17:34:41] James_F: if you want to give https://gerrit.wikimedia.org/r/515126 a sanity check when you have time [17:41:17] legoktm: Can you not `('(/)?package-lock.json\n', '')` or something? It's a bit of a mess to do it twice… [17:41:56] I suck at regexes >.< [17:42:04] I did a codesearch to verify those were the only two patterns :p [17:42:15] I suck at Python. Is a regex possible there? ;-) [17:42:22] yes [17:42:39] Anyway, yeah, let's go for it. [17:43:27] >>> t='/package-lock.json\nfoo\n' [17:43:27] >>> re.sub(r'/?package\-lock\.json\n', '', t) [17:43:27] 'foo\n' [17:43:41] Cool. [17:46:11] 10Continuous-Integration-Infrastructure, 10Front-end-Standards-Group, 10MediaWiki-extensions-General, 10Core Platform Team Backlog (Designing), 10Services (designing): Decide whether we want the package-lock.json to commit or ignore - https://phabricator.wikimedia.org/T179229 (10Jdforrester-WMF) >>! In T... [17:48:19] legoktm: Is bumping mwcs in CentralNotice on your list? It's one of a bunch of repos that complain about wgContLang because they (?) got mwcs bumped somehow without being fixed. [17:49:00] I'm going to do the npm-audit-fix run first then I can do MWCS and then phan I think [17:51:51] Cool. [17:51:57] In that case, I won't do it manually. :-) [17:52:59] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/515131 [17:53:00] there we go [17:57:49] Nice. [17:57:59] One down, 700 to go. [17:58:59] I guess you're going to push them through slowly, to avoid melting CI? [18:01:08] 700 what, dare I ask? [18:01:35] apergos: Repos with (minor) npm security vulnerabilities to fix. [18:01:51] b o oooooooo [18:02:29] Specifically, almost everyone uses `grunt` at version 1.0.3 (last version before libraryUpgrader broke); 1.0.4 with a security fix came out more recently, and I've only manually upgraded a few dozen repos. [18:02:37] Also other things to fix. [18:03:14] another CI pain point to go into the doc [18:04:06] (03PS8) 10Thcipriani: maintenance: Cleanup old Docker images at a lower threshold [integration/config] - 10https://gerrit.wikimedia.org/r/490505 (https://phabricator.wikimedia.org/T177867) (owner: 10Dduvall) [18:06:16] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10mmodell) @thcipriani: the fix is turning on http passwords. [18:09:17] James_F: just running canary repos right now [18:09:27] James_F: is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/+/515132 save? specifically stylelint [18:10:09] LU does check that the tests pass before it uploads patches [18:13:55] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Reedy) [18:13:57] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10mmodell) Rather, if we set **auth.gitBasicAuthPolicy** = "**HTTP_LDAP**" then I could work around the problem by setting an http password like I did before that option g... [18:15:12] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10mmodell) a:05mmodell→03None I'm blocked by {T225308}. Literally anyone else but me could do it but my ldap account is a speci... [18:15:39] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10mmodell) [18:15:55] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10mmodell) [18:22:26] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Reedy) The script is definitely flaky... ` $ python ./branch.py REL1_33 --core --bundle "*" --branchpoint b1b89784f6df33d02d91401... [18:26:06] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10thcipriani) >>! In T225308#5243509, @mmodell wrote: > @thcipriani: the fix is turning on http passwords. Will be doing that once a few security patches applied (that i... [18:27:17] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Legoktm) For the first error, it has to checkout mediawiki/skins before it can checkout mediawiki/skins/Timeless etc. [18:39:42] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Reedy) a:03Reedy Doing this the old fashioned way Using the REL1_33 branch in mediawiki/extensions, use those refs to create a... [18:41:53] legoktm: Looking. [18:42:50] legoktm: I *think* if you're bumping stylelint-config-wikimedia to 0.6.0 you should bump grunt-stylelint to 0.11.0 too. [18:43:06] (Sorry, I mixed an npm audit bump and a dependency bump together.) [18:43:56] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33 - https://phabricator.wikimedia.org/T220652 (10Jdforrester-WMF) [18:44:01] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Jdforrester-WMF) 05Stalled→03Open [18:44:40] James_F: hmm, will it break otherwise? supposedly the tests are passing right now, and I don't yet have a good way to combine bumps plus audit checks [18:44:54] legoktm: It will warn but I think not break. [18:45:05] So doing them as different patches should be OK. [18:46:20] James_F: got it. and then how comfortable are you with having this auto +2? [18:46:49] Totally. Go for it. [18:47:24] So much backlog to work through. grunt 1.0.3 -> 1.0.4; stylelint; eslint (not auto-able); jsonlint removal (ditto); mwcs stuff; etc. [18:47:43] You shouldn't feel like you have to do it all, of course. :-) Certainly, not all at once. [18:51:19] (03CR) 10Umherirrender: [C: 03+1] "When the same php extensions are installed on php72 than there seems no reason why phan should not pass as before" [integration/config] - 10https://gerrit.wikimedia.org/r/513914 (https://phabricator.wikimedia.org/T223847) (owner: 10Legoktm) [19:04:54] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33 - https://phabricator.wikimedia.org/T220652 (10Reedy) [19:04:57] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Reedy) 05Open→03Resolved Skins and extensions done FWIW, netrc with my gerrit password WFM here too (like it does for the int... [19:05:57] Reedy yay! [19:06:10] Sometimes the simplest way is the best way [19:06:56] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10Reedy) [19:06:59] 10Gerrit, 10Release-Engineering-Team, 10VPS-project-libraryupgrader: Re-enable use of Gerrit HTTP token to push patchsets - https://phabricator.wikimedia.org/T218750 (10Reedy) [19:07:02] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Reedy) [19:07:16] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33 - https://phabricator.wikimedia.org/T220652 (10Reedy) [19:07:19] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.33-release: Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10Reedy) [19:07:39] Reedy: nice :D [19:08:31] I guess I should write/steal a release announcement for rc.0 [19:08:43] Reedy: Totes. [19:08:58] Gah, Travis, why must I hate thee so? [19:10:03] I should probably eat too [19:14:30] I'm eating, why aren't you? [19:16:21] I've not made food.. [19:18:31] 10Release-Engineering-Team: Remove 1.32-rc.1 folder from releases.wikimedia.org/mediawiki/ - https://phabricator.wikimedia.org/T225324 (10Reedy) [19:19:56] legoktm: Are you going to set root: true in .eslintrc.json files? Should we have a task for mega-CI-runs for LU? :-) [19:20:19] James_F: I already ran that script a month or two ago? [19:20:28] Oh, but not for Babel? [19:20:45] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10MobileFrontend, 10Readers-Web-Backlog, 10JavaScript: Update MobileFrontend-npm-run-lint-modules-docker to run node10 - https://phabricator.wikimedia.org/T224997 (10phuedx) [19:20:51] https://gerrit.wikimedia.org/r/q/topic:root_true [19:20:57] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10MobileFrontend, 10JavaScript, 10Readers-Web-Backlog (Tracking): Update MobileFrontend-npm-run-lint-modules-docker to run node10 - https://phabricator.wikimedia.org/T224997 (10phuedx) [19:21:08] https://git.legoktm.com/legoktm/bin/src/master/eslintrc_root.py#L13 [19:21:19] my script only looked at .json [19:21:26] I guess I could look at both? [19:21:30] Oh, right. [19:21:33] I'll write the task. [19:26:05] 10Release-Engineering-Team: Remove 1.32-rc.1 folder from releases.wikimedia.org/mediawiki/ - https://phabricator.wikimedia.org/T225324 (10Legoktm) IIRC it was just a temporary staging area, it wasn't intended to be permanent/public. [19:26:17] James_F: looks like he's just doing it now [19:26:51] 10Continuous-Integration-Config: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) [19:27:46] legoktm: Well, I've written the task now. ;-) [19:28:14] 10Continuous-Integration-Config: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) @Umherirrender, anything else you can think of? [19:28:32] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) [19:30:12] (03CR) 10Thcipriani: [C: 03+2] "deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/490505 (https://phabricator.wikimedia.org/T177867) (owner: 10Dduvall) [19:30:28] maybe this'll just motivate me even further to make this self-serve [19:30:44] 10Gerrit: Users with a different name in the cn field compared to uid field cannot use http auth - https://phabricator.wikimedia.org/T225308 (10bd808) cn !== uid for most of our Developer accounts as far as I know. We encourage cn to be a person's full name (or at least given name + family name) and uid's have o... [19:31:52] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10Wikidata, and 5 others: Introduce wikidata termbox SSR to kubernetes - https://phabricator.wikimedia.org/T220402 (10akosiaris) >>! In T220402#5243209, @Tarrow wrote: > This should now be fixed. Sadly this was due to a mismatch between the code... [19:33:16] thcipriani: Hmm. We have a few images where we don't use the latest image for all jobs (e.g. we're using a mix of releng/quibble-stretch-php70:0.0.31-4 and -5). I guess we should migrate them all to -5? [19:33:20] (03Merged) 10jenkins-bot: maintenance: Cleanup old Docker images at a lower threshold [integration/config] - 10https://gerrit.wikimedia.org/r/490505 (https://phabricator.wikimedia.org/T177867) (owner: 10Dduvall) [19:33:28] (Or if we want to rapidly break the world, -latest? ;-)) [19:34:34] lol [19:35:18] James_F: for cleanup? It's not too terribly urgent. That cleanup job runs on integration agents only and only if the docker disk is > 80%. Worse-case a job has to re-download an image, I think. [19:36:15] OK. [19:36:52] Don't want the agents fighting back and forth over which image it needs now, evicting different versions of the same image back and forth every few minutes. :-) [19:37:59] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Umherirrender) phan-config to 0.6.1 would be nice The last repos for T206485 I have uploaded, also the rename from .eslintrc to .eslintrc.json - for... [19:39:11] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) >>! In T225325#5243742, @Umherirrender wrote: > phan-config to 0.6.1 would be nice > > The last repos for T206485 I have uploaded, a... [19:39:29] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Legoktm) [19:39:33] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) [19:39:50] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) Oops, edit conflict. [19:41:09] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) [19:41:27] whoops [19:41:47] Aren't Phab edit conflicts fun? Silent. Confusing. Deadly. [19:49:49] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Umherirrender) When working with .eslintrc.json be careful that TwoColConflicts has comments in it and it seems that this is support by eslint Other... [19:56:54] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Umherirrender) * `package.json` should have a private property * eslintIgnore in package.json (T179195 / T204176) [19:58:31] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) Excellent points. (But let's not touch the eslintignore one for now as it's not settled?) [20:00:49] hi releng! [20:01:15] Last night I blithely OKayed an update of the DonationInterface tests to node 10 [20:01:26] might have been hasty [20:01:55] That repos tests are failing in node build.js [20:02:07] with: 16:44:14 gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable. [20:03:01] Should we set that env variable, then? Or is there some other trick to making it work? [20:03:29] https://integration.wikimedia.org/ci/job/quibble-donationinterface-REL1_31-php70-docker/190/console [20:04:18] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33 - https://phabricator.wikimedia.org/T220652 (10Reedy) [20:04:21] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33.0-rc.0 - https://phabricator.wikimedia.org/T220654 (10Reedy) 05Open→03Resolved Done and git tags pushed [20:05:18] ejegg: That sounds dejavu... [20:05:43] oh? [20:05:55] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) [20:06:02] * ejegg crosses fingers, hopes Reedy's deja vu extends to the solution [20:06:14] legoktm: James_F ^ Didn't we have that breakage with another package? [20:06:34] it comes up twice in that log [20:06:52] looks like rebuilding node-gyp? [20:07:08] the new images don't have python2 in them [20:07:17] * James_F looks. [20:07:22] it causes problems for some repos, others just log [20:07:28] we probably just need to add python2 back in [20:07:32] Oh, right, no. [20:07:44] This is the node6/node10 incompatibility in fibers. [20:07:54] I think. [20:08:30] fibers is definitely mentioned in that log right above the errors! [20:08:35] Yup. [20:08:42] I'll write a patch right now. [20:09:41] Quick fix is to drop stuff FR doesn't use. [20:10:43] James_F: the devDependencies only list grunt-* and stylelint [20:11:09] let's see, and test: is just grunt test [20:11:15] so what's in the gruntfile? [20:11:52] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33 - https://phabricator.wikimedia.org/T220652 (10Reedy) I note #mw-1.33-release has a lot of tasks on it... I think we're to the point we might not want to be bundling more extensions (as rc.0 is out). We should therefore bu... [20:12:01] jshint, jscs, banana, jsonlint, and stylelint [20:12:11] Woah, really? jshint?! [20:12:19] I'd forgotten just how old 1.31 is. [20:12:27] That's ultra-EOL crapware. [20:12:43] oh boy. is the replacement a duck? [20:13:02] eslint replaces jshint, jscs, and jsonlint nowadays. [20:13:23] oh nice, let me look into what that transition entails [20:13:31] And we're replacing jsduck with jsdoc, any time "now" for values of "now" that are ± a year. ;-) [20:13:55] oh right, duck is doc [20:15:34] nice, someone's written a migration tool. [20:15:46] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Umherirrender) Yes, the eslintignore part is not ready * space vs. tabs in package.json was another point I remember, but that could already be done... [20:15:47] any reason not to use https://github.com/brenolf/polyjuice ? [20:16:19] ejegg: It's probably faster to just use eslint-config-wikimedia and run `--fix`. [20:16:40] ah, nice [20:16:45] Give me a mo. [20:17:15] Wait, didn't I do this before? [20:17:57] Oh, no, I brought them in but didn't fix it up for this repo: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/142616 [20:19:24] heh, and fr-tech has hardly touched it since :P [20:19:38] Yeah, well, if it ain't broke don't fix it. [20:19:50] it's been super-useful to have even those obsolete style checks, though! [20:21:41] so we'll be adding grunt-eslint and eslint-config-wikimedia [20:21:50] and getting rid of jshint, jscs, and jsonlint [20:22:10] Yes. [20:25:55] does eslint alone check json, or do we need eslint-plugin-json ? [20:26:40] this random commit I'm using as an example seems to have left jsonlint in place for the initial eslint install: https://gerrit.wikimedia.org/r/339082 [20:26:52] but that was 2 year ago, which is several decades in node time [20:35:11] whew, there's a lot to fix, even after --fix [20:35:48] hmm, a lot of that is assuming browser globals [20:36:30] ejegg: I've got a patch half-written. [20:37:28] James_F: awesome! It's been interesting flailing around for a bit, but now I'll wait for the real thing [20:47:41] ejegg: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/515166 – standard practice is allow everything, then gradually tighten up standards. Not sure if you want to be linting the gateway forms' styles – they're pretty outside of standards. We could have a custom set of rules for each directory. [20:48:43] 10Continuous-Integration-Config, 10VPS-project-libraryupgrader: LibraryUpgrader CI normalisation tasks, June 2019 - https://phabricator.wikimedia.org/T225325 (10Jdforrester-WMF) >>! In T225325#5243813, @Umherirrender wrote: > Yes, the eslintignore part is not ready > > * space vs. tabs in package.json was ano... [20:49:00] cool, looking! There are one or two things checked in which are actually deployed on the payment processors' hosted sites, but it would make sense to update the coding styles of everything we're deploying locally! [20:49:45] Totally, we can mark files as ignored or whatever you need. The point of CI is for the team to be certain of what you want, not force you to do pointless things just to get a green checkmark. :-) [20:53:17] hmm, locally i'm getting "Error: Undefined rule linebreaks" [20:53:22] when running stylelint [20:53:49] What version of node/npm are you running locally? A compatible version of stylelint should have been pulled in by npm install. [20:53:59] it's node 10 [20:54:01] Indeed, it's specified in package-lock.json. [20:54:19] but npm is 4.x and bugs me to upgrade to 6.x [20:54:28] Ooooh, yeah, npm 4.x is not great. [20:54:37] We're now running npm 6.5.0 for CI. [20:54:41] k, lemme rectify that [20:55:45] Also you can use `npm cit` instead of `npm install; npm test` once you're on npm v6.x, which is lots faster. [20:55:54] oh, handy! [20:59:29] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10MW-1.33-release: Release MW 1.33 - https://phabricator.wikimedia.org/T220652 (10Jdforrester-WMF) >>! In T220652#5243809, @Reedy wrote: > I note #mw-1.33-release has a lot of tasks on it... > > I think we're to the point we might not want to be bundling mo... [21:00:10] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10Epic, 10MW-1.34-release: Expand the set of bundled extensions and skins in MediaWiki 1.34 - https://phabricator.wikimedia.org/T209220 (10Jdforrester-WMF) [21:00:28] 10MediaWiki-Releasing, 10MW-1.33-release: Expand the set of bundled skins - https://phabricator.wikimedia.org/T194266 (10Reedy) [21:00:53] 10MediaWiki-Releasing, 10MW-1.34-release: Expand the set of bundled skins - https://phabricator.wikimedia.org/T194266 (10Jdforrester-WMF) [21:00:58] 10MediaWiki-Releasing, 10MinervaNeue, 10MW-1.34-release, 10Readers-Web-Backlog (Tracking): Bundle Minerva Neue skin with MediaWiki - https://phabricator.wikimedia.org/T191743 (10Jdforrester-WMF) [21:01:01] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.34-release: Bundle LoginNotify extension with MediaWiki - https://phabricator.wikimedia.org/T191746 (10Jdforrester-WMF) [21:01:05] 10MediaWiki-Releasing, 10Growth-Team, 10Thanks, 10MW-1.34-release: Bundle Thanks extension with MediaWiki - https://phabricator.wikimedia.org/T191739 (10Jdforrester-WMF) [21:01:09] 10MediaWiki-Releasing, 10Growth-Team, 10Notifications, 10MW-1.34-release: Bundle Echo extension with MediaWiki - https://phabricator.wikimedia.org/T191738 (10Jdforrester-WMF) [21:02:37] James_F: you killed wikibugs [21:03:07] lol [21:04:20] sweet, on top of installing the right things, npm 6 is a ton faster [21:05:22] ok, that patch looks good! I'll do a follow-on to restore some rules and just ignore the specific files we expect to fail [21:09:37] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Quibble, 10MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), and 2 others: Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests - https://phabricator.wikimedia.org/T199116 (10awight) There are a... [21:14:25] greg-g: With just 10 edits? Tsk. [21:14:50] ejegg: Yeah, the ~5x speed improvement is nice. :-) [21:34:13] (03CR) 10Hashar: "There is a gotcha with the way I am using imap_ordering() :-\ That parallelism is dirty and should be refactored, but I would rather kee" (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/513515 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [21:44:23] (03PS1) 10Awight: Inline remaining cmd.py steps [integration/quibble] - 10https://gerrit.wikimedia.org/r/515182 [22:20:39] (03PS4) 10Awight: Run node browser tests in each repo [integration/quibble] - 10https://gerrit.wikimedia.org/r/510709 (https://phabricator.wikimedia.org/T199116) [22:21:37] (03CR) 10jerkins-bot: [V: 04-1] Run node browser tests in each repo [integration/quibble] - 10https://gerrit.wikimedia.org/r/510709 (https://phabricator.wikimedia.org/T199116) (owner: 10Awight) [22:21:54] (03CR) 10Awight: "PS4: rebased onto Command object patches." [integration/quibble] - 10https://gerrit.wikimedia.org/r/510709 (https://phabricator.wikimedia.org/T199116) (owner: 10Awight) [22:23:59] (03PS5) 10Awight: Run node browser tests in each repo [integration/quibble] - 10https://gerrit.wikimedia.org/r/510709 (https://phabricator.wikimedia.org/T199116) [22:33:26] (03CR) 10Awight: [C: 04-1] "Yikes, thank you for pointing out the short-circuit!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/513515 (https://phabricator.wikimedia.org/T223752) (owner: 10Awight) [22:53:30] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.34-release: Enhance installer to support dependencies between skins and extensions - https://phabricator.wikimedia.org/T196670 (10Reedy) [23:23:58] (03PS7) 10Dduvall: service-pipeline: Define pipeline builder jobs for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/510602 (https://phabricator.wikimedia.org/T224035) [23:26:34] (03CR) 10Dduvall: [C: 03+2] service-pipeline: Define pipeline builder jobs for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/510602 (https://phabricator.wikimedia.org/T224035) (owner: 10Dduvall) [23:28:09] !log updating jenkins jobs for https://gerrit.wikimedia.org/r/c/integration/config/+/510602 [23:28:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:28:55] (03Merged) 10jenkins-bot: service-pipeline: Define pipeline builder jobs for blubber [integration/config] - 10https://gerrit.wikimedia.org/r/510602 (https://phabricator.wikimedia.org/T224035) (owner: 10Dduvall) [23:29:35] !log deploying zuul changes for https://gerrit.wikimedia.org/r/c/integration/config/+/510602 [23:29:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:32:10] (03CR) 10Dduvall: [C: 03+2] pipeline: Include .pipeline/config.yaml [blubber] - 10https://gerrit.wikimedia.org/r/511784 (owner: 10Dduvall) [23:37:17] (03Merged) 10jenkins-bot: pipeline: Include .pipeline/config.yaml [blubber] - 10https://gerrit.wikimedia.org/r/511784 (owner: 10Dduvall) [23:38:11] marxarelli: Tsk, shoo! :-) [23:38:40] James_F: thcipriani said i could! :) [23:38:47] * marxarelli throws thcipriani under the bus [23:38:48] * James_F laughs. [23:39:36] (03CR) 10PipelineBot: "pipeline-dashboard: blubber-pipeline-publish" [blubber] - 10https://gerrit.wikimedia.org/r/511784 (owner: 10Dduvall) [23:39:38] (03CR) 10PipelineBot: "pipeline-dashboard: blubber-pipeline-publish" [blubber] - 10https://gerrit.wikimedia.org/r/511784 (owner: 10Dduvall) [23:39:40] (03CR) 10jenkins-bot: pipeline: Include .pipeline/config.yaml [blubber] - 10https://gerrit.wikimedia.org/r/511784 (owner: 10Dduvall) [23:40:27] Fancy. [23:42:09] aw yeah [23:43:38] 10Release-Engineering-Team (Kanban), 10Release Pipeline, 10Patch-For-Review: Create service-pipeline job aware of .pipeline/config.yaml - https://phabricator.wikimedia.org/T224035 (10dduvall) 05Open→03Resolved [23:56:01] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10Release Pipeline: Experiment with hosted kubernetes solutions for Beta - https://phabricator.wikimedia.org/T222820 (10dduvall) a:05dduvall→03None I was able to run Mathoid just fine on GKE using the [[ https://releases.wikimedia.org/ch... [23:56:14] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Upgrade webdriverio to version 5 - https://phabricator.wikimedia.org/T213268 (10Jdforrester-WMF) [23:56:18] 10Continuous-Integration-Config, 10Release-Engineering-Team (Backlog), 10JavaScript, 10Patch-For-Review: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects - https://phabricator.wikimedia.org/T211784 (10Jdforrester-WMF) [23:56:23] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10JavaScript, 10MW-1.34-notes (1.34.0-wmf.7; 2019-05-28): Switch quibble-based CI jobs from node6 to node10 - https://phabricator.wikimedia.org/T222406 (10Jdforrester-WMF) 05Open→03Resolved Only outstanding patch is just waiting for... [23:58:05] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10CirrusSearch, 10MediaWiki-extensions-Scribunto, and 3 others: Add a PHPUnit group to skip test on gated CI runs - https://phabricator.wikimedia.org/T225068 (10Jdforrester-WMF)