[00:39:21] 10Continuous-Integration-Config: rsync: failed to set times on "/cache/." - https://phabricator.wikimedia.org/T226065 (10Huji) [00:39:24] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban): mwext-php70-phan-seccheck-docker blocking merges - https://phabricator.wikimedia.org/T226064 (10Huji) [01:46:17] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<11.11%) [01:55:48] (03PS1) 10Jeena Huneidi: Some bug fixes [releng/local-charts] - 10https://gerrit.wikimedia.org/r/517780 [02:16:27] Apparently gitiles allows you to download gz, eg https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+archive/b7131c89e9ad0d69beb5373df794e3d63e3c5cb6.tar.gz [03:38:12] hi [03:38:13] I'm here now [03:38:33] Ironically I was hanging out with Wikipedians IRL, so I had no need to connect to IRC on my phone [03:40:43] (03PS1) 10Legoktm: Revert "parameter_functions: Stop working on php70-phan, they're gone" [integration/config] - 10https://gerrit.wikimedia.org/r/517785 (https://phabricator.wikimedia.org/T226064) [03:40:45] (03PS1) 10Legoktm: Revert "layout: Temporarily make all seccheck jobs non-voting" [integration/config] - 10https://gerrit.wikimedia.org/r/517786 [03:40:50] James_F: ^^ [03:41:05] (03CR) 10Legoktm: [C: 03+2] Revert "parameter_functions: Stop working on php70-phan, they're gone" [integration/config] - 10https://gerrit.wikimedia.org/r/517785 (https://phabricator.wikimedia.org/T226064) (owner: 10Legoktm) [03:41:09] (03CR) 10Legoktm: [C: 03+2] Revert "layout: Temporarily make all seccheck jobs non-voting" [integration/config] - 10https://gerrit.wikimedia.org/r/517786 (owner: 10Legoktm) [03:42:33] (03Merged) 10jenkins-bot: Revert "parameter_functions: Stop working on php70-phan, they're gone" [integration/config] - 10https://gerrit.wikimedia.org/r/517785 (https://phabricator.wikimedia.org/T226064) (owner: 10Legoktm) [03:42:37] (03Merged) 10jenkins-bot: Revert "layout: Temporarily make all seccheck jobs non-voting" [integration/config] - 10https://gerrit.wikimedia.org/r/517786 (owner: 10Legoktm) [03:43:28] !log deploying https://gerrit.wikimedia.org/r/517785 https://gerrit.wikimedia.org/r/517786 [03:43:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:05:37] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: mwext-php70-phan-seccheck-docker blocking merges - https://phabricator.wikimedia.org/T226064 (10Legoktm) 05Open→03Resolved a:03Legoktm It wasn't a local patch, it was just that environment variables like this are... [04:07:01] podman is a command-line compatible replacement for docker, it doesn't require root or any docker daemon to be running in the background, so it's safer off the bat [04:07:22] it very nicely integrates with selinux, and has proper auditing and whatnot [04:08:15] I watched https://www.youtube.com/watch?v=YkBk52MGV0Y ("Replacing docker with podman") two weeks ago on the train and was very impressed [04:09:12] I still haven't tested to see how docker-pkg works with podman, I assume it won't work since podman doesn't implement the docker HTTP API (because there's no running daemon!) [04:18:18] 10Phabricator, 10Mail, 10Operations, 10Patch-For-Review, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10ArielGlenn) I'll leave this ticket open until we see that the next month's report has shown up. [06:51:18] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:05:30] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing: Speed up MediaWiki PHPUnit build by running integration tests in parallel - https://phabricator.wikimedia.org/T50217 (10hashar) There are a few gotchas though. Some testsuite define tests which would not be found by globbing files. Typically the parser... [07:17:52] 10Continuous-Integration-Config, 10TechCom: On CI, stop testing MediaWiki with php7.0 - https://phabricator.wikimedia.org/T225628 (10hashar) > The discussion here amounts to dropping support retroactively in existing releases which were released with that support. Yes. I would like to drop php7.0 entirely fro... [07:20:35] 10Continuous-Integration-Infrastructure: [Discussion] Disable whitelisted-user automated testing, unless requested. - https://phabricator.wikimedia.org/T225940 (10hashar) 05Open→03Declined I am being bold here and declining based on the proposal being a not so nice user experience. That adds way more manual... [07:22:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10PHP 7.2 support: CI uses PHP7.2 packages from sury.org instead of SRE ones - https://phabricator.wikimedia.org/T226028 (10hashar) Argh that is due to me not adding a file in git bah :-\ #docker-pkg is not highlighting a build ha... [08:01:37] 10Continuous-Integration-Config, 10TechCom: On CI, stop testing MediaWiki with php7.0 - https://phabricator.wikimedia.org/T225628 (10Tgr) >>! In T225628#5267723, @hashar wrote: > php7.0 went EOL in January 2019 and we released MediaWiki 1.32 the same month claiming to support php7.0. Most probably php7.0 shou... [08:02:11] (03Abandoned) 10Hashar: Create selenium-daily-beta-AdvancedSearch Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:07:13] (03CR) 10Hashar: [C: 03+2] "It does not work though since TwoColConflict fails to require/include some js file, but that is solveable in the repository itself." [integration/config] - 10https://gerrit.wikimedia.org/r/460560 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:09:03] (03CR) 10Hashar: "> The package for chromium doesn't define all the dependencies, but Firefox does, so we get the things we need for it to work that way. It" [integration/config] - 10https://gerrit.wikimedia.org/r/517121 (owner: 10Jforrester) [08:13:45] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium - https://phabricator.wikimedia.org/T226078 (10hashar) [08:18:02] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium - https://phabricator.wikimedia.org/T226078 (10hashar) [08:25:27] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Aklapper) Would it be possible to run that script once manually within this month, to get the stats for May 2019? Otherwise we'll neve... [08:27:35] <_joe_> hashar: I'm trying to add a new repository request to https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests but I don't seem able to do it [08:28:48] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Marostegui) I just ran it, but I think it gave the delta between today and 1 month ago as most of the queries are: ` SELECT COUNT(DIS... [08:29:02] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium - https://phabricator.wikimedia.org/T226078 (10hashar) The reason is that it uses puppeteer which download chromium but obviously fail to insta... [08:29:58] _joe_: hi, then mediawiki is broken? :) [08:30:12] <_joe_> I had to manually purge that page [08:30:17] <_joe_> and ofc now we have two [08:30:43] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Marostegui) So if we want the ones from may we need to modify all the queries on that script to make them to pick the right range, not... [08:31:00] <_joe_> also, can you create it please? I'm blocked on the repo creation as I was used to do it myself [08:32:27] _joe_: what is the repo name? [08:32:50] also, Gerrit config hardcodes an access right so that ldap/ops can create repo under operations/* so at least you are not completely locked down ;] [08:33:27] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10ArielGlenn) I could probably hack the script to let one optionally specify start date and end date, is it worth it though? [08:34:46] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Aklapper) No need to change any code, the [script](https://phabricator.wikimedia.org/source/operations-puppet/browse/production/module... [08:35:45] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Aklapper) Argh. I should get my first coffee before posting I guess, because `date_format(NOW())`, indeed. Sorry. [08:36:48] <_joe_> hashar: operations/software/python-poolcounter [08:36:57] yeah I have seen it eventually :] [08:36:58] <_joe_> oh so I can? [08:37:09] well [08:37:16] <_joe_> I mean creating it [08:37:27] gerrit config has a hardcoded setting to make ldap/ops owner of any repository matching operations/* [08:37:36] but I don't know whether that grant rights to create a repo :-\ [08:37:45] <_joe_> uhm not to create it, no [08:37:54] :-( [08:38:06] and the rights are a mess [08:38:12] you ask to inherit from conftool https://gerrit.wikimedia.org/r/#/admin/projects/operations/software/conftool,access [08:38:19] which in turns inherit from https://gerrit.wikimedia.org/r/#/admin/projects/operations/debs/hhvm,access [08:38:26] which inherits from operations/puppet .. [08:39:02] <_joe_> yes ahahah [08:39:09] <_joe_> but some details were changed [08:39:12] yeah [08:39:14] it is hmm [08:39:17] a huge mess [08:39:19] <_joe_> anyways, inherit from ops/puppet [08:39:27] <_joe_> I can modify from there [08:40:39] _joe_: https://gerrit.wikimedia.org/r/#/admin/projects/operations/software/python-poolcounter,access [08:40:48] and somehow its owned by ldap/ops bah [08:41:30] <_joe_> thanks hashar [08:41:39] _joe_: we should probably inherit from operations/software instead [08:41:45] operations/puppet is a bit too specific [08:42:18] anyway you are an owner, so you should be able to grant yourself push/force push/forge committer identiy etc to populate the repo [08:42:35] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Marostegui) Regardless of the query...the email hasn't arrived yet and the script didn't show any errors. So probably some debugging i... [08:46:02] <_joe_> great, I will probably nudge you with an integrations/config patch later in the day :) [08:46:18] <_joe_> you == releng, not hashar specifically [08:46:32] !log Removed Debian package colordiff from all slaves | T225735 https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/517091/ [08:46:35] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:46:35] T225735: Cleanup CI puppet manifests - https://phabricator.wikimedia.org/T225735 [08:46:56] _joe_: for python software it is usually straight forward :] volans can assist as well [08:47:26] <_joe_> yeah I just need a +2 at some point, I know it's straightforward [08:57:07] (03CR) 10Awight: "> Job has not been deployed, I guess there is not much interest." [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:58:41] !log Removed Debian packages for python / tox etc from all slaves | T225735 https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/517092/ [08:58:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:58:44] T225735: Cleanup CI puppet manifests - https://phabricator.wikimedia.org/T225735 [08:59:07] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10RhinosF1) The email has arrived to us for may now @Marostegui [09:00:53] PROBLEM - Puppet errors on integration-slave-jessie-1002 is CRITICAL: CRITICAL: 4.44% of data above the critical threshold [3.0] [09:01:03] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Marostegui) Yeah, it got some delay: ` Wed, Jun 19, 2019 at 10:27 AM (Delivered after 1752 seconds) ` [09:05:37] (03Restored) 10Hashar: Create selenium-daily-beta-AdvancedSearch Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [09:07:20] (03CR) 10Hashar: [C: 03+2] "And here it is: https://integration.wikimedia.org/ci/job/selenium-daily-beta-AdvancedSearch/" [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [09:07:44] 10Phabricator, 10Mail, 10Operations, 10Regression: "Phabricator monthly statistics" email on wikitech-l@ missing for May 2019 - https://phabricator.wikimedia.org/T224804 (10Marostegui) 05Open→03Resolved a:03ArielGlenn Looks fixed then [09:08:00] awight: I have deployed the selenium daily job for AdvancedSearch https://integration.wikimedia.org/ci/job/selenium-daily-beta-AdvancedSearch/1/console :D [09:08:28] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10hashar) https://integration.wikimedia.org/ci/job/selenium-daily-beta-Advanc... [09:09:33] (03Merged) 10jenkins-bot: Create selenium-daily-beta-AdvancedSearch Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [09:14:44] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10hashar) [09:15:28] (03PS9) 10Hashar: Create selenium-daily-beta-TwoColConflict Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460560 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [09:15:34] (03CR) 10Hashar: [C: 03+2] Create selenium-daily-beta-TwoColConflict Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460560 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [09:17:47] (03Merged) 10jenkins-bot: Create selenium-daily-beta-TwoColConflict Jenkins job [integration/config] - 10https://gerrit.wikimedia.org/r/460560 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [09:18:19] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10hashar) [09:20:07] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10hashar) I merged all integration/config patches that were still pending. T... [09:22:15] PROBLEM - Puppet errors on integration-slave-jessie-1004 is CRITICAL: CRITICAL: 3.37% of data above the critical threshold [3.0] [09:23:54] PROBLEM - Puppet errors on integration-slave-jessie-1001 is CRITICAL: CRITICAL: 5.56% of data above the critical threshold [3.0] [09:34:03] (03CR) 10Awight: [C: 03+1] "> Restored" [integration/config] - 10https://gerrit.wikimedia.org/r/460516 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [09:48:57] 10Phabricator, 10Multimedia, 10UploadWizard: Upload wizard large photo uploads fails with unknown error $1 - https://phabricator.wikimedia.org/T226085 (10Zache) [10:28:39] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) a:03zeljkofilipin [11:09:13] (03PS1) 10Giuseppe Lavagetto: Add python-poolcounter tests runner [integration/config] - 10https://gerrit.wikimedia.org/r/517831 [12:56:55] (03CR) 10Hashar: [C: 03+2] Add python-poolcounter tests runner [integration/config] - 10https://gerrit.wikimedia.org/r/517831 (owner: 10Giuseppe Lavagetto) [12:58:40] (03Merged) 10jenkins-bot: Add python-poolcounter tests runner [integration/config] - 10https://gerrit.wikimedia.org/r/517831 (owner: 10Giuseppe Lavagetto) [13:14:04] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Cloud-VPS (Quota-requests): Request new Flavor for integration Cloud VPS project - https://phabricator.wikimedia.org/T225025 (10hashar) @andrew @aborrero can you possibly bring that up at the next quota meeting please? It is merely... [13:14:12] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Cloud-VPS (Quota-requests): Request new Flavor for integration Cloud VPS project - https://phabricator.wikimedia.org/T225025 (10hashar) p:05Triage→03Normal [13:18:31] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:25:32] 10Phabricator, 10Release-Engineering-Team (Kanban): Set up a subdomain for Phame to enable caching - https://phabricator.wikimedia.org/T226044 (10BBlack) [13:25:54] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Traffic: Set up a subdomain for Phame to enable caching - https://phabricator.wikimedia.org/T226044 (10BBlack) [13:27:57] 10Release-Engineering-Team, 10Scap, 10serviceops, 10PHP 7.2 support, 10User-jijiki: Enhance MediaWiki deployments for support of php7.x - https://phabricator.wikimedia.org/T224857 (10Joe) To summarize the situation a bit, we have 2 problems right now that need to be solved: # Deploys are not atomic # Op... [13:35:06] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium - https://phabricator.wikimedia.org/T226078 (10Krinkle) This is not new. When I wrote the Dockerfile for Fresnel 4 months ago (1b37556b56d) th... [13:35:26] (03PS1) 10Krinkle: fresnel: Restore comment about firefox-esr [integration/config] - 10https://gerrit.wikimedia.org/r/517860 (https://phabricator.wikimedia.org/T226078) [13:38:23] zeljkof: RE logstash and stuff, want to set up a meeting early next week? [13:39:10] The early train was a bit of a surprise btw, given we don't do sign offs yet (e.g. different teams say group0 is ready to go), I kind of depend on it being Tuesday/Wed/Thu unless announced beforehand. [13:43:36] Krinkle: twentyafterfour is running the train this week, let me check what's the plan [13:43:46] ah, so groups 0 and 1 yesterday https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190618T1900 [13:44:54] Krinkle: I'm on vacation Monday and Tuesday, I'm mostly free the rest of the week [13:48:39] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Traffic: Set up a subdomain for Phame to enable caching - https://phabricator.wikimedia.org/T226044 (10Krinkle) If re-using `techblog.wikimedia.org`, please take care not to break existing urls. The root path would be fine to change as it... [13:54:21] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Traffic: Set up a subdomain for Phame to enable caching - https://phabricator.wikimedia.org/T226044 (10BBlack) Implementing a blanket redirect to the legacy blog URI for `^/20(0[7-9]|1[0-8])/` should be feasible in VCL or Lua at the edge.... [14:12:39] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T220726 (10Elitre) [14:39:07] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.10 deployment blockers - https://phabricator.wikimedia.org/T220735 (10Reedy) [14:48:12] (03Abandoned) 10Awight: Remove some extra characters [integration/config] - 10https://gerrit.wikimedia.org/r/516739 (owner: 10Awight) [15:00:58] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.10 deployment blockers - https://phabricator.wikimedia.org/T220735 (10Krinkle) [15:43:34] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.10 deployment blockers - https://phabricator.wikimedia.org/T220735 (10Reedy) [17:16:55] 10Continuous-Integration-Config, 10phan: Set up real CI for mediawiki/tools/phan - https://phabricator.wikimedia.org/T226117 (10Legoktm) [17:41:19] hello. i'm trying to make sense of some jenkins failures on the REL1_33 branch in VE [17:41:34] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/517907 [17:42:33] just a moment ago, the karma tests were running normally (and eventually failing, which this patch is supposed to fix). now they fail before ever starting with "Script error." [17:48:01] MatmaRex: suggests the response from qunit/export contains invalid syntax and/or got corrupted/cut off. [17:48:29] https://integration.wikimedia.org/ci/job/release-quibble-composer-mysql-php71-docker/4/artifact/log/mw-exception.log [17:48:34] 2019-06-19 17:26:08 6551bb0f1300 wikidb: [6d16e8ea2057e37a1a68a3cc] /index.php?title=Special:JavaScriptTest/qunit/export ConfigException from line 53 of /workspace/src/includes/config/GlobalVarConfig.php: GlobalVarConfig::get: undefined option: 'EnableBlockNoticeStats' [17:48:34] #0 /workspace/src/extensions/VisualEditor/includes/VisualEditorHooks.php(918): GlobalVarConfig->get(string) [17:48:34] #1 /workspace/src/includes/Hooks.php(174): VisualEditorHooks::onResourceLoaderGetConfigVars(array, string) [17:48:53] courtesy of xdebug outputting html in your javascript [17:49:09] https://phabricator.wikimedia.org/T225354 [17:49:36] argh [17:49:39] okay [17:49:48] so now i have a circular dependency [17:50:00] because the patch for *that* task is failing because of the task i'm trying to fix here [17:50:46] OK. link to that one? [17:51:10] Krinkle: https://phabricator.wikimedia.org/T226115 [17:51:35] MatmaRex: can you rebase one of them on the other, to see they pass? [17:51:41] Then I'll merge the lower one with force [17:52:03] yeah [17:52:23] can you even do that? i know wee configured this repo so that at least i can't force-merge [17:52:25] we* [17:52:34] which is SUPER ANNOYING by the way [17:53:56] Krinkle: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/515673 is rebased [17:54:32] yeah, James and I some years ago made it so that V+2 is allowed but Submit is not because lots of people didn't know the difference and pressed Submit by accident. Because whenever the test pipeline is completed, you get a nice shiny blue "Submit" button which then merges it bypassing Zuul, and without even having run the gate pipeline. This is because our 'test' pipeline uses V+2, it should probably use V+2 instead (cc hashar). . [17:54:50] If we change it to use V+2 then it at least it wont' show a confusing "Submit" button to CR+2'er people. [17:55:04] and they would have to explicitly add V+2 to make it merge, which is then not something that happens by accident. [17:56:29] Looks like a group was created to avoid that issue by limiting that ability to VE members only [17:56:30] https://gerrit.wikimedia.org/r/#/admin/groups/20,members [17:56:33] but you're not in that group? [17:57:12] the assumption being that your team will teach other about this Gerrit issue as part of on-boarding. [17:57:38] so yeah, poke someone to fix that. I can't anymore (no longer gerrit admin) [17:58:34] but it only applies to master, so REL is yolo [17:58:36] {{done}} [17:58:47] Krinkle: thanks [18:05:39] 10Release-Engineering-Team (Kanban): Enquire about framadate timezone handling status - https://phabricator.wikimedia.org/T225146 (10Quiddity) a:03hashar (Assigning to hashar, as I think that's what the description says) [18:14:03] o/ [18:15:17] 'test' pipeline uses V+2, it should probably use V+2 instead < krinkle [18:15:30] I guess you meant making 'test' to vote V+1 ? :] [18:20:07] hashar: sorry, yes, V+1 [18:20:18] so that there is no "Submit" button enabled in Gerrit unless you add V+2 [18:20:45] the same people have those rights, its just to avoid mistakes/confusion [18:21:46] 10Release-Engineering-Team (Kanban), 10Security-Team, 10phan-taint-check-plugin: Phan-taint-check-plugin not available for PHP > 7.0 - https://phabricator.wikimedia.org/T207344 (10Daimona) As I probably wrote in the child task (which is almost a duplicate of this one), the last patch to merge before releasin... [18:25:15] 10Continuous-Integration-Config: Make test vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10hashar) [18:25:25] Krinkle: yeah that makes sense. Filled as https://phabricator.wikimedia.org/T226123 [18:25:39] and of course operations/puppet is a different beast :-\ [18:25:46] yeah [18:25:47] thx for filing [18:25:54] now I am going to reshuffle some vendor.git related jobs [18:25:57] it is a huge mess [18:25:57] ;D [18:26:37] Krinkle: oh and low priority, but Fresnel uses puppeteer which downloads chromium from upstream. Turns out it might miss some lib as a result :-\ [18:26:37] https://phabricator.wikimedia.org/T226078 [18:26:55] hashar: I replied on the task a few hours ago :) [18:27:11] * Krinkle closes door on the tardis [18:27:12] which really boils down to either define all dependencies explicitly OR make puppeteer to use the system chromium [18:27:24] ah yeah [18:27:26] sorry ;D [18:32:55] (03CR) 10Hashar: [C: 03+2] "Good enough, thank you :]" [integration/config] - 10https://gerrit.wikimedia.org/r/517860 (https://phabricator.wikimedia.org/T226078) (owner: 10Krinkle) [18:34:27] (03Merged) 10jenkins-bot: fresnel: Restore comment about firefox-esr [integration/config] - 10https://gerrit.wikimedia.org/r/517860 (https://phabricator.wikimedia.org/T226078) (owner: 10Krinkle) [18:35:24] 10Continuous-Integration-Infrastructure, 10Fresnel, 10Performance-Team, 10Patch-For-Review: releng/quibble-fresnel container requires Firefox to be installed in order to launch Chromium - https://phabricator.wikimedia.org/T226078 (10hashar) 05Open→03Resolved a:03Krinkle @Krinkle perfect thank you for... [18:35:55] Krinkle: +2 on your explanations for quibble-fresnel. And yeah for production mediawiki/services/chromium-render we ended up using the Debian package and puppeteer_skip_download=1. Well at least at the time [18:36:06] task marked as solved. Thank you! [18:36:10] yw [18:36:38] hashar: keep in mind for node-browser/quibble-php7x as well, for browser and qunit tests, chromium headless there would also break if firefox-esr is not installed. not specific to puppeteer. [18:36:53] I ran into this when making the node 10 images, I initially only had chromium installed. [18:37:08] which is then broken by default in Debian if you try to use it headless. [18:48:52] oh really? ;| [18:55:11] (03CR) 10Hashar: "Filled and explained on T226078 Timo also added a comment in the Dockerfile.template" [integration/config] - 10https://gerrit.wikimedia.org/r/517121 (owner: 10Jforrester) [18:58:36] 10Continuous-Integration-Config, 10Release-Engineering-Team (Watching / External), 10Analytics, 10Patch-For-Review: Status of analytics/limn-*-data git repositories? - https://phabricator.wikimedia.org/T221064 (10hashar) To get the Gerrit repositories archived one can fill a task for all of them against #c... [19:16:11] (03CR) 10Hashar: Docker: Add bazel image (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/493638 (owner: 10Paladox) [19:16:35] (03PS8) 10Hashar: Docker: Add bazel image [integration/config] - 10https://gerrit.wikimedia.org/r/493638 (owner: 10Paladox) [19:17:07] \o/ hashar [19:17:18] hashar though will nobody work? [19:17:22] i tried nobody and failed [19:17:35] as bazel caches things in ~/ [19:17:38] paladox: I have no clue ;D [19:17:45] sorry I have missed following up on that patch [19:17:55] but I am building the container and will check what is happening when using USER nobody [19:18:03] ok, thanks hashar! :) [19:20:18] argh [19:20:26] and they provide a single Bazel :D [19:23:23] paladox: do you rmeember why we need python? ;) [19:23:30] yup [19:23:33] bazel uses python [19:35:29] (03PS9) 10Hashar: Docker: Add bazel image [integration/config] - 10https://gerrit.wikimedia.org/r/493638 (owner: 10Paladox) [19:39:14] (03CR) 10Hashar: Docker: Add bazel image (035 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/493638 (owner: 10Paladox) [19:39:49] arhg [19:40:17] paladox: yeah so the bazel debian package does depends on python [19:40:19] so I guess it is fine [19:40:26] yup [19:40:38] also the build for me goes to /private/var/tmp/_bazel_xxx/ [19:40:59] on the mac [19:41:00] which is symnlinked in the workspace [19:42:20] hashar on linux it goes to /home/paladox/.cache/bazel/_bazel_paladox/ [19:44:06] hashar https://github.com/GerritCodeReview/gerrit-ci-scripts/blob/master/jenkins-docker/slave-bazel/Dockerfile [19:50:04] (03PS10) 10Hashar: Docker: Add bazel image [integration/config] - 10https://gerrit.wikimedia.org/r/493638 (owner: 10Paladox) [20:44:50] (03CR) 10Hashar: Gerrit: Add CI for operations/software/gerrit (includes new docker image) (038 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/493328 (owner: 10Paladox) [20:45:31] that is all for today [20:45:32] ;D [21:43:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Cloud-VPS (Quota-requests), 10cloud-services-team (Kanban): Request new Flavor for integration Cloud VPS project - https://phabricator.wikimedia.org/T225025 (10bd808) a:03Andrew Approved in our 2019-06-18 meeting. Assigning to @A... [22:12:48] 10Continuous-Integration-Config, 10Pywikibot, 10Documentation, 10Pywikibot-Documentation, 10good first bug: Pywikibot documentation build throws many warnings to console - https://phabricator.wikimedia.org/T187009 (10Dvorapa)