[00:00:18] James_F: is it possible to have stylelint not fail if there are no css/less files? see the log on https://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/PreferencesList [00:01:18] legoktm: Didn't it pass? [00:01:45] Running "stylelint:all" (stylelint) task [00:01:45] >> Linted 0 files without errors [00:01:52] at the bottom [00:02:05] which...is after its been upgraded [00:02:17] Yeah, so breakage from the new version of grunt-stylelint? [00:02:37] Looks like this is now an intentional change in stylelint itself? [00:03:04] yeah...but it would be nice if we could keep repos configured in advance, so when someone does add css/less, it has to be in a compliant manner [00:03:09] Well, maybe not intentional, but… [00:04:00] Oh, I agree, both grunt-stylelint (which we own) and grunt-eslint (which we don't) suck in different ways. [00:07:27] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10tstarling) [00:07:29] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (201908), 10Developer Productivity, 10local-charts: Update local-charts repository to use mediawiki chart from deployment-charts repo - https://phabricator.wikimedia.org/T228913 (10jeena) 05Open→03Resolved [00:07:31] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (201908), 10Developer Productivity, 10local-charts, 10Patch-For-Review: Move local-charts helm charts to a chart repository - https://phabricator.wikimedia.org/T224935 (10jeena) [00:08:27] legoktm: You could file an upstream task (at least with grunt-stylelint, i.e. with me) but I don't see a nice quick fix [00:09:24] Oh, hmm, now I think about it, there's a place I could slap in a gross hack. [00:09:27] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10brennen) [00:09:27] One second. [00:11:37] thank you :) [00:16:27] legoktm: https://github.com/wikimedia/grunt-stylelint/pull/76 [00:17:38] James_F: just to make sure, options.files is after all the globs/etc have been expanded and filtered? [00:18:55] It's after grunt-stylelint has glob/filtered (a couple of lines above) but before we've passed it to stylelint itself (a couple of lines below) which is where the error is happening. [00:19:06] (Yes.) [00:19:20] https://github.com/stylelint/stylelint/pull/3965 looks to be the upstream breakage [00:21:26] Oh, can I just pass allow-empty-input? [00:55:31] legoktm: Whenever LibUp works out that grunt-stylelint 0.11.1 exists, the bug will go away. [01:08:12] James_F: awesome. Can you submit a patch to labs/libraryupgrader/config? That replaced the on-wiki JSON page [01:08:37] Oh, sure. [01:10:14] https://gerrit.wikimedia.org/r/#/c/labs/libraryupgrader/config/+/526818 [01:19:09] Cool, ill merge it once I'm home [01:19:11] Ty :)) [01:19:23] Psh, merge from phone, it's the best way. ;-) [01:21:07] don't have access to my important accounts on here [01:21:41] Also libup is turned off rn anyways :p [01:23:36] Details, dwtails. [03:10:25] Project mwcore-phpunit-coverage-master build #84: 04STILL FAILING in 10 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/84/ [07:07:37] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:18:39] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-UrlShortener, 10User-DannyS712: UrlShortener doesn't work on beta cluster - https://phabricator.wikimedia.org/T229369 (10Legoktm) @krenair do you remember what instance this domain was supposed to point to? You had helped us debug this when we first set i... [07:42:14] PROBLEM - Free space - all mounts on deployment-mwmaint01 is CRITICAL: CRITICAL: deployment-prep.deployment-mwmaint01.diskspace.root.byte_percentfree (<11.11%) [07:52:18] RECOVERY - Free space - all mounts on deployment-mwmaint01 is OK: OK: All targets OK [09:11:45] 10Phabricator: Improve start page window title - https://phabricator.wikimedia.org/T229225 (10PerfektesChaos) I do propose a different name for the entire project rather than //Homepage//. Apparently somewhere in the local configuration something has not been specified, and the fallback is ##Homepage##. If tha... [10:29:58] 10Release-Engineering-Team (Code Health), 10Release-Engineering-Team-TODO, 10Code-Stewardship-Reviews: Code Stewardship Review: Collection Extension - https://phabricator.wikimedia.org/T224922 (10Tgr) Collection is currently only a gateway to the PediaPress print-on-demand bookshop, which I imagine is not us... [10:34:14] 10Release-Engineering-Team (Code Health), 10Code-Stewardship-Reviews, 10MediaWiki-extensions-Nuke: Nuke Extension: Code Stewardship Review - https://phabricator.wikimedia.org/T221155 (10Tgr) In theory, Nuke could easily be replaced by an OAuth-backed external tool - no risk of causing errors in production, e... [11:39:47] PROBLEM - Free space - all mounts on deployment-mediawiki-07 is CRITICAL: CRITICAL: deployment-prep.deployment-mediawiki-07.diskspace.root.byte_percentfree (<40.00%) [12:31:09] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Shizhao) [12:33:51] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Paladox) Hi, i get "HTTP/2 200 " when running "curl -s -D - -o /dev/null https://phabricator.wikimedia.org". [13:33:00] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Shizhao) >>! 在T229575#5384207中，@Paladox写道： > Hi, i get "HTTP/2 200 " when running "curl -s -D - -o /dev/null https://phabricator.wikimedia.org". Just some France IP visit phabricator. [13:33:13] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Shizhao) [13:37:25] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T220736 (10Pchelolo) [13:37:27] 10Release-Engineering-Team (Kanban), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Release, 10Train Deployments: 1.34.0-wmf.10 deployment blockers - https://phabricator.wikimedia.org/T220735 (10Pchelolo) [14:04:00] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10DBA, 10Operations: Gerrit is failing to connect to db on gerrit2001 thus preventing systemd from working - https://phabricator.wikimedia.org/T176532 (10Marostegui) I have set up the proxy for m2 in codfw. I kn... [14:20:29] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Aklapper) 05Open→03Stalled Could you share an IP range if you are comfortable with that being public? If not, could you share via a [private email](https://meta.wikimedia.org/wiki/User:AKlapper_(WMF))? [14:29:17] gerrit2001 will be able to start now (re the comment Marostegui made above!) [14:29:29] so we will have a slave which we can point phabricator at [14:49:04] (03CR) 10Thcipriani: [C: 03+2] php7x: Add php_fpm module [tools/scap] - 10https://gerrit.wikimedia.org/r/525117 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [14:49:27] paladox: neat :) [14:49:45] that'd offload a ton of traffic. [14:49:48] https://gerrit.wikimedia.org/r/#/c/operations/dns/+/527114/ <-- that's the dns change [14:49:54] thcipriani yup! [14:50:04] thcipriani https://gerrit-slave.wikimedia.org/r/ is the slave url :) [14:50:24] that'll turn white i think if gerrit starts. [14:50:36] white as in black page (allowing you to clone over it) [14:51:06] (03Merged) 10jenkins-bot: php7x: Add php_fpm module [tools/scap] - 10https://gerrit.wikimedia.org/r/525117 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [14:51:47] (03CR) 10jenkins-bot: php7x: Add php_fpm module [tools/scap] - 10https://gerrit.wikimedia.org/r/525117 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [15:03:07] <_joe_> thcipriani: do you need me to do something more for the scap patches? [15:03:14] <_joe_> I'd like to unblock the migration now [15:03:47] <_joe_> where now == next week [15:31:17] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10Mholloway) [15:37:30] _joe_: (sorry, meeting) my plan was to get them merged by the end of the week, but my week has been unexpectedly busy, so I'm a bit behind [15:38:44] first one was the largest change, second one could probably merge pretty easily -- looks like the consensus is to move the feature flag to the module and out of main -- final one...there's some prior art in what you did for the opcache [15:40:20] PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 92.86% of data above the critical threshold [140.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [15:44:27] (03CR) 10Thcipriani: [C: 03+2] php7x: restart on 'scap pull' (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/525118 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [15:44:38] (03CR) 10jerkins-bot: [V: 04-1] php7x: restart on 'scap pull' [tools/scap] - 10https://gerrit.wikimedia.org/r/525118 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [15:45:06] (03PS2) 10Thcipriani: php7x: restart on 'scap pull' [tools/scap] - 10https://gerrit.wikimedia.org/r/525118 (https://phabricator.wikimedia.org/T224857) [15:45:18] (03CR) 10Thcipriani: php7x: restart on 'scap pull' [tools/scap] - 10https://gerrit.wikimedia.org/r/525118 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [15:59:42] RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 30.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [16:51:12] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201908), 10Operations, and 2 others: Prepare Phame to support heavy traffic for a Tech Department blog - https://phabricator.wikimedia.org/T226044 (10greg) a:05greg→03mmodell >>! In T226044#5380942, @greg... [17:00:48] (03CR) 10Thcipriani: [C: 03+2] php7x: restart on 'scap pull' [tools/scap] - 10https://gerrit.wikimedia.org/r/525118 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [17:01:36] hey releng folks ... i would appreciate your input on the various options that have been proposed for https://phabricator.wikimedia.org/T213494 given comments on https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/526262 ... if you want a summary of all proposals, i could probably collate and post there. [17:02:47] (03Merged) 10jenkins-bot: php7x: restart on 'scap pull' [tools/scap] - 10https://gerrit.wikimedia.org/r/525118 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [17:03:27] (03CR) 10jenkins-bot: php7x: restart on 'scap pull' [tools/scap] - 10https://gerrit.wikimedia.org/r/525118 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [17:06:40] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Shizhao) @Aklapper sent an email to you [17:14:34] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Aklapper) 05Stalled→03Declined @Shizhao: Thank you for sharing your IP via private email! The current behavior is intentional: Due to an ongoing security incident[0], certain IP ranges continue to be restricted from... [17:16:59] phab ban pls: https://phabricator.wikimedia.org/p/Nforcer7/ [17:17:15] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Dzahn) Could we possibly improve this though by not sending a "500 Internal Server Error" but more appropriate 401 Unauthorized or 403 Forbidden? [17:20:08] greg-g: FYI - emergency disabled https://phabricator.wikimedia.org/people/manage/20945/ [17:20:24] (andre seems online but not here?) [17:21:02] will need a rollback bot to be run, don't recall who has that [17:22:16] musikanimal I think ran it last time [17:23:03] there's an official rollback script now, I think [17:23:09] https://wikitech.wikimedia.org/wiki/Phabricator#Revert_all_activity_of_a_given_user [17:24:08] I'm happy to attempt that, if no one else wiser in the ways of Phab is around [17:24:40] take a db snapshot first [17:27:23] that I do not know how to do [17:27:33] so I suppose someone else should do it [17:28:34] twentyafterfour, ^ ping [17:28:48] also https://wikitech.wikimedia.org/wiki/Database_snapshots ... we should just delete things like this, IMO [17:28:52] or move it to another namespace [17:29:13] here [17:30:10] i got mysql credentials for the "phstats" user [17:30:14] but that isn't enough [17:30:55] (to run mysqldump ) [17:31:05] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Shizhao) thx @Aklapper, and agree with @Dzahn opinion, 403 Forbidden may be more appropriate. [17:31:54] mutante: phabricator has a build in db dump script [17:32:18] there is the Obsolete: namespace just for that [17:32:18] twentyafterfour: ok, great. can you run that. i will stop trying to find the right passwords [17:32:45] or if it is to be updated, you can slap a big fat https://wikitech.wikimedia.org/wiki/Template:Archive on it [17:32:45] would be good if that was documented on the phab page [17:33:05] i was in passwords::phabricator and there are actually certs now [17:36:27] ok dump is running [17:36:38] and I'll document it [17:37:19] thanks! [17:46:09] i see it's running and the full mysqldump command it uses in the background. that also answers my question about the user [17:48:33] https://wikitech.wikimedia.org/wiki/Phabricator#Dump_the_entire_database [17:49:03] twentyafterfour: <3 [17:50:04] 10Continuous-Integration-Config, 10MediaWiki-extensions-JsonConfig, 10Reading-Infrastructure-Team-Backlog, 10Maps (Kartographer), and 2 others: Move JCMapDataContent from JsonConfig to Kartographer - https://phabricator.wikimedia.org/T163274 (10Aklapper) 05Stalled→03Open [17:51:57] 10Continuous-Integration-Config, 10MediaWiki-extensions-JsonConfig, 10Reading-Infrastructure-Team-Backlog, 10Maps (Kartographer), and 2 others: Move JCMapDataContent from JsonConfig to Kartographer - https://phabricator.wikimedia.org/T163274 (10Aklapper) 05Open→03Stalled [17:52:02] 10Gerrit, 10Gerrit-Privilege-Requests, 10Wikimedia-IEG-grant-review, 10User-MarcoAurelio: Give access to l10n-bot to wikimedia/iegreview repository - https://phabricator.wikimedia.org/T228490 (10MarcoAurelio) 05Open→03Resolved Bot is now trying to automerge its changes as expected. [17:54:25] Yippee, build fixed! [17:54:26] Project mwcore-phpunit-coverage-master build #85: 09FIXED in 2 hr 54 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/85/ [18:09:50] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Parsoid-PHP, 10Patch-For-Review: Installing composer modules for deployment - https://phabricator.wikimedia.org/T213494 (10ssastry) For everyone's benefit, here is a summary of the three proposals. All options assume Parso... [18:11:04] thcipriani, greg-g ^^ I updated the phab task with a summary of options in case it helps folks evaluate and weigh in. [18:11:20] * thcipriani looks at scrollback [18:11:43] subbu|away: k, I'll add commentary :) [18:11:48] subbu|away: i am about to add mediawiki on scandium [18:11:57] mutante, great. ty. [18:12:35] :) enjoy the rest of |away time / lunch [18:12:37] maybe the independent deployability of parsoid and mediawiki makes option 2 somewhat desirable in that sense. [18:12:41] i know :) [18:12:52] i have been "away" for the last 30 mins. [18:13:06] i expected it means you are on your way out in the door frame, heh [18:13:50] well.. by adding mediawiki i meant "add the puppet roles for a mediawiki appserver and everything they do" [18:14:06] and then see how it goes [18:14:38] ok .. alright, i'll really go eat lunch now. will look up later. [18:14:49] yep, ttyl [18:38:34] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Parsoid-PHP, 10Patch-For-Review: Installing composer modules for deployment - https://phabricator.wikimedia.org/T213494 (10mmodell) I don't have any huge objections to either option. It sounds like #2 would give you the ab... [18:47:59] (03PS1) 10Jforrester: layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 [18:48:20] (03CR) 10Jforrester: [C: 03+2] layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 (owner: 10Jforrester) [18:49:35] (03CR) 10jerkins-bot: [V: 04-1] layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 (owner: 10Jforrester) [18:49:51] (03CR) 10jerkins-bot: [V: 04-1] layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 (owner: 10Jforrester) [18:52:31] (03PS2) 10Jforrester: layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 [18:54:06] (03CR) 10jerkins-bot: [V: 04-1] layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 (owner: 10Jforrester) [18:54:55] (03PS3) 10Jforrester: layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 [18:55:24] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Parsoid-PHP, 10Patch-For-Review: Installing composer modules for deployment - https://phabricator.wikimedia.org/T213494 (10ssastry) >>! In T213494#5385443, @mmodell wrote: > I don't have any huge objections to either optio... [18:55:58] 10Phabricator (Upstream), 10Upstream: "Unhandled Exception: Testing for capability "interact" on an object ("PhabricatorRepositoryCommit") which does not support that capability." trying to remove a comment - https://phabricator.wikimedia.org/T228847 (10epriestley) I believe this upstream in (03CR) 10Jforrester: [C: 03+2] layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 (owner: 10Jforrester) [18:59:49] 10Phabricator (Upstream), 10Regression, 10Upstream: "Merge Duplicates"/"Edit Parent Tasks"/"Edit Subtasks" dialogs: Clicking on a task title closes the dialog instead of selecting the task - https://phabricator.wikimedia.org/T228224 (10epriestley) I think I can reproduce this //sometimes//. I filed this ups... [19:00:11] (03Merged) 10jenkins-bot: layout: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [integration/config] - 10https://gerrit.wikimedia.org/r/527184 (owner: 10Jforrester) [19:00:49] !log Zuul: [BlueSpiceExtendedSearch] Disable HHVM tests, this doesn't work there [19:00:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:04:37] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Parsoid-PHP, 10Patch-For-Review: Installing composer modules for deployment - https://phabricator.wikimedia.org/T213494 (10thcipriani) Option 2 seems preferable to me as well at this point. It seems like there is a compell... [19:07:09] 10Phabricator (Upstream), 10Regression, 10Upstream: "Merge Duplicates"/"Edit Parent Tasks"/"Edit Subtasks" dialogs: Clicking on a task title closes the dialog instead of selecting the task - https://phabricator.wikimedia.org/T228224 (10epriestley) This should be resolved by (03PS1) 10Jforrester: layout: [BlueSpiceExtendedSearch] Add VisualEditor as a dependency [integration/config] - 10https://gerrit.wikimedia.org/r/527193 [19:12:11] (03CR) 10jerkins-bot: [V: 04-1] layout: [BlueSpiceExtendedSearch] Add VisualEditor as a dependency [integration/config] - 10https://gerrit.wikimedia.org/r/527193 (owner: 10Jforrester) [19:12:34] brennen: https://phabricator.wikimedia.org/T229605 worries me. Might be a train blocker. [19:14:47] 10Phabricator (Upstream), 10Upstream: Wikimedia Phabricator's "Developer Log In" should set the focus on username - https://phabricator.wikimedia.org/T201231 (10epriestley) This was changed upstream in so we automatically focus the first "Username" field on the login pag... [19:15:16] andre__: thanks for heads up [19:15:38] (03PS2) 10Jforrester: layout: [BlueSpiceExtendedSearch] Add VisualEditor as a dependency [integration/config] - 10https://gerrit.wikimedia.org/r/527193 [19:16:17] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Aklapper) Feel free to file a new task about that. :) [19:16:17] thcipriani: assuming above is the case, roll back to group0? [19:16:49] brennen: yeah, probably until we get it sorted out what's happening. [19:17:06] is it only on commons? [19:17:36] (I don't know how "popular" that issue is, cannot judge that... so was really just a heads-up :-/ ) [19:17:43] (03CR) 10Jforrester: [C: 03+2] layout: [BlueSpiceExtendedSearch] Add VisualEditor as a dependency [integration/config] - 10https://gerrit.wikimedia.org/r/527193 (owner: 10Jforrester) [19:18:04] andre__: definitely happening at a low level, but it seems like a bad issue in the cases where it does happen [19:19:19] (03Merged) 10jenkins-bot: layout: [BlueSpiceExtendedSearch] Add VisualEditor as a dependency [integration/config] - 10https://gerrit.wikimedia.org/r/527193 (owner: 10Jforrester) [19:19:31] hrm, seems to happen on wikisource as well? [19:19:34] brennen: yeah, let's rollback group2 and group1 and set this as unbreak now and hope it's a simple problem. [19:20:00] thcipriani: k, doing that. [19:20:16] I'll fiddle with tasks [19:21:09] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10thcipriani) [19:24:30] 10Diffusion, 10Phabricator (Upstream), 10Upstream: Turn off 'blame' by default on Diffusion - https://phabricator.wikimedia.org/T198838 (10epriestley) Blame loads asynchronously, so my expectation is that it does not slow the loading of the contents of the page. Locally, I can't reproduce this behavior: whe... [19:39:12] 10Continuous-Integration-Config, 10MediaWiki-extensions-CentralAuth: CentralAuth tests are broken - https://phabricator.wikimedia.org/T229613 (10Urbanecm) [19:39:33] 10Continuous-Integration-Config, 10MediaWiki-extensions-CentralAuth: CentralAuth tests are broken - https://phabricator.wikimedia.org/T229613 (10Urbanecm) p:05Triage→03High Breaks all work on extension => at least high, if not UBN. [19:40:09] 10Release-Engineering-Team (Deployment services), 10Release, 10Train Deployments: 1.34.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T220743 (10greg) 05Open→03Declined No train this week, Wikimania. [19:40:12] 10Continuous-Integration-Config, 10MediaWiki-extensions-CentralAuth, 10ci-test-error: CentralAuth tests are broken - https://phabricator.wikimedia.org/T229613 (10Jdforrester-WMF) [19:40:28] 10Continuous-Integration-Config, 10MediaWiki-extensions-CentralAuth, 10ci-test-error: CentralAuth tests are broken - https://phabricator.wikimedia.org/T229613 (10Jdforrester-WMF) This is just the phan breakage for dozens of repos, right? [19:40:43] 10Release-Engineering-Team (Deployment services), 10Release, 10Train Deployments: 1.34.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T220742 (10greg) a:03brennen [19:40:55] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T220742 (10greg) [19:42:37] 10Continuous-Integration-Config, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-production-error (Shared Build Failure), 10ci-test-error: CentralAuth tests are broken - https://phabricator.wikimedia.org/T229613 (10Urbanecm) >>! In T229613#5385647, @Jdforrester-WMF wrote: > This is just the phan breakage f... [19:43:03] 10Phabricator (Upstream), 10Upstream: In Phabricator's global search, tasks in a project's milestone are not found when searching in the parent project - https://phabricator.wikimedia.org/T190342 (10epriestley) I think this is largely similar to T224082: the Elastic engine does not resolve the "Tags" query con... [19:43:40] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Parsoid-PHP, 10Patch-For-Review: Installing composer modules for deployment - https://phabricator.wikimedia.org/T213494 (10cscott) I think there's some longer-term planning considerations here: 1) deploying parsoid separa... [19:44:19] 10Continuous-Integration-Config, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-production-error (Shared Build Failure), 10ci-test-error: CentralAuth tests are broken - https://phabricator.wikimedia.org/T229613 (10Jdforrester-WMF) CentralAuth isn't in the gate so this isn't a shared build failure. [19:46:12] 10Phabricator (Upstream), 10Upstream: In Phabricator's global search, tasks in a project's milestone are not found when searching in the parent project - https://phabricator.wikimedia.org/T190342 (10mmodell) Is there a way to keep elasticsearch enabled for the global search results but use ferrit for all the o... [19:48:35] 10Phabricator (Upstream), 10Upstream: In Phabricator's global search, tasks in a project's milestone are not found when searching in the parent project - https://phabricator.wikimedia.org/T190342 (10epriestley) That's already how things are working right now -- this task ("Tags" working differently in Maniphes... [19:50:07] train rolled back and status mail sent. [19:50:24] (he said, redundantly with a good many log messages.) [19:50:35] andre__: can you add lines=10 to the traces in https://phabricator.wikimedia.org/T229605#5385550 ? [19:51:14] Krinkle: Ah, didn't know that. Where exactly? I only use three backticks [19:51:18] 10Phabricator (Upstream), 10Upstream: In Phabricator's global search, tasks in a project's milestone are not found when searching in the parent project - https://phabricator.wikimedia.org/T190342 (10epriestley) (To throw another one on the pile, T168061 is also closely related, I think. I'll add some details t... [19:52:20] andre__: right after the backticks "```lines=10\n" [19:52:35] andre__: yep, it's like lang=, or name=. [19:52:40] I wish that was the default ... [19:53:35] twentyafterfour: ^ dumb UI feature request. Hack Phab so that code blocks are lines=10 by default. :) [19:53:51] Ah thanks! Done! [19:54:00] bd808: not sure how easy that'd be... [19:54:11] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.19 deployment blockers - https://phabricator.wikimedia.org/T220744 (10greg) a:03zeljkofilipin [19:54:22] yeah, I imagine it would be an ugly overlay patch [19:54:42] I haven't ever looking into their markup renderer [19:55:14] if it's anything like every other lightweight markup renderer that gets any serious use, it's probably horrifying. [19:55:27] (exception to above statement for pandoc i guess.) [19:55:38] 10Continuous-Integration-Config, 10MediaWiki-extensions-CentralAuth, 10ci-test-error: CentralAuth tests are broken - https://phabricator.wikimedia.org/T229613 (10Urbanecm) >>! In T229613#5385676, @Jdforrester-WMF wrote: > CentralAuth isn't in the gate so this isn't a shared build failure. Ok [19:55:41] it is slightly scary if not horrifying [19:56:18] were i a wagering man, i would wager it's a stack inscrutable of regex transforms... [19:56:26] 'of [19:56:37] 10Phabricator (Upstream), 10Upstream: Multiple grep results in one line displayed incorrectly - https://phabricator.wikimedia.org/T197935 (10epriestley) I noted this on , which is not exactly adjacent but sort of has similar flavor and is somewhere in the pipeline. [19:58:52] bd808: actually, it looks like it'd be really easy to make a default [20:00:56] https://phabricator.wikimedia.org/diffusion/PHUTIL/browse/wmf%252Fstable/src/markup/engine/remarkup/blockrule/PhutilRemarkupCodeBlockRule.php$59 [20:01:54] looks like just changing the ``'lines' => null`` there, to ``=> 10`` would probably do the trick [20:02:32] nice [20:02:55] oh meeting time [20:06:01] * Krinkle makes looks at impending expiry date for https://test-commons.wikimedia.org/wiki/Main_Page [20:09:03] (03PS2) 10Thcipriani: php7x: restart php-fpm after all sync operations [tools/scap] - 10https://gerrit.wikimedia.org/r/525119 (https://phabricator.wikimedia.org/T224857) [20:19:23] !log Resolve Jenkins admin warning about legacy token by revoking it from the only user id "" that seems to have one [20:19:24] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:19:40] 10Phabricator (Upstream), 10Regression, 10Upstream: "Merge Duplicates"/"Edit Parent Tasks"/"Edit Subtasks" dialogs: Clicking on a task title closes the dialog instead of selecting the task - https://phabricator.wikimedia.org/T228224 (10matmarex) Thanks. So the patch fixes this by making the links not be rea... [20:22:59] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201908), 10MediaWiki-Core-Testing, 10Epic, 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10Jdlrobson) [20:34:12] 10Continuous-Integration-Config, 10LibUp, 10Test-Coverage: Publish labs/libraryupgrader test coverage report - https://phabricator.wikimedia.org/T229619 (10Legoktm) [20:37:01] 10Phabricator: if phabricator users are blocked due to IP range blocks send a 4xx rather than 500 - https://phabricator.wikimedia.org/T229620 (10Dzahn) [20:37:24] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10Jdforrester-WMF) [20:37:31] 10Phabricator: phabricator server 500 error - https://phabricator.wikimedia.org/T229575 (10Dzahn) >>! In T229575#5385580, @Aklapper wrote: > Feel free to file a new task about that. :) ok. T229620 [20:38:15] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10Jdforrester-WMF) [20:38:53] (No actual train blocker status change, just making the hierarchy reflect comments.) [20:39:35] saved a click for me ^ [21:00:48] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10Krinkle) [21:04:00] James_F: I'm staring at the stylelint docs now :p [21:04:32] * James_F grins. [21:15:32] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (201908), 10Release, 10Train Deployments: 1.34.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T220741 (10Krinkle) [21:36:50] 10Phabricator: if phabricator users are blocked due to IP range blocks send a 4xx rather than 500 - https://phabricator.wikimedia.org/T229620 (10Aklapper) I am neither sure where this code is located nor if it is public... Also see non-public T218589 etc. [21:43:25] 10Phabricator (Upstream), 10Upstream: Global Advanced search should support "any()" and "not()" functions in the "Tags" field, like Maniphest's Advanced Search does - https://phabricator.wikimedia.org/T168061 (10epriestley) See also T190342 and T224082. I believe that swapping this to a `ProjectFunctionDataso... [21:47:42] (03CR) 10Thcipriani: php7x: restart php-fpm after all sync operations (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/525119 (https://phabricator.wikimedia.org/T224857) (owner: 10Thcipriani) [21:55:19] 10Phabricator: if phabricator users are blocked due to IP range blocks send a 4xx rather than 500 - https://phabricator.wikimedia.org/T229620 (10sbassett) p:05Triage→03Normal