[00:07:27] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10Agusbou2015) [00:12:51] twentyafterfour: ^ [00:18:14] brennen: "java.lang.RuntimeException: Pipeline 'dev' is not defined in project's '.pipeline/config.yaml'" :-( [00:18:46] https://integration.wikimedia.org/ci/job/mediawiki-pipeline-dev/538/console [00:51:33] paladox: is it still happening to you? I can't reproduce [00:52:10] ah only logged out [00:54:09] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10mmodell) 05Open→03Resolved a:03mmodell [00:54:27] fixed :) [01:57:30] James_F: yeah. :\ [02:47:49] 10Release-Engineering-Team (Deployment services), 10Patch-For-Review, 10Release, 10Train Deployments: 1.34.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T220749 (10mmodell) 05Open→03Resolved [02:50:38] 10Phabricator, 10Release-Engineering-Team-TODO (201909), 10Wikimedia-Logstash, 10observability: Improve error reporting / integration between Kibana and Phabricator - https://phabricator.wikimedia.org/T185155 (10mmodell) 05Open→03Resolved [03:08:00] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 4 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [03:35:42] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909): Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10Krinkle) +1 for a separate job that runs qunit+wdio. I don't... [04:56:37] (03PS1) 10Brennen Bearnes: layout: trigger-mediawiki-pipeline-dev to -publish [integration/config] - 10https://gerrit.wikimedia.org/r/539447 (https://phabricator.wikimedia.org/T218360) [05:02:14] (03CR) 10jerkins-bot: [V: 04-1] layout: trigger-mediawiki-pipeline-dev to -publish [integration/config] - 10https://gerrit.wikimedia.org/r/539447 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [05:30:00] Twentyafterfour: nope, seems fixed now [07:57:20] (03CR) 10Thiemo Kreuz (WMDE): Improve checks for variargs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [08:00:03] Project mwcore-phpunit-coverage-master build #199: 04FAILURE in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/199/ [08:11:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909), 10Test-Coverage: mwcore-phpunit-coverage-master times out after 5 hours - https://phabricator.wikimedia.org/T232706 (10hashar) 05Resolved→03Open https://integration.wik... [08:45:03] 10Project-Admins: New Phabricator project for Wikicontrib - https://phabricator.wikimedia.org/T231268 (10Rammanojpotla) OK @Aklapper I will shift all the issues reported here to github soon. [09:03:33] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909), 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg - https://phabricator.wikimedia.org/T234020 (10hashar) [09:03:43] (03PS1) 10Thiemo Kreuz (WMDE): Enforce floatval() instead of the doubleval() alias [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539497 [09:05:45] (03CR) 10Thiemo Kreuz (WMDE): "I'm afraid I don't understand what you mean when you write "reduced complexity". Not only do both intval() and (int) require to use the li" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/492634 (https://phabricator.wikimedia.org/T216971) (owner: 10Mainframe98) [09:09:55] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909), 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg - https://phabricator.wikimedia.org/T234020 (10hashar) [09:11:46] 10Project-Admins: New Phabricator project for Wikicontrib - https://phabricator.wikimedia.org/T231268 (10Aklapper) 05Open→03Declined Thanks - I've archived https://phabricator.wikimedia.org/project/profile/4243/ [09:16:06] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909), 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10hashar) [09:18:12] (03CR) 10Mainframe98: "> Patch Set 6:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/492634 (https://phabricator.wikimedia.org/T216971) (owner: 10Mainframe98) [09:19:21] (03CR) 10Mainframe98: [C: 03+1] "+1, although a test case might not be a bad idea, given that this sniff does auto-fixes." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539497 (owner: 10Thiemo Kreuz (WMDE)) [10:16:05] 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Browser-Tests, 10Patch-For-Review: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10zeljkofilipin) [10:16:45] 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Browser-Tests, 10Patch-For-Review, 10User-zeljkofilipin: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10zeljkofilipin) [10:17:10] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Browser-Tests, and 2 others: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10hashar) [10:33:33] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, 10Quibble, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) [10:38:59] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, 10Quibble, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) [10:58:16] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, 10Patch-For-Review, 10User-zeljkofilipin: Upgrade webdriverio to version 5 - https://phabricator.wikimedia.org/T213268 (10Pablo-WMDE) WMDE action on this topic: * [[ https://gerrit.wikimed... [10:59:39] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, 10Quibble, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) It takes one second to write 100 000 lines: ` lang=php use M... [11:19:39] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, 10Quibble, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) p:05Triage→03Low [11:53:41] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (201909), 10local-charts, 10User-zeljkofilipin: Error: error installing: the server could not find the requested resource - https://phabricator.wikimedia.org/T233960 (10zeljkofilipin) @jeena looks like downgrading kubernetes isn't triv... [12:01:18] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (201909), 10local-charts, 10User-zeljkofilipin: Error: error installing: the server could not find the requested resource - https://phabricator.wikimedia.org/T233960 (10zeljkofilipin) Still no luck. ` ~/Documents/gerrit/releng/local-c... [12:03:27] 10Beta-Cluster-Infrastructure, 10DNS, 10Operations, 10Traffic, and 4 others: Ferm's upstream Net::DNS Perl library questionable handling of NOERROR responses without records causing puppet errors when we try to @resolve AAAA in labs - https://phabricator.wikimedia.org/T153468 (10MoritzMuehlenhoff) I've bui... [12:48:45] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10Patch-For-Review, 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [12:50:12] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10Patch-For-Review, 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [12:51:20] https://gerrit-review.googlesource.com/c/gerrit/+/238917 "Document recommendations for making security fixes" [12:54:49] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10DStrine) 05Declined→03Open [12:56:49] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10DStrine) >>! In T229628#5461717, @mmodell wrote: > My suggestion, if searching for `wmf-fr` or `-fr` still doesn't work, then try this: > > 1. Go to [[ /favorites/menu/c... [13:05:05] (03CR) 10Daimona Eaytoy: [C: 03+1] Remove prohibitions on new PHP features (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/538726 (https://phabricator.wikimedia.org/T231710) (owner: 10MaxSem) [13:10:18] (03PS1) 10Daimona Eaytoy: Don't suggest to use a temporary variable for &$this [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539529 [13:13:55] (03PS6) 10Awight: Isolate analysis from execution [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 [13:16:04] (03CR) 10Umherirrender: [C: 03+2] "It is another entry in an array and the array is tested, that looks good" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539497 (owner: 10Thiemo Kreuz (WMDE)) [13:16:39] (03CR) 10Daimona Eaytoy: Improve checks for variargs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [13:17:00] (03Merged) 10jenkins-bot: Enforce floatval() instead of the doubleval() alias [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539497 (owner: 10Thiemo Kreuz (WMDE)) [13:20:21] (03CR) 10jenkins-bot: Enforce floatval() instead of the doubleval() alias [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539497 (owner: 10Thiemo Kreuz (WMDE)) [13:26:39] (03CR) 10Daimona Eaytoy: [C: 03+1] ">" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/538726 (https://phabricator.wikimedia.org/T231710) (owner: 10MaxSem) [13:47:05] PROBLEM - Puppet errors on integration-agent-stretch-1001 is CRITICAL: CRITICAL: 46.81% of data above the critical threshold [3.0] [13:49:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909), 10Test-Coverage: mwcore-phpunit-coverage-master times out after 5 hours - https://phabricator.wikimedia.org/T232706 (10Anomie) [13:52:01] (03PS1) 10Hashar: Rephrase a comment in quibble.zuul.clone_worker [integration/quibble] - 10https://gerrit.wikimedia.org/r/539537 [13:56:52] (03CR) 10Hashar: Exit on cloning failure (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/538020 (https://phabricator.wikimedia.org/T233143) (owner: 10Hashar) [14:04:03] (03PS1) 10Hashar: Apply Chronometer when executing the build plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/539539 [14:06:10] (03CR) 10Hashar: "Applied with:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/503125 (owner: 10Hashar) [14:25:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909), 10Test-Coverage: mwcore-phpunit-coverage-master times out after 5 hours - https://phabricator.wikimedia.org/T232706 (10hashar) And the suite also list a bunch of very slow... [14:31:51] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10Aklapper) 05Open→03Stalled @DStrine: Can you please follow T229628#5464270 and provide web browser developer tools output? [14:41:15] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [14:41:38] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [14:59:46] (03PS1) 10Abijeet Patro: Add MassMessage as a dependency for TranslationNotifications [integration/config] - 10https://gerrit.wikimedia.org/r/539547 (https://phabricator.wikimedia.org/T144780) [15:01:40] (03PS2) 10Abijeet Patro: Add MassMessage as a dependency for TranslationNotifications [integration/config] - 10https://gerrit.wikimedia.org/r/539547 (https://phabricator.wikimedia.org/T144780) [15:22:59] (03PS1) 10Umherirrender: List @phan-assert as allowed annotation in functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539555 [15:26:22] (03CR) 10Daimona Eaytoy: [C: 03+1] "Would you mind adding them to the test, please?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539555 (owner: 10Umherirrender) [15:39:19] (03PS2) 10Umherirrender: List @phan-assert as allowed annotation in functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539555 [15:40:37] (03CR) 10Umherirrender: "Added code example for testing" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539555 (owner: 10Umherirrender) [15:41:11] (03CR) 10Daimona Eaytoy: [C: 03+2] "> Added code example for testing" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539555 (owner: 10Umherirrender) [15:41:57] (03Merged) 10jenkins-bot: List @phan-assert as allowed annotation in functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539555 (owner: 10Umherirrender) [15:42:30] (03CR) 10jenkins-bot: List @phan-assert as allowed annotation in functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539555 (owner: 10Umherirrender) [15:51:47] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [15:54:20] 10MediaWiki-Codesniffer, 10Patch-For-Review: Position of boolean operators inside an if condition - https://phabricator.wikimedia.org/T116561 (10Umherirrender) The new PSR12.ControlStructures.BooleanOperatorPlacement from release 3.5.0 sounds a bit like this https://github.com/squizlabs/PHP_CodeSniffer/releas... [15:58:27] (03PS1) 10Umherirrender: Update squizlabs/php_codesniffer to 3.5.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539564 [16:03:22] (03CR) 10Umherirrender: "It is a long release list, there are may some sniffs we can add to ourer ruleset, but that should be done in separate patch set to allow d" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539564 (owner: 10Umherirrender) [16:10:00] (03CR) 10Daimona Eaytoy: [C: 03+1] Update squizlabs/php_codesniffer to 3.5.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539564 (owner: 10Umherirrender) [16:11:11] (03CR) 10Daimona Eaytoy: [C: 03+1] "> It is a long release list, there are may some sniffs we can add to" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539564 (owner: 10Umherirrender) [16:21:02] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [16:28:02] 10Continuous-Integration-Config, 10phan: mediawiki-core-php72-phan-docker is actually running on PHP 7.0.33 - https://phabricator.wikimedia.org/T234062 (10Daimona) [16:28:32] 10MediaWiki-Codesniffer, 10Patch-For-Review: Position of boolean operators inside an if condition - https://phabricator.wikimedia.org/T116561 (10Krinkle) [16:31:06] 10MediaWiki-Codesniffer: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Krinkle) [16:31:14] 10MediaWiki-Codesniffer: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Krinkle) p:05Triage→03Normal [16:31:40] (03CR) 10Umherirrender: Don't suggest to use a temporary variable for &$this (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539529 (owner: 10Daimona Eaytoy) [16:32:17] 10MediaWiki-Codesniffer: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Krinkle) Accepting, on the assumption that there isn't a built-in rule already that can be enabled through `phpcs.xml`. We'd ship a rule for it, but leave it out of the default pre... [16:32:43] 10MediaWiki-Codesniffer: Add a sniff to disallow @internal and @since on the same documented member - https://phabricator.wikimedia.org/T229454 (10Krinkle) p:05Triage→03Normal [16:33:15] (03CR) 10Daimona Eaytoy: Don't suggest to use a temporary variable for &$this (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539529 (owner: 10Daimona Eaytoy) [16:51:42] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [16:52:15] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [16:53:36] (03CR) 10Umherirrender: Improve checks for variargs (036 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [16:53:52] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (201909), 10local-charts, 10User-zeljkofilipin: Error: error installing: the server could not find the requested resource - https://phabricator.wikimedia.org/T233960 (10jeena) you need to downgrade your minikube to version 1.3 If using... [16:59:08] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201909), 10User-zeljkofilipin: Update existing Selenium documentation - https://phabricator.wikimedia.org/T232598 (10zeljkofilipin) [17:07:46] (03CR) 10Daimona Eaytoy: Improve checks for variargs (035 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [17:18:25] (03CR) 10Thcipriani: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/539447 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [17:21:03] (03PS7) 10Daimona Eaytoy: Improve checks for variargs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) [17:23:05] (03PS2) 10Brennen Bearnes: layout: trigger-mediawiki-pipeline-dev to -publish [integration/config] - 10https://gerrit.wikimedia.org/r/539447 (https://phabricator.wikimedia.org/T218360) [17:33:05] (03CR) 10Umherirrender: Improve checks for variargs (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [17:33:56] (03CR) 10Daimona Eaytoy: Improve checks for variargs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [17:34:08] (03PS8) 10Daimona Eaytoy: Improve checks for variargs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) [17:39:47] (03PS1) 10Umherirrender: [WikibaseQualityConstraints] Run phan job [integration/config] - 10https://gerrit.wikimedia.org/r/539588 (https://phabricator.wikimedia.org/T224773) [17:44:29] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201909), 10Release Pipeline, 10User-zeljkofilipin: Gerrit/Argo CI proof of concept - https://phabricator.wikimedia.org/T229246 (10dduvall) 05Open→03Resolved [17:44:40] 10Continuous-Integration-Infrastructure: quibble-composer-sqlite-php72-docker does not use cache for composer downloads - https://phabricator.wikimedia.org/T234075 (10Umherirrender) [17:53:58] 10Project-Admins: Create user-SwedishMuseum project - https://phabricator.wikimedia.org/T234078 (10Bugreporter) [17:57:42] 10Continuous-Integration-Config, 10phan: mediawiki-core-php72-phan-docker is actually running on PHP 7.0.33 - https://phabricator.wikimedia.org/T234062 (10Daimona) [17:57:53] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10epriestley) Ignore me if I have no clue what's going on, but I added another call to this method in , which may need adjustment if you've tweaked it (which I //think// is what's... [17:58:08] 10Continuous-Integration-Config, 10phan: mediawiki-core-php72-phan-docker is actually running on PHP 7.0.33 - https://phabricator.wikimedia.org/T234062 (10Daimona) Trying to change the composer.json PHP requirement will make the job fail. [17:58:23] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10epriestley) (That change is from 5 seconds ago so this would just be something to keep an eye on for the next deployment.) [18:19:55] (03CR) 10Thcipriani: [C: 03+2] layout: trigger-mediawiki-pipeline-dev to -publish [integration/config] - 10https://gerrit.wikimedia.org/r/539447 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [18:22:33] (03Merged) 10jenkins-bot: layout: trigger-mediawiki-pipeline-dev to -publish [integration/config] - 10https://gerrit.wikimedia.org/r/539447 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [18:23:33] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/539447 [18:23:35] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:37:36] 10Continuous-Integration-Infrastructure, 10User-DannyS712: Skins: Tests should ensure that `ResourceModuleSkinStyles` all exist - https://phabricator.wikimedia.org/T234092 (10DannyS712) [19:22:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I agree. I can't think of a good reason to pass a pointer to the current object by reference. I mean, it's possible to think of a rare sit" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539529 (owner: 10Daimona Eaytoy) [19:34:18] twentyafterfour: thcipriani: paladox: I found another nice setting in Gerrit "reindexAfterUpdate" https://gerrit.wikimedia.org/r/Documentation/config-gerrit.html#index.reindexAfterRefUpdate [19:34:42] so that every time a branch is updated, Gerrit internally reindex all pending open changes [19:34:46] to check whether they can still be merged [19:35:20] maybe that is a potential source of slowness when we cut the wmf branches ;D [19:39:53] (03CR) 10Hashar: [C: 03+2] Add MassMessage as a dependency for TranslationNotifications [integration/config] - 10https://gerrit.wikimedia.org/r/539547 (https://phabricator.wikimedia.org/T144780) (owner: 10Abijeet Patro) [19:41:50] (03Merged) 10jenkins-bot: Add MassMessage as a dependency for TranslationNotifications [integration/config] - 10https://gerrit.wikimedia.org/r/539547 (https://phabricator.wikimedia.org/T144780) (owner: 10Abijeet Patro) [19:44:05] hashar: I saw that setting at one point. I'm not sure what the consequences are to turning it off, exactly...needs some testing. [19:44:26] that is merely for the mergeability flag, so probably hardly an issue for us ;] [19:59:24] ohh [20:00:03] Project mwcore-phpunit-coverage-master build #200: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/200/ [20:00:51] i think google disabled that config on there site [20:00:55] for performance reasons [20:01:02] though i could be wrong... so i'm going to ask! [20:01:13] !log Marking integration-agent-docker-1015 offline due to cloudvirt1004 being wayyyyy too slow T223971 [20:01:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:01:16] T223971: Old cloudvirt (with Intel Xeon) are twice slower than new ones (Intel Sky Lake) - https://phabricator.wikimedia.org/T223971 [20:14:14] hashar spoke with luca who said that the negatives is wrong search results or stale indexes [20:14:27] we could up the index threads would that help? [20:14:48] cc thcipriani ^ [20:18:27] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201909), 10Operations, and 2 others: Prepare Phame to support heavy traffic for a Tech Department blog - https://phabricator.wikimedia.org/T226044 (10greg) >>! In T226044#5527864, @CDanis wrote: > Just curiou... [20:46:02] 10Continuous-Integration-Infrastructure: quibble-composer-sqlite-php72-docker does not use cache for composer downloads - https://phabricator.wikimedia.org/T234075 (10hashar) The cache is only populated for job triggered in gate-and-submit or postmerge. Since that is only in experimental pipeline, the cache is n... [20:46:45] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909): quibble-composer-sqlite-php72-docker does not use cache for composer downloads - https://phabricator.wikimedia.org/T234075 (10hashar) 05Open→03Resolved a:03hashar [20:47:53] paladox: probably a stale index yeah [20:47:53] paladox: but I don't want to mess with them, I barely understand how that mess works :] [20:48:04] heh [20:48:58] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909): quibble-composer-sqlite-php72-docker does not use cache for composer downloads - https://phabricator.wikimedia.org/T234075 (10hashar) As usual: thank you @Umherirrender ! [20:52:21] paladox: this afternoon I tried to find out how to check the status of the indices [20:52:25] but could not find any lead [20:52:44] oh [20:52:46] though there is https://gerrit.wikimedia.org/r/Documentation/pgm-reindex.html [20:52:51] yeh [20:52:59] you can also index changes through the rest api [20:53:01] but I clearly remember that Chad was swearing about it [20:53:07] yeah [20:53:14] so I tried gerrit index change XXXX [20:53:23] with XXXX being a change for a no more existing repo [20:53:28] yup [20:53:34] and unsurprisingly that just yields an error about that repo not existing [20:53:44] so I am just assuming the change did not get dropped from the index [20:53:45] ;D [20:53:46] oh :( [20:54:02] hashar what about a full reindex? [20:54:07] without specifying the change num? [20:54:39] https://gerrit-review.googlesource.com/Documentation/cmd-index-start.html [20:54:47] ssh -p 29418 review.example.com gerrit index start changes --force [20:56:57] would you mind suggesting that on the task? [20:57:25] then I guess I would prefer to pair that with twentyafterfour and/or thcipriani [20:57:57] ok [20:58:47] hashar done [20:58:51] 10Gerrit: Lots of "Skipping change xxx because the corresponding repository was not found" in the logs - https://phabricator.wikimedia.org/T233989 (10Paladox) I wonder should we do a full online reindex https://gerrit-review.googlesource.com/Documentation/cmd-index-start.html ssh -p 29418 @gerrit.wikimedi... [21:01:38] !log T233989 I have failed to run (must be run offline): /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java -jar /var/lib/gerrit2/review_site/bin/gerrit.war reindex --list [21:01:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:01:41] T233989: Lots of "Skipping change xxx because the corresponding repository was not found" in the logs - https://phabricator.wikimedia.org/T233989 [21:03:23] paladox: thx [21:03:31] I am not going to run that on a friday night though ;] [21:04:25] ok [21:04:50] If we want to do offline indexing, upstream did a fix that improved performance [21:05:13] https://www.gerritcodereview.com/2.15.html#21517 [21:05:21] "Allow to override autodetected Lucene index configuration." [21:06:45] ahhhh nice [21:51:01] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201909): CI mediawiki/core run times have increased since July 26th - https://phabricator.wikimedia.org/T232626 (10hashar) [21:51:03] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201909): Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10hashar) [21:52:01] (03PS1) 10Hashar: Dedicated Selenium job for gated repos [integration/config] - 10https://gerrit.wikimedia.org/r/539630 (https://phabricator.wikimedia.org/T232759) [21:52:49] (03CR) 10Hashar: "Late friday night hacking, probably need to update some test." [integration/config] - 10https://gerrit.wikimedia.org/r/539630 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [21:54:46] (03CR) 10jerkins-bot: [V: 04-1] Dedicated Selenium job for gated repos [integration/config] - 10https://gerrit.wikimedia.org/r/539630 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar)