[00:32:39] 10Scap, 10Performance-Team (Radar): Scap silently ignores sync and service restart if hash is equal - https://phabricator.wikimedia.org/T234872 (10Krinkle) [00:32:50] 10Release-Engineering-Team, 10Scap, 10Performance-Team (Radar): Scap silently ignores sync and service restart if hash is equal - https://phabricator.wikimedia.org/T234872 (10Krinkle) [00:34:54] 10Release-Engineering-Team, 10Scap, 10Performance-Team (Radar): Scap silently ignores sync and service restart if hash is equal - https://phabricator.wikimedia.org/T234872 (10Krinkle) [02:12:05] (03PS1) 10Dduvall: Fix wgVersion bump and .gitignore [tools/release] - 10https://gerrit.wikimedia.org/r/541405 [02:13:39] (03CR) 10Dduvall: "See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/541387#message-fc265367b5cebc456b704513fc84c70f66e2927d for justification." [tools/release] - 10https://gerrit.wikimedia.org/r/541405 (owner: 10Dduvall) [03:15:04] 10Phabricator: Change username - https://phabricator.wikimedia.org/T234877 (10TheMesquito) [03:18:12] 10Phabricator: Change username - https://phabricator.wikimedia.org/T234877 (10TheMesquito) [03:24:23] (03CR) 10Jforrester: [C: 03+2] Fix wgVersion bump and .gitignore [tools/release] - 10https://gerrit.wikimedia.org/r/541405 (owner: 10Dduvall) [03:25:00] (03Merged) 10jenkins-bot: Fix wgVersion bump and .gitignore [tools/release] - 10https://gerrit.wikimedia.org/r/541405 (owner: 10Dduvall) [03:36:47] 10Phabricator: Change my Phabricator username from TheMesquito to CodeLyoko - https://phabricator.wikimedia.org/T234877 (10TheMesquito) [04:19:47] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [05:46:54] huh, what was that about I wonder [05:50:16] Yippee, build fixed! [05:50:16] Project mwcore-phpunit-coverage-master build #223: 09FIXED in 2 hr 50 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/223/ [06:18:41] 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, 10wikitech.wikimedia.org, and 3 others: switch wikitech to PHP 7.2 - https://phabricator.wikimedia.org/T223393 (10Joe) >>! In T223393#5553766, @Jdforrester-WMF wrote: > If this isn't done before tomorrow, the train rollout will break wikitechwiki... [06:56:10] (03CR) 10Awight: [C: 03+2] "Looks fun!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/540881 (owner: 10Hashar) [06:57:08] (03CR) 10Awight: [C: 03+2] "Nice doc magic! Thanks for compiling this list." [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [07:04:37] (03CR) 10Awight: [C: 03+2] setup.cfg: add metadata [integration/quibble] - 10https://gerrit.wikimedia.org/r/540880 (owner: 10Hashar) [07:05:21] (03CR) 10Awight: [C: 03+2] Do run python setup.py check [integration/quibble] - 10https://gerrit.wikimedia.org/r/540882 (owner: 10Hashar) [07:09:04] (03PS7) 10Awight: Isolate analysis from execution [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 [07:14:29] (03PS8) 10Awight: Isolate analysis from execution [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 [07:18:01] (03CR) 10Awight: [C: 04-1] "I think this is the right direction to move in, but my patch isn't quite ready. Most steps can only be refined after cloning, so the "pla" [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 (owner: 10Awight) [08:32:16] 10Phabricator: Change my Phabricator username from TheMesquito to CodeLyoko - https://phabricator.wikimedia.org/T234877 (10Aklapper) 05Open→03Resolved a:03Aklapper Yes! :) Done. [09:31:47] 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10Tools, 10Wikimedia-Incident, 10cloud-services-team (Kanban): Various user visible errors in Cloud VPS projects following OpenStack upgrade on 2019-10-07 - https://phabricator.wikimedia.org/T234834 (10aborrero) [09:32:12] 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10Tools, 10Wikimedia-Incident, 10cloud-services-team (Kanban): Various user visible errors in Cloud VPS projects following OpenStack upgrade on 2019-10-07 - https://phabricator.wikimedia.org/T234834 (10aborrero) [10:05:40] 10Gerrit, 10Release-Engineering-Team: Set gerrit1001 master switch date - https://phabricator.wikimedia.org/T234866 (10Peachey88) [10:14:23] (03CR) 10Kosta Harlan: Simplify settings overrides (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/541361 (https://phabricator.wikimedia.org/T199939) (owner: 10Awight) [10:16:29] 10Release-Engineering-Team-TODO (201910), 10Quibble: Grant Kosta Harlan +2 to integration/quibble - https://phabricator.wikimedia.org/T234898 (10hashar) [10:17:10] 10Release-Engineering-Team-TODO (201910), 10Quibble: Grant Kosta Harlan +2 to integration/quibble - https://phabricator.wikimedia.org/T234898 (10hashar) 05Open→03Resolved a:03hashar I have done it yesterday while being in audio with Kosta :] [10:17:26] ^ nice [10:19:08] (03CR) 10Hashar: [C: 03+2] Migrate to setup.cfg [integration/quibble] - 10https://gerrit.wikimedia.org/r/540863 (owner: 10Hashar) [10:19:37] (03CR) 10Hashar: [C: 03+2] "Went ahead to also get all the follow up change merged in :)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/540863 (owner: 10Hashar) [10:19:50] (03Merged) 10jenkins-bot: Migrate to setup.cfg [integration/quibble] - 10https://gerrit.wikimedia.org/r/540863 (owner: 10Hashar) [10:19:53] (03Merged) 10jenkins-bot: setup.cfg: add metadata [integration/quibble] - 10https://gerrit.wikimedia.org/r/540880 (owner: 10Hashar) [10:19:55] (03CR) 10Hashar: [C: 04-1] "Canceling the +2 for now" [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [10:19:57] (03Merged) 10jenkins-bot: Use setuptools_scm to determine the version [integration/quibble] - 10https://gerrit.wikimedia.org/r/540881 (owner: 10Hashar) [10:19:59] (03Merged) 10jenkins-bot: Do run python setup.py check [integration/quibble] - 10https://gerrit.wikimedia.org/r/540882 (owner: 10Hashar) [10:20:16] (03CR) 10Hashar: [C: 04-1] "I think I have to rebase this one and update the changelog. Some additional changes have been merged since I wrote the patch. Will work o" [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [10:24:33] (03CR) 10Awight: Simplify settings overrides (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/541361 (https://phabricator.wikimedia.org/T199939) (owner: 10Awight) [10:40:58] I think I'm starting to round the next corner with the quibble pipeline representation. [10:41:36] Each step is a monad, with the type () -> ([more commands]) [10:42:55] That lets us make the pipeline in recursive stages, e.g. SingleRepoStage which will expand into the project-only tests like linting. [10:44:01] I'll drop this idea of planning before execution, it hasn't proven helpful. [10:45:49] But normalizing most of the logic from cmd.py into Command steps will let us keep a detailed record of what was *actually* executed, to print at the end. [10:51:57] (03CR) 10Kosta Harlan: [C: 03+2] Simplify settings overrides (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/541361 (https://phabricator.wikimedia.org/T199939) (owner: 10Awight) [10:53:08] (03Merged) 10jenkins-bot: Simplify settings overrides [integration/quibble] - 10https://gerrit.wikimedia.org/r/541361 (https://phabricator.wikimedia.org/T199939) (owner: 10Awight) [11:07:59] (03PS3) 10Hashar: Maintain a changelog [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 [11:09:43] (03CR) 10Hashar: "Rebased. I have updated the changelog to add entries that has been introduced meanwhile. Notably the LocalSettings.php being wrapped (nice" [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [11:15:01] (03CR) 10Kosta Harlan: [C: 03+1] Maintain a changelog [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [11:41:06] (03CR) 10Awight: [C: 03+2] Maintain a changelog [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [11:41:53] (03Merged) 10jenkins-bot: Maintain a changelog [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [11:56:40] 10Release-Engineering-Team (Code Health), 10Release-Engineering-Team-TODO (201908), 10Code-Stewardship-Reviews, 10Graphoid, and 3 others: graphoid: Code stewardship request - https://phabricator.wikimedia.org/T211881 (10dr0ptp4kt) @Milimetric the visual treatment depends on a few factors, although yes, I t... [12:17:26] (03Abandoned) 10Awight: Skip `npm install` for PHPUnit coverage jobs [integration/config] - 10https://gerrit.wikimedia.org/r/540389 (https://phabricator.wikimedia.org/T225008) (owner: 10Awight) [12:18:56] (03PS2) 10Kosta Harlan: (wip) docker: Bump quibble to 0.0.36 [integration/config] - 10https://gerrit.wikimedia.org/r/541354 [12:20:37] (03CR) 10jerkins-bot: [V: 04-1] (wip) docker: Bump quibble to 0.0.36 [integration/config] - 10https://gerrit.wikimedia.org/r/541354 (owner: 10Kosta Harlan) [12:36:49] 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10Tools, 10Wikimedia-Incident, 10cloud-services-team (Kanban): Various user visible errors in Cloud VPS projects following OpenStack upgrade on 2019-10-07 - https://phabricator.wikimedia.org/T234834 (10aborrero) [12:40:27] 10Project-Admins, 10User-DannyS712: Create WikiJournals tag - https://phabricator.wikimedia.org/T234178 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #WikiJournals has been created: https://phabricator.wikimedia.org/project/view/4317/ Please encourage interested people to visit th... [12:56:44] 10Phabricator: Reset 2FA for Phabricator account `Apap04` - https://phabricator.wikimedia.org/T234233 (10thcipriani) 05Open→03Resolved a:03thcipriani >>! In T234233#5549503, @bd808 wrote: >>>! In T234233#5549465, @Apap04 wrote: >> @bd808 Done. > > ` > $ ssh bastion.wmflabs.org > $ ls -lh ~apap04/2fa-reset... [13:04:52] 10Phabricator: Reset 2FA for Phabricator account `Apap04` - https://phabricator.wikimedia.org/T234233 (10Apap04) Thank you! :) [13:05:31] (03PS9) 10Awight: Commands can expand recursively [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 [13:06:19] (03CR) 10jerkins-bot: [V: 04-1] Commands can expand recursively [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 (owner: 10Awight) [13:22:34] (03PS3) 10Kosta Harlan: (wip) docker: Bump quibble to 0.0.36 [integration/config] - 10https://gerrit.wikimedia.org/r/541354 [13:23:46] (03PS10) 10Awight: Commands can expand recursively [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 [13:24:08] (03CR) 10jerkins-bot: [V: 04-1] (wip) docker: Bump quibble to 0.0.36 [integration/config] - 10https://gerrit.wikimedia.org/r/541354 (owner: 10Kosta Harlan) [13:24:32] (03CR) 10jerkins-bot: [V: 04-1] Commands can expand recursively [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 (owner: 10Awight) [13:25:24] (03PS4) 10Kosta Harlan: (wip) docker: Bump quibble to 0.0.36 [integration/config] - 10https://gerrit.wikimedia.org/r/541354 [13:25:30] Apparently I'm unable to correctly format a changelog today [13:26:54] (03CR) 10Awight: [C: 04-1] "Thanks for the comments, I'll reuse this change-id for a different and simpler approach." [integration/quibble] - 10https://gerrit.wikimedia.org/r/540387 (https://phabricator.wikimedia.org/T225008) (owner: 10Awight) [13:44:55] (03PS2) 10Awight: Npm install before each node command [integration/quibble] - 10https://gerrit.wikimedia.org/r/540387 (https://phabricator.wikimedia.org/T225008) [14:14:12] 10Project-Admins, 10Developer-Advocacy (Oct-Dec 2019): Sort out #Editing-Team vs #VisualEditor Phabricator project tags - https://phabricator.wikimedia.org/T234648 (10Aklapper) [14:27:53] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Beta-Cluster-reproducible: Beta Cluster cross-wiki login request would be blocked by CSP - https://phabricator.wikimedia.org/T211539 (10sbassett) > Thanks :) There may've been a misunderstanding here. This still applies t... [14:32:35] 10Gerrit, 10Release-Engineering-Team: Set gerrit1001 master switch date - https://phabricator.wikimedia.org/T234866 (10thcipriani) > Run /usr/bin/java -jar review_site/bin/gerrit.war reindex -d review_site --threads 4 (this may take a while) I've seen Luca say on the mailing list that the offline reindex tak... [14:35:33] (03PS1) 10Hashar: Fix header in README.rst [integration/quibble] - 10https://gerrit.wikimedia.org/r/541551 [14:35:35] (03PS1) 10Hashar: qa: use lazy formatting for logging calls [integration/quibble] - 10https://gerrit.wikimedia.org/r/541552 [14:38:07] (03CR) 10Jforrester: [C: 03+2] Fix header in README.rst [integration/quibble] - 10https://gerrit.wikimedia.org/r/541551 (owner: 10Hashar) [14:38:52] (03Merged) 10jenkins-bot: Fix header in README.rst [integration/quibble] - 10https://gerrit.wikimedia.org/r/541551 (owner: 10Hashar) [14:39:04] (03CR) 10Hashar: "Looks more or less fine on: https://doc.wikimedia.org/quibble/changelog.html" [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [14:39:39] (03PS2) 10Jforrester: qa: use lazy formatting for logging calls [integration/quibble] - 10https://gerrit.wikimedia.org/r/541552 (owner: 10Hashar) [14:40:09] (03CR) 10Jforrester: "Neat." [integration/quibble] - 10https://gerrit.wikimedia.org/r/540900 (owner: 10Hashar) [14:40:12] (03CR) 10Hashar: "The generated doc at https://doc.wikimedia.org/quibble/ shows a version 0.1.dev2 since the job uses a shallow clone :-\" [integration/quibble] - 10https://gerrit.wikimedia.org/r/540881 (owner: 10Hashar) [14:41:45] (03CR) 10Jforrester: [C: 03+2] qa: use lazy formatting for logging calls [integration/quibble] - 10https://gerrit.wikimedia.org/r/541552 (owner: 10Hashar) [14:42:32] (03Merged) 10jenkins-bot: qa: use lazy formatting for logging calls [integration/quibble] - 10https://gerrit.wikimedia.org/r/541552 (owner: 10Hashar) [14:43:01] (03CR) 10Jforrester: qa: use lazy formatting for logging calls (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/541552 (owner: 10Hashar) [14:47:09] 10Release-Engineering-Team, 10Scap, 10Performance-Team (Radar): Scap silently ignores sync and service restart if hash is equal - https://phabricator.wikimedia.org/T234872 (10thcipriani) p:05Triage→03Normal > I'm neutral on whether this optimisation is useful, but at the very least I think it could be ma... [15:25:04] 10Project-Admins, 10Developer-Advocacy (Oct-Dec 2019): Sort out #Editing-Team vs #VisualEditor Phabricator project tags - https://phabricator.wikimedia.org/T234648 (10matmarex) > The VisualEditor (Current work) milestone should be archived and its open tasks transferred to the Editing-team workboard. Tasks tha... [15:32:08] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is malfunctioning - https://phabricator.wikimedia.org/T234743 (10Jdforrester-WMF) >>! In T234743#5550291, @Tgr wrote: > As noted in T233561#5532950 the start of these issues roughly coincides with variant settin... [16:02:49] (03PS1) 10Daimona Eaytoy: docker: [mediawiki-phan] Fix phan version validation [integration/config] - 10https://gerrit.wikimedia.org/r/541559 (https://phabricator.wikimedia.org/T220589) [16:04:20] (03PS2) 10Daimona Eaytoy: docker: [mediawiki-phan] Fix phan version validation [integration/config] - 10https://gerrit.wikimedia.org/r/541559 (https://phabricator.wikimedia.org/T220589) [16:04:57] (03PS6) 10Daimona Eaytoy: jjb: Move *-php72-phan-docker to image 0.5.1 [integration/config] - 10https://gerrit.wikimedia.org/r/541352 [16:05:55] (03CR) 10jerkins-bot: [V: 04-1] docker: [mediawiki-phan] Fix phan version validation [integration/config] - 10https://gerrit.wikimedia.org/r/541559 (https://phabricator.wikimedia.org/T220589) (owner: 10Daimona Eaytoy) [16:06:09] (03PS7) 10Daimona Eaytoy: jjb: Move *-php72-phan-docker to image 0.5.2 [integration/config] - 10https://gerrit.wikimedia.org/r/541352 [16:06:26] Daimona: Looks good (but you're not allowed tabs). Did you manage to test? [16:07:21] James_F: oh, bad defaults. Not yet, TBH [16:08:06] (03PS3) 10Daimona Eaytoy: docker: [mediawiki-phan] Fix phan version validation [integration/config] - 10https://gerrit.wikimedia.org/r/541559 (https://phabricator.wikimedia.org/T220589) [16:09:24] I can quickly test in 5 minutes-ish [16:18:25] James_F: from a quick test, it's working [16:21:19] 10Gerrit, 10Release-Engineering-Team: Set gerrit1001 master switch date - https://phabricator.wikimedia.org/T234866 (10Paladox) [16:23:49] (03CR) 10Jforrester: [C: 03+2] docker: [mediawiki-phan] Fix phan version validation [integration/config] - 10https://gerrit.wikimedia.org/r/541559 (https://phabricator.wikimedia.org/T220589) (owner: 10Daimona Eaytoy) [16:25:25] (03Merged) 10jenkins-bot: docker: [mediawiki-phan] Fix phan version validation [integration/config] - 10https://gerrit.wikimedia.org/r/541559 (https://phabricator.wikimedia.org/T220589) (owner: 10Daimona Eaytoy) [16:27:11] !log Docker: [mediawiki-phan] Fix phan version validation [16:27:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:31:30] * Daimona is crossing fingers [16:31:32] OK, I've pushed mwskin-php72-phan-docker. Checking. [16:31:57] You can follow along at home on https://integration.wikimedia.org/ci/job/mwskin-php72-phan-docker/1655/. [16:32:36] LGTM. [16:33:07] Now https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/15041/console [16:33:19] Yay let's see [16:34:15] Alright, seems good - some dirs weren't found but this may predate the upgrade [16:34:24] https://integration.wikimedia.org/ci/job/mediawiki-core-php72-phan-docker/7999/ [16:34:32] Yeah. [16:35:12] Collection extension isn't the best-maintained. [16:35:23] Ah, no problem. So at least this is working [16:35:35] OK, good enough for me. [16:35:48] We'll see how it goes with the new phan version - to be released after https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/+/541556/ is merged [16:35:58] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/541352 (owner: 10Daimona Eaytoy) [16:36:13] Yeah. [16:36:36] Daimona: Also, physician, heal thyself: https://integration.wikimedia.org/ci/job/composer-package-php72-docker/7492/console ;-) [16:37:15] Meh, that's PHPCS [16:37:25] Yeah. [16:37:45] Because, yes, we need that before releasing phan. And in turn, that's blocked on a couple of PHP-related patches. Fun, isn't it? :) [16:38:06] (03Merged) 10jenkins-bot: jjb: Move *-php72-phan-docker to image 0.5.2 [integration/config] - 10https://gerrit.wikimedia.org/r/541352 (owner: 10Daimona Eaytoy) [16:38:40] What's left for MW-CS? [16:39:02] Oh, right, I didn't merge https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/539308/ [16:39:20] (03CR) 10Jforrester: [C: 03+2] Add rules for PHP71 nullable types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539308 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [16:39:50] (03Merged) 10jenkins-bot: Add rules for PHP71 nullable types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539308 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [16:40:21] (03CR) 10jenkins-bot: Add rules for PHP71 nullable types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539308 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [16:40:50] Yes, that one and also https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/codesniffer/+/539177/ [16:45:12] (03PS13) 10Jforrester: Improve checks for variargs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [16:52:11] 10MediaWiki-Codesniffer: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants null even if type is nullable - https://phabricator.wikimedia.org/T218816 (10Daimona) 05Open→03Resolved Calling it resolved, although PHPCS will still fail for the original reported code. Although with a different error... [17:13:52] (03CR) 10Jforrester: [C: 03+2] Improve checks for variargs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [17:14:21] (03Merged) 10jenkins-bot: Improve checks for variargs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [17:15:44] James_F: thanks! Shortly I'll release a new version and open a task for bumping PHPCS everywhere [17:15:45] (03CR) 10jenkins-bot: Improve checks for variargs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/539177 (https://phabricator.wikimedia.org/T231710) (owner: 10Daimona Eaytoy) [17:17:54] 10Release-Engineering-Team (Deployment services), 10Security-Team, 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Wikimedia-extension-review-queue: Deploy WebAuthn to Wikimedia Wikis - https://phabricator.wikimedia.org/T227242 (10Reedy) [17:20:19] Daimona: Excellent. [17:25:25] 10MediaWiki-Releasing, 10Release-Engineering-Team-TODO (201910), 10Core Platform Team, 10MW-1.34-notes, 10MW-1.34-release: Branch REL1_34 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T232024 (10dduvall) 05Open→03Resolved The `REL1_34` branch has been created for all activ... [17:25:30] 10Release-Engineering-Team-TODO (201910), 10MediaWiki-General, 10Release: Mark MediaWiki core as 1.35.0-alpha once REL1_34 is branched - https://phabricator.wikimedia.org/T232030 (10dduvall) [17:25:32] 10MediaWiki-Releasing, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.34-release: Release MW 1.34 - https://phabricator.wikimedia.org/T232023 (10dduvall) [17:31:17] (03PS8) 10Umherirrender: Create new sniff for doc comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/528280 [17:31:25] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/528280 (owner: 10Umherirrender) [17:37:33] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10Documentation: Standardise the docs for variadic arguments and make doxygen understand it - https://phabricator.wikimedia.org/T233787 (10Daimona) 05Open→03Resolved [17:43:12] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (201910), 10Release Pipeline, 10Maps (Kartotherian): Deployment Pipeline fails with CPS error for Kartotherian - https://phabricator.wikimedia.org/T233316 (10dduvall) [17:47:54] PROBLEM - Parsoid on deployment-parsoid09 is CRITICAL: connect to address 172.16.5.63 and port 8000: Connection refused [17:47:54] PROBLEM - Parsoid on deployment-mediawiki-parsoid10 is CRITICAL: connect to address 172.16.0.141 and port 8000: Connection refused [18:09:12] 10Phabricator, 10I18n, 10User-Nikerabbit: Please add Brazilian Portuguese (pt-br) language to Phabricator - https://phabricator.wikimedia.org/T215697 (10mmodell) 05Open→03Stalled [18:43:08] PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 53.33% of data above the critical threshold [140.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [18:53:09] @thcipriani any chance i can ge tthis backported for the train or is it far too late? https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/541596/ [18:55:26] Jdlrobson: marxarelli is conductor this week. Not sure of thecurrent status [18:56:43] Jdlrobson: i haven't sync'd group0 so there's time for a backport [18:57:30] thank you. marxarelli how should I go ahead and do that? [18:57:38] It's been a while since I backported.. [18:57:48] cherry pick it in gerrit :P [18:58:22] Jdlrobson: your patch is already for the wmf/1.35.0-wmf.1 branch so you're done :) [18:58:28] <3 thank you! [18:58:56] granted jenkins says it's ok [19:02:01] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Beta-Cluster-reproducible: Beta Cluster cross-wiki login request would be blocked by CSP - https://phabricator.wikimedia.org/T211539 (10Jdforrester-WMF) Yeah, the extension function in -labs seems to be getting run before... [19:20:40] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Beta-Cluster-reproducible: Beta Cluster cross-wiki login request would be blocked by CSP - https://phabricator.wikimedia.org/T211539 (10Jdforrester-WMF) https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/541... [19:44:19] (03CR) 10Hashar: qa: use lazy formatting for logging calls (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/541552 (owner: 10Hashar) [19:51:15] hashar: https://gerrit.wikimedia.org/r/c/integration/config/+/541354 is ready whenever you want to tag quibble. Are you waiting for other patches to land in 0.0.36? [19:56:01] kostajh: yes ;) [19:56:05] writing a release doc ! [19:56:25] kostajh: and I will definitely rebase/reuse/+2 your change :] [20:00:05] Project mwcore-phpunit-coverage-master build #224: 04FAILURE in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/224/ [20:01:05] :\ [20:01:29] (03PS1) 10Hashar: Releasing documentation [integration/quibble] - 10https://gerrit.wikimedia.org/r/541612 [20:02:13] (03CR) 10Hashar: [C: 03+2] "Going to use exactly that to cut 0.0.36" [integration/quibble] - 10https://gerrit.wikimedia.org/r/541612 (owner: 10Hashar) [20:06:44] (03Merged) 10jenkins-bot: Releasing documentation [integration/quibble] - 10https://gerrit.wikimedia.org/r/541612 (owner: 10Hashar) [20:09:33] hashar: Nice. [20:10:54] (03PS1) 10Hashar: Release Quibble 0.0.36 [integration/quibble] - 10https://gerrit.wikimedia.org/r/541615 [20:10:56] (03PS1) 10Hashar: changelog: begin new version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/541616 [20:10:56] kostajh: James_F ^^^ :] [20:11:32] (03CR) 10Jforrester: [C: 03+2] Release Quibble 0.0.36 [integration/quibble] - 10https://gerrit.wikimedia.org/r/541615 (owner: 10Hashar) [20:12:00] RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 30.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [20:12:25] (03Merged) 10jenkins-bot: Release Quibble 0.0.36 [integration/quibble] - 10https://gerrit.wikimedia.org/r/541615 (owner: 10Hashar) [20:14:27] 10Gerrit, 10Release-Engineering-Team, 10serviceops: Set gerrit1001 master switch date - https://phabricator.wikimedia.org/T234866 (10Dzahn) [20:19:17] !log Tag Quibble 0.0.36 @ 4b46156 # T181942 T190829 T199939 T230340 T233140 T233143 [20:19:28] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:19:29] T230340: Set up CI for mediawiki/tools/api-testing - https://phabricator.wikimedia.org/T230340 [20:19:29] T181942: Run composer --version in CI jobs - https://phabricator.wikimedia.org/T181942 [20:19:29] T190829: Test WikiTextEditor class with browser tests. - https://phabricator.wikimedia.org/T190829 [20:19:30] T233140: Quibble should not rely on dynamically detecting the value of $wgServer - https://phabricator.wikimedia.org/T233140 [20:19:30] T199939: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 [20:19:30] T233143: Quibble should fatal out on clone/fetch failure"ERROR:zuul.Repo:Unable to initialize repo for npm-test.git" - https://phabricator.wikimedia.org/T233143 [20:20:16] (03PS1) 10Hashar: releasing: document !log for SAL and poking tasks [integration/quibble] - 10https://gerrit.wikimedia.org/r/541617 [20:25:30] (03PS5) 10Hashar: docker: bump quibble to 0.0.36 [integration/config] - 10https://gerrit.wikimedia.org/r/541354 (owner: 10Kosta Harlan) [20:26:29] (03CR) 10Hashar: [C: 03+2] "Great thank you." [integration/config] - 10https://gerrit.wikimedia.org/r/541354 (owner: 10Kosta Harlan) [20:28:13] (03Merged) 10jenkins-bot: docker: bump quibble to 0.0.36 [integration/config] - 10https://gerrit.wikimedia.org/r/541354 (owner: 10Kosta Harlan) [20:30:51] (03CR) 10Hashar: [C: 03+2] changelog: begin new version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/541616 (owner: 10Hashar) [20:31:50] (03Merged) 10jenkins-bot: changelog: begin new version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/541616 (owner: 10Hashar) [20:32:55] 10 dollars it fails to build at least one container [20:33:02] :-( [20:33:05] But yes. [20:48:01] James_F: if you happen to have idle cycles for some english proof check https://etherpad.wikimedia.org/p/quibble-0.0.36 :D [20:48:11] that is for wikitech-l / QA lists [20:49:28] hashar: Can you pick a more readable colour? :-) [20:49:58] Thanks. [20:50:06] light orange ;] [20:53:23] James_F: you are absolutely amazing [20:53:41] Do you want to say the SecretKey thing, given CPT were blocked on it? [20:53:52] eek [20:53:53] good point [20:56:34] How's that? [20:57:36] looks great [20:57:39] just rephrased a part [20:57:44] Yeah. Go for it. [20:57:55] the devil was how to override settings set by install.php [20:57:59] Yeah. [20:58:08] and awight has found a very nice way to handle that [20:58:14] just rename LocalSettings.php to foobar.php [20:58:29] and then have Quibble injet its own LocalSettings.php which does whatever and include foobar.php [20:58:32] then does more settings [20:58:35] that is great [20:58:37] Very sneaky. :-) [20:59:01] kudos to who ever wrote that long word in wgSecretKey :P [20:59:33] ok copy pasting [21:00:57] and all images managed to build [21:01:44] Success! [21:05:14] docker run -v /home/hashar/projects:/srv/git:ro docker-registry.wikimedia.org/releng/quibble-stretch-php72:0.0.36 [21:05:18] testing out :] [21:05:28] and I guess we can then gradually roll it to CI jobs [21:05:32] will do a few tomorrow ;] [21:07:15] 10Continuous-Integration-Config, 10Quibble: Run composer --version in CI jobs - https://phabricator.wikimedia.org/T181942 (10hashar) 05Open→03Resolved The feature has been implemented by @awight and is available in Quibble 0.0.36. [21:14:50] oh aeu :-\ [21:48:04] (03PS1) 10Hashar: docker: upgrade setuptools in Quibble images [integration/config] - 10https://gerrit.wikimedia.org/r/541649 [21:48:06] of course the image is broken bah [21:48:53] (03CR) 10Hashar: [C: 03+2] docker: upgrade setuptools in Quibble images [integration/config] - 10https://gerrit.wikimedia.org/r/541649 (owner: 10Hashar) [21:50:59] (03Merged) 10jenkins-bot: docker: upgrade setuptools in Quibble images [integration/config] - 10https://gerrit.wikimedia.org/r/541649 (owner: 10Hashar) [21:53:26] 10Release-Engineering-Team-TODO (201910), 10MediaWiki-General: Bump PHP support version in composer.json - https://phabricator.wikimedia.org/T234767 (10Jdforrester-WMF) a:03Jdforrester-WMF [21:58:56] * James_F kills off a few long-running postmerge jobs [22:00:38] mwcore-codehealth-master-non-voting takes way too long. :-( [22:08:09] (03PS1) 10Jforrester: layout: Restrict mwcore-codehealth-master-non-voting and mwext-codehealth-master-non-voting to master [integration/config] - 10https://gerrit.wikimedia.org/r/541653 [22:10:10] (03CR) 10Jforrester: [C: 03+2] layout: Restrict mwcore-codehealth-master-non-voting and mwext-codehealth-master-non-voting to master [integration/config] - 10https://gerrit.wikimedia.org/r/541653 (owner: 10Jforrester) [22:12:07] (03Merged) 10jenkins-bot: layout: Restrict mwcore-codehealth-master-non-voting and mwext-codehealth-master-non-voting to master [integration/config] - 10https://gerrit.wikimedia.org/r/541653 (owner: 10Jforrester) [22:13:02] !log Zuul: Actually restrict mwcore-codehealth-master-non-voting and mwext-codehealth-master-non-voting to master [22:13:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:13:15] That's helped shorten postmerge a fair bit. [22:19:14] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Beta-Cluster-reproducible: Beta Cluster cross-wiki login request would be blocked by CSP - https://phabricator.wikimedia.org/T211539 (10Jdforrester-WMF) Helps but doesn't fix. Let's try putting the wikis properly into CSP... [22:26:22] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Beta-Cluster-reproducible, 10Patch-For-Review: Beta Cluster cross-wiki login request would be blocked by CSP - https://phabricator.wikimedia.org/T211539 (10Krinkle) >>! In T211539#5555631, @sbassett wrote: >> Thanks :)... [22:33:01] (03PS1) 10Hashar: Fix up missing local_settings.php [integration/quibble] - 10https://gerrit.wikimedia.org/r/541658 [22:33:25] (03CR) 10Hashar: ":-\" [integration/quibble] - 10https://gerrit.wikimedia.org/r/541658 (owner: 10Hashar) [22:33:46] so Quibble definitely need some kind of test :-\ [22:34:31] anyway [22:34:36] bed bed [22:55:44] (03CR) 10Jforrester: [C: 03+2] Fix up missing local_settings.php [integration/quibble] - 10https://gerrit.wikimedia.org/r/541658 (owner: 10Hashar) [22:56:36] (03Merged) 10jenkins-bot: Fix up missing local_settings.php [integration/quibble] - 10https://gerrit.wikimedia.org/r/541658 (owner: 10Hashar)