[05:05:07] (03PS1) 10MaxSem: Also require return type for setUpBeforeClass() and tearDownAfterClass() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) [05:09:10] (03CR) 10jerkins-bot: [V: 04-1] Also require return type for setUpBeforeClass() and tearDownAfterClass() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [05:12:54] (03PS2) 10MaxSem: Also require return type for setUpBeforeClass() and tearDownAfterClass() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) [10:46:49] (03PS1) 10Thiemo Kreuz (WMDE): Create PHPUnitAssertEquals sniff to find problematic assertEquals() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547721 [10:51:19] (03CR) 10Daimona Eaytoy: "Based on https://phpunit.de/announcements/phpunit-8.html, there are other three methods which now need typehints. IMHO, they should be add" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [11:52:48] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Looks about right to me. We can merge this patch as it is and add the other function names in a later patch, if you like. Or update this o" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [12:28:00] (03CR) 10Awight: [C: 03+2] "Great, and does exactly as advertised on tin! Both flags work locally, and I'm the default to correctly disable color under Jenkins." [integration/quibble] - 10https://gerrit.wikimedia.org/r/545988 (https://phabricator.wikimedia.org/T236222) (owner: 10Krinkle) [12:28:55] (03Merged) 10jenkins-bot: Disable color codes around log level words in CI [integration/quibble] - 10https://gerrit.wikimedia.org/r/545988 (https://phabricator.wikimedia.org/T236222) (owner: 10Krinkle) [13:02:53] (03CR) 10Awight: Add option for using Apache as server (038 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [13:43:48] 10Release-Engineering-Team-TODO (201911), 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10ci-test-error: DifferenceEngineTest and ApiComparePagesTest failures when intl is installed - https://phabricator.wikimedia.org/T237049 (10Anomie) >>! In T237049#5625101, @Jdforrester-WMF wrote: > Presumably $this->eng... [13:51:15] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10CPT Initiatives (API Integration Tests): Expose mediawiki/tools/api-testing doc on doc.wikimedia.org - https://phabricator.wikimedia.org/T236915 (10CCicalese_WMF) [13:56:40] 10Continuous-Integration-Config, 10CPT Initiatives (API Integration Tests), 10Code-Health: Enable API integration tests in CI for MediaWiki core - https://phabricator.wikimedia.org/T236680 (10CCicalese_WMF) [14:00:39] no beta wikidata item additions today unless I start up a job this evening. did a large refactor to the code and now all previous work needs to be retested. [14:17:45] 10Gerrit, 10Developer-Advocacy, 10Gerrit-Privilege-Requests, 10TechCom: Requesting access for SemanticACL extension - https://phabricator.wikimedia.org/T234124 (10MarcoAurelio) Thanks @tstarling for promoting @Tinss and for the clarification re. when to escalate a request to TechCom. Best regards. [14:19:13] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10User-Ladsgroup, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-āˆž): beta testwiki site is broken: "Unknown database 'testwikidatawiki'" - https://phabricator.wikimedia.org/T235970 (10MarcoAurelio) Looks good to me I thin... [15:42:37] James_F: So you did created wmf.4 directly on forrestbot? [15:42:50] *create [15:43:29] I'm not sure why the bot crashed either. The log just mentions that change. I see it's is not included in any branch other than master though [15:45:26] hauskater: On https://gerrit.wikimedia.org/r/admin/projects/mediawiki/extensions/Wikisource,branches [15:45:55] It's crashing on https://gerrit.wikimedia.org/r/plugins/gitiles/labs/tools/forrestbot/+/master/forrestbot.py#46 [15:46:14] James_F: ah, right. Ain't those created by the make-wmf-branch script though? [15:46:56] Hopefully we don't have to do this for every new wmf-branched extension ;) [15:47:00] Yes, but only when it runs. [15:47:48] I imagine that code doesn't normally land just after a repo gets added but before a wmf branch gets cut? [15:48:27] Can't run the bot manually for some reason; will have to wait 12 minutes. [15:48:41] I'm not privy to the details re. branching mediawiki extensions [15:51:26] We do the branches as part of the train. [15:51:31] So, on Tuesday mornings. [15:52:25] I suspected that [15:53:01] The locomotive conductor ( :-) ) runs the script manually then bumps wikiversions.json [15:53:29] Well, it's almost all one script, but yes. [15:54:51] automation ftw :P [15:57:32] back on with wikidata beta item uploads, 4 a minute, about 1k, starting now (these are very minimal items but they do have a label and description in en). to be used for depicts statements on commons beta. [15:57:55] * James_F nods. [15:59:37] testwikidatawiki.beta was fixed today I think [16:00:03] testwiki.beta, sorry [16:00:13] what was broken? [16:01:05] apergos: T235970 [16:01:05] T235970: beta testwiki site is broken: "Unknown database 'testwikidatawiki'" - https://phabricator.wikimedia.org/T235970 [16:01:06] (03CR) 10Jforrester: [C: 03+1] Also require return type for setUpBeforeClass() and tearDownAfterClass() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [16:01:46] ah ha [16:04:25] yuhu, forrestbot running again \o/ [16:08:18] https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/527948/ was not yet parsed apparently [16:15:23] (03PS1) 10Thcipriani: deployments-calendar: add messages + optional train [tools/release] - 10https://gerrit.wikimedia.org/r/547748 [16:19:08] (03CR) 1020after4: [C: 03+1] deployments-calendar: add messages + optional train (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/547748 (owner: 10Thcipriani) [16:21:37] (03PS1) 10Hashar: test zuul pipeline name do not have dots [integration/config] - 10https://gerrit.wikimedia.org/r/547751 [16:21:47] (03PS2) 10Thcipriani: deployments-calendar: add messages + optional train [tools/release] - 10https://gerrit.wikimedia.org/r/547748 [16:23:10] (03CR) 10Jforrester: "I thought you were on holiday? :-)" [integration/config] - 10https://gerrit.wikimedia.org/r/547751 (owner: 10Hashar) [16:23:35] (03CR) 10jerkins-bot: [V: 04-1] test zuul pipeline name do not have dots [integration/config] - 10https://gerrit.wikimedia.org/r/547751 (owner: 10Hashar) [16:23:37] nice cr [16:23:44] * James_F grins. [16:23:59] (03PS2) 10Hashar: Rename Zuul pipeline having a dot [integration/config] - 10https://gerrit.wikimedia.org/r/547751 [16:24:05] I had a good laugh looking at the wikitech db sections patch(es) btw [16:24:14] Iā€¦ aim to please? [16:24:23] what a nasty issue waiting to happen :-) [16:24:34] Yeah, not fun. [16:25:18] we have officially arrived at the "it's complicated" stage of software development and maintenance [16:25:29] I think we were there a decade ago, but yes. [16:26:30] ok ok, *extra complicated [16:27:10] (03CR) 10jerkins-bot: [V: 04-1] Rename Zuul pipeline having a dot [integration/config] - 10https://gerrit.wikimedia.org/r/547751 (owner: 10Hashar) [16:27:12] we really ought to have section lists in one place and config lists in another [16:27:15] problem solved [16:27:31] Well, the my patent-pending magic new config system, we will. [16:27:40] Ish. [16:28:32] heh [16:29:11] (03CR) 10Thcipriani: [C: 03+2] deployments-calendar: add messages + optional train [tools/release] - 10https://gerrit.wikimedia.org/r/547748 (owner: 10Thcipriani) [16:29:59] (03Merged) 10jenkins-bot: deployments-calendar: add messages + optional train [tools/release] - 10https://gerrit.wikimedia.org/r/547748 (owner: 10Thcipriani) [16:31:50] (03PS3) 10Hashar: Rename Zuul pipeline having a dot [integration/config] - 10https://gerrit.wikimedia.org/r/547751 [16:32:46] (03CR) 10Hashar: "> I thought you were on holiday? :-)" [integration/config] - 10https://gerrit.wikimedia.org/r/547751 (owner: 10Hashar) [16:33:22] tfw you click through on a gerrit patchset just to read the conversation :-D [16:36:29] (03CR) 10Jforrester: [C: 03+2] Rename Zuul pipeline having a dot [integration/config] - 10https://gerrit.wikimedia.org/r/547751 (owner: 10Hashar) [16:38:21] (03Merged) 10jenkins-bot: Rename Zuul pipeline having a dot [integration/config] - 10https://gerrit.wikimedia.org/r/547751 (owner: 10Hashar) [16:39:01] !log Zuul: Reloading with pipelines with _s not .s [16:39:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:39:42] (03CR) 10Jforrester: "Deployed, all looks good." [integration/config] - 10https://gerrit.wikimedia.org/r/547751 (owner: 10Hashar) [16:40:04] !log ladsgroup@deployment-deploy01:~$ mwscript sql.php --wiki=wikidatawiki /srv/mediawiki-staging/php-master/extensions/Wikibase/repo/sql/increase_wbxl_language.sql (T237102) [16:40:07] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:40:07] T237102: Increase the size of wbt_text_in_lang.wbxl_language - https://phabricator.wikimedia.org/T237102 [16:59:59] 10Release-Engineering-Team-TODO (201911), 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10ci-test-error: DifferenceEngineTest and ApiComparePagesTest failures when intl is installed - https://phabricator.wikimedia.org/T237049 (10Jdforrester-WMF) Aha, right, well, that makes sense because of 34c8b6e0 for T23... [17:03:24] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201910), 10Quibble: Install wikidiff2 into mediawiki-quibble-api-testing-vendor-mysql-php72-docker - https://phabricator.wikimedia.org/T236333 (10Jdforrester-WMF) Unfortunately this... [17:12:29] 10Release-Engineering-Team-TODO (201911), 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10ci-test-error: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed - https://phabricator.wikimedia.org/T237049 (10Jdforrester-WMF) [17:12:37] 10Release-Engineering-Team-TODO (201911), 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10wikidiff2, 10ci-test-error: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed - https://phabricator.wikimedia.org/T237049 (10Jdforrester-WMF) [18:16:14] @seen andre__ [18:26:05] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations: Reimage cobalt and gerrit2001 as buster - https://phabricator.wikimedia.org/T176774 (10Dzahn) [18:26:08] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations, and 2 others: Gerrit Hardware Upgrade (+ upgrade from jessie to stretch or buster) - https://phabricator.wikimedia.org/T222391 (10Dzahn) [19:16:02] 10Gerrit, 10Release-Engineering-Team, 10Operations, 10Wikimedia Design Style Guide: Automatic pickup of Gerrit clone master doesn't happen due to missing git-lfs ā€“ new deployment env - https://phabricator.wikimedia.org/T235677 (10Volker_E) [19:36:45] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations: Reimage cobalt and gerrit2001 as buster - https://phabricator.wikimedia.org/T176774 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqiad.wmnet for hosts: ` gerrit20... [20:01:42] hmm, 31b40dabfcbeb82dcd994e8736fe97b7879ac259 is showing as missing, dunno what repo that belongs to [20:02:07] mediawiki/core and operations/software showing as having missing objects [20:09:50] https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/11137/ [20:10:00] missing a object causing 500 [20:10:10] (if you use the patchset selector) [20:16:32] cc thcipriani ^ [20:20:00] wow [20:20:00] https://gerrit.wikimedia.org/r/#/c/operations/software/+/8481/ [20:20:04] that's an old change :P [20:22:15] it's not the patchset itself, it's something to do with change details [20:22:25] https://gerrit.wikimedia.org/r/changes/mediawiki%2Fcore~11137/detail?O=116414 specifically [20:22:52] yup [20:23:04] according to javamelody it's missing an object thcipriani [20:23:13] it's missing an unknown [20:23:45] yeh [20:31:55] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations: Reimage cobalt and gerrit2001 as buster - https://phabricator.wikimedia.org/T176774 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['gerrit2001.wikimedia.org'] ` and were **ALL** successf... [20:38:45] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10Volker_E) Related T232494 [20:44:47] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10Volker_E) It would be very good to get clarification if Git LFS is going to be supported long-term or n... [20:49:43] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10mmodell) @volker_e: I agree, some clarity would be good. Technically: * scap nominally supports git-l... [21:01:29] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10mmodell) I'd love to hear what @akosiaris and @thcipriani think about it. Also I want to voice my huge... [21:01:39] paladox: guess what.. wmf-auto-reimage worked on gerrit2001.. without even removing the role class [21:01:46] \o/ [21:01:47] that means it all works on... first puppet run [21:01:51] rare enough :) [21:01:56] we'll need to copy the mysql drive :P [21:02:02] *driver from gerrit1001 [21:02:12] good reminder! [21:02:27] * mutante tries to remember the path [21:02:37] let me initiate a force replication for the git repos if thats ok with you mutante [21:02:45] (e.g gerrit1001 to replicate to gerrit2001) [21:03:08] paladox: yes, i was going to ask about it [21:04:08] ok! [21:04:16] thanks [21:05:04] scp's /usr/share/java/mysql-connector-java.jar [21:05:53] thanks mutante ! [21:06:41] !log ssh -p 29418 paladox@gerrit.wikimedia.org replication start --url gerrit2001.wikimedia.org --all [21:06:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:07:48] mutante i bet the ssh key changed? [21:08:06] i see: [21:08:07] 592632fb 21:08:20.711 21:07:20.706 (retry 1) [415b7529] push gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/integration/config.git [21:08:14] retry 1 [21:08:16] paladox: ah yea.. need to update in puppet repo [21:08:31] puppetized host keys [21:08:37] thanks! [21:08:56] we dont enable the gerrit ssh server on the replica, btw [21:09:18] yup [21:17:12] 10Project-Admins, 10Wiktionary-fr: Replace tracking bug T76447 by new project tag "Wiktionary-fr" - https://phabricator.wikimedia.org/T101948 (10Aklapper) 05Openā†’03Resolved a:03Aklapper Requested public project #wiktionary-fr has been created: https://phabricator.wikimedia.org/project/view/4363/ [Existi... [21:17:15] 10Project-Admins, 10Epic: Replace all "tracking" tasks with tags/projects (if unbounded), relabel them to outcome tasks (if bounded), or kill them entirely (if pointless) - https://phabricator.wikimedia.org/T192655 (10Aklapper) [21:18:56] 10Beta-Cluster-Infrastructure, 10Page Content Service, 10Product-Infrastructure-Team-Backlog: Beta Cluster deployment failed: sign_and_send_pubkey: signing failed: agent refused operation - https://phabricator.wikimedia.org/T236103 (10Krenair) 05Openā†’03Resolved [21:23:16] mutante has puppet ran? :) [21:30:05] paladox: now [21:30:09] thanks [21:30:22] i went and got food [21:30:33] ok! [21:31:07] queues going down mutante! [21:31:18] should start seeing repos at /srv/gerrit/git/ [21:31:21] on gerrit2001 [21:32:20] paladox: [gerrit2001:~] $ watch du -hs /srv/gerrit/git/ [21:32:23] growing :) [21:32:27] \o/ [21:35:15] bulk add items is complete, that's it for the day [21:39:14] paladox: not sure we can do much for people cloning from gerrit-replica ..besides being quick as possible [21:39:21] between the time of reimage and first clone [21:39:21] yup [21:40:49] we can start gerrit up as soon as the repos have cloned. [21:41:06] *i think* [21:41:26] not sure if we want to do a init (which shouldn't be able to save anything in the repos/db) [21:42:15] paladox: it's growing but it's kind of slow [21:42:19] only 57MB so far [21:42:21] yup [21:42:27] i see the queue has stopped some how [21:42:32] not going down now... [21:42:33] yea, that's why we rsynced for the migration of the prod [21:42:54] paladox: hm ..:/ [21:45:01] Yeh definitely stopped now [21:45:11] mutante anything in the replication.log on gerrit1001? [21:48:11] paladox: it is still growing.. just slow [21:48:14] 84M [21:48:19] oh [21:48:23] but 30MB in 6 minutes isnt much [21:48:24] i guess it's on a large repo [21:48:26] if you have GBs [21:48:57] fd4d00d2 21:24:22.574 (retry 2) [d04431ac] push gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/wikimedia/fundraising/centralnotice_changes_monitor.git [21:49:10] is what it is on [21:49:33] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10ChangeProp, 10Operations, and 4 others: Migrate cpjobqueue to kubernetes - https://phabricator.wikimedia.org/T220399 (10WDoranWMF) [21:49:42] a lot of "Missing repository createad" in the log btw.. as expected [21:49:54] yup [21:51:45] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10Volker_E) [21:57:57] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10thcipriani) >>! In T235013#5627732, @mmodell wrote: > @volker_e: I agree, some clarity would be good. >... [22:08:46] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10Volker_E) Same here, both @mmodell and @Dzahn have provided valuable input and hands-on help extensivel... [22:09:22] (03PS3) 10MaxSem: Also require return type for setUpBeforeClass() and tearDownAfterClass() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) [22:14:11] (03CR) 10Jforrester: [C: 03+2] Also require return type for setUpBeforeClass() and tearDownAfterClass() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [22:14:39] (03Merged) 10jenkins-bot: Also require return type for setUpBeforeClass() and tearDownAfterClass() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [22:20:24] (03CR) 10Jforrester: "Hmm, on reflection we should probably have added unit tests for assertPreConditions etc. whines. :-)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/547706 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [22:46:40] (03PS1) 10Umherirrender: [CollaborationKit] Run phan job [integration/config] - 10https://gerrit.wikimedia.org/r/547814 [23:04:54] (03CR) 10Jforrester: [C: 03+2] [CollaborationKit] Run phan job [integration/config] - 10https://gerrit.wikimedia.org/r/547814 (owner: 10Umherirrender) [23:06:48] (03Merged) 10jenkins-bot: [CollaborationKit] Run phan job [integration/config] - 10https://gerrit.wikimedia.org/r/547814 (owner: 10Umherirrender) [23:23:02] 10Release-Engineering-Team, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10User-Ladsgroup: Use `git lfs` for large binary files of Design Style Guide - https://phabricator.wikimedia.org/T235013 (10mmodell) Some of the confusion is my fault, I've been saying that git-lfs works, and every indication I... [23:23:22] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, 10Google-Code-in-2019, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14): Stop using jsonlint (as it's abandonware) and instead use eslint-plugin-json fo... - https://phabricator.wikimedia.org/T220036