[00:16:38] restarting Gerrit to re-enable jgit gc [00:17:16] paladox: done ^ [00:17:25] mutante thanks! [00:18:48] (03PS3) 10Zoranzoki21: Disable running selenium tests for AnonPrivacy extension [integration/config] - 10https://gerrit.wikimedia.org/r/548542 (https://phabricator.wikimedia.org/T237335) [03:29:54] starting batch 2 of depicts statements and going back to sleep [06:20:09] about hlfway through with this batch of depicts [08:39:06] ~300 left in this batch [08:54:52] (03CR) 10Mobrovac: [C: 03+1] Update RESTBase link [integration/docroot] - 10https://gerrit.wikimedia.org/r/547846 (https://phabricator.wikimedia.org/T227766) (owner: 10Ammarpad) [10:35:08] morning batch of depicts statements is complete. I'll start a new batch later today [11:37:18] 3rd and final batch of depicts statements just started [11:38:19] 10Release-Engineering-Team-TODO (201911), 10User-zeljkofilipin: Close QA mailing list - https://phabricator.wikimedia.org/T237383 (10zeljkofilipin) [11:38:34] 10Release-Engineering-Team-TODO (201911), 10User-zeljkofilipin: Close QA mailing list - https://phabricator.wikimedia.org/T237383 (10zeljkofilipin) p:05Triage→03Normal [11:41:08] 10Release-Engineering-Team-TODO (201911), 10Operations, 10Wikimedia-Mailing-lists, 10User-zeljkofilipin: Close QA mailing list - https://phabricator.wikimedia.org/T237383 (10zeljkofilipin) [11:57:27] 10Release-Engineering-Team-TODO (201911), 10Operations, 10Wikimedia-Mailing-lists, 10User-zeljkofilipin: Close QA mailing list - https://phabricator.wikimedia.org/T237383 (10zeljkofilipin) [11:58:37] 10Release-Engineering-Team-TODO (201911), 10Operations, 10Wikimedia-Mailing-lists, 10User-zeljkofilipin: Close QA mailing list - https://phabricator.wikimedia.org/T237383 (10zeljkofilipin) a:05zeljkofilipin→03None [12:16:09] !log lucaswerkmeister-wmde@deployment-deploy01:~$ mwscript createAndPromote.php dewiki 'Lucas Werkmeister (WMDE)' --force --sysop # make myself admin for T235152 [12:16:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:16:12] T235152: don't show bridge edit pens when editor can't edit the article - https://phabricator.wikimedia.org/T235152 [13:05:46] 10Continuous-Integration-Config, 10Patch-For-Review, 10User-Zoranzoki21: quibble-vendor-mysql-php72-docker fails for AnonPrivacy because of selenium timeouts - https://phabricator.wikimedia.org/T237335 (10hashar) [13:08:26] 10Continuous-Integration-Config, 10Patch-For-Review, 10User-Zoranzoki21: quibble-vendor-mysql-php72-docker fails for AnonPrivacy because of selenium timeouts - https://phabricator.wikimedia.org/T237335 (10hashar) I have marked the build to be kept for ever https://integration.wikimedia.org/ci/job/quibble-ven... [13:09:20] (03CR) 10Hashar: [C: 04-1] "It is an issue in the extension code or in MediaWiki core itself: Special:RecentChanges is a blank page which should not happen. The Selen" [integration/config] - 10https://gerrit.wikimedia.org/r/548542 (https://phabricator.wikimedia.org/T237335) (owner: 10Zoranzoki21) [13:19:55] (03PS3) 10Hashar: Tox env for Fabric + doc [integration/config] - 10https://gerrit.wikimedia.org/r/546513 (https://phabricator.wikimedia.org/T236689) [13:20:47] (03CR) 10Hashar: "To be fair, I haven't tried it. tox strips the environment variables before running the commands. PS2 white list / passes SSH_AUTH_SOCK" [integration/config] - 10https://gerrit.wikimedia.org/r/546513 (https://phabricator.wikimedia.org/T236689) (owner: 10Hashar) [13:36:41] 10Project-Admins: Create user board for Majavah - https://phabricator.wikimedia.org/T237402 (10Majavah) [15:05:09] (03PS1) 10Jforrester: layout: Add InterwikiExtracts extension [integration/config] - 10https://gerrit.wikimedia.org/r/548760 [15:11:01] (03CR) 10Jforrester: [C: 03+2] layout: Add InterwikiExtracts extension [integration/config] - 10https://gerrit.wikimedia.org/r/548760 (owner: 10Jforrester) [15:12:28] (03Merged) 10jenkins-bot: layout: Add InterwikiExtracts extension [integration/config] - 10https://gerrit.wikimedia.org/r/548760 (owner: 10Jforrester) [15:14:07] !log Zuul: Adding InterwikiExtracts extension [15:14:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:16:19] 10Release-Engineering-Team-TODO (201911), 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10wikidiff2, and 3 others: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed - https://phabricator.wikimedia.org/T237049 (10Anomie) [15:57:23] (03PS1) 10Xqt: Edit Project Config [pywikibot/i18n] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/548770 [15:57:31] is there any process / rules for stewards on the beta cluster? [15:57:39] or can I createAndPromote.php myself and it’s fine? [15:57:55] about 200 depicts statements left for today's batch [15:58:36] (03PS1) 10Xqt: Edit Project Config [pywikibot/core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/548771 [15:59:45] (03Abandoned) 10Xqt: Edit Project Config [pywikibot/core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/548771 (owner: 10Xqt) [16:00:00] (03Abandoned) 10Xqt: Edit Project Config [pywikibot/i18n] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/548770 (owner: 10Xqt) [16:15:28] (03CR) 10Xqt: [C: 03+2] Give access to l10n-bot-watcher group [pywikibot/i18n] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/548295 (https://phabricator.wikimedia.org/T237263) (owner: 10MarcoAurelio) [16:15:32] 10Gerrit, 10Gerrit-Privilege-Requests, 10Pywikibot, 10Patch-For-Review, 10User-MarcoAurelio: Give access to l10n-bot-watcher group - https://phabricator.wikimedia.org/T237263 (10Xqt) 05Open→03Resolved [16:16:29] !log lucaswerkmeister-wmde@deployment-deploy01:~$ mwscript createAndPromote.php deploymentwiki 'Lucas Werkmeister (WMDE)' --force --custom-groups=steward # make myself steward to remove an erroneous global lock [16:16:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:20:44] okay that didn’t really work [16:23:30] 10Gerrit, 10Gerrit-Privilege-Requests, 10Pywikibot, 10User-MarcoAurelio: Give access to l10n-bot-watcher group - https://phabricator.wikimedia.org/T237263 (10MarcoAurelio) [16:26:32] 10Gerrit, 10Gerrit-Privilege-Requests, 10Pywikibot, 10User-MarcoAurelio: Give access to l10n-bot-watcher group - https://phabricator.wikimedia.org/T237263 (10MarcoAurelio) Looks good: https://gerrit.wikimedia.org/r/#/admin/projects/pywikibot/i18n,access :) Thanks for merging @Xqt [17:08:19] batch complete, that winds up today's bulk work [17:11:25] gerrit feels slow, I assume it’s the branch cut? [17:11:50] hm, deployment calendar says that only starts 3 hours from now… [17:12:15] hmm [17:12:31] fast for me [17:12:36] https://gerrit.wikimedia.org/r/monitoring shows no issues either [17:13:21] perhaps my laptop is just being slow in general [17:38:38] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Desktop Improvements, and 2 others: Automatically display production content on Beta Cluster wikis on desktop (via an API request) - https://phabricator.wikimedia.org/T207508 (10Jdlrobson) [17:47:52] PROBLEM - Parsoid on deployment-parsoid09 is CRITICAL: connect to address 172.16.5.63 and port 8000: Connection refused [17:47:52] PROBLEM - Parsoid on deployment-mediawiki-parsoid10 is CRITICAL: connect to address 172.16.0.141 and port 8000: Connection refused [18:02:31] (03Abandoned) 10Sophivorus: Add branching for Extension:WikipediaExtracts [tools/release] - 10https://gerrit.wikimedia.org/r/485373 (https://phabricator.wikimedia.org/T149765) (owner: 10Sophivorus) [18:03:10] (03PS9) 1020after4: u# This is a combination of 2 commits. [tools/release] - 10https://gerrit.wikimedia.org/r/543248 [18:10:58] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: Rsync error causing jenkins job "publish-to-doc1001" to fail - https://phabricator.wikimedia.org/T237439 (10Reedy) [18:17:26] twentyafterfour: Did you intend that commit summary? [18:18:04] James_F: uhm, not the comment part ;) [18:18:19] Yeah, I guessed, but didn't want to fix it for you and commit-conflict. ;-) [18:18:29] James_F: fixed, thanks! [18:18:46] (03PS10) 1020after4: Fix up branch.py so that it's suitable for wmf/ production branches [tools/release] - 10https://gerrit.wikimedia.org/r/543248 [18:20:28] (03CR) 10Jforrester: [C: 03+1] "Looks about right." [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [18:26:48] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: coverage publish job for "mediawiki/extensions/examples" fails because src/coverage does not exist - https://phabricator.wikimedia.org/T237439 (10Krinkle) [18:29:06] 10Continuous-Integration-Config, 10MediaWiki-extensions-Examples: coverage publish job for "mediawiki/extensions/examples" fails because src/coverage does not exist - https://phabricator.wikimedia.org/T237439 (10Krinkle) This seems to be working as intended from the CI infra perspective. In so far that the cov... [18:29:09] 10Continuous-Integration-Config, 10MediaWiki-extensions-Examples: coverage publish job for "mediawiki/extensions/examples" fails because src/coverage does not exist - https://phabricator.wikimedia.org/T237439 (10Krinkle) p:05Triage→03Low [18:31:19] (03PS1) 10Krinkle: Remove obsolete postmerge job for mwext-examples.git [integration/config] - 10https://gerrit.wikimedia.org/r/548827 (https://phabricator.wikimedia.org/T237439) [18:31:31] 10Continuous-Integration-Config, 10MediaWiki-extensions-Examples, 10Performance-Team, 10Patch-For-Review: coverage publish job for "mediawiki/extensions/examples" fails because src/coverage does not exist - https://phabricator.wikimedia.org/T237439 (10Krinkle) a:03Krinkle [18:31:44] (03CR) 10Krinkle: [C: 03+2] Remove obsolete postmerge job for mwext-examples.git [integration/config] - 10https://gerrit.wikimedia.org/r/548827 (https://phabricator.wikimedia.org/T237439) (owner: 10Krinkle) [18:33:34] (03Merged) 10jenkins-bot: Remove obsolete postmerge job for mwext-examples.git [integration/config] - 10https://gerrit.wikimedia.org/r/548827 (https://phabricator.wikimedia.org/T237439) (owner: 10Krinkle) [18:39:50] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/548827 [18:39:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:40:09] 10Continuous-Integration-Config, 10MediaWiki-extensions-Examples, 10Performance-Team, 10Patch-For-Review: coverage publish job for "mediawiki/extensions/examples" fails because src/coverage does not exist - https://phabricator.wikimedia.org/T237439 (10Krinkle) 05Open→03Resolved [18:40:28] !log branching 1.35.0-wmf.5 [18:40:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:41:41] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201910), 10MediaWiki-Core-Testing, 10Performance-Team, 10User-zeljkofilipin: Release new version of wdio-mediawiki - https://phabricator.wikimedia.org/T236927 (10Krinkle) [18:57:09] (03CR) 10Jforrester: [C: 03+2] Tox env for Fabric + doc [integration/config] - 10https://gerrit.wikimedia.org/r/546513 (https://phabricator.wikimedia.org/T236689) (owner: 10Hashar) [18:59:13] (03Merged) 10jenkins-bot: Tox env for Fabric + doc [integration/config] - 10https://gerrit.wikimedia.org/r/546513 (https://phabricator.wikimedia.org/T236689) (owner: 10Hashar) [19:06:39] 10Project-Admins, 10Research: create tags for Research - https://phabricator.wikimedia.org/T228350 (10leila) >>! In T228350#5611588, @Aklapper wrote: > Alright: > * I created `#foundational` as a subproject - @leila: Please add a description to `#foundational` at https://phabricator.wikimedia.org/project/edit/... [19:16:15] (03PS1) 10Reedy: Edit Project Config [wikimedia/security/tooling] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/548844 [19:16:22] (03Abandoned) 10Reedy: Edit Project Config [wikimedia/security/tooling] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/548844 (owner: 10Reedy) [19:18:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Upgrade integration/config to use Fabric 2.x / python3 - https://phabricator.wikimedia.org/T236689 (10Jdforrester-WMF) So, is the next step to explore Firebase? [19:26:55] 10Release-Engineering-Team-TODO, 10GitHub-Mirrors: Disable "Automated security fixes" on Wikimedia Org - https://phabricator.wikimedia.org/T237337 (10Jdforrester-WMF) [19:32:17] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Security-Team: wikimedia/security gerrit requests - https://phabricator.wikimedia.org/T237449 (10sbassett) [19:33:35] (03Abandoned) 10Jforrester: Disable running selenium tests for AnonPrivacy extension [integration/config] - 10https://gerrit.wikimedia.org/r/548542 (https://phabricator.wikimedia.org/T237335) (owner: 10Zoranzoki21) [19:35:10] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Security-Team: wikimedia/security gerrit requests - https://phabricator.wikimedia.org/T237449 (10Paladox) Hi, 1. Is not possible, it's either you can create repos for all namespaces or you carn't :) 2. Needs an admin. 3. answered in 1 :) [19:38:37] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201911): Evaluate Airflow's suitability for CI - https://phabricator.wikimedia.org/T237450 (10thcipriani) [19:39:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201911): Evaluate Airflow's suitability for CI - https://phabricator.wikimedia.org/T237450 (10thcipriani) p:05Triage→03Normal a:03LarsWirzenius Assigning to @LarsWirzenius per discussion. [19:44:08] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201911): Evaluate Airflow's suitability for CI - https://phabricator.wikimedia.org/T237450 (10Ottomata) 'currently in use' as of last week in trial mode :) [19:44:16] so gate-and-submit-wmf is running different jobs from gate-and-submit? is this intentional? [19:44:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201911): Evaluate Airflow's suitability for CI - https://phabricator.wikimedia.org/T237450 (10LarsWirzenius) Argo, Airflow, and CI @thcipriani , @dduvall , and I met and discussed using Apache Airflow for the new CI system. We decided a... [19:50:36] twentyafterfour: I'd assume so; i.e., we don't care about any tests for versions of php not in production for -wmf use specifically. I remember this being talked about, but I didn't realize it was a thing [19:51:24] yeah the -wmf version is running less tests. [19:51:25] ^ James_F probably has more intimate details about specific differences in the -wmf pipeline and/or devised the who thing :) [19:51:32] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201911): Evaluate Airflow's suitability for CI - https://phabricator.wikimedia.org/T237450 (10Ottomata) > We'd rather use something like Argo, which is itself a CI system already, not just a building block For accuracy, IIUC [[ https://... [19:51:34] *whole [19:51:38] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201910), 10MediaWiki-Core-Testing, 10Performance-Team, and 2 others: Release new version of wdio-mediawiki - https://phabricator.wikimedia.org/T236927 (10Krinkle) a:05Krinkle→03zeljkofilipin [19:52:29] so I ran the branch cut through code review this time, even though I still +2 self-merged it, at least the branch cut gets CI jobs run on it this way [19:53:25] that's both good and bad, good for thorough testing, bad for the extra load on CI pipeline [19:53:39] either way it finished just in time :) [19:54:06] Hey twentyafterfour was the train cut later today? [19:54:20] it looks like a few changes that were meant to be merged post-train cut are in origin/wmf/1.35.0-wmf.5 [19:54:29] Jdlrobson: it just merged [19:54:44] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201911): Evaluate Airflow's suitability for CI - https://phabricator.wikimedia.org/T237450 (10LarsWirzenius) Aye, Argo is what we call it, though it's actually many components. We also have no opinion on whether Airflow is suitable for... [19:54:49] ok. I'm going to need to get some patches removed from the train then :( What's the easiest way to do that? [19:54:51] I ran the branch cut around 11:00 pacific [19:55:25] ok yeh i think we merged assuming it was cut last night :( [19:55:32] Jdlrobson: I suppose the easiest is to revert the patches on the wmf/1.35.0-wmf.5 branch [19:55:40] twentyafterfour: ok ill do that now [19:55:48] unless it's a lot of complex patches then maybe I could re-run the branch cut from a specific point [19:56:33] i can squash - it's 3 i think [19:57:11] Jdlrobson: we will be switching the branch cut over to full automation very soon so you'll be able to depend on it happening at a specific time [19:58:10] not sure what time that will be yet but it'll at least be punctual if we have jenkin doing it [19:58:20] ill have the patches ready in a bit [19:58:24] 10Project-Admins: Create user board for Majavah - https://phabricator.wikimedia.org/T237402 (10MGChecker) a:03MGChecker [19:58:43] Jdlrobson: ok no prob, I'll wait for your patches before I continue the train [19:59:48] 10Project-Admins: Create user board for Majavah - https://phabricator.wikimedia.org/T237402 (10MGChecker) 05Open→03Resolved Requested public project #User-Majavah has been created: https://phabricator.wikimedia.org/project/view/4370/ Please encourage interested people to visit the project and to join the pr... [19:59:50] thcipriani, twentyafterfour: Hey. Ye, that's plannned. [20:00:07] E.g. we don't care about Postgres testing for production because we don't run it. [20:00:08] Etc. [20:01:51] okay twentyafterfour https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/548865 and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/548866 should restore us to a shippable state [20:01:55] i'm just waiting on jenkins to confirm [20:04:13] woah did you say 'branch cut' and 'full automation' in the same sentence? because that's awesome [20:04:40] apergos: Inorite? [20:04:54] 😍😍 [20:05:28] one patch, one edit, and one issue at a time, we get better [20:07:40] apergos: yep, full auto [20:08:13] been working on it with thcipriani along with some help from marxarelli and brennen for a while now [20:09:36] pretty interested to see how it's scripted up once it goes live [20:09:39] anyways, kudos! [20:10:35] apergos: https://gerrit.wikimedia.org/r/c/mediawiki/tools/release/+/543248 is the branching code but I think we will be triggering it from the releases jenkins instance [20:10:50] so it will just be a timed jenkins job that runs at a specific time each week [20:11:14] +1 automation will be awesome and free you up to do all sorts of exciting things :) [20:11:42] adding that to tomorrow's reading :-) [20:12:44] And, more importantly, having it at a reliable time will help everyone else schedule their must-merge-after-the-branch-cut patches ;) [20:13:27] yep, or their 'omg must get this merged before the branch cut' rushes! [20:13:42] (I'm typically in the former category :-D) [20:14:22] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Security-Team: wikimedia/security gerrit requests - https://phabricator.wikimedia.org/T237449 (10Reedy) For number one, it's probably not unreasonable just to add them to Gerrit Managers [20:14:38] (03PS11) 1020after4: u# This is a combination of 2 commits. [tools/release] - 10https://gerrit.wikimedia.org/r/543248 [20:15:01] twentyafterfour: seems i have to wrestle jenkins a little to get this train unblocked.. [20:15:09] (03CR) 10jerkins-bot: [V: 04-1] u# This is a combination of 2 commits. [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [20:15:18] (03PS12) 1020after4: Fix up branch.py so that it's suitable for wmf/ production branches [tools/release] - 10https://gerrit.wikimedia.org/r/543248 [20:15:48] (03CR) 10jerkins-bot: [V: 04-1] Fix up branch.py so that it's suitable for wmf/ production branches [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [20:16:35] (03CR) 10Jforrester: Fix up branch.py so that it's suitable for wmf/ production branches (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [20:17:20] 10Gerrit, 10Release-Engineering-Team (Development services): Update JavaMelody on Gerrit to 1.80.0 - https://phabricator.wikimedia.org/T232678 (10hashar) [20:17:33] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Update JavaMelody on Gerrit to 1.80.0 - https://phabricator.wikimedia.org/T232678 (10hashar) [20:18:35] 10Beta-Cluster-Infrastructure, 10Growth-Team, 10User-Ladsgroup: Set up beta cswiki - https://phabricator.wikimedia.org/T237077 (10Tgr) 05Resolved→03Open Seems like RESTBase needs to be configured: https://cs.wikipedia.beta.wmflabs.org/api/rest_v1/ is a 404. [20:19:35] twentyafterfour: jenkins is failing because the 2 patches depend on each other [20:19:38] (03PS13) 1020after4: Fix up branch.py so that it's suitable for wmf/ production branches [tools/release] - 10https://gerrit.wikimedia.org/r/543248 [20:19:59] Jdlrobson: Joy. [20:20:36] Jdlrobson: no problem [20:21:05] oh gee [20:21:06] can we force merge https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/548866/ ? [20:21:19] I was just gonna say the same thing ;) [20:21:29] provided the tests pass for https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/548865/ i think it's okay [20:21:33] James_F: any reason we shouldn't, other than that's always a bad idea? [20:21:41] as the tests for Minerva are what's failing in the MobileFrontend patch :) [20:22:52] (03CR) 10Jforrester: Fix up branch.py so that it's suitable for wmf/ production branches (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [20:23:25] twentyafterfour: Nope, force-merge away. If it breaks the world you can shout at Jdlrobson right here. ;-) [20:24:14] (03CR) 1020after4: Fix up branch.py so that it's suitable for wmf/ production branches (032 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [20:25:26] Jdlrobson: test succeeded on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/548865/ [20:25:41] (03CR) 10Jforrester: Fix up branch.py so that it's suitable for wmf/ production branches (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [20:26:25] Move away. [20:26:57] Jdlrobson: so we just need to force v+2 on the other patch then? [20:27:13] Yes. [20:27:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Upgrade integration/config to use Fabric 2.x / python3 - https://phabricator.wikimedia.org/T236689 (10hashar) I thought about using spicerack written by volans but that is a different... [20:28:10] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Upgrade integration/config to use Fabric 2.x / python3 - https://phabricator.wikimedia.org/T236689 (10Jdforrester-WMF) That could work. [20:29:48] thanks twentyafterfour and sorry for the trouble.You'll need to force merge the MobileFrontend one [20:29:55] the Minerva one will pass happily [20:30:02] Jdlrobson: ok no problem [20:46:01] 10Release-Engineering-Team-TODO, 10GitHub-Mirrors: Disable "Automated security fixes" on Wikimedia Org - https://phabricator.wikimedia.org/T237337 (10Krinkle) +1. Already disabled on various repos by hand. Thanks for creating this task. [20:46:37] (03PS14) 1020after4: Fix up branch.py so that it's suitable for wmf/ production branches [tools/release] - 10https://gerrit.wikimedia.org/r/543248 [20:47:50] (03CR) 1020after4: Fix up branch.py so that it's suitable for wmf/ production branches (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/543248 (owner: 1020after4) [20:58:20] Jdlrobson: the minerva post-nerge test failed, should I be worried? https://integration.wikimedia.org/ci/job/mwselenium-quibble-docker/20359/console [20:58:28] 10Project-Admins: Create user board for Majavah - https://phabricator.wikimedia.org/T237402 (10Majavah) Thanks @MGChecker! How can I automatically add the project to tasks that I've been assigned to? [20:59:18] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Security-Team: wikimedia/security gerrit requests - https://phabricator.wikimedia.org/T237449 (10Paladox) +1 to that @Reedy [21:05:02] 10Release-Engineering-Team-TODO, 10GitHub-Mirrors: Disable "Automated security fixes" on Wikimedia Org - https://phabricator.wikimedia.org/T237337 (10Reedy) p:05Triage→03High I intend to do this by the end of the week, barring any major issues/complaints. It seems fruitful to publicise this on mediawiki-l... [21:17:58] 10Release-Engineering-Team-TODO, 10GitHub-Mirrors: Disable "Automated security fixes" on Wikimedia Org - https://phabricator.wikimedia.org/T237337 (10MarcoAurelio) Just to clarify, what are we //really// disabling, `dependabot` creating automated Pull Requests for security issues or the weekly GitHub security... [21:24:45] 10Project-Admins: Create user board for Majavah - https://phabricator.wikimedia.org/T237402 (10MGChecker) A Bulk Edit (for the backlog, although this does not seem to be an issue) and a Global Herald rule (for automatically adding the project in the future). While I am technically able to do both of these things... [21:33:19] 10MediaWiki-Releasing, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.34-release: Release MW 1.34 - https://phabricator.wikimedia.org/T232023 (10Reedy) [21:35:22] 10Differential, 10Gerrit, 10Release-Engineering-Team-TODO, 10GitHub-Mirrors: Create and maintain somehow a list of repos mastered in GitHub (and in Differential) - https://phabricator.wikimedia.org/T237470 (10Jdforrester-WMF) [21:36:06] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201911), 10Test-Coverage: mwcore-phpunit-coverage-master times out after 5 hours - https://phabricator.wikimedia.org/T232706 (10Jdforrester-WMF) Currently being worked on a bit -> t... [21:36:06] that'd be helpful James_F ^ [21:36:16] the Differential one I mean [21:36:40] Next helpful, kill GitHub and Differential [21:36:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201911), 10Patch-For-Review: Investigate Docker slowness between 18.06.2 and 18.09.7 - https://phabricator.wikimedia.org/T236675 (10Jdforrester-WMF) Currently being worked on a bit... [21:36:45] :P [21:37:12] 10Release-Engineering-Team-TODO (201911), 10Code-Review-Workgroup: Define code review metrics - https://phabricator.wikimedia.org/T229510 (10Jdforrester-WMF) [21:38:17] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO (201910), 10Patch-For-Review: Beta cluster doesn’t update since ca. 2019-10-15 21:00 UTC - https://phabricator.wikimedia.org/T235674 (10Jdforrester-WMF) Is this fixed? Are the keys we use encrypted now? [21:39:22] hauskater: Well, we *did* kill Differential, but not well enough. ;-) [21:39:52] I'm still creating Mirrors for new repos [21:39:55] and on GitHub [21:40:02] There's a bunch of code that lives in GitHub for good reasons, and we should make sure that those (and only those) exist. [21:40:18] Well yeah, packagist issues I guess [21:42:29] Not just that. E.g. the eslint stuff has to live there because that's where eslint development happens and we need to keep the eslint people in the loop for some of it. [21:43:23] 10MediaWiki-Releasing, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.34-release: Release MW 1.34.0-rc.1 - https://phabricator.wikimedia.org/T235922 (10Jdforrester-WMF) a:03Reedy [21:46:27] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO (201910), 10Patch-For-Review: Beta cluster doesn’t update since ca. 2019-10-15 21:00 UTC - https://phabricator.wikimedia.org/T235674 (10Krenair) 05Open→03Resolved I don't think we figured out *why* exactly the unencrypted snakeoil keys got de... [22:00:23] 10MediaWiki-Releasing, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.34-release: Release MW 1.34 - https://phabricator.wikimedia.org/T232023 (10Reedy) [22:00:25] 10MediaWiki-Releasing, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.34-release: Release MW 1.34.0-rc.1 - https://phabricator.wikimedia.org/T235922 (10Reedy) 05Open→03Resolved [22:13:13] Krenair: Thanks. [22:14:45] A copy of your installation's LocalSettings.php [22:14:46] must exist and be readable in the source directory. [22:14:48] Use --conf to specify it. [22:14:50] wtf? [22:18:07] twentyafterfour: where do we send the "I iz borked tehz wikiz" t-shirt ;) ? [22:19:16] Oh dear. [22:19:18] hauskater: I already got my t-shirt [22:19:33] Yeah, you're not meant to collect the t-shirt-with-oak-clusters. ;-) [22:20:10] James_F: any clue what that might be? did we change anything about the localisation cache stuff recently? [22:20:27] Yeah, it's familiar. [22:20:31] * James_F goes hunting for commits. [22:20:37] or is it something wrong with my branch? I don't see any LocalSettings in the wmf.4 branch [22:20:39] I think I saw that error sometimes when trying to run maintenance scripts locally but no LocalSettings [22:20:59] We don't use LocalSettings in Wikimedia production. [22:21:08] I didn't think so [22:21:08] Or, rather, we do use a fake one that reflects out to MultiVersion. [22:21:11] yeah, that's why it's a bit weird [22:22:56] It's probably https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524396 [22:23:28] But we set wgServer? [22:23:34] Maybe it's not set by then somehow. [22:24:56] https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/548839/3/includes/DefaultSettings.php has wgServer set to false [22:25:40] Last change to Maintenance.php was 542677 but that went out in wmf.3. [22:26:01] twentyafterfour: Is there a stack trace at all? [22:26:08] James_F: in wmf.4 the DefaultSettings.php had $wgServer = WebRequest::detectServer(); [22:26:24] James_F: no stack for php just a useless scap python stack [22:26:26] Yeah, that's not meant to have ever been called in Wikimedia production. [22:26:39] It's running through the "real" prod config when you run scap, right? [22:26:48] Initiated as aawiki or whatever. [22:26:59] * James_F forgest exactly how this works in scap. [22:27:37] /usr/local/bin/mwscript rebuildLocalisationCache.php --wiki="testwiki" --outdir="/tmp/scap_l10n_840646293" --threads=30 --lang en --quiet [22:27:45] is what scap ran [22:28:36] Hmm, in that case I'd have expected it to initialise correctly with wgServer set to "//test.wikipedia.org" [22:29:35] twentyafterfour: Aha. [22:29:45] Prod config doesn't set a wgServer for testwiki. [22:30:06] Presumably it was expected that 'wikipedia' would do it? [22:30:54] My export JSON set it as `"wgServer": "//.wikipedia.org"` which looks, umm, wrong. :-) [22:32:26] something missing before .wikipedia I guess [22:32:42] $lang not valid. [22:32:53] twentyafterfour: Cherry-pick https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/548917 and see if it works? [22:33:09] If yes, we'll probably have to audit all the wgserver values and set them explicitly. [22:33:31] twentyafterfour: Did you make a task? [22:33:43] not yet [22:33:57] * twentyafterfour makes one [22:34:03] And here was I about to clock off for the day. [22:34:39] James_F: you don't have to stay around I can figure it out :) [22:34:53] Ha. [22:43:10] so this is what it's hitting: https://github.com/wikimedia/mediawiki/blob/master/maintenance/Maintenance.php#L1298 [22:43:47] and $settingsFile == LocalSettings.php ? [22:44:21] $settingsFile = MW_CONFIG_FILE; [22:44:22] else [22:44:35] $settingsFile = "$IP/LocalSettings.php"; [22:45:02] Could be that MW_CONFIG_FILE is set but not readable. [22:45:10] maybe you can use --conf $IP/wmf-config/InitialiseSettings.php [22:45:47] Or that [22:47:47] settingsFile = /srv/mediawiki-staging/php-1.35.0-wmf.5/LocalSettings.php [22:48:33] which is not a file that exists [22:48:54] it does exist for wmf.4 [22:48:57] ah ha [22:49:10] Oh, that'd do it. [22:49:17] Scap change? [22:49:35] ok false alarm, James_F you can clock off ;) [22:49:51] Excellent. Good night, all. [22:49:57] Good night James_F [23:15:05] 10MediaWiki-Releasing, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.34-release: Release MW 1.34 - https://phabricator.wikimedia.org/T232023 (10CCicalese_WMF) [23:20:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (201911): Evaluate Airflow's suitability for CI - https://phabricator.wikimedia.org/T237450 (10dduvall) >>! In T237450#5637682, @Ottomata wrote: > For accuracy, IIUC [[ https://github.com/argoproj/argo | Argo ]] is a building block, from... [23:38:52] 10Release-Engineering-Team-TODO (201911), 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10wikidiff2, and 3 others: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed - https://phabricator.wikimedia.org/T237049 (10Reedy) What's next? Set `$wgDiffEngine` in CI to PHP, and roll o... [23:42:40] 10Release-Engineering-Team-TODO (201911), 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10wikidiff2, and 3 others: DifferenceEngineTest and ApiComparePagesTest failures when wikidiff2 is installed - https://phabricator.wikimedia.org/T237049 (10Tgr) All tests that rely on a specific diffengine implementation... [23:49:49] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations, and 2 others: Gerrit Hardware Upgrade (+ upgrade from jessie to stretch or buster) - https://phabricator.wikimedia.org/T222391 (10Dzahn) [23:49:50] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations: Reimage gerrit1001 and gerrit2001 as buster - https://phabricator.wikimedia.org/T176774 (10Dzahn) [23:55:21] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Operations: Reimage gerrit1001 and gerrit2001 as buster - https://phabricator.wikimedia.org/T176774 (10Dzahn) 05Open→03Resolved gerrit1001 and gerrit2001 are on buster and cobalt has been shut down and remov... [23:55:27] 10Gerrit, 10Operations, 10Traffic, 10Patch-For-Review: Switch on http/2 in apache for gerrit - https://phabricator.wikimedia.org/T180978 (10Dzahn)