[00:00:52] https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/549670/ [00:01:08] RoanKattouw: ^ [00:01:20] Thank you! [00:01:57] A CSS-only fix might be fine, but also seems like it might not outweigh fixing of CI priority-wise in that prioritising that means to some extent accepting that CI is broken and not raising the alarm of "we can't deploy properly" [00:02:03] Thanks Krinkle, my fault. [00:02:07] Probably ok to hold back a day or two if that's what it takes to unbreak. [00:02:08] no worries :) [00:02:22] I was so focussed on fixing REL1_34/etc. that I didn't check wmf/ [00:04:17] I've now +2ed first the $wgDiffEngine patch, then Zoranzoki21's patch (in core), then my patch (in an extension), hoping that they'll all pass when done in that order [00:04:38] Thanks [00:04:47] One question: How to define action? [00:05:09] like &action=history [00:05:47] Krinkle: I agree with you in general, but if CI is broken at 4pm on a Thursday and the next SWAT window isn't until Tuesday, and if nobody who knew anything about the failure was around and it was also obviously bogus, I would have force-merged [00:07:17] RoanKattouw: UBNs don't need to wait for SWAT anyway… [00:07:28] Was the semicolon patch a UBN? [00:07:52] I imagine so. [00:07:59] People whine about the smallest thinngs. [00:10:17] lol [00:10:24] Will pass in gate-and-submit [00:10:27] :P [00:10:30] * Zoranzoki21 laughs [00:10:47] Excellent [00:11:13] BTW, T237701 [00:11:14] T237701: Vector skin injects a semicolon to the watchlist which is not localized - https://phabricator.wikimedia.org/T237701 [00:16:38] (03CR) 10Jeena Huneidi: "I am going to make a walkthrough and add it as a link. Brennen, I'm not sure about the dev-images. Should that be part of the dev-images r" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/546319 (https://phabricator.wikimedia.org/T236587) (owner: 10Jeena Huneidi) [00:24:03] RoanKattouw: the semicolon patch is definitely not an UBN in my mind [00:24:17] it can easily be rectified in site styles for impacted wikis [00:25:52] TIL that semicolons are translateable. [01:19:56] 10Project-Admins, 10Research: create tags for Research - https://phabricator.wikimedia.org/T228350 (10leila) Thanks for all the changes and help! all good on my end. [02:01:46] (03PS7) 10Krinkle: move wmf favicon from external link to local link [integration/docroot] - 10https://gerrit.wikimedia.org/r/549584 (https://phabricator.wikimedia.org/T213223) (owner: 10Dzahn) [02:01:49] (03CR) 10Krinkle: [C: 03+2] move wmf favicon from external link to local link [integration/docroot] - 10https://gerrit.wikimedia.org/r/549584 (https://phabricator.wikimedia.org/T213223) (owner: 10Dzahn) [02:02:22] (03Merged) 10jenkins-bot: move wmf favicon from external link to local link [integration/docroot] - 10https://gerrit.wikimedia.org/r/549584 (https://phabricator.wikimedia.org/T213223) (owner: 10Dzahn) [02:12:43] (03PS1) 10Krinkle: shared: remove double slash in favicon url [integration/docroot] - 10https://gerrit.wikimedia.org/r/549688 [02:12:54] (03CR) 10Krinkle: [C: 03+2] "Note that .// works fine, it just looks odd that's all :)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/549688 (owner: 10Krinkle) [02:13:26] (03Merged) 10jenkins-bot: shared: remove double slash in favicon url [integration/docroot] - 10https://gerrit.wikimedia.org/r/549688 (owner: 10Krinkle) [02:18:51] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: doc1001 permission problems - https://phabricator.wikimedia.org/T237707 (10Krinkle) [06:25:40] PROBLEM - Puppet errors on deployment-mediawiki-parsoid10 is CRITICAL: (Service Check Timed Out) [06:25:40] PROBLEM - Puppet staleness on deployment-cpjobqueue is CRITICAL: (Service Check Timed Out) [06:25:40] PROBLEM - Puppet staleness on deployment-etcd-01 is CRITICAL: (Service Check Timed Out) [06:25:40] PROBLEM - Puppet staleness on deployment-sessionstore01 is CRITICAL: (Service Check Timed Out) [06:25:41] PROBLEM - Puppet staleness on integration-slave-jessie-1001 is CRITICAL: (Service Check Timed Out) [06:25:42] PROBLEM - Puppet staleness on deployment-snapshot01 is CRITICAL: (Service Check Timed Out) [06:25:44] PROBLEM - Puppet errors on deployment-puppetmaster03 is CRITICAL: (Service Check Timed Out) [06:25:44] PROBLEM - Puppet errors on deployment-sessionstore01 is CRITICAL: (Service Check Timed Out) [06:25:45] PROBLEM - Puppet errors on deployment-mcs01 is CRITICAL: (Service Check Timed Out) [06:25:47] PROBLEM - Puppet errors on deployment-chromium02 is CRITICAL: (Service Check Timed Out) [06:25:47] PROBLEM - Puppet errors on deployment-docker-mathoid01 is CRITICAL: (Service Check Timed Out) [06:25:48] PROBLEM - Puppet staleness on integration-puppetmaster01 is CRITICAL: (Service Check Timed Out) [06:25:49] PROBLEM - Puppet staleness on deployment-imagescaler01 is CRITICAL: (Service Check Timed Out) [07:04:28] starting a new batch of upload/caption/add depicts for 1k images, with 10 second wait between each edit or upload, for beta commons. [07:07:17] I'm unable to respect maxlag because of the wikidata dispatch issue (dispatch attempted to wikis that don't exist in beta), but hopefully a 10 second wait is fine [09:07:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: doc1001 permission problems - https://phabricator.wikimedia.org/T237707 (10hashar) The long story is at T235715#5588924 The issue originates from the migration of doc.wikimedia.org to a new server which was {T137890}. It is pending a couple... [09:38:50] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): doc1001 permission problems - https://phabricator.wikimedia.org/T237707 (10hashar) p:05Triage→03Normal a:03hashar [09:39:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): doc1001 permission problems - https://phabricator.wikimedia.org/T237707 (10hashar) [09:39:28] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10serviceops, 10Developer-Wishlist (2017), and 3 others: Relocate CI generated docs and coverage reports - https://phabricator.wikimedia.org/T137890 (10hashar) [10:20:29] 10Release-Engineering-Team: Phatility: Include server field in "Request URL" field - https://phabricator.wikimedia.org/T235945 (10mmodell) 05Open→03Resolved [10:35:36] uploads for this batch done, moving on to captions [11:12:30] 10Phabricator, 10Operations: Intermittent DB connectivity problem on phabricator, needs investigation - https://phabricator.wikimedia.org/T163507 (10mmodell) 05Open→03Declined This is ancient history. [11:15:52] 10Phabricator, 10Code-Review-Workgroup, 10GerritBot: Enable semantic relationship between code review changesets and maniphest tasks in phabricator - https://phabricator.wikimedia.org/T229934 (10mmodell) a:03mmodell [11:40:22] 10Phabricator, 10Code-Review-Workgroup, 10GerritBot: Enable semantic relationship between code review changesets and maniphest tasks in phabricator - https://phabricator.wikimedia.org/T229934 (10hashar) [11:40:24] 10Phabricator, 10Code-Review-Workgroup: Add a link from Phabricator task to a Gerrit search for bug:TXXXXX - https://phabricator.wikimedia.org/T209463 (10hashar) [11:41:46] 10Phabricator, 10Code-Review-Workgroup, 10GerritBot: Enable semantic relationship between code review changesets and maniphest tasks in phabricator - https://phabricator.wikimedia.org/T229934 (10hashar) I guess that would address a feature I have listed T209463 namely for each task add a link to a Gerrit sea... [11:44:34] (03PS1) 10Pwirth: layout, parameter_functions: Add BlueSpiceArticlePreviewCapture [integration/config] - 10https://gerrit.wikimedia.org/r/549836 [12:20:50] (03PS1) 10Mainframe98: Add a sniff to detect and autosort use statements [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/549838 (https://phabricator.wikimedia.org/T237694) [12:21:30] 10MediaWiki-Codesniffer, 10Patch-For-Review: Alphasort use statements - https://phabricator.wikimedia.org/T237694 (10Mainframe98) a:03Mainframe98 [12:23:40] (03PS2) 10Mainframe98: Add a sniff to detect and autosort use statements [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/549838 (https://phabricator.wikimedia.org/T237694) [13:17:50] (03CR) 10Jforrester: [C: 03+2] Add a sniff to detect and autosort use statements [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/549838 (https://phabricator.wikimedia.org/T237694) (owner: 10Mainframe98) [13:18:18] (03Merged) 10jenkins-bot: Add a sniff to detect and autosort use statements [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/549838 (https://phabricator.wikimedia.org/T237694) (owner: 10Mainframe98) [13:26:41] 10MediaWiki-Codesniffer: Alphasort use statements - https://phabricator.wikimedia.org/T237694 (10Mainframe98) 05Open→03Resolved p:05Triage→03Normal [13:31:32] (03PS1) 10Hashar: Fix test edge case causing a failure [integration/config] - 10https://gerrit.wikimedia.org/r/549850 [13:36:02] (03PS1) 10Hashar: tests: make tests/ a module [integration/config] - 10https://gerrit.wikimedia.org/r/549853 [13:36:17] (03CR) 10Hashar: [C: 03+2] Fix test edge case causing a failure [integration/config] - 10https://gerrit.wikimedia.org/r/549850 (owner: 10Hashar) [13:37:07] (03Merged) 10jenkins-bot: Fix test edge case causing a failure [integration/config] - 10https://gerrit.wikimedia.org/r/549850 (owner: 10Hashar) [13:41:44] (03CR) 10Hashar: [C: 03+2] tests: make tests/ a module [integration/config] - 10https://gerrit.wikimedia.org/r/549853 (owner: 10Hashar) [13:42:20] (03CR) 10Jforrester: "Intéressant." [integration/config] - 10https://gerrit.wikimedia.org/r/549853 (owner: 10Hashar) [13:42:49] (03Merged) 10jenkins-bot: tests: make tests/ a module [integration/config] - 10https://gerrit.wikimedia.org/r/549853 (owner: 10Hashar) [13:43:35] paladox: Hey, would you have a minute to investigate an annoying gerrit bug? [13:43:40] hi [13:43:41] yup [13:43:44] Great! [13:43:51] Actually, I just want to know if you're already aware [13:43:56] So, here is how to reproduce [13:44:06] Go here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/549607/4/includes/api/ApiEchoUnreadNotificationPages.php [13:44:22] (Ah, forgot to say, I don't use polygerrit) [13:44:39] Click on "skipped 91 common lines" (it's at line 63) [13:44:57] hmm [13:44:59] i see 101 [13:45:16] top i see 33, middle 101 and bottom 40 [13:45:24] Huh, I guess it's the same - the 101 one [13:45:35] ok [13:45:40] Then double click on "$result" at line 153 [13:45:50] Then ctrl-f to search [13:46:02] Press enter to go to the next result [13:46:09] Then try to scroll to the top of the page [13:46:20] For me, it keeps bouncing back to line 153 [13:46:34] Oh, i sometimes have that issue [13:46:40] i just go out of the diff then go back [13:46:47] Yeah, me too [13:47:06] It's very, very annoying - now that I could consistently reproduce it I thought it'd be worth reporting [13:47:16] Yeh, upstream have removed GWTUI [13:47:42] And we plan to upgrade to 2.16 soon (tentative date set) :) [13:48:14] Ah, indeed I don't see it in polygerrit [13:48:22] Yeah, hoping it will happen soon :) [13:50:09] Thanks for confirming! [13:50:46] :) [14:02:23] 10Gerrit: Gerrit workflow: "Merge review" AND "Open push" for BlueSpice? - https://phabricator.wikimedia.org/T234224 (10hashar) >>! In T234224#5536925, @Osnard wrote: > Yes, I actually want to `push` instead of `review`, as I just want to synchronize branches `REL1_31` and `REL1_31_dev`. In `REL1_31_dev` everyth... [14:03:07] 10Gerrit, 10Release-Engineering-Team, 10wikimedia.biterg.io, 10Upstream: Gerrit replica does not support the 'query' command - https://phabricator.wikimedia.org/T235251 (10hashar) Out of the TODO queue; It is upstreamed and not a priority. [14:03:37] captions done, depicts started [14:11:26] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10MW-1.31-release, 10MW-1.32-release, and 2 others: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945 (10hashar) I am not active on the Phan front, but could we imagine upgrading Phan in our rele... [14:19:23] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10MW-1.31-release, 10MW-1.32-release, and 2 others: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945 (10Jdforrester-WMF) >>! In T226945#5647667, @hashar wrote: > I am not active on the Phan fron... [14:19:27] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10serviceops-radar: Consider creating a puppet-compiler equivalent for mediawiki-config.git - https://phabricator.wikimedia.org/T220775 (10Jdforrester-WMF) I co... [14:19:29] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10MW-1.31-release, 10MW-1.32-release, and 2 others: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945 (10Daimona) >>! In T226945#5647667, @hashar wrote: > I am not active on the Phan front, but c... [14:19:33] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10MW-1.31-release, 10MW-1.32-release, and 2 others: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945 (10hashar) [14:19:52] (03CR) 10Thiemo Kreuz (WMDE): "James, please give the people working on this codebase a little more time to have a look at significant patches like this. Less than an ho" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/549838 (https://phabricator.wikimedia.org/T237694) (owner: 10Mainframe98) [14:21:01] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10MW-1.31-release, 10MW-1.32-release, and 2 others: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945 (10hashar) You guys are **amazing**. As soon as the `extras` field is not needed anymore, let... [14:21:28] of course Daimona has a french citation on the user page! [14:21:32] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10MW-1.31-release, 10MW-1.32-release, and 2 others: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945 (10Daimona) {{edit conflict}} Belatedly, T235049 is only for master, nothing is being done on... [14:21:36] https://www.mediawiki.org/wiki/User:Daimona_Eaytoy reads "Un sot trouve toujours un plus sot qui l'admire." [14:22:12] Oui :) [14:22:59] J'ai étudié un peu de français [14:23:48] et j'aime l'origine de ton nickname [14:23:52] ;-] [14:29:29] C'était un choix... aléatoire (?) [14:33:38] :]] [14:35:32] 10Continuous-Integration-Config, 10MediaWiki-General: Extension quibble-vendor-mysql-hhvm-docker failing with Undefined interface: Psr\Container\ContainerInterface - https://phabricator.wikimedia.org/T231869 (10hashar) 05Stalled→03Resolved Assuming that got fixed somewhere :] [14:58:43] 10Phabricator, 10Code-Review-Workgroup, 10GerritBot: Enable semantic relationship between code review changesets and maniphest tasks in phabricator - https://phabricator.wikimedia.org/T229934 (10mmodell) 05Open→03Resolved [15:11:59] 10Phabricator, 10Code-Review-Workgroup, 10GerritBot: Enable semantic relationship between code review changesets and maniphest tasks in phabricator - https://phabricator.wikimedia.org/T229934 (10hashar) 10/10 totally aced. Example https://gerrit.wikimedia.org/r/c/548964 which has `Bug: T236746` and is thus... [15:16:21] (03PS1) 10Pwirth: layout, parameter_functions: Add BlueSpiceBookshelf,BlueSpiceBookshelfUI [integration/config] - 10https://gerrit.wikimedia.org/r/549868 [15:19:32] (03CR) 10jerkins-bot: [V: 04-1] layout, parameter_functions: Add BlueSpiceBookshelf,BlueSpiceBookshelfUI [integration/config] - 10https://gerrit.wikimedia.org/r/549868 (owner: 10Pwirth) [15:21:15] (03CR) 10Jforrester: "> Patch Set 2:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/549838 (https://phabricator.wikimedia.org/T237694) (owner: 10Mainframe98) [15:24:55] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10MW-1.31-release, 10MW-1.32-release, and 2 others: Decide on future of running Phan tests on release branches - https://phabricator.wikimedia.org/T226945 (10Jdforrester-WMF) >>! In T226945#5647679, @Daimona wrote: > {{edit conflict}} Belatedly, T2... [15:27:53] (03PS2) 10Pwirth: layout, parameter_functions: Add BlueSpiceBookshelf,BlueSpiceBookshelfUI [integration/config] - 10https://gerrit.wikimedia.org/r/549868 [15:31:14] (03CR) 10jerkins-bot: [V: 04-1] layout, parameter_functions: Add BlueSpiceBookshelf,BlueSpiceBookshelfUI [integration/config] - 10https://gerrit.wikimedia.org/r/549868 (owner: 10Pwirth) [15:38:38] (03PS3) 10Pwirth: layout, parameter_functions: Add BlueSpiceBookshelf,BlueSpiceBookshelfUI [integration/config] - 10https://gerrit.wikimedia.org/r/549868 [15:41:06] Hi all - I have another gerrit question for the Fundraising Analytics repo. We seem to be missing the ability to merge after code review - would you be able to help us out? [15:42:26] eyener hi, you can grant the submit rights under ,access. [15:44:07] paladox I don't think I'm seeing that - or maybe don't know where to go [15:44:38] eyener i've forgotten your exact repo name, but for example like /3d2png,access [15:44:42] then click edit [15:44:57] then go to "Add Permission" [15:45:19] scroll down till you see "Submit" [15:45:31] (it may already be there so if you doin't see it, search the page for it) [15:45:52] then click add group and then type in the group and click "add" [15:46:09] (03CR) 10Jforrester: [C: 03+2] layout, parameter_functions: Add BlueSpiceBookshelf,BlueSpiceBookshelfUI [integration/config] - 10https://gerrit.wikimedia.org/r/549868 (owner: 10Pwirth) [15:46:58] (03Merged) 10jenkins-bot: layout, parameter_functions: Add BlueSpiceBookshelf,BlueSpiceBookshelfUI [integration/config] - 10https://gerrit.wikimedia.org/r/549868 (owner: 10Pwirth) [15:47:20] paladox https://gerrit.wikimedia.org/r/q/project:wikimedia%252Ffundraising%252Fanalytics is the repo (sorry - new to this) [15:47:25] Where to from there? [15:47:57] eyener you go to https://gerrit.wikimedia.org/r/admin/projects [15:48:00] type in the repo name [15:48:02] click on it [15:48:16] look at the header, you should see it say "Access" [15:48:19] click on that [15:48:20] (03CR) 10Thiemo Kreuz (WMDE): "Considering that every change here affects millions of lines of code in hundreds of code repositories, maintained by hundreds of people, I" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/549838 (https://phabricator.wikimedia.org/T237694) (owner: 10Mainframe98) [15:48:28] then click the edit button [15:48:32] then go to "Add Permission" [15:48:36] scroll down till you see "Submit" [15:48:39] (it may already be there so if you doin't see it, search the page for it) [15:48:42] then click add group and then type in the group and click "add" [15:48:44] then click save [15:49:03] I do not see access available [15:50:51] !log Zuul: Add BlueSpiceBookshelf and BlueSpiceBookshelfUI [15:50:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:51:21] oh wait I think I've got it [15:51:25] :) [16:04:17] I've updated permissions to include Push, Push Merge Commit, Submit, Label Code Review, and Label Verified - but i'm still not seeing a Code Review section on a change I've posted to the repo [16:07:18] cc thcipriani ^ [16:09:39] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10serviceops-radar: Consider creating a puppet-compiler equivalent for mediawiki-config.git - https://phabricator.wikimedia.org/T220775 (10Ladsgroup) >>! In T22... [16:23:45] eyener did you grant the correct group to the rights? [16:24:10] I granted wikimedia-fundraising-analytics rights to all of those settings [16:25:05] hmm [16:28:58] eyener: which change? [16:29:22] Change-Id: Ic465ef84fc916a4f2adba34db941a4b53f0bfb64 [16:29:30] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/analytics/+/546757/ [16:30:14] heh, oh right, I can't see those changes. What I was going to look for is if that change has any dependant changes that might need to merge before that one can merge. [16:30:48] i.e., you might have permissions all correct, but still not be able to review due to ordering problems or something similar [16:33:43] Hmm it's a new repo and that's the only thing in there [16:34:01] We're just getting set up! [16:40:13] 10Deployments, 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10ReleaseTaggerBot: Deployment status indicator for gerrit patches - https://phabricator.wikimedia.org/T88136 (10Krinkle) Within Gerrit, the "Included In" section already indicates which branches a change was naturally a part of. Howeve... [17:01:26] 10Release-Engineering-Team, 10Operations, 10serviceops, 10Performance-Team (Radar), and 2 others: PHP Fatal error: The UdpSocket to 127.0.0.1:10514 has been closed (from Monolog/SyslogUdp on mwdebug1002) - https://phabricator.wikimedia.org/T214734 (10ema) Notice that debug servers aren't pooled in etcd li... [17:56:35] (03PS1) 10Dduvall: Remove experimental warning from README [blubber] - 10https://gerrit.wikimedia.org/r/549900 [18:00:06] (03PS1) 10Paladox: Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/549901 [18:01:11] (03CR) 10jerkins-bot: [V: 04-1] Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/549901 (owner: 10Paladox) [18:07:27] batch complete, that's it for the day [18:31:29] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201911), 10Documentation, and 2 others: Make PHD run on the backup phabricator server (phab2001, currently) - https://phabricator.wikimedia.org/T232883 (10Dzahn) Whether phd is running is actually not directl... [18:32:12] (03PS2) 10Paladox: Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/549901 [18:33:28] (03CR) 10jerkins-bot: [V: 04-1] Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/549901 (owner: 10Paladox) [18:38:34] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201911), 10Documentation, and 2 others: Make PHD run on the backup phabricator server (phab2001, currently) - https://phabricator.wikimedia.org/T232883 (10Dzahn) Let's change the monitoring to also use "profi... [18:39:04] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201911), 10serviceops, and 3 others: Make PHD run on the backup phabricator server (phab2001, currently) - https://phabricator.wikimedia.org/T232883 (10Dzahn) [18:42:26] (03PS3) 10Paladox: Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/549901 [18:43:13] (03CR) 10jerkins-bot: [V: 04-1] Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/549901 (owner: 10Paladox) [19:41:59] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201911), 10serviceops, and 3 others: Make PHD run on the backup phabricator server (phab2001, currently) - https://phabricator.wikimedia.org/T232883 (10Dzahn) https://gerrit.wikimedia.org/r/c/operations/puppe... [20:49:17] (03PS9) 10Paladox: WIP: Update gerrit to 2.16.13 [software/gerrit] (deploy/wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/495012 [20:57:27] (03PS10) 10Paladox: WIP: Update gerrit to 2.16.13 [software/gerrit] (deploy/wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/495012 [21:03:43] Migrating data to schema 169 ... [21:03:43] Migrating projects: 100% (4/4) [21:03:43] Skipped 4 projects with no legacy comments [21:03:43] > Done (58.032 s) [21:03:43] \o/ [21:03:59] Appears mw-core and the puppet repo doin't hit https://bugs.chromium.org/p/gerrit/issues/detail?id=10239 [21:08:57] thcipriani so when we upgrade, we have to start the online indexers immeditly. (Changes may look like they disappear but should start showing as the indexer runs through them) [21:09:32] we may want to increase the threads we give to the indexer for this [21:09:52] Since there's not much to worry about db side (shouldn't be using the db to reindex changes) [21:10:04] seems like a good plan. What do you mean that changes look like they disappear? [21:10:29] what happens in the UI? [21:11:16] The changes didn't show in status:open but when i went to them direct they showed (but 500'd) [21:11:46] with: [21:11:47] [2019-11-08 21:07:48,231] [HTTP-86] ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in GET /r/changes/operations%2Fpuppet~548547/submitted_together?o=CURRENT_COMMIT [21:11:47] java.lang.IllegalStateException: Expected exactly one ChangeData, got 0 [21:12:06] that was only for the submitted together [21:28:04] thcipriani ^ [21:28:51] hrm [21:33:54] fixed now after the index [21:33:57] https://gerrit.git.wmflabs.org/r/c/operations/puppet/+/548547/5 that was the change [21:37:50] though "Plugin install error: TypeError: self.onAction is not a function. (In 'self.onAction('project', 'delete', onDeleteProject)', 'self.onAction' is undefined)" is annoying [21:38:15] which i'm going to have to try and fix... [21:38:38] that should not be executed (that's gwtui code) [21:46:56] (03CR) 10Brennen Bearnes: [V: 03+2 C: 03+2] Fix permissions issue mounting volumes [releng/local-charts] - 10https://gerrit.wikimedia.org/r/549217 (owner: 10Jeena Huneidi) [21:47:13] (03CR) 1020after4: [C: 03+1] "awesome" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/549217 (owner: 10Jeena Huneidi) [22:11:35] (03CR) 10Brennen Bearnes: "> Patch Set 1:" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/546319 (https://phabricator.wikimedia.org/T236587) (owner: 10Jeena Huneidi) [22:37:39] does anyone know how I would get Jenkins to run on PHP 7.3? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GraphQL/+/547844 [23:09:18] https://github.com/wikimedia/integration-config/search?q=php7.3&unscoped_q=php7.3 [23:09:25] seems we have ph7.3 images [23:10:41] https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L1073