[00:22:49] !log Apply Puppet role class "xhgui::app" to deployment-xhgui01. T238788, T180761 [00:22:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [00:22:53] T180761: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 [00:22:53] T238788: make xhgui::app role support stretch/buster and deploy on new xhgui machines - https://phabricator.wikimedia.org/T238788 [00:29:34] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) [00:34:11] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-09 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [00:35:29] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) @Dzahn I've set the puppet role, confirmed puppet agent ran without errors, but looks like it's not (yet) working. I've exposed the host direct... [00:35:53] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) a:03Dzahn [00:38:08] (03PS3) 10Mstyles: Java sonarcloud implementation [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) [00:38:56] (03CR) 10jerkins-bot: [V: 04-1] Java sonarcloud implementation [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [00:39:01] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-09 is OK: HTTP OK: HTTP/1.1 200 OK - 49248 bytes in 0.744 second response time [00:41:04] (03CR) 10Mstyles: Java sonarcloud implementation (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [00:41:47] (03PS4) 10Mstyles: Java sonarcloud implementation [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) [01:04:00] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) a:05Dzahn→03Krinkle [01:15:17] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) Never mind. It needs `ext-mongodb` (for PHP 7+) instead of `ext-mongo` (PHP5-only). And the puppet provisioning already installs this correctly.... [01:26:35] !log Set `profile::webperf::site::xhgui_host: deployment-xhgui01.deployment-prep.eqiad.wmflabs` in Hiera for deployment-webperf11. T180761 [01:26:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:26:38] T180761: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 [01:26:55] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) And now properly at [01:31:25] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) [02:09:12] !log Create 'mongo' security group and apply to deployment-xhgui01 (ingress tcp/27017). T180761 [02:09:17] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:09:17] T180761: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 [02:32:20] !log It appears puppet-agent has been locally disabled on deployment-mediawiki-07 for at least three days with "no reason given". Re-enabling now to unbreak https://gerrit.wikimedia.org/r/556854 for T180761 [02:32:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:32:23] T180761: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 [02:32:58] Krenair: in case you know more ^ [02:54:50] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) While all parts are up and running and working correctly when probed independently, it seems the overall pipeline is not working. 1. Run `curl... [02:57:39] !log Restarting deployment-mediawiki-07. - T180761 [02:57:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:57:42] T180761: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 [02:58:03] (03PS5) 10Awight: [WIP] Sniff for undocumented, unchecked @throws annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556654 [02:58:53] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) And... now it all works. I guess either Apache or PHP needed a restart for some of this in a way that Puppet didn't do during provisioning. [03:12:24] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) a:05Krinkle→03Dzahn [03:13:11] 10Beta-Cluster-Infrastructure, 10Performance-Team, 10Patch-For-Review: Move XHGui from tungsten to xhgui-001 - https://phabricator.wikimedia.org/T180761 (10Krinkle) Signing over to @Dzahn for the last few steps in prod: 1. Switch perf.wm.o proxy on webperf1001 from tungsten to xhgui1001. – https://gerrit.wi... [03:56:28] Project beta-scap-eqiad build #279060: 04FAILURE in 2 min 0 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279060/ [04:06:40] Project beta-scap-eqiad build #279061: 04STILL FAILING in 2 min 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279061/ [04:16:26] Project beta-scap-eqiad build #279062: 04STILL FAILING in 1 min 58 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279062/ [04:26:26] Project beta-scap-eqiad build #279063: 04STILL FAILING in 1 min 58 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279063/ [04:32:50] 10Phabricator, 10Security-Team: Create generic security-team request for service intake mechanism - https://phabricator.wikimedia.org/T240492 (10Aklapper) (Let's please add #Phabricator to Phab configuration tasks (e.g. Phab forms) so they can be ever again in the future when searching for Phab things. Thanks :) [04:36:25] Yippee, build fixed! [04:36:25] Project beta-scap-eqiad build #279064: 09FIXED in 1 min 57 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279064/ [06:25:42] PROBLEM - Puppet errors on deployment-kafka-main-2 is CRITICAL: (Service Check Timed Out) [06:25:42] PROBLEM - Puppet staleness on deployment-xhgui01 is CRITICAL: (Service Check Timed Out) [06:25:42] PROBLEM - Puppet errors on deployment-db06 is CRITICAL: (Service Check Timed Out) [06:25:46] PROBLEM - Puppet errors on deployment-cpjobqueue is CRITICAL: (Service Check Timed Out) [06:25:46] PROBLEM - Puppet errors on deployment-cpjobqueue is CRITICAL: (Service Check Timed Out) [06:35:44] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) >>! In T228759#5690705, @Jdforrester-WMF wrote: > I've found the differentiation between Low and Lowest very useful when working as a product owner, when there are dozens or hundreds o... [06:37:40] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) >>! In T228759#5699339, @Lydia_Pintscher wrote: > Yes this is the same for me. Looking at the project tag with the most open tasks (#Wikidata) and ignoring open tasks with "Needs Tria... [08:41:30] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201912), and 2 others: Upload zuul_2.5.1-wmf11 to apt.wikimedia.org - https://phabricator.wikimedia.org/T240570 (10hashar) @jcrespo yes I lack write access :] We do not r... [08:46:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Alternative for Fix inconsistent sorting in UnsortedUseStatements sniff (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556770 (owner: 10Mainframe98) [08:55:42] (03PS2) 10Thiemo Kreuz (WMDE): Fix inconsistent sorting in UnsortedUseStatements sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556670 [08:56:50] (03CR) 10Thiemo Kreuz (WMDE): "In patch set 2 I combined the super helpful suggestions from Mainframe98 (Id2b5ade) and Umherirrender. I'm much more happy with the code n" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556670 (owner: 10Thiemo Kreuz (WMDE)) [09:02:52] (03CR) 10Mainframe98: [C: 03+1] "This is an even better solution." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556670 (owner: 10Thiemo Kreuz (WMDE)) [09:04:21] (03Abandoned) 10Mainframe98: Alternative for Fix inconsistent sorting in UnsortedUseStatements sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556770 (owner: 10Mainframe98) [09:04:57] (03CR) 10Mainframe98: Alternative for Fix inconsistent sorting in UnsortedUseStatements sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556770 (owner: 10Mainframe98) [09:36:40] hashar: bonjour [09:37:38] Do you know if it's possible to skip posting a comment to gerrit from a codehealth job? For example, after mwext-codehealth-patch is done, I don't want any comment posted back to gerrit [09:38:16] Maybe I need to move the jobs as publishers instead of as a pipeline in order to do that [09:38:38] hm [09:39:15] the reporting to Gerrit is done by the Zuul pipelines [09:39:33] when there is a change ;] [09:39:39] For context I'm building a tool on toolforge that is going to listen to a webhook from sonarcloud.io. So the job in Jenkins posts an analysis to SonarCloud.io, and then that posts some JSON to tools.wmflabs.org/sonarqubebot. Then the code there will post a comment with a +1/-1 to Gerrit [09:39:57] (And it will also make inline comments in the patch with issues found) [09:40:12] the "publish" pipeline only reacts on tag changes ( it reacts on reference updates in ^refs/tags/.*$ [09:40:30] So when that goes live, I will no longer need the "Code health checks failed, but this patch can still be merged." message that jenkins-bot leaves [09:41:51] jenkins-bot being Zuul itself :] [09:43:22] so codehealth job which publish to sonarcloud , the result being processed in the background [09:43:24] the job report back [09:43:37] and sonarcloud once it has completed report back the result to your toollabs thing [09:43:45] which spam back gerrit. is that correct? [09:43:54] Ideally in the new paradigm the job won't report back [09:44:08] But we can leave it, and I can change the wording to "Analysis sent to SonarQube for processing" or something like that. [09:44:24] then the message is reported by the "codehealth" pipeline [09:44:29] success-message: 'Code health checks OK! :)' [09:44:34] failure-message: 'Code health checks failed, but this patch can still be merged. Please give feedback at https://www.mediawiki.org/wiki/Talk:Continuous_integration/Codehealth_Pipeline' [09:45:02] right [09:45:31] I'd like to just not post any success-failure message since the toolforge code will do that instead [09:45:36] which really is just an introduction message to whatever Zuul crafts internally [09:45:44] eg the list of all jobs and their status [09:46:14] And the Docker image will have this line removed https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/dockerfiles/java8-sonar-scanner/run.sh#51 [09:46:33] but we can drop the reporting entirely in the zuul codehealth pipeline [09:46:37] just have to remove: [09:46:40] Yes, that's what I want [09:46:45] success: [09:46:45] gerrit: {} [09:46:49] ooh [09:46:51] great [09:46:52] it should not report anything at all [09:46:57] if I got the documentation correclty [09:47:04] :) [09:47:30] from doc/source/zuul.rst [09:47:35] > **success** [09:47:44] > Describes where Zuul should report to if all the jobs complete successfully [09:47:58] > This section is optional; if it is omitted, Zuul will run jobs and [09:47:58] > do nothing on success; it will not even report a message to Gerrit. [09:48:39] what might be possible though is to have the codehealth job to wait for sonarcloud to complete its analysis [09:48:58] then add a publisher that trigger a jenkins job which fetch the report from sonarcloud and then write to gerrit [09:49:09] essentially, instead of using toollabs: use a jenkins job :] [09:49:29] meh [09:49:32] but for a proof of concept toollabs is arguably easier for a quick iteration ;] [09:49:35] also [09:49:41] Yeah, I think it will be easier to iterate [09:49:47] Eventually it could move to Jenkins I suppose [09:50:06] we must have a task somewhere about analysing junit / checkstyle XML files and writing the results back in Gerrit inline differences [09:50:08] as comments [09:50:12] so that if you get a style check [09:50:20] you get a review by the bot pointing exactly the line [09:50:31] and you would theorically no more need to look at the jenkins console to figure out what happened [09:50:41] but yeah do it on wmflabs first [09:50:42] That would be nice indeed [09:50:48] and we can figure out later how to make that a jenkins job [09:50:49] ;) [09:51:15] and it will be absolutely wondering if your tool can be easily adapted to consume junit / checkstyle xml files! [09:52:00] but meanwhile yeah to shutdown the reporting, just drop success: gerrit: {} from the codehealth pipeline config and that might do it [09:52:03] cool [09:52:18] replacing it with a comment placeholder indicating the comment is done elsewhere [09:52:23] twist [09:52:52] one can add a new reporter in Zuul :-]] [09:53:20] Hmm, what would that do? [09:54:00] instead of using a tool on WMCS or a jenkins job [09:54:12] that could be the Zuul server doing the process [09:54:22] but hmm that is an adventurous journey [09:56:25] it is not pluggable (I hcecked) [09:56:33] would require the code to be embedded inside zuul itself bah [09:56:40] anyway that was a side track [09:57:21] (03CR) 10Thiemo Kreuz (WMDE): [WIP] Sniff for undocumented, unchecked @throws annotations (0310 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556654 (owner: 10Awight) [09:59:10] k [10:06:52] Project beta-scap-eqiad build #279097: 04FAILURE in 2 min 21 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279097/ [10:16:39] Project beta-scap-eqiad build #279098: 04STILL FAILING in 2 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279098/ [10:20:11] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201912), and 2 others: Upload zuul_2.5.1-wmf11 to apt.wikimedia.org - https://phabricator.wikimedia.org/T240570 (10jcrespo) a:03jcrespo [10:21:21] 10Diffusion, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201907), 10Operations, and 4 others: Cannot connect to vcs@git-ssh.wikimedia.org (since move from phab1001 to phab1003) - https://phabricator.wikimedia.org/T224677 (10zeljkofilipin) I guess [[ https://wikitech.... [10:23:19] hashar: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#fix-suggestion-info looks relevant [10:23:29] Not sure if that's supported in our version of gerrit yet tho [10:24:41] Meh, looks like a version 3 thing [10:25:47] Oh, never mind. It's here https://gerrit-documentation.storage.googleapis.com/Documentation/2.15/rest-api-changes.html#robot-comment-info [10:26:37] Project beta-scap-eqiad build #279099: 04STILL FAILING in 2 min 5 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279099/ [10:27:25] grr beta-scap fails :-\ [10:28:02] kostajh: yeah but I don't know whether our Gerrit 2.15 has support for it yet [10:29:03] kostajh: https://gerrit.wikimedia.org/r/Documentation/rest-api-changes.html#fix-change [10:29:32] hmm that one seems to automatically fix stuff [10:30:15] paladox would know for sure ;] [10:36:45] Project beta-scap-eqiad build #279100: 04STILL FAILING in 2 min 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279100/ [10:43:07] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201912), and 2 others: Upload zuul_2.5.1-wmf11 to apt.wikimedia.org - https://phabricator.wikimedia.org/T240570 (10jcrespo) @hashar Sorry for the delay, I wasn't aware of... [10:45:32] hashar / paladox any idea what the path is to our API for gerrit? [10:45:40] e.g. gerrit.wikimedia.org/api [10:46:01] Seems like you're supposed to be able to use gerrit.wikimedia.org/gerrit/config/server/info to look that up but that seems disabled [10:46:03] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201912), and 2 others: Upload zuul_2.5.1-wmf11 to apt.wikimedia.org - https://phabricator.wikimedia.org/T240570 (10hashar) 05Open→03Resolved > @hashar Sorry for the de... [10:46:07] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team-TODO (201912), 10Zuul: Zuul cancels all changes when a change is manually merged - https://phabricator.wikimedia.org/T203846 (10hashar) [10:46:40] Project beta-scap-eqiad build #279101: 04STILL FAILING in 2 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279101/ [10:47:50] kostajh: https://gerrit.wikimedia.org/r/changes/?q=is:open+limit:10 [10:48:04] Hmm, so /r [10:48:07] and you want to strip the first line from the response [10:48:13] looks something like ]}]} [10:48:21] yeah [10:48:21] then you get proper json [10:49:07] right. Ok, thx [10:53:25] For a POST request, I keep getting "authentication required", though I'm using --user with curl :\ [10:55:03] :-\ [10:55:13] the api seems to be https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-review [10:55:17] 'POST /changes/{change-id}/revisions/{revision-id}/review' [10:55:23] Yeah, that's what I'm trying [10:55:51] messages being a map of https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#review-input [10:56:12] and you could use robot inputs [10:56:12] robot_comments [10:56:12] [10:56:12] optional [10:56:12] [10:56:13] The robot comments that should be added as a map that maps a file path to a list of RobotCommentInput entities. [10:56:20] I think the UI would let one filter them out later on [10:56:34] Project beta-scap-eqiad build #279102: 04STILL FAILING in 2 min 2 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279102/ [10:56:35] for the authentication over curl, I have no idea :-\ [11:01:12] hm. In PolyGerrit, it looks like it sends X-Gerrit-Auth header. [11:03:42] lol [11:03:52] https://stackoverflow.com/a/58051686 [11:04:05] "Prefix /a to the endpoint URL" [11:04:42] I guess it was right there in the docs https://gerrit.wikimedia.org/r/Documentation/rest-api.html#authentication [11:06:48] Yippee, build fixed! [11:06:48] Project beta-scap-eqiad build #279103: 09FIXED in 2 min 17 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/279103/ [11:08:27] !log deployment-mediawiki07 : removing faulty entry mwdeploy:x:497:498::/var/lib/mwdeploy:/bin/bash in /etc/passwd # T73480 [11:08:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:08:30] T73480: Prevent puppet from creating local user when they are defined in LDAP - https://phabricator.wikimedia.org/T73480 [11:11:04] fixed ;) [11:11:23] kostajh: oh well done :\ I should have known about that /a bah [11:11:24] anyway [11:11:25] nap time [11:11:36] I have had high fever since yesterday evening :-\ [11:11:40] Oh no [11:11:42] Rest well [11:18:19] 10Project-Admins, 10Security-Team: Create Security-Team-Services umbrella project - https://phabricator.wikimedia.org/T240494 (10Aklapper) 05Open→03Stalled Setting #Project-Admins as this is about creating a project tag. Setting stalled as my understanding is that this should not be done yet. Feel free to... [11:34:19] I think our version of gerrit supports that kostajh [11:34:20] (Hashar) [11:34:21] https://gerrit.wikimedia.org/r/Documentation/rest-api-changes.html#robot-comment-info [11:34:31] yep [11:34:36] Thanks for verifying :) [11:34:44] I am not ready to do inline comments yet but will come back to that later [11:43:43] (03PS1) 10Jakob: wikibase/vuejs-components: build new docs on publish [integration/config] - 10https://gerrit.wikimedia.org/r/556998 (https://phabricator.wikimedia.org/T240445) [11:44:19] (03CR) 10Jakob: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/556998 (https://phabricator.wikimedia.org/T240445) (owner: 10Jakob) [11:44:46] (03CR) 10Jakob: Publish wikibase-components storybook on doc.wikimedia.org (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/556359 (https://phabricator.wikimedia.org/T240445) (owner: 10Jakob) [11:58:08] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10Technical-Debt: Clean up unchecked exceptions - https://phabricator.wikimedia.org/T240672 (10awight) [11:59:47] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10Technical-Debt: Clean up unchecked exceptions - https://phabricator.wikimedia.org/T240672 (10awight) [12:10:44] 10Scap, 10Parsoid, 10Core Platform Team Workboards (Clinic Duty Team): scap3 rollback does not depool servers before rolling back - https://phabricator.wikimedia.org/T239616 (10mobrovac) a:05mobrovac→03None [12:36:37] (03PS1) 10Kosta Harlan: jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) [12:37:38] hashar: if you feel better later, perhaps we could coordinate deploying the above patch, because I need to verify that it works with the new bot code [12:44:19] kostajh: yes [12:48:08] (03CR) 10Hashar: ":)" (035 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [12:48:23] kostajh: I am really heading to bed now sorry :/ [12:48:32] but zeljkof should have the approriate rights to deploy the job and reload zuul [12:48:45] we should probably grant you those access rights as well! [12:48:51] have a good afternoon, will fight my fever [12:49:05] Good luck! [12:49:14] hashar: get well soon [12:49:22] kostajh: what patch? [12:49:46] https://gerrit.wikimedia.org/r/557001 ? [12:50:29] it needs some amendemnt first ;) [12:50:42] * hashar vanishes [12:51:26] kostajh: let me know when the patch is ready [12:51:45] it's been a while since I've done anything with zuul, but I should be able to deploy stuff [12:52:52] (03CR) 10Addshore: [C: 03+2] wikibase/vuejs-components: build new docs on publish [integration/config] - 10https://gerrit.wikimedia.org/r/556998 (https://phabricator.wikimedia.org/T240445) (owner: 10Jakob) [12:53:49] (03Merged) 10jenkins-bot: wikibase/vuejs-components: build new docs on publish [integration/config] - 10https://gerrit.wikimedia.org/r/556998 (https://phabricator.wikimedia.org/T240445) (owner: 10Jakob) [12:54:11] !log reload zuul for https://gerrit.wikimedia.org/r/#/c/integration/config/+/556998/ [12:54:13] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:20:06] (03CR) 10Kosta Harlan: jjb: Modify branch name passed to sonar-scanner (035 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [13:20:12] (03PS2) 10Kosta Harlan: jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) [13:21:12] (03CR) 10jerkins-bot: [V: 04-1] jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [13:25:37] (03PS3) 10Kosta Harlan: jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) [13:26:36] (03CR) 10jerkins-bot: [V: 04-1] jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [13:27:54] (03PS4) 10Kosta Harlan: jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) [13:31:44] 10Phabricator, 10Developer-Advocacy (Jan-Mar 2020): Decrease issues with assignee field set for years without progress (aka cookie licking) - https://phabricator.wikimedia.org/T228575 (10Aklapper) [13:36:53] zeljkof: ready when you are [13:39:35] kostajh: ok, just a minute, finishing something... [13:50:41] kostajh: sorry, have to go to lunch, back in 30-60 [13:51:05] zeljkof: ok, ping me when you're back. thanks! [14:17:29] (03CR) 10Gehel: [C: 03+1] "LGTM!" (039 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [14:22:24] (03CR) 10Awight: [WIP] Sniff for undocumented, unchecked @throws annotations (0314 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556654 (owner: 10Awight) [14:27:52] (03CR) 10Kosta Harlan: [C: 03+1] "Great work! LGTM. Per my comments inline I think the commit message could be lightly revised but otherwise this is good to go." (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [14:44:12] (03PS1) 10Hashar: docker: upgrade Doxygen to 1.8.16 [integration/config] - 10https://gerrit.wikimedia.org/r/557033 (https://phabricator.wikimedia.org/T239482) [14:50:59] (03CR) 10Hashar: [C: 03+2] "Build, tried the example and it passes for oojs/ui at least :]" [integration/config] - 10https://gerrit.wikimedia.org/r/557033 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [14:51:48] (03Merged) 10jenkins-bot: docker: upgrade Doxygen to 1.8.16 [integration/config] - 10https://gerrit.wikimedia.org/r/557033 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [14:57:18] zeljkof: not sure if you're back yet, I'll be here for another 40 minutes or so [14:57:35] kostajh: just came back :) [14:57:38] ok, let's see [14:58:02] kostajh: so, I need to merge and deploy this, right? https://gerrit.wikimedia.org/r/c/integration/config/+/557001 [14:58:45] zeljkof: yes please [14:58:56] ok, doing the needful [14:59:41] (03CR) 10Zfilipin: [C: 03+2] jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [15:00:11] zeljkof: when it's live, I can trigger a job to verify that everything works, just let me know [15:00:46] (03Merged) 10jenkins-bot: jjb: Modify branch name passed to sonar-scanner [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [15:01:18] kostajh: will do [15:01:40] wow, ci is fast today [15:03:21] It's live? [15:03:40] uh oh, my notes say I need to install fabric via pip, but looks like new macos doesn't have pip :/ [15:03:43] let me look at the docs [15:04:04] kostajh: no, it's just merged, let me check the docs how to deploy zuul changes, it's been a while [15:04:14] k [15:04:29] https://www.mediawiki.org/wiki/Continuous_integration/Zuul [15:05:07] https://www.mediawiki.org/wiki/Continuous_integration/Zuul#Update_configuration [15:05:37] hi, what's the process to request/create a new phame blog ? looks like my user doesn't have the correct permissions to self-create [15:06:02] godog: I would ask twentyafterfour :) [15:06:07] he might not be awake yet [15:06:17] probably create a task and assign twentyafterfour [15:06:27] godog: I can help with that :) [15:06:45] kostajh: so far so good, fabric is available in homebrew [15:07:00] thanks zeljkof and twentyafterfour ! [15:07:21] twentyafterfour: yup I'd like to create a phame for sre infra foundations [15:07:52] kostajh: :/ looks like fabric from homebrew is for python 3... [15:07:53] twentyafterfour: actually sre infrastructure foundations + sre observability while we're at it [15:08:00] sometimes I hate python 2/3 [15:08:22] godog: you should be able to create a blog now [15:08:56] If not I'll create one for you [15:09:00] or two [15:09:44] twentyafterfour: oohh I can now, thank you very much! I'll bug you again if I run into troubles [15:10:23] twentyafterfour: I have python 2/3 problems :/ do you know how to deploy zuul changes? [15:10:32] docs: https://www.mediawiki.org/wiki/Continuous_integration/Zuul#Update_configuration [15:10:56] I have to go and I can't figure out how to install fabric on my macos :/ [15:11:56] kostajh: sorry, I have to go now, and fabric doesn't work on my machine :/ [15:12:13] I'll ask somebody from releng to deploy the patch later today [15:12:15] sorry about taht [15:12:17] that [15:12:22] zeljkof: I can try it [15:12:29] twentyafterfour: thanks! [15:13:19] Ok, thanks twentyafterfour & zeljkof [15:13:37] twentyafterfour: it's only "fab deploy_zuul" inside integration/config once you have fabric (for python2, apparently) installed [15:25:01] thcipriani hi, around? :) [15:37:39] (03PS1) 10Hashar: jjb: upgrade Doxygen to 1.8.16 [integration/config] - 10https://gerrit.wikimedia.org/r/557046 (https://phabricator.wikimedia.org/T239482) [15:38:11] (03CR) 10Hashar: [C: 03+2] "Jobs updated:" [integration/config] - 10https://gerrit.wikimedia.org/r/557046 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [15:38:59] (03Merged) 10jenkins-bot: jjb: upgrade Doxygen to 1.8.16 [integration/config] - 10https://gerrit.wikimedia.org/r/557046 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [15:40:06] helloo [15:40:17] i am very confused about gerrit permissions these days [15:40:20] i am in gerrit managers [15:40:38] and i created a new repo that inherits rights from 'analytics' group (or containing path?) [15:40:41] https://gerrit.wikimedia.org/r/admin/projects/analytics/hdfs-tools/deploy,access [15:40:51] but, i can't change any access permissions [15:40:58] most annoyingly, i did not want to create the repo with an empty commit [15:41:04] but, i can't push or git review to it [15:41:08] since it doesn't have any commits! [15:42:05] paladox: you helped me before I think, any tips? ^ [15:49:44] ottomata: so you need push rights on that repo? [15:50:20] twentyafterfour: i guess so? but, i used to have more rights than I have, which made things like this much easier [15:50:31] i would expect as repo owner to just be able to change things like that [15:50:45] twentyafterfour: I gotta run in about 10 minutes, if ttps://gerrit.wikimedia.org/r/c/integration/config/+/557001 is going live in the next few minutes I should be able to verify it, otherwise we might want to revert it and come back to it on Monday [15:51:21] (03CR) 10Umherirrender: [C: 03+1] Fix inconsistent sorting in UnsortedUseStatements sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/556670 (owner: 10Thiemo Kreuz (WMDE)) [15:51:47] I mean, it seems pretty low risk regardless of me verifying it but don't want to break stuff [15:52:02] (03PS1) 10Daimona Eaytoy: phpunit deprecations: Handle assertType() as well [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/557051 (https://phabricator.wikimedia.org/T192167) [15:56:24] (03PS2) 10Daimona Eaytoy: phpunit deprecations: Handle assertType() as well [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/557051 (https://phabricator.wikimedia.org/T192167) [16:00:34] (03PS3) 10Daimona Eaytoy: phpunit deprecations: Handle assertType() as well [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/557051 (https://phabricator.wikimedia.org/T192167) [16:03:49] paladox: I'm around now for a bit before my next meeting [16:05:29] (03CR) 10jerkins-bot: [V: 04-1] phpunit deprecations: Handle assertType() as well [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/557051 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [16:05:29] Project mediawiki-core-doxygen-docker build #12098: 04FAILURE in 1 min 13 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12098/ [16:07:00] ottomata: you should have access to edit refs/meta/config for that repo. One strange thing that could be tripping you up: the new UI is read-only for permissions (i.e., this page: https://gerrit.wikimedia.org/r/admin/projects/analytics/hdfs-tools/deploy,access ) if you switch to the old UI, I believe, you should be able to edit permissions for that repo [16:07:19] OHHH RIGHT [16:07:34] THANK YPOU [16:09:46] kostajh: Sorry I guess I probably missed you... :( [16:10:42] sure thing, that one bites me with some frequency :) [16:12:22] thcipriani: should I go ahead and deploy https://gerrit.wikimedia.org/r/c/integration/config/+/557001 without costa to verify or should I revert? it is friday but the change looks pretty harmless [16:12:34] without kosta I mean :-/ [16:13:05] * thcipriani reads [16:15:33] twentyafterfour: looks harmless to me, if kostaj.h needed that change then it looks fine. I'd say deploy and re-run the last successful job to make sure nothing broke [16:16:03] thcipriani: cool, will do [16:16:27] oh, plus looks like it's merged :) [16:16:31] right [16:23:46] I can try to take a peek after its deployed. If it works right, then we should see messages like this https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519448#message-091f5801faaaa8b881da1acb06fc89f1e787d1fd [16:24:20] Rather than the previous style of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519448#message-a31e01836246ddb1c8f51ae7dea86ad688f3c5a3 [16:28:08] !log deployed codehealth jenkins jobs [16:28:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:28:20] kostajh: it's deployed [16:29:43] twentyafterfour: thx, running a job [16:38:43] kostajh: sorry I am just now deploying the zuul layout change [16:39:06] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/c/integration/config/+/557001 [16:39:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:39:46] fabric was giving me trouble for a bit [16:40:10] (03CR) 1020after4: "This has been deployed to jenkins and zuul" [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [17:04:58] Project mediawiki-core-doxygen-docker build #12099: 04STILL FAILING in 54 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12099/ [17:21:35] (03PS5) 10Mstyles: dockerfiles: Add Java sonarcloud implementation [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) [17:24:18] (03PS4) 10Daimona Eaytoy: phpunit deprecations: Handle assertType() as well [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/557051 (https://phabricator.wikimedia.org/T192167) [17:29:50] (03CR) 10Mstyles: "This change is ready for review." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [17:31:25] (03CR) 10Mstyles: dockerfiles: Add Java sonarcloud implementation (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [17:57:59] (03PS1) 10Hashar: docker: add php extensions to doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/557081 (https://phabricator.wikimedia.org/T239482) [17:59:26] (03CR) 10Hashar: [C: 03+2] docker: add php extensions to doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/557081 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [18:00:15] (03Merged) 10jenkins-bot: docker: add php extensions to doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/557081 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [18:01:01] (03PS1) 10Hashar: jjb: bump to doxygen:0.6.1 for php extensions [integration/config] - 10https://gerrit.wikimedia.org/r/557082 (https://phabricator.wikimedia.org/T239482) [18:04:22] !log Successfully tagged docker-registry.discovery.wmnet/releng/doxygen:0.6.1 [18:04:24] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:10:40] Yippee, build fixed! [18:10:40] Project mediawiki-core-doxygen-docker build #12100: 09FIXED in 6 min 35 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12100/ [18:32:12] (03CR) 10Hashar: [C: 03+2] jjb: bump to doxygen:0.6.1 for php extensions [integration/config] - 10https://gerrit.wikimedia.org/r/557082 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [18:33:13] (03Merged) 10jenkins-bot: jjb: bump to doxygen:0.6.1 for php extensions [integration/config] - 10https://gerrit.wikimedia.org/r/557082 (https://phabricator.wikimedia.org/T239482) (owner: 10Hashar) [20:09:08] hello again! my 2FA authenitcator app was deleted (had to get phone repaired and wiped it in the process) [20:09:24] i restored from backup, but i guess registered 2FA hashes(?) are not saved [20:09:30] so, i can't log into horizon [20:09:37] (and will probably eventually be signed out of wikitech) [20:09:58] i could disable 2FA at https://wikitech.wikimedia.org/wiki/Special:Manage_Two-factor_authentication [20:10:12] but, to do so I need...to authenticate with my old number. [20:10:31] i have scratch tokens... [20:10:40] but i'm not prompted to use them [20:12:05] oh maybe i can just use one of them to disable? [20:12:18] nope. [20:15:18] ottomata: https://wikitech.wikimedia.org/wiki/Password_reset#For_users [20:15:22] (03PS1) 10Hashar: Use Zuul mutex for mediawiki-core-doxygen-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557102 [20:15:38] yar ok [20:15:52] (03CR) 10Hashar: [C: 03+2] Use Zuul mutex for mediawiki-core-doxygen-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557102 (owner: 10Hashar) [20:16:16] thank you [20:16:47] (03Merged) 10jenkins-bot: Use Zuul mutex for mediawiki-core-doxygen-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557102 (owner: 10Hashar) [20:18:38] !log Reloaded Zuul for "Use Zuul mutex for mediawiki-core-doxygen-docker-publish" https://gerrit.wikimedia.org/r/#/c/integration/config/+/557102/ [20:18:40] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:19:44] !log Regenerating MediaWiki core doxygen (and jsduck doc) # T218233 [20:19:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:19:47] T218233: Doxygen search.php no longer works on doc.wikimedia.org - https://phabricator.wikimedia.org/T218233 [20:31:37] (03PS1) 10Hashar: Use Zuul mutex for mediawiki-core-jsduck-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557108 [20:32:10] (03CR) 10Hashar: [C: 03+2] Use Zuul mutex for mediawiki-core-jsduck-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557108 (owner: 10Hashar) [20:33:08] (03CR) 10jerkins-bot: [V: 04-1] Use Zuul mutex for mediawiki-core-jsduck-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557108 (owner: 10Hashar) [20:35:05] (03PS2) 10Hashar: Use Zuul mutex for mediawiki-core-jsduck-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557108 [20:40:35] (03CR) 10Hashar: [C: 03+2] Use Zuul mutex for mediawiki-core-jsduck-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557108 (owner: 10Hashar) [20:41:36] (03Merged) 10jenkins-bot: Use Zuul mutex for mediawiki-core-jsduck-docker-publish [integration/config] - 10https://gerrit.wikimedia.org/r/557108 (owner: 10Hashar) [21:04:10] that is all for this week [21:29:54] * paladox got file uploading in the browser to work with gerrit! [21:38:03] thcipriani: yt? scap is being very strange on this new repo i just added [21:38:09] seems fine on deploy sever [21:38:13] server* [21:38:29] but deploy-local is failing on target [21:38:38] because it is trying to clone from a bad git url [21:38:41] the repo name is [21:38:45] analytics/hdfs-tools/deploy [21:38:47] but it is using [21:38:53] git clone http://deploy1001.eqiad.wmnet/hdfs-tools-deploy/.git [21:39:13] i think it should be [21:39:16] http://deploy1001.eqiad.wmnet/analytics/hdfs-tools/deploy/.git [21:47:44] AH my scap.cfg! [21:47:46] weird [21:48:40] NM [21:52:28] heh, glad you got it figured out :) [21:53:36] thcipriani still around? :) [21:54:48] paladox: sure [22:19:03] (03CR) 10Kosta Harlan: jjb: Modify branch name passed to sonar-scanner (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/557001 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [22:24:15] (03PS1) 10Kosta Harlan: jjb: Add back codehealth messages and adjust success/failure pattern [integration/config] - 10https://gerrit.wikimedia.org/r/557138 (https://phabricator.wikimedia.org/T217008) [22:25:13] (03CR) 10jerkins-bot: [V: 04-1] jjb: Add back codehealth messages and adjust success/failure pattern [integration/config] - 10https://gerrit.wikimedia.org/r/557138 (https://phabricator.wikimedia.org/T217008) (owner: 10Kosta Harlan) [22:26:10] (03PS2) 10Kosta Harlan: jjb: Add back codehealth messages and adjust success/failure pattern [integration/config] - 10https://gerrit.wikimedia.org/r/557138 (https://phabricator.wikimedia.org/T217008)