[00:21:51] 10Release-Engineering-Team (Code Health), 10Code-Stewardship-Reviews, 10MediaWiki-extensions-FlaggedRevs: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Bawolff) >>! In T185664#5742901, @DannyS712 wrote: > The task specifies that there are no security bugs - T234736 is a... [00:23:35] 10Release-Engineering-Team (Code Health), 10Code-Stewardship-Reviews, 10MediaWiki-extensions-FlaggedRevs: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10DannyS712) [01:04:26] 10Release-Engineering-Team (Code Health), 10Code-Stewardship-Reviews, 10MediaWiki-extensions-FlaggedRevs: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Ladsgroup) >>! In T185664#5742901, @DannyS712 wrote: > The task specifies that there are no security bugs - T234736 is... [02:37:36] 10Scap, 10MediaWiki-Internationalization, 10Performance-Team (Radar): Use static php array files for l10n cache instead of CDB - https://phabricator.wikimedia.org/T99740 (10ori) The work needed to support this in scap turns out to be relatively straightforward. Instead of syncing .cdb files, scap converts t... [05:08:21] 10Release-Engineering-Team (Code Health), 10Code-Stewardship-Reviews, 10MediaWiki-extensions-FlaggedRevs: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Tgr) And it's very likely caused by the site configuration bug mentioned above, not by a bug in FlaggedRevs. [06:42:11] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-09 is CRITICAL: (Service Check Timed Out) [06:52:02] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-09 is OK: HTTP OK: HTTP/1.1 200 OK - 49198 bytes in 0.548 second response time [08:11:15] (03CR) 10Jforrester: [C: 03+2] Archive ImageMetrics extension [integration/config] - 10https://gerrit.wikimedia.org/r/557657 (https://phabricator.wikimedia.org/T240799) (owner: 10Zoranzoki21) [08:12:09] (03Merged) 10jenkins-bot: Archive ImageMetrics extension [integration/config] - 10https://gerrit.wikimedia.org/r/557657 (https://phabricator.wikimedia.org/T240799) (owner: 10Zoranzoki21) [08:32:15] (03CR) 10Hashar: [C: 03+2] Adjust pytest parameter for "qa" [integration/config] - 10https://gerrit.wikimedia.org/r/557659 (owner: 10Hashar) [08:32:37] (03CR) 10Awight: [WIP] Knob to forbid any unchecked exception annotations (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/557253 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [08:33:09] (03Merged) 10jenkins-bot: Adjust pytest parameter for "qa" [integration/config] - 10https://gerrit.wikimedia.org/r/557659 (owner: 10Hashar) [08:37:25] (03PS1) 10Hashar: Fix pytest junit parameter [integration/config] - 10https://gerrit.wikimedia.org/r/557822 [08:37:34] (03CR) 10jerkins-bot: [V: 04-1] Fix pytest junit parameter [integration/config] - 10https://gerrit.wikimedia.org/r/557822 (owner: 10Hashar) [08:38:05] grbmblbl [08:38:48] (03PS2) 10Hashar: Fix pytest junit parameter [integration/config] - 10https://gerrit.wikimedia.org/r/557822 [08:38:58] (03CR) 10Hashar: [C: 03+2] Fix pytest junit parameter [integration/config] - 10https://gerrit.wikimedia.org/r/557822 (owner: 10Hashar) [08:39:55] (03Merged) 10jenkins-bot: Fix pytest junit parameter [integration/config] - 10https://gerrit.wikimedia.org/r/557822 (owner: 10Hashar) [08:45:41] (03PS1) 10Hashar: Revert pytest integration [integration/config] - 10https://gerrit.wikimedia.org/r/557825 [08:46:18] (03CR) 10Hashar: [C: 03+2] "That caused a lot of tests to disappear completely :-\\\\" [integration/config] - 10https://gerrit.wikimedia.org/r/557825 (owner: 10Hashar) [08:47:09] (03Merged) 10jenkins-bot: Revert pytest integration [integration/config] - 10https://gerrit.wikimedia.org/r/557825 (owner: 10Hashar) [09:03:08] Project mediawiki-core-doxygen-docker build #12165: 15ABORTED in 1 min 44 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12165/ [09:05:10] Project mediawiki-core-doxygen-docker build #12166: 15ABORTED in 1 min 6 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12166/ [09:07:52] 10Phabricator (Upstream), 10Phragile, 10TCB-Team, 10Upstream: [Phabricator] Expose a project's removed tasks through Conduit - https://phabricator.wikimedia.org/T100657 (10Aklapper) [09:20:39] Project mediawiki-core-doxygen-docker build #12168: 15ABORTED in 52 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12168/ [09:25:52] Project mediawiki-core-doxygen-docker build #12169: 04FAILURE in 53 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12169/ [09:26:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MediaWiki-Documentation, and 3 others: Doxygen search.php no longer works on doc.wikimedia.org - https://phabricator.wikimedia.org/T218233 (10hashar) I have nuked the build histor... [09:26:56] Project mediawiki-core-doxygen-docker build #12170: 04STILL FAILING in 1 min 2 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12170/ [09:27:52] Project mediawiki-core-doxygen-docker build #12171: 04STILL FAILING in 55 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12171/ [09:34:50] Yippee, build fixed! [09:34:51] Project mediawiki-core-doxygen-docker build #12172: 09FIXED in 6 min 56 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/12172/ [09:34:56] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MediaWiki-Documentation, and 3 others: Doxygen search.php no longer works on doc.wikimedia.org - https://phabricator.wikimedia.org/T218233 (10hashar) The git plugin no more has an... [09:35:54] !log doc1001: sudo -u doc-uploader rm -fR /srv/docroot/org/wikimedia/doc/DOCKER-mediawiki-core [09:35:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:41:10] hashar: I assume that was you re-trigger doxygen-publish on 545091? I panicked thinking that hadn't landed two months ago. :-) [09:41:18] yeah [09:41:18] ;) [09:41:24] Cool. [09:41:33] James_F: rebuilding all docs for the Doxygen 1.8.16 update :\ [09:42:02] * James_F nods. [09:42:18] * James_F applauds. [09:47:44] and I am now wondering who is in charge of replacing old branches with tags when a legacy release is EOL [09:47:45] ;D [09:48:01] we also do not purge old docs [09:49:52] Yeah. Formerly, Chad did that, I think. [09:49:54] But… [10:08:01] maybe we should add that to whatever process we have to phase out EOL relesaes [10:08:05] if we have such a thing [10:18:29] "Process"? You must be new here. ;-) [10:20:12] (03CR) 10Jforrester: "Meh. :-(" [integration/config] - 10https://gerrit.wikimedia.org/r/557825 (owner: 10Hashar) [10:50:38] James_F: ;] [10:50:55] James_F: ah yeah those pytest changes :(\\\\\\\\\\ [10:51:41] After I bugged l.egoktm to fix them so I could merge them. :-( [11:45:36] hashar: 557799,2 is stuck in test waiting for wmf-quibble-vendor-mysql-php72-docker which presumably got lost; how can we fix that? [11:45:52] Oh, never mind, new patchset, that works. ;-) [11:51:50] 10Project-Admins: Create project for sonarqubebot - https://phabricator.wikimedia.org/T240848 (10kostajh) [11:53:09] 10Project-Admins: Create component project for sonarqubebot - https://phabricator.wikimedia.org/T240848 (10kostajh) [11:53:39] James_F: yeah I screwed it up [11:53:41] will restart it [11:53:47] It's fine now. [11:53:51] Nothing stuck any more. [11:54:03] Not sure if there's further needs for restarts? [11:54:09] there is still a blocked change for homer [11:54:18] zuul server did trigger the gearman function [11:54:25] but when I have reloaded Jenkins the job got lost [11:54:30] Oh, right, in G&S. [11:54:32] but Zuul stills consider the job to be running [11:54:33] * James_F nods. [11:54:48] I tried to clear out but cant :-\ [11:54:58] And that's in SRE-land so I can't re-start the C+2 run. [11:57:15] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Patch-For-Review: Investigate gerrit session expiration - https://phabricator.wikimedia.org/T222472 (10LarsWirzenius) I'm still logged in. I've now been logged in for a month and a day. I suggest we can close th... [11:57:37] flushed [11:57:39] works again now [11:57:57] James_F: so even if you CR+2 again the patch, Zuul would notice it is already in the queue and will just skip it entirely [11:58:05] Ah, cool. [11:58:05] the only fix available would be to send a new patchset and +2 it [11:58:07] :\ [11:58:21] Yeah, that was my plan (trivial change to commit message). [12:13:19] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Patch-For-Review: Investigate gerrit session expiration - https://phabricator.wikimedia.org/T222472 (10Jdforrester-WMF) 05Open→03Resolved Agreed. [12:15:43] 10Project-Admins: Create component project for sonarqubebot - https://phabricator.wikimedia.org/T240848 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project has been created: #sonarqubebot @kostajh: Please add a description to the project at https://phabricator.wikimedia.org/project/edit/4... [12:27:40] 10Phabricator, 10Mobile: URLs for "Related Gerrit Patches" are cut off on mobile and not shown - https://phabricator.wikimedia.org/T240407 (10Zoranzoki21) >>! In T240407#5731420, @Aklapper wrote: > It's a table, as it is tabular data. :) Code is in https://phabricator.wikimedia.org/rPHEX7a526af8b46c0b9a0aacd32... [12:38:44] PROBLEM - Host deployment-zookeeper02 is DOWN: CRITICAL - Host Unreachable (172.16.5.55) [12:45:59] 10Project-Admins: Create component project for sonarqubebot - https://phabricator.wikimedia.org/T240848 (10kostajh) Thanks @Aklapper! [12:57:30] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MediaWiki-Documentation, and 3 others: Doxygen search.php no longer works on doc.wikimedia.org - https://phabricator.wikimedia.org/T218233 (10hashar) I have retriggered all builds... [12:58:12] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MediaWiki-Documentation, and 3 others: Doxygen search.php no longer works on doc.wikimedia.org - https://phabricator.wikimedia.org/T218233 (10hashar) 05Open→03Resolved a:03ha... [13:27:14] (03PS1) 10Lucas Werkmeister (WMDE): Whitelist a few more HTML tags for i18n messages [integration/config] - 10https://gerrit.wikimedia.org/r/558040 [13:27:33] (03PS2) 10Lucas Werkmeister (WMDE): Whitelist a few more HTML tags for i18n messages [integration/config] - 10https://gerrit.wikimedia.org/r/558040 [13:29:12] (03CR) 10Lucas Werkmeister (WMDE): "I don’t know where the original list of tag names came from, so I just added the new ones at the end. Let me know if they should be insert" [integration/config] - 10https://gerrit.wikimedia.org/r/558040 (owner: 10Lucas Werkmeister (WMDE)) [14:17:16] 10Release-Engineering-Team (Kanban): Consider and evaluate possible new CI tooling - https://phabricator.wikimedia.org/T217325 (10zeljkofilipin) [14:17:24] 10Release-Engineering-Team (Kanban), 10Release-Engineering-Team-TODO (201912): Create a threat model for new CI - https://phabricator.wikimedia.org/T240679 (10zeljkofilipin) [14:32:06] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team (Radar): Use static php array files for l10n cache instead of CDB - https://phabricator.wikimedia.org/T99740 (10Jdforrester-WMF) [14:34:54] <_joe_> I've never apologized about using blubberoid as my guinea pig for the helm charts improvements [14:35:43] 10Phabricator: Rename Phabricator account from "A2093064" to "Xiplus" - https://phabricator.wikimedia.org/T240859 (10A2093064) [14:38:42] _joe_: If it works, it works. [14:39:00] <_joe_> James_F: allegedly [14:39:25] Fair. :-) [14:41:02] 10Phabricator: Can't do shallow clone from phabricator - https://phabricator.wikimedia.org/T240862 (10Ladsgroup) [14:41:49] 10Phabricator: Rename Phabricator account from "A2093064" to "Xiplus" - https://phabricator.wikimedia.org/T240859 (10A2093064) [15:01:48] 10Phabricator, 10Release-Engineering-Team-TODO, 10Dumps-Generation, 10Phlogiston: Phlogiston dump is missing projects - https://phabricator.wikimedia.org/T236507 (10mmodell) @ArielGlenn: I suspect it might be a pain. It's pretty old code not written with python3 in mind, however, it might not be too bad, i... [15:05:29] 10Phabricator: Rename Phabricator account from "A2093064" to "Xiplus" - https://phabricator.wikimedia.org/T240859 (10Aklapper) 05Open→03Resolved a:03Aklapper [15:33:10] 10Phabricator: No results for specific string in Global Phab Search, while Advanced Search lists expected results (due to ElasticSearch for Global Search vs Ferret for Maniphest Search)? - https://phabricator.wikimedia.org/T224082 (10mmodell) [15:33:12] 10Phabricator (Search), 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (201912), 10User-MModell: Test out the Phabricator 'ferrit' search engine. - https://phabricator.wikimedia.org/T230787 (10mmodell) [15:40:26] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO, 10Wikimedia-Logstash, 10observability: logstash-beta.wmflabs.org does not receive any mediawiki events - https://phabricator.wikimedia.org/T233134 (10herron) Yes, we will need a second logstash stretch instance, and to migrate the Kafka broker... [16:09:00] 10Phabricator, 10Release-Engineering-Team-TODO, 10Dumps-Generation, 10Phlogiston: Phlogiston dump is missing projects - https://phabricator.wikimedia.org/T236507 (10mmodell) 05Open→03Resolved This is fixed in {b3b4a8587022}. I ran the new code manually and confirmed that the dump now correctly includes... [16:18:12] 10Gerrit: Cannot log into Gerrit using Brave Browser - https://phabricator.wikimedia.org/T238569 (10Ottomata) Similar problem with wikitech.wikimedia.org. When trying to log in using Brave, I get: ` There seems to be a problem with your login session; this action has been canceled as a precaution against sessi... [16:19:45] (03PS1) 10Alcarazzam: Add alcarazzam to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/558111 [16:19:50] 10Release-Engineering-Team (Pipeline), 10Operations, 10Release Pipeline, 10serviceops, 10Goal: Self-service Deployment Pipeline - https://phabricator.wikimedia.org/T228676 (10akosiaris) [16:20:00] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Operations, 10Release Pipeline, and 3 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10akosiaris) [16:23:40] (03CR) 10Urbanecm: [C: 03+1] "lgtm" [integration/config] - 10https://gerrit.wikimedia.org/r/558111 (owner: 10Alcarazzam) [16:25:55] 10Phabricator (Search): Searching open tasks found closed tasks - https://phabricator.wikimedia.org/T157783 (10MusikAnimal) 05Resolved→03Open Similar issue with https://phabricator.wikimedia.org/maniphest/query/0.3KI7G.FYrr/#R. T131065 shows up there when it shouldn't. However as Aklapper reports, it correct... [16:26:39] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201912), 10Jenkins: Upgrade Jenkins to 2.190.3 - https://phabricator.wikimedia.org/T239985 (10hashar) 05Open→03Resolved a:03brennen Paired the upgrade with @brennen . We had a... [16:34:47] hi! double checking that it's expected that all oozie jobs have been stopped. I'm assuming they need to be re-submitted? [16:34:52] doh, wrong room.. [16:37:40] 10Phabricator (Search): Searching open tasks found closed tasks - https://phabricator.wikimedia.org/T157783 (10Ammarpad) I am only seeing two 'Open' tasks at https://phabricator.wikimedia.org/maniphest/query/0.3KI7G.FYrr/#R ; that's `T131065` is not the result. Maybe it was reindexed because you mention it her... [16:41:56] 10Phabricator (Search): Searching open tasks found closed tasks - https://phabricator.wikimedia.org/T157783 (10MusikAnimal) 05Open→03Resolved Sorry, that first link was supposed to be https://phabricator.wikimedia.org/search/query/0LHQNrVX13XI/#R (not maniphest/query). However T131065 isn't showing up there... [16:50:29] 10Release-Engineering-Team (Code Health), 10Code-Stewardship-Reviews, 10MediaWiki-extensions-FlaggedRevs: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Ladsgroup) >>! In T185664#5700826, @Tgr wrote: > FWIW neither of the current issues ({T237191} and {T234743}) are probl... [16:56:40] (03CR) 10Hashar: [C: 03+2] Add alcarazzam to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/558111 (owner: 10Alcarazzam) [16:57:14] (03CR) 10Hashar: "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/557657 (https://phabricator.wikimedia.org/T240799) (owner: 10Zoranzoki21) [16:57:38] (03Merged) 10jenkins-bot: Add alcarazzam to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/558111 (owner: 10Alcarazzam) [17:02:45] (03PS1) 10Hashar: Split Selenium jobs on Wikibase repositories [integration/config] - 10https://gerrit.wikimedia.org/r/558126 (https://phabricator.wikimedia.org/T232759) [17:08:55] (03CR) 10Hashar: [C: 03+2] Split Selenium jobs on Wikibase repositories [integration/config] - 10https://gerrit.wikimedia.org/r/558126 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [17:10:04] (03Merged) 10jenkins-bot: Split Selenium jobs on Wikibase repositories [integration/config] - 10https://gerrit.wikimedia.org/r/558126 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [17:11:20] that should speed up Wikibase a bit [17:11:25] err [17:11:27] Wikibase* repos [17:16:23] 10Beta-Cluster-Infrastructure: Migrate deployment-zookeeper02 from jessie to stretch - https://phabricator.wikimedia.org/T222461 (10elukey) I killed the instance, wanted to create another m1.small with the same name but with stretch and there are some issues: 1) I don't see m1.small anymore but only qcow2 2) I... [17:19:10] 10Phabricator, 10Security-Team: Set Security Issue Task Type as default for Security reporting - https://phabricator.wikimedia.org/T240605 (10chasemp) [17:19:21] 10Phabricator, 10Security-Team: Create generic security-team request for service intake mechanism - https://phabricator.wikimedia.org/T240492 (10chasemp) >>! In T240492#5738444, @Aklapper wrote: > (Let's please add #Phabricator to Phab configuration tasks (e.g. Phab forms) so they can be ever again in the futu... [17:29:28] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10SRE-Access-Requests: Grant "contint-roots" and "releasers-mediawiki" to user brennen - https://phabricator.wikimedia.org/T240382 (10jcrespo) I mistakenly assumed I needed SRE agreement because of root, was reminded I... [17:46:04] 10Phabricator, 10Wikibase-Containers, 10Wikidata: Can't do shallow clone from phabricator - https://phabricator.wikimedia.org/T240862 (10Addshore) [17:46:32] 10Phabricator, 10Wikibase-Containers, 10Wikidata: Can't do shallow clone from phabricator - https://phabricator.wikimedia.org/T240862 (10Addshore) p:05Triage→03Normal [17:52:11] 10Release-Engineering-Team (Code Health), 10Code-Stewardship-Reviews, 10MediaWiki-extensions-FlaggedRevs: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Tgr) FlaggedRevs certainly is too flexible for its own good, but those bugs are not even related to FlaggedRevs configu... [17:52:40] 10Release-Engineering-Team (Kanban), 10Release-Engineering-Team-TODO (201912): Create a threat model for new CI - https://phabricator.wikimedia.org/T240679 (10dduvall) For CI systems that run on k8s, this might be useful: https://github.com/kubernetes/community/blob/master/wg-security-audit/findings/Kubernete... [18:04:54] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Performance-Team (Radar): scap should be LCStore-agnostic - https://phabricator.wikimedia.org/T105683 (10Krinkle) Below are ideas from the parent task about implementing transition stage in Scap. >>! In T99740#516... [18:05:13] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Performance-Team (Radar): Add Scap support for static-array format of LCStore - https://phabricator.wikimedia.org/T105683 (10Krinkle) [18:05:30] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team (Radar): Use static php array files for l10n cache instead of CDB - https://phabricator.wikimedia.org/T99740 (10Krinkle) @ori Thanks, I've updated T105683 with your proposal. [18:16:10] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10SRE-Access-Requests, 10Patch-For-Review: Grant "contint-roots" and "releasers-mediawiki" to user brennen - https://phabricator.wikimedia.org/T240382 (10jcrespo) @brennen Change is deployed, please allow up to 30 min... [18:50:39] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Patch-For-Review, 10User-zeljkofilipin: Upgrade webdriverio to version 5 for all repositories - https://phabricator.wikimedia.org/T234314 (10Ephemeralwaves) >>! In T234314#5737629, @gerritbot wrote: > Change 556810 had a related patch set uploaded (... [19:08:17] If anyone knows how to properly set +1 on a review in gerrit via the API, please let me know. https://gerrit.wikimedia.org/r/c/labs/tools/sonarqubebot/+/558032 doesn't seem to have worked. [19:25:30] kostajh: lego.ktm has done that before iirc [20:03:09] (03PS3) 10Clarakosi: Update Quibble to use api-testing npm package [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) [20:03:57] (03CR) 10jerkins-bot: [V: 04-1] Update Quibble to use api-testing npm package [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [20:12:55] p858snake: thanks. I see this example https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/6e518bef60720c4f055c81fe20534f779a564722/scap/plugins/swat.py#89 and it seems pretty similar to what I'm doing [20:14:27] (03PS4) 10Clarakosi: Update Quibble to use api-testing npm package [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) [20:25:00] (03CR) 10Clarakosi: "So I tried building it locally and running my version of quibble using the .env file as shown here: https://doc.wikimedia.org/quibble/#rep" (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [20:26:15] clarakosi: what command did you use to run quibble? [20:32:43] kostajh: I'm using a bash file that has the following [20:32:54] https://www.irccloud.com/pastebin/41RNdCLk/ [20:33:53] and my .env file for the spamblocklist [20:34:14] https://www.irccloud.com/pastebin/Y7sQr1Wm/ [20:35:20] Hm, you might need more stuff in the .env file [20:36:09] I do? [20:36:16] I'm looking at one I have now, it has also: ZUUL_COMMIT, ZUUL_CHANGES, EXT_DEPENDENCIES [20:36:33] ok let me try that [20:36:56] Also, maybe double check that your .env file is being loaded in the container? [20:37:25] I don't see why it wouldn't be, but worth checking [20:37:26] It is ... I noticed it when I did spamblacklist [20:45:08] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10mmodell) >>! In T191182#5096822, @hashar wrote: > We could do something similar with Gerrit. Roughly: > > * cr... [20:50:26] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Paladox) >>! In T191182#5745897, @mmodell wrote: >>>! In T191182#5096822, @hashar wrote: >> We could do somethi... [20:52:18] kostajh: update: It's still only pulling down master [20:52:35] :\ [20:55:46] yeah :/ [20:57:34] clarakosi: have you compared your output with https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/34783/consoleFull? [20:58:05] no but good idea! [20:58:35] clarakosi: and the issue specifically is that the change to SpamBlacklist is not getting checked out? [20:59:52] kostajh: yup! It didn't work either when I tried to checkout the change for my patch on core [21:01:04] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10mmodell) >>! In T191182#5745911, @Paladox wrote: > That's been improved in newer gerrit releases. Only slightly. [21:03:45] clarakosi: ZUUL_URL might be the issue too [21:04:19] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Paladox) https://phabzilla.wmflabs.org/file/data/fhrpawbwgmwsrxuludwl/PHID-FILE-43hi2yjjgqyuytqnvf7x/Screenshot... [21:05:20] kostajh: I currently have it set to git://contint1001.wikimedia.org ... should it be something else? [21:08:26] I think `ZUUL_URL=https://gerrit.wikimedia.org/r/p/` might work a lot faster, IIRC [21:11:32] 10Deployments, 10Release-Engineering-Team, 10serviceops, 10Performance-Team (Radar): Cache of wmf-config/InitialiseSettings often 1 step behind - https://phabricator.wikimedia.org/T236104 (10thcipriani) >>! In T236104#5599672, @CDanis wrote: >>>! In T236104#5595508, @Jdforrester-WMF wrote: >> How reliable... [21:12:16] But it shouldn't break things to not use htat [21:13:05] its a lot faster! [21:13:09] But still same issue [21:15:50] 10Project-Admins, 10Security-Team: Create Security-Team-Services umbrella project - https://phabricator.wikimedia.org/T240494 (10chasemp) thanks @Aklapper with the completion of {T240902} we are ready for this so I'm going to pull the trigger [21:21:21] 10Project-Admins, 10Security-Team: Create Security-Team-Services umbrella project - https://phabricator.wikimedia.org/T240494 (10chasemp) 05Stalled→03Open https://phabricator.wikimedia.org/project/view/4420/ [21:36:02] hashar or thcipriani might have a better idea about what we're missing. [21:51:21] oh ok! thcipriani are you around? otherwise I'll bug hashar tomorrow morning [21:51:48] I am around, what's up? [21:51:53] * thcipriani reads scrollback [21:53:33] AFAIK, we don't allow machines outside the integration cluster to access the zuul git server [21:53:36] so that might explain it [21:53:48] ohhh is there a way to test it locally? [21:54:15] 10Project-Admins, 10Security-Team: Create Security-Team-Services umbrella project - https://phabricator.wikimedia.org/T240494 (10chasemp) 05Open→03Resolved a:03chasemp https://phabricator.wikimedia.org/project/subprojects/4420/ to match [[ https://www.mediawiki.org/w/index.php?title=Wikimedia_Security_Te... [21:54:48] thcipriani: btw this is in relation to: https://gerrit.wikimedia.org/r/c/integration/quibble/+/554571 [21:57:00] this *might* work https://phabricator.wikimedia.org/P9885 [21:59:08] 10Release-Engineering-Team, 10Operations, 10serviceops, 10Performance-Team (Radar), and 2 others: PHP Fatal error: The UdpSocket to 127.0.0.1:10514 has been closed (from Monolog/SyslogUdp on mwdebug1002) - https://phabricator.wikimedia.org/T214734 (10Urbanecm) Seems to happen w/ mwdebug1001 too? https://l... [22:01:01] 10Release-Engineering-Team, 10Operations, 10serviceops, 10Performance-Team (Radar), and 2 others: All debug hosts give (likely spurious) message: PHP Fatal error: The UdpSocket to 127.0.0.1:10514 has been closed (from Monolog/SyslogUdp) - https://phabricator.wikimedia.org/T214734 (10CDanis) [22:04:37] thcipriani: it works! \o/ [22:04:47] was it just changing ZUUL_REF [22:04:49] ? [22:06:23] yeah, ZUUL_REF and ZUUL_URL, ype [22:06:25] *ye[p [22:06:33] blerg. *yep :) [22:08:40] hahaha [22:08:44] and one more question [22:09:50] let's say I add a `Depends-On` to this commit. Would it also include the other changes [22:09:58] quibble that is [22:13:48] hrm, I'm not honestly sure if that's a feature of zuul-merger or if that's a feature of zuul-cloner. [22:14:04] if it's a feature of zuul-cloner, then it *would* work, if it's a feature of zuul-merger then it wouldn't [22:14:08] I'd have to test [22:14:11] I don't know offhand [22:15:45] ahh ok. I'll test it out tomorrow [22:22:03] (03CR) 10Krinkle: "If I understand correctly, the current patch means that 'mixed' is considered as 'mixed|null' but does not enforce either form. It just me" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/498472 (https://phabricator.wikimedia.org/T218324) (owner: 10Legoktm) [22:29:34] 10Gerrit: Cannot log into Gerrit using Brave Browser - https://phabricator.wikimedia.org/T238569 (10hashar) hi, then I guess it is an issue with Brave? You might want to try against Gerrit while tailing the Apache log files and filtering by your IP. That is on gerrit1001.wikimedia.org: ` name=/var/log/apache2 g... [22:52:53] (03PS1) 10Ladsgroup: Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) [22:56:14] (03CR) 10jerkins-bot: [V: 04-1] Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [23:06:31] 10Release-Engineering-Team-TODO (201912): Write Pipelinelib tutorial - https://phabricator.wikimedia.org/T240913 (10dduvall) [23:09:27] 10Release-Engineering-Team-TODO (201912), 10Release Pipeline: Write pipelinelib user guide - https://phabricator.wikimedia.org/T240914 (10dduvall) [23:09:47] 10Release-Engineering-Team-TODO (201912), 10Release Pipeline: Write Pipelinelib tutorial - https://phabricator.wikimedia.org/T240913 (10dduvall) [23:11:55] (03CR) 10Dduvall: [C: 03+2] Remove experimental warning from README [blubber] - 10https://gerrit.wikimedia.org/r/549900 (owner: 10Dduvall) [23:16:00] (03Merged) 10jenkins-bot: Remove experimental warning from README [blubber] - 10https://gerrit.wikimedia.org/r/549900 (owner: 10Dduvall) [23:25:44] (03CR) 10Dduvall: Exclude binaries from blubber images (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/555572 (owner: 10Dduvall) [23:34:38] (03PS2) 10Dduvall: pipeline: Exclude binaries when copying source to docker images [blubber] - 10https://gerrit.wikimedia.org/r/555572