[00:22:56] 10Gerrit, 10ORES, 10Scoring-platform-team (Current): Write a cookbook for the workaround for getting LFS to gerrit - https://phabricator.wikimedia.org/T226055 (10ACraze) LGTM I followed the LFS commands and pushed 2 new objects to gerrit for editquality. It seems like articlequality and draftquality are bot... [05:47:18] Yippee, build fixed! [05:47:19] Project mwcore-phpunit-coverage-master build #365: 09FIXED in 2 hr 47 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/365/ [07:35:57] 10Release-Engineering-Team, 10Operations, 10Wikimedia-Rdbms, 10Core Platform Team Workboards (Clinic Duty Team): WikiPage::updateCategoryCounts causing replication lag due to long-running writes on commonswiki - https://phabricator.wikimedia.org/T240405 (10jcrespo) I've created https://wikitech.wikimedia.o... [08:13:59] 10Release-Engineering-Team, 10MediaWiki-extensions-FlaggedRevs, 10Regression: FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24 - https://phabricator.wikimedia.org/T237191 (10Zache) Tested that flaggedrevs_promote is still updated ` MariaDB [dewiki_p]> select * from flaggedrev... [08:55:48] (03PS2) 10Thiemo Kreuz (WMDE): Treat "mixed" as already including null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/498472 (https://phabricator.wikimedia.org/T218324) (owner: 10Legoktm) [08:59:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Indeed, I misunderstood the commit message. What this patch here does is really nothing but a bugfix, and should be merged independent fro" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/498472 (https://phabricator.wikimedia.org/T218324) (owner: 10Legoktm) [09:32:19] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10Zache) Based on [[ https://www.mediawiki.org/wiki/Manual:$wgExtensionFunctions | Manual:$wgExtensionFunctions ]... [09:51:29] (03PS2) 1020after4: Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [09:53:18] (03CR) 1020after4: [C: 03+1] Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [09:56:16] (03CR) 10jerkins-bot: [V: 04-1] Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [09:56:57] 10Beta-Cluster-Infrastructure: Migrate deployment-zookeeper02 from jessie to stretch - https://phabricator.wikimedia.org/T222461 (10elukey) Scratch the above, yesterday I was doing other tasks and wasn't able to concentrate properly, I just started a new stretch instance. [09:59:44] 10Beta-Cluster-Infrastructure: Migrate deployment-zookeeper02 from jessie to stretch - https://phabricator.wikimedia.org/T222461 (10Krenair) I think there was actually a period of time recently where only buster was available and stretch was missing. Don't know what was up with qcow2 showing up though. Thanks fo... [10:12:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10SRE-Access-Requests: Grant "contint-roots" and "releasers-mediawiki" to user brennen - https://phabricator.wikimedia.org/T240382 (10hashar) 05Open→03Resolved ` puppet/modules/admin/data(productionu=)$ ./matrix.py... [10:20:17] 10Beta-Cluster-Infrastructure: Migrate deployment-zookeeper02 from jessie to stretch - https://phabricator.wikimedia.org/T222461 (10elukey) Instance is ready now, I just applied `profile::zookeeper::server` to the new instance (same name, so it picks up the previous cluster config from the main hiera of the proj... [11:06:32] 10Gerrit, 10VPS-Projects: Gerrit test instance is down - https://phabricator.wikimedia.org/T240933 (10Aklapper) [11:20:52] 10Gerrit: Gerrit replication to Github stalled - https://phabricator.wikimedia.org/T87248 (10Jdforrester-WMF) 05Open→03Resolved >>! In T87248#5734391, @Krinkle wrote: >>>! In T87248#5727388, @hashar wrote: >> OAuth got enabled again via T234991 … > > "OAuth restrictions" were enabled, which, if I understand... [11:22:44] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO, 10Technical-Debt: Deal with portal-master on Beta Cluster's checkout of mediawiki-config - https://phabricator.wikimedia.org/T238595 (10Jdforrester-WMF) p:05Triage→03Low [11:23:18] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (201912), 10Epic, 10Technical-Debt, 10ci-test-error: Figure out which production extensions have conflicting tests and fix them - https://phabricator.wikimedia.org/T238492 (10Jdforrester-WMF) p:05Triage→03Normal [11:23:53] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Fundraising-Backlog, 10Patch-For-Review: Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (10Jdforrester-WMF)... [11:24:00] 10Release-Engineering-Team-TODO (201912), 10Code-Review-Workgroup: Define code review metrics - https://phabricator.wikimedia.org/T229510 (10Jdforrester-WMF) p:05Triage→03High [11:24:38] 10Release-Engineering-Team-TODO (201912), 10Wikimedia-Site-requests, 10Technical-Debt: Fix places where mw-config assumes "s4" means Commons - https://phabricator.wikimedia.org/T213096 (10Jdforrester-WMF) 05Open→03Resolved I believe that this is now done. [11:24:57] 10Release-Engineering-Team (Code Health), 10Release-Engineering-Team-TODO, 10MediaWiki-extensions-CodeReview, 10Wikimedia-Site-requests, 10Technical-Debt: Undeploy CodeReview - https://phabricator.wikimedia.org/T116948 (10Jdforrester-WMF) p:05Triage→03Low [11:25:27] 10Release-Engineering-Team-TODO (201912), 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) [11:30:06] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Sonarqubebot: Remove independent code health pipeline and integrate into test pipeline - https://phabricator.wikimedia.org/T240935 (10kostajh) [11:32:16] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Sonarqubebot: Remove independent code health pipeline and integrate into test pipeline - https://phabricator.wikimedia.org/T240935 (10kostajh) Alternatively, we can keep the pipeline as it is but somehow find a way to disable the gerrit reporting enti... [11:37:53] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Sonarqubebot: Run composer test for sonarqubebot - https://phabricator.wikimedia.org/T240937 (10kostajh) p:05Triage→03Lowest [11:54:20] !log Starting the train cut for 1.35.0-wmf.11 [11:54:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:08:56] James_F: I'm adding https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/558483/ to the .11 branch for Wikibase btw [12:09:00] just after thr train cut [12:09:27] addshore: Meh. OK. Train is being cut right now. [12:09:45] yup [12:10:05] the branch is already cut for Wikibase, but i guess the train is running until later anyway (giving me time to merge this) [12:10:16] it got merged just before the cut and then revert just after :D [12:10:45] addshore: Train deploy is in 49 minutes' time, but please don't use every second of that. :-) [12:11:23] ack :) [12:11:26] * tarrow owns up to the blame [12:11:28] James_F: who is choo chooing it? [12:11:34] Me. [12:11:36] cool! [12:12:02] just got to wait for the gate and submit of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/558483/ shouldnt take 49 mins [12:12:19] tarrow: i guess i only need to wait for that for the build checking bit? otherwise i would just force it through [12:12:45] I would hope that being a revert its actually always safe [12:12:47] tarrow: I'll leave it in your capable hands to make sure it goes in (and coordinate with James_F ) :) [12:13:03] addshore: Theoretically the wmf.X gate-and-submit run for Wikibase should be faster than the master one… [12:13:10] addshore: cool [12:13:18] tarrow: I guess that depends on if anything else went in between right? as anything that goes in between will alter the built stuff [12:13:52] James_F: I see https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/558485/ being merged just ahead of it [12:14:11] choo choo [12:14:28] Plausibly. [12:14:38] no, correction, the Wikibase one is in front :) [12:14:41] It'd be very sad(ly broken) if the core commit lands first. [12:14:45] Because the pointer will be wrong. [12:14:58] Err. If the core commit doesn't land first, rather. [12:14:59] but, i think the core commit pointer will still be wrong and in need of updating? [12:15:13] (03CR) 10Lars Wirzenius: [C: 03+2] "LGTM" [blubber] - 10https://gerrit.wikimedia.org/r/555572 (owner: 10Dduvall) [12:15:17] Yeah, and the gerrit pointer can't update a pointer that doesn't exist… [12:15:23] Maybe kill the Wikibase job for now? [12:15:46] sounds good [12:15:51] indeed, https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/558485/1/extensions/Wikibase is the parent of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/558483/ [12:16:47] I terminated quibble-vendor-mysql-php72-noselenium-docker/2036 [12:17:09] Well, for now core will end up with a valid commit pointer to wikibase (pre the revert) and then that will just have to be poked / updated after they both go through [12:17:10] So it'll re-build. [12:17:16] (03CR) 10jerkins-bot: [V: 04-1] pipeline: Exclude binaries when copying source to docker images [blubber] - 10https://gerrit.wikimedia.org/r/555572 (owner: 10Dduvall) [12:17:52] James_F: you only did that on test-wmf though? if the gate-submit passes it will still submit [12:18:13] but it submitting wont be a problem, it just means the submodule commit for wikibase needs updating after [12:19:04] Additionally we just discovered that our mistake probably isn't actually as bad as we thought so in principle we could ignore our revert and backport until a less pressured time [12:19:15] addshore: Oh, meh. Yes, fixing. [12:19:39] as it is already reverted on master, I think we best get the revert on the branch for now [12:19:50] Dealing with only a single tiny laptop screen is not fun. [12:19:54] Killed quibble-vendor-mysql-php72-noselenium-docker/2037 [12:20:15] addshore: In future, please don't ever do this again. :-P [12:20:35] hmm, you didnt need to cancel that build (as said above) :/ [12:20:46] now the core one must re run, and still needs another commit [12:21:42] Yes, I did. [12:21:46] As I said above. [12:22:22] so it will auto rebuild? [12:22:35] If the original pointer didn't exist in core yet, it'll not auto-update from original-wmf.11 to your new wmf.11 until you put a second new patch into wmf.11. [12:22:51] C+2ing to a wmf.X branch is always delicate. [12:23:19] The gate will re-run when I re-C+2, except you already have. [12:23:33] I was just going to make a commit to /core to update the pointer, as the pointer in the core patch was already valid, but yes, having it go in after the core one avoids thtat [12:23:53] There's a reason the bot said "sanity break". [12:24:21] Right, now it should follow the core patch in :) [12:24:34] ah! So if we'd waited until after https://gerrit.wikimedia.org/r/c/mediawiki/core/+/558485/ had merged we'd have been all good? [12:24:46] or before it was created :P [12:25:46] actually after branch cut but before commit creation might not worth eithier (i'd have to look at the code that makes the commit) [12:26:32] tarrow: Yeds. [12:26:37] addshore: NO! [12:26:47] addshore: You can't just fuck around with the branch cut like that. Srsly. [12:27:06] * addshore is just repeating a set of processes that has been done multiple times before [12:27:20] Except we changed how the train cut works recently. [12:27:33] I can see [12:27:38] It was a rollercoaster of emotion for me because I thought our bad patch had missed the train anyway since I saw the traincut SAL log before it merged [12:28:02] tarrow: Yeah, sorry, train cut is a window not a point in time. :-( [12:28:37] IT would be nice to actually have jenkins not merge things between the start and end of the cut [12:28:52] and just keep then in the queue for merging after the cut [12:28:58] Yes, but the effort to lock jenkins like that is quite high. [12:29:00] nothing to be sorry for; this whole kerfuffle is pretty much entirely my fault [12:29:10] tarrow: Psh, these things happen. [12:29:18] :D [12:34:10] 10Release-Engineering-Team (Kanban), 10Release-Engineering-Team-TODO (201912): Create a threat model for new CI - https://phabricator.wikimedia.org/T240679 (10LarsWirzenius) [13:40:55] (03PS1) 10Mainframe98: Upgrade to PHPUnit 8 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/558509 [13:43:18] (03CR) 10Awight: [C: 03+1] "Looks right, thanks." [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [13:46:23] (03PS1) 10Jforrester: layout: [labs/tools/sonarqubebot] Add CI to run composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/558511 (https://phabricator.wikimedia.org/T240937) [13:47:38] (03CR) 10Jforrester: [C: 03+2] layout: [labs/tools/sonarqubebot] Add CI to run composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/558511 (https://phabricator.wikimedia.org/T240937) (owner: 10Jforrester) [13:48:07] (03Merged) 10jenkins-bot: layout: [labs/tools/sonarqubebot] Add CI to run composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/558511 (https://phabricator.wikimedia.org/T240937) (owner: 10Jforrester) [13:49:01] !log Zuul: [labs/tools/sonarqubebot] Add CI to run composer-test T240937 [13:49:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:49:04] T240937: Run composer test for sonarqubebot - https://phabricator.wikimedia.org/T240937 [13:50:42] James_F: thanks. First I need `composer test` to do something with the repo. Just pushed a patch [13:51:21] kostajh: Ha. OK. [13:52:32] kostajh: Oh, yeah, do you only want to run in PHP 7.4? I can fiddle… [13:52:41] James_F: doesn't matter [13:52:53] For now anyway [13:53:11] 'Cos it complained that you had built the composer.lock file in too-new a version of PHP. [13:53:12] Oh, maybe it does matter [13:53:15] Yeah. [13:53:15] heh [13:53:29] James_F: if it's easy, yes please [13:53:50] James_F: if not, I'll just modify the composer.json file [13:53:56] php73? php74? [13:54:48] James_F: probably php73 for now? [13:55:14] James_F: the CLI on toolforge appears to use php72 [13:55:38] Oh, in that case I guess you'll want to actually run it on 72? [13:55:57] (Building 73 and 74 is "easy" but'll take an hour or so as it'll need new images, new jjbs, etc.) [13:56:15] Do-able but tedious. ;-) [13:56:35] If you can live with building for php72 for now, and I'll get around to 73/74 support later, is that OK? [13:56:37] James_F: let me just fix the composer.json for now :) [13:56:42] * James_F grins. [13:57:04] James_F: while we're chatting, do you have any idea why this isn't working? https://gerrit.wikimedia.org/r/c/labs/tools/sonarqubebot/+/558032 [13:57:21] 10Gerrit, 10Release-Engineering-Team, 10Upstream: Gerrit replica does not support the 'query' command - https://phabricator.wikimedia.org/T235251 (10Aklapper) [13:57:35] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201912), 10Code-Health-Metrics, 10Sonarqubebot, 10Patch-For-Review: Run composer test for sonarqubebot - https://phabricator.wikimedia.org/T240937 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [13:58:53] kostajh: Not off-hand, sorry. [13:58:57] It sounds correct. [14:01:19] 10Gerrit, 10Release-Engineering-Team-TODO, 10Documentation: Update Gerrit documentation on mediawiki.org before upgrading to Gerrit 2.16.x / PolyGerrit UI - https://phabricator.wikimedia.org/T227562 (10Paladox) [14:01:22] 10Gerrit, 10Developer-Advocacy, 10Documentation: Update Wikimedia's Gerrit documentation for new UI (GWTUI to be superseded by polygerrit) - https://phabricator.wikimedia.org/T179759 (10Paladox) [14:27:09] 10Continuous-Integration-Config, 10Code-Health-Metrics: Enable codehealth pipeline for more extensions - https://phabricator.wikimedia.org/T224990 (10MSantos) @kostajh, before ore filling another phab task, I would like to ask: is it possible to enable the codehealth pipeline for our node services as well? [14:28:29] James_F: quick follow up, do we need to do something about the gate-and-submit part? https://gerrit.wikimedia.org/r/c/labs/tools/sonarqubebot/+/558529#message-e2a8a2f4e264bfc30ba45d99c1fc85627d226d41 [14:29:18] 10Continuous-Integration-Config, 10Code-Health-Metrics: Enable codehealth pipeline for more extensions - https://phabricator.wikimedia.org/T224990 (10kostajh) @MSantos yes it's possible but I think a separate task makes sense. See {T238004}. We would probably do something similar to what @MStyles is working on... [14:33:13] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201912), 10Code-Health-Metrics, 10Sonarqubebot: Run composer test for sonarqubebot - https://phabricator.wikimedia.org/T240937 (10kostajh) 05Resolved→03Open It looks like we need to do something about gate-and-submit, which wants to use... [14:34:00] kostajh: Oh, right, sure. [14:36:30] (03PS1) 10Jforrester: layout: [labs/tools/sonarqubebot] Move to composer-test-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/558534 [14:36:45] (03CR) 10Jforrester: [C: 03+2] layout: [labs/tools/sonarqubebot] Move to composer-test-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/558534 (owner: 10Jforrester) [14:37:33] (03Merged) 10jenkins-bot: layout: [labs/tools/sonarqubebot] Move to composer-test-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/558534 (owner: 10Jforrester) [14:46:08] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (201912), 10Code-Health-Metrics, 10Sonarqubebot: Run composer test for sonarqubebot - https://phabricator.wikimedia.org/T240937 (10Jdforrester-WMF) 05Open→03Resolved Done. :-) [14:49:14] James_F: thx! [14:49:39] Happy to help; plain vanilla composer-test is quite rare, hence the issue. :-) [15:41:21] (03CR) 10Jforrester: [C: 03+2] Upgrade to PHPUnit 8 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/558509 (owner: 10Mainframe98) [15:41:55] (03Merged) 10jenkins-bot: Upgrade to PHPUnit 8 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/558509 (owner: 10Mainframe98) [15:42:07] (03CR) 10Jforrester: [C: 03+1] Treat "mixed" as already including null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/498472 (https://phabricator.wikimedia.org/T218324) (owner: 10Legoktm) [16:03:27] (03PS1) 10Matthias Mullie: Add Kartographer as dependency for WikibaseMediaInfo [integration/config] - 10https://gerrit.wikimedia.org/r/558571 [16:05:24] (03CR) 10Jforrester: [C: 03+2] Add Kartographer as dependency for WikibaseMediaInfo [integration/config] - 10https://gerrit.wikimedia.org/r/558571 (owner: 10Matthias Mullie) [16:06:22] (03Merged) 10jenkins-bot: Add Kartographer as dependency for WikibaseMediaInfo [integration/config] - 10https://gerrit.wikimedia.org/r/558571 (owner: 10Matthias Mullie) [16:06:54] !log Zuul: Add Kartographer as dependency for WBMI [16:06:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:18:45] RECOVERY - Host deployment-zookeeper02 is UP: PING OK - Packet loss = 0%, RTA = 1.09 ms [16:54:26] (03PS1) 10Thcipriani: docs: update dependencies [tools/scap] - 10https://gerrit.wikimedia.org/r/558598 [16:59:10] (03PS3) 10Thcipriani: Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [17:10:52] (03CR) 10Thcipriani: [C: 04-1] "Currently failing due to doc dependencies, rebased on https://gerrit.wikimedia.org/r/558598 to fix." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [17:37:44] (03PS1) 10Jforrester: Revert "Add Kartographer as dependency for WikibaseMediaInfo" [integration/config] - 10https://gerrit.wikimedia.org/r/558614 (https://phabricator.wikimedia.org/T240971) [17:37:59] (03CR) 10Jforrester: [C: 03+2] Revert "Add Kartographer as dependency for WikibaseMediaInfo" [integration/config] - 10https://gerrit.wikimedia.org/r/558614 (https://phabricator.wikimedia.org/T240971) (owner: 10Jforrester) [17:38:46] (03Merged) 10jenkins-bot: Revert "Add Kartographer as dependency for WikibaseMediaInfo" [integration/config] - 10https://gerrit.wikimedia.org/r/558614 (https://phabricator.wikimedia.org/T240971) (owner: 10Jforrester) [17:39:44] !log Zuul: Revert Kartographer as dependency for WBMI per T240971 [17:39:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:39:47] T240971: Wikibase CI on master failing due to CachingKartographerEmbeddingHandlerTest issue - https://phabricator.wikimedia.org/T240971 [17:47:53] PROBLEM - Parsoid on deployment-parsoid09 is CRITICAL: connect to address 172.16.5.63 and port 8000: Connection refused [17:47:53] PROBLEM - Parsoid on deployment-mediawiki-parsoid10 is CRITICAL: connect to address 172.16.0.141 and port 8000: Connection refused [17:51:39] <_joe_> thcipriani: I just got HEAD -> refs/drafts/production (draft workflow is disabled) [17:55:44] _joe_: when doing what? [17:56:15] <_joe_> git push origin HEAD:refs/drafts/production on ops/puppet [17:56:36] heh [17:56:46] i think that's deprecated [17:56:51] <_joe_> oh? [17:56:55] _joe_ drafts are wips now [17:56:59] (and private changes) [17:57:27] _joe_ i think you want %wip [17:57:40] <_joe_> not the same thing, but yes I used that [17:57:42] <_joe_> thanks [17:57:42] so git push origin HEAD:refs/for/production%wip [17:57:54] <_joe_> yeah just did that paladox :) [17:57:59] :) [17:58:22] <_joe_> but it's different, drafts were private but you could add reviewers [17:58:54] _joe_ https://www.gerritcodereview.com/3.1.html#legacy-support-for-pushing-to-refsdrafts-is-removed [17:58:59] oh [17:59:05] _joe_ we disabled private changes :) [17:59:28] https://github.com/wikimedia/puppet/blob/production/modules/gerrit/templates/gerrit.config.erb#L42 [17:59:40] <_joe_> well "temporarily private" is what draft where [18:00:01] yeh, that functionaility was split into wip and private [18:00:04] <_joe_> just visible to you and the reviewer until published, whereas WIP changes are public but you can't add reviewers [18:00:08] with both being able to switch in and back out [18:00:22] _joe_ you can add reviewers [18:00:26] just emails are not sent [18:00:42] remember to hit "save" not "save for review" [18:00:54] if you want the change to stay WIP but add reviewers [18:04:52] !log Create Jenkins Console section for "setup diffConfig", example at https://integration.wikimedia.org/ci/job/operations-mw-config-php72-composer-diffConfig-docker/181/console [18:04:54] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:06:19] James_F: ^ :) [18:06:39] * Krinkle saves carbon footprint of his scrollwheel [18:11:47] Krinkle: Fancy. [19:38:09] (03CR) 10Krinkle: [C: 03+1] Treat "mixed" as already including null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/498472 (https://phabricator.wikimedia.org/T218324) (owner: 10Legoktm) [20:30:31] (03PS5) 10Clarakosi: Update Quibble to use api-testing npm package [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) [20:37:31] (03CR) 10Clarakosi: "I was able to test it locally and it works for the patch in Core but the one in SpamBlacklist is currently failing because quibble.json do" [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [20:46:26] good to know that phab just silently ignore the invalid time and makes no changes [20:46:29] 22:00 AM [20:46:32] NO CHANGE [21:10:40] lol [21:31:27] @hashar @James_F I don't think Selenium browser tests are running in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/558657/ - did someone disable that? If so could it be restored? [21:42:06] (03CR) 10Hashar: "Yes it is good to go, it builds find on Buster, but the CI job fails because of some issue in the tool https://phabricator.wikimedia.org/T" [integration/config] - 10https://gerrit.wikimedia.org/r/554859 (owner: 10Hashar) [21:47:52] (03CR) 10Hashar: "Or we make it voting and assume it will pass by fixing T239910. The other jobs fail as well due to this bug anyway ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/554859 (owner: 10Hashar) [22:16:03] (03PS2) 10Mstyles: jib: Add Java codehealth project and job-template [integration/config] - 10https://gerrit.wikimedia.org/r/557154 (https://phabricator.wikimedia.org/T238004) [22:19:08] (03CR) 10Mstyles: "> Patch Set 1: Verified-1" [integration/config] - 10https://gerrit.wikimedia.org/r/557154 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [22:34:36] (03CR) 1020after4: [C: 03+1] "> Patch Set 3: Code-Review-1" (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [23:10:53] (03PS3) 10Hashar: labs/toollabs: run Debian package for Buster [integration/config] - 10https://gerrit.wikimedia.org/r/554859 [23:11:24] (03CR) 10Hashar: [C: 03+2] "I nerd snipped myself into fixing it: https://gerrit.wikimedia.org/r/#/c/labs/toollabs/+/558722/" [integration/config] - 10https://gerrit.wikimedia.org/r/554859 (owner: 10Hashar) [23:12:26] (03Merged) 10jenkins-bot: labs/toollabs: run Debian package for Buster [integration/config] - 10https://gerrit.wikimedia.org/r/554859 (owner: 10Hashar) [23:17:44] (03CR) 10Hashar: [C: 03+2] "And that passed on their change https://gerrit.wikimedia.org/r/#/c/labs/toollabs/+/558722/ !" [integration/config] - 10https://gerrit.wikimedia.org/r/554859 (owner: 10Hashar) [23:26:52] (03PS4) 1020after4: Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [23:30:46] (03CR) 10jerkins-bot: [V: 04-1] Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [23:35:15] (03CR) 1020after4: Add the part for rebuilding array l10n cache (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [23:36:16] (03CR) 1020after4: [C: 03+2] docs: update dependencies [tools/scap] - 10https://gerrit.wikimedia.org/r/558598 (owner: 10Thcipriani) [23:40:00] (03PS5) 1020after4: Add the part for rebuilding array l10n cache [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [23:40:11] (03Merged) 10jenkins-bot: docs: update dependencies [tools/scap] - 10https://gerrit.wikimedia.org/r/558598 (owner: 10Thcipriani)