[07:59:27] (03CR) 10Awight: Move argument parsing to module scope (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/546125 (owner: 10Awight) [08:01:04] (03PS5) 10Awight: Cleanup: Pass args directly rather than as state [integration/quibble] - 10https://gerrit.wikimedia.org/r/550345 [08:04:11] (03PS10) 10Awight: Move argument parsing to module scope [integration/quibble] - 10https://gerrit.wikimedia.org/r/546125 [08:04:58] (03CR) 10jerkins-bot: [V: 04-1] Move argument parsing to module scope [integration/quibble] - 10https://gerrit.wikimedia.org/r/546125 (owner: 10Awight) [08:09:04] (03PS11) 10Awight: Move argument parsing to module scope [integration/quibble] - 10https://gerrit.wikimedia.org/r/546125 [08:24:13] (03PS29) 10Awight: Commands expand recursively [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 [08:25:07] (03CR) 10jerkins-bot: [V: 04-1] Commands expand recursively [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 (owner: 10Awight) [08:25:11] (03PS30) 10Awight: Commands expand recursively [integration/quibble] - 10https://gerrit.wikimedia.org/r/519776 [08:25:43] (03PS6) 10Awight: Cleanup: require all command parameter keywords [integration/quibble] - 10https://gerrit.wikimedia.org/r/546469 [08:26:38] (03PS8) 10Awight: Merge utility functions into calling modules [integration/quibble] - 10https://gerrit.wikimedia.org/r/546434 [08:26:39] (03PS16) 10Awight: Clean up logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/546126 [08:34:58] Project beta-code-update-eqiad build #276235: 04FAILURE in 1 min 57 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/276235/ [08:37:51] (03PS12) 10Awight: Replace argparse with docopt [integration/quibble] - 10https://gerrit.wikimedia.org/r/546167 [08:39:09] awight: awight_ your making lots of quibble changes :D [08:39:14] (03PS13) 10Awight: Prepare to run browser suites in parallel [integration/quibble] - 10https://gerrit.wikimedia.org/r/545661 (https://phabricator.wikimedia.org/T226869) [08:39:20] oooooh [08:41:40] * awight_ rattles saber [08:41:57] addshore: Feel free to review! [08:42:20] I dare say https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/519776 is downright interesting. [08:43:37] & I'm not really happy with my decision to `yield` subprocesses, there's got to be a better pattern for this. [08:44:31] Yippee, build fixed! [08:44:32] Project beta-code-update-eqiad build #276236: 09FIXED in 1 min 30 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/276236/ [08:45:56] I've lost sight of why I wanted to leave control flow a responsibility of the top-level module. Why not just call subroutines like a normal program, and drop the Command pattern... [08:47:21] Originally, I wanted to use a command queue so that we could print a manifest of steps before taking any action, but with indeterminate substeps, there's no way to know everything ahead of time so what's the benefit... [09:17:44] (03PS1) 10Wugapodes: Enable automated documentation for ChessBrowser. [integration/config] - 10https://gerrit.wikimedia.org/r/558977 [09:23:46] (03PS2) 10Wugapodes: Enable automated documentation for ChessBrowser. [integration/config] - 10https://gerrit.wikimedia.org/r/558977 [10:49:13] (03CR) 10Jforrester: [C: 03+1] Update Quibble to use api-testing npm package [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [10:54:23] 10Release-Engineering-Team-TODO (201912), 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) [10:54:49] 10Release-Engineering-Team-TODO (201912), 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) (Train is currently unblocked.) [12:20:24] (03PS1) 10Jforrester: layout: [mediawiki/extensions/PhabTaskGraph] Add initial CI [integration/config] - 10https://gerrit.wikimedia.org/r/559032 [12:22:55] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki/extensions/PhabTaskGraph] Add initial CI [integration/config] - 10https://gerrit.wikimedia.org/r/559032 (owner: 10Jforrester) [12:23:11] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Patch-For-Review, 10Performance-Team (Radar): Add Scap support for static-array format of LCStore - https://phabricator.wikimedia.org/T105683 (10Ladsgroup) I deployed it but I'm not sure if it works with mwscript... [12:23:58] (03Merged) 10jenkins-bot: layout: [mediawiki/extensions/PhabTaskGraph] Add initial CI [integration/config] - 10https://gerrit.wikimedia.org/r/559032 (owner: 10Jforrester) [12:29:53] (03CR) 10Ladsgroup: [C: 04-1] Add the part for rebuilding array l10n cache (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/558243 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [13:14:51] 10Release-Engineering-Team-TODO (201912), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) [13:17:26] (03PS1) 10Jack Phoenix: Whitelist Ostrzyciel (Nonsensopedia (Polish Uncyclopedia) admin & dev) [integration/config] - 10https://gerrit.wikimedia.org/r/559046 [13:37:16] 10Release-Engineering-Team-TODO (201912), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) [13:59:27] 10MediaWiki-Releasing, 10Security: Write and send pre-release Announcements for MediaWiki 1.31.6/1.32.6/1.33.2/1.34.0 - https://phabricator.wikimedia.org/T233496 (10Reedy) 05Open→03Resolved [13:59:29] 10MediaWiki-Releasing, 10Security: Write and send pre-release Announcements for MediaWiki 1.31.6/1.32.6/1.33.2/1.34.0 - https://phabricator.wikimedia.org/T233496 (10Reedy) [13:59:38] 10Release-Engineering-Team, 10Scap: Run Swagger checks in Scap before exposing to prod MW traffic - https://phabricator.wikimedia.org/T239376 (10thcipriani) p:05Triage→03Normal [14:05:26] 10Release-Engineering-Team-TODO (201912): Document pipelinelib - https://phabricator.wikimedia.org/T239423 (10LarsWirzenius) https://wikitech.wikimedia.org/wiki/Deployment_pipeline/Pipelinelib That's a start of the reference documentation for Pipelinelib. It needs review and fixing by Dan or others who have the... [14:28:38] (03CR) 10Jforrester: [C: 03+2] dockerfiles: Add Java sonarcloud implementation [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [14:29:29] (03Merged) 10jenkins-bot: dockerfiles: Add Java sonarcloud implementation [integration/config] - 10https://gerrit.wikimedia.org/r/556513 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [14:30:12] !log Docker: Push java8-sonar-scanner:0.5.0 [14:30:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:33:16] (03CR) 10Jforrester: [C: 03+2] Whitelist a few more HTML tags for i18n messages [integration/config] - 10https://gerrit.wikimedia.org/r/558040 (owner: 10Lucas Werkmeister (WMDE)) [14:34:13] (03Merged) 10jenkins-bot: Whitelist a few more HTML tags for i18n messages [integration/config] - 10https://gerrit.wikimedia.org/r/558040 (owner: 10Lucas Werkmeister (WMDE)) [14:34:44] !log Zuul: Add ol ui li to i18n security allow list [14:34:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:41:49] (03PS3) 10Jforrester: jib: Add new java-codehealth-patch job and template [integration/config] - 10https://gerrit.wikimedia.org/r/557154 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [14:41:51] (03PS1) 10Jforrester: jjb: Migrate codehealth jobs to new version of docker image [integration/config] - 10https://gerrit.wikimedia.org/r/559086 [14:42:53] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/557154 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [14:43:46] (03Merged) 10jenkins-bot: jib: Add new java-codehealth-patch job and template [integration/config] - 10https://gerrit.wikimedia.org/r/557154 (https://phabricator.wikimedia.org/T238004) (owner: 10Mstyles) [14:53:42] 10Release-Engineering-Team-TODO (201912), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) [15:13:02] (03CR) 10Ppchelko: Update Quibble to use api-testing npm package (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [15:25:01] (03CR) 10Clarakosi: Update Quibble to use api-testing npm package (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [15:44:29] (03CR) 10Ppchelko: Update Quibble to use api-testing npm package (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [16:02:58] 10Release-Engineering-Team-TODO (201912), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) [16:12:21] (03PS6) 10Clarakosi: Update Quibble to use api-testing npm package [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) [16:14:25] (03CR) 10Clarakosi: "After convo on I827dc895719cc687 I've renamed quibble.json to .api-testing-quibble.json and placed it in the root" [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [16:41:18] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Product-Infrastructure-Team-Backlog: Enable codehealth pipeline for node services - https://phabricator.wikimedia.org/T240989 (10Jhernandez) Hey @MSantos can you fill the task description with more detail? Maybe using the [[https://phabricator.wikimed... [17:41:11] (03CR) 10Ppchelko: [C: 03+1] Update Quibble to use api-testing npm package [integration/quibble] - 10https://gerrit.wikimedia.org/r/554571 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [17:57:37] (03CR) 10Dduvall: "> Patch Set 2: Verified-1" [blubber] - 10https://gerrit.wikimedia.org/r/555572 (owner: 10Dduvall) [18:28:55] (03CR) 10Jforrester: [C: 03+2] "… re-triggering C+2." [blubber] - 10https://gerrit.wikimedia.org/r/555572 (owner: 10Dduvall) [18:31:15] (03Merged) 10jenkins-bot: pipeline: Exclude binaries when copying source to docker images [blubber] - 10https://gerrit.wikimedia.org/r/555572 (owner: 10Dduvall) [18:39:56] (03CR) 10Hashar: [C: 03+2] Cleanup: Pass args directly rather than as state (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/550345 (owner: 10Awight) [18:40:43] (03Merged) 10jenkins-bot: Cleanup: Pass args directly rather than as state [integration/quibble] - 10https://gerrit.wikimedia.org/r/550345 (owner: 10Awight) [19:06:47] (03CR) 10Hashar: [C: 04-1] "Haven't carefully the change being introduced, but I should be able to figure it out with:" (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/546125 (owner: 10Awight) [19:11:57] (03CR) 10Hashar: [C: 04-1] "Ok found it. We can just instruct sphinx-argparse to not output the default. We already document them in most cases anyway. So we would ju" [integration/quibble] - 10https://gerrit.wikimedia.org/r/546125 (owner: 10Awight) [20:27:26] 10Phabricator, 10Security-Team: Create 'user affiliation' custom drop down field for forms - https://phabricator.wikimedia.org/T240999 (10Jcross) @chasemp - talked to JB and we are good to run with this as a first iteration. We'll assess and refine on down the road. [20:46:09] (03CR) 10Kosta Harlan: [C: 03+1] jjb: Migrate codehealth jobs to new version of docker image [integration/config] - 10https://gerrit.wikimedia.org/r/559086 (owner: 10Jforrester) [20:52:49] 10Release-Engineering-Team, 10Operations, 10serviceops, 10Patch-For-Review, and 3 others: All debug hosts give (likely spurious) message: PHP Fatal error: The UdpSocket to 127.0.0.1:10514 has been closed (from Monolog/SyslogUdp) - https://phabricator.wikimedia.org/T214734 (10Krinkle) I also see the UdpSoc... [21:01:55] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Patch-For-Review, 10Performance-Team (Radar): Add Scap support for static-array format of LCStore - https://phabricator.wikimedia.org/T105683 (10Krinkle) Ah right. We run mediawiki code as a separate user and a c... [21:55:05] (03PS1) 10NicholasG04: Google Code-in - Added email to whitelist for Jenkins. [integration/config] - 10https://gerrit.wikimedia.org/r/559214 [22:03:28] 10Release-Engineering-Team-TODO (201912), 10dev-images: dev-images: Add a standalone php-fpm + Apache image for use in running mediawiki code without Blubber dependencies - https://phabricator.wikimedia.org/T240625 (10thcipriani) [22:29:58] (03CR) 10Hashar: [C: 03+2] Google Code-in - Added email to whitelist for Jenkins. [integration/config] - 10https://gerrit.wikimedia.org/r/559214 (owner: 10NicholasG04) [22:31:01] (03Merged) 10jenkins-bot: Google Code-in - Added email to whitelist for Jenkins. [integration/config] - 10https://gerrit.wikimedia.org/r/559214 (owner: 10NicholasG04) [22:31:38] (03CR) 10Hashar: [C: 03+2] "And deployed. Welcome!" [integration/config] - 10https://gerrit.wikimedia.org/r/559214 (owner: 10NicholasG04) [23:04:17] 10MediaWiki-Codesniffer: PHPCS: The UnrecognizedAnnotation sniff should ignore within a code block - https://phabricator.wikimedia.org/T241091 (10Krinkle) [23:06:21] 10MediaWiki-Codesniffer: PHPCS: The UnrecognizedAnnotation sniff should ignore code block - https://phabricator.wikimedia.org/T241091 (10Krinkle) [23:16:32] (03PS1) 10Mstyles: layout: Run sonar scanner analysis for java projects [integration/config] - 10https://gerrit.wikimedia.org/r/559230 (https://phabricator.wikimedia.org/T238004)