[06:13:18] 10MediaWiki-Codesniffer: codesniffer should fix wrong @throw to @throws on private functions - https://phabricator.wikimedia.org/T193430 (10DannyS712) FTR, I see only one use of this in function documentation, in [`SpecialClientSSL::checkExecutePermissions`](https://gerrit.wikimedia.org/g/mediawiki/extensions/SS... [08:38:14] 10Phabricator, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Operations, 10Traffic, 10serviceops: Phabricator downtime due to aphlict and websockets (aphlict current disabled) - https://phabricator.wikimedia.org/T238593 (10mmodell) >>! In T238593#5792383, @akosiaris wrote: >> I really can'... [09:19:56] 10MediaWiki-Codesniffer: codesniffer should fix wrong @throw to @throws on private functions - https://phabricator.wikimedia.org/T193430 (10Umherirrender) 05Open→03Resolved For @returns you have only to search in php files as for js files that is the correct tag - https://codesearch.wmflabs.org/search/?q=%40... [19:21:45] (03PS1) 10JeremyNguyenGCI: layout.yaml: Add JeremyNguyen to Jenkins whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/563682 (https://phabricator.wikimedia.org/T235286) [19:42:42] (03CR) 10Gopavasanth: [C: 04-1] "> Uploaded patch set 1." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/563682 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [20:16:53] 10Beta-Cluster-Infrastructure, 10Lexicographical data, 10Operations, 10Wikidata, 10User-DannyS712: PHP fatal error on beta cluster - https://phabricator.wikimedia.org/T242188 (10Cutmuetia1998) [20:18:36] 10Beta-Cluster-Infrastructure, 10Lexicographical data, 10Operations, 10Wikidata, 10User-DannyS712: PHP fatal error on beta cluster - https://phabricator.wikimedia.org/T242188 (10RhinosF1) [20:28:37] (03PS1) 10JeremyNguyenGCI: layout.yaml: Add JeremyNguyen to Jenkins whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/563687 (https://phabricator.wikimedia.org/T235286) [20:30:45] (03CR) 10Gopavasanth: [C: 03+1] "> Uploaded patch set 1." [integration/config] - 10https://gerrit.wikimedia.org/r/563687 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [20:32:16] (03CR) 10Gopavasanth: [C: 04-1] ">" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/563682 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [20:32:16] It looks like Friday's deploy of 1.35/wmf.14 broke thumbnails for something like 1-2% of PDFs, and in a way that hits all the Wikisourcen. [20:32:47] See T242422 and T242517. [20:32:49] T242422: Proofreadpage attempts to use images with non-integer pixel size - https://phabricator.wikimedia.org/T242422 [20:32:50] T242517: Thumbnails for PDF files not found when width is not an Integer in URL link - https://phabricator.wikimedia.org/T242517 [20:33:28] Recent example at https://commons.wikimedia.org/wiki/File:Sand_-_Œuvres_illustrées_de_George_Sand,_vol_9,_1856.pdf [20:34:37] Note the non-integer width/height, and the link to https://upload.wikimedia.org/wikipedia/commons/thumb/b/b9/Sand_-_Œuvres_illustrées_de_George_Sand%2C_vol_9%2C_1856.pdf/page1-2133.3333333333px-Sand_-_Œuvres_illustrées_de_George_Sand%2C_vol_9%2C_1856.pdf.jpg [20:34:51] (which returns 404) [20:35:48] Based on the diff, it seems likely to be caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PdfHandler/+/560127/2/includes/PdfImage.php [20:38:31] Which for some reason has the commit message "build: Updating mediawiki/mediawiki-phan-config to 0.9.0" and no mention of a change to how image dimensions are calculated. [20:40:56] 1-2% guesstimate is based on manually checking PDF files in Commons' upload log: it seems to not affect all PDF files, so probably only files with non-integer DPI values or something. [21:10:20] (03CR) 10Ammarpad: [C: 04-1] layout.yaml: Add JeremyNguyen to Jenkins whitelist (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/563687 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [21:12:48] (03CR) 10Gopavasanth: ">" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/563687 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [21:26:55] (03PS2) 10JeremyNguyenGCI: layout.yaml: Add JeremyNguyen to Jenkins whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/563687 (https://phabricator.wikimedia.org/T235286) [21:30:05] (03CR) 10Gopavasanth: "> Uploaded patch set 2." [integration/config] - 10https://gerrit.wikimedia.org/r/563687 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [21:30:52] (03Abandoned) 10JeremyNguyenGCI: layout.yaml: Add JeremyNguyen to Jenkins whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/563682 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [21:31:07] (03CR) 10Ammarpad: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/563687 (https://phabricator.wikimedia.org/T235286) (owner: 10JeremyNguyenGCI) [21:34:52] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10cloud-services-team (Kanban): labs/toollabs testsuite fails when building the Debian package - https://phabricator.wikimedia.org/T239910 (10hashar) a:05hashar→03Bstorm Arturo reviewed the change h... [21:35:03] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10cloud-services-team (Kanban): labs/toollabs testsuite fails when building the Debian package - https://phabricator.wikimedia.org/T239910 (10hashar) p:05Triage→03Normal [21:44:38] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Scap, 10Operations, 10serviceops: On beta, scap can't clear opcache on some mw servers - https://phabricator.wikimedia.org/T237033 (10hashar) Those settings are for the Puppet roles. Given roles are solely for production, on WMCS the hiera look... [22:46:32] (03PS1) 10Umherirrender: [NativeSvgHandler] Add quibble job [integration/config] - 10https://gerrit.wikimedia.org/r/563700