[01:29:48] 10Phabricator (2020-01-23), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Security-Team: Enforce PermanentlyPrivate tag as on Security Issue type and #security tagged issues - https://phabricator.wikimedia.org/T242638 (10mmodell) [01:30:53] 10Phabricator (2020-01-23), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Security-Team: Make ‘Protect as security issue’ add project #security-team - https://phabricator.wikimedia.org/T242018 (10mmodell) 05Open→03Resolved [03:44:46] 10Phabricator: Searching in phabricator are failing - https://phabricator.wikimedia.org/T243479 (10Xaosflux) [03:45:08] 10Phabricator: Searchs in phabricator are failing with Unhandled Exception - https://phabricator.wikimedia.org/T243479 (10Xaosflux) [03:45:15] 10Phabricator: Searches in phabricator are failing with Unhandled Exception - https://phabricator.wikimedia.org/T243479 (10Xaosflux) [04:26:58] releng team - phab seems to be under attack [04:34:17] can anyone here block this phab user? https://phabricator.wikimedia.org/p/.Nafees791/ [04:34:31] hey channel, anyone here who can expel a griefer from Phab? https://phabricator.wikimedia.org/p/.Nafees791/ [04:36:30] releng folks, anyone around to help with ^^^ before they cause more annoyance? [04:38:50] thcipriani / zeljkof / Krinkle / bd808 ^^^^ [04:39:31] ejegg: blocked [04:39:46] thanks! [04:39:47] thanks! [04:43:49] it looks like our phab vandal removed some wiktionary data too https://meta.wikimedia.org/wiki/Special:CentralAuth?target=.Nafees791 [04:46:39] what a monster [04:46:53] 10Phabricator: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10Xaosflux) [04:48:15] wiktionary edits seem to be reverted already [04:51:34] yep - but user not yet blocked [05:00:00] eileen: I got a steward to global block [05:03:03] 10Diffusion, 10Phabricator, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Toolforge, and 2 others: Mirroring Diffusion repositories to GitHub seems to be broken - https://phabricator.wikimedia.org/T242898 (10DannyS712) a:03mmodell [05:04:00] 10Gerrit, 10Phabricator, 10Code-Review-Workgroup: Make a commit-message hook for gerrit patches that creates a phab task at the same time as assigning the change-id - https://phabricator.wikimedia.org/T239720 (10DannyS712) a:03mmodell [05:05:53] 10Deployments, 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10ReleaseTaggerBot: Deployment status indicator for gerrit patches - https://phabricator.wikimedia.org/T88136 (10DannyS712) a:03mmodell [05:07:14] 10Phabricator, 10I18n, 10User-Nikerabbit: Please add Brazilian Portuguese (pt-br) language - https://phabricator.wikimedia.org/T215697 (10DannyS712) 05Declined→03Stalled p:05High→03Normal a:03mmodell [05:08:31] 10Phabricator, 10Operations, 10SRE-tools, 10Technical-Debt: Update Puppet repo code that uses deprecated maniphest.update/.createtask/.query Conduit API - https://phabricator.wikimedia.org/T159045 (10DannyS712) a:03Volans [05:11:01] 10Phabricator, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Operations, 10Traffic, 10serviceops: Phabricator downtime due to aphlict and websockets (aphlict current disabled) - https://phabricator.wikimedia.org/T238593 (10DannyS712) a:03mmodell [05:12:29] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10User-MModell: Make sure elasticsearch 6 is supported in phabricator - https://phabricator.wikimedia.org/T181393 (10DannyS712) a:03mmodell [05:14:17] 10Phabricator, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): move_project breaks the world when moving a subproject that already has subprojects - https://phabricator.wikimedia.org/T242254 (10DannyS712) a:03mmodell [05:24:15] 10Phabricator: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10DannyS712) Started from the back, about half way done, but this is giving me a headache [05:25:47] 10Phabricator: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10DannyS712) @Xaosflux I've added you to #acl_userdisable in case you spot something like this again [06:16:06] 10Phabricator: Unknown search function "XXX". Supported functions are: all, title, body, core, comment. - https://phabricator.wikimedia.org/T243483 (10Tgr) [06:19:07] 10Phabricator: Searches in phabricator are failing with Unhandled Exception - https://phabricator.wikimedia.org/T243479 (10Tgr) [06:19:58] 10Phabricator: Searches in phabricator are failing with Unhandled Exception - https://phabricator.wikimedia.org/T243479 (10Tgr) Started happening during the Phab upgrade today. Affects the generic search but not Maniphest search. [07:25:02] (03CR) 10Thiemo Kreuz (WMDE): Fix UnsortedUseStatement sniff handling other content between use statements (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565525 (owner: 10Mainframe98) [07:25:44] (03PS1) 10DannyS712: Edit Project Config [extensions/ChessBrowser] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/566655 [07:25:55] (03Abandoned) 10DannyS712: Edit Project Config [extensions/ChessBrowser] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/566655 (owner: 10DannyS712) [07:40:50] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Addshore) p:05Triage→03Normal [08:00:40] 10Phabricator: Searches in phabricator are failing with Unhandled Exception - https://phabricator.wikimedia.org/T243479 (10Mike_Peel) If you search for ticket numbers (e.g., 'T243479'), then you can reach the corresponding ticket - but no free text searching it seems. [08:14:23] PROBLEM - Free space - all mounts on deployment-logstash03 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash03.diskspace.root.byte_percentfree (<100.00%) [08:24:07] 10Continuous-Integration-Config, 10Operations: cergen CI fails to run on Debian Stretch because cryptography dependency cannot be built against newer openssl version - https://phabricator.wikimedia.org/T212395 (10MoritzMuehlenhoff) p:05Triage→03Normal This task is from 2018, is that still an issue? [08:40:54] 10Phabricator, 10Community-Tech: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10Urbanecm) maybe @CommunityTechBot can do this for us? [08:54:01] https://wikitech.wikimedia.org/wiki/Phabricator#Revert_all_activity_of_a_given_user [08:54:16] that's the procedure generally [08:54:39] I guess doing it by hand is possible but meh [08:56:24] probably can't use that approach now that a partial revert has happened [08:59:59] (03PS4) 10Mainframe98: Fix UnsortedUseStatement sniff handling other content between use statements [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565525 [09:30:01] 10Phabricator, 10Community-Tech: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10ArielGlenn) Did the rest (I think) but someone ought to double check that none were missed. [09:35:07] 10Phabricator, 10Community-Tech: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10Aklapper) >>! In T243481#5825792, @Urbanecm wrote: > maybe @CommunityTechBot can do this for us? `./bin/rollback execute --user some_vandal -d` exists on the server. Se... [09:35:33] 10Phabricator: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10Aklapper) [09:36:10] Urbanecm: see above [09:36:29] (10:56:24 πμ) apergos: probably can't use that approach now that a partial revert has happened [09:36:45] (or maybe a full one if we didn't miss anything) [09:41:23] 10Phabricator: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10ArielGlenn) I don't know that we can do a rollback after there have already been some reverts, maybe? It might not be worth it for a small number of changes like this though https://wiki... [09:55:39] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Ladsgroup) I would be in favor of reducing the code base we maintain and reducing the overhead of maintaining those (upgrading libraries, etc.). I say let's di... [10:04:26] 10Phabricator: Unknown search function "XXX". Supported functions are: all, title, body, core, comment. - https://phabricator.wikimedia.org/T243483 (10jcrespo) Related to T243479 ? [10:08:50] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10Wikidata, 10Wikidata-Query-Service: Grant more rights to wikidata/query/rdf for the group wikidata/query (similar to search) - https://phabricator.wikimedia.org/T243431 (10dcausse) [10:11:53] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10Discovery-Search (Current work): Add mstyles to the gerrit group wikidata/query - https://phabricator.wikimedia.org/T243496 (10dcausse) [10:15:46] 10Phabricator, 10Operations, 10SRE-tools, 10Technical-Debt: Update Puppet repo code that uses deprecated maniphest.update/.createtask/.query Conduit API - https://phabricator.wikimedia.org/T159045 (10Aklapper) [10:16:43] 10Phabricator, 10I18n, 10User-Nikerabbit: Please add Brazilian Portuguese (pt-br) language to Phabricator - https://phabricator.wikimedia.org/T215697 (10Aklapper) [10:17:06] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10Wikidata, 10Wikidata-Query-Service: Grant more rights to wikidata/query/rdf for the group wikidata-query (similar to search) - https://phabricator.wikimedia.org/T243431 (10dcausse) [10:18:37] 10Phabricator, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Operations, 10Traffic, 10serviceops: Phabricator downtime due to aphlict and websockets (aphlict current disabled) - https://phabricator.wikimedia.org/T238593 (10Aklapper) [10:18:47] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10Discovery-Search (Current work): Add mstyles to the gerrit group wikidata-query - https://phabricator.wikimedia.org/T243496 (10dcausse) [10:20:33] 10Phabricator, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): move_project breaks the world when moving a subproject that already has subprojects. - https://phabricator.wikimedia.org/T242254 (10Aklapper) [10:23:55] 10Phabricator: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10Aklapper) 05Open→03Resolved a:03Aklapper Done. Sorry for the interruption, and thanks everyone who helped cleaning up! [10:39:03] 10Phabricator, 10Regression: Searches in phabricator are failing with Unhandled Exception - https://phabricator.wikimedia.org/T243479 (10Aklapper) (For future reference, clear and exact steps to reproduce with URLs are welcome. Phabricator has several searches. See https://www.mediawiki.org/wiki/How_to_report_... [10:39:55] 10Phabricator, 10Regression: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given - https://phabricator.wikimedia.org/T243479 (10Aklapper) p:05Triage→03High [10:40:49] 10Phabricator, 10Regression: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given - https://phabricator.wikimedia.org/T243479 (10Aklapper) [10:42:50] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Daimona) >>! In T243296#5821602, @Legoktm wrote: > I think we could ship it inside the MediaWiki-Codesniffer repo so it doesn't fall behind at least. I think... [10:52:02] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Lucas_Werkmeister_WMDE) And how are we going to resolve all the failures we’ll get once we no longer ignore the MW-CS rules that WB-CS currently disables? I th... [11:03:23] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Daimona) >>! In T243296#5826260, @Lucas_Werkmeister_WMDE wrote: > (Unless “Move the WB ruleset to MW-CS” includes disabling those rules for all of MW-CS?) Sor... [11:03:44] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10thiemowmde) There is a .phpcs.xml in Wikibase. You can move the exclusions you want to keep to this file, including the comments explaining them. [11:04:47] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Lucas_Werkmeister_WMDE) Well, presumably we use WB-CS in more than one repo, so we’d have to duplicate those exclusions again :/ [11:06:02] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Daimona) Not if we move the main ruleset file per T243296#5826268. And, of course, unless it turns out to be impossible to have two different rulesets in MW-CS. [11:29:42] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Ladsgroup) >>! In T243296#5826271, @Lucas_Werkmeister_WMDE wrote: > Well, presumably we use WB-CS in more than one repo, so we’d have to duplicate those exclus... [11:48:53] 10Phabricator: Archive and rename duplicate Phabricator account - https://phabricator.wikimedia.org/T243368 (10Aklapper) [11:49:44] 10Phabricator: Archive and rename duplicate Phabricator account - https://phabricator.wikimedia.org/T243368 (10Aklapper) 05Open→03Resolved a:03Aklapper Done: https://phabricator.wikimedia.org/p/DeletedUser123/ [11:56:50] 10Phabricator, 10Regression: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given - https://phabricator.wikimedia.org/T243479 (10hashar) The file is at https://phabricator.wikimedia.org/source/phabricator/browse/wmf%252... [12:00:29] 10Phabricator (Upstream), 10Upstream: Unknown search function "XXX". Supported functions are: all, title, body, core, comment. - https://phabricator.wikimedia.org/T243483 (10Aklapper) p:05Triage→03Lowest Not related as I've experienced this before. This is expected behavior. Syntax is documented in https:... [12:01:40] 10Phabricator, 10Regression: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given - https://phabricator.wikimedia.org/T243479 (10Aklapper) p:05High→03Unbreak! This seems to also break fetching results in the "Edit P... [12:11:35] 10Phabricator: mass revert of phabricator vandalism by user Nafees791 needed - https://phabricator.wikimedia.org/T243481 (10Xaosflux) Thanks for the cleanup! [12:23:30] sorry if it's been commented on already -- seems that search is broken on phabricator [12:23:41] "Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given, called in /srv/deployment/phabricator/deployment-cache/revs/4547f31de8f69854e0cd9d3e0a802ce517360ee0/phabricator/src/applications/search/query/PhabricatorSearchDocumentQuery.php on line 61" [12:24:17] if it's not known, I'll file a task, but since I couldn't search to see if on already existed I thought I'd comment here first [12:26:31] kostajh: https://phabricator.wikimedia.org/T243479 [12:27:08] Lucas_WMDE: thanks [12:29:49] 10Phabricator, 10Regression: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given - https://phabricator.wikimedia.org/T243479 (10mmodell) 05Open→03Resolved a:03mmodell [12:59:30] 10MediaWiki-Releasing: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 (10Reedy) [13:02:18] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Quibble, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): Quibble should inject php-invoker into MediaWiki core's composer dependencies at run time - https://phabricator.wikimedia.org/T243324 (10Daim... [13:05:15] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Quibble, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): Quibble should inject php-invoker into MediaWiki core's composer dependencies at run time - https://phabricator.wikimedia.org/T243324 (10kost... [13:05:24] 10MediaWiki-Releasing: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 (10Reedy) [13:06:03] 10MediaWiki-Releasing: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 (10Reedy) [13:17:55] 10MediaWiki-Releasing: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 (10Reedy) [13:53:01] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10kostajh) While switching to pcov / phpdbg (pcov seems better aft... [14:43:12] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) Now that we're on PHPUnit 8, I've fiddled a bit with pc... [14:58:57] 10Project-Admins: Create a #Testing-Roadblocks tag - https://phabricator.wikimedia.org/T243453 (10Clarakosi) Thanks, @Aklapper! [16:06:27] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10MediaWiki-Core-Testing, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): PHPUnit: Drop enforceTimeLimit command and related settings, because we can't use p... - https://phabricator.wikimedia.org/T243324 [16:17:13] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: Release a new version of WikibaseCodeSniffer - https://phabricator.wikimedia.org/T243296 (10Jdforrester-WMF) [16:22:21] 10MediaWiki-Releasing: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 (10Jdforrester-WMF) [16:43:30] 10Phabricator (2020-01-23), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Security-Team, 10PermanentlyPrivate: Enforce PermanentlyPrivate tag as on Security Issue type and #security tagged issues - https://phabricator.wikimedia.org/T242638 (10mmodell) [16:46:44] 10Phabricator (2020-01-23), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Security-Team, 10PermanentlyPrivate: Enforce PermanentlyPrivate tag as on Security Issue type and #security tagged issues - https://phabricator.wikimedia.org/T242638 (10mmodell) p:05High→03Normal [16:50:21] (03PS1) 10Jforrester: layout: [mediawiki/extensions/TagContent] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/566800 (https://phabricator.wikimedia.org/T243093) [16:52:10] 10MediaWiki-Codesniffer: PHPCS forbids all attempts to implement interfaces over multiple lines - https://phabricator.wikimedia.org/T243529 (10Daimona) [16:53:15] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Security-Team, 10Security: Need to force users to reset their phabricator TOTP auth factor - https://phabricator.wikimedia.org/T243247 (10mmodell) [16:54:22] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki/extensions/TagContent] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/566800 (https://phabricator.wikimedia.org/T243093) (owner: 10Jforrester) [16:55:20] (03Merged) 10jenkins-bot: layout: [mediawiki/extensions/TagContent] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/566800 (https://phabricator.wikimedia.org/T243093) (owner: 10Jforrester) [16:58:07] 10Phabricator: No results for specific string in Global Phab Search, while Advanced Search lists expected results (due to ElasticSearch for Global Search vs Ferret for Maniphest Search)? - https://phabricator.wikimedia.org/T224082 (10mmodell) 05Open→03Resolved a:03mmodell This specific issue is resolved by... [16:58:26] 10MediaWiki-Codesniffer, 10Upstream: PHPCS forbids all attempts to implement interfaces over multiple lines - https://phabricator.wikimedia.org/T243529 (10Daimona) [17:03:03] 10Phabricator (2020-01-23), 10Regression: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given - https://phabricator.wikimedia.org/T243479 (10mmodell) [17:06:07] 10Phabricator (2020-01-23): No results for specific string in Global Phab Search, while Advanced Search lists expected results (due to ElasticSearch for Global Search vs Ferret for Maniphest Search)? - https://phabricator.wikimedia.org/T224082 (10mmodell) [17:06:40] 10Phabricator (2020-01-23), 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Security-Team, 10Security: Need to force users to reset their phabricator TOTP auth factor - https://phabricator.wikimedia.org/T243247 (10mmodell) [17:17:52] !log layout: [mediawiki/extensions/TagContent] Archive repo T243093 [17:17:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:17:55] T243093: Archive the TagContent extension - https://phabricator.wikimedia.org/T243093 [17:33:24] 10Scap, 10Operations, 10serviceops: Make canary wait time configurable - https://phabricator.wikimedia.org/T217924 (10jijiki) If it is a lot of work to limit when `--canary-wait-time` is available, we could do a graceful rollout, by asking deployers, via `utils.ask/utils.confirm`), to try this flag on, say,... [17:44:32] (03CR) 10Jforrester: "> Patch Set 1:" [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/566406 (owner: 10Legoktm) [18:06:58] (03CR) 10Volans: "@legoktm: FYI there is some (debated) effort to get on the black train on SRE-land too, see T211750 for context (full disclosure: I'm pers" [integration/tox-wikimedia] - 10https://gerrit.wikimedia.org/r/566407 (owner: 10Legoktm) [18:55:19] PROBLEM - Host deployment-elastic05 is DOWN: CRITICAL - Host Unreachable (172.16.5.136) [19:05:19] RECOVERY - Host deployment-elastic05 is UP: PING OK - Packet loss = 0%, RTA = 2.21 ms [19:18:10] 10Release-Engineering-Team, 10ReleaseTaggerBot: Exception: No PHID found for slug #mwwmf_deploy! - https://phabricator.wikimedia.org/T243540 (10Jdforrester-WMF) [19:20:45] James_F: you played with pesticides again, now Phab cannot play with the slugs :P [19:21:01] or perhaps they mean shotgun slug ammo? [19:21:40] hauskatze: I think it's just rare for FR-tech to back-port patches with `Bug:` syntax to wmf_deploy. :-) [19:22:18] Yeah, it's a weird deploy system they use :) [19:22:24] hellooo [19:22:53] we say weird not bad AndyRussG - we still love FR people ;) [19:23:00] well I do [19:23:37] heheh ok thanks hauskatze... likewise eh!!!! <3 [19:24:04] (mmmm yeah "fr-tech" is a ping word for the whole team too) [19:28:28] Well I'm trying to debug why my unit tests fail on ci and work locally, and I've kind of run out of ideas, so the next thing I'm trying is maybe run the docker container locally. Is that a sane debugging approach? [19:29:48] AndyRussG: Ha, sorry. [19:29:54] bawolff: Yes! [19:30:24] bawolff: It might be an environmental issue (different PHP extensions, slightly different builds of PHP), or it might be a race condition/etc. [19:30:43] James_F: oh hey no worries eh ;) cheers [19:31:14] bawolff: I use `docker run --workdir /src --volume ~/code:/src --interative --rm -tty --entrypoint /bin/bash 'docker-registry.wikimedia.org/releng/composer-php74:0.0.1'` or similar. [19:31:34] Thanks, that was going to be my next question :) [19:31:49] Theoretically (***), the CI images reflect actual Wikimedia production quite closely. [19:32:13] In practice, there's some necessary drift because we're using images, and some accidental/unintended. [19:32:29] the thing i'm testing does have some known relation to which php extensions, but i thought i accounted for that, but maybe i accounted wrong, or maybe i was so focused on that i missed something obvious [19:33:07] 10Release-Engineering-Team, 10ReleaseTaggerBot: Exception: No PHID found for slug #mwwmf_deploy! - https://phabricator.wikimedia.org/T243540 (10valhallasw) Discussed on IRC. Made two main changes: * Removed support for old naming styles; this fixes this bug * Removed mw- prefix for tags as this is no longer u... [19:35:35] bawolff: It could well be that the implementation changed or something. [19:36:46] oh, probably helps if i install docker first ;) [19:37:24] * James_F grins. [19:39:35] heya James_F am I doing https://phabricator.wikimedia.org/T242122 right? [19:40:08] ottomata: Yes. But none of it can merge (by policy) until the security review has passed. [19:40:13] ok [19:40:18] so i gotta bug that one first [19:40:19] ty [19:40:26] Always. :-) [19:41:03] Damn security people always in the way ;) [19:44:23] yeah, de-regularize [19:44:33] :P [19:45:43] 10Release-Engineering-Team, 10ReleaseTaggerBot, 10Patch-For-Review: Exception: No PHID found for slug #mwwmf_deploy! - https://phabricator.wikimedia.org/T243540 (10valhallasw) 05Open→03Resolved a:03valhallasw [19:46:07] 10MediaWiki-Releasing: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 (10Reedy) [19:47:51] 10MediaWiki-Releasing: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 (10Reedy) 05Open→03Resolved a:03Reedy https://lists.wikimedia.org/pipermail/mediawiki-announce/2020-January/000245.html [20:21:38] So i guess my issue was that I was trying to be snarky and use an emoji domain in my test case, and some sort of validation in php 7.2 (and only 7.2) didn't like that [20:36:09] Anyways, thanks all for the help :) [20:36:34] And by all i mean James [20:47:14] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T233864 (10brennen) [21:11:43] 10Phabricator, 10Operations, 10SRE-tools, 10Patch-For-Review, 10Technical-Debt: Update Puppet repo code that uses deprecated maniphest.update/.createtask/.query Conduit API - https://phabricator.wikimedia.org/T159045 (10Volans) [21:45:19] (03PS1) 10Jforrester: Drop REL1_32 testing, jobs, and pipelines, EOLed [integration/config] - 10https://gerrit.wikimedia.org/r/566877 [21:45:21] (03PS1) 10Jforrester: jjb: Add REL1_34 to quibble-integration and mediawiki-php-security matrices [integration/config] - 10https://gerrit.wikimedia.org/r/566878 [21:45:45] 10Beta-Cluster-Infrastructure, 10ORES, 10Scoring-platform-team: Failed executing job: ORESFetchScoreJob - https://phabricator.wikimedia.org/T243553 (10MarcoAurelio) [21:48:28] 10Beta-Cluster-Infrastructure, 10ORES, 10Scoring-platform-team: Failed executing job: ORESFetchScoreJob - https://phabricator.wikimedia.org/T243553 (10Halfak) We had a failed deploy earlier today. I'll go clean it up. [21:50:04] (03CR) 10Jforrester: [C: 03+2] Drop REL1_32 testing, jobs, and pipelines, EOLed [integration/config] - 10https://gerrit.wikimedia.org/r/566877 (owner: 10Jforrester) [21:50:36] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/566878 (owner: 10Jforrester) [21:50:57] (03Merged) 10jenkins-bot: Drop REL1_32 testing, jobs, and pipelines, EOLed [integration/config] - 10https://gerrit.wikimedia.org/r/566877 (owner: 10Jforrester) [21:51:27] (03Merged) 10jenkins-bot: jjb: Add REL1_34 to quibble-integration and mediawiki-php-security matrices [integration/config] - 10https://gerrit.wikimedia.org/r/566878 (owner: 10Jforrester) [21:52:21] 10Beta-Cluster-Infrastructure, 10ORES, 10Scoring-platform-team: Failed executing job: ORESFetchScoreJob - https://phabricator.wikimedia.org/T243553 (10Halfak) Should be back online now. [21:59:50] !log Drop REL1_32 testing, jobs, and pipelines, EOLed T242981 [21:59:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:59:52] T242981: Formally EOL MediaWiki 1.32 - https://phabricator.wikimedia.org/T242981 [22:01:00] 10Beta-Cluster-Infrastructure, 10ORES, 10Scoring-platform-team: Failed executing job: ORESFetchScoreJob - https://phabricator.wikimedia.org/T243553 (10MarcoAurelio) 05Open→03Resolved a:03Halfak I see no further errors in Logstash. Thanks! [22:16:17] thcipriani hi, around? :) [22:44:17] 10Continuous-Integration-Config, 10MathSearch: mwext-testextension-zend should load extension mathsearch after math - https://phabricator.wikimedia.org/T117659 (10Jdforrester-WMF) Hey, I'm trying to understand what this task it asking. Is it: # When patches are written in the MathSearch extension, they shoul... [22:49:58] paladox: ish, what's up? [22:50:40] (03PS3) 10Paladox: Bazel: Update bazel to 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/562364 [22:50:48] thcipriani i'm wondering if we could get https://gerrit.wikimedia.org/r/#/c/integration/config/+/562364/ deployed please? :) [22:50:52] (03PS4) 10Paladox: Bazel: Update bazel to 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/562364 [22:50:59] (03PS4) 10Paladox: Gerrit: Upgrade bazel image to 0.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/562365 [22:51:06] thcipriani and https://gerrit.wikimedia.org/r/#/c/integration/config/+/562365/ [22:51:52] paladox: seems like it should be fine. I'll take a closer looks after this next meeting [22:51:59] thanks :) [22:52:18] thcipriani we'll need to backport https://gerrit.googlesource.com/gerrit/+/9acae0640d1708ec25968305d3b61945ae3f488e [22:52:43] that commit fixes issues with building with bazel. [23:40:14] (03CR) 10Thcipriani: [C: 03+2] Bazel: Update bazel to 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/562364 (owner: 10Paladox) [23:40:16] (03CR) 10Thcipriani: [C: 03+2] Gerrit: Upgrade bazel image to 0.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/562365 (owner: 10Paladox) [23:40:19] \o/ [23:40:22] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): Determine if it is possible to migrate remaining integration jessie permanent instances to stretch/buster - https://phabricator.wikimedia.org/T242909 (10jeena) I attempted to run puppet with t... [23:41:06] (03Merged) 10jenkins-bot: Bazel: Update bazel to 2.0 [integration/config] - 10https://gerrit.wikimedia.org/r/562364 (owner: 10Paladox) [23:41:09] (03Merged) 10jenkins-bot: Gerrit: Upgrade bazel image to 0.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/562365 (owner: 10Paladox) [23:43:30] !log Updating docker-pkg files on contint1001 for https://gerrit.wikimedia.org/r/562365 and ttps://gerrit.wikimedia.org/r/562364 [23:43:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:44:11] thcipriani thank you! [23:45:06] paladox: sure thing, thanks for the patches as always :) [23:45:14] :) [23:45:37] (03CR) 10Paladox: "recheck" [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/562363 (owner: 10Paladox) [23:46:10] (03PS2) 10Paladox: Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/562363 [23:46:12] (03PS1) 10Paladox: Bump Bazel version to 2.0.0 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/566890 [23:46:54] (03CR) 10jerkins-bot: [V: 04-1] Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/562363 (owner: 10Paladox) [23:47:03] (03CR) 10jerkins-bot: [V: 04-1] Bump Bazel version to 2.0.0 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/566890 (owner: 10Paladox) [23:47:15] oh [23:47:23] i forgot to update this in a place i think [23:47:24] 23:47:00 Current Bazel version is 0.29.1; expected at least 2.0.0 [23:48:55] (03PS1) 10Paladox: Update 'gerrit-docker' to use ver "0.1.0-s3" [integration/config] - 10https://gerrit.wikimedia.org/r/566891 [23:49:14] (03PS2) 10Paladox: Update 'gerrit-docker' to use ver "0.1.0-s3" [integration/config] - 10https://gerrit.wikimedia.org/r/566891 [23:49:25] thcipriani wondering if you could also do ^ please? :) [23:51:14] * thcipriani looks [23:56:02] thanks! [23:56:34] (03CR) 10Thcipriani: [C: 03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 1" [integration/config] - 10https://gerrit.wikimedia.org/r/566891 (owner: 10Paladox) [23:56:39] :) [23:56:54] paladox: should be deployed [23:57:00] yay! [23:57:02] thanks! [23:57:17] (03CR) 10Paladox: "recheck" [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/562363 (owner: 10Paladox) [23:57:21] (03CR) 10Paladox: "recheck" [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/566890 (owner: 10Paladox) [23:57:28] (03Merged) 10jenkins-bot: Update 'gerrit-docker' to use ver "0.1.0-s3" [integration/config] - 10https://gerrit.wikimedia.org/r/566891 (owner: 10Paladox) [23:58:37] ERROR: Unrecognized option: --incompatible_string_join_requires_strings=false [23:58:38] oh [23:58:42] we need to remove that option [23:59:25] (03PS1) 10Paladox: Bazel remove --incompatible_string_join_requires_strings option [integration/config] - 10https://gerrit.wikimedia.org/r/566895