[00:37:49] thcipriani|afk hi, around? :) [00:46:47] paladox: contentless ping and "afk" in nick :) [00:47:01] you can check out my patch for gerrit lookup() though heh [00:47:06] heh [00:47:29] well.. wait.. compiler says it fails [00:47:41] https://puppet-compiler.wmflabs.org/compiler1002/20571/gerrit1001.wikimedia.org/change.gerrit1001.wikimedia.org.err lol, ok [00:48:34] mutante according to https://puppet.com/docs/puppet/6.10/hiera_automatic.html it says do: [00:48:47] lookup(...., undef, undef, ) [00:49:56] ah yea. fixing [00:55:30] way fewer errors but not all https://puppet-compiler.wmflabs.org/compiler1001/20572/gerrit1001.wikimedia.org/change.gerrit1001.wikimedia.org.err [00:55:44] but the place i work at closes [00:57:01] adds the missing scap_user [04:37:56] 10Gerrit: gerrit-replica is OOMing again, returning 502s on git clones - https://phabricator.wikimedia.org/T243654 (10Legoktm) p:05Triage→03Unbreak! [04:39:37] 10Gerrit: gerrit-replica is OOMing again, returning 502s on git clones - https://phabricator.wikimedia.org/T243654 (10Legoktm) [04:45:52] oh good [04:46:01] well, if I could get the monitoring page to load [05:03:35] 10Gerrit, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): Tune gerrit-replica to be more resilient to the kind of traffic it gets - https://phabricator.wikimedia.org/T243655 (10thcipriani) [05:04:56] 10Gerrit: gerrit-replica is OOMing again, returning 502s on git clones - https://phabricator.wikimedia.org/T243654 (10thcipriani) 05Open→03Resolved a:03thcipriani Here's a threaddump I managed to grab before restarting: https://fastthread.io/my-thread-report.jsp?p=c2hhcmVkLzIwMjAvMDEvMjUvLS1hcGktOTY2ZjljZT... [05:05:16] 10Gerrit, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): Tune gerrit-replica to be more resilient to the kind of traffic it gets - https://phabricator.wikimedia.org/T243655 (10thcipriani) p:05Triage→03Normal [08:14:23] PROBLEM - Free space - all mounts on deployment-logstash03 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash03.diskspace.root.byte_percentfree (<100.00%) [08:58:08] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10DannyS712) @Aklapper {{ping}} its been over a week since I posted my request - is there a standard time frame for this? [09:50:27] (03PS1) 10Reedy: Fix Temporarily typo [tools/scap] - 10https://gerrit.wikimedia.org/r/567198 [09:59:07] (03CR) 10Umherirrender: Let UnsortedUseStatements sniff skip non top-level scopes (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565546 (owner: 10Thiemo Kreuz (WMDE)) [10:02:39] (03PS2) 10Umherirrender: Consolidate duplicate code in UnsortedUseStatements sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565548 (owner: 10Thiemo Kreuz (WMDE)) [10:02:42] (03CR) 10Umherirrender: [C: 03+2] Consolidate duplicate code in UnsortedUseStatements sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565548 (owner: 10Thiemo Kreuz (WMDE)) [10:03:10] (03Merged) 10jenkins-bot: Consolidate duplicate code in UnsortedUseStatements sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565548 (owner: 10Thiemo Kreuz (WMDE)) [10:07:19] 10Scap: Minor improvements to scap help output - https://phabricator.wikimedia.org/T243659 (10Reedy) [10:24:40] (03CR) 10Umherirrender: "When there are more than 3 newlines the new sniff would report twice" (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/566552 (owner: 10Thiemo Kreuz (WMDE)) [10:31:36] 10MediaWiki-Codesniffer, 10User-thiemowmde: Expand PHPUnitAssertEqualsSniff to better auto-fix comparisons with count() - https://phabricator.wikimedia.org/T242762 (10Umherirrender) > Is there an easy way to skip the first parameter in a method call, no matter how complicated the code is? Have a look at Forbi... [10:32:19] 10MediaWiki-Codesniffer: Avoid use of isset( ..., ..., [...] ) function construct / syntax - https://phabricator.wikimedia.org/T219139 (10Umherirrender) 05Open→03Resolved >>! In T219139#5701986, @Umherirrender wrote: > The last question is, if this should be done also for unset() > > I would say yes, becaus... [10:36:32] (03CR) 10Mainframe98: "(whoops; unpublished draft)" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565525 (owner: 10Mainframe98) [10:37:10] (03PS5) 10Mainframe98: Fix UnsortedUseStatement sniff handling other content between use statements [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565525 [11:20:13] (03CR) 10Umherirrender: Rewrite MultipleEmptyLines sniff for performance (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/566552 (owner: 10Thiemo Kreuz (WMDE)) [11:34:43] (03PS2) 10Umherirrender: Fix sniff destroying comments mentioning other variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565021 (https://phabricator.wikimedia.org/T174761) (owner: 10Thiemo Kreuz (WMDE)) [11:34:46] (03CR) 10Umherirrender: [C: 03+2] Fix sniff destroying comments mentioning other variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565021 (https://phabricator.wikimedia.org/T174761) (owner: 10Thiemo Kreuz (WMDE)) [11:35:15] (03Merged) 10jenkins-bot: Fix sniff destroying comments mentioning other variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565021 (https://phabricator.wikimedia.org/T174761) (owner: 10Thiemo Kreuz (WMDE)) [11:43:28] (03CR) 10Umherirrender: Remove a few pieces of unused code from FunctionComment sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565022 (owner: 10Thiemo Kreuz (WMDE)) [14:11:20] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-09 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [14:11:33] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-parsoid10 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [14:11:46] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [14:12:31] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [14:15:02] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [14:16:12] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-09 is OK: HTTP OK: HTTP/1.1 200 OK - 48576 bytes in 3.264 second response time [14:16:22] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-parsoid10 is OK: HTTP OK: HTTP/1.1 200 OK - 48636 bytes in 0.769 second response time [14:16:36] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 37650 bytes in 0.665 second response time [14:17:21] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 49132 bytes in 0.672 second response time [14:19:52] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 48624 bytes in 0.554 second response time [16:10:44] 10Release-Engineering-Team, 10GitHub-Mirrors, 10Pywikibot: Add pywikibot-i18n repository to the pywikibot team in GitHub - https://phabricator.wikimedia.org/T243685 (10Xqt) [16:18:01] PROBLEM - SSH on deployment-ores01 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [16:22:54] RECOVERY - SSH on deployment-ores01 is OK: SSH OK - OpenSSH_7.4p1 Debian-10+deb9u6 (protocol 2.0) [16:38:53] PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [16:51:31] RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [17:06:09] (03PS2) 10Umherirrender: Add another test case for @param comments containing an & [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565024 (https://phabricator.wikimedia.org/T242787) (owner: 10Thiemo Kreuz (WMDE)) [17:06:13] (03CR) 10Umherirrender: [C: 03+2] Add another test case for @param comments containing an & [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565024 (https://phabricator.wikimedia.org/T242787) (owner: 10Thiemo Kreuz (WMDE)) [17:06:47] (03Merged) 10jenkins-bot: Add another test case for @param comments containing an & [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/565024 (https://phabricator.wikimedia.org/T242787) (owner: 10Thiemo Kreuz (WMDE)) [19:03:58] (03PS1) 10D3r1ck01: Mark SemanticTasks extension as archived [integration/config] - 10https://gerrit.wikimedia.org/r/567262 (https://phabricator.wikimedia.org/T221549) [19:12:01] (03CR) 10D3r1ck01: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/567262 (https://phabricator.wikimedia.org/T221549) (owner: 10D3r1ck01) [19:56:15] PROBLEM - SSH on integration-agent-jessie-docker-1001 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [20:01:03] RECOVERY - SSH on integration-agent-jessie-docker-1001 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u8 (protocol 2.0) [20:21:55] PROBLEM - Parsoid on deployment-parsoid09 is CRITICAL: connect to address 172.16.5.63 and port 8000: Connection refused [20:21:55] PROBLEM - Parsoid on deployment-mediawiki-parsoid10 is CRITICAL: connect to address 172.16.0.141 and port 8000: Connection refused [20:41:52] (03CR) 10MarcoAurelio: [C: 03+1] Mark SemanticTasks extension as archived [integration/config] - 10https://gerrit.wikimedia.org/r/567262 (https://phabricator.wikimedia.org/T221549) (owner: 10D3r1ck01) [23:13:43] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth: Add indices for local_user_id and global_user_id in Beta - https://phabricator.wikimedia.org/T148239 (10Aklapper) > Once the local_user_id and global_user_id fields are completely populated on the Beta Cluster, we should add the following index...