[00:33:01] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10User-brennen, 10User-greg: Developer Satisfaction Survey 2020 - https://phabricator.wikimedia.org/T243439 (10brennen) [00:39:53] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10User-brennen: Learn Phabricator update / deployment workflow - https://phabricator.wikimedia.org/T244628 (10brennen) [00:41:20] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10User-brennen: Learn Phabricator update / deployment workflow - https://phabricator.wikimedia.org/T244628 (10brennen) p:05Triage→03Medium [00:43:29] (03CR) 10Umherirrender: "These are the foundings from the extensions:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570955 (owner: 10Umherirrender) [00:46:55] (03PS4) 10Umherirrender: Detect multiple empty lines after single line comment or php open [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570955 [00:52:44] (03CR) 10Umherirrender: "the php open check also find two classes in core:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570955 (owner: 10Umherirrender) [01:57:30] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Analytics, 10Event-Platform, 10Wikimedia-Extension-setup, and 2 others: Deploy EventStreamConfig extension - https://phabricator.wikimedia.org/T242122 (10Jdforrester-WMF) [02:27:30] 10Beta-Cluster-Infrastructure, 10Operations, 10RESTBase, 10Traffic: Restbase routing down on beta, 2020-02-07 - https://phabricator.wikimedia.org/T244586 (10Jdforrester-WMF) [02:33:16] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): Create `watchlist_expiry` table in production after wmf.19 is available - https://phabricator.wikimedia.org/T244631 (10Mooeypoo) [02:34:55] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Community-Tech, 10Expiring-Watchlist-Items, 10TCB-Team: Create `watchlist_expiry` table in production after wmf.19 is available - https://phabricator.wikimedia.org/T244631 (10Jdforrester-WMF) [04:43:15] 10Release-Engineering-Team (CI & Testing services): Constant inheritance not detected in phan block CI - https://phabricator.wikimedia.org/T244633 (10aaron) [04:43:22] 10Release-Engineering-Team (CI & Testing services), 10Performance-Team: Constant inheritance not detected in phan block CI - https://phabricator.wikimedia.org/T244633 (10aaron) [06:00:02] 10Phabricator, 10I18n: Add Turkish (tr) language to Phabricator - https://phabricator.wikimedia.org/T244634 (10abi_) [10:12:37] 10Phabricator: Rename my Phabricator account - https://phabricator.wikimedia.org/T244537 (10Demian) May I request here the same rename for Gerrit? I've found no information about that process. Full name: "Aron Manning" -> "Demian" Username: "aron" -> "Demian" That includes the ssh username too, with a... [10:13:02] 10Gerrit: Rename my Phabricator account - https://phabricator.wikimedia.org/T244537 (10Demian) [10:13:55] 10Gerrit: Rename my Phabricator (done, thx) and Gerrit account - https://phabricator.wikimedia.org/T244537 (10Demian) 05Resolved→03Open [10:14:55] 10Gerrit: Rename my Phabricator (done, thx) and Gerrit account - https://phabricator.wikimedia.org/T244537 (10Demian) [10:43:03] 10Release-Engineering-Team (CI & Testing services), 10Performance-Team, 10Upstream, 10phan: Constant inheritance not detected in phan block CI - https://phabricator.wikimedia.org/T244633 (10Daimona) FTR: This really seems like a phan bug, but I couldn't reproduce the issue with smaller pieces of code. [11:16:02] 10Phabricator, 10Security-Team, 10Security: Make NDA task filing more obvious/prominent - https://phabricator.wikimedia.org/T244156 (10Aklapper) *If* converting (instead of initial creation) also falls under this task, then T244609 would have been another use case [11:20:24] RECOVERY - Free space - all mounts on deployment-logstash03 is OK: OK: All targets OK [11:45:02] 10Beta-Cluster-Infrastructure, 10Operations, 10RESTBase, 10Traffic: Restbase routing down on beta, 2020-02-07 - https://phabricator.wikimedia.org/T244586 (10Krenair) a:03Krenair looks like profile::trafficserver::backend::mapping_rules in hieradata/labs.yaml only has support for mediawiki and upload - it... [11:57:39] 10Beta-Cluster-Infrastructure, 10Operations, 10RESTBase, 10Traffic, 10User-Ryasmeen: Restbase routing down on beta, 2020-02-07 - https://phabricator.wikimedia.org/T244586 (10Krenair) 05Open→03Resolved [12:02:31] 10Beta-Cluster-Infrastructure, 10Operations, 10RESTBase, 10Traffic, 10User-Ryasmeen: Restbase routing down on beta, 2020-02-07 - https://phabricator.wikimedia.org/T244586 (10Krenair) (I added some corrected hieradata to cache-text05 in horizon) [12:59:06] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [13:51:50] 10Project-Admins, 10Office-IT: Scope of #Office-IT project tag in Phabricator? - https://phabricator.wikimedia.org/T242292 (10Aklapper) @eross, @eliza, @JGulingan, @bcampbell, @ggellerman : Friendly ping. Could someone explain how this tag is [not] used? Thanks in advance! :) [13:55:55] (03CR) 10Thiemo Kreuz (WMDE): "I don't really understand. What's the benefit? I was intentionally using isset() in most of these cases because it performs faster, and fe" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570953 (owner: 10Umherirrender) [14:26:08] 10Beta-Cluster-Infrastructure, 10Browser-Support-Firefox: en.wikipedia.beta.wmflabs.org not accessible in Firefox, due to something with OCSP - https://phabricator.wikimedia.org/T243881 (10Krenair) 05Open→03Resolved should be solved now, if it breaks again (within the next few weeks only of course) you can... [14:47:19] PROBLEM - Free space - all mounts on deployment-puppetmaster04 is CRITICAL: CRITICAL: deployment-prep.deployment-puppetmaster04.diskspace.root.byte_percentfree (<10.00%) [14:55:27] root@deployment-puppetmaster04:/# du -hsx /var/log/* | grep G [14:55:27] 5.5G /var/log/daemon.log [14:55:28] 5.5G /var/log/debug [14:55:28] 2.4G /var/log/syslog [14:55:28] 1.8G /var/log/syslog.1 [14:55:44] all seem very verbose [15:22:11] 10Beta-Cluster-Infrastructure, 10Operations: Upgrade puppet in deployment-prep (Puppet agent broken in Beta Cluster) - https://phabricator.wikimedia.org/T243226 (10Krenair) Thanks dpifke. I've seen it do that before too. We probably need to tune it a bit - I recall puppetdb hosts in particular have a hiera set... [15:22:19] RECOVERY - Free space - all mounts on deployment-puppetmaster04 is OK: OK: All targets OK [15:35:39] 10Beta-Cluster-Infrastructure: Ferm failing to start in a new way on deployment-(imagescaler02|mediawiki-09) - https://phabricator.wikimedia.org/T217279 (10Krenair) 05Open→03Resolved Looks like this got solved at some point, shrug [15:41:54] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Do something about deployment-imagescaler01 - https://phabricator.wikimedia.org/T244642 (10Krenair) [15:42:03] 10Beta-Cluster-Infrastructure: Do something about deployment-imagescaler01 - https://phabricator.wikimedia.org/T244642 (10Krenair) [15:44:11] 10Beta-Cluster-Infrastructure, 10Thumbor: thumbor on deployment-imagescaler03 does not want to start with firejail private-dev rule - https://phabricator.wikimedia.org/T221879 (10Krenair) 05Open→03Resolved guess this got fixed at some point: ` krenair@deployment-imagescaler03:~$ sudo service thumbor@8801 s... [15:57:23] PROBLEM - Free space - all mounts on deployment-logstash03 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash03.diskspace.root.byte_percentfree (<44.44%) [15:57:29] (03PS1) 10Thiemo Kreuz (WMDE): Optimize MultipleEmptyLines sniff for peformance (again) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/571003 [15:59:45] (03CR) 10Thiemo Kreuz (WMDE): "Original, before my patch Iee09735:" (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570955 (owner: 10Umherirrender) [16:33:10] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<11.11%) [16:43:08] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [17:13:20] PROBLEM - Free space - all mounts on deployment-puppetmaster04 is CRITICAL: CRITICAL: deployment-prep.deployment-puppetmaster04.diskspace.root.byte_percentfree (<20.00%) [18:36:24] 10Release-Engineering-Team, 10Operations, 10Core Platform Team Workboards (Clinic Duty Team), 10Performance Issue, 10Wikimedia-database-error: WikiPage::updateCategoryCounts causing replication lag due to long-running writes on commonswiki - https://phabricator.wikimedia.org/T240405 (10russblau) As of to... [18:45:14] (03CR) 10Umherirrender: Detect multiple empty lines after single line comment or php open (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570955 (owner: 10Umherirrender) [18:46:40] (03CR) 10Umherirrender: Optimize MultipleEmptyLines sniff for peformance (again) (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/571003 (owner: 10Thiemo Kreuz (WMDE)) [18:49:23] (03Abandoned) 10Umherirrender: Replace isset() by File::numTokens to check for end of array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570953 (owner: 10Umherirrender) [18:53:21] RECOVERY - Free space - all mounts on deployment-puppetmaster04 is OK: OK: All targets OK [18:54:08] (03PS5) 10Umherirrender: Detect multiple empty lines after single line comment or php open [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570955 [18:54:36] (03CR) 10Umherirrender: "Removed parent and changed to --" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/570955 (owner: 10Umherirrender) [18:58:00] 10Beta-Cluster-Infrastructure, 10Browser-Support-Firefox: en.wikipedia.beta.wmflabs.org not accessible in Firefox, due to something with OCSP - https://phabricator.wikimedia.org/T243881 (10Kaartic) @Krenair As of now, I can confirm that this is fixed in both Firefox on Windows and the commons beta app. Thanks... [19:01:26] 10Beta-Cluster-Infrastructure, 10Browser-Support-Firefox: en.wikipedia.beta.wmflabs.org not accessible in Firefox, due to something with OCSP - https://phabricator.wikimedia.org/T243881 (10Kaartic) Also, SSL server test seems to be a lot happier (A) than before (B). Though I notice that it shows "No" near OCSP... [20:24:06] RECOVERY - Free space - all mounts on deployment-logstash2 is OK: OK: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found) [20:44:18] PROBLEM - Free space - all mounts on deployment-puppetmaster04 is CRITICAL: CRITICAL: deployment-prep.deployment-puppetmaster04.diskspace.root.byte_percentfree (<30.00%) [20:45:08] 10Beta-Cluster-Infrastructure, 10Operations: Upgrade puppet in deployment-prep (Puppet agent broken in Beta Cluster) - https://phabricator.wikimedia.org/T243226 (10Krenair) I've moved the remaining instances over to using the new puppetmaster. Puppet does appear to be struggling on deployment-mwmaint01 and dep... [20:46:47] Krenair: I thought you looked at that shinken-wm alert. Why’s it still triggering? [20:47:05] RhinosF1, what, space on puppetmaster04? [20:47:20] Krenair: yeah [20:47:25] I didn't fix it [20:47:39] Ah [20:47:41] I merely deleted enough to make room for what I wanted to do on the host at the time [20:47:56] Fair enough [20:48:00] problem still needs sorting [20:48:14] Someone should do that when they’re around [20:48:17] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: PHPCS forbids all attempts to implement interfaces over multiple lines - https://phabricator.wikimedia.org/T243529 (10Krinkle) 05Invalid→03Open [20:48:34] Krenair: is it worth or needing a phab task? [20:48:54] I expect it should be covered in the existing ticket regarding the creation of the new puppetmaster [20:48:55] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: PHPCS should allow implementing interfaces over multiple lines - https://phabricator.wikimedia.org/T243529 (10Krinkle) [20:49:21] we should address puppetmaster04 disk space, puppetdb03 memory usage, and puppet run time on mwmaint01/puppetmaster03 [20:49:35] Krenair: which task is that? [20:50:07] literally the task between shinken-wm and your message [20:50:45] (03PS1) 10Umherirrender: Ignore self-closing doc comments /***/ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/571016 (https://phabricator.wikimedia.org/T243721) [20:50:55] It’s 9pm on a saturday and i’m new to this channel. Brain fart [20:52:05] 10MediaWiki-Codesniffer: MediaWiki CodeSniffer destroys @param lines when the text contains an & - https://phabricator.wikimedia.org/T242787 (10Umherirrender) 05Open→03Resolved p:05Triage→03Medium a:03thiemowmde [20:52:23] 10MediaWiki-Codesniffer, 10Patch-For-Review: Autofix of sniff MediaWiki.Commenting.DocComment fails / produce invalid file - https://phabricator.wikimedia.org/T243721 (10Umherirrender) p:05Triage→03Medium a:03Umherirrender [20:52:28] 10Beta-Cluster-Infrastructure, 10Operations: Upgrade puppet in deployment-prep (Puppet agent broken in Beta Cluster) - https://phabricator.wikimedia.org/T243226 (10Krenair) a:05Krenair→03None So before closing this task and removing puppetmaster03, someone should address: * puppetdb03 memory usage * puppet... [20:56:51] 10MediaWiki-Codesniffer: Small improve on autofix of MediaWiki.Usage.IsNullSniff possible to avoid unneeded parenthesis - https://phabricator.wikimedia.org/T242780 (10Umherirrender) It seems the following code does not take function call in account ` $innerParenthesis = $phpcsFile->findNext( T_OPEN_PARENT... [21:09:26] (03PS1) 10Legoktm: Merge in cobertura-clover-transform from integration/jenkins [integration/config] - 10https://gerrit.wikimedia.org/r/571017 [21:09:28] (03PS1) 10Legoktm: jjb: Use cobertura-clover-transform from container [integration/config] - 10https://gerrit.wikimedia.org/r/571018 [21:20:38] 10Continuous-Integration-Config, 10tox-wikimedia, 10Test-Coverage: Standardize way to publish test coverage for Python projects in CI - https://phabricator.wikimedia.org/T244650 (10Legoktm) [21:24:05] (03PS1) 10Legoktm: tox: Install gettext [integration/config] - 10https://gerrit.wikimedia.org/r/571019 (https://phabricator.wikimedia.org/T241685) [21:59:05] (03PS1) 10Umherirrender: Detect missing & for ParamNameNoMatch error code and autofix [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/571023 [22:25:53] (03PS1) 10Zoranzoki21: tox: Install tk [integration/config] - 10https://gerrit.wikimedia.org/r/571026 (https://phabricator.wikimedia.org/T240070) [22:30:38] (03CR) 10Legoktm: [C: 04-1] "I think tk is large enough to merit its own container." [integration/config] - 10https://gerrit.wikimedia.org/r/571026 (https://phabricator.wikimedia.org/T240070) (owner: 10Zoranzoki21) [22:32:05] (03CR) 10Zoranzoki21: "> I think tk is large enough to merit its own container." [integration/config] - 10https://gerrit.wikimedia.org/r/571026 (https://phabricator.wikimedia.org/T240070) (owner: 10Zoranzoki21) [22:36:14] (03CR) 10Zoranzoki21: "Uh, you mean that tk should have own container?" [integration/config] - 10https://gerrit.wikimedia.org/r/571026 (https://phabricator.wikimedia.org/T240070) (owner: 10Zoranzoki21) [22:39:55] (03CR) 10Zoranzoki21: "If you mean that tk should have own container, I can try to make it. :)" [integration/config] - 10https://gerrit.wikimedia.org/r/571026 (https://phabricator.wikimedia.org/T240070) (owner: 10Zoranzoki21) [22:57:53] 10MediaWiki-Codesniffer, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Upstream: PHPCS should allow implementing interfaces over multiple lines - https://phabricator.wikimedia.org/T243529 (10DannyS712) [23:45:05] (03CR) 10Legoktm: [C: 04-1] "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/571026 (https://phabricator.wikimedia.org/T240070) (owner: 10Zoranzoki21)