[00:01:14] 10Release-Engineering-Team (Pipeline), 10Analytics, 10Analytics-Kanban, 10Release Pipeline, and 2 others: Migrate EventStreams to k8s deployment pipeline - https://phabricator.wikimedia.org/T238658 (10Ottomata) I think I found the leak. https://github.com/Blizzard/node-rdkafka/issues/731#issuecomment-6009... [00:04:55] 10Beta-Cluster-Infrastructure, 10Puppet: puppetdb on deployment-puppetdb03 keeps getting OOMKilled - https://phabricator.wikimedia.org/T248041 (10Krenair) [00:12:51] (03PS1) 10Jforrester: zuul: [operations/mediawiki-config] Disable tox job for now, as it's failing [integration/config] - 10https://gerrit.wikimedia.org/r/581154 [00:13:26] (03CR) 10Jforrester: [C: 03+2] zuul: [operations/mediawiki-config] Disable tox job for now, as it's failing [integration/config] - 10https://gerrit.wikimedia.org/r/581154 (owner: 10Jforrester) [00:13:34] (03PS2) 10Jforrester: zuul: [operations/mediawiki-config] Disable tox job for now, as it's failing [integration/config] - 10https://gerrit.wikimedia.org/r/581154 (https://phabricator.wikimedia.org/T248040) [00:13:55] (03CR) 10Jforrester: [C: 03+2] "…" [integration/config] - 10https://gerrit.wikimedia.org/r/581154 (https://phabricator.wikimedia.org/T248040) (owner: 10Jforrester) [00:15:15] (03Merged) 10jenkins-bot: zuul: [operations/mediawiki-config] Disable tox job for now, as it's failing [integration/config] - 10https://gerrit.wikimedia.org/r/581154 (https://phabricator.wikimedia.org/T248040) (owner: 10Jforrester) [00:15:38] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10User-DannyS712, 10ci-test-error: operations/mediawiki-config master branch failing tests - https://phabricator.wikimedia.org/T248040 (10Jdforrester-WMF) p:05Unbreak!→03High This wasn't and isn't a train blocker, just a reg... [00:15:45] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10User-DannyS712, 10ci-test-error: operations/mediawiki-config master branch failing tests - https://phabricator.wikimedia.org/T248040 (10Jdforrester-WMF) [00:15:47] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10Jdforrester-WMF) [00:16:43] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10Jdforrester-WMF) [00:18:20] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10User-DannyS712, 10ci-test-error: operations/mediawiki-config master branch failing tests - https://phabricator.wikimedia.org/T248040 (10DannyS712) >>! In T248040#5982478, @Jdforrester-WMF wrote: > This wasn't and isn't a train... [03:27:58] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10Catrope) [05:46:20] Hey folks, asking for Tech News purposes: If I understand things correctly, there will be a train next week, just with precautions for what goes in? In that case, what's the schedule like, with no deploys on Wednesday (Memorial Day)? [05:46:30] https://wikitech.wikimedia.org/wiki/Deployments doesn't say anything about next week. [05:48:54] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Samwilson) [07:12:23] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Legoktm) >>! In T191182#5745897, @mmodell wrote: > Even if you reduce the friction involved with getting a gerr... [08:52:19] (10:49:45 πμ) marostegui: We have a maintenance window in 10 minutes that might affect gerrit, for around 30-45 seconds [09:04:31] Project beta-code-update-eqiad build #288593: 04FAILURE in 1 min 30 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/288593/ [09:14:34] Yippee, build fixed! [09:14:34] Project beta-code-update-eqiad build #288594: 09FIXED in 1 min 33 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/288594/ [09:23:47] 10Continuous-Integration-Infrastructure, 10Operations, 10Traffic, 10Patch-For-Review: Make CI run Varnish VCL tests - https://phabricator.wikimedia.org/T128188 (10ema) >>! In T128188#5143265, @ema wrote: > @hashar can we run it in CI? The catalog needs to be compiled against a given hostname. Perhaps this... [09:23:59] 10Continuous-Integration-Infrastructure, 10Operations, 10Traffic, 10Patch-For-Review: Make CI run Varnish VCL tests - https://phabricator.wikimedia.org/T128188 (10ema) a:05ema→03None [09:53:19] 10Gerrit, 10Vector, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Default to feature branch in Vector - https://phabricator.wikimedia.org/T247890 (10ovasileva) p:05Triage→03High [10:28:14] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10Ladsgroup) [10:34:12] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): Write script to apply security patches - https://phabricator.wikimedia.org/T247075 (10LarsWirzenius) [10:34:14] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap: Automate scap patch - https://phabricator.wikimedia.org/T245185 (10LarsWirzenius) [10:35:05] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): Write script to apply security patches - https://phabricator.wikimedia.org/T247075 (10LarsWirzenius) Ack, I'm working on an acceptance test suite for applying patches, and will be basin... [11:15:56] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Lucas_Werkmeister_WMDE) It’s not resolving for me again. `lines=10 $ LC_ALL=C dig {,m.}wikidata.beta.wmflabs.org @1.1 ; <<>> DiG 9.11.5-P4-5.1ubuntu2.1-Ubuntu <<>> wikidata.beta.wmfla... [11:40:20] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10PHP 8.0 support, 10Technical-Debt: Fix all functions that have required parameters following optional ones - https://phabricator.wikimedia.org/T248078 (10MaxSem) [11:50:40] (03PS1) 10Zoranzoki21: Fix syntax for two whitelisted emails [integration/config] - 10https://gerrit.wikimedia.org/r/581547 [11:52:20] (03PS1) 10Zoranzoki21: Add QEDK in CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/581548 [11:55:03] (03PS1) 10MaxSem: Prohibit required parameters after optional ones [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/581549 (https://phabricator.wikimedia.org/T248078) [12:21:08] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:21:13] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:24:56] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:26:00] ^ could be related to T248013? [12:26:01] T248013: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 [12:26:48] no, nevermind, it still has a DNS entry [12:29:19] (in other words, I’m on the first line of the DNS haiku ;) ) [12:33:04] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Krenair) 05Resolved→03Open [13:09:41] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10hashar) [13:17:25] 10Release-Engineering-Team, 10Repository-Admins, 10Product-Analytics (Kanban): Create a repository and user for Product Analytics Oozie jobs? - https://phabricator.wikimedia.org/T230743 (10mpopov) Requested `analytics/wmf-product` [13:19:47] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 93203 bytes in 1.015 second response time [13:20:58] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 93657 bytes in 1.037 second response time [13:21:05] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 52336 bytes in 1.067 second response time [13:29:50] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10hashar) I have looked at logs, there is not much issues. The blockers have been quickly resolved over night and th... [13:42:02] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10hashar) [14:08:14] (03CR) 10Jforrester: [C: 03+2] "Oops, indeed." [integration/config] - 10https://gerrit.wikimedia.org/r/581547 (owner: 10Zoranzoki21) [14:08:47] (03CR) 10Jforrester: [C: 03+2] Add QEDK in CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/581548 (owner: 10Zoranzoki21) [14:09:10] (03Merged) 10jenkins-bot: Fix syntax for two whitelisted emails [integration/config] - 10https://gerrit.wikimedia.org/r/581547 (owner: 10Zoranzoki21) [14:09:37] (03Merged) 10jenkins-bot: Add QEDK in CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/581548 (owner: 10Zoranzoki21) [14:09:50] !log Zuul: Added QEDK to CI whitelist [14:09:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:30:56] !log made labs-striker self owned [14:30:57] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:38:09] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10PHP 8.0 support, 10MW-1.31-release, and 5 others: Fix all functions that have required parameters following optional ones - https://phabricator.wikimedia.org/T248078 (10Aklapper) [14:44:11] (03CR) 10Jforrester: [C: 03+1] Prohibit required parameters after optional ones [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/581549 (https://phabricator.wikimedia.org/T248078) (owner: 10MaxSem) [15:26:29] Asked earlier, but probably at a time when very few were awake: What's the plan for next week's train? https://wikitech.wikimedia.org/wiki/Deployments notes that Wednesday is Memorial Day and no deploys, but doesn't have the schedule for next week. [15:27:25] thcipriani: ^ [15:33:32] (03PS2) 10Jforrester: Switch example image from old node6 image to current node10 one [blubber] - 10https://gerrit.wikimedia.org/r/580167 [15:34:39] (03PS3) 10Jforrester: Switch example image from old node6 image to current node10 one [blubber] - 10https://gerrit.wikimedia.org/r/580167 [15:35:13] JohanJ: We were planning a normal train. [15:35:22] JohanJ: But maybe we shouldn't. [15:36:00] Wait. No. May isn't March. Sorry. My mistake. I'm two months off. [15:36:40] Ignore my question, I took the lack of schedule to mean that the note below meant something for next week. (: [15:36:47] Ha. [15:36:51] OK, good. [15:36:56] James_F: OK, thanks. [15:37:08] * James_F was worried that he'd lost track of reality. [15:41:24] (03CR) 10Hashar: "The phpunit-standalone stage does not run by default and can not be passed to --run (see inline comment)." (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/577638 (https://phabricator.wikimedia.org/T225068) (owner: 10Jforrester) [15:42:36] hashar: I was intentionally not running by default. [15:43:09] hashar: I guess a no-op stage can be added to a thousand repos just to be used on 3, but it seems a big waste of time. [15:43:39] hashar: And if "default_stages" is values "valid_stages", it should be named appropriately. :-P [15:46:25] andre__: If I need to do a mass change, will I need to request access on phab or just here? I don't need to yet. Probably in a week or so. [15:49:01] RhinosF1: How large a change? If it's big, please file a task and let us run it silently. [15:50:16] James_F: max 2 edits to 17 tasks [15:50:47] Oh, at that size I'd just make them manually. :-) [15:52:01] could be easier tbh, I don't know how simple it's going to be yet as well. [15:52:26] Covid-19 and upstream have changed my entire development plan for a tool [15:52:57] RhinosF1: Just ping, I'd say :) [15:53:06] ok [15:59:31] (03CR) 10Hashar: "I went adding a "@group Standalone" comment to one of Scribunto tests and I can run it with:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/577638 (https://phabricator.wikimedia.org/T225068) (owner: 10Jforrester) [16:04:02] James_F: i will look at writing some kind of execution plan for that quibble standalone feature [16:04:09] not sure what torun exactly for each possible case [16:04:15] nor how ot integrate that in CI [16:05:05] 10Gerrit, 10Vector, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Default to feature branch in Vector - https://phabricator.wikimedia.org/T247890 (10greg) I recommend not to change the default branch to a branch that will not be deployed. We have our guidelines in place ( https://wikite... [16:10:35] hashar: Yeah. [16:11:15] hashar: It'd be wonderful to get this out the door. [16:11:31] gotta write the few use cases [16:11:38] determine the expected outcome [16:11:39] * James_F nods. [16:11:40] and code that ;] [16:11:46] at least I have made some kind of progress locally [16:12:14] php tests/phpunit/phpunit.php --group Standalone /full/path/to/extension [16:12:16] seems to work [16:14:39] I'll split default_stages logic. [16:16:40] (03PS1) 10Jforrester: Split default_stages out into known_stages [integration/quibble] - 10https://gerrit.wikimedia.org/r/581629 [16:17:32] James_F: the phpunit-standalone stage should run by default [16:17:40] it is just that the phpunit command being run has to be adjusted [16:17:45] Why? [16:17:59] eg to not include --testsuite extensions which runs mediawiki/core structure/extensions tests [16:18:06] Yeah, sure. [16:18:17] so the testsuite should be dropped / set to None [16:18:27] we then have to pass the full path to the repo that trigger the patch [16:18:50] But why waste the time running this space for so many repos? [16:18:57] and find out what to do for mediawiki/core (I guess skip it entirely) [16:19:43] We could split into phpunit-notstandalone for the secondary run. [16:20:03] the phpunit discovery apperntly just take 3 seconds [16:20:09] There are probably some core tests that could run as standalone [16:20:21] possibly yeah [16:20:22] 3 seconds here, 3 seconds there, eventually it adds up. [16:20:34] We're trying to get the whole run down to less than 5 minutes. [16:21:50] 10Phabricator, 10TCB-Team: Spaces request for "Technical Wishes Private" - https://phabricator.wikimedia.org/T248104 (10awight) [16:23:36] hashar: what is phpunit discovery? [16:23:58] 3 seconds is an eternity. That's like 50% of our qunit tests, or 7 runs of 3 scenarios with Fresnel. [16:24:13] our CI is not slow. It's faster than my MBP [16:24:35] (ussually) [16:25:18] the step when phpunit discover tests for an extension [16:26:20] then that standalone group would let drop a bunch of slow tests for unrelated repositories. So overall that will be a speed up [16:26:30] No. [16:26:40] We're creating this to run even more things in gate, like Scribunto. [16:26:48] This will make things slower, not faster. [16:26:54] So every second we can spare counts. [16:27:27] Adding a 3 second stage of "look for standlone tests, find there aren't any, exit" to 1000 repos seems like a bad plan. [16:29:26] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10Umherirrender) [16:30:29] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10hashar) We can mass update it using #libup :] [16:30:36] James_F: yeah roger [16:30:38] err [16:30:45] yes I acknowledge that [16:30:53] will go to the drawing board tomorrow about it [16:31:00] 10Project-Admins, 10Multimedia, 10Structured-Data-Backlog: Clarify confusion between Multimedia and Structured Data team and update docs accordingly - https://phabricator.wikimedia.org/T240281 (10Aklapper) [16:38:34] hashar: Thank you. [16:55:32] :]] [16:58:55] 10MediaWiki-Codesniffer, 10PHP 7.4 support: Create a sniff for: PHP Deprecated: The behavior of unparenthesized expressions containing both '.' and '+'/'-' will change in PHP 8: '+'/'-' will take a higher precedence - https://phabricator.wikimedia.org/T248110 (10Umherirrender) [16:59:46] (03CR) 10Dduvall: "> I guess it is just a confusion between the 'master' node (running in the jenkins daemon as jenkins) and contint1001 which is an agent co" [integration/config] - 10https://gerrit.wikimedia.org/r/577678 (https://phabricator.wikimedia.org/T247109) (owner: 10Dduvall) [17:00:42] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10hashar) [17:04:20] (03Abandoned) 10Dduvall: pipeline: Schedule trigger jobs on master node [integration/config] - 10https://gerrit.wikimedia.org/r/577678 (https://phabricator.wikimedia.org/T247109) (owner: 10Dduvall) [17:04:40] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10Jdforrester-WMF) I'll write a patch. [17:05:17] 10MediaWiki-Codesniffer: Review proposed PHPCS 3.5.0 upstream changes - https://phabricator.wikimedia.org/T229040 (10DannyS712) The pull request linked was closed; @Legoktm @Umherirrender can this be closed? [17:14:59] 10MediaWiki-Codesniffer, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10DannyS712) Just found another one: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SideBarMenu/+/581661/2/SideBarMenu.php (line 76) [17:17:15] 10MediaWiki-Codesniffer, 10PHP 8.0 support, 10PHP 7.4 support: Create a sniff for: PHP Deprecated: The behavior of unparenthesized expressions containing both '.' and '+'/'-' will change in PHP 8: '+'/'-' will take a higher precedence - https://phabricator.wikimedia.org/T248110 (10MaxSem) [17:17:55] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10hashar) Train is on all of group0 and group1. There is barely any logs in logstash and Grafana metrics looks fine o... [17:23:51] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10PHP 7.0 support, 10PHP 7.1 support: mediawiki/mediawiki-codesniffer >= 28 causing travis failures in repos which still think they support PHP < 7.2 - https://phabricator.wikimedia.org/T242972 (10DannyS712) [17:28:35] 10MediaWiki-Codesniffer: Remove [] from optional doc parameters - https://phabricator.wikimedia.org/T198022 (10DannyS712) How common is this? A codesearch within php files for `@param .*\[\$`[1] only finds 5 instances, 2 are false positives and the other three are all in #wikibase-datamodel files. Is a sniff nee... [17:30:25] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor, 10Patch-For-Review: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10Jdforrester-WMF) So I spent a fair bit of time re-writing the whole library to have the co... [17:31:01] 10MediaWiki-Codesniffer: MediaWiki.Commenting.FunctionComment.MissingParamTag should handle "@param $var type" a little better - https://phabricator.wikimedia.org/T141412 (10DannyS712) Until a sniff is added, if anyone wants to manually go through and fix these, https://codesearch.wmflabs.org/deployed/?q=%40para... [17:37:10] 10Gerrit, 10Vector, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Default to feature branch in Vector - https://phabricator.wikimedia.org/T247890 (10Jdlrobson) Thanks @greg for the follow up here. If the concern is we don't want a big future release to build up that's totally fine and... [17:40:19] 10Gerrit, 10Vector, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Default to feature branch in Vector - https://phabricator.wikimedia.org/T247890 (10greg) >>! In T247890#5984718, @Jdlrobson wrote: > Thanks @greg for the follow up here. If the concern is we don't want a big future relea... [17:40:22] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10Technical-Debt: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7 - https://phabricator.wikimedia.org/T178136 (10DannyS712) 05Stalled→03Open Unstalling now that {T172165} has been resolved [17:46:18] !log releases/releases-jenkins - closed firewall hole to port 80 for caching servers - kept it open just for envoy from the backends - ATS speaks https to them meanwhile [17:46:19] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:50:22] 10MediaWiki-Codesniffer: Provide Codesniffer rules to enforce primitive types in lowercase in documentation - https://phabricator.wikimedia.org/T172836 (10DannyS712) While there isn't a sniff, manual fixes submitted: * int: https://gerrit.wikimedia.org/r/#/q/topic:lowercase-int+(status:open+OR+status:merged) * b... [17:50:40] 10Gerrit, 10Vector, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Default to feature branch in Vector - https://phabricator.wikimedia.org/T247890 (10Reedy) Another thing is that if we change the default branch, the patches won't be available on beta for testing, unless we change the bra... [18:08:49] 10MediaWiki-Codesniffer: phpcs should error on unclosed @codingStandardsIgnoreStart annotations - https://phabricator.wikimedia.org/T127241 (10DannyS712) Checked current tags, 2 issues found: https://gerrit.wikimedia.org/r/#/q/topic:codingStandardsIgnore-tags+(status:open+OR+status:merged) I think this is rare e... [18:09:32] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10PHP 8.0 support, 10MW-1.35-release, and 2 others: Fix all functions that have required parameters following optional ones - https://phabricator.wikimedia.org/T248078 (10Reedy) Going to untag MW 1.31 (EOL June 2021), MW 1.33 (EOL June 2020) and MW 1.34 (EOL No... [19:35:20] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Krenair) a:03Andrew [19:55:00] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Testing, 10MediaWiki-General: MW/CI allowed two test files with the same class name to exist - https://phabricator.wikimedia.org/T247209 (10Umherirrender) codesniffer has a bootstrap which avoid running it for all files, but that also impact the sniffs like this. Wh... [20:01:33] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10hashar) T248125 might be a result of 1.35.0-wmf.24 (or something else) [20:07:15] 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T233872 (10hashar) 05Open→03Resolved There are a few very minor issues, but none of them seems to be sufficient to justify... [20:55:06] 10MediaWiki-Codesniffer: Review proposed PHPCS 3.5.0 upstream changes - https://phabricator.wikimedia.org/T229040 (10Legoktm) I guess the remaining thing is to evaluate whether https://github.com/squizlabs/PHP_CodeSniffer/pull/2456#issuecomment-580492465 is something we should adopt or not. [21:12:19] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Andrew) This looks to me similar to the issue described here: https://github.com/PowerDNS/pdns/issues/7141 documented at https://doc.powerdns.com/authoritative/backends/generic-sql.h... [21:17:08] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Andrew) I believe that this issue is caused by the _acme-challenge records: MariaDB [designate]> select name from recordsets where name like '%wikidata.beta.wmflabs.org.'; +-----------... [21:28:21] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Krenair) We think this is the same as T218842, I've made an m.wikidata.beta.wmflabs.org A record for it... This feels like it should not be necessary. [21:32:33] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Andrew) Discussed this with pdns devs who seem to regard the rfc as silly but are committed to following it: ` [16:27] The issue I'm seeing is... I have a wildcard do... [21:35:49] 10Beta-Cluster-Infrastructure, 10Cloud-VPS: Wikidata Mobile Beta not resolving - https://phabricator.wikimedia.org/T248013 (10Krenair) 05Open→03Resolved thanks Andrew & pdns devs [21:59:16] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)): Replace integration-trigger-01 with running the dummy job on contint1001 agent - https://phabricator.wikimedia.org/T247109 (10Jdforrester-W... [21:59:20] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Cloud-VPS (Debian Jessie Deprecation): "integration" Cloud VPS project jessie deprecation - https://phabricator.wikimedia.org/T236576 (... [22:01:00] 10Release-Engineering-Team, 10Wikimedia-GitHub: Github Actions do not run correctly on Github mirrors of Gerrit-hosted repositories - https://phabricator.wikimedia.org/T245826 (10Jdforrester-WMF) a:03thcipriani Assigning to Tyler to investigate setting an e-mail for wmfgerrit on GitHub. [22:16:14] 10Project-Admins, 10User-DannyS712: Create #dependency-injection - https://phabricator.wikimedia.org/T247623 (10DannyS712) >>! In T247623#5970949, @Aklapper wrote: > I'm personally still not convinced that people cannot look at open tasks in #cpt-decoupling and/or #mediawiki-servicecontainer to find DI tasks,... [22:17:05] 10Project-Admins: Create Project: Section-Name-Diff - https://phabricator.wikimedia.org/T246484 (10ifried) Hello, @Aklapper. I think it would be helpful to have a specific project tag for 'section name in diff,' rather than generally listing (under MediaWiki-Page-Diffs). This is because the Community Tech team d... [23:00:58] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [23:02:07] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [23:02:14] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [23:09:24] whenever I go to look at this it's already sorted itself out [23:10:52] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 93198 bytes in 5.056 second response time [23:12:05] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 52337 bytes in 1.395 second response time [23:16:58] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 93656 bytes in 1.490 second response time