[00:05:29] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Browser-Tests, and 3 others: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10Krinkle) >>! In T234002#6000499, @gerritbot wrote: > Change 5834...
[00:05:38] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Browser-Tests, 10User-zeljkofilipin: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10Krinkle)
[00:05:41] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Browser-Tests, 10User-zeljkofilipin: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10Krinkle) p:05Triage→03Medium
[00:11:53] <icinga-wm>	 RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[02:09:56] <snowick>	 Hey @bd808 & @goat-g thanks for the help, I'm in looking at logs, will add the steps I missed to the docs
[03:39:09] <wikibugs>	 10Beta-Cluster-Infrastructure, 10User-DannyS712, 10Wikimedia-maintenance-script-run: Run emptyUserGroup on the beta cluster (again) - https://phabricator.wikimedia.org/T248547 (10DannyS712)
[03:53:32] <wikibugs>	 10phan-taint-check-plugin, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), 10Patch-For-Review, and 2 others: Phan warning in "includes/specials/SpecialMobileDiff.php" - working around by disabling - https://phabricator.wikimedia.org/T248360 (10sbassett) >>! In T248360#5998997, @Jdlrobson wrot...
[03:54:35] <wikibugs>	 10Beta-Cluster-Infrastructure, 10User-DannyS712, 10Wikimedia-maintenance-script-run: Run emptyUserGroup on the beta cluster (again) - https://phabricator.wikimedia.org/T248547 (10DannyS712)
[07:44:34] <wikibugs>	 10Release-Engineering-Team, 10serviceops: mw1251 down (no ssh) but still in dsh group? - https://phabricator.wikimedia.org/T248501 (10Joe) p:05High→03Unbreak! a:05Dzahn→03Joe
[08:06:30] <wikibugs>	 10Release-Engineering-Team, 10serviceops: mw1251 down (no ssh) but still in dsh group? - https://phabricator.wikimedia.org/T248501 (10Joe) Not only that, but also mw1252, which is a mcrouter proxy, got decommissioned yesterday.  Fixing both.
[08:35:58] <wikibugs>	 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: mw1251 down (no ssh) but still in dsh group? - https://phabricator.wikimedia.org/T248501 (10Joe) 05Open→03Resolved
[09:12:47] <kart_>	 What is wrong at: https://integration.wikimedia.org/ci/job/mwext-php72-phan-seccheck-docker/43279/console
[09:12:56] <kart_>	 Any idea?
[09:13:04] <kart_>	 PHP Fatal error:  Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/abstractMethodDeclaration7.php on line 3
[09:14:21] <RhinosF1>	 kart_: it's known. https://phabricator.wikimedia.org/T248306
[10:03:30] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10kostajh) > I cant tell what kind of madne...
[10:54:19] <kart_>	 RhinosF1: hmm. I'm not sure, if it is still OK to manually merged patch :/ 
[10:57:48] <Reedy>	 What's the change?
[11:02:37] <kart_>	 Reedy: https://gerrit.wikimedia.org/r/c/583562/
[11:02:58] <Reedy>	 Yeah, see my reply in operations ;P
[11:04:08] <kart_>	 :P
[11:19:03] <awight>	 I've been getting a lot of (happened 2x) this error: 12:14:36 rsync: change_dir "/castor-mw-ext-and-skins/wmf-1.35.0-wmf.25/mwext-php72-phan-seccheck-docker" (in caches) failed: No such file or directory (2)
[11:19:51] <Reedy>	 awight: Are you sure that's the actual failure?
[11:20:06] <Reedy>	 There's a phan failure of stuff being scanned that shouldn't
[11:20:10] <Reedy>	 And a github auth failure too
[11:20:17] <awight>	 Good question, here's the log https://integration.wikimedia.org/ci/job/mwext-php72-phan-seccheck-docker/43293/console
[11:20:41] <Reedy>	 PHP Fatal error:  Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/abstractMethodDeclaration7.php on line 3
[11:20:53] <Reedy>	 Which is a known bug
[11:21:14] <awight>	 I don't quite follow--where is this error displayed?
[11:21:15] <Reedy>	 https://phabricator.wikimedia.org/T248306
[11:21:17] <awight>	 ty
[11:21:33] <Reedy>	 hit show details below setup quibble
[11:21:34] <Reedy>	 scroll down
[11:21:44] <Reedy>	 It's just below
[11:21:45] <Reedy>	      parse ███████████████████████████▓░░░░░░░░░░░░░░░░░░░░░░  55% 1261MB/1261MB
[11:21:45] <Reedy>	      parse ████████████████████████████░░░░░░░░░░░░░░░░░░░░░░  56% 1277MB/1277MB
[11:21:45] <Reedy>	      parse ████████████████████████████▒░░░░░░░░░░░░░░░░░░░░░  57% 1293MB/1293MB
[11:21:45] <Reedy>	      parse █████████████████████████████▒░░░░░░░░░░░░░░░░░░░░  59% 1304MB/1304MB
[11:22:42] <awight>	 Reedy: thanks, it's exactly as you said.
[11:22:50] <Reedy>	 Why it's happening
[11:22:53] <Reedy>	 Is a mystery
[11:23:04] <Reedy>	 The repo in question has a gitattributes that ignores tests, and has for ages
[11:23:06] <awight>	 So this is intermittent and I should keep rechecking?  blargh, I'm trying to SWAT a patch...
[11:23:10] <awight>	 oof
[11:23:12] <Reedy>	 No, it'll always fail
[11:23:21] <Reedy>	 Our Phan config as of the last couple of versions ignores that directory too...
[11:24:06] <awight>	 Darn, I don't see a workaround.
[11:24:45] <Reedy>	 A recheck apparently might help... Sometimes
[11:24:46] <awight>	 Ah fwiw, this isn't a Phan error, it's a PHP fatal
[11:25:01] <awight>	 looks like bumping library versions should fix it?
[11:25:06] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team, 10phan-taint-check-plugin, 10MediaWiki-Vendor, 10ci-test-error: CI error on WMF branches: Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/ab... - https://phabricator.wikimedia.org/T248306
[11:25:21] <Reedy>	 awight: Well, yes and no
[11:25:22] <awight>	 amusing that this fatal error would come from "tolerant-php-parser"
[11:25:24] <Reedy>	 It's purposely broken code
[11:25:30] <Reedy>	 It's supposed to be like that
[11:25:31] <awight>	 oooh lulz
[11:25:37] <Reedy>	 It's just *why* it's getting included
[11:25:47] <Reedy>	 https://github.com/microsoft/tolerant-php-parser/blob/master/.gitattributes#L2-L3
[11:25:54] <Reedy>	 https://github.com/wikimedia/mediawiki-tools-phan/blob/master/src/config.php#L125
[11:26:03] <Reedy>	 So it shouldn't be there in the first place, and it shouldn't be being scanned either
[11:26:34] <awight>	 Looks like it *should* be there, those are attributes, not ignore rules
[11:26:49] <Reedy>	 You know what .gitattributes does, right?
[11:26:58] <Reedy>	 OH
[11:27:05] <Reedy>	 Well, wrong lines
[11:27:06] <Reedy>	 https://github.com/microsoft/tolerant-php-parser/blob/master/.gitattributes#L10
[11:27:07] <Reedy>	 :P
[11:31:26] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team, 10phan-taint-check-plugin, 10MediaWiki-Vendor, 10ci-test-error: CI error on WMF branches: Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/ab... - https://phabricator.wikimedia.org/T248306
[11:34:39] <wikibugs>	 (03CR) 10Reedy: "There's some extra indenting, but I don't see why it should fail like that because of the indenting.. Other files with mixed levels of ind" [integration/config] - 10https://gerrit.wikimedia.org/r/583483 (https://phabricator.wikimedia.org/T106452) (owner: 10BryanDavis)
[11:40:34] <Daimona>	 Reedy: I know what's wrong with the tolerant parser thingy. I'll write down an explanation later today, as soon as I have a bit of free time
[11:40:44] <Reedy>	 <3
[11:41:18] <awight>	 Reedy: Daimona: Awesome.  also, TIL about export-ignore, that seems useful.
[11:41:22] <awight>	 (if it worked ;-)
[11:41:27] <Reedy>	 It does normally
[11:41:34] <Reedy>	 It's how we stop vendor libraries cluttering stuff
[11:41:41] <Reedy>	 I don't know if it's falling back to a normal git clone
[11:41:44] <Reedy>	 And bringing everything with it
[11:42:04] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team, 10phan-taint-check-plugin, 10MediaWiki-Vendor, 10ci-test-error: CI error on WMF branches: Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/ab... - https://phabricator.wikimedia.org/T248306
[11:42:16] <Reedy>	 11:15:36 [265.2MB/29.10s]     Now trying to download from source
[11:42:16] <Reedy>	 11:15:36 [265.2MB/29.10s]   - Installing microsoft/tolerant-php-parser (v0.0.18): [265.2MB/29.75s] Cloning e255aa978b from cache
[11:42:27] <Reedy>	 It's.. odd it's suddenly using a git hash
[11:43:37] <awight>	 Also fwiw, that hash corresponds to v0.0.20 which seems bad and wrong.  https://github.com/microsoft/tolerant-php-parser/commit/e255aa978b45729094da2a1a6f9954044a244ff2
[11:45:47] <Reedy>	 That hash is v0.0.18
[11:45:59] <Reedy>	 As per https://github.com/microsoft/tolerant-php-parser/releases/tag/v0.0.18
[11:46:06] <Reedy>	  v0.0.18
[11:46:06] <Reedy>	  e255aa9
[11:48:43] <awight>	 ty, I am still learning to read
[11:48:59] <Reedy>	 :D
[11:49:36] <Reedy>	 And we require phan 2.5.0
[11:49:37] <Reedy>	 https://packagist.org/packages/phan/phan#2.5.0
[11:49:41] <Reedy>	 microsoft/tolerant-php-parser: 0.0.18
[11:49:51] <Reedy>	 So the version is right, just the way composer is apparently falling back to clone it isn't
[11:50:00] <Reedy>	 Along with the scanning
[11:50:06] <Reedy>	 We'll await Daimona's response ;)
[11:51:49] <shinken-wm>	 PROBLEM - Free space - all mounts on deployment-deploy01 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy01.diskspace._srv.byte_percentfree (<10.00%)
[11:53:16] <wikibugs>	 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10Quality-and-Test-Engineering-Team (QTE), 10Browser-Tests, 10User-zeljkofilipin: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10zeljkofilipin)
[12:01:49] <shinken-wm>	 RECOVERY - Free space - all mounts on deployment-deploy01 is OK: OK: All targets OK
[12:46:48] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team, 10phan-taint-check-plugin, 10MediaWiki-Vendor, 10ci-test-error: CI error on WMF branches: Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/ab... - https://phabricator.wikimedia.org/T248306
[12:48:59] <Daimona>	 ^ There you go
[13:33:27] <wikibugs>	 10Project-Admins, 10Developer-Advocacy (Jan-Mar 2020), 10Editing-team (Tracking), 10PM: Sort out #Editing-Team vs #VisualEditor Phabricator project tags - https://phabricator.wikimedia.org/T234648 (10Aklapper) Whou. Great! Thanks :)
[13:53:05] <wikibugs>	 (03CR) 10Kosta Harlan: Create image for EventLogging service (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/572212 (https://phabricator.wikimedia.org/T223643) (owner: 10Kosta Harlan)
[14:04:59] <wikibugs>	 10phan-taint-check-plugin, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), 10Patch-For-Review, and 2 others: Phan warning in "includes/specials/SpecialMobileDiff.php" - working around by disabling - https://phabricator.wikimedia.org/T248360 (10Daimona) See also T183174. I haven't checked whet...
[14:08:38] <wikibugs>	 10phan, 10MediaWiki-General, 10User-DannyS712: redundant_condition_detection is still suppressed - https://phabricator.wikimedia.org/T248438 (10Daimona) > https://github.com/phan/phan/issues/2943 appears to have been resolved with https://github.com/phan/phan/pull/3176 in September 2019;  My fix was incomple...
[14:40:08] <wikibugs>	 10MediaWiki-Codesniffer, 10MediaWiki-General, 10User-DannyS712: Add global $wgUser to DeprecatedGlobalVariablesSniff - https://phabricator.wikimedia.org/T244452 (10DannyS712) 05Stalled→03Open Now that it is officially being marked as deprecated it should be added for the next release of codesniffer
[14:40:38] <wikibugs>	 (03PS1) 10DannyS712: Add global $wgUser to DeprecatedGlobalVariablesSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/583607 (https://phabricator.wikimedia.org/T244452)
[14:41:27] <wikibugs>	 (03PS2) 10DannyS712: Add global $wgUser to DeprecatedGlobalVariablesSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/583607 (https://phabricator.wikimedia.org/T244452)
[14:45:27] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Add global $wgUser to DeprecatedGlobalVariablesSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/583607 (https://phabricator.wikimedia.org/T244452) (owner: 10DannyS712)
[14:49:06] <wikibugs>	 (03PS3) 10DannyS712: Add global $wgUser to DeprecatedGlobalVariablesSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/583607 (https://phabricator.wikimedia.org/T244452)
[14:51:18] <wikibugs>	 (03CR) 10DannyS712: "> I'm baffled to see such a large chunk of code being duplicated, but" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/582107 (https://phabricator.wikimedia.org/T248183) (owner: 10DannyS712)
[15:20:10] <wikibugs>	 (03CR) 10Daimona Eaytoy: [C: 03+1] Add global $wgUser to DeprecatedGlobalVariablesSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/583607 (https://phabricator.wikimedia.org/T244452) (owner: 10DannyS712)
[15:25:35] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10Krinkle) 05Open→03Resolved
[15:25:37] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: CI mediawiki/core run times have increased since July 26th, 2019 - https://phabricator.wikimedia.org/T232626 (10Krinkle)
[15:25:41] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle)
[15:28:49] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: CI mediawiki/core run times have increased since July 26th, 2019 - https://phabricator.wikimedia.org/T232626 (10Krinkle) 05Open→03Resolved a:03Krinkle >>! **Task description** > {F30299642}  From <https://people.wikimedia.org/~dduvall/jenk...
[15:28:57] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: CI mediawiki/core run times have increased since July 26th, 2019 - https://phabricator.wikimedia.org/T232626 (10Krinkle) a:05Krinkle→03hashar
[15:41:16] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Analytics, 10Analytics-Kanban, 10Release Pipeline, and 2 others: Migrate EventStreams to k8s deployment pipeline - https://phabricator.wikimedia.org/T238658 (10akosiaris) >>! In T238658#5999287, @Ottomata wrote: > Ah we need to merge https://gerrit.wikimedia.org/r/c...
[15:56:19] <wikibugs>	 10Continuous-Integration-Config, 10Wikidata, 10Wikidata-Campsite: Wikibase post-merge builds are failing - https://phabricator.wikimedia.org/T242617 (10Lucas_Werkmeister_WMDE) >>! In T242617#5941610, @Jdforrester-WMF wrote: > I mean, we can switch it back off, but that doesn't get Wikibase documentation fixe...
[15:58:23] <wikibugs>	 10Continuous-Integration-Config, 10Wikidata, 10Wikidata-Campsite: Wikibase post-merge builds are failing - https://phabricator.wikimedia.org/T242617 (10Jdforrester-WMF) Someone who knows what documentation you expect to get generated where builds an entire bespoke job just for you. Normally these kinds of is...
[16:00:34] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Jdforrester-WMF) >>! In T225730#6001349,...
[16:02:55] <wikibugs>	 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10Zuul, 10Code-Health, 10Developer Productivity: Change zuul scheduler's failure check from areAllJobsComplete to didAnyJobFail to abort CI failures earlier - https://phabricator.wikimedia.org/T248596 (10Jdforrester...
[16:07:46] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10SRE-Access-Requests: Grant "contint-roots" and "releasers-mediawiki" to user jforrester - https://phabricator.wikimedia.org/T248597 (10Jdforrester-WMF)
[16:25:33] <wikibugs>	 (03PS1) 10Lucas Werkmeister (WMDE): Remove extension-coverage from Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/583671 (https://phabricator.wikimedia.org/T242617)
[16:26:50] <wikibugs>	 (03CR) 10Lucas Werkmeister (WMDE): Remove extension-coverage from Wikibase (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/583671 (https://phabricator.wikimedia.org/T242617) (owner: 10Lucas Werkmeister (WMDE))
[16:27:31] <wikibugs>	 10phan-taint-check-plugin: phan-taint-check should warn about unnecessary @suppress tags - https://phabricator.wikimedia.org/T203344 (10Daimona) 05Open→03Resolved
[16:28:07] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.0 - https://phabricator.wikimedia.org/T235383 (10Daimona)
[16:28:09] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] Remove extension-coverage from Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/583671 (https://phabricator.wikimedia.org/T242617) (owner: 10Lucas Werkmeister (WMDE))
[16:29:10] <wikibugs>	 (03Merged) 10jenkins-bot: Remove extension-coverage from Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/583671 (https://phabricator.wikimedia.org/T242617) (owner: 10Lucas Werkmeister (WMDE))
[16:29:53] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.0 - https://phabricator.wikimedia.org/T235383 (10Daimona)
[16:30:36] <wikibugs>	 (03PS1) 10Lucas Werkmeister (WMDE): Add extension-coverage to WikibaseQualityConstraints [integration/config] - 10https://gerrit.wikimedia.org/r/583677 (https://phabricator.wikimedia.org/T242444)
[16:32:26] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.0 - https://phabricator.wikimedia.org/T235383 (10Jdforrester-WMF)
[16:33:59] <wikibugs>	 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Analytics, and 2 others: Migrate analytics/refinery/source release jobs to Docker - https://phabricator.wikimedia.org/T210271 (10hashar) Instead of using `ssh-a...
[16:34:54] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.0 - https://phabricator.wikimedia.org/T235383 (10Jdforrester-WMF) ` $ git log --topo-order --no-merges --oneline  2.1.0.. 3094900 Fix phan crash when analyzing MediaWiki core 558af65 Add RAW_PARAM taint type 59bb9c6 build: Upgrade mediawiki-codesniffer from v29....
[16:35:09] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.0 - https://phabricator.wikimedia.org/T235383 (10Jdforrester-WMF)
[16:35:21] <wikibugs>	 (03CR) 10Lucas Werkmeister (WMDE): Add extension-coverage to WikibaseQualityConstraints (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/583677 (https://phabricator.wikimedia.org/T242444) (owner: 10Lucas Werkmeister (WMDE))
[16:35:57] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.0 - https://phabricator.wikimedia.org/T235383 (10Daimona) >>! In T235383#6002460, @Jdforrester-WMF wrote: > Good to go?  Yes, thanks! I'm going to tag it.
[16:36:07] <wikibugs>	 (03PS6) 10Hashar: jjb: migrate refinery release job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271)
[16:46:15] <James_F>	 hashar: "fatal: ref HEAD is not a symbolic ref"
[16:46:33] <James_F>	 hashar: Maybe it's assuming it's only ever running in named branches?
[16:46:38] <hashar>	 yeah
[16:46:45] <hashar>	 the detached state does not quite work
[16:46:48] <James_F>	 (Also yay, IRCCloud worked again.)
[16:46:57] <James_F>	 Not being able to run zuul-cloner would be a pain.
[16:47:32] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] Add extension-coverage to WikibaseQualityConstraints [integration/config] - 10https://gerrit.wikimedia.org/r/583677 (https://phabricator.wikimedia.org/T242444) (owner: 10Lucas Werkmeister (WMDE))
[16:47:54] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.0 - https://phabricator.wikimedia.org/T235383 (10Daimona) 05Open→03Resolved {{[[https://gerrit.wikimedia.org/g/mediawiki/tools/phan/SecurityCheckPlugin/+/refs/tags/3.0.0|Done]]}}!
[16:47:56] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.1 - https://phabricator.wikimedia.org/T240069 (10Daimona)
[16:48:08] <James_F>	 Daimona: Now to manually rev it in 200 repos. :-(
[16:48:25] <James_F>	 231 repos, according to codesearch.
[16:48:33] <wikibugs>	 (03Merged) 10jenkins-bot: Add extension-coverage to WikibaseQualityConstraints [integration/config] - 10https://gerrit.wikimedia.org/r/583677 (https://phabricator.wikimedia.org/T242444) (owner: 10Lucas Werkmeister (WMDE))
[16:49:33] <Daimona>	 James_F: No, not yet :)
[16:49:54] <James_F>	 Oh, you think we're going to rev everything straight to 3.0.1?
[16:49:55] <Daimona>	 Actually, I think we don't need it at all
[16:49:59] <Daimona>	 Neither
[16:50:14] <Daimona>	 I'd like to tag 3.0.1, and then merge into the other phan thing
[16:50:23] <James_F>	 Oh, are we ready for that?
[16:50:24] <Daimona>	 So we'll only have to upgrade mediawiki-phan and remove taint-check altogether
[16:50:28] <James_F>	 If so, that'd be great.
[16:50:30] <Daimona>	 After 3.0.1, yes
[16:50:35] <Daimona>	 We need the phan version to be synced
[16:50:35] <James_F>	 Cool.
[16:50:40] <wikibugs>	 (03PS7) 10Hashar: jjb: migrate refinery release job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271)
[16:50:42] <James_F>	 Yeah, that's just a sub-dependency.
[16:50:42] <wikibugs>	 (03PS1) 10Hashar: docker: java8 should checkout in a branch [integration/config] - 10https://gerrit.wikimedia.org/r/583683 (https://phabricator.wikimedia.org/T210271)
[16:50:45] <James_F>	 No biggie.
[16:50:59] <Daimona>	 In fact, 3.0.1 is just for syncing versions
[16:51:25] <James_F>	 Right.
[16:52:02] <James_F>	 And we'll get LibUp to drop the "phan-taint-check-plugin" key from the "extra" field.
[16:52:20] <hashar>	 James_F: https://gerrit.wikimedia.org/r/#/c/integration/config/+/583683/1/dockerfiles/java8/run.sh :]
[16:52:36] <James_F>	 hashar: Ha.
[16:52:44] <James_F>	 That might help.
[16:52:50] <hashar>	 yeah it seems to help
[16:53:16] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "Poor maven :)" [integration/config] - 10https://gerrit.wikimedia.org/r/583683 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar)
[16:53:44] <hashar>	 I cant believe I have spend most of my time this week on this conversion bah :/
[16:53:49] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.1 - https://phabricator.wikimedia.org/T240069 (10Jdforrester-WMF)
[16:54:08] <James_F>	 hashar: Yeah. :-(
[16:54:22] <wikibugs>	 (03Merged) 10jenkins-bot: docker: java8 should checkout in a branch [integration/config] - 10https://gerrit.wikimedia.org/r/583683 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar)
[16:54:47] <Daimona>	 <James_F> And we'll get LibUp to drop the "phan-taint-check-plugin" key from the "extra" field. <-- Exactly, yes
[16:54:55] * James_F sighs.
[16:55:04] <James_F>	 I foresee myself having to write yet more damn Python. ;-)
[16:55:04] <Daimona>	 Tagging 3.0.1 now
[16:55:08] <James_F>	 Cool.
[16:56:44] <wikibugs>	 10phan-taint-check-plugin: Release taint-check 3.0.1 - https://phabricator.wikimedia.org/T240069 (10Daimona) 05Open→03Resolved Aaaand {{[[https://gerrit.wikimedia.org/g/mediawiki/tools/phan/SecurityCheckPlugin/+/refs/tags/3.0.1|Done]]}}.
[16:56:48] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Daimona)
[16:57:14] <Daimona>	 Done, let's see what happens
[16:57:31] <Daimona>	 Good thing is, we enabled that job to test phan changes in real time, so we should see how it goes
[16:57:59] <James_F>	 Yeah.
[16:59:09] <ejegg>	 thanks Reedy, James_F and bd808 for the fix for the github authentication! Our CiviCRM tests are passing now.
[16:59:26] <ejegg>	 and anyone else who helped
[16:59:28] <James_F>	 ejegg: I don't think bd808's fix is deployed yet.
[16:59:38] <James_F>	 So it might just be passing-for-now. :-(
[16:59:53] <James_F>	 I'm going to look at those after I've dealt with phan issues.
[17:00:21] <Reedy>	 no it's not... lol https://gerrit.wikimedia.org/r/#/c/integration/config/+/583483/
[17:03:22] <Daimona>	 Why the heck is jenkins unable to merge a commit? https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/+/578058/
[17:03:37] <Daimona>	 I've already rebased it, even if it was up-to-date
[17:04:29] <Daimona>	 And same for the other one, it was up-to-date but it failed thrice
[17:06:56] <wikibugs>	 (03PS1) 10Reedy: Remove makerelease.py [tools/release] - 10https://gerrit.wikimedia.org/r/583686
[17:07:19] <ejegg>	 oooh, well, thanks for all the work you've put in so far
[17:08:16] <wikibugs>	 10Beta-Cluster-Infrastructure, 10MediaWiki-API, 10Pywikibot, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Attempt to login fails several times - https://phabricator.wikimedia.org/T224712 (10Dvorapa) The patch just partially workarounds one loop. But does not resolve anything
[17:10:39] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Daimona)
[17:11:34] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10SRE-Access-Requests, 10Patch-For-Review: Grant "contint-roots" and "releasers-mediawiki" to user jforrester - https://phabricator.wikimedia.org/T248597 (10Volans) p:05Triage→03Medium a:03thcipriani Over to @th...
[17:11:56] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Daimona)
[17:12:32] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10SRE-Access-Requests, 10Patch-For-Review: Grant "contint-roots" and "releasers-mediawiki" to user jforrester - https://phabricator.wikimedia.org/T248597 (10thcipriani) approved.
[17:22:14] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10SRE-Access-Requests, 10Patch-For-Review: Grant "contint-roots" and "releasers-mediawiki" to user jforrester - https://phabricator.wikimedia.org/T248597 (10Volans) a:05thcipriani→03Volans Patch merged, changes wi...
[17:28:49] <James_F>	 Daimona: Well, rebasing away from master and then back worked…
[17:28:55] <James_F>	 Daimona: No idea why.
[17:29:01] <Daimona>	 Ah, well...
[17:29:06] <Reedy>	 jgit being craptastic? :P
[17:29:13] <James_F>	 Reedy: Probably.
[17:29:35] <Reedy>	 It is very special
[17:29:45] <wikibugs>	 (03PS8) 10Hashar: jjb: migrate refinery release job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271)
[17:30:31] <wikibugs>	 (03CR) 10Hashar: "I had to pass project.scm.developerConnection to switch to https. The project pom.xml uses ssh." [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar)
[17:35:39] <Daimona>	 Ahem, gate-and-submit isn't triggering?!
[17:36:03] <James_F>	 Daimona: Wasn't it? Or did your rebase just cancel it?
[17:36:21] <Daimona>	 It wasn't, I tried a rebase and it still isn't
[17:36:36] <James_F>	 How did you rebase it?
[17:36:39] <James_F>	 It was already on master.
[17:37:04] <Daimona>	 As usual -- it lets you rebase even if up-to-date
[17:37:17] <Daimona>	 I see it got a merge failed after your +2 and before my rebase
[17:37:18] <James_F>	 Not if you use new-gerrit.
[17:37:32] <Daimona>	 Locally, I mean
[17:37:35] <James_F>	 Yes, the merge-failed is from the gate process.
[17:37:46] <James_F>	 This is tedious.
[17:39:49] <Daimona>	 Perhaps trying a manual submit and see if this unblocks the dependent commit?
[17:40:39] <James_F>	 Fine.
[17:40:57] <wikibugs>	 10MediaWiki-Releasing, 10Security: Write and send release announcements for MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240395 (10Reedy)
[17:41:24] <wikibugs>	 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240393 (10Reedy) 05Open→03Resolved a:03Reedy
[17:41:27] <wikibugs>	 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240393 (10Reedy)
[17:41:35] <wikibugs>	 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240392 (10Reedy)
[17:42:31] <wikibugs>	 10MediaWiki-Releasing, 10Security: Update onwiki release notes for 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240396 (10Reedy)
[17:42:39] <wikibugs>	 10MediaWiki-Releasing, 10Security: Update HISTORY in master after 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240397 (10Reedy)
[17:42:44] <wikibugs>	 10MediaWiki-Releasing, 10Security: Tag 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240398 (10Reedy)
[17:45:06] <wikibugs>	 10MediaWiki-Releasing, 10Security: Obtain CVEs for 1.31.7/1.33.3/1.34.1 security releases - https://phabricator.wikimedia.org/T240399 (10Reedy)
[17:45:38] <James_F>	 Oh, right, Zuul is catastro-loaded by Reedy with all his security patches, some of which have failed.
[17:48:10] <Reedy>	 James_F: First come first served
[17:48:11] * Reedy hides
[17:48:20] <James_F>	 Yeah yeah. :-)
[17:48:30] <Reedy>	 They're going through quicker than previous editions
[17:48:35] <Reedy>	 So progress
[17:48:43] <James_F>	 Yes, because we split the pipelines.
[17:48:51] <James_F>	 So they don't stomp over each other.
[17:49:01] <Reedy>	 That's what I mean, progress!
[17:49:16] <James_F>	 Same limited capacity in CI, however. :-P
[17:49:40] <Reedy>	 bloody release note line length
[17:49:47] <James_F>	 Sorry.
[17:56:12] <icinga-wm>	 PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[18:04:02] <Daimona>	 James_F: it worked!
[18:04:56] <Daimona>	 Although the thing per se doesn't work https://integration.wikimedia.org/ci/job/mw-tools-phan-mwcore-testrun/21/console
[18:05:16] <Daimona>	 I'll try to fix it later
[18:05:32] <James_F>	 ../../vendor looks wrong; won't it just be one ..?
[18:06:09] <Daimona>	 Something's wrong with $VP
[18:06:54] <Daimona>	 Actually, I should find a prettier way to import that file, without using $VP
[18:07:01] <James_F>	 That'd be nice, yes.
[18:07:06] * James_F shrugs.
[18:07:09] <Daimona>	 It may also be caused by the hacks in the testrun job
[18:07:15] <James_F>	 Plausibly.
[18:07:22] <wikibugs>	 10MediaWiki-Releasing, 10Security: Tag 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240398 (10Reedy) 05Open→03Resolved a:03Reedy
[18:07:25] <wikibugs>	 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240392 (10Reedy)
[18:12:07] <wikibugs>	 (03PS9) 10Hashar: jjb: migrate refinery release job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271)
[18:12:30] <wikibugs>	 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Analytics, and 2 others: Migrate analytics/refinery/source release jobs to Docker - https://phabricator.wikimedia.org/T210271 (10hashar) I have instructed Maven...
[18:14:29] <wikibugs>	 10MediaWiki-Releasing, 10Patch-For-Review, 10Security: Update HISTORY in master after 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240397 (10Reedy) a:03Reedy
[18:15:38] <wikibugs>	 10MediaWiki-Releasing, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (MediaWiki 1.31.7/1.33.3/1.34.1) - https://phabricator.wikimedia.org/T240400 (10Reedy)
[18:28:48] <wikibugs>	 10MediaWiki-Releasing, 10Security: Update onwiki release notes for 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240396 (10Reedy) 05Open→03Resolved a:03Reedy
[18:28:51] <wikibugs>	 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240392 (10Reedy)
[18:34:27] <wikibugs>	 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240393 (10Reedy) >>! In T240393#6002789, @DannyS712 wrote: > @Reedy I've hidden this again - {T232932} still isn't public (I can't see it) but the fact that the patch file is included here me...
[18:34:30] <wikibugs>	 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240393 (10Reedy)
[18:45:23] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops, 10Services (watching): TEC3:O3:O3.1:Q3 Goal - Move cxserver, citoid, changeprop, eventgate (new service) and ORES (partially) through the production CD Pipel... - https://phabricator.wikimedia.org/T212801
[18:45:27] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10ChangeProp, 10Release Pipeline, and 3 others: Migrate changeprop to kubernetes - https://phabricator.wikimedia.org/T213193 (10holger.knust) 05Open→03Resolved
[18:47:04] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10ChangeProp, 10Release Pipeline, and 3 others: Migrate changeprop to kubernetes - https://phabricator.wikimedia.org/T213193 (10Pchelolo) Are you planning to file a new ticket for migrating all the rules to k8s change-prop? The work he...
[18:55:02] <icinga-wm>	 RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[19:00:39] <wikibugs>	 10MediaWiki-Releasing, 10Patch-For-Review, 10Security: Update HISTORY in master after 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240397 (10Reedy) 05Open→03Resolved
[19:00:42] <wikibugs>	 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240392 (10Reedy)
[19:05:23] <wikibugs>	 (03PS1) 10Daimona Eaytoy: [WIP] Test [integration/config] - 10https://gerrit.wikimedia.org/r/583726
[19:08:41] <wikibugs>	 (03PS2) 10Daimona Eaytoy: [WIP] Test [integration/config] - 10https://gerrit.wikimedia.org/r/583726
[19:09:34] <Daimona>	 James_F: Could you please test whether https://gerrit.wikimedia.org/r/#/c/integration/config/+/583726/ fixes it?
[19:10:05] <James_F>	 Not trivially. I could build the image and bump the job for you?
[19:12:56] <wikibugs>	 (03PS3) 10Jforrester: dockerfiles: [mediawiki-phan-testrun] Set MW_VENDOR_PATH [integration/config] - 10https://gerrit.wikimedia.org/r/583726 (owner: 10Daimona Eaytoy)
[19:13:07] <Daimona>	 Huh, I guess... I don't know how it works precisely :/
[19:13:25] <James_F>	 Let's give it a go.
[19:13:26] <wikibugs>	 (03PS1) 10Jforrester: jjb: [mw-tools-phan-mwcore-testrun] Bump to new container [integration/config] - 10https://gerrit.wikimedia.org/r/583730
[19:15:50] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/583726 (owner: 10Daimona Eaytoy)
[19:17:07] <wikibugs>	 (03Merged) 10jenkins-bot: dockerfiles: [mediawiki-phan-testrun] Set MW_VENDOR_PATH [integration/config] - 10https://gerrit.wikimedia.org/r/583726 (owner: 10Daimona Eaytoy)
[19:17:48] <James_F>	 !log Docker: Pushing mediawiki-phan-testrun:0.1.5
[19:21:05] <James_F>	 Daimona: Looks to be working.
[19:21:13] <James_F>	 (Test run at https://integration.wikimedia.org/ci/job/mw-tools-phan-mwcore-testrun/23/console )
[19:21:36] <Daimona>	 Aye! Thanks!
[19:21:45] <Daimona>	 BTW, I think using $VP is our best choice
[19:21:53] * James_F nods.
[19:22:01] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/583730 (owner: 10Jforrester)
[19:22:41] <James_F>	 Daimona: Once we combine the phan and phan-seccheck jobs, the next step is to combine the phan and composer-test ones.
[19:22:55] <wikibugs>	 (03Merged) 10jenkins-bot: jjb: [mw-tools-phan-mwcore-testrun] Bump to new container [integration/config] - 10https://gerrit.wikimedia.org/r/583730 (owner: 10Jforrester)
[19:23:09] <Daimona>	 Might be beneficial, yes -- note that it's going to eat a lot of memory though
[19:23:20] <James_F>	 Yes, but it already does.
[19:23:28] <James_F>	 Two jobs is more expensive than one.
[19:23:52] <James_F>	 There's no pipeline where we have phan present but don't run it, but do run composer-test.
[19:23:59] <James_F>	 (I think.)
[19:25:17] <Daimona>	 Makes sense
[19:25:40] <James_F>	 00:06:03.328 includes/user/User.php:4550 SecurityCheck-XSS Calling method \User::sendMail() in \User::sendConfirmationMail that outputs using tainted argument $[arg #4]. (Caused by: includes/user/User.php +4575) (Caused by: includes/user/User.php +4528)
[19:25:41] <James_F>	 00:06:03.328 languages/converters/IuConverter.php:155 PhanTypeArraySuspiciousNullable Suspicious array access to nullable \ReplacementArray[]|array<string,\ReplacementArray>|array<string,true>|bool[]|null
[19:25:45] <James_F>	 In the same run! Hurrah.
[19:25:52] <James_F>	 Let's merge?
[19:30:09] <wikibugs>	 (03PS5) 10Kosta Harlan: Provide support for setting default configuration in dev image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/582498 (https://phabricator.wikimedia.org/T247072)
[19:36:22] <Daimona>	 Yeah, sure!
[19:36:37] <Daimona>	 (I was multitasking... Very poorly!)
[19:36:39] <wikibugs>	 (03PS1) 10Krinkle: Prefer 'npm ci' instead of 'npm prune' + 'npm install' [integration/quibble] - 10https://gerrit.wikimedia.org/r/583736 (https://phabricator.wikimedia.org/T234738)
[19:37:28] <James_F>	 Daimona: … and it merge fails.
[19:37:34] * James_F sighs.
[19:37:46] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Prefer 'npm ci' instead of 'npm prune' + 'npm install' [integration/quibble] - 10https://gerrit.wikimedia.org/r/583736 (https://phabricator.wikimedia.org/T234738) (owner: 10Krinkle)
[19:37:53] <Daimona>	 Geez
[19:38:16] <wikibugs>	 (03CR) 10Jforrester: "Neat." [integration/quibble] - 10https://gerrit.wikimedia.org/r/583736 (https://phabricator.wikimedia.org/T234738) (owner: 10Krinkle)
[19:38:22] <Daimona>	 That's annoying though
[19:39:07] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Patch-For-Review: Quibble jobs re-download npm packages every build (Castor not loading?) - https://phabricator.wikimedia.org/T234738 (10Krinkle) p:05Triage→03Medium a:03Krinkle
[19:41:43] <wikibugs>	 (03PS2) 10Krinkle: Prefer 'npm ci' instead of 'npm prune' + 'npm install' [integration/quibble] - 10https://gerrit.wikimedia.org/r/583736 (https://phabricator.wikimedia.org/T234738)
[19:44:53] <wikibugs>	 (03PS10) 10Hashar: jjb: migrate refinery release job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271)
[19:48:18] <James_F>	 Daimona: Ah, you force-merged.
[19:48:23] * James_F was investigating.
[19:49:35] <Daimona>	 No, I just retried
[19:49:48] <Daimona>	 With CR+2
[19:49:54] <James_F>	 Huh.
[19:49:56] <James_F>	 Very odd.
[19:49:56] <Daimona>	 And it succeeded, apparently...
[19:50:22] <James_F>	 https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/+/583738 should also land, BTW>
[19:52:05] <Daimona>	 Oh, cool, I didn't know about that...
[19:52:16] <James_F>	 Apparently neither did anyone else. :-)
[19:52:22] <Daimona>	 Yeah indeed
[19:52:40] <Daimona>	 I'll tag 0.10.0 later or tomorrow, barring objections
[19:52:49] <James_F>	 Cool.
[19:53:27] <wikibugs>	 (03CR) 10Umherirrender: [C: 03+1] Add global $wgUser to DeprecatedGlobalVariablesSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/583607 (https://phabricator.wikimedia.org/T244452) (owner: 10DannyS712)
[19:53:33] <Daimona>	 (Of note, phan seems to be much slower now -- which is sort of expected, but I'll investigate anyway)
[19:53:43] <James_F>	 Yes.
[19:58:27] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Jdforrester-WMF)
[19:59:23] <wikibugs>	 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Analytics, and 2 others: Migrate analytics/refinery/source release jobs to Docker - https://phabricator.wikimedia.org/T210271 (10hashar) Finally a successful bu...
[20:13:50] <shinken-wm>	 PROBLEM - Free space - all mounts on deployment-deploy01 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy01.diskspace._srv.byte_percentfree (<10.00%)
[20:16:14] <wikibugs>	 (03CR) 10Kosta Harlan: [C: 03+1] Prefer 'npm ci' instead of 'npm prune' + 'npm install' [integration/quibble] - 10https://gerrit.wikimedia.org/r/583736 (https://phabricator.wikimedia.org/T234738) (owner: 10Krinkle)
[20:21:37] <wikibugs>	 10MediaWiki-Releasing, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (MediaWiki 1.31.7/1.33.3/1.34.1) - https://phabricator.wikimedia.org/T240400 (10sbassett)
[20:23:48] <shinken-wm>	 RECOVERY - Free space - all mounts on deployment-deploy01 is OK: OK: All targets OK
[20:27:50] <wikibugs>	 10MediaWiki-Releasing, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (MediaWiki 1.31.7/1.33.3/1.34.1) - https://phabricator.wikimedia.org/T240400 (10sbassett) {{draft}}  Subject: MediaWiki Extensions and Skins Security Release Su...
[20:29:03] <wikibugs>	 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.25 deployment blockers - https://phabricator.wikimedia.org/T233873 (10mmodell) 05Open→03Resolved
[20:31:53] <wikibugs>	 10MediaWiki-Releasing, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (MediaWiki 1.31.7/1.33.3/1.34.1) - https://phabricator.wikimedia.org/T240400 (10DannyS712) Given that none of the listed tasks are private, does the note about...
[20:32:30] <wikibugs>	 10MediaWiki-Releasing, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (MediaWiki 1.31.7/1.33.3/1.34.1) - https://phabricator.wikimedia.org/T240400 (10Reedy) >>! In T240400#6003324, @DannyS712 wrote: > Given that none of the listed...
[20:43:15] <wikibugs>	 10MediaWiki-Releasing, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (MediaWiki 1.31.7/1.33.3/1.34.1) - https://phabricator.wikimedia.org/T240400 (10sbassett) 05Open→03Resolved Done and done.  https://lists.wikimedia.org/pipe...
[20:43:18] <wikibugs>	 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240392 (10sbassett)
[20:47:25] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] Prefer 'npm ci' instead of 'npm prune' + 'npm install' [integration/quibble] - 10https://gerrit.wikimedia.org/r/583736 (https://phabricator.wikimedia.org/T234738) (owner: 10Krinkle)
[20:48:11] <wikibugs>	 (03Merged) 10jenkins-bot: Prefer 'npm ci' instead of 'npm prune' + 'npm install' [integration/quibble] - 10https://gerrit.wikimedia.org/r/583736 (https://phabricator.wikimedia.org/T234738) (owner: 10Krinkle)
[20:50:41] <James_F>	 Krinkle: There are a couple of changes we're close to landing in quibble, so that should roll out reasonably soon.
[21:26:52] <Daimona>	 James_F: I can tag phan 0.10 now. May I amend https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/+/583738/ and replace "forthcoming" with "0.10.0"?
[21:30:31] <James_F>	 Daimona: Sure! Or do them as different patches?
[21:30:43] <Daimona>	 Different patches is fine
[21:30:45] <James_F>	 So we have a patch which is explicitly "Release 0.10.0"
[21:31:04] <Daimona>	 Yeah, I'll make it
[21:31:11] <James_F>	 Cool.
[21:38:20] <Daimona>	 Done
[21:38:30] <Daimona>	 I'm also filing a task against LibUp
[21:43:03] <James_F>	 I've written a patch.
[21:43:06] <James_F>	 It doesn't work yet.
[21:43:09] <James_F>	 But… details.
[21:43:46] <wikibugs>	 10LibUp, 10phan, 10phan-taint-check-plugin: Upgrade phan to 0.10.0 - https://phabricator.wikimedia.org/T248630 (10Daimona)
[21:44:00] <Daimona>	 Hah
[21:44:39] <Daimona>	 I'll tag a release and resolve the task once https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/+/583761/ is merged (later/tomorrow)
[21:56:04] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Jdforrester-WMF)
[21:57:11] <wikibugs>	 10LibUp, 10phan, 10phan-taint-check-plugin: Upgrade phan to 0.10.0 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Jdforrester-WMF)
[21:57:51] <wikibugs>	 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.0 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Jdforrester-WMF)
[22:01:31] <James_F>	 Daimona: Tagged.
[22:01:55] <James_F>	 https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/phan/+/0.10.0
[22:03:02] <wikibugs>	 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.7/1.33.3/1.34.1 - https://phabricator.wikimedia.org/T240392 (10Reedy) 05Open→03Resolved a:03Reedy
[22:14:07] <Pchelolo>	 James_F: do you have a minute?
[22:14:23] <James_F>	 Sure.
[22:14:39] <Pchelolo>	 so... is there any trick to debug something like this: https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/19671/console ?
[22:15:13] <Pchelolo>	 like, some setting to add to a patch to make it log all the tests it starts or something?
[22:15:40] <James_F>	 Hmm.
[22:16:42] <Pchelolo>	 if not, I can probably just write some code in phpunit.php to echo everything it does... I'm at least interested in which test is failing with this..
[22:16:46] <James_F>	 That's reporting 25745166336 bytes already allocated, which is 24 GB?
[22:17:20] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10ChangeProp, 10Release Pipeline, and 3 others: Migrate changeprop to kubernetes - https://phabricator.wikimedia.org/T213193 (10holger.knust) Yes, Hugh Nolan will be creating another ticket.
[22:17:23] <James_F>	 Which is quite a lot. :-)
[22:17:34] <Pchelolo>	 the interesting part is that I don't think it's a persistent leak going
[22:17:41] <James_F>	 We could bump the memory allocation.
[22:17:48] <James_F>	 (For all quibble jobs.)
[22:17:57] <James_F>	 But I'm surprised we're already giving that much.
[22:18:23] <James_F>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/565462 doesn't look like it's doing anything particularly silly or subject to a memory leak, no.
[22:18:23] <Pchelolo>	 basically when the tests run, they get to this 732 tests, then it stos for a long time (accumulating memory I guess?) and then crashes
[22:18:50] <Pchelolo>	 so, I would at least want to know which test suite is it getting stuck on
[22:19:07] <James_F>	 Yeah, probably an infinite loop.
[22:19:17] <James_F>	 Does this happen running them locally?
[22:19:33] <Pchelolo>	 James_F: I don't have all the extensions installed and configured locally
[22:19:41] <James_F>	 Ah.
[22:19:54] <James_F>	 But it passes locally without some extensions?
[22:20:03] <Pchelolo>	 yeah
[22:20:09] <James_F>	 Interesting.
[22:20:21] <Pchelolo>	 I suspect one of the extensions does something funny
[22:20:25] <James_F>	 My first guess is to blame Wikibase, because that code is large and complex.
[22:21:06] <James_F>	 Though it's more likely the fault of CirrusSearch, as I believe it runs them alphabetically.
[22:21:12] <James_F>	 And that's the other major scary codebase.
[22:21:25] <Pchelolo>	 oh! interesting. ok. that's good to know
[22:21:43] <James_F>	 732/4166 shows it's early in the run.
[22:21:52] <Pchelolo>	 do you think it would be ok if I continue hurting CI with this?
[22:22:02] <James_F>	 Oh, sure.
[22:22:26] <James_F>	 Especially at this time of day; no-one else is around, at least compared to EU-day.
[22:23:18] <Pchelolo>	 ok. Then I'll probably try instrumenting phpunit or something... 
[22:24:37] <James_F>	 If you run phpunit in "debug" reporter mode (can't remember what it's called) it'll print each test's name individually, IIRC.
[22:24:50] <James_F>	 Sorry I can't be more helpful.
[22:25:13] <Pchelolo>	 nono, that was plenty helpful
[22:25:17] <Pchelolo>	 thank you
[22:25:22] <James_F>	 Always!
[22:25:33] <James_F>	 Thanks for so much work making MW better. :-)
[22:28:58] * snowick hey @greg-g and @bd808 thanks for your help yesterday, got my logs!
[22:29:02] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Jdforrester-WMF)
[22:29:18] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Jdforrester-WMF)
[23:01:22] <wikibugs>	 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Merge taint-check-plugin into mediawiki-phan-config - https://phabricator.wikimedia.org/T235390 (10Daimona) 05Open→03Resolved a:03Daimona Closing in favour of T248630 for the remaining part.
[23:06:00] <icinga-wm>	 PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[23:06:05] <Daimona>	 Uh-oh: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/43919/console
[23:07:54] <James_F>	 Daimona: Yeah.
[23:08:07] <Daimona>	 Well, let's see...
[23:08:23] <Daimona>	 Testing locally now
[23:09:13] <James_F>	 Maybe we need to make that hack change in phan-config not just the job
[23:09:40] <Daimona>	 Hmmm maybe
[23:09:44] <Daimona>	 Failing locally as well
[23:10:00] <James_F>	 Also for e.g. OOUI it's not running in an MW context so we'll need to disable it.
[23:11:24] <Daimona>	 Heh
[23:11:55] <Daimona>	 So, probably it should use __DIR__ . '/../../' to locate the vendor folder, not $VP
[23:12:11] <James_F>	 And then fall back to $VP if that fails?
[23:12:18] <icinga-wm>	 RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[23:13:44] <Daimona>	 It shouldn't be necessary, but yeah, let's do that
[23:17:30] <Daimona>	 Fix attempt at https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/+/583776/
[23:17:39] <Daimona>	 Hope it won't fail merging again...
[23:32:38] <Daimona>	 Oh jenkins what's wrong with you?
[23:33:38] <wikibugs>	 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Daimona)
[23:37:34] <icinga-wm>	 PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[23:42:55] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] Remove makerelease.py [tools/release] - 10https://gerrit.wikimedia.org/r/583686 (owner: 10Reedy)
[23:43:30] <wikibugs>	 (03Merged) 10jenkins-bot: Remove makerelease.py [tools/release] - 10https://gerrit.wikimedia.org/r/583686 (owner: 10Reedy)
[23:45:55] <wikibugs>	 (03PS1) 10Jeena Huneidi: tutorial: Add test and publish pipelines [blubber-doc/example/helloworldoid] (kubernetes-tutorial) - 10https://gerrit.wikimedia.org/r/583788
[23:54:35] <wikibugs>	 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Daimona) Ouch: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker...