[00:01:43] (03PS3) 10Umherirrender: Reduce code duplication in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 [00:13:39] (03PS2) 10Umherirrender: Add sniff: Expected parameter type before parameter name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) [00:14:16] (03CR) 10Umherirrender: "Rebased on top of the code deduplication - Id76e73dd6ddb61347ed8bb67544da41c8dc44f2f" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) (owner: 10Umherirrender) [00:30:21] (03PS2) 10Umherirrender: Add sniff: Expected param name not wrapped in parenthesis [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) [00:31:30] (03CR) 10Umherirrender: "Rebased on top of the code deduplication - Id76e73dd6ddb61347ed8bb67544da41c8dc44f2f" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) (owner: 10Umherirrender) [00:45:26] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Sniff for boolean/integer should not be case sensitive - https://phabricator.wikimedia.org/T248183 (10Umherirrender) This can have the same impact as `Bool` -> `bool` or `Int` -> `int` In my opinion the change from case of the long type and the... [01:14:12] 10Phabricator, 10I18n: Translation of phabricator is outdated in Brazilian Portuguese - https://phabricator.wikimedia.org/T248902 (10Eduaddad) Related Objects, Subscribers, Authored By, Edit Task, Mentions, $1 created this task, Create a Task, Profile, Settings, Needs Triage, Open, - were translated between 20... [01:25:30] 10Phabricator, 10I18n: Translation of phabricator is outdated in Brazilian Portuguese - https://phabricator.wikimedia.org/T248902 (10Eduaddad) 05Open→03Resolved a:03Eduaddad >>! Em T248902#6013616, @Aklapper escreveu: > @Eduaddad: T215697 is still open, so I don't understand why this task was created? I... [01:25:54] 10Phabricator, 10I18n: Translation of phabricator is outdated in Brazilian Portuguese - https://phabricator.wikimedia.org/T248902 (10Eduaddad) 05Resolved→03Open [01:26:32] 10Phabricator, 10I18n: Translation of phabricator is outdated in Brazilian Portuguese - https://phabricator.wikimedia.org/T248902 (10Eduaddad) a:05Eduaddad→03None [06:34:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Sniff for boolean/integer should not be case sensitive [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/582107 (https://phabricator.wikimedia.org/T248183) (owner: 10DannyS712) [06:35:09] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Sniff for boolean/integer should not be case sensitive - https://phabricator.wikimedia.org/T248183 (10thiemowmde) I think doing both is valuable. [06:35:18] (03Merged) 10jenkins-bot: Sniff for boolean/integer should not be case sensitive [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/582107 (https://phabricator.wikimedia.org/T248183) (owner: 10DannyS712) [06:40:52] 10MediaWiki-Codesniffer, 10User-DannyS712: Sniff for boolean/integer should not be case sensitive - https://phabricator.wikimedia.org/T248183 (10DannyS712) 05Open→03Resolved [06:57:12] (03PS1) 10DannyS712: Add a sniff for using assertNull instead of assertSame with null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:08:18] (03PS2) 10DannyS712: Add a sniff for using assertNull instead of assertSame with null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:08:32] (03PS3) 10DannyS712: Add a sniff for using assertNull instead of assertSame with null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:08:53] (03PS4) 10DannyS712: Add a sniff for using assertNull instead of assertSame with null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:10:03] (03PS5) 10DannyS712: Add a sniff for using assertNull instead of assertSame with null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:15:22] 10LibUp: libup: Kill running docker containers after some wall clock timeout - https://phabricator.wikimedia.org/T240749 (10Legoktm) ` legoktm@upgrader-06:~$ sudo docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 4f5f84a35... [07:20:28] (03PS6) 10DannyS712: Add a sniff for using assertNull instead of assertSame with null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:21:10] (03PS7) 10DannyS712: Add a sniff for using assertNull instead of assertSame with null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:31:30] (03PS8) 10DannyS712: Add a sniff for using assertSame with null, true, or false [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:33:29] (03PS9) 10DannyS712: Add a sniff for using assertSame with null, true, or false [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:34:22] (03PS10) 10DannyS712: Add a sniff for using assertSame with null, true, or false [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [07:37:53] 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10Wikimedia-GitHub: Cannot find repo operations/debs/wmf-pt-kill on diffusion or Github Wikimedia mirror - https://phabricator.wikimedia.org/T249205 (10mmodell) @jcrespo: I think we need an automated (or semi-automated) solution simply because it's becom... [07:40:23] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: add sniffs for using less specific assertions - https://phabricator.wikimedia.org/T244556 (10DannyS712) >>! In T244556#6029861, @gerritbot wrote: > Change 585973 had a related patch set uploaded (by DannyS712; owner: DannyS712): > [mediawiki/tool... [07:40:57] 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10Wikimedia-GitHub: Cannot find repo operations/debs/wmf-pt-kill on diffusion or Github Wikimedia mirror - https://phabricator.wikimedia.org/T249205 (10mmodell) >>! In T249205#6027531, @jcrespo wrote: should I request also the mirroring to these 2 places... [07:47:25] (03PS1) 10DannyS712: Use https for the one http link in ruleset.xml [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585981 [07:47:35] (03PS2) 10DannyS712: Use https for the one http link in ruleset.xml [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585981 [08:02:47] (03PS3) 10DannyS712: Use https for http links where possible [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585981 [08:30:00] 10Project-Admins, 10User-Luke081515: Create project Articles Needing links - https://phabricator.wikimedia.org/T249316 (10Aklapper) Thank you Luke081515! [08:45:58] 10Phabricator, 10I18n: Translation of phabricator is outdated in Brazilian Portuguese - https://phabricator.wikimedia.org/T248902 (10Aklapper) @Eduaddad: Okay. Could you answer my question in T248902#6013616, please? Thanks :) [09:06:47] (03CR) 10Umherirrender: [C: 03+2] Use https for http links where possible [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585981 (owner: 10DannyS712) [09:07:19] (03Merged) 10jenkins-bot: Use https for http links where possible [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585981 (owner: 10DannyS712) [09:20:24] (03CR) 10Umherirrender: Sniff for boolean/integer should not be case sensitive (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/582107 (https://phabricator.wikimedia.org/T248183) (owner: 10DannyS712) [09:20:40] (03PS4) 10Umherirrender: Reduce code duplication in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 [09:21:07] (03CR) 10Umherirrender: "Patch Set 4: Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [09:21:55] (03PS5) 10Umherirrender: Reduce code duplication in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 [09:22:29] (03CR) 10Umherirrender: "Patch Set 5: Fixed bad spacing from rebase" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [10:18:59] 10LibUp: libup KeyError 'actions' in npm_audit_fix - https://phabricator.wikimedia.org/T228173 (10Legoktm) a:05Legoktm→03None [10:20:49] 10LibUp: libup: grunt being upgraded through "npm audit fix" and new upstream version leaves a confusing commit message - https://phabricator.wikimedia.org/T227982 (10Legoktm) 05Open→03Resolved a:03Legoktm Please re-open if I didn't actually fix this. [13:31:23] 10Continuous-Integration-Config, 10MathSearch: mwext-testextension-zend should load extension mathsearch after math - https://phabricator.wikimedia.org/T117659 (10Physikerwelt) @Jdforrester-WMF somehow this reply slipped through my attention. It is actually much simpler. Running the tests in MathSearch require... [14:14:04] Project mediawiki-core-doxygen-docker build #14893: 04FAILURE in 10 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/14893/ [14:24:53] (03PS1) 10Physikerwelt: Reenable tests for MathSearch [integration/config] - 10https://gerrit.wikimedia.org/r/586095 (https://phabricator.wikimedia.org/T117659) [14:31:15] (03PS8) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [15:10:19] Yippee, build fixed! [15:10:19] Project mediawiki-core-doxygen-docker build #14894: 09FIXED in 6 min 15 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/14894/ [15:26:26] (03CR) 10Umherirrender: "There are still issues to make it fail - found with experimental run - https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php" [integration/config] - 10https://gerrit.wikimedia.org/r/586095 (https://phabricator.wikimedia.org/T117659) (owner: 10Physikerwelt) [16:23:45] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development - https://phabricator.wikimedia.org/T249304 (10Niedzielski) [17:07:43] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Addshore) Could this be causing T249018 on beta? [19:16:25] 10Release-Engineering-Team-TODO, 10Scap, 10Wikimedia-Incident: Unit tests for wfLoadExtension @ operations/mediawiki-config - https://phabricator.wikimedia.org/T136782 (10Krinkle) [19:18:50] (03PS1) 10DC Slagel: Add golint as an optional requirement [blubber] - 10https://gerrit.wikimedia.org/r/586133 [19:18:52] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [blubber] - 10https://gerrit.wikimedia.org/r/586133 (owner: 10DC Slagel) [19:19:37] 10Continuous-Integration-Config, 10Operations, 10serviceops, 10Regression, 10Wikimedia-Incident: operations-apache-config-lint replacement doesn't check syntax - https://phabricator.wikimedia.org/T114801 (10Krinkle) [19:29:43] (03CR) 10DC Slagel: "This is a simple addition to Blubber's CONTRIBUTING.md that adds info on installing golint as an optional requirement since it is used in " [blubber] - 10https://gerrit.wikimedia.org/r/586133 (owner: 10DC Slagel) [20:01:46] PROBLEM - Free space - all mounts on deployment-aqs01 is CRITICAL: (Service Check Timed Out) [20:06:39] RECOVERY - Free space - all mounts on deployment-aqs01 is OK: OK: All targets OK [20:08:54] PROBLEM - Free space - all mounts on integration-agent-docker-1006 is CRITICAL: (Service Check Timed Out) [20:12:16] (03CR) 10Umherirrender: [C: 03+1] "It passed on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MathSearch/+/586126/ in experimental mode" [integration/config] - 10https://gerrit.wikimedia.org/r/586095 (https://phabricator.wikimedia.org/T117659) (owner: 10Physikerwelt) [20:13:24] 10Continuous-Integration-Config, 10MathSearch, 10Patch-For-Review: mwext-testextension-zend should load extension mathsearch after math - https://phabricator.wikimedia.org/T117659 (10Physikerwelt) [20:13:45] RECOVERY - Free space - all mounts on integration-agent-docker-1006 is OK: OK: All targets OK [20:22:48] PROBLEM - Free space - all mounts on deployment-aqs01 is CRITICAL: (Service Check Timed Out) [20:56:45] 10Continuous-Integration-Infrastructure, 10Composer: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10bd808) [21:00:14] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster04 is CRITICAL: (Service Check Timed Out) [21:04:49] (03PS1) 10BryanDavis: Update composer to 1.10.1 [integration/composer] - 10https://gerrit.wikimedia.org/r/586142 (https://phabricator.wikimedia.org/T249461) [21:06:47] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10Reedy) Seems we're still using composer with PHP 5.6 images? https://github.com/wikimedia/integration-config/tree/e0982e0c4573e6dd32346d5e6499a881277f98... [21:10:16] (03CR) 10Reedy: Update composer to 1.10.1 (031 comment) [integration/composer] - 10https://gerrit.wikimedia.org/r/586142 (https://phabricator.wikimedia.org/T249461) (owner: 10BryanDavis) [21:12:31] (03CR) 10BryanDavis: Update composer to 1.10.1 (031 comment) [integration/composer] - 10https://gerrit.wikimedia.org/r/586142 (https://phabricator.wikimedia.org/T249461) (owner: 10BryanDavis) [21:13:31] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10bd808) >>! In T249461#6030585, @Reedy wrote: > Seems we're still using composer with PHP 5.6 images? > > https://github.com/wikimedia/integration-config... [21:14:43] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10Reedy) >>! In T249461#6030588, @bd808 wrote: >>>! In T249461#6030585, @Reedy wrote: >> Seems we're still using composer with PHP 5.6 images? >> >> https... [21:16:17] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10bd808) >>! In T249461#6030590, @Reedy wrote: > > It was more updating the platform restraint in composer.json for that repo. See my comment. We presumab... [21:17:20] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10bd808) I honestly am not sure why we don't just use the upstream PHAR file, but I won't try to readjudicate that decision at this time. [21:31:02] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10Reedy) >>! In T249461#6030592, @bd808 wrote: > I honestly am not sure why we don't just use the upstream PHAR file, but I won't try to readjudicate that... [21:33:19] 10Continuous-Integration-Infrastructure, 10Composer: Replace integration/composer with a composer.phar - https://phabricator.wikimedia.org/T249464 (10Reedy) [21:35:34] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Update Composer >=1.9.3 for CI jobs - https://phabricator.wikimedia.org/T249461 (10Legoktm) >>! In T249461#6030592, @bd808 wrote: > I honestly am not sure why we don't just use the upstream PHAR file, but I won't try to readjudicate tha... [21:38:37] 10Continuous-Integration-Infrastructure, 10Composer: Replace integration/composer with a composer.phar - https://phabricator.wikimedia.org/T249464 (10bd808) >>! In T249461#6030625, @Legoktm wrote: >>>! In T249461#6030592, @bd808 wrote: >> I honestly am not sure why we don't just use the upstream PHAR file, but... [22:17:54] (03PS11) 10DannyS712: Add a sniff for using assertSame with null, true, or false [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [22:18:25] (03PS12) 10DannyS712: Add a sniff for using assertSame with null, true, or false [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) [22:24:11] PROBLEM - Free space - all mounts on deployment-eventgate-3 is CRITICAL: (Service Check Timed Out) [22:29:01] RECOVERY - Free space - all mounts on deployment-eventgate-3 is OK: OK: All targets OK [22:32:37] PROBLEM - Free space - all mounts on deployment-docker-cxserver01 is CRITICAL: (Service Check Timed Out) [22:32:48] PROBLEM - Free space - all mounts on integration-agent-pkgbuilder-1002 is CRITICAL: (Service Check Timed Out) [22:37:29] RECOVERY - Free space - all mounts on deployment-docker-cxserver01 is OK: OK: All targets OK [22:37:38] RECOVERY - Free space - all mounts on integration-agent-pkgbuilder-1002 is OK: OK: All targets OK [22:37:50] PROBLEM - Free space - all mounts on integration-castor03 is CRITICAL: (Service Check Timed Out) [22:42:42] RECOVERY - Free space - all mounts on integration-castor03 is OK: OK: All targets OK [22:48:50] PROBLEM - Free space - all mounts on integration-agent-docker-1010 is CRITICAL: (Service Check Timed Out) [22:48:50] PROBLEM - Free space - all mounts on integration-castor03 is CRITICAL: (Service Check Timed Out) [22:53:41] RECOVERY - Free space - all mounts on integration-agent-docker-1010 is OK: OK: All targets OK [22:53:41] RECOVERY - Free space - all mounts on integration-castor03 is OK: OK: All targets OK