[00:02:15] (03PS1) 10Reedy: Replace integration/composer repo with composer.phar [integration/config] - 10https://gerrit.wikimedia.org/r/586154 (https://phabricator.wikimedia.org/T249464) [00:04:01] (03PS2) 10Reedy: Replace integration/composer repo with composer.phar [integration/config] - 10https://gerrit.wikimedia.org/r/586154 (https://phabricator.wikimedia.org/T249464) [00:05:34] 10Continuous-Integration-Infrastructure, 10Composer: Replace integration/composer with a composer.phar - https://phabricator.wikimedia.org/T249464 (10Reedy) Bots don't seem to be working... https://gerrit.wikimedia.org/r/#/c/integration/config/+/586154/ [00:17:30] PROBLEM - Free space - all mounts on integration-agent-docker-1008 is CRITICAL: (Service Check Timed Out) [00:22:19] RECOVERY - Free space - all mounts on integration-agent-docker-1008 is OK: OK: All targets OK [00:30:21] PROBLEM - Free space - all mounts on deployment-ores01 is CRITICAL: (Service Check Timed Out) [00:32:29] (03PS1) 10Reedy: dockerfiles: [composer-php70] Update composer to v1.10.1 [integration/config] - 10https://gerrit.wikimedia.org/r/586155 (https://phabricator.wikimedia.org/T249461) [00:32:40] (03PS1) 10DannyS712: Fix another http link in MagicConstantClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/586156 [00:32:51] (03PS2) 10DannyS712: Fix another http link in MagicConstantClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/586156 [00:33:18] (03CR) 10jerkins-bot: [V: 04-1] dockerfiles: [composer-php70] Update composer to v1.10.1 [integration/config] - 10https://gerrit.wikimedia.org/r/586155 (https://phabricator.wikimedia.org/T249461) (owner: 10Reedy) [00:33:30] (03CR) 10Reedy: "Depends-On: Iecf82b8fbc9d503b35995ddfa6ad0196a2c18184 or Depends-On: I4d1c7cb925e6077e86f4eefa61fff6a646bd6f69" [integration/config] - 10https://gerrit.wikimedia.org/r/586155 (https://phabricator.wikimedia.org/T249461) (owner: 10Reedy) [00:35:11] RECOVERY - Free space - all mounts on deployment-ores01 is OK: OK: All targets OK [00:35:32] (03PS2) 10Reedy: dockerfiles: [composer-php70] Update composer to v1.10.1 [integration/config] - 10https://gerrit.wikimedia.org/r/586155 (https://phabricator.wikimedia.org/T249461) [00:37:14] (03PS3) 10Reedy: dockerfiles: [composer-php70] Update composer to v1.10.1 [integration/config] - 10https://gerrit.wikimedia.org/r/586155 (https://phabricator.wikimedia.org/T249461) [00:37:30] (03PS4) 10Reedy: dockerfiles: [composer-php70] Update composer to v1.10.1 [integration/config] - 10https://gerrit.wikimedia.org/r/586155 (https://phabricator.wikimedia.org/T249461) [00:42:45] PROBLEM - Free space - all mounts on deployment-restbase02 is CRITICAL: (Service Check Timed Out) [00:44:11] (03PS3) 10Reedy: Replace integration/composer repo with composer.phar [integration/config] - 10https://gerrit.wikimedia.org/r/586154 (https://phabricator.wikimedia.org/T249464) [00:45:50] PROBLEM - Free space - all mounts on integration-agent-docker-1010 is CRITICAL: (Service Check Timed Out) [00:47:37] RECOVERY - Free space - all mounts on deployment-restbase02 is OK: OK: deployment-prep.deployment-restbase02.diskspace._var_log.byte_percentfree (No valid datapoints found) [00:50:40] RECOVERY - Free space - all mounts on integration-agent-docker-1010 is OK: OK: All targets OK [02:19:46] PROBLEM - Free space - all mounts on deployment-mediawiki-09 is CRITICAL: (Service Check Timed Out) [02:24:36] RECOVERY - Free space - all mounts on deployment-mediawiki-09 is OK: OK: All targets OK [03:12:24] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Replace integration/composer with a composer.phar - https://phabricator.wikimedia.org/T249464 (10Legoktm) I'd like us to have the ability to reproducibly build composer phars before we start using upstream's binary files. I tried doing... [03:20:04] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Replace integration/composer with a composer.phar - https://phabricator.wikimedia.org/T249464 (10Reedy) Is it a composer repo bug or a php bug causing non reproducible builds? [03:26:46] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: (Service Check Timed Out) [04:37:46] PROBLEM - Free space - all mounts on integration-agent-docker-1002 is CRITICAL: (Service Check Timed Out) [04:42:37] RECOVERY - Free space - all mounts on integration-agent-docker-1002 is OK: OK: All targets OK [04:57:03] PROBLEM - Free space - all mounts on deployment-eventstreams-1 is CRITICAL: (Service Check Timed Out) [05:01:54] RECOVERY - Free space - all mounts on deployment-eventstreams-1 is OK: OK: All targets OK [06:44:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Sniff for boolean/integer should not be case sensitive (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/582107 (https://phabricator.wikimedia.org/T248183) (owner: 10DannyS712) [07:11:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Add a sniff for using assertSame with null, true, or false (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) (owner: 10DannyS712) [07:13:54] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: add sniffs for using less specific assertions - https://phabricator.wikimedia.org/T244556 (10thiemowmde) How is any of the assertion listed in this tasks description an issue? What do we win by disallowing one form? [07:39:34] PROBLEM - Free space - all mounts on deployment-sca01 is CRITICAL: (Service Check Timed Out) [07:44:25] RECOVERY - Free space - all mounts on deployment-sca01 is OK: OK: deployment-prep.deployment-sca01.diskspace._var.byte_percentfree (No valid datapoints found) deployment-prep.deployment-sca01.diskspace._srv.byte_percentfree (No valid datapoints found) deployment-prep.deployment-sca01.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-sca01.diskspace._var_log.byte_percentfree (No valid datapoints [08:24:45] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T247774 (10Nikerabbit) [09:16:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix another http link in MagicConstantClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/586156 (owner: 10DannyS712) [09:17:02] (03Merged) 10jenkins-bot: Fix another http link in MagicConstantClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/586156 (owner: 10DannyS712) [09:22:09] 10Beta-Cluster-Infrastructure, 10Wikimedia-Site-requests, 10ContentSecurityPolicy: Change Content Security Policy on betacommons to allow api.flickr.com - https://phabricator.wikimedia.org/T249486 (10AlexisJazz) [09:36:02] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Legoktm) @Daimona could you clarify what you want #libup to do here? If we need... [09:38:22] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Daimona) 05Open→03Stalled >>! In T248630#6031334, @Legoktm wrote: > @Daimon... [09:38:26] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Weird interaction between phan and taint-check: PhanUndeclaredVariable - https://phabricator.wikimedia.org/T248742 (10Daimona) [09:38:28] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Daimona) [09:42:18] 10LibUp: LibUp fails to run stylelint after upgrade when grunt is missing - https://phabricator.wikimedia.org/T248801 (10Legoktm) I'm not really sure what the best thing to do here is. Ideally it would just be like eslint where we can just lint `.` and it knows which extensions to check and what paths to exclude... [09:53:31] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) p:05Medium→03High There's a huge performance deterioration in taint-check 3.0.1. On core it takes like 5 minutes vs "vanilla" phan taking less than one minute. We need to find out what's causing... [10:15:32] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredVariable, part 2 - https://phabricator.wikimedia.org/T249491 (10Daimona) [10:15:47] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredVariable, part 2 - https://phabricator.wikimedia.org/T249491 (10Daimona) [10:15:52] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Daimona) [10:49:42] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Joe) >>! In T99740#6030334, @Addshore wrote: > Could this be causing T249018 on beta? No, there is... [10:51:37] RECOVERY - Free space - all mounts on deployment-logstash2 is OK: OK: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found) [10:57:04] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Joe) Is there a way to turn this function on for just a single application server? I would like to r... [12:28:39] 10Phabricator, 10User-Zoranzoki21: Phabricator does not show videos in webm format as embedded - https://phabricator.wikimedia.org/T244162 (10Dzahn) >>! In T244162#6021780, @mmodell wrote: > I'd rather not encourage videos uploaded to phabricator due to the storage limitations we currently have for phab file u... [12:30:14] 10Beta-Cluster-Infrastructure, 10Operations: deployment-cache-upload05: Several millions of logstash error entries - https://phabricator.wikimedia.org/T243129 (10fgiunchedi) Untagging observability as this is a service / beta issue (also seems fixed?) [12:40:48] (03CR) 10Thiemo Kreuz (WMDE): "I'm sorry, but I'm unable to review changes in this particular 800 lines file when they touch so many lines. I mean, it's super helpful to" (037 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [12:43:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Small change, does make a lot of sense. Thanks for fixing this long-standing issue!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) (owner: 10Umherirrender) [12:58:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Makes sense." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) (owner: 10Umherirrender) [12:58:58] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix newline detection in SpacyParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585961 (https://phabricator.wikimedia.org/T246636) (owner: 10Umherirrender) [13:00:05] (03Merged) 10jenkins-bot: Fix newline detection in SpacyParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585961 (https://phabricator.wikimedia.org/T246636) (owner: 10Umherirrender) [13:16:32] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredVariable, part 2 - https://phabricator.wikimedia.org/T249491 (10Daimona) So, this one was harder than the other, and reproducing the issue wasn't easy, either. The problem arises when we try to compute the objects that a... [13:59:35] (03CR) 10Hashar: [C: 03+2] "Joseph managed to make a release with the new job :]" [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar) [14:00:33] (03Merged) 10jenkins-bot: jjb: migrate refinery release job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/583092 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar) [14:01:46] (03CR) 10Hashar: [C: 03+2] "Redeployed just now. We can further tweak the notifications later on as needed." [integration/config] - 10https://gerrit.wikimedia.org/r/585497 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar) [14:02:05] (03CR) 10jerkins-bot: [V: 04-1] jjb: irc notification for analytics jobs [integration/config] - 10https://gerrit.wikimedia.org/r/585497 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar) [14:02:16] (03PS2) 10Hashar: jjb: irc notification for analytics jobs [integration/config] - 10https://gerrit.wikimedia.org/r/585497 (https://phabricator.wikimedia.org/T210271) [14:02:35] (03CR) 10Hashar: [C: 03+2] jjb: irc notification for analytics jobs [integration/config] - 10https://gerrit.wikimedia.org/r/585497 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar) [14:03:04] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Analytics, and 2 others: Migrate analytics/refinery/source release jobs to Docker - https://phabricator.wikimedia.org/T210271 (10hashar) [14:03:31] (03Merged) 10jenkins-bot: jjb: irc notification for analytics jobs [integration/config] - 10https://gerrit.wikimedia.org/r/585497 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar) [14:06:22] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Reduce size of artifacts stored on the CI Jenkins master - https://phabricator.wikimedia.org/T249268 (10hashar) The codehealth jobs no more run with SonarQub... [14:16:13] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development - https://phabricator.wikimedia.org/T249304 (10hashar) IIRC WMDE is using Vue.js for Wikibase, they might have some experience to share :) [14:28:39] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development - https://phabricator.wikimedia.org/T249304 (10Niedzielski) Thanks @hashar! +@WMDE-leszek, @Pablo-WMDE, this task pertains to linting for the new Vue.js se... [14:36:58] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) >>! In T99740#6031681, @Joe wrote: > Is there a way to turn this function on for just a sin... [14:46:35] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development - https://phabricator.wikimedia.org/T249304 (10Pablo-WMDE) WMDE's vue linting in wikibase sub-products can be summarized as `plugin:vue/strongly-recommended... [14:50:52] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.29 deployment blockers - https://phabricator.wikimedia.org/T247776 (10thcipriani) 05Open→03Declined Skipping wmf.29 due to wmf holiday starting 2020-04-22. [15:14:11] 10Beta-Cluster-Infrastructure, 10Security-Team, 10Wikimedia-Site-requests, 10ContentSecurityPolicy: Change Content Security Policy on betacommons to allow api.flickr.com - https://phabricator.wikimedia.org/T249486 (10Urbanecm) IIRC, neither beta nor production allow external non-WM-hosted service in their... [15:18:10] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development - https://phabricator.wikimedia.org/T249304 (10Niedzielski) [15:23:32] apologies if this was mentioned as i just rejoined channel. Is the 'unresolved seutp issues' warning known by releng in phab? [15:23:41] (i know it does this regularly during upgrades so just checking) [15:24:20] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development - https://phabricator.wikimedia.org/T249304 (10Pablo-WMDE) I forgot to mention: Thank you for reaching out. It means a lot! [15:24:51] (unable to connect to notification server is the issue on setup warning) [15:28:35] robh: I hadn't seen that yet this morning, thanks for the heads up, I'll get a task filled. It's strange, I'm not aware of any upgrades we did recently... [15:28:45] twentyafterfour: ^ [15:29:13] that is because i activated the aphlict service [15:29:17] while it's not used in the phab config [15:29:56] i didn't think it was a big deal because only admins see it (i think?) and the follow-up code change still needs a phab config to go with it [15:30:55] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, 10Patch-For-Review: Convert zuul to use scap - https://phabricator.wikimedia.org/T215458 (10hashar) 05Open→03Resolved I sa... [15:30:56] oh! is aphlict going to work again? That's good news. [15:31:01] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10hashar) [15:31:03] maybe :p [15:31:06] :) [15:31:22] it's a cosmetic issue for now. nothing is broken that wasnt already broken :) [15:31:29] but yea, trying to [15:31:42] had discussion with traffic and need to follow-up with Mukunda [15:31:50] we need to change it to https on port 22280 [15:32:18] and then we can merge an ATS change which will make it talk to nodejs (that notification service) directly instead of going through apache [15:32:33] nice [15:32:35] and if we don't go through apache then we don't need to use the buggy module that once took phab down [15:32:50] https://gerrit.wikimedia.org/r/c/operations/puppet/+/569104 [15:33:09] the reason you see the icon today is https://gerrit.wikimedia.org/r/c/operations/puppet/+/586338 [15:34:39] * thcipriani *nods* [15:34:40] makes sense [15:36:59] Gerrit now supports file uploads using the rest api (change was merged today) [15:42:33] mutante: cool thx for info! ill ignore [15:42:34] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10hashar) [15:42:48] i just didnt wanna ignore without mention first [15:43:05] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10hashar) [15:43:20] afaik indeed only phab admins (all 6 of us?) see the warning but thats it! [15:45:53] robh: a few more than 6 https://phabricator.wikimedia.org/people/query/Df0Mt44LIdkZ/#R [15:47:06] 10Beta-Cluster-Infrastructure, 10Security-Team, 10Wikimedia-Site-requests, 10ContentSecurityPolicy: Change Content Security Policy on betacommons to allow api.flickr.com - https://phabricator.wikimedia.org/T249486 (10sbassett) p:05Triage→03Medium [15:53:11] robh: yw, thanks for checking [15:54:27] Uhhhh [15:54:29] Is CI broken? [15:54:29] 16:53:48 * Could not find the registration file for the extension "ConfirmEdit" [15:54:34] https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php72-docker/13528/console [15:55:08] and numerous others... [15:55:24] Hmm. Maybe just branches? [15:56:10] 10Continuous-Integration-Config: Don't install EventStreamConfig on older release branches - https://phabricator.wikimedia.org/T249514 (10Reedy) [15:56:44] RhinosF1: damn, indeed [15:56:58] well i obviously only have it because i had it when there wer like 6 and i do the form crap for SRE [15:57:05] otherwise i'd remove admin from myself, just forms... [15:57:17] (everything else admin can only get me in trouble, but i edit forms all the time.) [15:57:19] 10Continuous-Integration-Config: Could not find the registration file for the extension - https://phabricator.wikimedia.org/T249515 (10Reedy) [15:57:44] 10Beta-Cluster-Infrastructure, 10Security-Team, 10Wikimedia-Site-requests, 10ContentSecurityPolicy: Change Content Security Policy on betacommons to allow api.flickr.com - https://phabricator.wikimedia.org/T249486 (10sbassett) Ideally, the #security-team would prefer to wait for [[ https://gerrit.wikimedia... [15:58:59] https://github.com/wikimedia/mediawiki-extensions-EventStreamConfig didn't exist either [16:01:06] 10Beta-Cluster-Infrastructure, 10Security-Team, 10Wikimedia-Site-requests, 10ContentSecurityPolicy: Change Content Security Policy on betacommons to allow api.flickr.com - https://phabricator.wikimedia.org/T249486 (10Bawolff) Note, the flickr thing is part of the uploadwizard extension, not a gadget or any... [16:01:42] 10Continuous-Integration-Config: Don't install EventStreamConfig on older release branches - https://phabricator.wikimedia.org/T249514 (10Reedy) Broke on REL1_31 too, but not REL1_33 [16:02:44] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: phan and taint-check weird interactions: PhanUndeclaredVariable, part 2 - https://phabricator.wikimedia.org/T249491 (10Daimona) a:03Daimona [16:03:19] (03PS1) 10Reedy: Remove special casing for BlueSpiceFoundation depending onExtJsBase [integration/config] - 10https://gerrit.wikimedia.org/r/586387 [16:04:10] (03CR) 10jerkins-bot: [V: 04-1] Remove special casing for BlueSpiceFoundation depending onExtJsBase [integration/config] - 10https://gerrit.wikimedia.org/r/586387 (owner: 10Reedy) [16:04:13] 10VPS-project-codesearch, 10Analytics: Add analytics/* gerrit repos to code search - https://phabricator.wikimedia.org/T249318 (10Milimetric) a:03Milimetric I don't know how to add them. But would love to. [16:04:58] (03PS2) 10Reedy: Remove special casing for BlueSpiceFoundation depending onExtJsBase [integration/config] - 10https://gerrit.wikimedia.org/r/586387 [16:10:46] (03PS1) 10Reedy: Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) [16:11:55] (03PS3) 10Reedy: Remove special casing for BlueSpiceFoundation depending onExtJsBase [integration/config] - 10https://gerrit.wikimedia.org/r/586387 [16:12:01] (03CR) 10Reedy: [C: 03+2] Remove special casing for BlueSpiceFoundation depending onExtJsBase [integration/config] - 10https://gerrit.wikimedia.org/r/586387 (owner: 10Reedy) [16:12:05] (03CR) 10jerkins-bot: [V: 04-1] Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:12:56] (03Merged) 10jenkins-bot: Remove special casing for BlueSpiceFoundation depending onExtJsBase [integration/config] - 10https://gerrit.wikimedia.org/r/586387 (owner: 10Reedy) [16:13:28] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/586387 [16:13:29] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:14:18] (03PS2) 10Reedy: Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) [16:14:58] (03CR) 10jerkins-bot: [V: 04-1] Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:15:23] (03PS3) 10Reedy: Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) [16:16:10] (03CR) 10jerkins-bot: [V: 04-1] Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:18:54] (03PS4) 10Reedy: Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) [16:21:02] Fun. [16:21:30] (03PS5) 10Reedy: Don't install EventStreamConfig as a dependancy for Eventlogging in old branches [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) [16:22:00] (03PS6) 10Reedy: Only install EventStreamConfig in MW >= 1.35 [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) [16:22:04] (03CR) 10Reedy: [C: 03+2] Only install EventStreamConfig in MW >= 1.35 [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:23:00] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [16:24:07] (03Merged) 10jenkins-bot: Only install EventStreamConfig in MW >= 1.35 [integration/config] - 10https://gerrit.wikimedia.org/r/586388 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:24:07] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [16:24:16] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [16:24:56] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/586388 [16:24:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:25:50] James_F: I'm not sure how the REL1_33 job went through fine... But I'll ignore that [16:31:54] Yeah. [16:32:17] (03PS1) 10Reedy: Don't install EventStreamConfig at all in REL1_3[134] [integration/config] - 10https://gerrit.wikimedia.org/r/586394 (https://phabricator.wikimedia.org/T249514) [16:32:48] (03CR) 10Reedy: [C: 03+2] Don't install EventStreamConfig at all in REL1_3[134] [integration/config] - 10https://gerrit.wikimedia.org/r/586394 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:33:44] (03CR) 10jerkins-bot: [V: 04-1] Don't install EventStreamConfig at all in REL1_3[134] [integration/config] - 10https://gerrit.wikimedia.org/r/586394 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:34:28] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Weird interaction between phan and taint-check: PhanUndeclaredVariable - https://phabricator.wikimedia.org/T248742 (10Daimona) p:05Triage→03High [16:34:32] (03PS2) 10Reedy: Don't install EventStreamConfig at all in REL1_3[134] [integration/config] - 10https://gerrit.wikimedia.org/r/586394 (https://phabricator.wikimedia.org/T249514) [16:34:36] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: phan and taint-check weird interactions: PhanUndeclaredVariable, part 2 - https://phabricator.wikimedia.org/T249491 (10Daimona) p:05Triage→03High [16:35:24] 10LibUp, 10MW-1.31-release: Bump PHPCS version in REL1_31 extensions - https://phabricator.wikimedia.org/T236070 (10Reedy) >>! In T236070#5784074, @Jdforrester-WMF wrote: > This is a dupe of T233759, right? Or a very specific subset of it [16:35:55] 10LibUp, 10MW-1.31-release: Bump PHPCS version in REL1_31 extensions - https://phabricator.wikimedia.org/T236070 (10Reedy) p:05Triage→03High This is getting annoying when trying to backport stuff [16:36:12] 10LibUp: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Reedy) [16:36:15] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10PHP 7.3 support: Update mediawiki/mediawiki-codesniffer for php7.3 support in release branches - https://phabricator.wikimedia.org/T233759 (10Reedy) [16:36:28] 10LibUp: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Reedy) p:05Triage→03High [16:36:40] (03CR) 10Reedy: [C: 03+2] Don't install EventStreamConfig at all in REL1_3[134] [integration/config] - 10https://gerrit.wikimedia.org/r/586394 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:37:37] 10LibUp, 10MW-1.31-release: Bump PHPCS version in REL1_31 extensions - https://phabricator.wikimedia.org/T236070 (10Reedy) [16:37:40] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10PHP 7.3 support: Update mediawiki/mediawiki-codesniffer for php7.3 support in release branches - https://phabricator.wikimedia.org/T233759 (10Reedy) [16:38:21] (03Merged) 10jenkins-bot: Don't install EventStreamConfig at all in REL1_3[134] [integration/config] - 10https://gerrit.wikimedia.org/r/586394 (https://phabricator.wikimedia.org/T249514) (owner: 10Reedy) [16:38:24] * Reedy needs to find a bribe for legoktm [16:38:54] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/586394 [16:38:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:47:32] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: phan and taint-check weird interactions: PhanUndeclaredThis - https://phabricator.wikimedia.org/T249491 (10Daimona) [16:49:03] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredThis, part 2 - https://phabricator.wikimedia.org/T249519 (10Daimona) [16:49:14] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredThis, part 2 - https://phabricator.wikimedia.org/T249519 (10Daimona) [16:49:18] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Weird interaction between phan and taint-check: PhanUndeclaredVariable - https://phabricator.wikimedia.org/T248742 (10Daimona) [16:49:36] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredThis, part 2 - https://phabricator.wikimedia.org/T249519 (10Daimona) [16:49:38] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Weird interaction between phan and taint-check: PhanUndeclaredVariable - https://phabricator.wikimedia.org/T248742 (10Daimona) [16:49:40] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Daimona) [16:49:48] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredThis, part 2 - https://phabricator.wikimedia.org/T249519 (10Daimona) p:05Triage→03High a:03Daimona [16:50:16] (03PS1) 10Jforrester: jjb: Adjust comment mentioning REL1_26 for my sanity [integration/config] - 10https://gerrit.wikimedia.org/r/586396 [16:51:04] lol [16:51:48] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development - https://phabricator.wikimedia.org/T249304 (10Jdforrester-WMF) >>! In T249304#6027573, @Niedzielski wrote: > Thanks for looking out, @Jdforrester-WMF! I've... [16:52:02] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development ahead of it being done for all repos - https://phabricator.wikimedia.org/T249304 (10Jdforrester-WMF) [16:56:18] 10Continuous-Integration-Config: Don't install EventStreamConfig on older release branches - https://phabricator.wikimedia.org/T249514 (10Reedy) 05Open→03Resolved a:03Reedy [16:56:33] 10Continuous-Integration-Config: Could not find the registration file for the extension - https://phabricator.wikimedia.org/T249515 (10Reedy) [16:56:35] 10Continuous-Integration-Config: Don't install EventStreamConfig on older release branches - https://phabricator.wikimedia.org/T249514 (10Reedy) [16:56:44] 10Continuous-Integration-Config: Could not find the registration file for the extension - https://phabricator.wikimedia.org/T249515 (10Reedy) Fixing T249514 seems to fix this [16:57:47] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Configure ESLint for Vue.js search development ahead of it being done for all repos - https://phabricator.wikimedia.org/T249304 (10hashar) Danke schön @Pablo-WMDE ! [16:58:51] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10Huji) [17:00:02] Hi, I'm having trouble with a (new?) "UNSTABLE" jenkins result https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/28970/ -- the test report claims that one test failed, but the log in the console is completely green. Any ideas what is going on? [17:01:46] micgro42: that is a risky test reported by phpunit [17:01:54] it does not cause the build to fail (ie phpunit exit 0) [17:02:08] but the risky test is a fault in the junit report [17:02:13] so on that page https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/28970/ [17:02:25] at the bottom there is a link to "Test Failure" which shows the error [17:02:35] https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/28970/testReport/ [17:02:41] Wikibase.Client.Tests.Integration.GlobalStateFactoryMethodsResourceTest.testMovePageNotice [17:02:41] Stack Trace [17:02:41] Risky Test [17:02:48] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 93833 bytes in 1.108 second response time [17:03:07] 1) Wikibase\Client\Tests\Integration\GlobalStateFactoryMethodsResourceTest::testMovePageNotice [17:03:10] This test did not perform any assertions [17:03:15] micgro42: ^^ :] [17:04:00] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 94130 bytes in 0.992 second response time [17:04:06] I am really off now [17:04:07] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 52105 bytes in 1.156 second response time [17:06:07] hasharAway thanks and have a nice evening [17:06:34] Though it is strange that this starts failing now, as that patch did not touch that test 🤔 [17:10:11] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 2 others: Upgrade phan to 0.10.2 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Jdforrester-WMF) [17:22:46] (03CR) 10DannyS712: ">" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) (owner: 10DannyS712) [17:23:28] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: add sniffs for using less specific assertions - https://phabricator.wikimedia.org/T244556 (10DannyS712) >>! In T244556#6030921, @thiemowmde wrote: > How is any of the assertion listed in this tasks description an issue? What do we win by disallow... [17:24:29] 10LibUp: LibUp fails to run stylelint after upgrade when grunt is missing - https://phabricator.wikimedia.org/T248801 (10Jdforrester-WMF) >>! In T248801#6031367, @Legoktm wrote: > What could go wrong if we just assumed stylelint's path to be `**/*.{css,less}` if it's not configured by grunt? SGTM. [17:27:45] 10LibUp, 10Patch-For-Review: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Reedy) What's the best way going to be dealing with https://gerrit.wikimedia.org/r/plugins/gitiles/labs/libraryupgrader/config/+/master/releases.json ? Add a "branch" under each library, and if def... [17:30:16] 10LibUp: LibUp fails to run stylelint after upgrade when grunt is missing - https://phabricator.wikimedia.org/T248801 (10Umherirrender) +1 [17:31:53] 10LibUp, 10Patch-For-Review: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Jdforrester-WMF) >>! In T236071#6033071, @Reedy wrote: > What's the best way going to be dealing with https://gerrit.wikimedia.org/r/plugins/gitiles/labs/libraryupgrader/config/+/master/releases.jso... [17:47:48] 10LibUp: Use packaged composer - https://phabricator.wikimedia.org/T249525 (10Reedy) [17:47:54] 10LibUp: Use packaged composer - https://phabricator.wikimedia.org/T249525 (10Reedy) 05Open→03Stalled [18:07:05] (03CR) 10Umherirrender: "I will split the patch set to make the code moves easier to follow" (036 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [18:09:04] 10phan, 10phan-taint-check-plugin: phan and taint-check weird interactions: PhanUndeclaredThis, part 2 - https://phabricator.wikimedia.org/T249519 (10Daimona) A bit of investigation: this is very similar to T249491, in that the same code path is involved. This time, the problem is that we try to read the saved... [18:15:58] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: add sniffs for using less specific assertions - https://phabricator.wikimedia.org/T244556 (10thiemowmde) Objections by whom? How many people have been added to this ticket? How many people have seen it? The assertEquals sniff introduced in https... [18:18:31] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I'm not sure if I get the question. What is the point of mass-editing a formatting detail in all codebases, if that detail is not an error" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) (owner: 10DannyS712) [18:19:28] 10MediaWiki-Codesniffer: Bogus MediaWiki.WhiteSpace.SpaceyParenthesis auto-fix when there is whitespace at the end of the line - https://phabricator.wikimedia.org/T246636 (10Umherirrender) 05Open→03Resolved p:05Triage→03Medium a:03Umherirrender [18:26:30] (03CR) 10Thiemo Kreuz (WMDE): Reduce code duplication in FunctionCommentSniff (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [18:26:35] mutante: what needs to be changed specifically? phab or aphlict? [18:32:36] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10Huji) I, and at least two other folks on fawiki, are experiencing this bug too. On fawiki, we don't have the "c... [18:35:08] Project mediawiki-core-doxygen-docker build #14921: 04FAILURE in 31 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/14921/ [18:46:50] (03CR) 10Krinkle: [C: 04-1] "The problem is with assertEqual, which performs lose/weak comparison. assertSame is fine and should not be sniffed for." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585973 (https://phabricator.wikimedia.org/T244279) (owner: 10DannyS712) [18:49:48] twentyafterfour: in phab.. when i followed that exclamation mark, it shows an example config for notification server and the current local config [18:50:13] twentyafterfour: in the example it says protocol https and port 22280, in the local config it says protocol http and port 22280. same port, different protocol [18:50:34] so the idea was if we can change it to https protocol and have a cert ... [18:50:58] then the ATS change to talk wss directly to 22280 would be ok.. but not if it is http [18:51:47] mutante: yeah so we just need to install a cert [18:52:12] 10LibUp: Failed building wheel for pyrsistent - https://phabricator.wikimedia.org/T249534 (10Reedy) [18:52:48] twentyafterfour: cool, so either that or .. we use envoy for TLS and that way also avoid apache [18:53:22] i can create the cert but would prefer tomorrow because i'm in Europe timezone now [18:53:29] aphlict supports ssl.key ssl.cert and ssl.chain options [18:53:41] great :) [18:53:49] mutante: ok it can wait until tomorrow [18:53:53] that was what i was hoping for originally [18:54:15] i see you fixed the exclamation mark? [18:54:17] I think it'd probably be better to give aphlict the cert instead of envoy [18:54:18] sorry for that [18:54:25] it's because i started the service [18:54:29] but that got us one step closer [18:54:50] yeah I fixed it by telling phab to talk to localhost because the admin 22281 is bound to local interface [18:54:54] ok, so we can probably use https://wikitech.wikimedia.org/wiki/Cergen#Cheatsheet [18:55:00] and then just copy it [18:55:04] cool [18:55:23] i'll do that tomorrow and put the cert in the repo [18:55:57] i wasn't 100% sure about the /ws/ suffix in the target/replacement URLs, btw [18:56:43] that was just to proxy via apache probably [18:59:24] 10LibUp: Failed building wheel for pyrsistent - https://phabricator.wikimedia.org/T249534 (10Reedy) Googling suggests adding `wheel` to the pip install should fix it... But doesn't seem to for me https://stackoverflow.com/questions/34819221/why-is-python-setup-py-saying-invalid-command-bdist-wheel-on-travis-ci [19:00:24] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10QEDK) >>! In T234743#6033372, @Huji wrote: > I, and at least two other folks on fawiki, are experiencing this b... [19:00:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Investigate Docker slowness between 18.06.2 and 18.09.7 - https://phabricator.wikimedia.org/T236675 (10hashar) [19:02:55] I love reading my previous notes: """CONCLUSION: regression in Docker somewhere ;-\\\ FUCk""" [19:06:07] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Investigate Docker slowness between 18.06.2 and 18.09.7 - https://phabricator.wikimedia.org/T236675 (10hashar) [19:08:47] Hi all... Is there a current policy regarding using external front-end libraries? I'm reviewing a patch that checks a new external thingy into an extension repo (CentralNotice) in a resources/vendor directory [19:09:28] Not sure it's the best way to do it, a bit concerned about maintenance, though there is precedent for doing it that way [19:09:49] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/518449 [19:10:29] Yippee, build fixed! [19:10:30] Project mediawiki-core-doxygen-docker build #14922: 09FIXED in 6 min 26 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/14922/ [19:13:26] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Investigate Docker slowness between 18.06.2 and 18.09.7 - https://phabricator.wikimedia.org/T236675 (10hashar) [19:16:53] AndyRussG: I guess you could ask on wikitech-l for a more general audience [19:17:20] AndyRussG: I don't think we have any system to ship javascript dependencies beside having them added in a vendor directory as you have done [19:17:34] there is one team apparently using webpack , but I don'tknow much about it [19:18:04] and there is of course the performance implication of adding jquery.jstree in central notice. But I guess it is for a specific page ;) [19:21:06] PROBLEM - Free space - all mounts on deployment-etcd-01 is CRITICAL: (Service Check Timed Out) [19:23:14] 10LibUp, 10Patch-For-Review: Failed building wheel for pyrsistent - https://phabricator.wikimedia.org/T249534 (10Reedy) Debian package worked... Dunno if we really needed to pip install it too [19:25:24] Reedy: python3-wheel already installs "wheel" ;] [19:25:47] pip potentially installs a newer version [19:25:57] RECOVERY - Free space - all mounts on deployment-etcd-01 is OK: OK: All targets OK [19:28:22] 10LibUp, 10Patch-For-Review: Failed building wheel for pyrsistent - https://phabricator.wikimedia.org/T249534 (10Reedy) It does look like the pip one is a noop ` Building wheels for collected packages: pyrsistent Running setup.py bdist_wheel for pyrsistent: started Running setup.py bdist_wheel for pyrsist... [19:30:43] 10LibUp, 10Documentation: Document Libup - https://phabricator.wikimedia.org/T249545 (10Reedy) [19:32:30] 10LibUp, 10Documentation: Document Libup - https://phabricator.wikimedia.org/T249545 (10Reedy) p:05Triage→03High a:03Legoktm [19:36:55] 10Gerrit, 10Release-Engineering-Team, 10Fundraising-Backlog: Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 (10Ejegg) [19:38:08] hashar: ok thanks much! Yeah the performance implications of an extra RL module should be mitigated by it only being registered when used [19:42:37] AndyRussG: that is the only thing I can think of :] [19:57:46] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: (Service Check Timed Out) [20:04:38] (03PS1) 10Umherirrender: Reduce code duplication in FunctionCommentSniff about short type checks [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/586430 [20:07:06] hashar: :) thx! [20:13:08] 10Release-Engineering-Team (Pipeline), 10ChangeProp: Service pipeline fails if initiated by creating a tag - https://phabricator.wikimedia.org/T249549 (10Pchelolo) [20:14:58] (03CR) 10Umherirrender: [C: 04-2] "First split of is If99fcd80039b8881987e7ca177e2d46048c98e78" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [20:19:36] 10Release-Engineering-Team (Pipeline), 10ChangeProp: Service pipeline fails if initiated by creating a tag - https://phabricator.wikimedia.org/T249549 (10Pchelolo) [20:22:45] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: (Service Check Timed Out) [20:36:07] 10Release-Engineering-Team (Pipeline), 10ChangeProp: Service pipeline fails if initiated by creating a tag - https://phabricator.wikimedia.org/T249549 (10Pchelolo) I have managed to workaround the problem by manually restarting Jenkins job and supplying some a change-id of some bogus unrelated changes I create... [20:56:02] 10LibUp: Unhandled rejection Error: EACCES: permission denied, mkdir '/cache' - https://phabricator.wikimedia.org/T249552 (10Reedy) [20:57:27] 10LibUp: Unhandled rejection Error: EACCES: permission denied, mkdir '/cache' - https://phabricator.wikimedia.org/T249552 (10Reedy) ` $ composer test Cannot create cache directory /cache/composer/repo/https---packagist.org/, or directory is not writable. Proceeding without cache Cannot create cache directory /ca... [20:59:44] 10LibUp: Unhandled rejection Error: EACCES: permission denied, mkdir '/cache' - https://phabricator.wikimedia.org/T249552 (10Reedy) And then a bit further before dying ` $ npm i --package-lock-only Unhandled rejection Error: EACCES: permission denied, mkdir '/cache' Unhandled rejection Error: EACCES: permission... [21:06:07] 10Deployments, 10Release-Engineering-Team-TODO, 10Developer Productivity: Train changelog: Omit empty sections - https://phabricator.wikimedia.org/T249553 (10Krinkle) [21:06:42] 10Deployments, 10Release-Engineering-Team-TODO, 10Developer Productivity: Train changelog: Omit empty sections - https://phabricator.wikimedia.org/T249553 (10Krinkle) I manually applied this with a find/replace regex to for whomever it may bene... [21:09:21] (03PS2) 10Jforrester: Add jobs for labs/tools/articles-needing-links [integration/config] - 10https://gerrit.wikimedia.org/r/585927 (owner: 10Urbanecm) [21:10:37] (03CR) 10Jforrester: "Why does this need expensive extra jobs? Will they run for hours?" [integration/config] - 10https://gerrit.wikimedia.org/r/585927 (owner: 10Urbanecm) [21:11:17] (03CR) 10Jforrester: [C: 03+2] jjb: Adjust comment mentioning REL1_26 for my sanity [integration/config] - 10https://gerrit.wikimedia.org/r/586396 (owner: 10Jforrester) [21:11:31] James_F: no - if there is another solution to make jenkins run tox there, I'd be happy to know [21:11:54] (03CR) 10jerkins-bot: [V: 04-1] jjb: Adjust comment mentioning REL1_26 for my sanity [integration/config] - 10https://gerrit.wikimedia.org/r/586396 (owner: 10Jforrester) [21:12:11] 10LibUp: Unhandled rejection Error: EACCES: permission denied, mkdir '/cache' - https://phabricator.wikimedia.org/T249552 (10Reedy) Noting T249545 ` # Shared cache ENV NPM_CONFIG_CACHE=/cache ENV XDG_CACHE_HOME=/cache ` Should this /cache be created locally or something? [21:12:23] Urbanecm: Just use tox-docker? [21:12:30] I [21:12:32] Bah. [21:12:35] I'll do it. [21:13:07] James_F: thanks. Please ping me once done, so I can learn from that :) [21:14:22] Urbanecm: Like that. [21:15:14] 10LibUp, 10MediaWiki-General, 10Patch-For-Review: `composer lint` doesn't actually work in libraryupgrader on mw core - https://phabricator.wikimedia.org/T249554 (10Reedy) [21:15:29] (03PS3) 10Jforrester: layout: Add jobs for labs/tools/articles-needing-links [integration/config] - 10https://gerrit.wikimedia.org/r/585927 (owner: 10Urbanecm) [21:15:39] Sorry, wikibugs is being slow. [21:16:01] 10LibUp, 10MediaWiki-General, 10Patch-For-Review: `composer lint` doesn't actually work in libraryupgrader on mw core - https://phabricator.wikimedia.org/T249554 (10Reedy) If we call `composer test .`... and it results in `parallel-lint . --exclude vendor --exclude node_modules '.'` in extensions.. Would it... [21:16:44] (03CR) 10Jforrester: [C: 03+2] "…" [integration/config] - 10https://gerrit.wikimedia.org/r/586396 (owner: 10Jforrester) [21:17:05] (03Merged) 10jenkins-bot: jjb: Adjust comment mentioning REL1_26 for my sanity [integration/config] - 10https://gerrit.wikimedia.org/r/586396 (owner: 10Jforrester) [21:18:23] thanks James_F. Can I ask in which way are extra jobs expensive? Just curious :) [21:18:43] Urbanecm: Adds complexity when rolling out fixes/etc. [21:18:55] The only benefit is that you get your own bespoke pipeline. [21:19:09] But if you're not running dozens of patches a day you won't notice. [21:19:21] so it's "human time" expensivity rather than something purely technical, right? [21:19:50] I mean, it also very slightly slows down jenkins, I guess. [21:19:56] But yes, mostly it's human-expensive. [21:20:02] Specifically, me-expensive. :-) [21:20:14] hehe :) [21:20:41] (03CR) 10Jforrester: [C: 03+2] layout: Add jobs for labs/tools/articles-needing-links [integration/config] - 10https://gerrit.wikimedia.org/r/585927 (owner: 10Urbanecm) [21:21:59] (03CR) 10Jforrester: [C: 03+2] Reenable tests for MathSearch [integration/config] - 10https://gerrit.wikimedia.org/r/586095 (https://phabricator.wikimedia.org/T117659) (owner: 10Physikerwelt) [21:22:01] (03Merged) 10jenkins-bot: layout: Add jobs for labs/tools/articles-needing-links [integration/config] - 10https://gerrit.wikimedia.org/r/585927 (owner: 10Urbanecm) [21:22:57] (03CR) 10Jforrester: [C: 03+2] [mediawiki/extensions/S5SlideShow] Run quibble [integration/config] - 10https://gerrit.wikimedia.org/r/582885 (owner: 10Umherirrender) [21:23:00] !log Zuul: Run CI for MathSearch T117659 [21:23:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:23:04] T117659: mwext-testextension-zend should load extension mathsearch after math - https://phabricator.wikimedia.org/T117659 [21:23:10] !log Zuul: Run CI for labs/tools/articles-needing-links [21:23:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:23:18] !log Zuul: Run CI for mediawiki/extensions/S5SlideShow [21:23:19] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:23:33] (03Merged) 10jenkins-bot: Reenable tests for MathSearch [integration/config] - 10https://gerrit.wikimedia.org/r/586095 (https://phabricator.wikimedia.org/T117659) (owner: 10Physikerwelt) [21:23:38] (03Merged) 10jenkins-bot: [mediawiki/extensions/S5SlideShow] Run quibble [integration/config] - 10https://gerrit.wikimedia.org/r/582885 (owner: 10Umherirrender) [21:32:17] 10LibUp, 10MediaWiki-General, 10Patch-For-Review: `composer lint` doesn't actually work in libraryupgrader on mw core - https://phabricator.wikimedia.org/T249554 (10Jdforrester-WMF) >>! In T249554#6034160, @Reedy wrote: > If we call `composer test .`... and it results in `parallel-lint . --exclude vendor --e... [21:33:35] (03CR) 10Jforrester: "Dependency is merged. Should we merge this?" [integration/config] - 10https://gerrit.wikimedia.org/r/584998 (https://phabricator.wikimedia.org/T210271) (owner: 10Hashar) [21:48:27] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Analytics, and 2 others: Migrate analytics/refinery/source release jobs to Docker - https://phabricator.wikimedia.org/T210271 (10Jdforr... [22:24:53] 10Release-Engineering-Team-TODO, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10PHP 7.2 support, 10Wikimedia-Incident: Performance regression from Apcu/ExtensionRegistry::loadFromQueue on PHP7 - https://phabricator.wikimedia.org/T187154 (10Krinkle) >>! In T187154#5954675, @Krin... [22:28:33] 10Continuous-Integration-Config, 10MathSearch, 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): mwext-testextension-zend should load extension mathsearch after math - https://phabricator.wikimedia.org/T117659 (10Jdforrester-WMF) Resolved? [22:31:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Investigate Docker slowness between 18.06.2 and 18.09.7 - https://phabricator.wikimedia.org/T236675 (10hashar) On integration-agent-doc... [22:35:16] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Investigate Docker slowness between 18.06.2 and 18.09.7 - https://phabricator.wikimedia.org/T236675 (10hashar) [22:41:56] ejegg: Hey, is the FundraisingEmailUnsubscribe extension used by FR-Tech still? It's not in main production but I worry that it is. Does it still require PHP70? [23:03:46] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Test-Coverage: Have a CI test that fails if a Beta Cluster extension has an unsatisfiable dependency - https://phabricator.wikimedia.org/T231601 (10Jdforrester-WMF) OK, `... [23:04:01] 10VPS-project-codesearch, 10Analytics: Add analytics/* gerrit repos to code search - https://phabricator.wikimedia.org/T249318 (10Ladsgroup) >>! In T249318#6032746, @Milimetric wrote: > I don't know how to add them. But would love to. Awesome. It's in this file: https://gerrit.wikimedia.org/r/plugins/gitiles... [23:16:05] 10Beta-Cluster-Infrastructure, 10Security-Team, 10Wikimedia-Site-requests, 10ContentSecurityPolicy: Change Content Security Policy on betacommons to allow api.flickr.com - https://phabricator.wikimedia.org/T249486 (10AlexisJazz) >>! In T249486#6032516, @Urbanecm wrote: > IIRC, neither beta nor production a... [23:40:39] James_F: Hi! Sorry for the delay in answering - it is deployed on the payments cluster, which does still use php 7.0 [23:40:49] hopefully we will have that upgraded within a few months [23:40:57] you monsters [23:41:13] ejegg|away: Cool. Is it just FundraisingEmailUnsubscribe and DonationInterface that need to maintain PHP7.0? [23:42:13] Or also ContributionTracking and ParserFunctions and cldr? [23:42:15] Joy.