[00:01:59] (03CR) 10Ppchelko: "I do not know what will happen if we do this, and I also do not know if there is a way to test this. I would be very grateful if you could" [integration/config] - 10https://gerrit.wikimedia.org/r/587610 (owner: 10Ppchelko) [01:01:59] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Quibble jobs re-download npm packages every build (Castor not loading?) - https://phabricator.wikimedia.org/T234738 (10Krinkle) https://integration.wikimedia.org/ci/jo... [01:02:10] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Quibble jobs re-download npm packages every build (Castor not loading?) - https://phabricator.wikimedia.org/T234738 (10Krinkle) 05Open→03Resolved [01:02:16] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [01:09:42] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Code-Health: Quibble: Run PHPUnit databaseless and database stages in parallel - https://phabricator.wikimedia.org/T235449 (10Krinkle) [03:10:51] 10Release-Engineering-Team-TODO, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10PHP 7.2 support, and 2 others: Performance regression from Apcu/ExtensionRegistry::loadFromQueue on PHP7 - https://phabricator.wikimedia.org/T187154 (10Legoktm) >>! In T187154#6041485, @Anomie wrote:... [07:35:20] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10MoritzMuehlenhoff) helm-diff also needs to be... [07:45:07] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10Dzahn) [07:53:30] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10Dzahn) [ ] E: Unable to locate package blubber... [09:25:50] 10Phabricator: Weekly phabricator-reports mail: List project tags which lack a project description - https://phabricator.wikimedia.org/T249805 (10Aklapper) p:05Triage→03Lowest [09:25:53] 10Phabricator: Weekly phabricator-reports mail: List project tag/color combinations which violate the "Types of Projects" definition - https://phabricator.wikimedia.org/T249806 (10Aklapper) p:05Triage→03Lowest [09:25:56] 10Phabricator: Weekly phabricator-reports mail: List open tasks with a Due Date in the past - https://phabricator.wikimedia.org/T249807 (10Aklapper) p:05Triage→03Lowest [09:28:14] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Aklapper) @ARamirez_WMF: Added you. (Usual default disclaimer: Please follow [guidelines](https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#New_projects) and... [09:34:24] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10hashar) > [ ] E: Unable to locate package zuul That one is intended... [09:45:18] (03PS1) 10Hashar: Rebuild for Buster [blubber] (debian) - 10https://gerrit.wikimedia.org/r/587706 (https://phabricator.wikimedia.org/T224591) [09:46:21] (03CR) 10Hashar: "contint* machines have the blubber Debian package and we are upgrading those boxes to Buster. I am not even sure we still rely on the De" [blubber] (debian) - 10https://gerrit.wikimedia.org/r/587706 (https://phabricator.wikimedia.org/T224591) (owner: 10Hashar) [09:46:26] (03CR) 10jerkins-bot: [V: 04-1] Rebuild for Buster [blubber] (debian) - 10https://gerrit.wikimedia.org/r/587706 (https://phabricator.wikimedia.org/T224591) (owner: 10Hashar) [09:47:28] (03CR) 10Hashar: "At least the Debian packaging work ;)]]" [blubber] (debian) - 10https://gerrit.wikimedia.org/r/587706 (https://phabricator.wikimedia.org/T224591) (owner: 10Hashar) [09:49:03] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10hashar) https://gerrit.wikimedia.org/r/587706... [09:59:56] 10Gerrit, 10Release-Engineering-Team, 10Wikimedia-GitHub: Last MW Core Security Release tags haven't pushed through to github - https://phabricator.wikimedia.org/T248842 (10hashar) >>! In T248842#6010877, @Reedy wrote: > It certainly worked before... I do not dismiss that it worked before. I guess the first... [10:00:06] 10Gerrit, 10Release-Engineering-Team, 10Wikimedia-GitHub: Last MW Core Security Release tags haven't pushed through to github - https://phabricator.wikimedia.org/T248842 (10hashar) p:05Triage→03Medium [10:06:07] 10Gerrit, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Fundraising-Backlog: Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 (10hashar) [10:07:35] !log gerrit: created empty repository wikimedia/fundraising/crm/drush/vendor owned by fundraising. # T249547 [10:07:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:07:38] T249547: Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 [10:29:22] 10Gerrit, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Fundraising-Backlog: Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 (10hashar) I have created the empty repository https://gerrit.wikimedia.org/r/#/admin/proj... [10:30:13] 10Gerrit, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Fundraising-Backlog: Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 (10hashar) p:05Triage→03High a:03hashar [12:27:01] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10hashar) 05Resolved→03Open I have forgot about this task, it is not... [12:27:03] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: CI mediawiki/core run times have increased since July 26th, 2019 - https://phabricator.wikimedia.org/T232626 (10hashar) [12:27:10] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10hashar) [12:34:17] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations: Rebuild helm/helm-diff for buster-wikimedia - https://phabricator.wikimedia.org/T249812 (10MoritzMuehlenhoff) [12:58:46] (03PS1) 10Hashar: tests: normalize parameter_function import [integration/config] - 10https://gerrit.wikimedia.org/r/587729 [12:59:32] (03CR) 10jerkins-bot: [V: 04-1] tests: normalize parameter_function import [integration/config] - 10https://gerrit.wikimedia.org/r/587729 (owner: 10Hashar) [13:11:30] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10Zuul, 10Developer Productivity: Abort a Zuul pipeline when one job completed with failures (change zuul scheduler's failure check... - https://phabricator.wikimedia.org/T248531 [13:11:32] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Scap: Unify deployment of integration/config.git changes using the official Wikimedia deployment system - https://phabricator.wikimedia.org/T111559 (10hashar) [13:11:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Scap (Scap3-Adoption-Phase2), 10Technical-Debt: Migrate deployment of integration/config for zuul to scap deploy - https://phabricator.wikimedia.org/T129357 (10hashar) 05Open→... [13:46:41] 10Beta-Cluster-Infrastructure: Request admin and interface rights for zhwiki on beta cluster - https://phabricator.wikimedia.org/T249819 (10gao_wenhai) [13:49:36] 10Beta-Cluster-Infrastructure: Request admin and interface admin rights on zhwiki beta cluster - https://phabricator.wikimedia.org/T249819 (10gao_wenhai) [14:09:20] (03PS2) 10Hashar: tests: normalize parameter_function import [integration/config] - 10https://gerrit.wikimedia.org/r/587729 [14:09:22] (03PS1) 10Hashar: Wikibase Selenium tests to their own job [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) [14:09:33] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10hashar) [14:10:28] (03CR) 10jerkins-bot: [V: 04-1] Wikibase Selenium tests to their own job [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [14:11:35] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10hashar) Cormac, Matthia... [14:34:36] (03PS2) 10Hashar: tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) [14:34:38] (03PS1) 10Hashar: Wikibase Selenium tests to their own job [integration/config] - 10https://gerrit.wikimedia.org/r/587776 [14:35:43] (03CR) 10jerkins-bot: [V: 04-1] tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [14:37:27] (03CR) 10Hashar: "That is some python black magic to import the standalone file. It just felt odd to have the import happening inside a function, it seems n" [integration/config] - 10https://gerrit.wikimedia.org/r/587729 (owner: 10Hashar) [14:39:28] thanks for the new repo hashar! [14:39:34] (03CR) 10Hashar: "PS2: ignore repository having solely the 'archived' template." [integration/config] - 10https://gerrit.wikimedia.org/r/587776 (owner: 10Hashar) [14:39:46] ejegg: good morning. The new repo is super straightforward ;] [14:40:07] ejegg: I will let you digest the thoughts I wrote about importing from upstream hehe [14:40:19] but it is probably straight forward as well. Just fetch from github and push to Gerrit [14:40:26] and you should be set [14:44:36] hashar ah right, so I can just reset locally and push to gerrit and not worry about the history discontinuity breaking things on the gerrit side? [14:45:11] We may have to reset some state in our own deploy scripts, but we can handle that [14:48:22] (03PS1) 10Hashar: scap: drop git_rev: master [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/587780 [14:48:39] (03PS2) 10Hashar: scap: drop git_rev: master [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/587780 (https://phabricator.wikimedia.org/T215458) [14:49:04] (03CR) 1020after4: [C: 03+1] scap: drop git_rev: master [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/587780 (https://phabricator.wikimedia.org/T215458) (owner: 10Hashar) [14:49:42] (03CR) 1020after4: [C: 03+2] scap: drop git_rev: master [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/587780 (https://phabricator.wikimedia.org/T215458) (owner: 10Hashar) [14:49:53] (03CR) 1020after4: [V: 03+2 C: 03+2] scap: drop git_rev: master [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/587780 (https://phabricator.wikimedia.org/T215458) (owner: 10Hashar) [14:58:56] ejegg: you don't even have to reset locally. You can push the reference from a remote to another remote. git push origin github/0.7x:0.7x for example [14:59:24] ejegg: but the master branch in our repo has a custom commit, so any attempt to push will be break beacuse the new reference is ot fast forward [14:59:37] ejegg: that would require a force push (and erase the custom commit). [15:00:12] also if you have anything relying on the master branch being what it is today, as soon as you push, those script will have some new code which might be unwanted [15:00:27] so maybe it is safer to have a custom new branch ( wmf-7.x ) [15:00:50] Anyone know if we're actively using phab/diffusion (ie arc) for any canonical repo? [15:02:14] we have a task to migrate the remaining repos [15:02:27] there might still be a few for tools labs [15:02:34] T191182 [15:02:34] T191182: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 [15:03:08] with a few sub tasks [15:03:42] Reedy: ^ ;) [15:03:46] Thanks! [15:04:02] Was just wondering for T249703 whether we need to pay attention for .arcconfig etc [15:04:03] T249703: Automatically close Pull Requests in repos mirrored on Github - https://phabricator.wikimedia.org/T249703 [15:04:14] ah github [15:04:17] I guess (for now), yes [15:04:24] It's not much more work, I don't think [15:04:33] Worth doing if we have some etc [15:04:34] I am wondering whether we should have the Gerrit mirrored repository to a standalone github organization [15:05:14] but I have too many cookies to lick already [15:06:55] heh [15:20:49] thanks for the advice hashar [15:21:51] there is a circular dependency there or something [15:22:04] i have heard people who still use it say they will use it until it's removed [15:30:10] 10Beta-Cluster-Infrastructure: Request admin and interface admin rights on zhwiki beta cluster - https://phabricator.wikimedia.org/T249819 (10DannyS712) @gao_wenhai how exactly are you fixing bugs in the MediaWiki namespace? Per https://meta.wikimedia.org/wiki/Special:CentralAuth/高文海 you aren't an admin or inter... [15:46:09] 10Beta-Cluster-Infrastructure: Request admin and interface admin rights on zhwiki beta cluster - https://phabricator.wikimedia.org/T249819 (10gao_wenhai) [[ https://zh.wikipedia.org/wiki/Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E6%8A%80%E6%9C%AF#%E5%85%B3%E4%BA%8E2017%E7%89%88%E7%BC%96%E8%BE%91%E5%99%A8_%... [15:46:21] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10thcipriani) >>! In T224591#6042651, @hashar wr... [15:46:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Yes, please." [integration/config] - 10https://gerrit.wikimedia.org/r/587610 (owner: 10Ppchelko) [15:50:13] (03CR) 10Hashar: [C: 03+2] "o FlaggedRevs is still a thing? ;)))" [integration/config] - 10https://gerrit.wikimedia.org/r/587610 (owner: 10Ppchelko) [15:51:12] (03Merged) 10jenkins-bot: Enable code coverage for FlaggedRevs extension [integration/config] - 10https://gerrit.wikimedia.org/r/587610 (owner: 10Ppchelko) [15:52:22] (03CR) 10Hashar: [C: 03+2] "I have deployed the change. You should be able to trigger the job by commenting "check coverage" on an open change." [integration/config] - 10https://gerrit.wikimedia.org/r/587610 (owner: 10Ppchelko) [15:52:58] (03CR) 10Dvorapa: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/510927 (https://phabricator.wikimedia.org/T132138) (owner: 10Dvorapa) [15:55:04] 10Release-Engineering-Team, 10Operations, 10serviceops: Hundreds of tags for `wikimedia/mediawiki-core` image - https://phabricator.wikimedia.org/T242775 (10Joe) p:05High→03Low [15:59:34] hashar: I've been thinking about splitting the selenium tests out for all repos. It'd make things much simpler… [16:01:27] got a question probably for greg-g: given that apr 22-23-24 are holidays running into the weekend and presumably are no-deploy days, do we treat the day before that (april 21) as a no-deploy friday? what are the plans for that week? [16:02:06] James_F: I thought about that as well, but most repos (and their deps) do not have selenium tests at all [16:02:15] Sure, but it's a no-op. [16:02:19] so that is an extra job with all the overhead of cloning repos / setting up dev dependencies etc [16:02:26] for little actual execution time [16:02:27] apergos: Probably. [16:02:32] hashar: Eh. [16:02:41] I will be reporting this back to our team, which is why I ask [16:02:44] which would add more stress to the instances (cause moare jobs are run) [16:02:54] hashar: We still run core's selenium tests with the extension, don't we? [16:03:02] James_F: might [16:03:14] hashar: So the job won't be empty. [16:05:32] James_F: then the mediawiki/core selenium tests are ~ 45 seconds apparently [16:05:45] a random example is https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php72-docker/13626/console [16:05:49] So ~1 min for clone for a 45 second job? [16:05:59] Not ideal, I agree. [16:06:09] 2:40 total runtime [16:06:34] and some good amount of that is cloning/install mw etc [16:06:59] Yeah. [16:09:56] so one of the issue is that lot of the overhead is common to all jobs [16:10:17] Yeah. [16:10:21] potentially we could have a job that does all the preparation work saving the result [16:10:32] then we would trigger several jobs in parallel all reusing those artifacts [16:10:43] If we could pre-fill the majority of the cloning? [16:10:47] Yeah. [16:10:54] Zuul v2.5 does not have support for that [16:11:04] Jenkins would definitely not scale [16:11:09] :-( [16:11:20] but maybe that can be done using an external storage of some sort [16:11:39] S3 like, a distributed file system, bittorent or whatever [16:13:51] I talked a bit about it with awight yesterday [16:14:06] and how some part can be done in quibble as a serie of goals to reach [16:14:10] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble, 10Regression: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty - https://phabricator.wikimedia.org/T246358 (10Lucas_Werkmeister_WMDE) Thanks, I looked at a recent build and cr... [16:14:18] the first one would be to lcone the repo, then install the dependencies etc [16:14:32] so a parent job would do something like quibble prepare-source [16:14:46] we then dispatch the resulting artifacts to different jobs that will each do something like: [16:14:57] quibble --resume-from=prepare-source phpunit [16:15:01] quibble --resume-from=prepare-source selenium [16:15:02] etc [16:15:10] but that is probably a bit too terrible [16:26:55] (03PS3) 10Jforrester: tests: normalize parameter_function import [integration/config] - 10https://gerrit.wikimedia.org/r/587729 (owner: 10Hashar) [16:26:57] (03PS2) 10Jforrester: Wikibase Selenium tests to their own job [integration/config] - 10https://gerrit.wikimedia.org/r/587776 (owner: 10Hashar) [16:26:59] (03PS3) 10Jforrester: tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [16:27:01] (03PS1) 10Jforrester: layout: [mediawiki/extensions/TemplateStyles] Move to vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587805 [16:27:03] (03PS1) 10Jforrester: layout: Move MachineVision, PropertySuggester, /WikibaseQualityConstraints, and Wikidata.org to split, vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587806 [16:27:20] hashar: Yeah. :-( [16:27:35] and I file tasks faster than I can resolve them :\ [16:28:50] That's my trick. [16:28:50] (03CR) 10jerkins-bot: [V: 04-1] tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [16:28:53] I don't file tasks. ;-) [16:29:13] (03CR) 10jerkins-bot: [V: 04-1] layout: Move MachineVision, PropertySuggester, /WikibaseQualityConstraints, and Wikidata.org to split, vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587806 (owner: 10Jforrester) [16:30:17] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki/extensions/TemplateStyles] Move to vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587805 (owner: 10Jforrester) [16:31:10] (03Merged) 10jenkins-bot: layout: [mediawiki/extensions/TemplateStyles] Move to vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587805 (owner: 10Jforrester) [16:31:54] (03PS2) 10Jforrester: layout: Move last production extensions to use vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587806 [16:32:42] !log Zuul: [mediawiki/extensions/TemplateStyles] Move to vendor [16:32:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:33:02] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MachineVision, 10MediaWiki-extensions-PropertySuggester, and 3 others: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 (10hashar) [16:33:16] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MachineVision, 10MediaWiki-extensions-PropertySuggester, and 3 others: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 (10hashar) [16:33:18] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10hashar) [16:33:43] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10hashar) Some of those r... [16:34:04] (03CR) 10Hashar: "I have filed T249845 "CI jobs for WMF deployed extensions should use vendor.git , not composer"." [integration/config] - 10https://gerrit.wikimedia.org/r/587776 (owner: 10Hashar) [16:34:42] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MachineVision, 10MediaWiki-extensions-PropertySuggester, and 3 others: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 (10hashar) [16:35:02] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MachineVision, 10MediaWiki-extensions-PropertySuggester, and 3 others: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 (10hashar) Interestingly, #Machi... [16:36:18] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Test-Coverage: Have a CI test that fails if a Beta Cluster extension has an unsatisfiable dependency - https://phabricator.wikimedia.org/T231601 (10thcipriani) >>! In T23... [16:39:48] (03PS1) 10Jforrester: parameter_functions: Drop dependencies for three archived extensions [integration/config] - 10https://gerrit.wikimedia.org/r/587810 [16:41:55] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Test-Coverage: Have a CI test that fails if a Beta Cluster extension has an unsatisfiable dependency - https://phabricator.wikimedia.org/T231601 (10Jdforrester-WMF) Yeah,... [16:43:01] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Test-Coverage: Have a CI test that fails if a Beta Cluster / production extension has an unsatisfiable dependency that blocks me... - https://phabricator.wikimedia.org/T231601 [16:43:41] (03CR) 10Jforrester: [C: 03+2] parameter_functions: Drop dependencies for three archived extensions [integration/config] - 10https://gerrit.wikimedia.org/r/587810 (owner: 10Jforrester) [16:44:00] (03CR) 10Jforrester: [C: 03+2] tests: normalize parameter_function import [integration/config] - 10https://gerrit.wikimedia.org/r/587729 (owner: 10Hashar) [16:45:18] (03Merged) 10jenkins-bot: parameter_functions: Drop dependencies for three archived extensions [integration/config] - 10https://gerrit.wikimedia.org/r/587810 (owner: 10Jforrester) [16:45:38] (03Merged) 10jenkins-bot: tests: normalize parameter_function import [integration/config] - 10https://gerrit.wikimedia.org/r/587729 (owner: 10Hashar) [16:46:05] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Test-Coverage: Have a CI test that fails if a Beta Cluster / production extension has an unsatisfiable dependency that blocks me... - https://phabricator.wikimedia.org/T231601 [16:46:55] (03PS3) 10Jforrester: layout: Split Wikibase-dependent repos into non-selenium & selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/587776 (owner: 10Hashar) [16:47:07] (03PS4) 10Jforrester: layout: Split Wikibase-dependent repos into non-selenium & selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/587776 (owner: 10Hashar) [16:47:23] (03PS3) 10Jforrester: layout: Move last production extensions to use vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587806 [16:48:55] (03PS4) 10Jforrester: tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [16:49:24] 10Continuous-Integration-Infrastructure, 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation phpunit run very slow due to inclusion of Scribunto and Wikibase - https://phabricator.wikimedia.org/T121595 (10hashar) [16:49:28] !log Zuul: parameter_functions: Drop dependencies for three archived extensions [16:49:29] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:49:33] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10CirrusSearch, and 4 others: Add a PHPUnit group to skip test on gated CI runs - https://phabricator.wikimedia.org/T225068 (10hashar) [16:50:25] apergos: tl;dr: no train that week and no deploys on those days off. swats open for the non-off days though. cc thcipriani (right?) [16:50:27] 10Continuous-Integration-Infrastructure, 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation phpunit run very slow due to inclusion of Scribunto and Wikibase - https://phabricator.wikimedia.org/T121595 (10hashar) At least for Scribunto that should be doable now with Quibble 0.0.41. There is a n... [16:50:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation phpunit run very slow due to inclusion of Scri... - https://phabricator.wikimedia.org/T121595 [16:52:49] * apergos waits to hear the ok [16:53:31] (03CR) 10Jforrester: [C: 03+2] layout: Split Wikibase-dependent repos into non-selenium & selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/587776 (owner: 10Hashar) [16:54:39] (03Merged) 10jenkins-bot: layout: Split Wikibase-dependent repos into non-selenium & selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/587776 (owner: 10Hashar) [16:55:07] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MachineVision, 10MediaWiki-extensions-PropertySuggester, and 3 others: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 (10Jdforrester-WMF) [16:55:34] !log Zuul: Split Wikibase-dependent repos into non-selenium & selenium jobs [16:55:35] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:55:46] (03PS4) 10Jforrester: layout: Move last production extensions to use vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587806 (https://phabricator.wikimedia.org/T249845) [16:56:36] (03CR) 10Jforrester: [C: 04-1] "Need to check that the repos have their dependencies in vendor. They should, because otherwise the train would have blown up, but will che" [integration/config] - 10https://gerrit.wikimedia.org/r/587806 (https://phabricator.wikimedia.org/T249845) (owner: 10Jforrester) [17:13:34] (03CR) 10Jforrester: [C: 03+2] "Manually confirmed." [integration/config] - 10https://gerrit.wikimedia.org/r/587806 (https://phabricator.wikimedia.org/T249845) (owner: 10Jforrester) [17:13:52] (03CR) 10Jforrester: [C: 03+2] tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [17:13:58] PROBLEM - Check systemd state on contint2001 is CRITICAL: CRITICAL - degraded: The system is operational but one or more units failed. https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [17:14:30] PROBLEM - zuul_merger_service_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args ^/usr/share/python/zuul/bin/python /usr/bin/zuul-merger https://www.mediawiki.org/wiki/Continuous_integration/Zuul [17:14:32] PROBLEM - git_daemon_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args ^/usr/lib/git-core/git-daemon --syslog https://www.mediawiki.org/wiki/Continuous_integration/Zuul [17:14:33] (03Merged) 10jenkins-bot: layout: Move last production extensions to use vendor [integration/config] - 10https://gerrit.wikimedia.org/r/587806 (https://phabricator.wikimedia.org/T249845) (owner: 10Jforrester) [17:14:39] (03CR) 10Jforrester: [C: 03+2] parameter_functions: Drop old comment about gate and re-sort [integration/config] - 10https://gerrit.wikimedia.org/r/587381 (owner: 10Jforrester) [17:15:35] (03Merged) 10jenkins-bot: parameter_functions: Drop old comment about gate and re-sort [integration/config] - 10https://gerrit.wikimedia.org/r/587381 (owner: 10Jforrester) [17:15:45] (03PS5) 10Jforrester: tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [17:15:52] (03CR) 10Jforrester: [C: 03+2] "…" [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [17:17:25] (03Merged) 10jenkins-bot: tests: ensure Wikibase selenium tests are standalone [integration/config] - 10https://gerrit.wikimedia.org/r/587750 (https://phabricator.wikimedia.org/T232759) (owner: 10Hashar) [17:17:43] !log Zuul: Move last production extensions to use vendor [17:17:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:17:45] T249845 [17:17:45] T249845: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 [17:17:46] Bah. [17:18:27] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MachineVision, 10MediaWiki-extensions-PropertySuggester, and 4 others: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 (10Jdforrester-WMF) 05Open→03... [17:18:31] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10Jdforrester-WMF) [17:19:16] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10MachineVision, 10MediaWiki-extensions-PropertySuggester, and 4 others: CI jobs for WMF deployed extensions should use vendor.git , not composer - https://phabricator.wikimedia.org/T249845 (10Jdforrester-WMF) [17:20:49] PROBLEM - Free space - all mounts on deployment-deploy01 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy01.diskspace._srv.byte_percentfree (<10.00%) [17:25:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Move CI selenium/qunit tests of mediawiki repository to a standalone job - https://phabricator.wikimedia.org/T232759 (10Jdforrester-WMF) 05Ope... [17:25:04] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: CI mediawiki/core run times have increased since July 26th, 2019 - https://phabricator.wikimedia.org/T232626 (10Jdforrester-WMF) [17:25:10] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Jdforrester-WMF) [17:25:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation phpunit run very slow due to inclusion of Scri... - https://phabricator.wikimedia.org/T121595 [17:30:14] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Discovery-Search, 10Wikidata, 10Wikidata-Campsite, and 2 others: Migrate wikidata-query-rdf-release-silent release job to Docker - https://phabricator.wikimedia.org/T247123 (10Mstyles) a:03Mstyles [17:30:49] RECOVERY - Free space - all mounts on deployment-deploy01 is OK: OK: All targets OK [17:50:19] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10ops-monitoring-bot) Icinga downtime for 1 day,... [17:50:59] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10ops-monitoring-bot) Icinga downtime for 4 days... [17:59:40] 10Release-Engineering-Team, 10Quibble, 10Core Platform Team Workboards (Green), 10Testing-Roadblocks: Modify Quibble to accept a LocalSettings.php file - https://phabricator.wikimedia.org/T235865 (10nnikkhoui) [18:04:28] 10Gerrit, 10Release-Engineering-Team, 10Wikimedia-GitHub: Last MW Core Security Release tags haven't pushed through to github - https://phabricator.wikimedia.org/T248842 (10Paladox) I see the tags now! https://github.com/wikimedia/mediawiki/releases [18:05:04] hellooo! Who would be a good person to answer a question about the current LocalSettings config in quibble? and the reasoning behind a given setting? [18:07:05] 10Gerrit, 10Release-Engineering-Team, 10Wikimedia-GitHub: Last MW Core Security Release tags haven't pushed through to github - https://phabricator.wikimedia.org/T248842 (10Reedy) >>! In T248842#6044224, @Paladox wrote: > I see the tags now! > > https://github.com/wikimedia/mediawiki/releases Yeah, they've... [18:07:36] 10Gerrit, 10Release-Engineering-Team, 10Wikimedia-GitHub: Last MW Core Security Release tags haven't pushed through to github - https://phabricator.wikimedia.org/T248842 (10Paladox) Oh, sorry i didn't read the whole task :( [18:18:10] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10User-Ladsgroup, and 3 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Jdforrester-WMF) [18:24:17] 10Project-Admins, 10Parsoid: Merge Parsoid and Parsoid-PHP project - https://phabricator.wikimedia.org/T241377 (10ssastry) >>! In T241377#6006708, @ssastry wrote: > It is close to the end of the quarter, and we can get this done next week whenever you get a chance. No reason to wait till end of April. We are... [18:30:25] is this the wrong timezone for thcipriani? I kinda lost track, a.k.a. time-has-no-meaning [18:30:51] he's around, probably missed my cc above. [18:31:08] I'm around [18:31:13] * thcipriani looks at scrollback [18:31:18] thcipriani: just to confirm my understanding of the week with few days... [18:31:21] nikkinikk: Git blame not help? :P [18:31:23] tl;dr: no train that week and no deploys on those days off. swats open for the non-off days though. [18:32:08] +1, yep, I'll post a calendar with ^ Soon™ [18:32:18] already declined train that week [18:33:26] nikkinikk: generally, hashar is the person to ask about quibble (primary author), though some others can help a bit. He's in France timezone-wise. [18:33:28] nikkinikk: the short answer is probably hash.ar but it's late for him, not sure who else is familiar with that file [18:34:01] ^^ ah ok thanks guys!! ill shoot him an email. not urgent mostly just a question around reasoning for one of the settings :) [18:34:10] * greg-g nods [18:41:29] 10Continuous-Integration-Config, 10LibUp, 10Front-end-Standards-Group: Move eslint ignores out of Gruntfile.js or package.json and into .eslintignore for all repos - https://phabricator.wikimedia.org/T249858 (10Jdforrester-WMF) [18:42:14] 10Continuous-Integration-Config, 10LibUp, 10Front-end-Standards-Group: Move eslint ignores out of Gruntfile.js or package.json and into .eslintignore for all repos - https://phabricator.wikimedia.org/T249858 (10Jdforrester-WMF) [18:43:04] 10Project-Admins, 10Parsoid: Merge Parsoid and Parsoid-PHP project - https://phabricator.wikimedia.org/T241377 (10Aklapper) @ssastry: Just lay out what's exactly to be done, and what's the earliest date. :) [19:00:56] 10Project-Admins, 10Parsoid: Merge Parsoid and Parsoid-PHP project - https://phabricator.wikimedia.org/T241377 (10ssastry) >>! In T241377#6044318, @Aklapper wrote: > @ssastry: Just lay out what's exactly to be done, and what's the earliest date. :) Just like the merging of other subprojects you tackled, (a) m... [19:07:31] (03PS1) 10Jforrester: layout: Add Kartographer to the gate [integration/config] - 10https://gerrit.wikimedia.org/r/587848 (https://phabricator.wikimedia.org/T204252) [19:12:33] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T247774 (10jeena) Thanks to @Nikerabbit @Volker_E @Krinkle @Jdforrester-WMF @Ladsgroup for helping unblock this week's train! [19:14:34] (03CR) 10Jforrester: [C: 03+2] layout: Add Kartographer to the gate [integration/config] - 10https://gerrit.wikimedia.org/r/587848 (https://phabricator.wikimedia.org/T204252) (owner: 10Jforrester) [19:17:59] (03Merged) 10jenkins-bot: layout: Add Kartographer to the gate [integration/config] - 10https://gerrit.wikimedia.org/r/587848 (https://phabricator.wikimedia.org/T204252) (owner: 10Jforrester) [19:18:14] PROBLEM - Free space - all mounts on deployment-deploy02 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy02.diskspace._srv.byte_percentfree (<11.11%) [19:21:33] nikkinikk: o/ [19:21:41] was having dinner / kids story time etc [19:22:13] hey! aw, hope you read em a good one :) [19:22:44] (03PS1) 10C. Scott Ananian: Update parsoid CI tests [integration/config] - 10https://gerrit.wikimedia.org/r/587853 [19:23:15] RECOVERY - Free space - all mounts on deployment-deploy02 is OK: OK: All targets OK [19:23:43] its not urgent at all, just wanted to know why $wgDevelopmentWarnings was set to true for unit tests, and false for integration tests? (and if thats not the case correct me if im mistaken but i think thats whats happening) [19:23:49] ACKNOWLEDGEMENT - Check systemd state on contint2001 is CRITICAL: CRITICAL - degraded: The system is operational but one or more units failed. amusso Being dist upgraded. T224591 https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [19:23:49] ACKNOWLEDGEMENT - git_daemon_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args ^/usr/lib/git-core/git-daemon --syslog amusso Being dist upgraded. T224591 https://www.mediawiki.org/wiki/Continuous_integration/Zuul [19:23:50] ACKNOWLEDGEMENT - zuul_merger_service_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args ^/usr/share/python/zuul/bin/python /usr/bin/zuul-merger amusso Being dist upgraded. T224591 https://www.mediawiki.org/wiki/Continuous_integration/Zuul [19:24:20] (03CR) 10jerkins-bot: [V: 04-1] Update parsoid CI tests [integration/config] - 10https://gerrit.wikimedia.org/r/587853 (owner: 10C. Scott Ananian) [19:25:04] nikkinikk: hmmm I have no idea? ;) [19:25:33] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Epic, 10Patch-For-Review: Have dependencies of gated extensions in the gate - https://phabricator.wikimedia.org/T204252 (10Jdforrester-WMF) [19:26:27] nikkinikk: Quibble has a LocalSettings.php wrapper which include includes/DevelopmentSettings.php which in turn set $wgDevelopmentWarnings [19:26:32] so it should always be set [19:26:53] but maybe some test set it false and does not restore the global [19:26:56] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Epic, 10Patch-For-Review: Have all Wikimedia production extensions and skins in the CI gate - https://phabricator.wikimedia.org/T249674 (10Jdforrester-WMF) [19:27:03] or there is another reason entirely [19:29:51] gotttt it, so ideally it should always be true. ok that helps, i will look around and see if its being unset somewhere. [19:30:06] or maybe my problem is happening somewhere else entirely lol. [19:30:12] thanks! [19:30:43] nikkinikk: what leads you to think it is disabled? [19:30:56] or to rephrase, what are the symptoms ?;) [19:32:44] (03PS2) 10C. Scott Ananian: Update parsoid CI tests [integration/config] - 10https://gerrit.wikimedia.org/r/587853 [19:33:07] and potentially you could drop into a shell with quibble --command bash [] [args] [19:33:25] or maybe quibble --command 'php maintenance/shell.php' ;] [19:37:36] Oh, bugger. [19:40:33] (03PS3) 10Jforrester: layout: [mediawiki/services/parsoid] Add experimental 'extension-phan' [integration/config] - 10https://gerrit.wikimedia.org/r/587853 (owner: 10C. Scott Ananian) [19:40:54] Well I was writing a test that tests a deprecation warning is being thrown, and the test was giving me different behavior when put in the MW /phpunit/unit directory vs in just /phpunit which made me think that $wgDevelopmentWarnings was set differently when running different kinds of tests. But if its supposed to always be true, I'm gonna just DOUBLE check that this isn't a "me" issue first. haha [19:41:09] (03PS1) 10Jforrester: layout: [mediawiki/services/parsoid/deploy] Drop all voting CI [integration/config] - 10https://gerrit.wikimedia.org/r/587857 [19:41:12] ohhh [19:43:02] nikkinikk: the unit test should not require LocalSettings.php / a database. And thus they do not include includes/DevelopmentSettings.php and $wgDevelopmentWarnings would be the default: false [19:43:42] right. because its a unit test.... [19:43:43] (03CR) 10C. Scott Ananian: [C: 03+1] layout: [mediawiki/services/parsoid/deploy] Drop all voting CI [integration/config] - 10https://gerrit.wikimedia.org/r/587857 (owner: 10Jforrester) [19:43:43] tha tmight explain it [19:43:46] yeah [19:43:46] (03PS2) 10Jforrester: layout: [mediawiki/services/parsoid/deploy] Drop all voting CI [integration/config] - 10https://gerrit.wikimedia.org/r/587857 [19:43:55] lol ok yeah that makes total sense now [19:44:02] kostajh wrote that part in mediawiki/core [19:44:12] thank yous very much [19:44:44] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Epic, 10Patch-For-Review: Have all Wikimedia production extensions and skins in the CI gate - https://phabricator.wikimedia.org/T249674 (10Jdforrester-WMF) [19:44:45] (03PS4) 10Jforrester: layout: [mediawiki/services/parsoid] Add experimental 'extension-phan' [integration/config] - 10https://gerrit.wikimedia.org/r/587853 (owner: 10C. Scott Ananian) [19:44:45] and it should call tests/phpunit/bootstrap.php [19:44:52] so maybe the setting should be enabled for unit test [19:44:54] and put there [19:45:00] (03PS1) 10Jforrester: layout: Add WikimediaMessages to the gate [integration/config] - 10https://gerrit.wikimedia.org/r/587858 (https://phabricator.wikimedia.org/T204252) [19:45:33] might be worth filing a task about it and cc kosta, I would trust his judgement [19:45:33] ;) [19:46:04] trust my judgment at your own risk :P [19:46:18] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Epic, 10Patch-For-Review: Have dependencies of gated extensions in the gate - https://phabricator.wikimedia.org/T204252 (10Jdforrester-WMF) [19:46:44] kostajh: ;]]] [19:46:45] (03CR) 10Jforrester: [C: 03+2] layout: Add WikimediaMessages to the gate [integration/config] - 10https://gerrit.wikimedia.org/r/587858 (https://phabricator.wikimedia.org/T204252) (owner: 10Jforrester) [19:46:48] on that otpic [19:46:58] WMDE is splitting the Wikibase tests between uniti and integration tests as well [19:47:03] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Epic, 10Patch-For-Review: Have dependencies of gated extensions in the gate - https://phabricator.wikimedia.org/T204252 (10Jdforrester-WMF) [19:47:06] which is a good model to have [19:47:26] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Epic, 10Patch-For-Review: Have dependencies of gated extensions in the gate - https://phabricator.wikimedia.org/T204252 (10Jdforrester-WMF) [19:47:39] 10Continuous-Integration-Config, 10ContentTranslation, 10MediaWiki-extensions-Interwiki, 10MediaWiki-extensions-TranslationNotifications, and 2 others: Add i18n related extensions to the CI gate - https://phabricator.wikimedia.org/T86930 (10Jdforrester-WMF) [19:48:28] (03Merged) 10jenkins-bot: layout: Add WikimediaMessages to the gate [integration/config] - 10https://gerrit.wikimedia.org/r/587858 (https://phabricator.wikimedia.org/T204252) (owner: 10Jforrester) [19:49:02] James_F: we used to have the gate job (wmf-quibble*) in the experimental pipeline with the triggering repo being added to the list of gated things [19:49:03] hashar: yeah, I've seen some extensions doing it [19:49:10] but we could probably do more to promote it. [19:49:22] James_F: which was handy to test addition of a repo to the gated job. But I don't know whether that still exist [19:49:31] kostajh: definitely [19:49:35] hashar: Yeah. [19:50:31] !log Zuul: Adjust parsoid CI config and parsoid/deploy CI config [19:50:32] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:50:44] (03CR) 10C. Scott Ananian: [C: 03+1] layout: [mediawiki/services/parsoid] Add experimental 'extension-phan' [integration/config] - 10https://gerrit.wikimedia.org/r/587853 (owner: 10C. Scott Ananian) [19:51:19] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki/services/parsoid/deploy] Drop all voting CI [integration/config] - 10https://gerrit.wikimedia.org/r/587857 (owner: 10Jforrester) [19:52:25] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki/services/parsoid] Add experimental 'extension-phan' [integration/config] - 10https://gerrit.wikimedia.org/r/587853 (owner: 10C. Scott Ananian) [19:52:59] (03Merged) 10jenkins-bot: layout: [mediawiki/services/parsoid/deploy] Drop all voting CI [integration/config] - 10https://gerrit.wikimedia.org/r/587857 (owner: 10Jforrester) [19:53:23] (03Merged) 10jenkins-bot: layout: [mediawiki/services/parsoid] Add experimental 'extension-phan' [integration/config] - 10https://gerrit.wikimedia.org/r/587853 (owner: 10C. Scott Ananian) [19:53:30] 10Release-Engineering-Team-TODO, 10Scap, 10observability, 10Developer Productivity, 10Regression: Scap no longer sets 'level' in Logstash messages - https://phabricator.wikimedia.org/T246793 (10thcipriani) p:05High→03Medium I don't see a `loglevel` on any of our records in logstash, I do see `levelna... [20:01:29] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10Anomie) [20:02:22] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Consider what paging who should get for what in RelEng/EngProd? - https://phabricator.wikimedia.org/T247427 (10thcipriani) [20:03:00] JamesF: "Move last production extensions to use vendor" https://gerrit.wikimedia.org/r/587806 [20:03:04] have you verified them ? [20:03:17] hashar: Yes. [20:03:28] hashar: Manual review of the versions in vendor.git. [20:03:30] perfet ! [20:03:47] thank you :]] [20:03:49] I was thinking of making a template for production extensions which pulls together all the variations. [20:04:03] But that relies on us splitting selenium and non-selenium everywhere. ;-) [20:04:10] yeah hmm [20:04:13] maybe [20:04:55] another thing that would be nice is to have a test that ensure wmf deployed extensions (as listed in mediawiki/tools/release ) are using vendor.git [20:05:55] or that they all have the gate-and-submit-swat pipelines for example [20:06:01] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [20:06:02] ie keep them in sync [20:07:31] hashar: That's why I wanted a single template. [20:07:50] Very simple to know if we think it's a production extension if it's listed in layout.yaml. ;-) [20:17:24] thcipriani: heya! have a moment? [20:17:45] Pchelolo: sure, what's up? [20:17:55] tldr: so I have a patch that I will +2, the patch is big and risky https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/585376 [20:18:28] risky cause it's big and cause it's FlaggedRevs that have not too many tests, not cause something weird is going on [20:19:03] so should I write it on the deployment blockers? Or should I just say that it's coming? [20:19:23] I can sign up to hang out while the train is going to see if it works [20:20:33] thanks thcipr iani, just saw your answer a few days ago [20:20:36] *minutes [20:21:22] s/hang out/hang around/ [20:22:35] Pchelolo: I'd say go ahead and make a note on the train blocker for the train this is going to ride, definitly. [20:22:41] *definitely [20:23:32] the question of how to collaborate about the risky patches is a good one, are there things you can check on testwiki? group0 wikis (https://tools.wmflabs.org/versions for group0 wiki list)? [20:24:13] there is long boring part of train that you probably don't want to hang out for :P [20:24:39] but a checkin scheduled for after the rollout might be worthwhile [20:25:04] * thcipriani checks who's next week's conductor [20:25:10] FlaggedRevs don't seem to be enabled on testwiki.. [20:25:52] oh, but it is on test2wiki [20:26:07] ok. Lemme try to draft a message on the train blocker task and see what you think [20:26:18] nice [20:26:48] https://www.youtube.com/watch?v=lGCTD5o_eGI for my previous typo. took that long to find the clip [20:26:54] wait wait [20:26:56] not that [20:27:08] :D [20:27:21] https://youtu.be/lGCTD5o_eGI?t=273 that! [20:28:42] Pchelolo: James_F is the train conductor next week. James_F could you take a look at backscroll here: for collaboration on this patchset/needs from the train conductor's POV -- what do you think? [20:29:00] * James_F reads. [20:29:20] Oh, right, FR. [20:29:45] Determining brokeness is hard because the feature is (a) complex and (b) not very good. [20:29:56] So one person's breakage is another person's working-as-expected. [20:30:00] (03PS1) 10C. Scott Ananian: Allow MediaWiki dependency jobs (aka mwext-php72-phan) to run on Parsoid repo [integration/config] - 10https://gerrit.wikimedia.org/r/587861 [20:30:42] (03CR) 10C. Scott Ananian: "Problem being solved:" [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [20:31:02] (03CR) 10C. Scott Ananian: Allow MediaWiki dependency jobs (aka mwext-php72-phan) to run on Parsoid repo (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [20:31:11] Pchelolo: Can you test it post-merge on Beta Cluster a bit? That'd not be perfect, but it'd help assure us. [20:31:24] yeah, was planning to do so [20:31:39] Cool. In that case, I'm not especially worried. [20:31:46] thcipriani: ok, what do you think: https://phabricator.wikimedia.org/T247775#6044738 ? [20:32:27] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T247775 (10Pchelolo) Risky patch rolling this train: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/585376 **Idea of the patch... [20:34:20] Pchelolo: nice, the "testing" section is helpful. Are there specific places to watch for breakage, other than logstash? "Rollback plan" is one field that we've thought about in the past, but i'm not sure if that makes sense here or not. [20:35:20] (03CR) 10Jforrester: [C: 04-1] Allow MediaWiki dependency jobs (aka mwext-php72-phan) to run on Parsoid repo (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [20:35:28] yeah, I've edited and added "In case of UBN: revert" section [20:35:36] Thank you. [20:35:54] and for testing - not really, as James said, it's a complicated feature with ton of edge cases [20:36:13] ack [20:36:54] Pchelolo: this looks good to me, thanks for reaching out I appreciate it! [20:37:15] oh James_F, FlaggedRevs is not enabled in beta! [20:37:33] or is it.. [20:38:00] Nowhere? [20:38:02] * James_F looks. [20:38:45] wmf-config/config-cache/conf-labs-dewiki.json: "wmgUseFlaggedRevs": true, [20:38:58] lovely wmde folks ;] [20:39:30] that config-cache thing sounds lovely as well? So we can easily figure out the settings for each of the wikis we have? [20:40:24] it turns out to case some headaches :P [20:41:46] oh, I didn't know about that.. that's so much better then parsing config code [20:41:56] parsing in your head [20:43:17] maybe it saves some headaches too in that case [21:02:14] (03PS2) 10Jeena Huneidi: tutorial: Add test and publish pipelines [blubber-doc/example/helloworldoid] (kubernetes-tutorial) - 10https://gerrit.wikimedia.org/r/583788 [21:34:46] (03CR) 10C. Scott Ananian: Allow MediaWiki dependency jobs (aka mwext-php72-phan) to run on Parsoid repo (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [21:37:29] (03PS2) 10C. Scott Ananian: Allow MediaWiki dependency jobs (aka mwext-php72-phan) to run on services repos [integration/config] - 10https://gerrit.wikimedia.org/r/587861 [21:48:08] (03PS1) 10Jforrester: Exclude phpunit group Standalone from the Database run [integration/quibble] - 10https://gerrit.wikimedia.org/r/587872 [21:48:47] (03CR) 10jerkins-bot: [V: 04-1] Exclude phpunit group Standalone from the Database run [integration/quibble] - 10https://gerrit.wikimedia.org/r/587872 (owner: 10Jforrester) [21:50:26] (03PS2) 10Jforrester: Exclude phpunit group Standalone from the Database run [integration/quibble] - 10https://gerrit.wikimedia.org/r/587872 [22:02:18] (03PS3) 10Jeena Huneidi: tutorial: Add test and publish pipelines [blubber-doc/example/helloworldoid] (kubernetes-tutorial) - 10https://gerrit.wikimedia.org/r/583788 [22:10:54] (03PS3) 10Jforrester: parameter_functions: Run set_mw_dependencies for mediawiki/services/parsoid too [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [22:11:04] (03CR) 10Jforrester: [C: 03+2] parameter_functions: Run set_mw_dependencies for mediawiki/services/parsoid too [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [22:11:54] (03Merged) 10jenkins-bot: parameter_functions: Run set_mw_dependencies for mediawiki/services/parsoid too [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [22:29:12] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10MediaWiki-Core-Testing, 10Quibble, 10Code-Health: Quibble: Run PHPUnit databaseless and database stages in parallel - https://phabricator.wikimedia.org/T235449 (10awight) [22:49:29] (03PS1) 10Awight: Remove redundant logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/587881 [22:52:03] (03PS1) 10Awight: Extract git_clean into a function [integration/quibble] - 10https://gerrit.wikimedia.org/r/587882 [22:55:08] (03CR) 10Jforrester: [C: 03+2] Remove redundant logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/587881 (owner: 10Awight) [22:55:53] (03CR) 10Jforrester: [C: 03+2] Extract git_clean into a function [integration/quibble] - 10https://gerrit.wikimedia.org/r/587882 (owner: 10Awight) [22:56:00] (03Merged) 10jenkins-bot: Remove redundant logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/587881 (owner: 10Awight) [22:56:42] (03Merged) 10jenkins-bot: Extract git_clean into a function [integration/quibble] - 10https://gerrit.wikimedia.org/r/587882 (owner: 10Awight) [22:57:23] (03PS3) 10Jforrester: Factor visitor out of executor [integration/quibble] - 10https://gerrit.wikimedia.org/r/587606 (https://phabricator.wikimedia.org/T249775) (owner: 10Awight) [22:57:29] (03PS3) 10Jforrester: Support command recursion [integration/quibble] - 10https://gerrit.wikimedia.org/r/587608 (https://phabricator.wikimedia.org/T249775) (owner: 10Awight) [22:58:42] (03CR) 10Jforrester: "Before merging, I think a use of this would be good to see. ;-)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/587608 (https://phabricator.wikimedia.org/T249775) (owner: 10Awight) [22:59:58] (03CR) 10Jforrester: [C: 03+1] "Oh, right, If84f992ca4? Hmm. That looks nice." [integration/quibble] - 10https://gerrit.wikimedia.org/r/587608 (https://phabricator.wikimedia.org/T249775) (owner: 10Awight) [23:00:56] (03Abandoned) 10Awight: Support command recursion [integration/quibble] - 10https://gerrit.wikimedia.org/r/587608 (https://phabricator.wikimedia.org/T249775) (owner: 10Awight) [23:01:46] (03Abandoned) 10Awight: Factor visitor out of executor [integration/quibble] - 10https://gerrit.wikimedia.org/r/587606 (https://phabricator.wikimedia.org/T249775) (owner: 10Awight) [23:03:39] (03PS1) 10Awight: Drop redundant "Command" suffix [integration/quibble] - 10https://gerrit.wikimedia.org/r/587884 [23:06:23] (03CR) 10Jforrester: [C: 03+2] Drop redundant "Command" suffix [integration/quibble] - 10https://gerrit.wikimedia.org/r/587884 (owner: 10Awight) [23:07:24] (03Merged) 10jenkins-bot: Drop redundant "Command" suffix [integration/quibble] - 10https://gerrit.wikimedia.org/r/587884 (owner: 10Awight) [23:10:07] (03PS1) 10Awight: [WIP] Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 [23:15:09] (03CR) 10Awight: [C: 03+2] "Nice find!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/587872 (owner: 10Jforrester) [23:15:49] (03Merged) 10jenkins-bot: Exclude phpunit group Standalone from the Database run [integration/quibble] - 10https://gerrit.wikimedia.org/r/587872 (owner: 10Jforrester) [23:17:44] (03PS2) 10Awight: [WIP] Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 [23:39:07] (03PS3) 10Awight: Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 [23:39:52] (03CR) 10jerkins-bot: [V: 04-1] Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (owner: 10Awight) [23:47:35] (03PS4) 10Awight: Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 [23:47:37] (03PS1) 10Awight: [WIP][POC] Parallelize phpunit-unit -databaseless, and -standalone [integration/quibble] - 10https://gerrit.wikimedia.org/r/587887 (https://phabricator.wikimedia.org/T235449) [23:47:39] (03PS1) 10Awight: [WIP] Split npm and composer test commands [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 [23:47:41] (03PS1) 10Awight: [WIP] Sugary decorators [integration/quibble] - 10https://gerrit.wikimedia.org/r/587889 [23:47:43] (03PS1) 10Awight: [DNM] Clean-up: remove old parallel_run [integration/quibble] - 10https://gerrit.wikimedia.org/r/587890 [23:48:35] (03CR) 10jerkins-bot: [V: 04-1] [WIP][POC] Parallelize phpunit-unit -databaseless, and -standalone [integration/quibble] - 10https://gerrit.wikimedia.org/r/587887 (https://phabricator.wikimedia.org/T235449) (owner: 10Awight) [23:48:37] (03CR) 10jerkins-bot: [V: 04-1] Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (owner: 10Awight) [23:48:39] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Split npm and composer test commands [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [23:48:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Sugary decorators [integration/quibble] - 10https://gerrit.wikimedia.org/r/587889 (owner: 10Awight) [23:48:52] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Clean-up: remove old parallel_run [integration/quibble] - 10https://gerrit.wikimedia.org/r/587890 (owner: 10Awight) [23:51:46] (03CR) 10C. Scott Ananian: parameter_functions: Run set_mw_dependencies for mediawiki/services/parsoid too (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/587861 (owner: 10C. Scott Ananian) [23:57:14] (03PS5) 10Awight: [WIP] Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 [23:57:23] Darn, I couldn't get that one quite right. [23:58:26] (03PS1) 10Jforrester: layout: [mediawiki/services/parsoid/deploy] Use node 10 [integration/config] - 10https://gerrit.wikimedia.org/r/587891 [23:59:52] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki/services/parsoid/deploy] Use node 10 [integration/config] - 10https://gerrit.wikimedia.org/r/587891 (owner: 10Jforrester)