[00:16:21] 10Continuous-Integration-Config, 10MediaWiki-Documentation, 10Documentation: Create a Jenkins check to verify hooks.yaml formatting - https://phabricator.wikimedia.org/T116965 (10DannyS712) [00:25:30] (03PS1) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [00:31:42] (03PS2) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [00:32:54] (03Abandoned) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 (owner: 10DannyS712) [00:55:20] (03Restored) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [00:59:05] (03PS15) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [01:00:00] (03PS16) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [01:05:37] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [01:08:52] (03PS17) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [01:10:19] (03PS18) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [01:12:15] (03PS19) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [01:16:19] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [01:16:36] (03Abandoned) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [01:18:13] (03PS1) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591240 [01:23:56] (03PS2) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591240 [01:25:11] (03PS3) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591240 [01:26:33] (03PS4) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591240 [01:28:00] (03PS5) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591240 [01:29:05] (03PS6) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591240 [01:30:51] (03PS1) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [01:32:03] (03Abandoned) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591240 (owner: 10DannyS712) [01:32:08] (03PS2) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [01:32:24] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Treat assertEmpty() as problematic in PHPUnitAssertEquals - https://phabricator.wikimedia.org/T246674 (10DannyS712) a:03DannyS712 [01:32:56] (03PS3) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [01:33:20] (03PS4) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [01:34:40] (03PS5) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [01:38:39] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Treat assertEmpty() as problematic in PHPUnitAssertEquals - https://phabricator.wikimedia.org/T246674 (10DannyS712) >>! In T246674#5933045, @thiemowmde wrote: > In the past, I liked PHP's `empty()` exactly because it is so relaxed. Whenever I saw... [01:43:54] 10MediaWiki-Codesniffer: Add potentially problematic assertEquals( 1 ) to the PHPUnitAssertEquals sniff - https://phabricator.wikimedia.org/T246662 (10DannyS712) @thiemowmde can this be closed as resolved? [01:48:02] 10phan-taint-check-plugin, 10MobileFrontend: MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10sbassett) So https://gerrit.wikimedia.org/r/582909 didn't help at all with T183174? [01:48:18] 10phan-taint-check-plugin, 10MobileFrontend: MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10sbassett) p:05Triage→03Medium [02:04:42] (03PS1) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591247 [02:12:01] (03Abandoned) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591247 (owner: 10DannyS712) [05:27:24] (03PS1) 10Zoranzoki21: Archive the UnblockMe extension [integration/config] - 10https://gerrit.wikimedia.org/r/591258 (https://phabricator.wikimedia.org/T250564) [05:31:26] (03CR) 10Zoranzoki21: "I'm a bit confused with new Gerrit interface..." [integration/config] - 10https://gerrit.wikimedia.org/r/591258 (https://phabricator.wikimedia.org/T250564) (owner: 10Zoranzoki21) [05:35:32] what is the reason for running phpunit via vendor/bin/phpunit instead of phpunit.php? I think that is the reason there is no debug log anymore [05:35:34] 10MediaWiki-Codesniffer: Add potentially problematic assertEquals( 1 ) to the PHPUnitAssertEquals sniff - https://phabricator.wikimedia.org/T246662 (10thiemowmde) 05Open→03Resolved a:03thiemowmde Yup. According to https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/codesniffer/+/576045/2/MediaWiki/Tests/fil... [05:36:25] (03PS2) 10Zoranzoki21: Archive the UnblockMe extension [integration/config] - 10https://gerrit.wikimedia.org/r/591258 (https://phabricator.wikimedia.org/T250564) [06:55:04] 10Phabricator: Create new custom fundraising form - https://phabricator.wikimedia.org/T243961 (10Aklapper) >>! In T243961#5946562, @DStrine wrote: > ok thanks. I will run this by the stakeholders. They may still want something in the UI but I'll check. @DStrine: Any news to share? [06:55:59] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Aklapper) [07:00:23] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Aklapper) 05Stalled→03Declined As upstream already wrote: > We do not support Maxthon, so please try this in anothe... [07:01:39] Project beta-scap-eqiad build #297221: 04FAILURE in 6 min 45 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/297221/ [07:14:36] Yippee, build fixed! [07:14:36] Project beta-scap-eqiad build #297222: 09FIXED in 9 min 58 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/297222/ [07:21:49] (03PS4) 10Thiemo Kreuz (WMDE): Streamline a few minor details in FunctionComment sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/587201 [07:21:58] (03CR) 10Thiemo Kreuz (WMDE): Streamline a few minor details in FunctionComment sniff (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/587201 (owner: 10Thiemo Kreuz (WMDE)) [07:27:21] 10MediaWiki-Codesniffer: How to handle the nullable operator on multi type lists in code - https://phabricator.wikimedia.org/T250734 (10thiemowmde) Uh, nice suggestion! I agree. All examples that include a `?…` and a `…|…` the same time are not wrong, but very confusing. I would love to converted them all to `…|... [07:41:14] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "It looks like there are only 3 of these warnings in the test run. That's great news, I think. I feel it's worth having this sniff, even if" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) (owner: 10DannyS712) [07:42:10] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10thiemowmde) Sure. Let's just add it to the UnusedUseStatement sniff! [07:56:27] (03PS1) 10Thiemo Kreuz (WMDE): Revert "Add Squiz.Arrays.ArrayBracketSpacing to detect spaces in array indexer brackets" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591303 [08:03:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Revert "Add Squiz.Arrays.ArrayBracketSpacing to detect spaces in array indexer brackets" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591303 (owner: 10Thiemo Kreuz (WMDE)) [08:04:09] (03Merged) 10jenkins-bot: Revert "Add Squiz.Arrays.ArrayBracketSpacing to detect spaces in array indexer brackets" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591303 (owner: 10Thiemo Kreuz (WMDE)) [08:05:11] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10thiemowmde) 05Resolved→03Open Wait a second. Are we going to enforce one style now? Where is the discussion if this is a good idea, and how exactly it should be implemented? Why is barely an... [08:11:11] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10daniel) What @thiemowmde said. I slightly prefer `$a[0]` to `$a[ 0 ]`, but I much prefer `$array[ $this->createKey( $inputValue ) ]` over ` $array[$this->createKey( $inputValue )]`, and `$foo[ $... [08:16:06] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Dvorapa) The second upstream report not yet closed (but anyway, we don't need to keep this downstream issue open anyway... [08:16:21] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using browser on mobile - https://phabricator.wikimedia.org/T209045 (10Dvorapa) [08:17:25] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Dvorapa) [08:23:55] helo. https://gerrit.wikimedia.org/r/c/operations/puppet/+/591304 is an attempt to fix https://phabricator.wikimedia.org/T246763 (occasional 502s from Gerrit) please do leave comments if you think it makes sense or is nonsense, i just found a guy with the same problem using apache to proxy to jetty, it's just really old, but that doesn't have to mean anything [08:27:39] 10Phabricator (Upstream), 10Upstream: Swap phabricator's default fields for "Tags" and "Assigned to" within the create task form - https://phabricator.wikimedia.org/T128482 (10Aklapper) Note that in the side bar of an existing task, the order is: Tags, Subscribers, Assigned To. In the default Form 1 to create... [08:29:52] 10Gerrit, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10ci-test-error (WMF-deployed Build Failure): Jenkins job failing intermittently due to Gerrit HTTP 502 errors when interacting with repos - https://phabricator.wikimedia.org/T246763 (10Dzahn) I found https://serverfau... [08:40:40] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Ammarpad) [08:41:59] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Ammarpad) >Cannot type into assigned to, tags and subscribers fields when using browser on mobile. This is not true. So... [08:44:57] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Firefox or Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Dvorapa) [08:45:28] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Firefox or Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Dvorapa) >>! In T209045#6074454, @Ammarpad wrote: >>Cannot type into assigned to, tags and subscribers field... [08:55:41] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Firefox or Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Aklapper) >>! In T209045#6074396, @Dvorapa wrote: > The second upstream report not yet closed I don't know... [09:39:54] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [09:40:13] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [09:40:58] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [09:45:37] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Aklapper) 05Open→03Stalled A few weeks after this task was created, https://secure.phabricator.com/T12588#242719 got implemented. Currently, if I click Edit Related Tasks... > Create Subta... [09:59:42] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 92758 bytes in 0.995 second response time [10:00:06] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 52125 bytes in 1.081 second response time [10:00:51] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 92459 bytes in 0.941 second response time [10:01:48] PROBLEM - Free space - all mounts on deployment-deploy01 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy01.diskspace._srv.byte_percentfree (<10.00%) [10:11:49] RECOVERY - Free space - all mounts on deployment-deploy01 is OK: OK: All targets OK [11:38:26] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Dvorapa) Seems solved on my side as well [11:40:22] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Firefox or Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Dvorapa) I mentioned Firefox from the beginning, I tested the issue on both. I also added link above (once a... [11:44:18] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Firefox or Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Dvorapa) 05Declined→03Resolved [11:48:14] (03CR) 10Hashar: [C: 03+2] Archive the UnblockMe extension [integration/config] - 10https://gerrit.wikimedia.org/r/591258 (https://phabricator.wikimedia.org/T250564) (owner: 10Zoranzoki21) [11:49:05] (03CR) 10jerkins-bot: [V: 04-1] Archive the UnblockMe extension [integration/config] - 10https://gerrit.wikimedia.org/r/591258 (https://phabricator.wikimedia.org/T250564) (owner: 10Zoranzoki21) [11:55:56] (03PS1) 10Hashar: Revert "Add Jenkins job for fresh.git" [integration/config] - 10https://gerrit.wikimedia.org/r/591324 (https://phabricator.wikimedia.org/T250766) [12:00:22] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10mmodell) 05Stalled→03Resolved fixed upstream [12:15:02] (03CR) 10Hashar: [C: 03+2] Revert "Add Jenkins job for fresh.git" [integration/config] - 10https://gerrit.wikimedia.org/r/591324 (https://phabricator.wikimedia.org/T250766) (owner: 10Hashar) [12:15:55] (03Merged) 10jenkins-bot: Revert "Add Jenkins job for fresh.git" [integration/config] - 10https://gerrit.wikimedia.org/r/591324 (https://phabricator.wikimedia.org/T250766) (owner: 10Hashar) [12:17:37] 10Continuous-Integration-Config, 10Fresh, 10Patch-For-Review: Move Fresh to Gerrit (mirror to GitHub) - https://phabricator.wikimedia.org/T250766 (10hashar) [12:43:42] 10Phabricator (Upstream), 10Mobile, 10Upstream: Cannot type into assigned to, tags and subscribers fields when using Firefox or Maxthon browser on mobile - https://phabricator.wikimedia.org/T209045 (10Aklapper) >>! In T209045#6074704, @Dvorapa wrote: > I mentioned Firefox from the beginning Hmm. [Not in thi... [12:47:13] hashar: If you find time for Quibble, I wanted to highlight just one patch: https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/587885/ [12:48:39] It's more robust than my usual drive-by submissions, and is potentially a game-changer IMO. This is the abstraction I've been searching for, a year on... [13:18:33] (03PS1) 10Paladox: Grant push access to ldap/ops [software/cas-overlay-template] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/591329 [13:19:04] (03CR) 10Jbond: [V: 03+2 C: 03+2] Grant push access to ldap/ops [software/cas-overlay-template] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/591329 (owner: 10Paladox) [13:29:48] (03CR) 10Hashar: [C: 03+2] "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/591258 (https://phabricator.wikimedia.org/T250564) (owner: 10Zoranzoki21) [13:30:13] (03PS6) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [13:30:17] (03CR) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) (owner: 10DannyS712) [13:30:49] (03Merged) 10jenkins-bot: Archive the UnblockMe extension [integration/config] - 10https://gerrit.wikimedia.org/r/591258 (https://phabricator.wikimedia.org/T250564) (owner: 10Zoranzoki21) [13:34:21] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10DannyS712) >>! In T250765#6074362, @thiemowmde wrote: > Sure. Let's just add it to the UnusedUseStatement sniff! I tried that; `@phan-var` isn't a proper t... [13:40:00] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10LarsWirzenius) a:03LarsWirzenius [13:40:28] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10LarsWirzenius) a:05LarsWirzenius→03None [13:41:32] awight: eventually yeah ;] [13:41:51] awight: I got bunch of various backlogs to expunge first [14:12:34] 10Continuous-Integration-Infrastructure, 10Fresh: Decide how to run a test involving docker inside WMF CI - https://phabricator.wikimedia.org/T250808 (10Krinkle) [14:14:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Fresh: Decide how to run a test involving docker inside WMF CI - https://phabricator.wikimedia.org/T250808 (10Krinkle) [14:37:33] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Fresh: Decide how to run a test involving docker inside WMF CI - https://phabricator.wikimedia.org/T250808 (10Krinkle) > (The VM would resume from a snapshot with docker, git, etc. pre-installed). I suppose we can do without that f... [14:48:11] !log Creating integration-agent-qemu-1001 to experiment with VM-based CI jobs – T250808 [14:48:13] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:48:14] T250808: Decide how to run a test involving docker inside WMF CI - https://phabricator.wikimedia.org/T250808 [14:52:13] (03PS1) 10Mholloway: Add Echo dependency for PushNotifications [integration/config] - 10https://gerrit.wikimedia.org/r/591355 [14:57:45] 10phan: $cfg['exclude_file_list'] doesn't seem to work - https://phabricator.wikimedia.org/T250814 (10Reedy) [14:59:13] (03CR) 10Hashar: [C: 04-1] "Took me a while to notice this change. I would rather have the checker script in a different repository in order to avoid to rebuild the c" [integration/config] - 10https://gerrit.wikimedia.org/r/560413 (https://phabricator.wikimedia.org/T179663) (owner: 10Addshore) [15:01:40] (03CR) 10Addshore: "mediawiki/tools/release sounds pretty good," [integration/config] - 10https://gerrit.wikimedia.org/r/560413 (https://phabricator.wikimedia.org/T179663) (owner: 10Addshore) [15:04:19] 10phan: $cfg['exclude_file_list'] doesn't seem to work - https://phabricator.wikimedia.org/T250814 (10Reedy) [15:05:13] 10phan: $cfg['exclude_file_list'] doesn't seem to work - https://phabricator.wikimedia.org/T250814 (10Daimona) 05Open→03Invalid Relative paths in the config file are based on the project folder (unless something else is specified), see comment on gerrit. [15:05:50] !log install 'qemu-system-x86' package on integration-agent-qemu-1001 [15:05:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:06:59] 10Release-Engineering-Team, 10ci-test-error: Upgrade ruby version for CI tests - https://phabricator.wikimedia.org/T250538 (10hashar) 05Resolved→03Open Ah I see what is happening. That has been broken by 037adb57222b3c3f1b13a0590c0185456aefea14 ( @JMeybohm ): ` --- a/.ruby-version +++ b/.ruby-version @@ -1... [15:07:03] 10phan: $cfg['exclude_file_list'] doesn't seem to work - https://phabricator.wikimedia.org/T250814 (10Reedy) >>! In T250814#6075308, @Daimona wrote: > Relative paths in the config file are based on the project folder (unless something else is specified), see comment on gerrit. Why is it inconsistent with the di... [15:08:54] 10phan: $cfg['exclude_file_list'] doesn't seem to work - https://phabricator.wikimedia.org/T250814 (10Daimona) It's not inconsistent, '../../' is the (usual) install path if you start from the extension's main dir. [15:13:57] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10User-Ladsgroup, and 3 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10eprodromou) @apaskulin asked me to comment on the domain name for the wiki. I'm really reluctant to use a... [15:14:39] Project beta-code-update-eqiad build #293262: 04FAILURE in 1 min 37 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/293262/ [15:15:24] 16:13:04 Fetching submodule Wikibase [15:15:24] 16:13:07 error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502 Proxy Error [15:15:24] 16:13:07 fatal: The remote end hung up unexpectedly [15:15:43] (03PS10) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [15:16:56] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10User-Ladsgroup, and 3 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10eprodromou) @BPirkle @Eevans Please see above. [15:17:44] Is CI down or what? [15:22:42] 10MediaWiki-Codesniffer: How to handle the nullable operator on multi type lists in code - https://phabricator.wikimedia.org/T250734 (10Daimona) I also prefer the 4th version, and agree with Thiemo above: while not wrong, 1 and 3 are a bit confusing, and 2 looks very redundant. I wonder if there's a standard abo... [15:22:47] https://integration.wikimedia.org/zuul/ looks eerily quiet [15:24:36] Yippee, build fixed! [15:24:37] Project beta-code-update-eqiad build #293263: 09FIXED in 1 min 35 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/293263/ [15:24:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Fresh: Decide how to run a test involving docker inside WMF CI - https://phabricator.wikimedia.org/T250808 (10Krinkle) ` integration-agent-qemu-1001:~$ qemu-system-x86_64 -enable-kvm Could not access KVM kernel module: No such file... [15:24:56] hashar: liw thcipriani James_F Zuul/jenkins are looking rather idle... [15:25:28] Traffic were fiddling earlier and took it down. [15:25:35] Maybe it’s still blocked somehow? [15:25:35] 10Project-Admins: Creating new project - MoeData - https://phabricator.wikimedia.org/T250819 (10Premeditated) [15:26:20] It's only suddenly just stopped [15:27:15] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10Daimona) >>! In T249872#6074387, @daniel wrote: > What @thiemowmde said. I slightly prefer `$a[0]` to `$a[ 0 ]`, but I much prefer `$array[ $this->createKey( $inputValue ) ]` over ` $array[$this... [15:27:31] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): CI / Zuul does not process any events! - https://phabricator.wikimedia.org/T250820 (10hashar) [15:27:51] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10ci-test-error: CI / Zuul does not process any events! - https://phabricator.wikimedia.org/T250820 (10hashar) p:05Triage→03Unbreak! [15:28:28] Gerrit event stream issue? [15:31:20] (03PS4) 10Thcipriani: train-deploy-notes: change pipeline trigger [integration/config] - 10https://gerrit.wikimedia.org/r/589163 [15:31:31] hrm, I see events in the event stream [15:31:55] I see jenkins-bot connected [15:32:02] Right. [15:32:36] hrm, the zuul debug log doesn't look...good [15:34:32] Project beta-code-update-eqiad build #293264: 04FAILURE in 1 min 31 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/293264/ [15:34:51] > WARNING zuul.GerritEventConnector: Received unrecognized event type 'ref-replication-scheduled' from Gerrit. Can not get account information. [15:35:02] That’s normal, isn’t it? [15:35:21] That’s been there since we set up gerrit-replica. [15:35:22] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10ci-test-error: CI / Zuul does not process any events! - https://phabricator.wikimedia.org/T250820 (10hashar) 05Open→03Resolved a:03hashar That is T... [15:35:35] Ha. [15:35:36] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), and 2 others: CI / Zuul not processing changes - https://phabricator.wikimedia.org/T246973 (10hashar) [15:35:38] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10ci-test-error: CI / Zuul does not process any events! - https://phabricator.wikimedia.org/T250820 (10hashar) [15:36:06] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban): CI / Zuul is no more processing events - https://phabricator.wikimedia.org/T220243 (10hashar) I am pretty sure that is the same issue I have debugged a year later: T246973 [15:37:07] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), and 2 others: CI / Zuul not processing changes - https://phabricator.wikimedia.org/T246973 (10hashar) Happened again and restarting Gerrit cause... [15:37:28] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), and 2 others: CI / Zuul not processing changes - https://phabricator.wikimedia.org/T246973 (10hashar) [15:37:38] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), and 2 others: CI / Zuul not processing changes - https://phabricator.wikimedia.org/T246973 (10hashar) 05Declined→03Open [15:38:14] 10Project-Admins: Creating new project - MoeData - https://phabricator.wikimedia.org/T250819 (10Aklapper) This should be a subproject under https://phabricator.wikimedia.org/tag/vps-projects/ [15:41:24] 10Release-Engineering-Team, 10Patch-For-Review, 10ci-test-error: Upgrade ruby version for CI tests - https://phabricator.wikimedia.org/T250538 (10hashar) * https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/591358/ should be merged ASAP, it reverts the faulty change * https://gerrit.wikimedia.org/r/#/c... [15:42:32] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/589163 (owner: 10Thcipriani) [15:44:22] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [15:44:32] Yippee, build fixed! [15:44:33] Project beta-code-update-eqiad build #293265: 09FIXED in 1 min 31 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/293265/ [15:47:44] 10Project-Admins: Creating new project - MoeData - https://phabricator.wikimedia.org/T250819 (10Majavah) >>! In T250819#6075547, @Aklapper wrote: > This should be a subproject under https://phabricator.wikimedia.org/tag/vps-projects/ This is a toolforge tool, so it should be #tools and not under #vps-projects. [15:51:38] 10Project-Admins: Creating new project - MoeData - https://phabricator.wikimedia.org/T250819 (10bd808) 05Open→03Resolved a:03bd808 #tool-moedata [15:53:49] (03PS5) 10Umherirrender: Streamline a few minor details in FunctionComment sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/587201 (owner: 10Thiemo Kreuz (WMDE)) [15:53:52] (03PS6) 10Umherirrender: Streamline a few minor details in FunctionComment sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/587201 (owner: 10Thiemo Kreuz (WMDE)) [15:53:55] (03CR) 10Umherirrender: [C: 03+2] Streamline a few minor details in FunctionComment sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/587201 (owner: 10Thiemo Kreuz (WMDE)) [15:54:38] (03Merged) 10jenkins-bot: Streamline a few minor details in FunctionComment sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/587201 (owner: 10Thiemo Kreuz (WMDE)) [15:56:28] github down [15:57:33] paladox: github up for me [15:57:33] Didn’t work ~15 seconds [15:57:45] not up for me [15:58:04] "This page is taking too long to load." [15:58:06] https://twitter.com/githubstatus/status/1252624524253806593 [15:58:24] Gone again, saw https://www.githubstatus.com/incidents/dsf2qtzh4jpz [15:58:28] Must be intermittent [16:00:10] * RhinosF1 subscribed to incident [16:00:52] 10Phabricator: Create new custom fundraising form - https://phabricator.wikimedia.org/T243961 (10DStrine) 05Open→03Resolved [16:04:37] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10thiemowmde) Oh, indeed. Thanks for pointing that out! I can give it a try. [16:10:12] (03PS6) 10Umherirrender: New error: Expected parameter type before parameter name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) [16:10:42] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) (owner: 10Umherirrender) [16:11:37] 10Diffusion, 10Release-Engineering-Team, 10Projects-Cleanup, 10Wikimedia-GitHub: Delete/Archive Github and Diffusion mirrors of Gerrit repos related wikiba.se - https://phabricator.wikimedia.org/T239429 (10WMDE-leszek) No troubles at all, thanks a lot @MarcoAurelio ! [16:14:44] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10Krinkle) I consider array bracket styling as something that does not benefit from blind consistency. Like deciding whether to put a new line between two lines of code, I believe it is best left... [16:21:34] (03PS7) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [16:28:38] (03PS1) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:28:44] 10phan-taint-check-plugin, 10MobileFrontend, 10Readers-Web-Backlog (Tracking): MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10Jdlrobson) [16:31:52] paladox: github fixed rolled out moments ago [16:32:01] i know [16:35:39] (03PS1) 10Umherirrender: Reduce code duplication in FunctionCommentSniff about punctuation check [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 [16:36:22] (03CR) 10Umherirrender: [C: 04-2] "Second split of is I9ce7f2137da63bad3431079e54d5884fd35e8945" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [16:42:40] (03PS2) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:43:53] (03PS3) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:44:37] (03PS4) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:44:55] (03PS5) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:45:47] (03PS6) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:46:09] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10Umherirrender) Workaround: As in the other task you can use the full qualified class name to make phan and phpcs happy [16:48:33] (03PS7) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:50:20] (03PS8) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:50:45] (03PS9) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:51:35] (03PS10) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:53:02] (03PS11) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:53:08] (03CR) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [16:53:51] (03PS12) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:54:56] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10DannyS712) >>! In T250765#6075938, @Umherirrender wrote: > Workaround: As in the other task you can use the full qualified class name to make phan and phpcs... [16:55:13] (03PS13) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 [16:55:27] 10MediaWiki-Codesniffer, 10User-DannyS712: Remove tabs in function signature - https://phabricator.wikimedia.org/T241520 (10DannyS712) a:03DannyS712 [16:58:06] (03PS1) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [16:58:31] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10Daimona) >>! In T250765#6074936, @DannyS712 wrote: >>>! In T250765#6074362, @thiemowmde wrote: >> Sure. Let's just add it to the UnusedUseStatement sniff! >... [17:00:58] (03PS2) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [17:01:21] (03Abandoned) 10DannyS712: trying tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591373 (owner: 10DannyS712) [17:02:29] (03PS3) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [17:05:27] (03PS7) 10DannyS712: Disallow having both @internal and @since on the same method [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591115 (https://phabricator.wikimedia.org/T229454) [17:10:13] (03CR) 10DannyS712: "> Main test build succeeded." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [17:11:41] 10Project-Admins: Creating new project - MoeData - https://phabricator.wikimedia.org/T250819 (10Aklapper) Hah, thanks. My eyes really misparsed that new URL scheme ending in `toolforge.org`! [17:13:06] 10Project-Admins: Creating new project - MoeData - https://phabricator.wikimedia.org/T250819 (10RhinosF1) >>! In T250819#6076078, @Aklapper wrote: > Hah, thanks. My eyes really misparsed that new URL scheme ending in `toolforge.org`! Looks fancy :) [17:14:56] (03CR) 10DannyS712: [C: 03+1] "LGTM" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 (owner: 10Umherirrender) [17:19:01] (03CR) 10Jforrester: [C: 03+2] Add Echo dependency for PushNotifications [integration/config] - 10https://gerrit.wikimedia.org/r/591355 (owner: 10Mholloway) [17:20:06] (03Merged) 10jenkins-bot: Add Echo dependency for PushNotifications [integration/config] - 10https://gerrit.wikimedia.org/r/591355 (owner: 10Mholloway) [17:20:28] 10MediaWiki-Codesniffer: @coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass) - https://phabricator.wikimedia.org/T230688 (10DannyS712) @Simetrical is this still needed? If so can you provide an example patch that fails but should pass? [17:25:45] 10Phabricator: If a task has #Patch-Needs-Improvement and Gerritbot adds #Patch-For-Review, remove #Patch-Needs-Improvement - https://phabricator.wikimedia.org/T250839 (10Aklapper) p:05Triage→03Low [17:26:11] 10Phabricator: If a task has #Patch-Needs-Improvement and Gerritbot adds #Patch-For-Review, remove #Patch-Needs-Improvement - https://phabricator.wikimedia.org/T250839 (10Aklapper) 05Open→03Resolved ...because both together makes no sense. Implemented in H363 [17:43:19] (03PS1) 10DannyS712: Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 [17:58:09] (03PS2) 10DannyS712: Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 [17:59:16] (03PS3) 10DannyS712: Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 [17:59:19] (03CR) 10jerkins-bot: [V: 04-1] Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 (owner: 10DannyS712) [18:00:06] (03PS4) 10DannyS712: Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 [18:01:10] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to check if all returns of a function are void or non-void returns - https://phabricator.wikimedia.org/T168994 (10DannyS712) a:03DannyS712 @Umherirrender should this autofix to include `void` in the return (`@return int` -> `@return int|void`) or just add... [18:03:19] (03PS5) 10DannyS712: Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 [18:10:30] (03PS4) 10Jeena Huneidi: Portals Build: convert to use docker image [integration/config] - 10https://gerrit.wikimedia.org/r/589724 (https://phabricator.wikimedia.org/T242909) [18:11:30] 10Release-Engineering-Team, 10Community-Tech, 10Wikisource OCR: Improve OCR: Move ws-google-ocr repository to Gerrit - https://phabricator.wikimedia.org/T247284 (10kaldari) [18:12:42] 10Release-Engineering-Team, 10Community-Tech, 10Wikisource OCR: Improve OCR: Move ws-google-ocr repository to Gerrit - https://phabricator.wikimedia.org/T247284 (10kaldari) [18:13:05] (03CR) 10Jforrester: "Oooh, yeah, do stuff with the logs *before* deleting them, that makes sense. ;-)" [integration/config] - 10https://gerrit.wikimedia.org/r/589724 (https://phabricator.wikimedia.org/T242909) (owner: 10Jeena Huneidi) [18:13:44] (03PS5) 10Jforrester: jjb: [wikimedia-portals-build] Convert to use docker image [integration/config] - 10https://gerrit.wikimedia.org/r/589724 (https://phabricator.wikimedia.org/T242909) (owner: 10Jeena Huneidi) [18:14:03] longma: Sorry for the compulsive rename. :-) [18:14:16] (03PS1) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [18:14:43] 10Release-Engineering-Team, 10Community-Tech, 10Wikisource OCR: Improve OCR: Move ws-google-ocr repository to Gerrit - https://phabricator.wikimedia.org/T247284 (10kaldari) @mmodell - To be clear, we need https://phabricator.wikimedia.org/source/tool-wikisource-ocr/ to mirror https://gerrit.wikimedia.org/r/#... [18:26:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I 100% support this sniff. Thanks for working on this! But I think I found a little mistake, or something that was not considered before. " (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [18:29:00] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10thiemowmde) Isn't `$a->b` already 3 tokens? [18:32:31] 10phan-taint-check-plugin, 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10Jdforrester-WMF) Oh, hey, just found this. [18:33:07] James_F: no problem :) [18:34:22] (03PS2) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [18:35:07] 10Release-Engineering-Team, 10Community-Tech, 10Wikisource OCR: Improve OCR: Move ws-google-ocr repository to Gerrit - https://phabricator.wikimedia.org/T247284 (10mmodell) Done [18:35:20] 10Release-Engineering-Team, 10Community-Tech, 10Wikisource OCR: Improve OCR: Move ws-google-ocr repository to Gerrit - https://phabricator.wikimedia.org/T247284 (10mmodell) [18:38:49] (03PS4) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [18:38:54] (03CR) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [18:40:00] (03CR) 10jerkins-bot: [V: 04-1] Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [18:40:56] (03PS3) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [18:41:29] (03PS4) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [18:43:44] (03PS5) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [18:44:00] (03CR) 10jerkins-bot: [V: 04-1] Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [18:49:28] (03CR) 10jerkins-bot: [V: 04-1] Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [18:49:30] (03PS5) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [18:49:58] (03CR) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [18:51:46] (03PS6) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [18:54:14] (03CR) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [18:55:19] (03CR) 10jerkins-bot: [V: 04-1] Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [19:01:04] (03PS6) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [19:03:44] (03PS7) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [19:04:39] (03PS1) 10DannyS712: Add UnaryMinusSpacing sniff to remove spaces after unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) [19:06:14] (03PS2) 10DannyS712: Add UnaryMinusSpacing sniff to remove spaces after unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) [19:06:26] (03Abandoned) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [19:06:58] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: No phpcs rules for space after unary minus operator - https://phabricator.wikimedia.org/T155627 (10DannyS712) a:03DannyS712 [19:10:28] (03CR) 10jerkins-bot: [V: 04-1] Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [19:12:16] 10Continuous-Integration-Config, 10Scoring-platform-team: CI should check to see if our wheels are good - https://phabricator.wikimedia.org/T250746 (10hashar) [19:18:16] Hey folks. I'm looking at this task: CI should check to see if our wheels are good - https://phabricator.wikimedia.org/T250746 [19:18:46] Essentially, I'd like to try installing the wheels and checking for an error. Where should I look for a good way to do this? [19:23:50] (03PS8) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [19:24:26] (03CR) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [19:28:10] 10phan-taint-check-plugin, 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [19:32:56] 10MediaWiki-Codesniffer, 10User-DannyS712: Provide Codesniffer rules to enforce primitive types in lowercase in documentation - https://phabricator.wikimedia.org/T172836 (10DannyS712) a:03DannyS712 [19:33:12] (03PS1) 10DannyS712: FunctionCommentSniff lowercase [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591435 [19:35:48] Has zuul broken again? [19:36:25] oh, no [19:36:27] I turned JS off [19:40:54] Reedy: :-D [19:41:47] (03PS2) 10DannyS712: FunctionCommentSniff lowercase [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591435 [19:42:27] (03PS3) 10DannyS712: FunctionCommentSniff lowercase [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591435 [19:48:51] 10Release-Engineering-Team, 10Community-Tech, 10Wikisource OCR: Improve OCR: Move ws-google-ocr repository to Gerrit - https://phabricator.wikimedia.org/T247284 (10kaldari) 05Open→03Resolved a:03kaldari [19:48:55] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10kaldari) [19:52:19] (03PS4) 10DannyS712: FunctionCommentSniff lowercase [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591435 [19:52:35] (03PS5) 10DannyS712: FunctionCommentSniff lowercase [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591435 [19:53:40] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to check if all returns of a function are void or non-void returns - https://phabricator.wikimedia.org/T168994 (10Umherirrender) I would not add an autofix for this case. It should be looked by a human if there is an error or not. [19:55:26] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Fresh: Decide how to run a test involving docker inside WMF CI - https://phabricator.wikimedia.org/T250808 (10hashar) Note that `integration-agent-qemu-1001.integration.eqiad.wmflabs` does not have `/dev/kvm`. I tried earlier to loa... [19:57:31] (03Abandoned) 10DannyS712: FunctionCommentSniff lowercase [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591435 (owner: 10DannyS712) [19:58:29] (03PS1) 10DannyS712: Expand FunctionCommentSniff to enforce lowercase primitive types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) [19:59:17] (03PS2) 10DannyS712: Expand FunctionCommentSniff to enforce lowercase primitive types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) [20:09:34] (03PS6) 10DannyS712: Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 [20:10:43] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to check if all returns of a function are void or non-void returns - https://phabricator.wikimedia.org/T168994 (10DannyS712) >>! In T168994#6076647, @Umherirrender wrote: > I would not add an autofix for this case. It should be looked by a human if there is... [20:11:23] (03Abandoned) 10DannyS712: Return void [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591399 (owner: 10DannyS712) [20:13:52] (03PS1) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [20:14:35] (03PS2) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [20:20:19] (03CR) 10C. Scott Ananian: "> > Patch Set 3:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/587896 (owner: 10C. Scott Ananian) [20:22:11] 10MediaWiki-Codesniffer: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants redundant "mixed|null" - https://phabricator.wikimedia.org/T218324 (10DannyS712) @Legoktm can this be closed as resolved? [20:30:58] 10MediaWiki-Codesniffer, 10Documentation: Make a contributing.md file or add to README, steps to contribute to Mediawiki Codesniffer - https://phabricator.wikimedia.org/T133478 (10DannyS712) [20:31:57] 10MediaWiki-Codesniffer: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) [20:58:17] 10MediaWiki-Codesniffer: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) Is it enough to report the invalid orders, or does the rule need to fix them as well? I should be able to write a sniff for reporting, but not autofix [21:01:46] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff for disallow spaces between variable expression and array offset - https://phabricator.wikimedia.org/T154103 (10DannyS712) a:03DannyS712 [21:02:15] (03Restored) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [21:02:39] (03PS1) 10Umherirrender: [GroupWhitelist] Run quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/591476 [21:08:52] PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [21:12:29] (03PS7) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [21:13:01] (03PS8) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [21:18:31] 10MediaWiki-Codesniffer: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10Krinkle) I don't think anyone should waste time fixing these by hand. Not worth the effort, so yeah, auto-fix or keep un-enforced without sniff. When auto-fixing keep in mind t... [21:23:13] (03CR) 10jerkins-bot: [V: 04-1] Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [21:24:23] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10Pchelolo) Notalbe patch alert: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/581247 This patch is hard deprecating... [21:25:55] (03PS9) 10DannyS712: Unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [21:28:19] 10MediaWiki-Codesniffer, 10User-DannyS712: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) a:03DannyS712 >>! In T175374#6076926, @Krinkle wrote: > I don't think anyone should waste time fixing these by hand. Not worth the effort, so ye... [21:31:19] (03PS1) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) [21:33:20] (03PS2) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) [21:40:44] PROBLEM - Host deployment-echostore01 is DOWN: CRITICAL - Host Unreachable (172.16.0.170) [21:49:26] RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [21:49:39] (03PS10) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [21:50:06] (03CR) 10Jeena Huneidi: [V: 03+2] Use newer version of mediawiki-dev [releng/local-charts] - 10https://gerrit.wikimedia.org/r/589440 (https://phabricator.wikimedia.org/T246921) (owner: 10Jeena Huneidi) [21:50:29] (03PS11) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [21:53:07] (03PS12) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [21:55:26] (03PS1) 10DannyS712: Use preferred order of tags within codesniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591501 (https://phabricator.wikimedia.org/T175374) [21:58:11] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [22:01:37] PROBLEM - Host deployment-schema-2 is DOWN: CRITICAL - Host Unreachable (172.16.7.161) [22:07:32] (03PS13) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:09:57] (03PS14) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:11:09] (03PS15) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:14:24] (03PS16) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:16:13] (03PS17) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:18:56] (03PS18) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:20:17] (03PS19) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:20:29] (03PS20) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:21:40] RECOVERY - Host deployment-schema-2 is UP: PING OK - Packet loss = 0%, RTA = 0.68 ms [22:21:55] (03PS21) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:24:19] (03PS2) 10DannyS712: Use preferred order of tags within codesniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591501 (https://phabricator.wikimedia.org/T175374) [22:25:45] (03PS22) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [22:27:00] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) >>! In T175374#6077046, @gerritbot wrote: > Change 591501 had a related patch set uploaded (by DannyS712; owner: DannyS712):... [22:29:41] (03CR) 10jerkins-bot: [V: 04-1] Use preferred order of tags within codesniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591501 (https://phabricator.wikimedia.org/T175374) (owner: 10DannyS712) [22:30:45] RECOVERY - Host deployment-echostore01 is UP: PING OK - Packet loss = 0%, RTA = 0.61 ms [22:31:04] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [22:37:01] (03PS3) 10DannyS712: Use preferred order of tags within codesniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591501 (https://phabricator.wikimedia.org/T175374) [22:42:32] heh, gerrit now supports "Display name" [22:42:46] "REVIEW MY CODE" [22:42:59] lol [22:46:16] Reedy some how on chromium-review theirs are their status (probably because it was populated wrong according to a bug report for googlesource) [22:48:42] I was wondering why file uploads were broken on mobiles... turns out Polymer cancels synthetic click events (workaround for old mobile browsers). Luckily i found an app linked to a bug report where i found setCancelSyntheticClickEvents :P [22:51:37] (03PS1) 10Mstyles: jjb: migrate wdqs job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/591522 (https://phabricator.wikimedia.org/T247123) [22:53:00] (03CR) 10jerkins-bot: [V: 04-1] jjb: migrate wdqs job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/591522 (https://phabricator.wikimedia.org/T247123) (owner: 10Mstyles) [23:12:59] (03CR) 10Mstyles: "Not sure what this failure indicates. I got it on my local machine, but couldn't tell from the logs. Temporarily disabling gpg key signing" [integration/config] - 10https://gerrit.wikimedia.org/r/591522 (https://phabricator.wikimedia.org/T247123) (owner: 10Mstyles) [23:17:19] (03PS1) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [23:18:36] (03CR) 10jerkins-bot: [V: 04-1] node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:22:59] (03PS2) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [23:23:43] (03CR) 10Jeena Huneidi: "This might need some rethinking if we are building images with an npm version < 6" [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:24:29] (03CR) 10jerkins-bot: [V: 04-1] node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:31:19] (03PS3) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [23:38:25] 10Continuous-Integration-Infrastructure, 10Product-Infrastructure-Team-Backlog, 10Push-Notification-Service: mwext-phpunit-coverage-patch-docker CI job is failing - https://phabricator.wikimedia.org/T250868 (10Reedy) >16:56:09 The "tests/phpunit" directory does not exist. It seems fairly obvious looking...