[00:08:03] twentyafterfour: did we drop support for raw downloads ? https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.less/mediawiki.mixins.less?view=raw [00:08:23] it's breaking Vector's CI which was dependent on it [00:12:58] ok tbc Monday :) [00:21:18] 10Phabricator, 10Release-Engineering-Team, 10Vector: Phabricator upgrade broke Vector CI - https://phabricator.wikimedia.org/T250881 (10Jdlrobson) [00:22:13] 10Phabricator, 10Release-Engineering-Team, 10Vector: Phabricator upgrade broke Vector CI - https://phabricator.wikimedia.org/T250881 (10Jdlrobson) p:05Triage→03Unbreak! I'm guessing blocking patches to our main skin might be UBN worthy and block any SWAT deploys so I wanted to make sure those impacted we... [00:23:13] 10Phabricator, 10Release-Engineering-Team, 10Vector: Phabricator upgrade broke Vector CI - cannot access RAW text - https://phabricator.wikimedia.org/T250881 (10Jdlrobson) [01:03:27] (03CR) 10DannyS712: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [01:12:24] (03PS1) 10Reedy: Bump composer/semver from 1.5.1 to 2.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591570 [01:39:36] (03PS4) 10DannyS712: Use preferred order of tags within codesniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591501 (https://phabricator.wikimedia.org/T175374) [01:48:05] 10Phabricator, 10Release-Engineering-Team, 10Vector: Phabricator upgrade broke Vector CI - cannot access RAW text - https://phabricator.wikimedia.org/T250881 (10Reedy) Use gerrit? Considering Phab is not canonical either, and we develop against gerrit? https://gerrit.wikimedia.org/r/plugins/gitiles/mediawik... [02:37:14] PROBLEM - Free space - all mounts on deployment-deploy02 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy02.diskspace._srv.byte_percentfree (<11.11%) [02:37:53] (03CR) 10DannyS712: "Recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [02:42:17] RECOVERY - Free space - all mounts on deployment-deploy02 is OK: OK: All targets OK [02:53:46] (03Restored) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 (owner: 10DannyS712) [02:53:51] (03PS3) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [02:55:59] (03PS4) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [02:59:41] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 (owner: 10DannyS712) [03:02:15] (03PS5) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [03:03:31] (03PS6) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [03:04:41] (03PS7) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [03:07:23] (03PS8) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 [03:08:39] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10DannyS712) >>! In T250765#6076001, @Daimona wrote: >>>! In T250765#6074936, @DannyS712 wrote: >>>>! In T250765#6074362, @thiemowmde wrote: >>> Sure. Let's j... [03:09:31] (03PS1) 10DannyS712: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) [03:09:40] (03Abandoned) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591235 (owner: 10DannyS712) [03:11:05] (03PS2) 10DannyS712: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) [03:13:06] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10DannyS712) a:03DannyS712 [03:16:36] (03CR) 10DannyS712: "> LGTM, not familiar with the code but the test cases show that it" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE)) [03:20:00] (03CR) 10DannyS712: Report particularly confusing assertNotEquals( false ) (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE)) [03:25:36] (03Restored) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 (owner: 10DannyS712) [03:27:05] (03PS17) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:27:54] (03PS18) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:27:59] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 (owner: 10DannyS712) [03:29:27] (03PS19) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:32:39] (03PS20) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:37:58] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 (owner: 10DannyS712) [03:43:42] (03PS21) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:44:45] (03PS22) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:45:37] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 (owner: 10DannyS712) [03:45:52] (03PS23) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:50:47] (03PS24) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:51:07] (03PS25) 10DannyS712: MediaWiki.Files.LineEndings [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 [03:53:55] 10MediaWiki-Codesniffer, 10phan: PHPCS: Allow long lines for phan annotations - https://phabricator.wikimedia.org/T231922 (10DannyS712) @Daimona @Krinkle so I figured out a way to do this, but I'm not sure its the best: * Disable `Generic.Files.LineLength` in MediaWiki`s ruleset * Create a copy of it at `Media... [04:09:06] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Testing: Add PHPCS sniff to encourage assertSame() when comparing to literal values - https://phabricator.wikimedia.org/T233420 (10DannyS712) >>! In T233420#5515319, @thiemowmde wrote: > Please note: Even if `assertEquals()` relies on the magic type casting behavior of... [04:10:28] (03Restored) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [04:11:58] (03PS20) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [04:13:17] (03PS21) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [04:15:50] (03PS22) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [04:17:40] (03PS23) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [04:18:22] (03PS24) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [04:22:20] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [04:58:41] (03PS25) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:00:56] (03PS26) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:01:56] (03PS27) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:02:55] (03PS28) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:04:02] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [05:05:00] (03PS29) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:06:32] (03PS30) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:06:52] (03PS31) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:11:58] (03CR) 10jerkins-bot: [V: 04-1] Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [05:17:11] (03PS32) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 [05:19:48] (03Abandoned) 10DannyS712: Trying [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591147 (owner: 10DannyS712) [05:20:04] 10Phabricator, 10Release-Engineering-Team, 10Vector, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): Phabricator upgrade broke Vector CI - cannot access RAW text - https://phabricator.wikimedia.org/T250881 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson Thanks. Hadn't thought to use base64 on the raw asse... [08:16:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] FunctionCommentSniff: warn if returning void when not expected (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [08:23:16] (03CR) 10Thiemo Kreuz (WMDE): "I welcome the idea and the fact that it's a nice and trivial auto-fix. But I do have a serious problem with this class. It's almost 800 li" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [08:24:14] (03PS3) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [08:24:26] (03CR) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [08:26:50] (03PS3) 10DannyS712: Expand FunctionCommentSniff to enforce lowercase primitive types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) [08:26:55] (03CR) 10DannyS712: Expand FunctionCommentSniff to enforce lowercase primitive types (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [08:27:57] (03CR) 10DannyS712: ">" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [08:28:39] (03CR) 10Thiemo Kreuz (WMDE): "Yup, nice! The only concern I have is about the performance of this sniff, which unfortunately is the slowest we have." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:30:40] (03CR) 10DannyS712: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:40:54] (03PS3) 10Thiemo Kreuz (WMDE): Report particularly confusing assertNotEquals( false ) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 [08:41:30] (03CR) 10Thiemo Kreuz (WMDE): Report particularly confusing assertNotEquals( false ) (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE)) [08:46:15] (03CR) 10jerkins-bot: [V: 04-1] Report particularly confusing assertNotEquals( false ) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE)) [08:46:24] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "No reasoning is given, neither here in the commit message nor in the Phabricator ticket." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591115 (https://phabricator.wikimedia.org/T229454) (owner: 10DannyS712) [08:55:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I agree with the idea. Also it does look like there are zero of these errors in the test run. Which is great news. I still have a minor is" (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) (owner: 10DannyS712) [09:04:02] (03CR) 10Daimona Eaytoy: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [09:06:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Add WhiteSpaceBeforeFunction sniff for whitespace in function signature (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [09:30:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I agree with the idea. But there are sooo many edge cases. This needs many more test cases." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [09:43:47] (03CR) 10Thiemo Kreuz (WMDE): UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [09:55:51] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Testing: Add PHPCS sniff to encourage assertSame() when comparing to literal values - https://phabricator.wikimedia.org/T233420 (10thiemowmde) Uh, no. I think we can close this ticket as resolved because the PHPUnitAssertEqualsSniff exists already. As far as I can tell... [10:05:47] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10thiemowmde) I strongly veto this idea. What is the benefit? What is the issue with `@see` and `@todo` being in this order, as shown [he... [10:07:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Use preferred order of tags within codesniffer (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591501 (https://phabricator.wikimedia.org/T175374) (owner: 10DannyS712) [10:21:13] (03PS4) 10Thiemo Kreuz (WMDE): Report particularly confusing assertNotEquals( false ) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 [10:57:47] 10Project-Admins, 10Striker, 10User-Majavah: Allow self-service creation of Maniphest projects for Tools - https://phabricator.wikimedia.org/T144111 (10Majavah) a:03Majavah [11:17:13] 10Phabricator: Request: Add task subtype as a form field to facilitate its use in forms and URLs - https://phabricator.wikimedia.org/T217785 (10Aklapper) > so customizing existing forms via dropdown per use case would still be handy. :) @MBinder_WMF I'm afraid I'm lost what that means... If people want a form wh... [11:33:04] 10Continuous-Integration-Config, 10Fresh, 10Patch-For-Review: Move Fresh to Gerrit (mirror to GitHub) - https://phabricator.wikimedia.org/T250766 (10Aklapper) > Update docs. https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Docker_development_environment links to https://www.mediawiki.org/wiki... [11:48:38] (03PS1) 10Awight: Host and port are mandatory for DevWebServer [integration/quibble] - 10https://gerrit.wikimedia.org/r/591822 [11:57:44] (03PS2) 10Awight: Flag for "none" webserver [integration/quibble] - 10https://gerrit.wikimedia.org/r/590651 (https://phabricator.wikimedia.org/T225218) [11:57:46] (03PS1) 10Awight: Configurable web host and port [integration/quibble] - 10https://gerrit.wikimedia.org/r/591826 [12:02:45] 10Continuous-Integration-Config, 10Fresh, 10Patch-For-Review: Move Fresh to Gerrit (mirror to GitHub) - https://phabricator.wikimedia.org/T250766 (10kostajh) Core’s DEVELOPERS.md links to Fresh on GitHub, so that is at least one place. [13:10:42] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:55:52] U, [13:55:53] Um [13:55:58] Why can random users archive projects? [13:56:00] https://phabricator.wikimedia.org/p/SOlyoh21/ [13:59:03] Strange [14:05:01] I’ve used that right to archive sprint boards before, fwiw [14:08:24] Sure [14:08:35] But you're not a user that just signed up etc :P [14:09:32] That right might be best moved to Trusted Contributors at least [14:10:17] I don't know how granular the phab rights actually are [14:10:17] should someone not block on mw.org / lock so they can’t come back as well [14:10:28] Hmm, good point [14:10:38] I've filed a security task anyway (WP:BEANS) about it [14:10:57] The account should just be locked completely [14:16:21] Reedy: good idea [14:16:44] * RhinosF1 goes to find a stew [14:18:33] Reedy: done by Urbanecm [14:19:48] * Lucas_WMDE is not sure if he’s a Trusted Contributor ^^ [14:20:00] ok, looks like I am :) [14:20:43] i’d hope so [15:39:36] 10Phabricator, 10Release-Engineering-Team, 10Vector, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): Phabricator upgrade broke Vector CI - cannot access RAW text - https://phabricator.wikimedia.org/T250881 (10Reedy) a:05Jdlrobson→03Reedy [16:54:53] (03CR) 10Jforrester: "Can we make this 1.5.1|2.0.0 so that we can upgrade, please? Otherwise no repo will be able to update MWCS until we've force-upgraded the " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591570 (owner: 10Reedy) [17:13:34] (03PS2) 10Reedy: Allow composer/semver version 2.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591570 [17:50:24] (03CR) 10Umherirrender: "It is a long sniff, but it belongs all together." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [17:53:20] 10Continuous-Integration-Config, 10Fresh, 10Patch-For-Review: Move Fresh to Gerrit (mirror to GitHub) - https://phabricator.wikimedia.org/T250766 (10Krinkle) >>! In T250766#6078138, @Aklapper wrote: >> Update docs. > > […] I'm curious which //existing// pages are supposed to be updated. I wasn't actually t... [17:53:26] 10Continuous-Integration-Config, 10Fresh, 10Patch-For-Review: Move Fresh to Gerrit (mirror to GitHub) - https://phabricator.wikimedia.org/T250766 (10Krinkle) 05Open→03Stalled [17:57:41] (03CR) 10Umherirrender: "I see no benefit for the order of @see or @todo" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591501 (https://phabricator.wikimedia.org/T175374) (owner: 10DannyS712) [18:10:52] (03CR) 10Umherirrender: "Maybe a upstream bug to improve the upstream sniff could be created. But I have no idea how to handle all situation with - at the best." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [18:23:11] (03CR) 10Umherirrender: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [18:33:34] (03CR) 10Umherirrender: "I have not looked at the code but it is technically possible to extend upstream sniffs and may skip some part and in other calling the par" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591119 (owner: 10DannyS712) [19:39:45] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [20:29:32] (03CR) 10Daimona Eaytoy: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [21:55:30] (03CR) 10DannyS712: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [21:57:08] (03CR) 10DannyS712: Add UnaryMinusSpacing sniff to remove spaces after unary minus (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [21:59:48] (03PS3) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) [21:59:57] (03CR) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) (owner: 10DannyS712) [23:08:16] (03CR) 10Daimona Eaytoy: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712)