[01:19:45] Project beta-scap-eqiad build #297474: 04FAILURE in 5 min 14 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/297474/ [01:28:47] Yippee, build fixed! [01:28:47] Project beta-scap-eqiad build #297475: 09FIXED in 4 min 14 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/297475/ [02:46:23] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [02:46:34] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [07:57:51] (03PS3) 10DannyS712: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) [07:58:05] (03CR) 10DannyS712: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:08:25] (03CR) 10Daimona Eaytoy: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:13:54] (03CR) 10DannyS712: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:21:03] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "> there could be whitespace […] between string and semicolon." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:33:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Thanks for the update!" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) (owner: 10DannyS712) [08:36:06] 10Phabricator, 10Release-Engineering-Team, 10Vector, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): Phabricator upgrade broke Vector CI - cannot access RAW text - https://phabricator.wikimedia.org/T250881 (10Edd0408) [08:39:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I think this sniff is fine (if the list of tokens is expanded as suggested before). I also think it's fine to have it here. If it turns ou" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [08:41:31] (03PS4) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) [08:41:38] (03CR) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) (owner: 10DannyS712) [08:47:24] 10Phabricator, 10Release-Engineering-Team, 10Vector, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): Phabricator upgrade broke Vector CI - cannot access RAW text - https://phabricator.wikimedia.org/T250881 (10Billinghurst) @Edd0408 These edits do not seem to be useful or correct, can I suggest that you desist... [08:49:25] (03PS3) 10DannyS712: Add UnaryMinusSpacing sniff to remove spaces after unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) [08:49:28] (03CR) 10DannyS712: Add UnaryMinusSpacing sniff to remove spaces after unary minus (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [08:49:47] 10Phabricator, 10Release-Engineering-Team, 10Vector, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): Phabricator upgrade broke Vector CI - cannot access RAW text - https://phabricator.wikimedia.org/T250881 (10Aklapper) [08:49:51] (03CR) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) (owner: 10DannyS712) [08:59:10] 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10DannyS712) Since there is no proper logging for adding users to #acl_userdisable either, note: I've added @Billinghurst, can be trusted with this, and would have been helpful for them t... [09:00:13] (03CR) 10Thiemo Kreuz (WMDE): "The tests prove this addition does what it should do. I won't block changes to this class that are sufficiently covered by tests. But my i" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [09:24:49] o/ hoo :P [09:25:26] hoo and I will be backporting a maintenance script today (to delete some db rows), and if noone objects we will do that in a few hours! [09:31:57] (03PS4) 10DannyS712: Expand FunctionCommentSniff to enforce lowercase primitive types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) [09:32:01] (03CR) 10DannyS712: Expand FunctionCommentSniff to enforce lowercase primitive types (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [09:32:31] (03CR) 10DannyS712: ">" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [09:49:18] 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10Aklapper) There is, see https://phabricator.wikimedia.org/tag/acl_userdisable/ :) [10:04:29] addshore: I thought they were no deploys Tuesday-Sunday this week [10:04:40] * RhinosF1 looks confusingly at the calendar [10:13:33] 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10DannyS712) >>! In T200856#6079253, @Aklapper wrote: > There is, see https://phabricator.wikimedia.org/project/manage/3442/ :) I mean with log comments [10:20:52] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [10:21:13] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [10:21:56] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [10:37:24] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I think I reviewed a patch very similar to this one already. I think I did: Id76e73d." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 (owner: 10Umherirrender) [10:43:31] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper) [10:53:26] (03CR) 10Umherirrender: "Yes, you have reviewed a similar patch set, but there was a comment that is is a big chance and hard to follow removed and added code." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 (owner: 10Umherirrender) [10:57:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "At this point we are not enforcing type hints anywhere. I think it's beneficial to start using them whenever we can. But this is really ju" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 (owner: 10Umherirrender) [10:58:33] 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10Aklapper) My link shows log comments. Or maybe I have no idea what "log comments" are. Or who needs them and why. [10:59:34] 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10RhinosF1) >>! In T200856#6079372, @Aklapper wrote: > My link shows log comments. Or maybe I have no idea what "log comments" are. A reason for the change? >Or who needs them and why. ? [11:01:41] 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10Aklapper) >>! In T200856#6079374, @RhinosF1 wrote: > A reason for the change? Personally I don't care about reasons. I trust people who can disable accounts that they have their reasons. [11:02:52] 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10RhinosF1) >>! In T200856#6079379, @Aklapper wrote: >>>! In T200856#6079374, @RhinosF1 wrote: >> A reason for the change? > Personally I don't care about reasons. I trust people who can... [11:05:44] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 92758 bytes in 0.956 second response time [11:06:06] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 52124 bytes in 0.948 second response time [11:06:47] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 92453 bytes in 0.982 second response time [12:52:23] RhinosF1: indeed, although this is not hot code path etc, as it is just a maintenance script etc [12:52:34] Ah [16:46:53] (03PS1) 10Umherirrender: Move fix of typo annotations to FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592277 [16:52:01] 10Phabricator (Upstream), 10Upstream: Swap phabricator's default fields for "Tags" and "Assigned to" within the create task form - https://phabricator.wikimedia.org/T128482 (10mmodell) 05Open→03Resolved a:03mmodell Since it's configurable from the UI, I don't think the default is critically important.... [16:52:46] it took a while but we will sync the maint script soon! [17:22:26] 10Phabricator: Swap phabricator's default fields for "Tags" and "Assigned to" within the create task form - https://phabricator.wikimedia.org/T128482 (10Aklapper) It never came to my mind that this is configurable, but right, you can change the order of items in the forms. Heh. Thanks @mmodell! [17:41:16] (03PS2) 10Umherirrender: Reduce code duplication in FunctionCommentSniff about punctation check [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 [18:40:07] (03PS6) 10Umherirrender: Reduce code duplication in FunctionCommentSniff about parenthesis check [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 [18:42:33] 10MediaWiki-Codesniffer, 10User-DannyS712: Split up FunctionCommentSniff - https://phabricator.wikimedia.org/T250958 (10DannyS712) [18:42:53] 10MediaWiki-Codesniffer, 10User-DannyS712: Split up FunctionCommentSniff - https://phabricator.wikimedia.org/T250958 (10DannyS712) p:05Triage→03Medium CC @thiemowmde [18:43:32] (03CR) 10Umherirrender: "Rebased on top of the both splites to show the rest of the patch set to be done." (037 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585969 (owner: 10Umherirrender) [18:47:17] (03PS1) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) [18:51:56] (03PS2) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) [18:51:58] 10Diffusion, 10Release-Engineering-Team, 10Projects-Cleanup, 10Wikimedia-GitHub: Delete/Archive Github and Diffusion mirrors of Gerrit repos related wikiba.se - https://phabricator.wikimedia.org/T239429 (10MarcoAurelio) Thanks for the reply. I'll see if I can find some spare time to do it. [18:53:02] (03CR) 10DannyS712: "> >" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) (owner: 10DannyS712) [18:56:49] (03CR) 10jerkins-bot: [V: 04-1] Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [18:57:48] (03PS3) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) [18:58:17] (03PS7) 10Umherirrender: New error: Expected parameter type before parameter name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) [19:00:09] (03CR) 10Umherirrender: "Rebased on another parent" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) (owner: 10Umherirrender) [19:01:56] (03CR) 10jerkins-bot: [V: 04-1] Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [19:02:11] (03PS4) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) [19:02:26] (03PS5) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) [19:22:23] (03PS3) 10Umherirrender: New error: Param name should not be wrapped in parenthesis [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) [19:22:49] (03CR) 10Umherirrender: "Rebased and improved the regex format/comment" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) (owner: 10Umherirrender) [20:23:57] (03PS1) 10Umherirrender: build: Add mediawiki/mediawiki-phan-config [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 [20:24:29] (03PS2) 10Umherirrender: build: Add mediawiki/mediawiki-phan-config [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 [20:30:23] Urbanecm: This is starting to feel rather.. meta :) [20:36:26] Reedy: ? [20:36:41] Urbanecm: running phan on codesniffer repo, running codensiffer on the phan repo [20:37:25] We need to test everything :P [20:37:43] (through I'm not the author of that patch if you think I am ;) [20:42:02] Reedy: while we're here...could you help me what am I doing wrong at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/592287 https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php72-docker/19370/console keeps saying `BlockValidatorTest::testValidTarget: Trying to @cover or @use not existing method "BlockValidator::validateTarget".`... The cover tag is the same. [20:42:51] Urbanecm: Covers need to be fully qualified [20:42:54] For reasons I don't quite understand [20:43:07] MediaWiki\Block\BlockValidator [20:43:20] Reedy: aha, but why does it fail just for one of the tests? [20:43:31] Hit the first error and give up? [20:46:50] hmm good point [20:47:12] I've been bitten by the same cycle of the same issues :D [20:47:28] :D [20:47:30] thanks Reedy [20:47:52] It might be worth filing an issue (if we don't have one) about the @covers [20:48:11] I don't quite see why it can't use the use statements [20:48:18] Or whether it's done for speed [20:57:28] [13:48:12] I don't quite see why it can't use the use statements <-- because PHPUnit, there's a declined bug about it somewhere [20:57:38] Seriously? [20:57:44] 'nuff said [21:02:16] I can't find it, but I'm sure I read it somewhere [21:02:18] 10Continuous-Integration-Config, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [21:04:08] legoktm: It doesn't surprise me [21:05:06] I also think they would have had to develop a parser for use statements like we did in PHPCS [21:06:47] Maybe so [21:06:59] I'm pretty sure they're more than capale [21:07:50] https://github.com/sebastianbergmann/phpunit/pull/1312 [21:08:05] *capable [21:08:08] https://github.com/sebastianbergmann/phpunit/issues/730 [21:08:52] And that, ladies and gentleman is why we don't just mass close issues [21:08:54] >If the topic of this ticket is still relevant then please open a new ticket or send a new pull request. [21:08:59] * Reedy barfs a little [21:09:24] Hmm. So it's not a no, just a "I'm not doing this" [21:11:54] Yeah, looks like someone needs to resurrect that PR [21:13:17] Or start again [21:13:26] The library it tries to use hasn't been touched in 7 years [21:13:27] https://github.com/eloquent/cosmos [21:23:37] https://phabricator.wikimedia.org/T250966 [21:24:42] (03CR) 10Daimona Eaytoy: ">" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [21:46:40] misread that as eloquence's library [21:54:05] heh [21:55:38] Can we librarise ours and share it? [22:22:28] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: wmde / WikibaseCodeSniffer tests fail on master - https://phabricator.wikimedia.org/T250973 (10Addshore)