[02:25:08] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Testing: Add PHPCS sniff to encourage assertSame() when comparing to literal values - https://phabricator.wikimedia.org/T233420 (10DannyS712) 05Open→03Resolved Closing as resolved per above [02:27:21] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), 10MW-1.35-release, and 2 others: Fix all functions that have required parameters following optional ones - https://phabricator.wikimedia.org/T248078 (10DannyS712) >>! In T248078#5987737, @gerritbot wrote: > Change 58... [02:39:51] (03PS23) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [02:42:29] 10MediaWiki-Codesniffer: PHPCS: The UnrecognizedAnnotation sniff should ignore code block - https://phabricator.wikimedia.org/T241091 (10DannyS712) @Umherirrender @Krinkle if a fix is desired for the UnrecognizedAnnotation sniff (as opposed to just disabling it) its pretty easy. SpacingDocTag should be easy too;... [02:43:56] 10MediaWiki-Codesniffer, 10Code-Health, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22): Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10DannyS712) >>! In T234118#5911040, @thiemowmde wrote: >> UserRetr... [02:44:45] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [03:04:20] (03PS24) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:05:23] (03PS25) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:05:58] (03PS26) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:07:43] (03PS27) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:08:29] (03PS28) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:14:14] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [03:14:25] (03PS29) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:15:38] (03PS30) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:17:18] (03PS31) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:17:52] (03PS32) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:18:26] (03PS33) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:23:16] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [03:23:37] 10MediaWiki-Codesniffer: Add sniff to require trailing commas in multiline arrays - https://phabricator.wikimedia.org/T222042 (10DannyS712) >>! In T222042#5142935, @thiemowmde wrote: > This is one of these cases where I wonder if the effort is worth it. How often do we run into a situation where we think "dang,... [03:26:50] (03PS34) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:28:11] (03PS35) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:32:55] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [03:36:44] (03PS36) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [03:41:00] (03CR) 10jerkins-bot: [V: 04-1] Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 (owner: 10DannyS712) [05:37:29] 10MediaWiki-Codesniffer: Add sniff to require trailing commas in multiline arrays - https://phabricator.wikimedia.org/T222042 (10thiemowmde) No, as argued [a little lower](https://phabricator.wikimedia.org/T222042#5155779). There are reasons to not have a dangling comma in multi-line arrays. It should be a human... [05:43:16] 10MediaWiki-Codesniffer: Add sniff to require trailing commas in multiline arrays - https://phabricator.wikimedia.org/T222042 (10DannyS712) 05Open→03Declined Oh well, I wrote the sniff, but I guess its not needed - declining per discussion above [05:48:14] (03PS37) 10DannyS712: Testing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591409 [05:51:35] (03CR) 10DannyS712: [C: 03+1] "LGTM, 1 suggestion" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [06:26:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "> Strpos is a fairly simple function […]" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [06:47:19] (03PS1) 10Thiemo Kreuz (WMDE): Fix minor performance issue in UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592393 [06:51:39] (03CR) 10jerkins-bot: [V: 04-1] Fix minor performance issue in UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592393 (owner: 10Thiemo Kreuz (WMDE)) [07:01:43] 10Beta-Cluster-Infrastructure: Login to some beta wikis fail with "There seems to be a problem with your login session" - https://phabricator.wikimedia.org/T250986 (10dom_walden) [07:05:15] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] New error: Param name should not be wrapped in parenthesis (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) (owner: 10Umherirrender) [07:10:35] (03CR) 10Thiemo Kreuz (WMDE): "Uh, wow! If that's not an obvious thing to extract, I don't know." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [07:15:59] (03PS6) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) [07:16:03] (03CR) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [07:16:33] (03CR) 10DannyS712: ">" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [07:25:40] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] New error: Expected parameter type before parameter name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585962 (https://phabricator.wikimedia.org/T141412) (owner: 10Umherirrender) [09:14:57] 10Project-Admins: Cleaning up #Mediawiki-extensions-other - https://phabricator.wikimedia.org/T213880 (10Aklapper) I'm proposing to close this task, as I am not aware of any clear criteria when to define this task as "resolved" and as tasks should not be neverending. [09:14:59] 10Project-Admins, 10User-DannyS712: Cleaning up #mediawiki-general - https://phabricator.wikimedia.org/T249999 (10Aklapper) I'm proposing to close this task, as I am not aware of any clear criteria when to define this task as "resolved" and as tasks should not be neverending. [10:59:56] Project beta-scap-eqiad build #297676: 04FAILURE in 5 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/297676/ [11:08:38] Yippee, build fixed! [11:08:39] Project beta-scap-eqiad build #297677: 09FIXED in 4 min 5 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/297677/ [12:11:22] PROBLEM - Free space - all mounts on deployment-changeprop is CRITICAL: (Service Check Timed Out) [12:16:11] RECOVERY - Free space - all mounts on deployment-changeprop is OK: OK: All targets OK [13:10:41] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [14:01:12] PROBLEM - Free space - all mounts on integration-agent-pkgbuilder-1001 is CRITICAL: (Service Check Timed Out) [14:06:03] RECOVERY - Free space - all mounts on integration-agent-pkgbuilder-1001 is OK: OK: All targets OK [14:35:29] (03PS4) 10Umherirrender: New error: Param name should not be wrapped in parenthesis [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) [14:35:55] (03CR) 10Umherirrender: New error: Param name should not be wrapped in parenthesis (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) (owner: 10Umherirrender) [14:55:36] 10Project-Admins: Cleaning up #Mediawiki-extensions-other - https://phabricator.wikimedia.org/T213880 (10MGChecker) This task would be done when every extension has its own project and #MediaWiki-extensions-other is archived. [15:28:24] 10Project-Admins: Cleaning up #Mediawiki-extensions-other - https://phabricator.wikimedia.org/T213880 (10Aklapper) p:05Triage→03Low Okay, that makes no sense to me as long as there is no process to make any and every extension maintainer out there have an issue tracker defined on their extension homepage. :) [15:41:31] (03PS1) 10Thiemo Kreuz (WMDE): [WIP] Full rewrite of the UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 [15:46:19] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Full rewrite of the UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [15:48:10] (03PS2) 10Thiemo Kreuz (WMDE): [WIP] Full rewrite of the UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 [15:52:44] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Full rewrite of the UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [17:56:28] (03PS3) 10Thiemo Kreuz (WMDE): Full rewrite of the UnusedUseStatementSniff, 4x faster [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 [17:59:01] (03PS1) 10Thiemo Kreuz (WMDE): Fix possible index error AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592423 [18:00:18] (03CR) 10jerkins-bot: [V: 04-1] Full rewrite of the UnusedUseStatementSniff, 4x faster [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [18:14:03] (03PS4) 10Thiemo Kreuz (WMDE): Full rewrite of the UnusedUseStatementSniff, 4x faster [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 [18:25:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Currently failing on aliased use statements, e.g. `use Cdb\Exception as CdbException;`. I will fix this." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [18:43:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Uh, nice! Even using spaces to make the pattern more readable. I like it!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/585965 (https://phabricator.wikimedia.org/T198022) (owner: 10Umherirrender) [18:44:14] (03PS2) 10Thiemo Kreuz (WMDE): Fix possible index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592423 [18:44:59] 10Beta-Cluster-Infrastructure: Login to some beta wikis fail with "There seems to be a problem with your login session" - https://phabricator.wikimedia.org/T250986 (10Aklapper) @dom_walden: Also see https://www.mediawiki.org/wiki/Manual:How_to_debug/Login_problems - Thanks! [18:46:18] (03PS5) 10Thiemo Kreuz (WMDE): Full rewrite of the UnusedUseStatementSniff, 4x faster [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 [18:52:58] (03PS6) 10Thiemo Kreuz (WMDE): Full rewrite of the UnusedUseStatementSniff, 4x faster [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 [18:59:05] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Reduce code duplication in FunctionCommentSniff about punctation check (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 (owner: 10Umherirrender) [19:00:02] (03Merged) 10jenkins-bot: Reduce code duplication in FunctionCommentSniff about punctation check [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591374 (owner: 10Umherirrender) [19:03:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I would love to have at least two other opinions, just to properly approve this. As of now nobody else was commenting on T246674. Let's wa" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) (owner: 10DannyS712) [19:09:50] (03PS2) 10Thiemo Kreuz (WMDE): Fix minor performance issue in UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592393 [19:13:14] (03PS7) 10DannyS712: Move `SuperfluousVariadicArgComment` out of the FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592286 (https://phabricator.wikimedia.org/T250958) [19:39:46] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [19:43:59] 10Project-Admins, 10Anti-Harassment, 10User-DannyS712: Create #MediaWiki-Blocks component - https://phabricator.wikimedia.org/T250427 (10Niharika) I am happy with renaming #mediawiki-partial-blocks to #mediawiki-user-blocks and moving the partial blocks tasks to a separate column. Does that sound like a good... [21:50:10] 10Beta-Cluster-Infrastructure: Can't edit on betacommons: "We could not process your edit due to a loss of session data." - https://phabricator.wikimedia.org/T251009 (10AlexisJazz) [21:50:30] 10Beta-Cluster-Infrastructure: Login to some beta wikis fail with "There seems to be a problem with your login session" - https://phabricator.wikimedia.org/T250986 (10AlexisJazz) I'm logged into beta Commons but I can't edit anything: T251009. [21:57:34] (03CR) 10Daimona Eaytoy: [C: 04-1] "> It does not matter if a piece of code needs 1ms or 0.1ms." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [22:19:27] (03PS2) 10Awight: [WIP] Experimenting with external db [integration/quibble] - 10https://gerrit.wikimedia.org/r/591004 [22:28:15] (03CR) 10Awight: "I was able to smoke-test this locally, using an external container for the database under this docker-compose: https://gitlab.com/adamwigh" [integration/quibble] - 10https://gerrit.wikimedia.org/r/591004 (owner: 10Awight)