[00:02:05] (03CR) 10DannyS712: "> [snip]" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [00:04:51] 10Project-Admins, 10Anti-Harassment, 10User-DannyS712: Create #MediaWiki-Blocks component - https://phabricator.wikimedia.org/T250427 (10DannyS712) a:03DannyS712 >>! In T250427#6080878, @Niharika wrote: > I am happy with renaming #mediawiki-partial-blocks to #mediawiki-user-blocks and moving the partial bl... [00:17:22] 10Project-Admins, 10Anti-Harassment, 10User-DannyS712: Create #MediaWiki-Blocks component - https://phabricator.wikimedia.org/T250427 (10DannyS712) So I just went through and created it, and removed #mediawiki-user-management from the tasks in favor of #mediawiki-blocks, but {H361} added it back :( - @Aklapp... [00:29:51] (03CR) 10DannyS712: [C: 03+1] "LGTM" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592423 (owner: 10Thiemo Kreuz (WMDE)) [03:28:04] 10Phabricator: Add Remarkup-capable
/ support - https://phabricator.wikimedia.org/T251014 (10Niedzielski) [03:29:13] 10Phabricator: Add Remarkup-capable
/ support - https://phabricator.wikimedia.org/T251014 (10Niedzielski) [05:18:35] 10Phabricator (Upstream), 10Upstream: Add Remarkup-capable
/ support - https://phabricator.wikimedia.org/T251014 (10Peachey88) @Niedzielski Please propose upstream in their [[ https://discourse.phabricator-community.org/ | discourse ]] instance. Can you provide some context on how you would... [06:06:19] (03PS5) 10DannyS712: Expand FunctionCommentSniff to enforce lowercase primitive types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591443 (https://phabricator.wikimedia.org/T172836) [06:07:13] (03PS4) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [08:19:19] (03CR) 10Daimona Eaytoy: [C: 04-1] "> I'm not sure how to run those tests" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:21:57] (03CR) 10DannyS712: "> > I'm not sure how to run those tests" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [08:58:21] (03CR) 10Daimona Eaytoy: [C: 04-1] "> I don't use phpcs locally, nor do I have it downloaded / set up, so" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [10:03:35] 10Beta-Cluster-Infrastructure: Can't edit on betacommons: "We could not process your edit due to a loss of session data." - https://phabricator.wikimedia.org/T251009 (10Aklapper) @AlexisJazz: Same request: Please see https://www.mediawiki.org/wiki/Manual:How_to_debug/Login_problems - thanks! :) [10:15:05] 10Phabricator (Upstream), 10Upstream: Add Remarkup-capable
/ support for collapsed sections in Markdown - https://phabricator.wikimedia.org/T251014 (10Aklapper) p:05Triage→03Lowest [10:33:18] 10Project-Admins, 10Anti-Harassment, 10User-DannyS712: Create #MediaWiki-Blocks component - https://phabricator.wikimedia.org/T250427 (10Aklapper) Sure, I have disabled H361 now [10:38:20] 10Project-Admins, 10Anti-Harassment, 10User-DannyS712: Create #MediaWiki-Blocks component - https://phabricator.wikimedia.org/T250427 (10DannyS712) >>! In T250427#6081655, @Aklapper wrote: > Sure, I have disabled H361 now If you have the ability to silence notifications on your batch edits, can you do so an... [12:27:55] 10Project-Admins, 10Anti-Harassment, 10User-DannyS712: Create #MediaWiki-Blocks component - https://phabricator.wikimedia.org/T250427 (10Aklapper) @DannyS712: I made a silent mass-edit and removed #mediawiki-user-management from [80 tickets](https://phabricator.wikimedia.org/maniphest/?ids=250059,250020,2494... [12:41:20] 10Project-Admins: Better track Kiwix & openZIM tickets - https://phabricator.wikimedia.org/T238223 (10Kelson) @ArielGlenn Thank you for your interest and your patience. Here it is https://phabricator.wikimedia.org/tag/affects-kiwix-and-openzim/ [15:11:31] 10Phabricator (Upstream), 10Upstream: Add Remarkup-capable
/ support for collapsed sections in Markdown - https://phabricator.wikimedia.org/T251014 (10Niedzielski) @Peachey88, thanks! So, should I close this task? Also, do you know if this is a good use of my time or are most upstream request... [15:18:10] 10Phabricator (Upstream), 10Upstream: Add Remarkup-capable
/ support for collapsed sections in Markdown - https://phabricator.wikimedia.org/T251014 (10Aklapper) > do you know if this is a good use of my time or are most upstream requests denied? @Niedzielski: See https://www.mediawiki.org/wi... [15:22:38] (03PS1) 10Krinkle: doc.wikimedia.org: Remove unused dir.php copies [integration/docroot] - 10https://gerrit.wikimedia.org/r/592451 [15:22:40] (03PS1) 10Krinkle: doc: Update README to advertise port 4000 for local dev [integration/docroot] - 10https://gerrit.wikimedia.org/r/592452 [15:22:53] (03CR) 10Krinkle: [C: 03+2] doc.wikimedia.org: Remove unused dir.php copies [integration/docroot] - 10https://gerrit.wikimedia.org/r/592451 (owner: 10Krinkle) [15:22:59] (03CR) 10Krinkle: [C: 03+2] doc: Update README to advertise port 4000 for local dev [integration/docroot] - 10https://gerrit.wikimedia.org/r/592452 (owner: 10Krinkle) [15:23:35] (03Merged) 10jenkins-bot: doc.wikimedia.org: Remove unused dir.php copies [integration/docroot] - 10https://gerrit.wikimedia.org/r/592451 (owner: 10Krinkle) [15:23:37] (03Merged) 10jenkins-bot: doc: Update README to advertise port 4000 for local dev [integration/docroot] - 10https://gerrit.wikimedia.org/r/592452 (owner: 10Krinkle) [15:55:10] 10Beta-Cluster-Infrastructure: Login to some beta wikis fail with "There seems to be a problem with your login session" - https://phabricator.wikimedia.org/T250986 (10AlexisJazz) @Aklapper I tried logging in with a private window as suggested by your link. I got the same > There seems to be a problem with your l... [15:58:18] 10Beta-Cluster-Infrastructure: Can't edit on betacommons: "We could not process your edit due to a loss of session data." - https://phabricator.wikimedia.org/T251009 (10AlexisJazz) Tried logging in with a private window as your link suggested, ran straight into T250986. I'm guessing the only reason I can get the... [17:11:46] 10phan-taint-check-plugin, 10Patch-For-Review: Improve caused-by lines as seen for GlobalBlocking - https://phabricator.wikimedia.org/T247428 (10Daimona) [[https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/SecurityCheckPlugin/+/592448/ | r592448 ]] helps a bit by removing some rawElement repetitions, bri... [17:33:59] (03PS1) 10Krinkle: shared: Move class loading to autoload.php [integration/docroot] - 10https://gerrit.wikimedia.org/r/592457 [17:34:01] (03PS1) 10Krinkle: shared: Reduce complexity in the Page class [integration/docroot] - 10https://gerrit.wikimedia.org/r/592458 [17:34:03] (03PS1) 10Krinkle: build: Update PHP requirement from 5.5+ to 5.6+ [integration/docroot] - 10https://gerrit.wikimedia.org/r/592459 [17:34:32] (03CR) 10Krinkle: [C: 03+2] shared: Move class loading to autoload.php [integration/docroot] - 10https://gerrit.wikimedia.org/r/592457 (owner: 10Krinkle) [17:35:06] (03Merged) 10jenkins-bot: shared: Move class loading to autoload.php [integration/docroot] - 10https://gerrit.wikimedia.org/r/592457 (owner: 10Krinkle) [17:35:14] (03CR) 10Krinkle: [C: 03+2] shared: Reduce complexity in the Page class [integration/docroot] - 10https://gerrit.wikimedia.org/r/592458 (owner: 10Krinkle) [17:35:38] (03Merged) 10jenkins-bot: shared: Reduce complexity in the Page class [integration/docroot] - 10https://gerrit.wikimedia.org/r/592458 (owner: 10Krinkle) [17:35:45] (03CR) 10Krinkle: build: Update PHP requirement from 5.5+ to 5.6+ (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/592459 (owner: 10Krinkle) [17:35:47] (03CR) 10Krinkle: [C: 03+2] build: Update PHP requirement from 5.5+ to 5.6+ [integration/docroot] - 10https://gerrit.wikimedia.org/r/592459 (owner: 10Krinkle) [17:36:14] (03Merged) 10jenkins-bot: build: Update PHP requirement from 5.5+ to 5.6+ [integration/docroot] - 10https://gerrit.wikimedia.org/r/592459 (owner: 10Krinkle) [17:51:41] 10Beta-Cluster-Infrastructure: Login to some beta wikis fail with "There seems to be a problem with your login session" - https://phabricator.wikimedia.org/T250986 (10Aklapper) @AlexisJazz: I just tried with Firefox 75 and had no problems logging into https://commons.wikimedia.beta.wmflabs.org/ , and had no prob... [18:38:58] 10Beta-Cluster-Infrastructure: Can't edit on betacommons: "We could not process your edit due to a loss of session data." - https://phabricator.wikimedia.org/T251009 (10AlexisJazz) 05Open→03Resolved a:03AlexisJazz It works now, but I have no idea what changed. [18:39:31] 10Beta-Cluster-Infrastructure: Login to some beta wikis fail with "There seems to be a problem with your login session" - https://phabricator.wikimedia.org/T250986 (10AlexisJazz) >>! In T250986#6081975, @Aklapper wrote: > @AlexisJazz: I just tried with Firefox 75 and had no problems logging into https://commons.... [18:52:14] 10Beta-Cluster-Infrastructure: Attribution in the footer on betacommons includes username "imported>Clindberg" - https://phabricator.wikimedia.org/T251028 (10AlexisJazz) [19:06:48] (03PS3) 10Umherirrender: Fix minor performance issue in UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592393 (owner: 10Thiemo Kreuz (WMDE)) [19:06:56] (03CR) 10Umherirrender: [C: 03+2] Fix minor performance issue in UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592393 (owner: 10Thiemo Kreuz (WMDE)) [19:07:34] (03Merged) 10jenkins-bot: Fix minor performance issue in UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592393 (owner: 10Thiemo Kreuz (WMDE)) [19:09:03] (03PS3) 10Umherirrender: Fix possible index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592423 (owner: 10Thiemo Kreuz (WMDE)) [19:09:06] (03CR) 10Umherirrender: [C: 03+2] Fix possible index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592423 (owner: 10Thiemo Kreuz (WMDE)) [19:09:41] (03Merged) 10jenkins-bot: Fix possible index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592423 (owner: 10Thiemo Kreuz (WMDE)) [19:20:15] 10Beta-Cluster-Infrastructure: Attribution in the footer on betacommons includes username "imported>Clindberg" - https://phabricator.wikimedia.org/T251028 (10DannyS712) [19:22:09] (03PS1) 10Umherirrender: Ignore anon classes when looking for return in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592464 [19:26:47] (03CR) 10Umherirrender: build: Add mediawiki/mediawiki-phan-config (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [19:31:37] 10phan-taint-check-plugin: Make taint-check stronger about abnormal syntax by using test files from codesniffer - https://phabricator.wikimedia.org/T251029 (10Umherirrender) [20:05:19] 10phan: Conditional suppress? - https://phabricator.wikimedia.org/T251039 (10Reedy) [20:10:03] (03CR) 10Daimona Eaytoy: build: Add mediawiki/mediawiki-phan-config (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [20:13:50] (03CR) 10Daimona Eaytoy: [C: 04-1] "@Danny do you need any help with testing the performance as described in my last comment?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [20:19:54] 10phan-taint-check-plugin: Make taint-check stronger about abnormal syntax by using test files from codesniffer - https://phabricator.wikimedia.org/T251029 (10Daimona) It seems a wrong assumption about closures, but I cannot figure it out by looking at the file. I'll investigate. And yes, it's probably a good id... [20:24:50] 10phan: Conditional suppress? - https://phabricator.wikimedia.org/T251039 (10Daimona) The best solution I can think of is suppressing the issue conditionally in the config file. That would apply to the whole repo, but I think we can bear it as long as it's for PHP 7.4 only. Alternatively, you may try using @pha... [20:43:41] 10phan: Conditional suppress? - https://phabricator.wikimedia.org/T251039 (10Reedy) 05Open→03Resolved a:03Daimona >>! In T251039#6082334, @Daimona wrote: > Alternatively, you may try using @phan-file-suppress, which IIRC is not checked by the UnusedSuppression plugin. I may be wrong though, so perhaps just... [20:57:41] (03CR) 10Awight: "MysqlExternal.start() should retry the database until it's live." [integration/quibble] - 10https://gerrit.wikimedia.org/r/591004 (owner: 10Awight) [22:08:56] (03CR) 10Umherirrender: Full rewrite of the UnusedUseStatementSniff, 4x faster (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE))