[00:11:15] PROBLEM - Free space - all mounts on deployment-deploy02 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy02.diskspace._srv.byte_percentfree (<11.11%) [00:16:15] RECOVERY - Free space - all mounts on deployment-deploy02 is OK: OK: All targets OK [00:37:52] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10brennen) Signing off for the evening. Train is currently unblocked; I've sent mail to that effect to the usual places. [01:41:04] 10Release-Engineering-Team-TODO, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 3 others: Performance regression from Apcu/ExtensionRegistry::loadFromQueue on PHP7 - https://phabricator.wikimedia.org/T187154 (10Krinkle) [06:36:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Code cleanup: Remove unused variable and fields (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593299 (owner: 10Umherirrender) [06:36:42] (03Merged) 10jenkins-bot: Code cleanup: Remove unused variable and fields [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593299 (owner: 10Umherirrender) [08:28:07] 10Release-Engineering-Team-TODO, 10Packaging, 10Upstream: gbp buildpackage with GIT_PBUILDER_AUTOCONF=no causes DIST to be ignored - https://phabricator.wikimedia.org/T233020 (10JMeybohm) Something in between keeps resetting DIST back to "local version" which creates an inconsistency between DIST and GBP_PBU... [09:45:04] (03CR) 10Hashar: "We would need the mediawiki/core patch to be ported to the supported branches (wmf ones, REL1_31, REL1_33, REL1_34)." [integration/quibble] - 10https://gerrit.wikimedia.org/r/591033 (https://phabricator.wikimedia.org/T248484) (owner: 10Kosta Harlan) [09:54:45] (03CR) 10Hashar: [C: 04-1] "One can pass the command as a string, then it must not have any arguments:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588113 (owner: 10Awight) [10:26:50] PROBLEM - Free space - all mounts on deployment-deploy01 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy01.diskspace._srv.byte_percentfree (<10.00%) [10:36:49] RECOVERY - Free space - all mounts on deployment-deploy01 is OK: OK: All targets OK [10:51:56] (03Abandoned) 10Awight: Simplify shell call syntax [integration/quibble] - 10https://gerrit.wikimedia.org/r/588113 (owner: 10Awight) [11:36:56] 10Beta-Cluster-Infrastructure: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10abi_) [11:46:34] 10Beta-Cluster-Infrastructure: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10abi_) p:05Triage→03High [11:54:06] 10Beta-Cluster-Infrastructure: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10Reedy) [11:54:30] 10Beta-Cluster-Infrastructure, 10Analytics, 10Event-Platform: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10Reedy) [12:38:38] (03PS3) 10Hashar: Override scm url for wikidata/query/rdf [integration/config] - 10https://gerrit.wikimedia.org/r/593300 (https://phabricator.wikimedia.org/T247123) [12:44:17] (03CR) 10Gehel: [C: 03+1] "Looks OK to me, but I haven't actually tested it." [integration/config] - 10https://gerrit.wikimedia.org/r/593300 (https://phabricator.wikimedia.org/T247123) (owner: 10Hashar) [12:57:13] (03CR) 10Hashar: "I have refreshed the job and it now passes:" [integration/config] - 10https://gerrit.wikimedia.org/r/593300 (https://phabricator.wikimedia.org/T247123) (owner: 10Hashar) [13:02:00] hashar: Just because I've been spamming the Quibble repo like crazy, I wanted to highlight the most useful patch of the lot, for review at your convenience: https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/587885/ [13:04:16] (03PS1) 10Hashar: releng to forge identities for mass import of repos [services] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/593500 (https://phabricator.wikimedia.org/T249908) [13:04:26] (03CR) 10Hashar: [V: 03+2 C: 03+2] releng to forge identities for mass import of repos [services] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/593500 (https://phabricator.wikimedia.org/T249908) (owner: 10Hashar) [13:07:12] (03CR) 10Thcipriani: [V: 03+2 C: 03+2] Remove .arcconfig add .gitreview [tools/scap-vagrant] - 10https://gerrit.wikimedia.org/r/593243 (https://phabricator.wikimedia.org/T216483) (owner: 10Hashar) [13:10:23] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10LarsWirzenius) Just promoted all sites to wmf.30. [13:10:41] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:17:16] (03PS1) 10Hashar: Add push to releng for mass import [services] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/593507 (https://phabricator.wikimedia.org/T249908) [13:17:25] (03CR) 10Hashar: [V: 03+2 C: 03+2] Add push to releng for mass import [services] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/593507 (https://phabricator.wikimedia.org/T249908) (owner: 10Hashar) [13:33:20] (03PS4) 10Hashar: Override scm url for wikidata/query/rdf [integration/config] - 10https://gerrit.wikimedia.org/r/593300 (https://phabricator.wikimedia.org/T247123) [13:33:51] (03CR) 10Hashar: [C: 03+1] "Rolled back to PS2" [integration/config] - 10https://gerrit.wikimedia.org/r/593300 (https://phabricator.wikimedia.org/T247123) (owner: 10Hashar) [13:42:02] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-GitHub, 10Patch-For-Review: Github Actions do not run correctly on Github mirrors of Gerrit-hosted repositories - https://phabricator.wikimedia.org/T245826 (10Lucas_Werkmeister_WMDE) 05Open→03Resolved a:... [13:42:40] 10Beta-Cluster-Infrastructure, 10Analytics, 10Event-Platform: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10Ottomata) Where are you getting this error? In MW Vagrant? [13:43:53] 10Beta-Cluster-Infrastructure, 10Analytics, 10Event-Platform: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10abi_) On the beta cluster - https://logstash-beta.wmflabs.org/app/kibana#/doc/logstash-*/logstash-2020.04.30/eventgate-logging?id=AXHKt8f7Cmr1... [13:53:29] 10Beta-Cluster-Infrastructure, 10Analytics, 10Event-Platform: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10Ottomata) That's a strange error, I'm not sure where '../lib/factories/wikimedia-eventgate' comes from, that isn't the right configuration.... [14:10:56] hashar / maryum: I've just seen a failed post merge build: https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-release-docker-wdqs/3/console [14:11:23] it looks like we are now trying to do a release on post merge. That's most probably not what we want. Not sure where this is coming from... [14:12:36] 10Beta-Cluster-Infrastructure, 10Analytics, 10Event-Platform: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10abi_) @Ottomata - Yup, the jobs seem to be executing again! Thanks for you help! Feel free to resolve this task if there is nothing further to... [14:14:55] gehel: I have removed that job from postmerge yesterday night [14:15:11] gehel: the ci config was wrong ;D [14:16:08] 10Beta-Cluster-Infrastructure, 10Analytics, 10Event-Platform: Cannot find module '../lib/factories/wikimedia-eventgate' - https://phabricator.wikimedia.org/T251510 (10Ottomata) 05Open→03Resolved a:03Ottomata [14:21:39] hashar: ok, so already fixed! thanks! [14:22:31] hashar: I've pushed a commit to https://gerrit.wikimedia.org/r/c/wikidata/query/rdf/+/593298/ I think it should now be ok [14:26:32] gehel: ahhh much better ;D [14:26:47] and one can notice my terrible copy paste skill [14:26:56] he, he, he... [14:29:14] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Blubber: For node images, run npm ci instead of npm install - https://phabricator.wikimedia.org/T250764 (10thcipriani) p:05Triage→03Medium [14:43:47] 10phan-taint-check-plugin: ERROR: Error: Undefined constant 'ast\AST_LIST' - https://phabricator.wikimedia.org/T251346 (10Daimona) I cannot reproduce this locally with php-ast, nor with the polyfill parser. What version of php-ast are you using? And if using the polyfill parser, what happens if you switch to php... [14:49:44] (03CR) 10Thcipriani: [C: 03+1] "Makes sense to me and projects seem to build. Added a few reviewers who may or may not have strong opinions about this (both cxserver and " [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [14:59:24] (03CR) 10Thcipriani: [C: 03+2] Fix regexp string to be a raw string so \d works [tools/scap] - 10https://gerrit.wikimedia.org/r/589390 (owner: 10Lars Wirzenius) [15:01:51] 10Gerrit, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Unable to clone Mediawiki core repo due to timeout - https://phabricator.wikimedia.org/T249410 (10AlQaholic007) This issue has been resolved now. I think it was related to network issues. [15:02:33] 10MediaWiki-Codesniffer, 10Wikidata: Consider adding - https://phabricator.wikimedia.org/T251533 (10Addshore) [15:02:42] 10Gerrit, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Unable to clone Mediawiki core repo due to timeout - https://phabricator.wikimedia.org/T249410 (10AlQaholic007) 05Open→03Resolved [15:02:51] 10MediaWiki-Codesniffer, 10Wikidata: Consider adding bash scripts to mediawiki-codesniffer for only running on touched files - https://phabricator.wikimedia.org/T251533 (10Addshore) [15:05:49] (03CR) 10Mholloway: [C: 03+1] "Sounds good to me!" [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [15:13:21] 10Continuous-Integration-Config, 10Core Platform Team, 10Texvcjs, 10Patch-For-Review: Move math related repositories from GitHub(?) to gerrit - https://phabricator.wikimedia.org/T249908 (10hashar) [15:13:46] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Core Platform Team, and 2 others: Move math related repositories from GitHub(?) to gerrit - https://phabricator.wikimedia.org/T249908 (10hashar) [15:27:16] (03CR) 10BearND: [C: 03+1] "LGTM. As long as there's a package-lock.json file, as this seems to be checking for, I prefer `npm ci` over `npm install`." [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [15:32:58] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10LarsWirzenius) Logstash is still fairly quiet after two hours. [15:34:01] (03PS2) 10Thcipriani: Use getfullargspec instead of getargspec if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589391 (owner: 10Lars Wirzenius) [15:34:26] (03CR) 10Thcipriani: [C: 03+2] Use getfullargspec instead of getargspec if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589391 (owner: 10Lars Wirzenius) [15:37:56] (03CR) 10Hashar: "I see where it is coming, but for an externally website we would also want to be able to specify the path under which the wiki is exposed " [integration/quibble] - 10https://gerrit.wikimedia.org/r/591826 (owner: 10Awight) [15:40:41] (03PS2) 10Thcipriani: Use configparser read_file over readfp, if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589392 (owner: 10Lars Wirzenius) [15:41:04] (03CR) 10Thcipriani: [C: 03+2] Use configparser read_file over readfp, if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589392 (owner: 10Lars Wirzenius) [15:42:16] (03PS2) 10Thcipriani: Fix test to use mock less strangely [tools/scap] - 10https://gerrit.wikimedia.org/r/589393 (owner: 10Lars Wirzenius) [15:52:58] (03CR) 10Dduvall: [C: 04-1] "Seems like a good idea to allow use of `ci` based on its description, but I'll defer to folks with more NPM knowledge." [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [15:53:11] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Core Platform Team, and 2 others: Move math related repositories from GitHub(?) to gerrit - https://phabricator.wikimedia.org/T249908 (10Physikerwelt) @hashar th... [15:53:56] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Replace integration-trigger-01 with running the dummy job on contint1001 agent - https://phabricator.wikimedia.org/T247109 (10hashar) The... [15:57:59] (03CR) 10Thcipriani: [C: 03+2] Fix test to use mock less strangely (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/589393 (owner: 10Lars Wirzenius) [15:59:56] (03CR) 10Hashar: "When it comes to npm I summon Krinkle." [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [16:03:36] (03CR) 10Mholloway: [C: 03+1] "> Perhaps you could introduce explicit configuration instead?" [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [16:12:30] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10LarsWirzenius) a:05LarsWirzenius→03brennen I'm signing off for today, assigning to Brennen in case something happen... [16:29:25] (03PS5) 10Umherirrender: Set ignoreSpacingBeforeAssignments to false for OperatorSpacing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592751 (https://phabricator.wikimedia.org/T232265) [16:30:59] (03CR) 10Umherirrender: "I have removed the tabs from the test case" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592751 (https://phabricator.wikimedia.org/T232265) (owner: 10Umherirrender) [16:33:57] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Add extension to release branch cut - https://phabricator.wikimedia.org/T251442 (10LGoto) [16:34:20] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Add extension to release branch cut - https://phabricator.wikimedia.org/T251442 (10dr0ptp4kt) To clarify, is this required ahead of placing on the beta cluster? [16:34:44] (03CR) 10Umherirrender: "phpcs exclude the folder because it is tested by phpunit and should not be autofixed." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592947 (owner: 10Thiemo Kreuz (WMDE)) [16:36:22] (03PS3) 10Umherirrender: build: Add mediawiki/mediawiki-phan-config [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 [16:36:57] (03PS2) 10Umherirrender: Update squizlabs/php_codesniffer to 3.5.5 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593301 [16:36:59] (03PS4) 10Umherirrender: build: Add mediawiki/mediawiki-phan-config [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 [16:38:48] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10brennen) [16:39:14] (03CR) 10Umherirrender: "Now with dead code detection" (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [16:40:02] (03PS1) 10Physikerwelt: Enable tests for texvcinfo [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) [16:44:13] (03CR) 10Umherirrender: "Unfortunally this downgrade the use of composer/semver from 2.0.0 to 1.5.2" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [16:47:06] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Core Platform Team, and 2 others: Move math related repositories from GitHub(?) to gerrit - https://phabricator.wikimedia.org/T249908 (10Physikerwelt) I was tryi... [16:48:37] (03CR) 10Reedy: "Filed https://github.com/phan/phan/issues/3887, will do a PR upstream too" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [16:49:57] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Add extension to release branch cut - https://phabricator.wikimedia.org/T251442 (10Mholloway) [17:00:44] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Add extension to release branch cut - https://phabricator.wikimedia.org/T251442 (10Jdforrester-WMF) >>! In T251442#6097695, @dr0ptp4kt wrote: > To clarify, is this required... [17:06:15] (03CR) 10Jforrester: "Can we write an equivalent patch on top of this stack and merge the lot?" [tools/scap] - 10https://gerrit.wikimedia.org/r/589389 (owner: 10Lars Wirzenius) [17:10:08] (03CR) 10Ppchelko: [C: 04-1] Enable tests for texvcinfo (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) (owner: 10Physikerwelt) [17:11:40] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10brennen) [17:13:11] (03CR) 10BearND: "An explicit configuration sounds good to me as well." [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [17:22:10] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Add extension to release branch cut - https://phabricator.wikimedia.org/T251442 (10dr0ptp4kt) Thanks @Jdforrester-WMF. [17:26:08] (03CR) 10Dduvall: [C: 03+2] ui: Stick table row for easier scrolled reading [integration/reporting] - 10https://gerrit.wikimedia.org/r/588440 (owner: 10Dduvall) [17:26:15] (03Merged) 10jenkins-bot: ui: Stick table row for easier scrolled reading [integration/reporting] - 10https://gerrit.wikimedia.org/r/588440 (owner: 10Dduvall) [17:27:13] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10Krinkle) [17:35:16] PROBLEM - Free space - all mounts on deployment-deploy02 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy02.diskspace._srv.byte_percentfree (<11.11%) [17:40:06] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Add extension to release branch cut - https://phabricator.wikimedia.org/T251442 (10Mholloway) >>! In T251442#6097818, @Jdforrester-WMF wrote: >>>! In T251442#6097695, @dr0pt... [17:45:15] RECOVERY - Free space - all mounts on deployment-deploy02 is OK: OK: All targets OK [17:46:48] PROBLEM - Free space - all mounts on deployment-deploy01 is CRITICAL: CRITICAL: deployment-prep.deployment-deploy01.diskspace._srv.byte_percentfree (<10.00%) WARN: deployment-prep.deployment-deploy01.diskspace.root.byte_percentfree (<10.00%) [17:46:51] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.30 deployment blockers - https://phabricator.wikimedia.org/T249962 (10brennen) Currently reverted to group0. [17:55:14] (03CR) 10Thiemo Kreuz (WMDE): "I'm not sure I understand everything you wrote. My argument is simply: these test files are not meant to be executed. *Never*. If we want " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592947 (owner: 10Thiemo Kreuz (WMDE)) [17:56:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Nice, thanks! Let's give others a little time to see this before we merge it." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592751 (https://phabricator.wikimedia.org/T232265) (owner: 10Umherirrender) [17:56:49] RECOVERY - Free space - all mounts on deployment-deploy01 is OK: OK: All targets OK [18:11:03] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Push-Notification-Service, 10Product-Infrastructure-Team-Backlog (Kanban): Add extension to release branch cut - https://phabricator.wikimedia.org/T251442 (10Jdforrester-WMF) >>! In T251442#6097967, @Mholloway wrote: >>>! In T251442#6097818, @Jdfor... [18:11:20] (03PS2) 10Physikerwelt: Enable tests for texvcinfo [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) [18:13:28] (03CR) 10Physikerwelt: "That makes much more sense. Maybe there is also a template for coverage tests?" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) (owner: 10Physikerwelt) [18:15:44] (03CR) 10Jforrester: "Is this going to be used in Wikimedia production? If not, we should make its own section." [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) (owner: 10Physikerwelt) [18:17:31] (03CR) 10Jforrester: "> Patch Set 1:" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) (owner: 10Physikerwelt) [18:26:07] (03CR) 10Physikerwelt: "It is used in production. But only the version published to npm as specified in the package.json in mathoid." [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) (owner: 10Physikerwelt) [18:30:45] (03CR) 10Jforrester: [C: 03+2] "> Patch Set 2:" [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) (owner: 10Physikerwelt) [18:31:46] (03Merged) 10jenkins-bot: Enable tests for texvcinfo [integration/config] - 10https://gerrit.wikimedia.org/r/593563 (https://phabricator.wikimedia.org/T249908) (owner: 10Physikerwelt) [18:32:22] !log Zuul: Install CI for mediawiki/services/texvcinfo T249908 [18:32:24] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:32:24] T249908: Move math related repositories from GitHub(?) to gerrit - https://phabricator.wikimedia.org/T249908 [19:13:08] (03CR) 10Reedy: "Upstream PR merged... Gotta wait for a release :)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [19:15:32] 10phan: New version 2.7.1 available for phan for use in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Reedy) I got a PR for `composer/semver` to include `^2.0` which we'll need here eventually when we bump it about our chains... https://github.com/phan/phan/commit/e65dc905368345787d477746e... [19:39:44] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [19:45:12] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Core Platform Team, and 2 others: Move math related repositories from GitHub(?) to gerrit - https://phabricator.wikimedia.org/T249908 (10hashar) One more questio... [19:49:13] !log deployment-logstash2 emptied /var/log/demon.log [19:49:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:49:29] Apr 30 19:49:24 deployment-logstash2 kafka-server-start[18265]: [2020-04-30 19:49:24,038] WARN Received a PartitionLeaderEpoch assignment for an epoch < latestEpoch. This implies messages have arrived out of order. New: {epoch:7, offset:51111823301}, Current: {epoch:1554, offset:51109229892} for Partition: __consumer_offsets-49 (kafka.server.epoch.LeaderEpochFileCache) [19:49:30] pfff [19:50:05] Could not find class role::kibana for deployment-logstash2.deployment-prep.eqiad.wmflabs on node deployment-logstash2.deployment-prep.eqiad.wmflabs [19:50:11] so yeah hmm bah [19:50:13] it is broken [19:52:30] and it will fill up again [19:52:35] I have no clue how kafka works [19:57:38] RECOVERY - Free space - all mounts on deployment-logstash2 is OK: OK: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found) [20:08:46] 10Beta-Cluster-Infrastructure, 10User-DannyS712, 10Wikimedia-maintenance-script-run: Run emptyUserGroup on the beta cluster (again) - https://phabricator.wikimedia.org/T248547 (10Reedy) 05Open→03Resolved a:03Reedy ` reedy@deployment-deploy01:~$ mwscript emptyUserGroup.php --wiki=testwiki contestadmin R... [20:14:11] (03PS1) 10Eevans: Edit Project Config [services/kask] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/593607 [20:15:04] (03Abandoned) 10Eevans: Edit Project Config [services/kask] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/593607 (owner: 10Eevans) [20:49:40] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Rebuild integration-agent-puppet-docker-1001 to use Stretch - https://phabricator.wikimedia.org/T250502 (10hashar) a:05hashar→03None [20:51:01] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Zuul, 10ci-test-error (WMF-deployed Build Failure): fatal: remote error: access denied or repository not exported: /mediawiki/extension... - https://phabricator.wikimedia.org/T187897 [20:53:26] 10Continuous-Integration-Infrastructure, 10Browser-Tests, 10Code-Health: Automate identifying flaky tests - https://phabricator.wikimedia.org/T224673 (10hashar) [20:54:29] 10Continuous-Integration-Infrastructure, 10Browser-Tests, 10Code-Health: Automate identifying flaky tests - https://phabricator.wikimedia.org/T224673 (10hashar) [20:54:31] 10Continuous-Integration-Infrastructure: CI monitoring to detect flapping tests, especially in unrelated gated extensions - https://phabricator.wikimedia.org/T225193 (10hashar) [20:54:41] 10Continuous-Integration-Infrastructure, 10Browser-Tests, 10Code-Health: Automate identifying flaky tests - https://phabricator.wikimedia.org/T224673 (10hashar) Edited to incorporate a comment I have made on another task ( /T225193#5242462 ) which points at OpenStack recheck bot that does analysis of recheck... [20:55:17] 10Continuous-Integration-Infrastructure: CI monitoring to detect flapping tests, especially in unrelated gated extensions - https://phabricator.wikimedia.org/T225193 (10hashar) I have merged this task into the very similar T224673 which has some basic analysis based on number of `recheck`. [21:01:30] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Zuul: "Depends on" tests both change cherry-picked from and cherry-pick patch itself; should only test cherry-pick patch itself - https://phabricator.wikimedia.org/T154359 (10hashar) 05Open→03Declined Looks like I have missed that task, then it is from... [21:02:50] (03PS1) 10Umherirrender: Code cleanup: Use parameter when building sniff message [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 [21:07:50] (03CR) 10Jforrester: [C: 03+2] Update squizlabs/php_codesniffer to 3.5.5 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593301 (owner: 10Umherirrender) [21:08:23] (03Merged) 10jenkins-bot: Update squizlabs/php_codesniffer to 3.5.5 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593301 (owner: 10Umherirrender) [21:09:19] (03CR) 10Jforrester: [C: 03+1] "Nice. You should add .phan to .gitattributes so it doesn't bloat vendor/etc." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [21:14:51] (03PS4) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [21:16:08] (03CR) 10jerkins-bot: [V: 04-1] node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [21:16:31] (03PS2) 10Umherirrender: Code cleanup: Use parameter when building sniff message [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 [21:19:04] (03CR) 10Hashar: [C: 03+2] "That code is SO bad... They could surely have a SignalException with the signal name and code as a property." [tools/scap] - 10https://gerrit.wikimedia.org/r/589390 (owner: 10Lars Wirzenius) [21:21:09] (03CR) 10Hashar: [C: 04-1] "I would argue that with Gerrit, when commits are independent, they should be send as independent patches ;) I guess we can break the chain" [tools/scap] - 10https://gerrit.wikimedia.org/r/589389 (owner: 10Lars Wirzenius) [21:21:28] (03PS1) 10Umherirrender: Code cleanup: Use T_OPEN_CURLY_BRACKET to check for { [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593616 [21:23:54] (03PS5) 10Umherirrender: build: Add mediawiki/mediawiki-phan-config [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 [21:24:09] (03CR) 10Umherirrender: ".phan/ export-ignore added" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [21:24:35] (03PS5) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [21:26:27] (03CR) 10jerkins-bot: [V: 04-1] Code cleanup: Use T_OPEN_CURLY_BRACKET to check for { [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593616 (owner: 10Umherirrender) [21:26:52] (03PS1) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [21:27:38] * hashar vanishes [21:27:39] (03CR) 10Jeena Huneidi: "I added specific configuration, node: { use-npm-ci: true }. The user must know that a package-lock or shrinkwrap file is needed, though, s" [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [21:28:17] (03CR) 10Jforrester: "Oh, right, this isn't actually a hard dependency of the stack." [tools/scap] - 10https://gerrit.wikimedia.org/r/589389 (owner: 10Lars Wirzenius) [21:28:22] (03PS2) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [21:28:24] (03PS2) 10Jforrester: Fix regexp string to be a raw string so \d works [tools/scap] - 10https://gerrit.wikimedia.org/r/589390 (owner: 10Lars Wirzenius) [21:28:38] (03PS3) 10Jforrester: Use getfullargspec instead of getargspec if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589391 (owner: 10Lars Wirzenius) [21:28:43] (03PS3) 10Jforrester: Use configparser read_file over readfp, if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589392 (owner: 10Lars Wirzenius) [21:28:48] (03PS3) 10Jforrester: Fix test to use mock less strangely [tools/scap] - 10https://gerrit.wikimedia.org/r/589393 (owner: 10Lars Wirzenius) [21:29:02] (03CR) 10Jforrester: [C: 03+2] "Go go zuul!" [tools/scap] - 10https://gerrit.wikimedia.org/r/589390 (owner: 10Lars Wirzenius) [21:30:17] (03PS6) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [21:30:59] (03Merged) 10jenkins-bot: Fix regexp string to be a raw string so \d works [tools/scap] - 10https://gerrit.wikimedia.org/r/589390 (owner: 10Lars Wirzenius) [21:32:16] (03Merged) 10jenkins-bot: Use getfullargspec instead of getargspec if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589391 (owner: 10Lars Wirzenius) [21:35:04] (03CR) 10jerkins-bot: [V: 04-1] Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [21:35:55] (03PS2) 10Umherirrender: Code cleanup: Use T_OPEN_CURLY_BRACKET to check for { [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593616 [21:37:01] (03CR) 10Jforrester: [C: 03+2] "…" [tools/scap] - 10https://gerrit.wikimedia.org/r/589392 (owner: 10Lars Wirzenius) [21:37:47] (03CR) 10Jforrester: [C: 03+2] build: Add mediawiki/mediawiki-phan-config [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [21:38:52] (03Merged) 10jenkins-bot: Use configparser read_file over readfp, if available [tools/scap] - 10https://gerrit.wikimedia.org/r/589392 (owner: 10Lars Wirzenius) [21:39:00] (03Merged) 10jenkins-bot: Fix test to use mock less strangely [tools/scap] - 10https://gerrit.wikimedia.org/r/589393 (owner: 10Lars Wirzenius) [21:39:02] (03Merged) 10jenkins-bot: build: Add mediawiki/mediawiki-phan-config [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592292 (owner: 10Umherirrender) [21:39:17] (03CR) 10Jforrester: [C: 03+2] Code cleanup: Use T_OPEN_CURLY_BRACKET to check for { [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593616 (owner: 10Umherirrender) [21:39:55] (03Merged) 10jenkins-bot: Code cleanup: Use T_OPEN_CURLY_BRACKET to check for { [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593616 (owner: 10Umherirrender) [21:39:59] (03PS3) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [21:42:20] (03PS4) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [21:47:01] (03PS3) 10Umherirrender: Code cleanup: Use parameter when building sniff message [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 [21:59:23] 10Continuous-Integration-Config: Update jenkins job builder - https://phabricator.wikimedia.org/T143731 (10hashar) 05Open→03Resolved a:03hashar That last issue got solved by upgrading the plugin and bumping jjb T188398 f2d2d06dc0f4a6c48c1fd49c516f6a7c981143ec We are now using JJB 3.1.0 which was T236746 [21:59:27] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10Traffic, 10Upstream: Jenkins job builder ignores BUILD_TIMEOUT - https://phabricator.wikimedia.org/T217403 (10hashar) [22:08:26] (03CR) 10Dduvall: [C: 04-1] "I like your overall approach and +100 for the tests." (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [22:12:47] (03PS4) 10Umherirrender: Code cleanup: Use parameter when building sniff message [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 [22:12:49] (03PS4) 10Umherirrender: Code cleanup: Remove calls to File::recordMetric [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592746 [22:12:58] (03PS4) 10Umherirrender: Move fix of typo annotations to FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592277 [22:15:58] (03PS1) 10Umherirrender: Code cleanup: Use class constant instead of class fields [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593625 [22:16:11] (03CR) 10jerkins-bot: [V: 04-1] Code cleanup: Use class constant instead of class fields [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593625 (owner: 10Umherirrender) [22:18:25] (03CR) 10jerkins-bot: [V: 04-1] Code cleanup: Remove calls to File::recordMetric [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592746 (owner: 10Umherirrender) [22:21:45] (03PS2) 10Umherirrender: Code cleanup: Use class constant instead of class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593625 [22:34:51] (03CR) 10Umherirrender: Add a sniff for `$wg*` variables that aren't globals (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [22:38:11] (03CR) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [22:39:06] (03PS5) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [22:45:01] (03CR) 10DannyS712: [C: 03+1] "LGTM" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593625 (owner: 10Umherirrender) [22:57:24] 10Gerrit, 10Release-Engineering-Team (Development services): Install rename-project plugin - https://phabricator.wikimedia.org/T201953 (10hashar) [23:02:00] (03CR) 10Krinkle: node.go: Add npm ci to build instructions (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:02:08] (03CR) 10Jeena Huneidi: node.go: Add npm ci to build instructions (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:11:44] (03CR) 10Dduvall: [C: 04-1] node.go: Add npm ci to build instructions (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:24:44] (03PS7) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [23:25:39] (03CR) 10Jeena Huneidi: node.go: Add npm ci to build instructions (032 comments) [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:25:44] (03CR) 10jerkins-bot: [V: 04-1] node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi) [23:29:51] (03CR) 10Umherirrender: Add a sniff for `$wg*` variables that aren't globals (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [23:30:58] (03PS1) 10Umherirrender: UnusedGlobalVariablesSniff should work with closures [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 [23:32:06] (03CR) 10Umherirrender: "You may want also to work (correctly) for closures, see I527c502102333a7513078f0bf0684d2333e33148 for changes to the sniff this sniff is b" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [23:34:39] (03PS8) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [23:38:19] (03PS5) 10Umherirrender: Code cleanup: Remove calls to File::recordMetric [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592746 [23:39:28] (03PS9) 10Jeena Huneidi: node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) [23:40:46] (03CR) 10jerkins-bot: [V: 04-1] node.go: Add npm ci to build instructions [blubber] - 10https://gerrit.wikimedia.org/r/591530 (https://phabricator.wikimedia.org/T250764) (owner: 10Jeena Huneidi)