[00:09:22] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10Pywikibot, 10Pywikibot-tests: Grant Pywikibot-gerritbot an access to Gerrit stream (stream-events group) - https://phabricator.wikimedia.org/T248262 (10bd808) Making some notes here that will be easier to find than in #striker. @Dvorapa created ht... [00:14:05] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Parsoid, 10Patch-For-Review: Undeploy ParsoidBatchAPI from the Wikimedia cluster - https://phabricator.wikimedia.org/T242430 (10Jdforrester-WMF) 05Stalled→03Open Excellent, thanks. [00:42:24] (03PS8) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptySeeSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) [00:45:43] (03PS1) 10DannyS712: FunctionCommentSniff: Move some sniffs to new ProperDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [00:49:48] (03PS2) 10DannyS712: FunctionCommentSniff: Move some sniffs to new ProperDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [00:54:03] (03PS3) 10DannyS712: FunctionCommentSniff: Move some sniffs to new ProperDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [05:17:13] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Marostegui) [05:17:45] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Marostegui) p:05Triage→03Medium [06:52:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I like it very much! Good job!" (037 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [07:16:12] 10Continuous-Integration-Infrastructure, 10Operations, 10Traffic: Caching of https://doc.wikimedia.org/cover/mediawiki-libs-IPUtils/IPUtils.php.html is inconsistent - https://phabricator.wikimedia.org/T252131 (10ema) >>! In T252131#6116691, @Reedy wrote: > It was definitely updated at least twice today In o... [07:35:55] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10Addshore) [07:47:31] (03CR) 10Thiemo Kreuz (WMDE): Move fix of typo annotations to FunctionAnnotationsSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592277 (owner: 10Umherirrender) [07:55:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Personally, I favor this proposal very much. It feels much simpler (less code, no surprising dependency between the two sniffs). Sure, thi" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593746 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [08:16:21] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Aklapper) Some stuff around https://phabricator.wikimedia.org/diffusion/PHTO/browse/master/wmfphablib/phabdb.py$96 might need updates. AFAIK a Phab update got deployed last week. Might be worth to first find out... [08:25:21] (03CR) 10Thiemo Kreuz (WMDE): "I think this is a welcome improvement, and I'm looking forward to merge this. However, I do have a few minor issues with how the code is a" (035 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 (owner: 10Umherirrender) [08:29:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "The only "issue" I have with this patch is that it is "to good" ;-) but that's not mentioned in the commit message:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593625 (owner: 10Umherirrender) [08:30:24] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, and 2 others: 1.35.0-wmf.31 deployment blockers - https://phabricator.wikimedia.org/T249963 (10Marostegui) We've had a huge spikes on INSERTS on our primary masters - even though it has happened b... [09:48:57] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Dzahn) should be gone now since these were merged: https://gerrit.wikimedia.org/r/c/operations/puppet/+/595488 https://gerrit.wikimedia.org/r/c/operations/puppet/+/595479 [09:49:51] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Dzahn) >>! In T252495#6128372, @Aklapper wrote: > Some stuff around https://phabricator.wikimedia.org/diffusion/PHTO/browse/master/wmfphablib/phabdb.py$96 might need updates. AFAIK a Phab update got deployed last... [09:50:12] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Dzahn) p:05Medium→03Low [09:51:26] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Dzahn) a:03Dzahn [09:54:03] 10Continuous-Integration-Config, 10MediaWiki-extensions-Other: [Page Exchange] Add Jenkins monitoring to new Page Exchange extension - https://phabricator.wikimedia.org/T252473 (10Peachey88) [09:56:04] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Dzahn) 05Open→03Resolved cron on the cloud VPS has been removed. closing as resolved. if unexpectedly it happens again please reopen. [10:37:02] 10Phabricator: public_task_dump.py script is failing - https://phabricator.wikimedia.org/T252495 (10Aklapper) @Dzahn: Uh, true, you said that... had forgotten. Happy that the "fix" was so easy. :P [10:56:16] 10Phabricator, 10Developer-Advocacy, 10Epic: (Semi)automatically close Phabricator tickets with status "stalled" after a while - https://phabricator.wikimedia.org/T252522 (10Aklapper) p:05Triage→03Lowest [10:58:18] 10Phabricator, 10Developer-Advocacy: Decrease issues created many years ago with no recent activity (aka stale tickets) - https://phabricator.wikimedia.org/T248034 (10Aklapper) I think I am still wondering which actual underlying problem to solve by this proposal/solution, apart from folks working on stuff th... [11:04:54] 10Phabricator, 10WMNO-General: Make #WMNO-General a subproject of #WMNO - https://phabricator.wikimedia.org/T221864 (10jhsoby-WMNO) @Aklapper No worries, there's absolutely no urgency to this, just a mild inconvenience. :-) But still wanted, yes. I believe the reason you weren't subscribed is that IIRC your h... [11:43:09] (03PS1) 10Lars Wirzenius: refactor: rename loop variable to not be lower case ell [tools/scap] - 10https://gerrit.wikimedia.org/r/595910 [11:47:27] (03CR) 10Lars Wirzenius: "This is a really trivial change. Honest." [tools/scap] - 10https://gerrit.wikimedia.org/r/595910 (owner: 10Lars Wirzenius) [11:59:13] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10hashar) @DannyS712 thank you for the summary ;) https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/594807/ is worth adding but I don't... [12:28:22] (03CR) 10Hashar: [C: 03+2] tests: sort output of some assertion [integration/config] - 10https://gerrit.wikimedia.org/r/594508 (owner: 10Hashar) [12:29:19] (03Merged) 10jenkins-bot: tests: sort output of some assertion [integration/config] - 10https://gerrit.wikimedia.org/r/594508 (owner: 10Hashar) [12:49:13] (03PS1) 10Lars Wirzenius: refactor(scap.md): make subplot easier to edit in Emacs [tools/scap] - 10https://gerrit.wikimedia.org/r/595920 [12:51:18] (03CR) 10jerkins-bot: [V: 04-1] refactor(scap.md): make subplot easier to edit in Emacs [tools/scap] - 10https://gerrit.wikimedia.org/r/595920 (owner: 10Lars Wirzenius) [12:55:12] 10Release-Engineering-Team (Deployment services), 10Scap: scap deployment to deployment server uses slow rsync with compression - https://phabricator.wikimedia.org/T252533 (10hashar) [12:58:59] 10Release-Engineering-Team (Deployment services), 10Scap: scap checks messages appears after they have completed - https://phabricator.wikimedia.org/T252534 (10hashar) [12:59:13] 12:57:07 Finished sync-proxies (duration: 00m 57s) not too bad [12:59:15] :) [12:59:20] * hashar presses enter [13:00:08] (03PS2) 10Lars Wirzenius: refactor(scap.md): make subplot easier to edit in Emacs [tools/scap] - 10https://gerrit.wikimedia.org/r/595920 [13:05:02] (03CR) 10Lars Wirzenius: "This makes it easier for me to edit scap.md in Emacs (not being a vim user). Bascially only a refactoring of the markdown file. See commit" [tools/scap] - 10https://gerrit.wikimedia.org/r/595920 (owner: 10Lars Wirzenius) [13:10:41] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:14:04] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Arrange PGP keysigning at All Hands 2020 - https://phabricator.wikimedia.org/T242340 (10Dzahn) >>! In T242340#6124140, @LarsWirzenius wrote: > https://gerrit.wikimedia.org/r/admin/projects/pgp-public-keys Thanks! https://gerrit.wikimedia.org/r/c/pgp-p... [13:40:21] hi, I'd like releng's opinion/insight on what I'm doing/proposing here: T251869, let me know! thanks [13:40:22] T251869: Regression test for Logstash filters - https://phabricator.wikimedia.org/T251869 [14:02:59] 10Release-Engineering-Team (Deployment services), 10Scap: Experiment rsync "new compression" - https://phabricator.wikimedia.org/T252540 (10hashar) [14:17:29] (03PS1) 10Hashar: Make rsync use new compress algorithm [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) [14:18:13] (03CR) 10Hashar: "I haven't benchmarked the difference :(" [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:19:28] 10Release-Engineering-Team (Deployment services), 10Scap, 10Patch-For-Review: Experiment rsync "new compression" - https://phabricator.wikimedia.org/T252540 (10hashar) a:03hashar [14:19:30] (03CR) 10jerkins-bot: [V: 04-1] Make rsync use new compress algorithm [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:20:22] (03Abandoned) 10Lars Wirzenius: Drop test of euro sign [tools/scap] - 10https://gerrit.wikimedia.org/r/589389 (owner: 10Lars Wirzenius) [14:26:33] (03PS1) 10Hashar: Pin flake8 version [tools/scap] - 10https://gerrit.wikimedia.org/r/595944 [14:27:04] (03CR) 10Hashar: "The failure is unrelated, it is due to flake8 cutting a new release. Pinning it to a specific version would solve the issue: https://gerr" [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:28:19] (03CR) 10jerkins-bot: [V: 04-1] Pin flake8 version [tools/scap] - 10https://gerrit.wikimedia.org/r/595944 (owner: 10Hashar) [14:30:43] (03PS2) 10Hashar: Pin flake8 version [tools/scap] - 10https://gerrit.wikimedia.org/r/595944 [14:31:38] 10Release-Engineering-Team (Deployment services), 10Scap, 10Patch-For-Review: Experiment rsync "new compression" - https://phabricator.wikimedia.org/T252540 (10hashar) p:05Triage→03Medium [14:37:31] (03CR) 10Jforrester: [C: 03+2] Pin flake8 version [tools/scap] - 10https://gerrit.wikimedia.org/r/595944 (owner: 10Hashar) [14:38:43] (03CR) 10Lars Wirzenius: "I'm going to want to think about this for a moment. On the one hand, not getting random failures due to new tests is good. On the other ha" [tools/scap] - 10https://gerrit.wikimedia.org/r/595944 (owner: 10Hashar) [14:39:26] (03Merged) 10jenkins-bot: Pin flake8 version [tools/scap] - 10https://gerrit.wikimedia.org/r/595944 (owner: 10Hashar) [14:40:13] (03CR) 10Hashar: "recheck" [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:40:38] (03CR) 10Jforrester: "> Patch Set 2:" [tools/scap] - 10https://gerrit.wikimedia.org/r/595944 (owner: 10Hashar) [14:40:52] (03PS2) 10Jforrester: Make rsync use new compress algorithm [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:46:25] 10Release-Engineering-Team, 10Wikimedia-Logstash, 10observability, 10Patch-For-Review, 10User-fgiunchedi: Regression test for Logstash filters - https://phabricator.wikimedia.org/T251869 (10fgiunchedi) [14:53:34] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10LarsWirzenius) [14:54:17] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Python3-Porting: Port scap to Python 3.4 - https://phabricator.wikimedia.org/T246025 (10LarsWirzenius) [14:55:09] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-Logstash, 10observability, and 2 others: Regression test for Logstash filters - https://phabricator.wikimedia.org/T251869 (10thcipriani) [15:07:55] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [15:11:46] thcipriani: to clarify T251869 I'm looking for a consultancy/opinion, thanks! [15:11:46] T251869: Regression test for Logstash filters - https://phabricator.wikimedia.org/T251869 [15:12:17] godog: yep, just moving around workboards so I don't lose it :) [15:12:46] sweet -- thanks [15:12:50] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 92858 bytes in 0.990 second response time [15:22:45] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, and 2 others: 1.35.0-wmf.31 deployment blockers - https://phabricator.wikimedia.org/T249963 (10thcipriani) 05Resolved→03Open >>! In T249963#6128435, @Marostegui wrote: > We've had a huge spike... [15:22:58] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10thcipriani) [15:23:02] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, and 2 others: 1.35.0-wmf.31 deployment blockers - https://phabricator.wikimedia.org/T249963 (10thcipriani) [15:23:45] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10thcipriani) Added 1.35.0-wmf.31 as a blocker to investigate T249963#6128435 [15:24:53] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10Jdforrester-WMF) [15:25:31] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10Jdforrester-WMF) [15:25:34] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, and 2 others: 1.35.0-wmf.31 deployment blockers - https://phabricator.wikimedia.org/T249963 (10Jdforrester-WMF) [15:25:42] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, and 2 others: 1.35.0-wmf.31 deployment blockers - https://phabricator.wikimedia.org/T249963 (10Jdforrester-WMF) 05Open→03Resolved Moved blocker dependency to T247028. [15:31:06] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-Site-requests, 10WikimediaMessages, 10EngProd-Virtual-Hackathon: Put "shim" code for namespaces, logs, and log i18n into WikimediaMessages so we can undeploy extensions - https://phabricator.wikimedia.org/T222918 (10Jdforrester-WMF) [15:32:03] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, and 2 others: 1.35.0-wmf.31 deployment blockers - https://phabricator.wikimedia.org/T249963 (10thcipriani) [15:33:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation phpunit run very slow due to inclusion of Scri... - https://phabricator.wikimedia.org/T121595 [15:34:27] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, and 2 others: 1.35.0-wmf.31 deployment blockers - https://phabricator.wikimedia.org/T249963 (10thcipriani) [15:34:41] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble, 10EngProd-Virtual-Hackathon: Feature request: Evaluate "require" field from "extension.json" in automated test environment - https://phabricator.wikimedia.org/T185736 (10Jdforrester-WMF) [15:34:58] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 3 others: Upgrade phan to 0.10.2 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Jdforrester-WMF) a:03Jdforrester-WMF [15:40:12] Hello! I am trying to understand a CI-only configuration. I am in skin/Vector trying to use a relative path like ../../resources/src/mediawiki.page.ready but it doesn't exist in CI. I'm in the context of an NPM script (mwgate-node10-docker). When I run `ls ..`, it looks like the repo has been mounted at the root of the filesystem. How can I reference MediaWiki Core files? [15:48:31] (03PS1) 10Jcrespo: zuul: Add Privacybatm to the list of users that can trigger CI [integration/config] - 10https://gerrit.wikimedia.org/r/595968 (https://phabricator.wikimedia.org/T248256) [15:52:28] (03CR) 10Reedy: [C: 03+2] zuul: Add Privacybatm to the list of users that can trigger CI [integration/config] - 10https://gerrit.wikimedia.org/r/595968 (https://phabricator.wikimedia.org/T248256) (owner: 10Jcrespo) [15:53:44] thanks [15:53:53] (03Merged) 10jenkins-bot: zuul: Add Privacybatm to the list of users that can trigger CI [integration/config] - 10https://gerrit.wikimedia.org/r/595968 (https://phabricator.wikimedia.org/T248256) (owner: 10Jcrespo) [15:54:35] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/595968 T248256 [15:54:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:54:39] T248256: GSoC 2020 Proposal: Improve the framework to transfer files over the LAN - https://phabricator.wikimedia.org/T248256 [15:54:53] Well, that's no use [15:55:06] [contint2001.wikimedia.org] sudo: /usr/sbin/service zuul reload [15:55:06] [contint2001.wikimedia.org] out: zuul: unrecognized service [15:55:06] [contint2001.wikimedia.org] out: [15:55:06] Fatal error: sudo() received nonzero return code 1 while executing! [15:55:06] Requested: /usr/sbin/service zuul reload [15:55:06] Executed: sudo -H -u "root" /usr/sbin/service zuul reload [15:55:16] James_F: Has something changed? [15:56:03] that is buster, not sure service is the way to go [15:56:15] if I can try just plain systemctl? [15:56:35] oh [15:56:56] zuul.service -> Loaded: masked / Active: inactive (dead) [15:57:16] not sure which one is the active [15:57:32] Reedy: Ask hashar, he's been working on migrating CI onto buster. I think you can't deploy CI changes this week. Oh, right, you tried to do that. Tsk. [15:57:37] but I knew there was a migration and then a revert [15:57:44] Reedy: This is why CI is locked down so randos can't try to deploy changes. :-P [15:58:41] There are a few hundred plates in the air right now. [16:00:37] contint is on contint1001 just like before right now [16:00:50] Yes, but half the config points at one or the other. [16:01:03] Reedy: Let me see if I can manually fudge it. [16:01:17] ugh :/ [16:01:26] it should have been reverted to contint1001 yesterday [16:02:07] i dont think it's a good idea to start zuul on contint2001 right now [16:02:13] it is masked on purpose [16:02:20] !log Zuul: Manually running fabric against contint1001 to add Privacybatm to the CI allow list T248256 [16:02:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:02:22] T248256: GSoC 2020 Proposal: Improve the framework to transfer files over the LAN - https://phabricator.wikimedia.org/T248256 [16:02:27] yeah, I think we just want to reload contint1001 [16:02:30] OK, that worked. [16:02:43] ok, good [16:02:59] mutante: Yeah, agreed; there are too many damn places with CI config/assumptions. [16:03:13] Maybe we should point everything at contint rather than contint1001 or 2001. [16:03:14] if you see a config using 2001, change it to 1001 [16:03:19] And rely on DNS. [16:03:28] James_F: i did that [16:03:33] it can be used now [16:03:41] Yeah, I saw. Nice change. [16:03:49] contint.wikimedia.org is an alias for contint1001.wikimedia.org. [16:03:55] feel free to use that in configs [16:03:59] With a short TTL. [16:04:10] we well switch it when we try to switch to 2001 next time [16:04:21] * James_F nods. [16:04:28] which is hopefully soon [16:04:36] Did you/hashar make progress on the Java 8 downgrade? [16:04:42] the reason to revert yesterday was that gearman doesnt support java 11 [16:04:58] yes, i amended to a change and merged it [16:05:04] 2001 now has java 8 [16:05:18] on buster [16:05:54] Nice. [16:05:57] (03PS1) 10Jforrester: fabfile: Rely on DNS to point to contint primary, rather than hardcode [integration/config] - 10https://gerrit.wikimedia.org/r/595972 [16:06:59] fabfile.py is out of date then [16:07:02] heh, yeah, that [16:07:14] But as I said, now is a really bad time to merge CI changes. [16:07:28] If you want to help out, there's a weekly Friday evening UTC meeting about CI. ;-) [16:07:31] Shouldn't the infrastructure prevent it? [16:07:40] Ha. You must be new here. ;-( [16:07:44] ;P [16:07:44] (03CR) 10Dzahn: [C: 03+1] "The DNS entry will change during the migration." [integration/config] - 10https://gerrit.wikimedia.org/r/595972 (owner: 10Jforrester) [16:07:56] Making the CI repo read-only is a bit mega, but I guess we could. [16:08:29] the prevention was the masked zuul service? [16:08:39] Yeah, true. [16:09:49] (03CR) 10Jforrester: [C: 03+2] refactor: rename loop variable to not be lower case ell [tools/scap] - 10https://gerrit.wikimedia.org/r/595910 (owner: 10Lars Wirzenius) [16:10:22] https://gerrit.wikimedia.org/r/c/operations/puppet/+/587517 [16:10:33] (03CR) 10Jforrester: [C: 03+2] refactor(scap.md): make subplot easier to edit in Emacs [tools/scap] - 10https://gerrit.wikimedia.org/r/595920 (owner: 10Lars Wirzenius) [16:10:53] * James_F nods. [16:10:58] though it was masked manually anyways :p [16:11:05] I wish I was in .eu timezone so I could help out more. [16:11:50] thanks! i hope we can try again very soon [16:11:51] (03Merged) 10jenkins-bot: refactor: rename loop variable to not be lower case ell [tools/scap] - 10https://gerrit.wikimedia.org/r/595910 (owner: 10Lars Wirzenius) [16:11:59] +1 [16:12:00] now Java upgrade and OS upgrade are unrelated [16:12:02] sleeping is overrated! [16:12:24] jynus: I have a meeting at 05:00 tomorrow; I think that's me showing willing enough. :-) [16:12:39] wow [16:12:51] earliest I gotten up for work is 6 [16:13:02] well, if you don't count the couple of 3am calls :-D [16:13:04] Except for pages, I guess. [16:13:07] Snap. :-) [16:14:32] if i had to pick ...7am is better than 7pm [16:14:50] 5 is too extreme though :p [16:15:29] (03Merged) 10jenkins-bot: refactor(scap.md): make subplot easier to edit in Emacs [tools/scap] - 10https://gerrit.wikimedia.org/r/595920 (owner: 10Lars Wirzenius) [16:17:00] Yeah, well, meetings with SF, Australia, and Europe don't really have timeslots that work for everyone. [16:20:34] i remember that when springle was DBA.. sucked for him [16:24:57] (03CR) 10BearND: "This is ready for review" [integration/config] - 10https://gerrit.wikimedia.org/r/594823 (owner: 10BearND) [16:25:10] Yeah. [16:25:47] indeed [16:26:03] We really need more clock-round coverage generally. [16:26:10] and specially with me being literally 12h shifted [16:26:18] * James_F nods. [16:26:36] I think EU -> AU -> US allow for some better bilateral matches? [16:27:28] I know one of my teams with EU/US/AU/IN ended up having two meetings a day, SF morning (with EU) and SF evening (with AU/IN). [16:27:54] Other times, people have had weekly or even daily meetings at 02:00 local. That really sucks. [16:28:55] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Puppet, 10User-brennen: logspam-watch: Some exceptions may be missing from logspam - https://phabricator.wikimedia.org/T244528 (10brennen) 05Open→03Resolved After the last few weeks of usage of `logspam-watch` and Kiba... [16:40:39] (03PS6) 10Umherirrender: Code cleanup: Use parameter when building sniff message [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 [16:41:22] (03CR) 10Umherirrender: Code cleanup: Use parameter when building sniff message (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 (owner: 10Umherirrender) [16:44:49] (03PS1) 10Lars Wirzenius: feat: add scap apply-patch for security patches during train [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 [16:57:22] (03CR) 10Lars Wirzenius: "This is a biiiiiig patch for adding a scap command to apply security patches during the train. The bulk of the changes are to the document" [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [16:58:55] (03PS2) 10Lars Wirzenius: feat: add scap apply-patch for security patches during train [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (https://phabricator.wikimedia.org/T247075) [17:14:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Code cleanup: Use parameter when building sniff message (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 (owner: 10Umherirrender) [17:15:02] (03Merged) 10jenkins-bot: Code cleanup: Use parameter when building sniff message [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593614 (owner: 10Umherirrender) [17:22:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "I think this was sitting here long enough for others to notice. There is a bug, and this is a fix. If there is an edge-case the current im" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [17:26:38] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10thiemowmde) Can we assume this is an "accepted rule change"? Personally, I think this is not even changing a rule, but... [17:27:58] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Are 2 weeks enough for others to notice? Maybe not. Unfortunately the ticket T232265 was never moved to the column "accepted rule change"," [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592751 (https://phabricator.wikimedia.org/T232265) (owner: 10Umherirrender) [17:33:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Code cleanup: Remove extra php7.4 code from UnsortedUseStatement (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593737 (owner: 10Umherirrender) [17:38:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Check index in VariadicArgumentSniff and avoid some local vars (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593732 (owner: 10Umherirrender) [17:39:20] (03Merged) 10jenkins-bot: Check index in VariadicArgumentSniff and avoid some local vars [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593732 (owner: 10Umherirrender) [17:48:59] (03PS5) 10Jforrester: Stop branching ParsoidBatchAPI [tools/release] - 10https://gerrit.wikimedia.org/r/563462 (https://phabricator.wikimedia.org/T242430) (owner: 10Reedy) [18:05:02] 10LibUp, 10MediaWiki-Configuration: Create and maintain/encourage/enforce a sort order for extension/skin.json - https://phabricator.wikimedia.org/T252567 (10Jdforrester-WMF) This is something LibUp could probably do. [18:06:21] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO, 10local-charts, 10Developer Productivity, 10Patch-For-Review: Move local-charts helm charts to a chart repository - https://phabricator.wikimedia.org/T224935 (10thcipriani) 05Open→03Resolved All subtasks closed, closing this one... [18:13:25] 10Release-Engineering-Team (Local Dev), 10Release Pipeline, 10serviceops-radar: Make helm chart template in deployment-charts support local development - https://phabricator.wikimedia.org/T226660 (10thcipriani) 05Open→03Resolved Patch merged with {00e3486a0518bd60be53de66e1ed72c5d141738d} [18:18:13] (03CR) 10Umherirrender: Code cleanup: Remove extra php7.4 code from UnsortedUseStatement (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593737 (owner: 10Umherirrender) [18:18:30] (03PS2) 10Umherirrender: UnusedGlobalVariablesSniff should work with closures [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 [18:19:32] 10Release-Engineering-Team-TODO: Get an IDE to run tests against services running in kubernetes - https://phabricator.wikimedia.org/T245656 (10thcipriani) 05Open→03Stalled [18:20:21] (03PS7) 10Umherirrender: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [18:20:27] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [18:21:17] (03Merged) 10jenkins-bot: UnusedUseStatementSniff: Recognize uses in `@phan-var` comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591600 (https://phabricator.wikimedia.org/T250765) (owner: 10DannyS712) [18:22:32] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10Umherirrender) 05Open→03Resolved p:05Triage→03Medium [18:28:38] (03PS1) 10Thiemo Kreuz (WMDE): Significant simplification of UnusedGlobalVariables sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596010 [18:30:22] 10MediaWiki-Codesniffer, 10User-thiemowmde: Allow float|int documentation for strictly typed float parameters - https://phabricator.wikimedia.org/T251722 (10Umherirrender) > Our CodeSniffer rule set should accept both @param float as well as @param float|int in such a situation. I would say there is no sniff... [18:33:27] (03CR) 10Thiemo Kreuz (WMDE): "Looking forward to merge this! Just an issue with a style I think is not that readable." (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 (owner: 10Umherirrender) [18:35:09] 10Continuous-Integration-Config: Make test vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10hashar) [18:41:12] o/ is there a way to see all final mediaiwki config for a given wiki? [18:41:23] i'm just looking in beta right now [18:41:32] the + merging docs are pretty confusing and it isn't clear to me what isi happenng [18:44:57] !log cloning all (public) wmf repos from gerrit replica to a local system for number crunching [18:44:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:45:02] (03PS1) 10Hashar: Archive mediawiki/debian [integration/config] - 10https://gerrit.wikimedia.org/r/596016 (https://phabricator.wikimedia.org/T240521) [18:45:45] (03CR) 10Hashar: "We need the repository to be emptied up first :]" [integration/config] - 10https://gerrit.wikimedia.org/r/596016 (https://phabricator.wikimedia.org/T240521) (owner: 10Hashar) [18:46:00] (logged above in event that i cause undo traffic to gerrit replica. did the same thing on friday without issue but made a complete hash of it, so starting over.) [18:46:22] (03CR) 10jerkins-bot: [V: 04-1] Archive mediawiki/debian [integration/config] - 10https://gerrit.wikimedia.org/r/596016 (https://phabricator.wikimedia.org/T240521) (owner: 10Hashar) [18:47:55] ottomata: there may be an easier way to do this, but in /tmp/ on the app servers under mw-cache-[version] directory there are json conf files for wikis. Or you could use mwscript to eval code using a particular wiki and var_dump the value you're looking for [18:48:56] brennen: you break it, you buy it [18:48:58] (03PS3) 10Umherirrender: UnusedGlobalVariablesSniff should work with closures [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 [18:49:04] (03CR) 10Umherirrender: UnusedGlobalVariablesSniff should work with closures (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 (owner: 10Umherirrender) [18:52:38] thcipriani: i'll pay in scrip, put it on my tab at the company store... [18:52:48] 10MediaWiki-Codesniffer, 10User-thiemowmde: Allow float|int documentation for strictly typed float parameters - https://phabricator.wikimedia.org/T251722 (10thiemowmde) If everything I listed is already possible, great! \o/ The only thing to do is to add test cases then. If we don't compare the types yet, tha... [18:53:58] by "buy" I really meant "maintain forever after" [18:54:31] (03CR) 10jerkins-bot: [V: 04-1] UnusedGlobalVariablesSniff should work with closures [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 (owner: 10Umherirrender) [18:55:40] (03CR) 10Jforrester: "This doesn't depend on that patch at all, surely?" [integration/config] - 10https://gerrit.wikimedia.org/r/596016 (https://phabricator.wikimedia.org/T240521) (owner: 10Hashar) [18:56:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Code cleanup: Remove extra php7.4 code from UnsortedUseStatement (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593737 (owner: 10Umherirrender) [18:57:22] (03Merged) 10jenkins-bot: Code cleanup: Remove extra php7.4 code from UnsortedUseStatement [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593737 (owner: 10Umherirrender) [18:58:54] 10Continuous-Integration-Config: Make test vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10Jdforrester-WMF) If we did this, the C+2 button would disappear from the UI; people would have to open the code review panel and explicitly check C+2 and Send. Re... [19:06:22] 10Continuous-Integration-Config: Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10Krinkle) [19:09:37] 10Continuous-Integration-Config: Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10Krinkle) >>! In T226123#6130733, @Jdforrester-WMF wrote: > If we did this, the C+2 button would disappear from the UI; […] Ha, interesting! I agree removi... [19:11:26] (03PS4) 10Umherirrender: UnusedGlobalVariablesSniff should work with closures [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 [19:20:18] 10MediaWiki-Codesniffer, 10User-thiemowmde: Allow float|int documentation for strictly typed float parameters - https://phabricator.wikimedia.org/T251722 (10Krinkle) Is it true that PHP 7 allows and magically casts ints to floats in strictly-typed floats. But! - I'm not sure that we should therefor document (a... [19:23:51] thcipriani: thanks that will work will check tmp dirs [19:23:55] just need to debug [19:24:37] cool [19:27:30] Hi all! Quick question, whom should I ping for guidance on CI XSS checks, specifically usage of @suppress SecurityCheck-XSS tags? Thanks in advance! [19:34:01] (03CR) 10Thiemo Kreuz (WMDE): "Nice, thanks! I will merge this very soon. Just want to give others a little more time to have a look." (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 (owner: 10Umherirrender) [19:34:23] !log installing patched version of php7.2-fpm on deployment-mediawiki-07 [19:34:25] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:40:58] https://phabricator.wikimedia.org/P11185 :) [19:44:44] 10Phabricator, 10WMNO-General: Make #WMNO-General a subproject of #WMNO - https://phabricator.wikimedia.org/T221864 (10Aklapper) 05Open→03Resolved a:03Aklapper Following https://wikitech.wikimedia.org/wiki/Phabricator#Converting_a_parent_project_into_a_subproject , * Checked that [no tasks have both tag... [20:04:36] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [analytics/wmde/TW/edit-conflicts] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/596051 [20:04:40] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [analytics/wmde/TW/edit-conflicts] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/596051 (owner: 10QChris) [20:04:49] (03PS1) 10QChris: Import done. Revoke import grants [analytics/wmde/TW/edit-conflicts] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/596052 [20:04:53] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [analytics/wmde/TW/edit-conflicts] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/596052 (owner: 10QChris) [20:10:28] !log reverting to standard php7.2-fpm on deployment-mediawiki-07 [20:10:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:14:31] 10Gerrit, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Fundraising-Backlog, 10Fundraising Sprint Ice cream cures everything: Reset fr-tech drush repo, create sub-repo for vendor - https://phabricator.wikimedia.org/T249547 (10DStrine) 05Open→03Invalid [20:19:09] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Core Platform Team, 10Quibble, 10Regression: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty - https://phabricator.wikimedia.org/T246358 (10eprodromou) Daniel, we'll keep our eyes p... [20:20:50] 10Continuous-Integration-Config, 10Core Platform Team, 10MediaWiki-Core-Testing, 10Quibble: Jenkins build for MediaWiki should fail when "PHP Warning" is emitted - https://phabricator.wikimedia.org/T214552 (10eprodromou) Also T/W this issue [20:22:23] (03PS4) 10Jforrester: Output mysql/mariadb and postgresql version [integration/quibble] - 10https://gerrit.wikimedia.org/r/595276 (owner: 10Reedy) [20:22:59] 10Gerrit, 10AutoWikiBrowser: Re-migrate AWB svn repo to git? - https://phabricator.wikimedia.org/T102427 (10Aklapper) [20:31:48] (03CR) 10Jforrester: [C: 03+2] Output mysql/mariadb and postgresql version [integration/quibble] - 10https://gerrit.wikimedia.org/r/595276 (owner: 10Reedy) [20:32:28] (03Merged) 10jenkins-bot: Output mysql/mariadb and postgresql version [integration/quibble] - 10https://gerrit.wikimedia.org/r/595276 (owner: 10Reedy) [20:32:40] (03CR) 10Jforrester: [C: 03+1] "This seems right, but leaving to Antoine." [integration/quibble] - 10https://gerrit.wikimedia.org/r/594791 (https://phabricator.wikimedia.org/T211702) (owner: 10Awight) [20:36:22] 10Continuous-Integration-Config: Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10Jdforrester-WMF) >>! In T226123#6130749, @Krinkle wrote: > Speaking of the Submit button appearing etc. I think this is tied to the same kind of ruleset as... [20:36:55] 10Phabricator (Upstream), 10Upstream: Maniphest advanced search project selection is hard to understand ("In Any Project"; "Not In Projects"; "In Users' Projects" etc.) - https://phabricator.wikimedia.org/T1378 (10Aklapper) 05Stalled→03Declined No changes planned here AFAIK, hence reflecting reality by set... [20:41:49] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble, 10Patch-For-Review: Quibble initialize step should only clone the target repository - https://phabricator.wikimedia.org/T211702 (10Jdforrester-WMF) [20:54:19] (03PS1) 10Kosta Harlan: [codehealth] Add MachineVision to pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/596059 [21:24:02] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [21:34:02] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [21:54:54] Hello! Who is a good person to ask about mwgate-node10-docker? Should I make new task? [21:59:04] I have an NPM script in Vector that is trying to reference Core files but they don't seem to exist? E.g.,` ../../resources/src/mediawiki.page.ready`. [22:05:04] niedzielski: Are you sure it's an npm script and not an MW require() call? [22:06:03] mediawiki.page.ready is a resourceloader module but not sure it'd work through npm. [22:07:18] Hmm, looking at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/resources/src/mediawiki.page.ready/ready.js maybe it will, assuming you inject mw into it? [22:07:47] James_F: well, I was doing some very scientific type experiments with `ls` that I think we're showing odd results https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/584694/40/package.json [22:08:03] https://integration.wikimedia.org/ci/job/mwgate-node10-docker/117701/console [22:08:37] (03PS9) 10Dduvall: Add pipeline project for TypeScript services [integration/config] - 10https://gerrit.wikimedia.org/r/594823 (owner: 10BearND) [22:09:20] My thinking was that locally, if I `cd skins/Vector`, `ls ../../resources/src/mediawiki.page.ready` works. It doesn't in CI, I think because of how things are mounted? So, what's the right way to reference files in Core from a skin is the question. [22:10:57] I can mark my current ticket blocked or make a new one for this question if it isn't obvious. I didn't know if I was doing something stupid. [22:13:20] (03CR) 10Dduvall: "Created jobs:" [integration/config] - 10https://gerrit.wikimedia.org/r/594823 (owner: 10BearND) [22:14:07] !log created 4 jenkins jobs with jjb for https://gerrit.wikimedia.org/r/c/integration/config/+/594823 [22:14:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:14:13] (03CR) 10Dduvall: [C: 03+2] Add pipeline project for TypeScript services [integration/config] - 10https://gerrit.wikimedia.org/r/594823 (owner: 10BearND) [22:14:40] \o/ [22:15:08] (03Merged) 10jenkins-bot: Add pipeline project for TypeScript services [integration/config] - 10https://gerrit.wikimedia.org/r/594823 (owner: 10BearND) [22:23:56] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/c/integration/config/+/594823 [22:23:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:23:58] niedzielski: I don't know if that's something we'd support. MW managed dependencies through RL. Supporting random other usage isn't something we're resourced to do in CI or anywhere else really. But please file a task explaining your needs and why you want them that way so we can see? [22:24:27] marxarelli: Careful to do that on contint1001 and not 2001. [22:24:46] James_F: ? [22:24:55] the fabfile says 2001? [22:25:06] marxarelli: Yes. It's because we're mid-transition. [22:25:12] The real zuul runs on 1001 right now. [22:25:18] oh :) [22:25:24] James_F: I'll file a task. I was using `ls` as an example. The real usages are 1) actually using a file reference in JavaScript 2) making a file copy or symlink to generate Storybook documentation. [22:25:28] And the 2001 one should error at you. [22:25:31] thanks for stopping me 1 second before i hit enter [22:25:43] ah ok [22:25:45] niedzielski: Sure. [22:25:56] but it's ok to go ahead and reload zuul on contint1001? [22:26:04] Yes. [22:26:18] kk. heads up i fetched/rebased /etc/zuul/wikimidia [22:26:21] wikimedia [22:26:24] on contint2001 [22:26:30] should i reset it? [22:26:49] Don't know. [22:27:07] I'd hope that hashar re-rsyncs tomorrow or whatever before switching live zuul. [22:27:08] But… [22:28:18] ok. well i'll leave it so it's the same as contint1001 tomorrow [22:30:54] (03CR) 10Dduvall: "Deployed zuul layout changes." [integration/config] - 10https://gerrit.wikimedia.org/r/594823 (owner: 10BearND) [22:31:58] marxarelli: should i do a recheck on https://gerrit.wikimedia.org/r/c/mediawiki/services/push-notifications/+/594352 again or should I wait until tomorrow for something to happen? [22:32:22] bearND: recheck should work now [22:32:45] ok, trying.. [22:33:19] niedzielski: 'npm test' is expected to be standalone. There is no MW core, extensions, php or databases etc in those jobs. Those kind of jobs should root at mediawiki's invocation of Ci commands instead, like for phpunit and qunit. For dev convenicence, one could certainly add a local command in your package.json like 'phpunit: cd $MW_INSTALL_PATH && composer phpunit -- Minerva' (not the correct argument, but something like that), but [22:33:19] that would be for local use only. [22:34:57] Krinkle: well, right now we're doing things like `curl -L "https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/resources/src/mediawiki.less/mediawiki.mixins.less?format=TEXT" | base64 --decode > .storybook/resolve-less-imports/mediawiki.mixins.less` which isn't ideal. [22:35:45] Locally, we can use relative pathing. I think WikibaseMediaInfo clones an entire copy of MediaWiki into node_modules to work around the issue. [22:36:02] bearND: well, it ran, so that's a start [22:36:07] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseMediaInfo/+/master/package.json#9 [22:36:15] looks like you need to tweak your `execution:` config [22:36:24] marxarelli: yes, it latest a minute longer this time before it failed [22:36:28] https://gerrit.wikimedia.org/r/c/mediawiki/services/push-notifications/+/594352/15/.pipeline/config.yaml#15 [22:36:36] progress! :) [22:37:14] just remove the `npm-run` entries from `execution` and i believe that will fix the failure [22:37:30] ok [22:38:11] and looks like we need better validation on that field too [22:38:29] it should at least bail with something like "npm-run isn't a valid stage name" [22:40:20] niedzielski: Long-term, I'd recommend leaving this out of 'npm test' and having a separate command for the storybook integration. We have lots of tailor-made jobs like this for publishing artefacts, and they've gotten relatively easy to write now (about as easy as doing this on GItHub with Travis). And indeed that job would clone MW one way or another that's what you need. But you can let CI do that, and then for local use, you can [22:40:20] assume MW_INSTALL_PATH to your own directory. So e.g. "npm run storybook" for local use, and in CI, you'd have a job like mwvector-storybook-publish which, like more MW-related jobs does a minimal MW install, and invokes your npm command and publishes the result. [22:40:37] If all you need is jsduck/jsdoc, then we have a generic job preset for that, which is what you use now [22:40:43] But might be time to grow out of that generic preset. [22:41:15] marxarelli: Now only the jenkins-bot comment appeared, not the PipelineBot one. [22:44:34] bearND: hrm... not sure why that is, but it looks like the docker build is failing on account of `npm run build` https://integration.wikimedia.org/ci/blue/organizations/jenkins/typescript-service-pipeline-test/detail/typescript-service-pipeline-test/1/pipeline/30 [22:45:42] you might want to try getting that to work locally before trying in ci [22:46:24] marxarelli: it does work locally [22:46:56] oh, you mean inside Docker [22:47:06] yeah, w/ blubber + docker [22:47:23] Krinkle: thanks, I think we'll need to make a custom NPM test job then. Vector can't check require types from ResourceLoader if it can't reference the Core files which is another use case. Are there any jobs you'd recommend offhandedly for reference? [22:47:35] you can install blubber by following https://wikitech.wikimedia.org/wiki/Blubber/Download [22:48:05] and then do `blubber .pipeline/blubber.yaml test | docker build -f - .` [22:48:42] `Error response from daemon: the Dockerfile (.dockerfile.27f15c4a2880f45fc0a1) cannot be empty` [22:48:42] er, sorry, `npm-run` is your variant name [22:48:54] so `blubber .pipeline/blubber.yaml npm-run | docker build -f - .` [22:49:04] right, that's better [23:03:13] * niedzielski sent a long message: < https://matrix.org/_matrix/media/r0/download/matrix.org/PHebtorJYgTnkLEiCSRudkqt > [23:04:04] I guess I'll open a task. [23:04:53] niedzielski: dependencies are already a solved problem. The problem is that the job you were trying to operate within is explicitly standalone and not aplpying any of that. [23:05:05] The qunit, phpunit, selenium etc they install MW plus known dependencies. [23:05:31] as declared by {extension,skin}.json/requires [23:06:17] marxarelli: at what point in terms of the blubber.yaml comes the `npm install` invocation? It seems to me that the builder step on line 15 needs the node_modules folder as a requirement but when i add it the folder doesn't exist yet. [23:10:12] bearND: you can see what kind of Dockerfile blubber is outputting just by doing `blubber .pipeline/blubber.yaml run-npm` [23:11:01] afaict, the `node_modules` directory should be there. `npm install` is run before your custom `npm run-script build` builder command [23:11:20] i've verified that locally [23:13:28] btw, best way to debug locally is usually to take the image id from the last ` ---> [sha]` line of `docker build` output before the failure and run a shell with it to inspect [23:14:22] (oh how quickly docker's promise of simplicity breaks down in practice) [23:18:30] This is strange. I do see the node_modules folder but no src when I run `docker run --rm -it 82e8acd97d9e`. [23:18:51] bearND: i just noticed that as well [23:19:21] doesn't explain `COPY failed: stat /var/lib/docker/tmp/docker-builder351357541/node_modules: no such file or directory` [23:19:26] one quirk of docker's COPY instruction (and by extension a quirk of blubber) is that you need to include the trailing `/` on directories [23:20:30] i.e. do `requirements: [package.json, src/]` [23:23:51] bearND: oh, do you need tsconfig.json in your `requirements:` as well perhaps? [23:24:07] marxarelli: yes!!!! [23:24:10] doh [23:24:27] so `requirements: [package.json, tsconfig.json, src/]` [23:24:38] (add that trailing slash on src too) [23:25:44] got that. now to the lint step, that needs .eslintignore and .eslintrc.json [23:26:36] hmm, or should I move that out of npm run build? [23:26:51] since we have another pipeline for lint [23:28:29] you probably want to include those files in `npm-run` [23:28:39] marxarelli: not sure what the best practice is here. Should I keep the lint step separate from the build step? [23:28:44] otherwise, you'd need to build another image specifically for linting that includes them [23:29:05] If we combine it then we don't need a separate piplin for lint (the lint part is super quick anyways) [23:29:13] pipeline [23:29:37] probably could simplify the .pipeline/config file then [23:30:32] it's up to you really. right now you're building an image in one step and then executing two containers using that image in two subsequent parallel steps [23:31:25] so if you simply want to include the eslint files in `npm-run` you can keep the parallelism. but if you don't think parallel execution is all that necessary for linting then you could remove the `execution` config entirely and have it execute everything serially [23:32:09] sorry, to clarify: you probably want to include the eslint files in `npm-run` regardless [23:32:45] and then decide if you want to branch out and do linting/testing in parallel or remove `execution` and make it serial [23:33:23] i've pushed what I have so far to get the build working. [23:34:18] nice https://integration.wikimedia.org/ci/blue/organizations/jenkins/typescript-service-pipeline-test/detail/typescript-service-pipeline-test/3/pipeline [23:35:28] sweet. Thank you for guiding me through how to debug this, marxarelli! [23:35:38] no problem! [23:35:54] glad you got it working [23:37:33] So, the config change is optional if i understand you correctly. If we keep it as is then it runs these in parallel. Or we take out the `execution` and the `lint` stage if we think it's not needed.