[00:02:25] 10Continuous-Integration-Config, 10Release-Engineering-Team: Expose mediawiki/tools/api-testing doc on doc.wikimedia.org - https://phabricator.wikimedia.org/T236915 (10apaskulin) It looks like the repository already uses the [jsdoc plugin](https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/api-test... [00:23:27] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10matmarex) [01:02:14] (03CR) 10Krinkle: Full rewrite of the UnusedUseStatementSniff, 4x faster (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [01:33:14] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10mmodell) [07:23:19] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops: Deploy Scap version 3.14.0-1 - https://phabricator.wikimedia.org/T249250 (10JMeybohm) 05Open→03Resolved an-tool1006.eqiad.wmnet is a test host with some ongoing experiment. As scap 3.13.0-1 should still be compatible, I'll close this as resolved now. [07:23:21] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Make scap release with --canary-wait-time and integration test changes - https://phabricator.wikimedia.org/T246455 (10JMeybohm) [08:06:54] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops: Deploy Scap version 3.14.0-1 - https://phabricator.wikimedia.org/T249250 (10elukey) Sorry for the trouble, just fixed the package on the host, thanks for the ping! [09:20:06] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Python3-Porting: Port scap to Python 3.4 - https://phabricator.wikimedia.org/T246025 (10LarsWirzenius) [09:29:40] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops: Deploy Scap version 3.14.0-1 - https://phabricator.wikimedia.org/T249250 (10LarsWirzenius) Thanks for taking care of this! [09:34:50] (03PS1) 10Awight: Remove package files to minimize build stage and image [integration/config] - 10https://gerrit.wikimedia.org/r/596403 [09:36:00] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Python3-Porting: Port scap to Python 3.4 - https://phabricator.wikimedia.org/T246025 (10LarsWirzenius) [09:49:20] (03PS1) 10Lars Wirzenius: fix(debian): put back the build-dependency on bash-completion [tools/scap] - 10https://gerrit.wikimedia.org/r/596406 [09:53:16] (03PS1) 10Awight: Docker image for testing Scala repos [integration/config] - 10https://gerrit.wikimedia.org/r/596407 [10:01:05] (03CR) 10Lars Wirzenius: "I screwed up yesterday. This undoes part of yesterday change to drop build-essential dependencies. Sorry." [tools/scap] - 10https://gerrit.wikimedia.org/r/596406 (owner: 10Lars Wirzenius) [10:04:08] 10Beta-Cluster-Infrastructure: Login to some beta wikis fail with "There seems to be a problem with your login session" - https://phabricator.wikimedia.org/T250986 (10Aklapper) 05Open→03Resolved [10:06:58] 10Continuous-Integration-Config, 10MediaWiki-Configuration, 10Wikidata, 10Sustainability (Incident Prevention): Consider having a linter that could catch config file entries that set unused variables - https://phabricator.wikimedia.org/T248866 (10Addshore) [10:07:42] 10Phabricator, 10Mobile: URLs for "Related Gerrit Patches" are cut off on mobile and not shown - https://phabricator.wikimedia.org/T240407 (10Zoranzoki21) Looks like that this is somehow resolved. See: {F31817581} Now I can scroll in each task [10:57:48] 10Phabricator, 10Mobile: URLs for "Related Gerrit Patches" are cut off on mobile and not shown - https://phabricator.wikimedia.org/T240407 (10Aklapper) 05Open→03Resolved a:03mmodell Nice catch Zoranzoki21! :) Right, since https://phabricator.wikimedia.org/rPHEX31beeaa265bca3e28d13360c91b1c57eb6c85bc5 it... [11:00:50] 10Phabricator, 10Mobile: URLs for "Related Gerrit Patches" are cut off on mobile and not shown - https://phabricator.wikimedia.org/T240407 (10Zoranzoki21) Cool, thanks @Aklapper and @mmodell! [11:56:12] Reedy: I just saw https://phabricator.wikimedia.org/T252754#6136587, I suggest we not bundle that then with https://phabricator.wikimedia.org/T252343 per my comment so we don't bottleneck with there being no train next week [11:56:43] i'd ask Urbanecm in pm about it and was waiting on reply. Didn't realise it was a core ns when I first read. [12:03:14] s/i'd ask/I asked [12:06:25] We probably wouldn't SWAT deploy new namespace names in mw core anyway [12:07:03] Reedy: yeah, didn't notice that was a core change. We'll need to SWAT the aliases part after train has ran though, right? [12:07:16] Depends if/where they're added [12:07:27] They can exist in MW core.. So we wouldn't need to [12:07:38] That's why I'm asking if it only needs doing for that wiki.. Which would seem odd [12:07:50] Unless it was some sort of translation of Wikipedian [12:07:51] 10Project-Admins, 10User-Zoranzoki21: User project for MoritzMuehlenhoff - https://phabricator.wikimedia.org/T252677 (10MoritzMuehlenhoff) Thank you! [12:08:49] Reedy: good shout, I'm going to scrap my idea to do them together with creating the portal namespace then. [12:08:58] Yeah [12:09:03] Portal are mw-config, so that's fine [12:09:31] If every wiki needs it, then it will need to go via messagesJv.php and then work out what to do with the aliases [12:11:01] Reedy: he's just replied. Let me test something for something else and then i'll read what he said [12:11:30] The aliases can go in the messages file too [12:14:02] Reedy: I'll probably have to read one to see how then [12:14:09] It's pretty simple [12:15:02] * RhinosF1 only found out that file existed the other day [12:17:29] Reedy: it sounds from his reply like go through core as it's a better translation rather than a per wiki thing? [12:20:58] * RhinosF1 sees the other change he requested and mentioned was done in core so doing [12:29:00] Reedy: created https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/596424/2/languages/messages/MessagesJv.php, the = in the alias list is not lined up, shall I shift them along? also, why does it say there's a page load cost when PS1 was just a commit msg? [12:29:38] The VMs may be differently loaded when different parts of the test run [12:29:41] So you can mostly ignore that [12:30:10] And you'll probably need/want to. You certainly need a space after 'Parembugan_Panganggo', as I imagine phpcs will complain [12:30:18] will do [12:30:36] it's triggering me so jenkins will likely moan [12:31:27] Reedy: ty and {{done}} [12:33:28] (03PS2) 10Lars Wirzenius: fix(py_djb_hash): change code to work in both Python 2 and 3 [tools/scap] - 10https://gerrit.wikimedia.org/r/596191 [12:40:56] 10Project-Admins: Project Creation request: Cronos (WMCH) - https://phabricator.wikimedia.org/T252768 (10valerio.bozzolan) [12:41:05] (03CR) 10Lars Wirzenius: "> Patch Set 1: Code-Review+1" [tools/scap] - 10https://gerrit.wikimedia.org/r/596191 (owner: 10Lars Wirzenius) [12:42:01] (03CR) 10Lars Wirzenius: "The timings are with the version in PS2, btw." [tools/scap] - 10https://gerrit.wikimedia.org/r/596191 (owner: 10Lars Wirzenius) [12:49:52] 10Project-Admins: Project Creation request: Cronos (WMCH) - https://phabricator.wikimedia.org/T252768 (10valerio.bozzolan) [12:57:46] 10Project-Admins: Project Creation request: Cronos (WMCH) - https://phabricator.wikimedia.org/T252768 (10valerio.bozzolan) [12:58:56] Reedy: made the task description less confusing for people who could do with friday off [13:10:41] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:11:07] James_F: https://phabricator.wikimedia.org/T252770#6136845 [13:12:02] Just SWAT it [13:13:04] Reedy: after their reply, I'm highly inclined to not rush. [13:13:11] Quite :) [13:13:22] If it was completely broken or something, sure [13:13:26] But this is very much a vanity change [13:14:03] Reedy: I'll let them know and do the late one with my other config patch [13:47:19] 10Release-Engineering-Team, 10Readers-Web-Backlog, 10Vector: [CI] Replace npm-test job with npm-test + MediaWiki Core - https://phabricator.wikimedia.org/T252772 (10Niedzielski) [13:51:47] 10Release-Engineering-Team, 10Readers-Web-Backlog, 10Vector: [CI] Replace npm-test job with npm-test + MediaWiki Core - https://phabricator.wikimedia.org/T252772 (10Niedzielski) [15:05:03] 10Phabricator, 10Security-Team, 10PM: Add OIT to author affiliation drop down - https://phabricator.wikimedia.org/T252778 (10chasemp) [15:05:35] 10Phabricator, 10Security-Team, 10PM: Add OIT to author affiliation drop down - https://phabricator.wikimedia.org/T252778 (10chasemp) 05Open→03Resolved done [15:09:11] 10Phabricator, 10RelEng-Archive-FY201718-Q2, 10Patch-For-Review: Enable notification server (real-time pop-up notifications) in Phabricator - https://phabricator.wikimedia.org/T765 (10mmodell) [15:09:17] 10Phabricator, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, 10Traffic, and 2 others: Phabricator downtime due to aphlict and websockets (aphlict current disabled) - https://phabricator.wikimedia.org/T238593 (10mmodell) 05Open→03Stalled a:05mmodell→03None I am currently u... [15:51:42] 10Gerrit: Rename Gerrit repository "LdapGroups" to "LDAPGroups" - https://phabricator.wikimedia.org/T200736 (10dev-zero) for some reason is the GitHub mirror for LDAPGroups now also archived [16:10:30] hello! Is there a way to get stuff into deployment-prep's hiera without using horizon? I have a service configuration that I suspect is too large to POST to horizon [16:11:30] local puppetmaster patch? [16:29:44] 10Project-Admins, 10User-Zoranzoki21: Project Creation request: Cronos (WMCH) - https://phabricator.wikimedia.org/T252768 (10Zoranzoki21) 05Open→03Resolved a:03Zoranzoki21 Requested public project #wmch-cronos has been created: https://phabricator.wikimedia.org/project/view/4782/ Please encourage intere... [16:43:43] Reedy: how do you mean? local stuff in the client hiera datadir or something else? [16:44:00] Yeah [17:02:46] (03CR) 10Umherirrender: Full rewrite of the UnusedUseStatementSniff, 4x faster (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [17:11:30] (03CR) 10Umherirrender: "There is already a SpaceAfterClosureSniff to check closures." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [17:13:19] hnowlan: too large to post to horizon is an interesting bug if you have found that. Are you needing megabytes of yaml to configure your service? [17:15:20] hnowlan: hiera on a deployment-prep Cloud VPS instance also reads from files in hieradata/cloud/eqiad1/deployment-prep/ of operations/puppet.git. Just a bit more annoying for most folks to update as it requires a root +2 to deploy a change [17:18:16] (03CR) 10Thiemo Kreuz (WMDE): Full rewrite of the UnusedUseStatementSniff, 4x faster (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [17:19:21] bd808: I'm not certain that's what it is (and if that is what I'm hitting I'd say it's more likely to be some kind of limit elsewhere in the stack rather than horizon itself), but when I try to add stuff incrementally to the minimal base config I initially added I get "Danger: There was an error submitting the form" in the UI and a 500 on the request [17:19:33] but that said, it's only a 60KB config file [17:20:01] but if I can go directly via git that would be much better [17:33:40] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10hashar) [18:11:12] hnowlan: somewhat late reply -- you may have found what you needed, but if not: the deployment-prep puppetmaster is deployment-puppetmaster04.deployment-prep.eqiad.wmflabs you can cherry-pick there as bd808 mentioned. We use the tag in gerrit "beta-cherry-picked" to track what's cherry picked there. https://gerrit.wikimedia.org/r/#/q/hashtag:%22beta-cherry-picked%22 [18:35:49] 10Continuous-Integration-Config: Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10hashar) The blue code-review +2 button is a feature known as //quick approval// in Gerrit. It shows up when there is one label left without the maximum sco... [18:35:58] 10Continuous-Integration-Config: Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10hashar) p:05Triage→03Medium [18:36:13] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10hashar) [19:06:50] 10phan, 10phan-taint-check-plugin: Phan complains about a numeric input - https://phabricator.wikimedia.org/T252809 (10Huji) [19:07:21] 10phan, 10phan-taint-check-plugin: Phan complains about a numeric input - https://phabricator.wikimedia.org/T252809 (10Huji) [19:07:38] 10phan-taint-check-plugin, 10Upstream: Allow to print taint of variable when using taint-check plugin - https://phabricator.wikimedia.org/T252261 (10Daimona) Yeah I've been thinking about this for a while. Perhaps phan could have a Capability interface for plugins to use so they can add debug data. Taint-check... [19:17:53] 10phan-taint-check-plugin, 10Upstream: Allow to print taint of variable when using taint-check plugin - https://phabricator.wikimedia.org/T252261 (10Daimona) https://github.com/phan/phan/issues/3911 [19:18:22] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10matmarex) [19:21:35] 10phan: Phan complains about a numeric input - https://phabricator.wikimedia.org/T252809 (10Daimona) Phan complains because `$user_id` can potentially be null, but addWhereFld doesn't take null, so phan would theoretically be right here. However, as you noticed, it cannot infer from the if above that the null ca... [19:50:24] 10phan: Phan complains about a numeric input - https://phabricator.wikimedia.org/T252809 (10Huji) [19:50:27] 10phan, 10Upstream: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Huji) [20:18:32] 10Release-Engineering-Team: Docker registry not updating when a tag is pushed to Gerrit - https://phabricator.wikimedia.org/T233259 (10thcipriani) 05Open→03Resolved a:03thcipriani Sorry for the delay on reply. It looks like the latest tag v1.0.6 exists (https://tools.wmflabs.org/dockerregistry/wikimedia/me... [20:19:18] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10hashar) [20:26:44] 10Continuous-Integration-Config, 10Growth-Team, 10GrowthExperiments: banana:docs fails on user-provided string - https://phabricator.wikimedia.org/T252823 (10Tgr) [20:27:50] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10Bugreporter) [20:29:26] 10Continuous-Integration-Config, 10Growth-Team, 10GrowthExperiments, 10Patch-For-Review: banana:docs fails on user-provided string - https://phabricator.wikimedia.org/T252823 (10Tgr) [21:38:17] 10Release-Engineering-Team, 10Readers-Web-Backlog, 10Vector: [CI] Replace npm-test job with npm-test + MediaWiki Core - https://phabricator.wikimedia.org/T252772 (10Krinkle) > In general, `ls ../../resources/src` from an NPM script returns all the usual mediawiki.* files. The intent behind this is fine, bu... [22:08:11] Do you feel zuul is being slower than usual? Or it is just me? [22:08:59] It wasn't for core earlier but that was this morning. Core is fairly slow anyway. [22:09:36] I think I read there was some maintenance ongoing so it might be that [22:12:02] (03CR) 10Jforrester: [C: 03+2] fix(debian): put back the build-dependency on bash-completion [tools/scap] - 10https://gerrit.wikimedia.org/r/596406 (owner: 10Lars Wirzenius) [22:12:48] hauskatze: that was hashar and https://phabricator.wikimedia.org/T224591 based on my email [22:13:39] hauskatze: https://lists.wikimedia.org/pipermail/wikitech-l/2020-May/093379.html [22:13:42] RhinosF1: yes, I think that was the email I read as well, but I closed my mail client a while ago and was too lazy to re-open [22:14:01] (03Merged) 10jenkins-bot: fix(debian): put back the build-dependency on bash-completion [tools/scap] - 10https://gerrit.wikimedia.org/r/596406 (owner: 10Lars Wirzenius) [22:14:05] hauskatze: heh [22:14:29] I've only got mine open as if I close it for too long I'd spend a day checking emails! [22:21:26] I still prefer regular post for correspondence [22:23:12] hauskatze: I rarely get post. [22:23:25] Important bank stuff is about it now [22:24:29] RhinosF1: Yeah, bank stuff and the bills... I'd not mind *not* receiving those heh [22:25:13] hauskatze: I'd love it if someone either forget to send a bill or someone else paid for once [22:27:49] hauskatze: If I get something for me, I normally end up with the least of it [22:50:56] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Make test pipline vote Verified+1 instead of +2 to avoid unintentional submit - https://phabricator.wikimedia.org/T226123 (10Krinkle) > * some repositories / branche...