[01:08:12] 10Release-Engineering-Team, 10Readers-Web-Backlog, 10Vector: [CI] Replace npm-test job with npm-test + MediaWiki Core - https://phabricator.wikimedia.org/T252772 (10Niedzielski) `MW_INSTALL_PATH` would work well for the shell script, thank you. Unfortunately, [[ https://github.com/Microsoft/TypeScript/issues... [08:51:29] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) Next up... For core, 1m30s out of 3m30s are spent on markAllDependentVarsYes. Not sure what the best solution would be... [10:07:19] 10Phabricator: Restore old "merged" icon in Maniphest's Gerrit info block - https://phabricator.wikimedia.org/T252866 (10Tgr) [10:10:17] 10Phabricator: Restore old "merged" icon in Maniphest's Gerrit info block - https://phabricator.wikimedia.org/T252866 (10Tgr) On a side note, the unresolved comment count (is that new, or have I just not payed attention before?) is pretty cool. Thanks for working on that! [10:37:09] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) Fails today again [10:41:37] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Zoranzoki21) 05Declined→03Open (per previous comment) [10:42:03] (03PS1) 10Robert Vogel: Add new extension `FlexiSkin`:wq [integration/config] - 10https://gerrit.wikimedia.org/r/596623 [10:42:36] (03PS2) 10Robert Vogel: Add new extension `FlexiSkin` [integration/config] - 10https://gerrit.wikimedia.org/r/596623 [11:01:15] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Dzahn) [12:25:22] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dzahn) There was no ongoing work today that i am aware of. So this should have a different cause. [12:25:59] James_F: that ticket makes it sound as if we had CI maintenance again but i am not aware of anything today [12:26:41] looking at contint to see if zuul and friends is running [12:43:55] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) It seems it happens randomly for random patchset/merge/postmerge [12:47:52] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dzahn) I added "recheck" on https://gerrit.wikimedia.org/r/c/pywikibot/core/+/595213/3 and i got a jen... [12:49:04] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) You can see patchsets in https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/584896/ for example [12:54:57] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dzahn) That example also seems to show it working 2 and the result being added 2 minutes after uploadi... [13:06:40] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) >>! In T252310#6140359, @Dzahn wrote: > That example also seems to show it working and the re... [13:22:16] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dzahn) >>! In T252310#6140362, @Dvorapa wrote: > It would also show "Cannot Merge" if it would be reba... [13:34:26] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) I would wait for some next occurence. I didn't want this to be reopened as there is currently... [13:40:45] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dzahn) p:05High→03Medium Ok, let's keep it open but lower prio from High to Medium, i propose. [13:40:53] 10Diffusion, 10Phabricator (Upstream), 10Upstream: Phabricator diffs for changes in a list of items makes it hard to find differences - https://phabricator.wikimedia.org/T212658 (10Aklapper) 05Open→03Resolved Thanks for retesting! [14:06:45] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Dzahn) After talking with qchris I have rsynced /srv/gerrit/git and /var/l... [15:23:09] (03PS1) 10Jforrester: Follow-up ccb797c94: Drop not-php74 reference from tests [integration/config] - 10https://gerrit.wikimedia.org/r/596664 [15:23:11] (03PS1) 10Jforrester: layout: Always split out the selenium run into their own jobs [integration/config] - 10https://gerrit.wikimedia.org/r/596665 [15:23:13] (03PS1) 10Jforrester: layout: Don't use extension-quibble-only-selenium, no-op [integration/config] - 10https://gerrit.wikimedia.org/r/596666 [15:23:15] (03PS1) 10Jforrester: layout: Drop extension-quibble-only-selenium, unused [integration/config] - 10https://gerrit.wikimedia.org/r/596667 [15:23:17] (03PS1) 10Jforrester: jjb: [WIP] Rename and simplify all the quibble jobs into one set [integration/config] - 10https://gerrit.wikimedia.org/r/596668 [15:24:14] (03CR) 10Jforrester: [C: 03+2] Follow-up ccb797c94: Drop not-php74 reference from tests [integration/config] - 10https://gerrit.wikimedia.org/r/596664 (owner: 10Jforrester) [15:24:26] (03CR) 10jerkins-bot: [V: 04-1] layout: Don't use extension-quibble-only-selenium, no-op [integration/config] - 10https://gerrit.wikimedia.org/r/596666 (owner: 10Jforrester) [15:24:36] (03CR) 10jerkins-bot: [V: 04-1] layout: Drop extension-quibble-only-selenium, unused [integration/config] - 10https://gerrit.wikimedia.org/r/596667 (owner: 10Jforrester) [15:24:49] (03CR) 10jerkins-bot: [V: 04-1] jjb: [WIP] Rename and simplify all the quibble jobs into one set [integration/config] - 10https://gerrit.wikimedia.org/r/596668 (owner: 10Jforrester) [15:25:12] (03Merged) 10jenkins-bot: Follow-up ccb797c94: Drop not-php74 reference from tests [integration/config] - 10https://gerrit.wikimedia.org/r/596664 (owner: 10Jforrester) [15:36:30] (03PS2) 10Jforrester: layout: Don't use extension-quibble-only-selenium, no-op [integration/config] - 10https://gerrit.wikimedia.org/r/596666 [15:36:32] (03PS2) 10Jforrester: layout: Drop extension-quibble-only-selenium, unused [integration/config] - 10https://gerrit.wikimedia.org/r/596667 [15:36:34] (03PS2) 10Jforrester: jjb: [WIP] Rename and simplify all the quibble jobs into one set [integration/config] - 10https://gerrit.wikimedia.org/r/596668 [15:36:58] (03CR) 10Krinkle: [C: 03+1] layout: Always split out the selenium run into their own jobs (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/596665 (owner: 10Jforrester) [15:37:40] (03CR) 10jerkins-bot: [V: 04-1] layout: Don't use extension-quibble-only-selenium, no-op [integration/config] - 10https://gerrit.wikimedia.org/r/596666 (owner: 10Jforrester) [15:37:46] (03CR) 10jerkins-bot: [V: 04-1] jjb: [WIP] Rename and simplify all the quibble jobs into one set [integration/config] - 10https://gerrit.wikimedia.org/r/596668 (owner: 10Jforrester) [15:37:48] (03CR) 10jerkins-bot: [V: 04-1] layout: Drop extension-quibble-only-selenium, unused [integration/config] - 10https://gerrit.wikimedia.org/r/596667 (owner: 10Jforrester) [16:08:25] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Xqt) again with https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/596644/ PS 5 [16:22:15] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10User-brennen: Add branch committers to train task - https://phabricator.wikimedia.org/T203111 (10brennen) [16:38:27] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) >>! In T203651#6139771, @Daimona wrote: > Next up... For core, 1m30s out of 3m30s are spent on markAllDependentVarsYes. Not sure what the best solution would be... This turns out to be nontrivial.... [16:47:21] (03CR) 10Umherirrender: [C: 03+1] Full rewrite of the UnusedUseStatementSniff, 4x faster (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [17:05:51] What happens with the train still blocked as rel eng are off site next week? Does that mean it won’t proceed until 24th ? [17:10:13] Error fetching URL "https://deployment-echostore01.deployment-prep.eqiad.wmflabs:8080/echoseen/v1/global%3Aecho%3Aseen%3Amessage%3Atime%3A17": (curl error: 35) SSL connect error [17:11:22] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) >>! In T203651#6140825, @Daimona wrote: > Additionally, the "compromise" can be modified in the following way: if the property belongs to the class we're currently inside (i.e. we're probably analyz... [17:17:30] Krinkle: Where did you get that? [17:19:54] (03PS1) 10Jforrester: layout: Add CI for mediawiki/extensions/PageExchange [integration/config] - 10https://gerrit.wikimedia.org/r/596697 (https://phabricator.wikimedia.org/T252473) [17:20:27] (03CR) 10Jforrester: [C: 03+2] layout: Add CI for mediawiki/extensions/PageExchange [integration/config] - 10https://gerrit.wikimedia.org/r/596697 (https://phabricator.wikimedia.org/T252473) (owner: 10Jforrester) [17:21:20] (03Merged) 10jenkins-bot: layout: Add CI for mediawiki/extensions/PageExchange [integration/config] - 10https://gerrit.wikimedia.org/r/596697 (https://phabricator.wikimedia.org/T252473) (owner: 10Jforrester) [17:21:49] !log Zuul: Add CI for mediawiki/extensions/PageExchange T252473 [17:21:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:21:53] T252473: [Page Exchange] Add Jenkins monitoring to new Page Exchange extension - https://phabricator.wikimedia.org/T252473 [17:23:33] 10Continuous-Integration-Config, 10MediaWiki-extensions-Other, 10Patch-For-Review: [Page Exchange] Add Jenkins monitoring to new Page Exchange extension - https://phabricator.wikimedia.org/T252473 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF Done. If you need the CI tweaking (e.g. to drop... [17:24:29] 10Continuous-Integration-Config: Provide a PHP code coverage job for mediawiki/libs/* (non-MW context) - https://phabricator.wikimedia.org/T252120 (10Jdforrester-WMF) [17:24:29] James_F: logstash-beta, it seems echostore isnt/ wired up rightr [17:24:31] (or down) [17:25:40] It's plausible it never worked? BC is such a mess. [17:26:23] 10Beta-Cluster-Infrastructure, 10Core Platform Team, 10Growth-Team, 10Notifications: echostore connection error in Beta Cluster - https://phabricator.wikimedia.org/T252898 (10Krinkle) [17:27:35] 10Continuous-Integration-Config, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Team: Add TwoColConflict to the "gated" extensions list in core - https://phabricator.wikimedia.org/T251276 (10Jdforrester-WMF) Per https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/67170/testReport/ thi... [17:28:08] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Determine purpose of deployment-memc0[67] - https://phabricator.wikimedia.org/T250585 (10Krinkle) `name=From openstack-browser deployment-memc04.deployment-prep.eqiad.wmflabs 172.16.5.76 deployment-memc05.deployment-prep.eqiad.wmflabs 17... [17:33:53] (03PS1) 10Jforrester: gate: Add BetaFeatures [integration/config] - 10https://gerrit.wikimedia.org/r/596707 (https://phabricator.wikimedia.org/T249674) [17:33:55] (03PS1) 10Jforrester: gate: Add TwoColConflict [integration/config] - 10https://gerrit.wikimedia.org/r/596708 (https://phabricator.wikimedia.org/T251276) [17:34:07] 10Continuous-Integration-Config, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Team, 10Patch-For-Review: Add TwoColConflict to the "gated" extensions list in core - https://phabricator.wikimedia.org/T251276 (10Jdforrester-WMF) We have BetaFeatures, EventLogging, and WikiEditor as CI injected dependencies... [17:35:38] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) @Jdforrester-WMF This is not Pywikibot issue, so at least one releng tag needs to stay here (... [17:41:27] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Jdforrester-WMF) If you code isn't up to date with master, CI tries to rebase it for you (inside `zuul... [17:45:09] (03CR) 10Jforrester: [C: 03+2] gate: Add BetaFeatures [integration/config] - 10https://gerrit.wikimedia.org/r/596707 (https://phabricator.wikimedia.org/T249674) (owner: 10Jforrester) [17:47:33] (03Merged) 10jenkins-bot: gate: Add BetaFeatures [integration/config] - 10https://gerrit.wikimedia.org/r/596707 (https://phabricator.wikimedia.org/T249674) (owner: 10Jforrester) [17:48:07] !log Zuul: Add BetaFeatures to the gate T249674 [17:48:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:48:09] T249674: Have all Wikimedia production extensions and skins in the CI gate - https://phabricator.wikimedia.org/T249674 [17:49:50] (03PS4) 10DannyS712: FunctionCommentSniff: Move some sniffs to new ProperDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [17:50:34] (03PS5) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [17:50:57] (03CR) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [17:51:49] (03PS7) 10DannyS712: Move FunctionCommentSniff annotation checks to FunctionAnnotationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593746 (https://phabricator.wikimedia.org/T250958) [17:51:53] (03PS9) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptySeeSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) [17:51:57] (03PS6) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [17:59:56] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) In the last patch linked here, it is failing to merge and after "recheck", it merges perfectl... [18:04:48] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Epic, 10Patch-For-Review: Have all Wikimedia production extensions and skins in the CI gate - https://phabricator.wikimedia.org/T249674 (10Jdforrester-WMF) [18:19:57] (03CR) 10Jforrester: [C: 03+2] gate: Add TwoColConflict [integration/config] - 10https://gerrit.wikimedia.org/r/596708 (https://phabricator.wikimedia.org/T251276) (owner: 10Jforrester) [18:20:51] (03Merged) 10jenkins-bot: gate: Add TwoColConflict [integration/config] - 10https://gerrit.wikimedia.org/r/596708 (https://phabricator.wikimedia.org/T251276) (owner: 10Jforrester) [18:21:23] !log Zuul: Add TwoColConflict to the gate T251276 [18:21:25] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:21:26] T251276: Add TwoColConflict to the "gated" extensions list in core - https://phabricator.wikimedia.org/T251276 [18:42:57] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10Krinkle) [18:56:22] 10Continuous-Integration-Config, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Team, 10Patch-For-Review: Add TwoColConflict to the "gated" extensions list in core - https://phabricator.wikimedia.org/T251276 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF OK, this seems like it hasn't brok... [18:56:24] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Epic: Have all Wikimedia production extensions and skins in the CI gate - https://phabricator.wikimedia.org/T249674 (10Jdforrester-WMF) [18:56:31] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Epic: Have all Wikimedia production extensions and skins in the CI gate - https://phabricator.wikimedia.org/T249674 (10Jdforrester-WMF) [19:07:54] 10Continuous-Integration-Config, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Team, 10Patch-For-Review: Add TwoColConflict to the "gated" extensions list in core - https://phabricator.wikimedia.org/T251276 (10thiemowmde) Amazing, thanks a lot! > We have BetaFeatures, EventLogging, and WikiEditor as CI... [19:08:27] 10Continuous-Integration-Config, 10Two-Column-Edit-Conflict-Merge, 10WMDE-QWERTY-Team, 10Patch-For-Review, 10WMDE-QWERTY-Sprint-2020-05-13: Add TwoColConflict to the "gated" extensions list in core - https://phabricator.wikimedia.org/T251276 (10thiemowmde) [19:15:42] (03CR) 10Jforrester: [C: 03+2] Stop branching ParsoidBatchAPI [tools/release] - 10https://gerrit.wikimedia.org/r/563462 (https://phabricator.wikimedia.org/T242430) (owner: 10Reedy) [19:16:37] (03Merged) 10jenkins-bot: Stop branching ParsoidBatchAPI [tools/release] - 10https://gerrit.wikimedia.org/r/563462 (https://phabricator.wikimedia.org/T242430) (owner: 10Reedy) [19:20:48] (03PS3) 10Jforrester: Add new extension `FlexiSkin` [integration/config] - 10https://gerrit.wikimedia.org/r/596623 (owner: 10Robert Vogel) [19:20:53] (03CR) 10Jforrester: [C: 03+2] Add new extension `FlexiSkin` [integration/config] - 10https://gerrit.wikimedia.org/r/596623 (owner: 10Robert Vogel) [19:21:51] (03Merged) 10jenkins-bot: Add new extension `FlexiSkin` [integration/config] - 10https://gerrit.wikimedia.org/r/596623 (owner: 10Robert Vogel) [19:23:06] !log Zuul: Add CI for mediawiki/extensions/FlexiSkin [19:23:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:23:39] (03PS2) 10Jforrester: layout: Always split out the selenium run into their own jobs [integration/config] - 10https://gerrit.wikimedia.org/r/596665 [19:26:00] (03CR) 10Jforrester: [C: 03+2] layout: Always split out the selenium run into their own jobs [integration/config] - 10https://gerrit.wikimedia.org/r/596665 (owner: 10Jforrester) [19:26:53] (03Merged) 10jenkins-bot: layout: Always split out the selenium run into their own jobs [integration/config] - 10https://gerrit.wikimedia.org/r/596665 (owner: 10Jforrester) [19:27:32] (03CR) 10Umherirrender: [C: 03+2] "Runs without errors on core, skins or extensions. Let's do improvements in separate patch sets" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [19:27:37] (03PS3) 10Jforrester: layout: Don't use extension-quibble-only-selenium, no-op [integration/config] - 10https://gerrit.wikimedia.org/r/596666 [19:27:57] !log Zuul: Always split out the selenium run into their own jobs [19:27:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:28:16] (03Merged) 10jenkins-bot: Full rewrite of the UnusedUseStatementSniff, 4x faster [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [19:29:18] (03CR) 10Jforrester: [C: 03+2] layout: Don't use extension-quibble-only-selenium, no-op [integration/config] - 10https://gerrit.wikimedia.org/r/596666 (owner: 10Jforrester) [19:29:22] (03PS3) 10Jforrester: layout: Drop extension-quibble-only-selenium, unused [integration/config] - 10https://gerrit.wikimedia.org/r/596667 [19:30:15] (03Merged) 10jenkins-bot: layout: Don't use extension-quibble-only-selenium, no-op [integration/config] - 10https://gerrit.wikimedia.org/r/596666 (owner: 10Jforrester) [19:30:36] !log Zuul: Collapse extension-quibble-only-selenium users back into extension-quibble now it's split [19:30:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:30:47] (03CR) 10Jforrester: [C: 03+2] layout: Drop extension-quibble-only-selenium, unused [integration/config] - 10https://gerrit.wikimedia.org/r/596667 (owner: 10Jforrester) [19:31:41] (03Merged) 10jenkins-bot: layout: Drop extension-quibble-only-selenium, unused [integration/config] - 10https://gerrit.wikimedia.org/r/596667 (owner: 10Jforrester) [19:34:53] (03PS3) 10Jforrester: jjb: [WIP] Rename and simplify all the quibble jobs into one set [integration/config] - 10https://gerrit.wikimedia.org/r/596668 [19:35:50] (03CR) 10jerkins-bot: [V: 04-1] jjb: [WIP] Rename and simplify all the quibble jobs into one set [integration/config] - 10https://gerrit.wikimedia.org/r/596668 (owner: 10Jforrester) [19:54:46] (03PS1) 10Umherirrender: Fix unused use statement sniff for complex @phan-var [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596741 [20:06:13] (03PS10) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) [20:08:13] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) [20:08:53] (03PS11) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) [20:09:51] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) @Umherirrender @thiemowmde thoughts on both requiring something after `@since` and other possible tags to include? [20:10:00] (03PS7) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [20:14:14] (03CR) 10jerkins-bot: [V: 04-1] FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [20:14:58] (03CR) 10DannyS712: "Recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [20:24:57] (03PS7) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [20:25:06] (03CR) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [20:26:18] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10DannyS712) >>! In T251443#6132200, @thiemowmde wrote: > Note this is not yet an "accepted rule change". I, personally, think it should be one.... [20:30:50] (03CR) 10jerkins-bot: [V: 04-1] Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [20:38:45] (03PS8) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [20:41:13] 10MediaWiki-Codesniffer, 10Technical-Debt: Warn when a method/class has a @deprecated annotation but no call to wfDeprecated - https://phabricator.wikimedia.org/T205938 (10DannyS712) Perhaps warn the other way? No `wfDeprecated` calls without `@deprecated` in the doc [20:43:49] (03CR) 10jerkins-bot: [V: 04-1] Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [20:45:02] (03PS9) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [21:41:45] (03PS1) 10Umherirrender: Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 [21:43:44] (03CR) 10Umherirrender: Full rewrite of the UnusedUseStatementSniff, 4x faster (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [21:46:48] (03CR) 10jerkins-bot: [V: 04-1] Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [21:50:27] (03PS2) 10Umherirrender: Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 [22:04:28] (03PS1) 10Umherirrender: Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 [22:13:23] (03PS1) 10Umherirrender: Enable PSR12.Functions.NullableTypeDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 [22:19:35] (03PS2) 10Umherirrender: Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 [22:22:57] (03PS3) 10Umherirrender: Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 [22:29:19] (03PS4) 10Umherirrender: Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 [22:33:34] (03PS3) 10Umherirrender: Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 [22:47:30] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10MediaWiki-Debug-Logger, 10Readers-Web-Backlog: Ensure flood of hard-deprecations are caught during (train) deployments - https://phabricator.wikimedia.org/T252923 (10Krinkle) [22:47:39] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10MediaWiki-Debug-Logger, 10Readers-Web-Backlog, 10Sustainability (Incident Prevention): Ensure flood of hard-deprecations are caught during (train) deployments - https://phabricator.wikimedia.org/T252923 (10Krinkle) [22:48:59] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10MediaWiki-Debug-Logger, 10Readers-Web-Backlog, 10Sustainability (Incident Prevention): Ensure flood of hard-deprecations are caught during (train) deployments - https://phabricator.wikimedia.org/T252923 (10Krinkle)