[02:24:31] (03PS1) 10Reedy: Add mediawiki/skins/WikimediaApiPortal to layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/596797 (https://phabricator.wikimedia.org/T247837) [02:25:45] (03CR) 10Reedy: "Deploying this is awkward, as it depends on a skin that isn't in gerrit so it's hard to add it as a dependancy..." [integration/config] - 10https://gerrit.wikimedia.org/r/596797 (https://phabricator.wikimedia.org/T247837) (owner: 10Reedy) [03:19:30] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Krinkle) [03:25:00] (03CR) 10Krinkle: [C: 04-1] "Vertical alignment in arrays is explicily called out in our coding conventions as something that's rare, but allowed at the author's discr" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592751 (https://phabricator.wikimedia.org/T232265) (owner: 10Umherirrender) [03:30:21] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Krinkle) @thiemowmde For sniffs that merekly help enforce pre-established/documented coding conventions I think accepti... [03:30:26] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Krinkle) p:05Triage→03Medium [08:10:46] (03CR) 10DannyS712: "Is there a bug for this?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (owner: 10Umherirrender) [08:11:00] (03CR) 10DannyS712: "Is there a bug for this?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 (owner: 10Umherirrender) [11:43:12] 10MediaWiki-Codesniffer, 10Technical-Debt: Warn when a method/class has a @deprecated annotation but no call to wfDeprecated - https://phabricator.wikimedia.org/T205938 (10thiemowmde) Personally, I think it's fine to have `@deprecated` without `wfDeprecated()`. I think this is still useful. Sure, it's a very "... [12:06:11] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10thiemowmde) Sure. I reviewed the list we currently have in the FunctionAnnotationsSniff, and would suggest the following: Strict errors: *... [12:14:21] (03PS2) 10Thiemo Kreuz (WMDE): Fix unused use statement sniff for complex @phan-var [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596741 (owner: 10Umherirrender) [12:21:21] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I did a very minor update in patch set 2. Otherwise I'm very happy with this addition!" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596741 (owner: 10Umherirrender) [12:42:49] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Cleanup CI puppet manifests - https://phabricator.wikimedia.org/T252942 (10hashar) [12:44:09] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Cleanup CI puppet manifests - https://phabricator.wikimedia.org/T252942 (10hashar) a:03hashar [12:48:41] (03CR) 10Thiemo Kreuz (WMDE): "Thanks for the merge! It makes me very happy to report that this is now the 2nd slowest custom sniff we have, according to my test run on " (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [15:32:32] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) Other ideas I've been trying: - Analyze the whole class if it has less than X methods. X=10 has no impact on core; X=30 has almost the same performance as the original "compromise", but catches 5-1... [16:01:45] (03CR) 10Umherirrender: "Thanks. I am okay with your changes to the regex pattern." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596741 (owner: 10Umherirrender) [16:57:04] 10MediaWiki-Codesniffer, 10Wikidata: Consider adding bash scripts to mediawiki-codesniffer for only running on touched files - https://phabricator.wikimedia.org/T251533 (10Umherirrender) There is a bootstrap for use of CI/jenkins, but such a way has limitation, see T247209 [17:30:39] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Aklapper) [17:31:41] 10phan-taint-check-plugin: Report implicit or explict usage of Message::__toString in the phan-taint-check-plugin - https://phabricator.wikimedia.org/T252946 (10Umherirrender) [17:35:44] 10MediaWiki-Codesniffer: Codesniffer should check that nullable typehints are lacking superfluous whitespace - https://phabricator.wikimedia.org/T252947 (10Umherirrender) [17:35:52] (03PS2) 10Umherirrender: Enable PSR12.Functions.NullableTypeDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) [17:47:55] 10MediaWiki-Codesniffer: Codesniffer should check the whitespace in use statements for traits - https://phabricator.wikimedia.org/T252948 (10Umherirrender) [17:48:07] (03PS5) 10Umherirrender: Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 (https://phabricator.wikimedia.org/T252948) [19:18:04] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) `@param`, `@return`, and `@throws` should already be covered by the FunctionCommentSniff [19:32:05] 10Phabricator, 10User-Josve05a: My profile picture on Phabricator looks wierd - https://phabricator.wikimedia.org/T235348 (10Aklapper) @Josve05a: Does this also happen in Chrome? Have you found any pattern (assuming this still happens)? [20:39:42] 10phan: New version 2.7.1 available for phan for use in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Umherirrender) Version 2.7.2 released - https://github.com/phan/phan/releases/tag/2.7.2 And phan has a major release 3.0.0 released - https://github.com/phan/phan/releases/tag/3.0.0 [20:41:35] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff to warn when public methods lack `@since` - https://phabricator.wikimedia.org/T251785 (10Umherirrender) If the class holds a @since it should be okay also for the function (similar to @covers in unit tests) [20:44:36] 10MediaWiki-Codesniffer: MediaWiki.Commenting.DocComment.SyntaxAlignedDocStar issue - https://phabricator.wikimedia.org/T251248 (10Umherirrender) Not covered by `Generic.WhiteSpace.DisallowSpaceIndent` [20:52:23] (03PS1) 10Umherirrender: Fix use of const and function imports in unsorted statement sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 [20:58:22] (03Abandoned) 10Awight: Lint at 99 columns [integration/quibble] - 10https://gerrit.wikimedia.org/r/591007 (owner: 10Awight) [21:05:49] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff to warn when public methods lack `@since` - https://phabricator.wikimedia.org/T251785 (10DannyS712) >>! In T251785#6142596, @Umherirrender wrote: > If the class holds a @since it should be okay also for the function (similar to @covers in unit tests) Sure... [21:13:24] (03PS1) 10Umherirrender: Add test for SpaceAfterControlStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596822 [21:23:35] 10phan: Upgrade to phan/phan 2.7.2 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Reedy) [21:40:18] (03PS1) 10Umherirrender: Simplify IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596825 [22:20:51] (03PS1) 10Umherirrender: Add test case for !is_null and parentheses must be kept [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596829 [22:21:21] (03PS2) 10Umherirrender: Add test case for !is_null and parentheses must be kept [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596829 [22:42:04] (03CR) 10Umherirrender: "When no interaction is wanted between FunctionAnnotationSniff and FunctionCommentSniff the tests should be moved to the correct test file " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593746 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [22:45:07] (03Abandoned) 10Umherirrender: Move fix of typo annotations to FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592277 (owner: 10Umherirrender) [22:58:15] (03PS1) 10Umherirrender: Include += in PlusStringConcatSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596830 [22:59:19] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Technical-Debt: Clear out unused integration/jenkins.git "slave" scripts - https://phabricator.wikimedia.org/T252955 (10Krinkle) [23:00:28] (03CR) 10DannyS712: "> When no interaction is wanted between FunctionAnnotationSniff and" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593746 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [23:08:39] (03PS1) 10Krinkle: jjb: Avoid global agent scripts in 'beta-update-databases-eqiad' job [integration/config] - 10https://gerrit.wikimedia.org/r/596831 (https://phabricator.wikimedia.org/T252955) [23:09:22] (03CR) 10jerkins-bot: [V: 04-1] jjb: Avoid global agent scripts in 'beta-update-databases-eqiad' job [integration/config] - 10https://gerrit.wikimedia.org/r/596831 (https://phabricator.wikimedia.org/T252955) (owner: 10Krinkle) [23:10:49] (03PS2) 10Krinkle: jjb: Avoid global agent scripts in 'beta-update-databases-eqiad' job [integration/config] - 10https://gerrit.wikimedia.org/r/596831 (https://phabricator.wikimedia.org/T252955) [23:17:02] (03CR) 10Krinkle: [C: 03+2] jjb: Avoid global agent scripts in 'beta-update-databases-eqiad' job [integration/config] - 10https://gerrit.wikimedia.org/r/596831 (https://phabricator.wikimedia.org/T252955) (owner: 10Krinkle) [23:18:00] (03Merged) 10jenkins-bot: jjb: Avoid global agent scripts in 'beta-update-databases-eqiad' job [integration/config] - 10https://gerrit.wikimedia.org/r/596831 (https://phabricator.wikimedia.org/T252955) (owner: 10Krinkle) [23:18:18] (03PS1) 10Krinkle: jjb: remove unused checkout-branch.bash file [integration/config] - 10https://gerrit.wikimedia.org/r/596832 (https://phabricator.wikimedia.org/T252955) [23:25:10] (03CR) 10Krinkle: [C: 03+2] jjb: remove unused checkout-branch.bash file [integration/config] - 10https://gerrit.wikimedia.org/r/596832 (https://phabricator.wikimedia.org/T252955) (owner: 10Krinkle) [23:26:04] (03Merged) 10jenkins-bot: jjb: remove unused checkout-branch.bash file [integration/config] - 10https://gerrit.wikimedia.org/r/596832 (https://phabricator.wikimedia.org/T252955) (owner: 10Krinkle) [23:46:04] (03PS1) 10Krinkle: jjb: Remove mention of unused integration/jenkins file [integration/config] - 10https://gerrit.wikimedia.org/r/596835 (https://phabricator.wikimedia.org/T252955) [23:50:28] (03PS2) 10Krinkle: Remove mentions of unused integration/jenkins files [integration/config] - 10https://gerrit.wikimedia.org/r/596835 (https://phabricator.wikimedia.org/T252955)